Robert Sparks
338da98661
merged forward. Gave IAB same abilities as IESG.
...
- Legacy-Id: 19201
2021-07-06 20:19:12 +00:00
Robert Sparks
6b383255ad
Staging for merge forward
...
- Legacy-Id: 19199
2021-07-06 18:05:54 +00:00
Robert Sparks
688f938ce2
Merged in [19166] from krathnayake@ietf.org:
...
Use INTERNET_ALL_DRAFTS_ARCHIVE_DIR serve all IDs. Fixes #3308 and #3309 .
- Legacy-Id: 19171
Note: SVN reference [19166] has been migrated to Git commit 6b9f0887bb
2021-06-30 19:24:56 +00:00
Kesara Rathnayake
6b9f0887bb
Use INTERNET_ALL_DRAFTS_ARCHIVE_DIR serve all IDs. Fixes #3308 and #3309 . Commit ready for merge.
...
- Legacy-Id: 19166
2021-06-29 00:58:07 +00:00
Jennifer Richards
044293b4a9
Fix broken meeting materials button on upcoming meetings page. Fixes #3278 . Commit ready for merge.
...
- Legacy-Id: 19164
2021-06-28 18:57:20 +00:00
Robert Sparks
4dcd2cbaa6
Merged in [19104] from rjsparks@nostrum.com:
...
Allow people to volunteer for NomCom via the datatracker.
- Legacy-Id: 19109
Note: SVN reference [19104] has been migrated to Git commit 86102b9980
2021-06-10 23:12:01 +00:00
Robert Sparks
86102b9980
Allow people to volunteer for NomCom via the datatracker. Commit ready for merge.
...
- Legacy-Id: 19104
2021-06-10 20:35:50 +00:00
Robert Sparks
5f6816d742
Handle bare numbers and rfc names with a space for the /doc/html view. Fixes #1999 . Commit ready for merge.
...
- Legacy-Id: 19095
2021-06-07 21:25:42 +00:00
Robert Sparks
ea0c0e1ad1
Merged in [19081] from fenton@bluepopcorn.net:
...
Added IESG document state to review request information. Fixes #3235 .
- Legacy-Id: 19084
Note: SVN reference [19081] has been migrated to Git commit 6ec7347f8d
2021-06-04 22:47:03 +00:00
Jim Fenton
6ec7347f8d
Added IESG document state to review request information. Fixes #3235 . Commit ready for merge.
...
- Legacy-Id: 19081
2021-06-04 21:00:58 +00:00
Robert Sparks
11d420bf69
Merged in [19028] from jennifer@painless-security.com:
...
Accept 'None' when updating DocumentAuthor affiliation / country.
- Legacy-Id: 19062
Note: SVN reference [19028] has been migrated to Git commit 1155fb32f6
2021-06-02 18:09:54 +00:00
Jennifer Richards
1155fb32f6
Accept 'None' when updating DocumentAuthor affiliation / country. Commit ready for merge.
...
- Legacy-Id: 19028
2021-05-21 15:54:03 +00:00
Robert Sparks
65619f2fa8
guard docauthor fields. Commit ready to merge.
...
- Legacy-Id: 19026
2021-05-21 14:20:21 +00:00
Robert Sparks
602d138fa2
Merged in [18997] from rjsparks@nostrum.com:
...
Changes to reflect repository moves.
- Legacy-Id: 19006
Note: SVN reference [18997] has been migrated to Git commit ceb7121018f8dcb877c5777c487f6b49f49b70ed
2021-05-19 14:00:32 +00:00
Robert Sparks
4298cf08ab
Merged in [18995] from rjsparks@nostrum.com:
...
Link only to datatracker htmlization. Adjust mail-to-authors and mail-to-list. Fixes #3261 .
- Legacy-Id: 19005
Note: SVN reference [18995] has been migrated to Git commit 06a46567b2c5778465466285398a72a195c2f4a5
2021-05-19 13:49:46 +00:00
Jennifer Richards
6cf9eb8dd1
Allow secretariat to edit document author list. Fixes #3185 . Commit ready for merge.
...
- Legacy-Id: 18989
2021-05-11 18:40:28 +00:00
Robert Sparks
85bf8cc39c
Merged in [18975] from rjsparks@nostrum.com:
...
Add RFC 8989 nomcom eligibility calculations.
- Legacy-Id: 18980
Note: SVN reference [18975] has been migrated to Git commit fd38a9bf96
2021-05-07 19:37:28 +00:00
Robert Sparks
fe82f4d696
connect the new calculations to the UI. Clean flakes.
...
- Legacy-Id: 18974
2021-05-06 19:00:58 +00:00
Robert Sparks
216ec499df
Checkpointing. Remaining work: convert meetingregistation fixup to a migration and a mgmt comment. Flesh out testing of 8989 rule 2 and fix the known edge case bug. Remove old implementation and connect UI to the new implementation.
...
- Legacy-Id: 18971
2021-05-01 19:57:04 +00:00
Jennifer Richards
b08110b838
Allow external resources to be set/suggested during submission process. Fixes #3068 . Commit ready for merge.
...
- Legacy-Id: 18960
2021-04-19 20:21:19 +00:00
Robert Sparks
6d7a0b6d0f
Merged in [18939] from jennifer@painless-security.com:
...
Consolidate repeated searchable field code into SearchableField class. Fix single-valued searchable fields. Make javascript test config reusable. Use Django Form.media for JS/CSS inclusion. Fixes #3196 , #3204 .
- Legacy-Id: 18948
Note: SVN reference [18939] has been migrated to Git commit 17d37723f7
2021-04-12 22:07:03 +00:00
Robert Sparks
8dc76252eb
Merged in [18938] from rjsparks@nostrum.com:
...
Redirect requests for htmlized bcp or std subseries elements to the relevant rfc-editor info page. Fixes #3233 .
- Legacy-Id: 18947
Note: SVN reference [18938] has been migrated to Git commit 497a453a93376488caed154b0611dc21dd78b956
2021-04-12 19:01:51 +00:00
Robert Sparks
3b84ea6648
Merged in [18937] from rjsparks@nostrum.com:
...
Change the default behavior of a document's main page to show the
full document content. Users can still control whether the full
page is shown on a particular document by adding either
?include_text=0 or ?include_text=1 to the url. Users can also use
the settings page at /account/settings to override the default
behavior for all documents. Fixes #3252 .
- Legacy-Id: 18946
Note: SVN reference [18937] has been migrated to Git commit 7cb5fdafbf149eb67161fc8297f70ba208f05fe9
2021-04-12 18:24:58 +00:00
Jennifer Richards
17d37723f7
Consolidate repeated searchable field code into SearchableField class. Fix single-valued searchable fields. Make javascript test config reusable. Use Django Form.media for JS/CSS inclusion. Fixes #3196 , #3204 . Commit ready for merge.
...
- Legacy-Id: 18939
2021-04-09 15:18:11 +00:00
Robert Sparks
481fc3ff9d
Merged in [18913] from housley@vigilsec.com:
...
Convert generate-draft-aliaes and generate-wg-aliases into management commands: generate_draft_aliases and generate_group_aliases. Also provide tests for the new management commands.
- Legacy-Id: 18925
Note: SVN reference [18913] has been migrated to Git commit 45b14c83a7
2021-03-29 22:48:17 +00:00
Robert Sparks
ac6bcdab66
Merged in [18906] from housley@vigilsec.com:
...
Provide bibxml test for drafts that end in a hyphen and a digit.
- Legacy-Id: 18921
Note: SVN reference [18906] has been migrated to Git commit 469c67296e
2021-03-22 23:17:21 +00:00
Robert Sparks
e76d32e61b
Merged in [18905] from housley@vigilsec.com:
...
Point bibxml3 to I-D archive so that all version numbers are handled properly, and perform more robust revision suffix cleanup. Fixes #3188 .
- Legacy-Id: 18920
Note: SVN reference [18905] has been migrated to Git commit d42aab0d0a
2021-03-22 22:30:00 +00:00
Russ Housley
45b14c83a7
Convert generate-draft-aliaes and generate-wg-aliases into management commands: generate_draft_aliases and generate_group_aliases. Also provide tests for the new management commands.
...
- Legacy-Id: 18913
2021-03-13 17:30:35 +00:00
Russ Housley
469c67296e
Provide bibxml test for drafts that end in a hyphen and a digit.
...
- Legacy-Id: 18906
2021-03-08 13:51:38 +00:00
Russ Housley
d42aab0d0a
Point bibxml3 to I-D archive so that all version numbers are handled properly, and perform more robust revision suffix cleanup. Fixes #3188 .
...
- Legacy-Id: 18905
2021-03-06 23:30:13 +00:00
Robert Sparks
d13d878103
Only log an error for is_rfc vs canonical_name mismatch for Document objects - it's OK for DocHistory to have the mismatch given how DocHistory computes is_rfc()
...
- Legacy-Id: 18903
2021-03-06 16:18:01 +00:00
Robert Sparks
67456530e4
Merged in [18858] and [18875] from kivinen@iki.fi:
...
Remove the automatic redirect from latest version to page without version number (also from tests), and made sure when viewing old snapshot which also happens to be last revision for draft where we have rfc, we show information from the draft, not from the rfc. Fixes issue #3162 .
- Legacy-Id: 18882
Note: SVN reference [18858] has been migrated to Git commit 84a25ed491
Note: SVN reference [18875] has been migrated to Git commit fedab94d3d
2021-03-03 17:11:13 +00:00
Robert Sparks
7cd52f4d81
Merged in [18869] from rjsparks@nostrum.com:
...
Display htmlized pages much more like tools.ietf.org.
- Legacy-Id: 18880
Note: SVN reference [18869] has been migrated to Git commit b075c2dca8
2021-03-03 15:40:55 +00:00
Robert Sparks
fa0826f860
Merged in [18862] from peter@akayla.com:
...
Modifies stream name descriptions and changes document page to use the description instead of the stream name. Fixes issue 3169.
- Legacy-Id: 18879
Note: SVN reference [18862] has been migrated to Git commit 12a5e04689
2021-03-02 23:33:48 +00:00
Tero Kivinen
fedab94d3d
Fix the format links to point to correct location when latest snapshot
...
is used, also corrects the versions links at the top.
- Legacy-Id: 18875
2021-03-02 19:06:36 +00:00
Robert Sparks
9744ae12e5
Reverted r18858. More work is needed.
...
- Legacy-Id: 18873
2021-03-02 18:35:34 +00:00
Robert Sparks
5b43494421
Merged in [18858] from kivinen@iki.fi:
...
Remove the automatic redirect from latest version to page without version number (also from tests), and made sure when viewing old snapshot which also happens to be last revision for draft where we have rfc, we show information from the draft, not from the rfc. Fixes issue #3162 .
- Legacy-Id: 18872
Note: SVN reference [18858] has been migrated to Git commit 84a25ed491
2021-03-02 17:17:30 +00:00
Robert Sparks
c44c8a0caa
Merged in [18857] from housley@vigilsec.com:
...
Properly handle bibxml3 for drafts with filenames that end in a hypen and digits. Fixes #3188 .
- Legacy-Id: 18870
Note: SVN reference [18857] has been migrated to Git commit cb554fa862
2021-03-02 14:51:08 +00:00
Robert Sparks
b075c2dca8
Display htmlized pages much more like tools.ietf.org. Commit ready for merge.
...
- Legacy-Id: 18869
2021-03-01 22:50:31 +00:00
Robert Sparks
87489c8694
Merged in [18856] from rjsparks@nostrum.com:
...
Patch around multiple newrevisiondocevents.
- Legacy-Id: 18868
Note: SVN reference [18856] has been migrated to Git commit 160030c745
2021-03-01 22:31:16 +00:00
Robert Sparks
8bf32fc890
Adjust several searchable fields to match a changed interface in select2-field.js
...
- Legacy-Id: 18867
2021-02-26 16:23:04 +00:00
Robert Sparks
ae4c2d1fca
Updated test (minor) to match changes in generation of page
...
- Legacy-Id: 18864
2021-02-24 19:10:23 +00:00
Robert Sparks
2421e41f3f
Minor tweaks
...
- Legacy-Id: 18863
2021-02-24 18:26:45 +00:00
Peter E. Yee
12a5e04689
Modifies stream name descriptions and changes document page to use the description instead of the stream name. Fixes issue 3169. Commit ready for merge.
...
- Legacy-Id: 18862
2021-02-24 03:11:50 +00:00
Robert Sparks
fc6579c712
Remove datatracker menu, simplify the base, and focus primarily on styling for just this page. Add the colorbar and tooltips.
...
- Legacy-Id: 18861
2021-02-23 23:16:07 +00:00
Tero Kivinen
84a25ed491
Remove the automatic redirect from latest version to page without version number (also from tests), and made sure when viewing old snapshot which also happens to be last revision for draft where we have rfc, we show information from the draft, not from the rfc. Fixes issue #3162 . Commit ready for merge.
...
- Legacy-Id: 18858
2021-02-23 19:17:45 +00:00
Russ Housley
cb554fa862
Properly handle bibxml3 for drafts with filenames that end in a hypen and digits. Fixes #3188 .
...
- Legacy-Id: 18857
2021-02-23 18:38:06 +00:00
Robert Sparks
160030c745
Patch around multiple newrevisiondocevents. Commit ready for merge.
...
- Legacy-Id: 18856
2021-02-20 19:29:56 +00:00
Robert Sparks
436d68e5c1
Change ietf.doc.tests.TemplateTagTest to use our own TestCase class rather than bare unittest.
...
- Legacy-Id: 18837
2021-02-17 21:38:31 +00:00
Robert Sparks
156cbf680e
Change styling to get closer to tools. Implement most of the info items.
...
- Legacy-Id: 18836
2021-02-16 22:41:31 +00:00
Jennifer Richards
e11583a87f
Allow assignment of Person as "action holder" for a Doc, plus rudimentary automation of assignment. Fixes #3146 . Commit ready for merge.
...
- Legacy-Id: 18829
2021-02-12 20:31:00 +00:00
Robert Sparks
e94f5c15ff
Allow ballot text to be edited after the ballot is approved. Fixes #3157 . Related to #3119 . Commit ready to merge.
...
- Legacy-Id: 18791
2021-01-11 22:59:11 +00:00
Robert Sparks
ba29ab845a
Merged in [18723] from mrcullen42@gmail.com:
...
Fixes #3032 : Only send expiration warnings for drafts with a 'draft' state of 'active', to match the drafts that we will actually expire.
- Legacy-Id: 18755
Note: SVN reference [18723] has been migrated to Git commit dbeb0e8d2d
2020-12-11 20:17:55 +00:00
Robert Sparks
b673e9f836
Merged in [18719] from housley@vigilsec.com:
...
Automatically move the IESG document state when a ballot is issued, prevent a writeup change or re-issue of ballot if the document is already approved, and warn about issuing ballots before the IETF Last Call is finished. Fixes #3119 .
- Legacy-Id: 18746
Note: SVN reference [18719] has been migrated to Git commit 89ec802a5b
2020-12-10 17:04:41 +00:00
Margaret Cullen
dbeb0e8d2d
Fixes #3032 : Only send expiration warnings for drafts with a "draft" state of "active", to match the drafts that we will actually expire. Commit ready for merge.
...
- Legacy-Id: 18723
2020-12-01 17:05:34 +00:00
Russ Housley
89ec802a5b
Automatically move the IESG document state when a ballot is issued, prevent a writeup change or re-issue of ballot if the document is already approved, and warn about issuing ballots before the IETF Last Call is finished. Fixes #3119 .
...
- Legacy-Id: 18719
2020-11-23 22:59:41 +00:00
Robert Sparks
7e384a8aea
Send email to new mailtrigger controlled destinations when iana expert review state changes. Fixes #3121 . Commit ready for merge.
...
- Legacy-Id: 18714
2020-11-18 21:32:48 +00:00
Henrik Levkowetz
7b02847149
Merged in [18701] from jennifer@painless-security.com:
...
Improve group 'about' link text on doc page. Fixes #3066 .
- Legacy-Id: 18704
Note: SVN reference [18701] has been migrated to Git commit cde31ce72f
2020-11-17 06:44:47 +00:00
Henrik Levkowetz
15c5a0ab8b
Modified the document.save...() logging to give the document name
...
- Legacy-Id: 18702
2020-11-17 05:08:42 +00:00
Jennifer Richards
cde31ce72f
Improve group 'about' link text on doc page. Fixes #3066 . Commit ready for merge.
...
- Legacy-Id: 18701
2020-11-16 18:11:05 +00:00
Robert Sparks
ec061deef6
Add logging for times to save a document with history. Commit ready for merge.
...
- Legacy-Id: 18698
2020-11-16 17:17:00 +00:00
Henrik Levkowetz
088033d843
Added matching indexes to a number of models with ordering by multiple keys.
...
- Legacy-Id: 18664
2020-11-09 19:41:12 +00:00
Henrik Levkowetz
dbd9ab0c66
Merged in [18627] from rjsparks@nostrum.com:
...
Repair warning call for duplicate review submission. Improve testing. Additional fix for #3092 .
- Legacy-Id: 18638
Note: SVN reference [18627] has been migrated to Git commit c8361aba80
2020-10-24 19:27:41 +00:00
Robert Sparks
c8361aba80
Repair warning call for duplicate review submission. Improve testing. Additional fix for #3092 . Commit ready for merge.
...
- Legacy-Id: 18627
2020-10-22 21:04:37 +00:00
Henrik Levkowetz
1832976b94
Added caching for the /doc/active page.
...
- Legacy-Id: 18625
2020-10-22 11:25:24 +00:00
Henrik Levkowetz
4bbe2fed93
Restricted a log.assertion to only run for current documents (not DocHistory entries). Fixed a buggy handling of document.group for historic groups.
...
- Legacy-Id: 18617
2020-10-15 11:29:14 +00:00
Henrik Levkowetz
6d36990446
Changed the cache-filling code for doc.get_state() to avoid a period where the cache is seen as valid but empty. Addresses an issue where documents occasionally appear to be in an unexpected state.
...
- Legacy-Id: 18564
2020-10-05 14:55:16 +00:00
Henrik Levkowetz
f31b52e8f7
Merged in [18550] from rjsparks@nostrum.com:
...
Use the id-archive wherever we had been using the id-repository. Fixes #3080 .
- Legacy-Id: 18560
Note: SVN reference [18550] has been migrated to Git commit 3baea05e6d
2020-10-04 14:16:15 +00:00
Henrik Levkowetz
29d1a0b362
Merged in [18533] from rjsparks@nostrum.com:
...
Replaced review name collision resolution code with a decision to not save when it occurs. Fixes #3092 .
- Legacy-Id: 18559
Note: SVN reference [18533] has been migrated to Git commit 0ff5172a89d5a7ad48cb1fd03b1c8926e26e50f9
2020-10-04 13:36:44 +00:00
Robert Sparks
3baea05e6d
Use the id-archive wherever we had been using the id-repository. Fixes #3080 . Commit ready for merge.
...
- Legacy-Id: 18550
2020-10-02 14:13:17 +00:00
Henrik Levkowetz
0eee548999
Fixed a couple of pyflakes issues.
...
- Legacy-Id: 18516
2020-09-24 10:23:30 +00:00
Henrik Levkowetz
e2caecba2f
Added a migration to create missing DocAlias instances (and remove some bad ones).
...
- Legacy-Id: 18511
2020-09-22 15:25:58 +00:00
Henrik Levkowetz
51806b1964
Updated log.assertion() to provide an exception object (under Py3, it seems that logging.Logger instances ignore the traceback if there isn't also an exception object). Added a check for unset draft-iesg state to Document.set_state().
...
- Legacy-Id: 18503
2020-09-18 14:15:02 +00:00
Henrik Levkowetz
0fa1500f52
Changed the format of email addresses added to the document notifications filed when the document shepherd is set. Fixes issue #3079 .
...
- Legacy-Id: 18494
2020-09-14 13:31:39 +00:00
Henrik Levkowetz
90a6ed0d08
Fixed a bad membership test.
...
- Legacy-Id: 18480
2020-09-09 15:32:38 +00:00
Henrik Levkowetz
e86bf0194b
Added an assertion to catch an unexpected document state (no IESG state set). Updated the log.assertion() function to accept a "note" argument, for more informative assertion messages.
...
- Legacy-Id: 18479
2020-09-09 14:09:43 +00:00
Henrik Levkowetz
1354604581
Fixed a pyflakes nit.
...
- Legacy-Id: 18470
2020-09-07 14:57:00 +00:00
Henrik Levkowetz
0fa8800644
Rewrote some code in document_main to avoid using the iesg_state.slug attribute when iesg_state might not be set.
...
- Legacy-Id: 18469
2020-09-07 14:54:29 +00:00
Henrik Levkowetz
a6bbb33177
Merged in [18445] from rjsparks@nostrum.com:
...
Provide a management command to inform github backups.
- Legacy-Id: 18455
Note: SVN reference [18445] has been migrated to Git commit 30ac9833c5
2020-09-01 12:10:48 +00:00
Henrik Levkowetz
21cd74a809
Added search field and tweaked the list display for the DocAlias admin.
...
- Legacy-Id: 18451
2020-08-31 15:38:33 +00:00
Henrik Levkowetz
2355f7c0e8
Merged in [18378] from rjsparks@nostrum.com:
...
Improved the classification of some github related external resources. Tightened validation of new resource values.
- Legacy-Id: 18449
Note: SVN reference [18378] has been migrated to Git commit 2b70735fd2
2020-08-31 15:21:42 +00:00
Robert Sparks
30ac9833c5
Provide a management command to inform github backups. Commit ready for merge.
...
- Legacy-Id: 18445
2020-08-28 15:34:25 +00:00
Robert Sparks
ba7e1f3c6a
changes to improve interfacing with the backup scripts
...
- Legacy-Id: 18442
2020-08-28 15:28:22 +00:00
Henrik Levkowetz
b3128842c9
Renamed the AUTH48 state_alert_badge() filter to auth48_alert_badge(), as the filter is specific, not generic.
...
- Legacy-Id: 18439
2020-08-28 13:29:15 +00:00
Henrik Levkowetz
5a64d6027c
Added exception catching around an urlreverse that might fail. (Enumerating valid group types will also work, but can get out of sync, so this is more DRY).
...
- Legacy-Id: 18437
2020-08-28 12:57:22 +00:00
Henrik Levkowetz
1b2900007a
Fixed an issue in the auth48 state_alert_badge() template filter, which could arise for a document where a get_state() call returns None.
...
- Legacy-Id: 18436
2020-08-28 12:49:09 +00:00
Henrik Levkowetz
c98b6c8ad3
Fixed an issue with the generated tag for versioned bibxml entries under /doc/bibxml3 for drafts that have been published as RFC.
...
- Legacy-Id: 18418
2020-08-26 15:23:41 +00:00
Henrik Levkowetz
8d2e0a0637
Merged in [18357] from rjsparks@nostrum.com:
...
Show link to a drafts group page for all group types when the draft has a group. Fixes #3061 .
- Legacy-Id: 18406
Note: SVN reference [18357] has been migrated to Git commit cf42db8804
2020-08-24 10:53:10 +00:00
Robert Sparks
f4fd4b1921
Gather actual repos to backup takinging user and organizational owners into account, iterating through owner repos when necessary using the github api.
...
- Legacy-Id: 18384
2020-08-19 19:07:29 +00:00
Robert Sparks
2b70735fd2
Improved the classification of some github related external resources. Tightened validation of new resource values. Commit ready to merge.
...
- Legacy-Id: 18378
2020-08-17 23:50:22 +00:00
Henrik Levkowetz
9125104065
Merged in [18324] from rjsparks@nostrum.com:
...
Send extra mail to yangdoctors chairs when a draft with yang checks goes into IETF LC. Fixes #2419 .
- Legacy-Id: 18363
Note: SVN reference [18324] has been migrated to Git commit cb58810705
2020-08-13 11:23:22 +00:00
Robert Sparks
cf42db8804
Show link to a drafts group page for all group types when the draft has a group. Fixes #3061 . Commit ready for merge.
...
- Legacy-Id: 18357
2020-08-12 18:47:29 +00:00
Henrik Levkowetz
57938b039d
Converted many cases of plain-text 403 messages to use a properly styled page instead, with a login link when appropriate. Also changed some API endpoint 400 responses to a more correct 403.
...
- Legacy-Id: 18339
2020-08-06 10:59:52 +00:00
Robert Sparks
cb58810705
Send extra mail to yangdoctors chairs when a draft with yang checks goes into IETF LC. Fixes #2419 . Commit ready to merge.
...
- Legacy-Id: 18324
2020-07-30 21:44:02 +00:00
Henrik Levkowetz
e4bc508abc
Merged in [18298] from rjsparks@nostrum.com:
...
Convert IRTF area groups into their own group type rather than attempting to overload AG. Fixes #3027 .
- Legacy-Id: 18320
Note: SVN reference [18298] has been migrated to Git commit 2b10465aa7
2020-07-30 14:27:17 +00:00
Henrik Levkowetz
9dbdbd5078
Merged in [18296] from rjsparks@nostrum.com:
...
Show RSOC from the Group menu. Fixes #3024 .
- Legacy-Id: 18308
Note: SVN reference [18296] has been migrated to Git commit 328c92f395
2020-07-29 14:18:29 +00:00
Henrik Levkowetz
57f6fba930
Merged in [18276] from housley@vigilsec.com:
...
Send email to AD when an IETF Last Call expires that contains downrefs. Fixes #2472
- Legacy-Id: 18306
Note: SVN reference [18276] has been migrated to Git commit e0ca07e65d
2020-07-29 13:08:10 +00:00
Robert Sparks
2b10465aa7
Convert IRTF area groups into their own group type rather than attempting to overload AG. Fixes #3027 . Commit ready for merge.
...
- Legacy-Id: 18298
2020-07-28 18:54:44 +00:00
Robert Sparks
44d19f0533
Let MyPy know a decoration is on purpose. Commit ready for merge.
...
- Legacy-Id: 18297
2020-07-28 16:49:08 +00:00
Robert Sparks
328c92f395
Show RSOC from the Group menu. Fixes #3024 . Commit ready for merge.
...
- Legacy-Id: 18296
2020-07-28 16:10:42 +00:00
Henrik Levkowetz
f10255e0e2
Merged in [18270] from valery@smyslov.net:
...
Added display of verified errata in red, not verified in orange in document lists.
#2997
- Legacy-Id: 18280
Note: SVN reference [18270] has been migrated to Git commit 126d32b37f
2020-07-26 14:46:35 +00:00
Russ Housley
e0ca07e65d
Send email to AD when an IETF Last Call expires that contains downrefs. Fixes #2472
...
- Legacy-Id: 18276
2020-07-25 21:09:50 +00:00
Valery Smyslov
126d32b37f
#2997
...
- Legacy-Id: 18270
2020-07-25 17:25:31 +00:00
Henrik Levkowetz
d16e946ed3
Merged in [18189] from jennifer@painless-security.com:
...
Make docs in Auth48 state visually distinct. Fixes #2925 .
- Legacy-Id: 18210
Note: SVN reference [18189] has been migrated to Git commit abe97eeb28
2020-07-21 09:28:53 +00:00
Henrik Levkowetz
d6d3d82434
Merged in [18198] from rjsparks@nostrum.com:
...
Return the right reference for interim meeting materials.
- Legacy-Id: 18200
Note: SVN reference [18198] has been migrated to Git commit 9bcd64455a
2020-07-20 18:09:16 +00:00
Robert Sparks
9bcd64455a
Return the right reference for interim meeting materials. Commit ready for merge.
...
- Legacy-Id: 18198
2020-07-20 17:39:33 +00:00
Henrik Levkowetz
606cedd796
Merged in the ExtResource work from rjsparks@nostrum.com, based on a feature request and contributions from rsalz@akamai.com. This provides external resource models for Person, Group, and Document models, as a generalisation of the previous related-URL concept. This provides a consistent labelling and classification of URLs and other resources related to a Group, Document, or Person. The GroupURL (and similar) classes will be removed in a later step. Some DocumentURL instances (such as auth48 URLs) remain to convert, as they have come in with other merged-in work while the ExtResource work was in transit.
...
- Legacy-Id: 18192
2020-07-20 01:58:26 +00:00
Jennifer Richards
abe97eeb28
Make docs in Auth48 state visually distinct. Fixes #2925 . Commit ready for merge.
...
- Legacy-Id: 18189
2020-07-17 18:14:23 +00:00
Henrik Levkowetz
4bc6a20661
Merged in [18162] from jennifer@painless-security.com:
...
Notify IRSG when an IRSG ballot is created. Fixes #2978 .
- Legacy-Id: 18177
Note: SVN reference [18162] has been migrated to Git commit 6e97a89786
2020-07-15 14:52:38 +00:00
Henrik Levkowetz
4fa431651c
Renumbered some migrations to avoid multiple leaf nodes.
...
- Legacy-Id: 18169
2020-07-14 17:40:41 +00:00
Henrik Levkowetz
4b1074483a
Merged in [18159] from jennifer@painless-security.com:
...
Notify secretariat when conflict review/status change doc enters an announcement pending state. Fixes #2962 .
- Legacy-Id: 18168
Note: SVN reference [18159] has been migrated to Git commit 24140fac50
2020-07-14 12:25:47 +00:00
Henrik Levkowetz
2d6925f02f
Fixed an UnboundLocalError issue.
...
- Legacy-Id: 18167
2020-07-14 12:06:14 +00:00
Henrik Levkowetz
a7b3d9c83b
Merged in [18157] from jennifer@painless-security.com:
...
Store Auth48 URL as DocumentURL and display in RFC-Editor state. Migrates old data when possible. Alternative to 17563. Fixes #2722 .
- Legacy-Id: 18166
Note: SVN reference [18157] has been migrated to Git commit fff927b085
2020-07-14 11:22:11 +00:00
Robert Sparks
6227162e53
Updated mgmt command to find github repos to back up. Improved test coverage of branch changes. Branch ready for merge.
...
- Legacy-Id: 18163
2020-07-13 17:36:34 +00:00
Jennifer Richards
6e97a89786
Notify IRSG when an IRSG ballot is created. Fixes #2978 . Commit ready for merge.
...
- Legacy-Id: 18162
2020-07-13 16:45:45 +00:00
Jennifer Richards
24140fac50
Notify secretariat when conflict review/status change doc enters an announcement pending state. Fixes #2962 . Commit ready for merge.
...
- Legacy-Id: 18159
2020-07-13 16:11:58 +00:00
Robert Sparks
99df95d542
Cleaned up created names. Improved validation during migration. Cleaned up migration output. Cleaned the last of the awp includes from secr views. Removed now unused secr templates. Build extresource urls correctly during submission and when creating group wikis.
...
- Legacy-Id: 18158
2020-07-13 16:03:39 +00:00
Jennifer Richards
fff927b085
Store Auth48 URL as DocumentURL and display in RFC-Editor state. Migrates old data when possible. Alternative to 17563. Fixes #2722 . Commit ready for merge.
...
- Legacy-Id: 18157
2020-07-13 15:34:01 +00:00
Robert Sparks
53f7bc3ce6
migrated forward
...
- Legacy-Id: 18144
2020-07-09 21:07:05 +00:00
Robert Sparks
066ee27505
preparing to merge forward
...
- Legacy-Id: 18143
2020-07-09 20:29:45 +00:00
Robert Sparks
c6f55a3306
Fixed some test scaffolding that used non-existent keys (uncovered by recent improvements in sqlite3 integrity checking). Commit ready for merge.
...
- Legacy-Id: 18130
2020-07-02 20:05:02 +00:00
Henrik Levkowetz
47a2174e80
Django 2.2 does not wrap single queries in transactions, for performance reasons. This caused some template tags that did database lookups to trigger exceptions. Fixed by moving the lookups (which would not normally change between apache reloads) out from the template tag code to module scope. Adding new groups of type ['ag','area','team','dir','program'] will now require a reload to show up in the group menu.
...
- Legacy-Id: 18086
2020-06-27 17:28:50 +00:00
Henrik Levkowetz
dc5ca4eebc
Merged in Django 2.1 upgrade changes.
...
- Legacy-Id: 18060
2020-06-24 20:51:00 +00:00
Henrik Levkowetz
dc7581fef4
Changed NullBoleanField() to BooleanField(null=True), according to the 2.1 upgrade recommendations.
...
- Legacy-Id: 18051
2020-06-24 20:33:57 +00:00
Robert Sparks
bf53bf1057
Merged forward. Added some missing parts to the XMPPURLValidator.
...
- Legacy-Id: 18050
2020-06-24 19:01:45 +00:00
Robert Sparks
f7b1ce1fce
Remove abandoned charters from any future telechats. Fixes #3003 . Commit ready for merge.
...
- Legacy-Id: 18037
2020-06-22 21:22:54 +00:00
Robert Sparks
d87a1d009b
Map some new urls. Create a new external resource type
...
- Legacy-Id: 17873
2020-05-21 21:46:51 +00:00
Robert Sparks
8a0578040e
Added better self-descriptive __str__ functions to PersonExtResource, GroupExtResource, and DocExtResource
...
- Legacy-Id: 17871
2020-05-21 20:59:44 +00:00
Robert Sparks
02e1226a03
Added appropriate Admin classes
...
- Legacy-Id: 17870
2020-05-21 20:48:03 +00:00
Robert Sparks
785f6243f1
explicit resource names for classes with the word resource in their name
...
- Legacy-Id: 17857
2020-05-20 18:28:05 +00:00
Robert Sparks
7e57be2bd3
merged forward ^/personal/rjs/explore-extref
...
- Legacy-Id: 17840
2020-05-19 18:47:47 +00:00
Henrik Levkowetz
bc05e7a8d0
Refactored many instances of msg.get_payload(decode=True).decode('utf-8') and similar to get_payload_text(msg), which uses msg.get_charset() to get the actual charset to do the decoding, in a consistent manner. Also removed some instances of force_str, but more remain.
...
- Legacy-Id: 17807
2020-05-16 20:20:05 +00:00
Henrik Levkowetz
02804ba163
Fixed a case of too few format string parameters.
...
- Legacy-Id: 17768
2020-05-10 14:14:50 +00:00
Henrik Levkowetz
81197f044c
Tweaked a 404 message to differentiate between two not-found cases.
...
- Legacy-Id: 17767
2020-05-10 14:13:39 +00:00
Henrik Levkowetz
29ccca849a
Added a second link to htmlized draft content (on the datatracker) in addition to the link to the tools hosted htmlized document.
...
- Legacy-Id: 17760
2020-05-06 18:23:47 +00:00
Henrik Levkowetz
0b51e9a2b3
Removed a debug statement.
...
- Legacy-Id: 17732
2020-05-04 20:59:44 +00:00
Henrik Levkowetz
35a2a145fa
Merged in [17708] from rjsparks@nostrum.com:
...
Remove 'point raised - writup needed' from the set of substates the IESG can use with a document. Fixes #2968 .
- Legacy-Id: 17731
Note: SVN reference [17708] has been migrated to Git commit fa492c3947
2020-05-04 20:50:17 +00:00
Henrik Levkowetz
3e6a1cfb11
Limited the data for 'New draft revisions over time' on the personal profile page to type='draft'.
...
- Legacy-Id: 17720
2020-05-01 11:37:32 +00:00
Robert Sparks
fa492c3947
Remove "point raised - writup needed" from the set of substates the IESG can use with a document. Fixes #2968 . Commit ready for merge.
...
- Legacy-Id: 17708
2020-04-29 20:32:31 +00:00
Robert Sparks
7587d564d4
Added GroupExtResources to the group about page, and added the ability to edit them.
...
- Legacy-Id: 17685
2020-04-24 21:47:24 +00:00
Robert Sparks
2de9eb93b5
Added validation to the migrations. Added external resources to the draft display page. Built an editor for DocExternalResources.
...
- Legacy-Id: 17683
2020-04-24 16:14:43 +00:00
Henrik Levkowetz
9aeda11a29
Removed some Py2 compatibility decorators.
...
- Legacy-Id: 17673
2020-04-21 13:54:31 +00:00
Robert Sparks
672f9bce26
Added display-name. Refined migrations.
...
- Legacy-Id: 17646
2020-04-15 19:54:29 +00:00
Henrik Levkowetz
f10ddadc0e
Merged in changes from trunk up to r17584.
...
- Legacy-Id: 17593
2020-04-07 16:02:52 +00:00
Henrik Levkowetz
98fab6c05b
Merged in [17562] from jennifer@painless-security.com:
...
Add tooltips with doc name to 'updates' and 'obsoletes' links. Fixes #2866 ;
- Legacy-Id: 17569
Note: SVN reference [17562] has been migrated to Git commit 2d6179c1a5
2020-03-31 13:03:15 +00:00
Jennifer Richards
2d6179c1a5
Add tooltips with doc name to "updates" and "obsoletes" links. Fixes #2866 ; Commit ready for merge.
...
- Legacy-Id: 17562
2020-03-30 20:22:05 +00:00
Henrik Levkowetz
37f39163d1
Prevent an exception on missing author.email.person when listing author emails.
...
- Legacy-Id: 17554
2020-03-27 16:14:29 +00:00
Henrik Levkowetz
50bb971fc3
Merged in [17496] from rjsparks@nostrum.com:
...
Remove the rest of the log.assertions checking that iesg_state existed in places we expected it to. Removed unnecessary imports.
- Legacy-Id: 17522
Note: SVN reference [17496] has been migrated to Git commit db5d11ea32
2020-03-23 22:34:03 +00:00
Henrik Levkowetz
c6be826113
Merged in [17495] from rjsparks@nostrum.com:
...
Remove log.assertion that was checking that we covered the edges when we changed documents to always have an iesg state.
- Legacy-Id: 17517
Note: SVN reference [17495] has been migrated to Git commit f2b106cf8c
2020-03-23 11:16:19 +00:00
Henrik Levkowetz
970248a3d6
Merged in [17494] from rjsparks@nostrum.com:
...
Use current email addresses when we have them when listing document authors. Fixes #1902 .
- Legacy-Id: 17516
Note: SVN reference [17494] has been migrated to Git commit 8583a0a098
2020-03-22 23:55:49 +00:00
Robert Sparks
c055d37dcb
Removed extref app. Refined population migrations.
...
- Legacy-Id: 17509
2020-03-22 19:27:28 +00:00
Robert Sparks
db5d11ea32
Remove the rest of the log.assertions checking that iesg_state existed in places we expected it to. Commit ready for merge.
...
- Legacy-Id: 17496
2020-03-21 22:11:33 +00:00
Robert Sparks
f2b106cf8c
Remove log.assertion that was checking that we covered the edges when we changed documents to always have an iesg state. Commit ready for merge.
...
- Legacy-Id: 17495
2020-03-21 22:07:15 +00:00
Robert Sparks
8583a0a098
Use current email addresses when we have them when listing document authors. Fixes #1902 . Commit ready for merge.
...
- Legacy-Id: 17494
2020-03-21 21:36:58 +00:00
Henrik Levkowetz
87bf4e8d58
Make sure to strip possible mail header field values of whitespace before applying email.utils.unquite(). Resolution by kivinen@iki.fi, Fixes issue #2899 .
...
- Legacy-Id: 17485
2020-03-21 17:34:37 +00:00
Robert Sparks
316dd183d9
first run at external resources
...
- Legacy-Id: 17470
2020-03-19 23:32:24 +00:00
Henrik Levkowetz
08130f4986
Merged in [17396] from rjsparks@nostrum.com:
...
Move charters for replaced groups to a new replaced state. Close any outstanding ballots on them. Fixes #2889 , #2873 , and #1286 .
- Legacy-Id: 17420
Note: SVN reference [17396] has been migrated to Git commit 79bb245f8a
2020-03-11 19:21:43 +00:00
Henrik Levkowetz
ec13af6c43
Added a guard against accessing attributes of None.
...
- Legacy-Id: 17409
2020-03-08 13:18:58 +00:00
Henrik Levkowetz
638fbc592e
Added a data migration to fix up some incorrect external URLs for reviews.
...
- Legacy-Id: 17402
2020-03-07 14:21:41 +00:00
Robert Sparks
79bb245f8a
Move charters for replaced groups to a new replaced state. Close any outstanding ballots on them. Fixes #2889 , #2873 , and #1286 . Commit ready for merge.
...
- Legacy-Id: 17396
2020-03-06 16:47:59 +00:00
Henrik Levkowetz
726fcbf27d
Removed all __future__ imports.
...
- Legacy-Id: 17391
2020-03-05 23:53:42 +00:00
Henrik Levkowetz
ab173cb2eb
Removed further six usage: six.string_types, six.integer_types, six.moves.urllib instances.
...
- Legacy-Id: 17390
2020-03-05 20:46:58 +00:00
Henrik Levkowetz
e9a37d8ac8
Removed six.text_type(), changed six.moves.urllib to plain urllib, and removed now unused six imports.
...
- Legacy-Id: 17385
2020-03-05 14:41:41 +00:00
Henrik Levkowetz
a14e38a1a1
Replaced most cases of using of urlopen(), instead using the higher-level 'requests' module where it simplifies the code.
...
- Legacy-Id: 17380
2020-03-03 17:34:42 +00:00
Henrik Levkowetz
94e4dc7c74
Python3 is more ticklish about comparing strings to None than Py2. Fixed an issue with this in generate_sort_key() for document searches.
...
- Legacy-Id: 17373
2020-03-02 12:47:05 +00:00
Henrik Levkowetz
07747b26c3
Fixed an issue with tests mocking urlopen() responses, and tweaked error messages on bad results in sync/rfceditor.py
...
- Legacy-Id: 17356
2020-02-27 15:05:27 +00:00
Henrik Levkowetz
bea0c59d6e
Fixed a string vs list issue for Message from form case.
...
- Legacy-Id: 17338
2020-02-26 17:01:00 +00:00
Henrik Levkowetz
a7baacf519
Added missing .as_strings() to some gather_address_lists() calls, in order to assign strings rather than lists to Message CharField instances. Fixed a Message content_type setting.
...
- Legacy-Id: 17337
2020-02-26 16:59:18 +00:00
Henrik Levkowetz
ab34ecbb58
Merged in [17288] from rjsparks@nostrum.com:
...
Make internal review email about an RG use the IRSG instead of the IESG in text and addresses. Fixes #2881 .
- Legacy-Id: 17307
Note: SVN reference [17288] has been migrated to Git commit 4cce1b5e08
2020-02-18 22:04:15 +00:00
Henrik Levkowetz
0a6260cf16
Merged in [17286] from rjsparks@nostrum.com:
...
Add Reply-To to the default group review text. Fixes #2883 .
- Legacy-Id: 17292
Note: SVN reference [17286] has been migrated to Git commit 7e09dea02c
2020-02-13 00:33:37 +00:00
Henrik Levkowetz
5e6ea5b2e8
Merged in [17284] from jennifer@painless-security.com:
...
Create DocEvent when related IprDisclosure is posted or removed. Fixes #2811 .
- Legacy-Id: 17291
Note: SVN reference [17284] has been migrated to Git commit b02b42da81
2020-02-12 23:11:26 +00:00
Robert Sparks
4cce1b5e08
Make internal review email about an RG use the IRSG instead of the IESG in text and addresses. Fixes #2881 . Commit ready for merge.
...
- Legacy-Id: 17288
2020-02-11 20:17:42 +00:00
Robert Sparks
7e09dea02c
Add Reply-To to the default group review text. Fixes #2883 . Commit ready for merge.
...
- Legacy-Id: 17286
2020-02-11 15:39:20 +00:00
Jennifer Richards
b02b42da81
Create DocEvent when related IprDisclosure is posted or removed. Fixes #2811 . Commit ready for merge.
...
- Legacy-Id: 17284
2020-02-07 20:41:13 +00:00
Henrik Levkowetz
32e9692f54
Fixed a py2/py3 issue in sync.rfceditor.post_approved_draft(), and enhanced tests to execute the failing code (with Mock functions) instead of skipping the code.
...
- Legacy-Id: 17265
2020-01-28 22:37:50 +00:00
Henrik Levkowetz
82baf773d8
Merged in [17228] from rjsparks@nostrum.com:
...
Improve admin handling of DocumentURL. Fixes #2865 .
- Legacy-Id: 17231
Note: SVN reference [17228] has been migrated to Git commit 0040a85395
2020-01-14 13:43:56 +00:00
Henrik Levkowetz
3fe48041da
Merged in [17227] from rjsparks@nostrum.com:
...
Allow document Additional URLs to become empty. Fixes #2864 .
- Legacy-Id: 17229
Note: SVN reference [17227] has been migrated to Git commit 0c0cc5dcf5
2020-01-14 11:09:21 +00:00
Robert Sparks
0040a85395
Improve admin handling of DocumentURL. Fixes #2865 . Commit ready for merge.
...
- Legacy-Id: 17228
2020-01-13 19:33:35 +00:00
Robert Sparks
0c0cc5dcf5
Allow document Additional URLs to become empty. Fixes #2864 . Commit ready for merge.
...
- Legacy-Id: 17227
2020-01-13 19:03:58 +00:00
Henrik Levkowetz
288f4135e3
Added (currently inactive) code to trigger exceptions on failure to resolve template variables during tests, and added fixes for a couple of places that triggered such exceptions.
...
- Legacy-Id: 17226
2020-01-13 17:16:43 +00:00
Henrik Levkowetz
d2b2bb1417
Merged in [17219] from rjsparks@nostrum.com:
...
Update some uses of pos.ad in templates to pos.balloter. Fixes #2863 .
- Legacy-Id: 17224
Note: SVN reference [17219] has been migrated to Git commit af0a9954fe
2020-01-13 15:01:40 +00:00
Robert Sparks
af0a9954fe
Update some uses of pos.ad in templates to pos.balloter. Fixes #2863 . Commit ready for merge.
...
- Legacy-Id: 17219
2020-01-10 19:04:42 +00:00
Henrik Levkowetz
ba3010e3b0
Added fetch and use of the RFC-Editor's errata.json file in order to set a new 'verified-errata' document tag, and use that to show the link to inline-errata documents only when there is verified errata. Fixes issue #2861 .
...
- Legacy-Id: 17212
2020-01-10 12:22:33 +00:00
Henrik Levkowetz
acaca62195
Merged in [17179] from housley@vigilsec.com:
...
Add references and referened-by buttons to each RFC listed on the peron profile page. In addition, changed the buttons on the document references and document referenced-by pages to match the buttons on the main document page (the buttons with the long arrows). Fixes #2854 , although it does not include the number of references in the button.
- Legacy-Id: 17191
Note: SVN reference [17179] has been migrated to Git commit 3460f9242f
2020-01-07 15:29:40 +00:00
Henrik Levkowetz
b14cba5f15
Refactored some document methods to align better with Django's get_absolute_url(), and added Person.get_absolute_uri()
...
- Legacy-Id: 17189
2020-01-07 13:33:02 +00:00
Henrik Levkowetz
b2fc68a978
Merged in [17177] from rjsparks@nostrum.com:
...
Improve can_ballot. Fixes #2856 .
- Legacy-Id: 17188
Note: SVN reference [17177] has been migrated to Git commit eb69b9e14b
2020-01-07 11:47:03 +00:00
Henrik Levkowetz
2961f4dfba
Merged in [17173] from rjsparks@nostrum.com:
...
Works around a problem with displaying IESG evaluation information for non-approve ballot types. Partially addresses #2851 .
- Legacy-Id: 17183
Note: SVN reference [17173] has been migrated to Git commit 5773d62c1b
2020-01-06 18:48:33 +00:00
Robert Sparks
eb69b9e14b
Improve can_ballot. Fixes #2856 . Commit ready for merge.
...
- Legacy-Id: 17177
2020-01-03 15:55:48 +00:00
Robert Sparks
5773d62c1b
Works around a problem with displaying IESG evaluation information for non-approve ballot types. Partially addresses #2851 . Commit ready for merge.
...
- Legacy-Id: 17173
2019-12-23 19:48:21 +00:00
Henrik Levkowetz
6482254a03
Merged in ^/branch/akayla/irsg/6.113.1.dev0 from peter@akayla.com.
...
This provides support for IRSG ballots, similar to the IESG ballots support which has been in use for quite some time. The IRSG ballots differ from IESG ballots in a number of ways, described in detail in the RFP and SoW for this work and implemented here.
- Legacy-Id: 17164
2019-12-20 15:00:55 +00:00
Henrik Levkowetz
1d0e8b7527
Merged in [17148] from rjsparks@nostrum.com:
...
Only gather addresses instead of name_addrs for the group_secretaries Mailtrigger Recipient. Fixes #2847 .
- Legacy-Id: 17156
Note: SVN reference [17148] has been migrated to Git commit d22da6259b
2019-12-18 18:29:26 +00:00
Henrik Levkowetz
1e1bd2f995
Merged in [17147] from rjsparks@nostrum.com:
...
Show diff controls for a bis -00 document. Fixes #2846 .
- Legacy-Id: 17155
Note: SVN reference [17147] has been migrated to Git commit 18b8a795ad
2019-12-18 16:33:59 +00:00
Henrik Levkowetz
06fe583351
Merged /branch/iola/meeting-improvement-r16992@17152 from olau@iola.dk:
...
* Renamed Meeting.agenda to Meeting.schedule together with a bunch of related
internal things
* Moved Session.status, .requested, and .requested_by to a new SchedulingEvent.
* Turned sessions into regular sessions and non-sessions into misc.
sessions in the UI and code to avoid ambiguity.
This doesn't change the data in the DB except for uses of
TimeSlotTypeName where 'session' is now 'regular'.
- Legacy-Id: 17153
2019-12-17 23:43:07 +00:00
Peter E. Yee
8313b0adbf
Fixes for questions for you. Does not include any changes in docker/
...
- Legacy-Id: 17150
2019-12-13 23:01:06 +00:00
Peter E. Yee
bb7e504d14
12/13 merged into 6.113.1.dev0 with migration ordering failure
...
- Legacy-Id: 17149
2019-12-13 19:53:45 +00:00
Robert Sparks
d22da6259b
Only gather addresses instead of name_addrs for the group_secretaries Mailtrigger Recipient. Fixes #2847 . Commit ready for merge.
...
- Legacy-Id: 17148
2019-12-13 18:37:30 +00:00
Robert Sparks
18b8a795ad
Show diff controls for a bis -00 document. Fixes #2846 . Commit ready for merge.
...
- Legacy-Id: 17147
2019-12-12 17:17:51 +00:00
Ole Laursen
de2b6d4072
Fix use of status still referring to the old attribute in the group
...
meeting page
- Legacy-Id: 17142
2019-12-09 18:08:37 +00:00
Ole Laursen
568670c060
Turn sessions into regular sessions and non-sessions into misc.
...
sessions in the UI and code to avoid ambiguity.
This doesn't change the data in the DB except for uses of
TimeSlotTypeName where 'session' is now 'regular'.
- Legacy-Id: 17128
2019-12-06 20:02:26 +00:00
Ole Laursen
3957743b85
Move Session.status, .requested, and .requested_by to a new SchedulingEvent
...
- Legacy-Id: 17122
2019-12-05 12:41:09 +00:00
Henrik Levkowetz
fcb6806d17
Merged in work from sasha@dashcare.nl on Review Queue Managemnt:
...
This abstracts queue management, making it possible to implement different
policies for each team. It provides two concrete policies:
RotateAlphabeticallyReviewerQueuePolicy, which rotates an alphabetically
ordered reviewer list with consideration for skip indications, and is the
default policy; and LeastRecentlyUsedReviewerQueuePolicy, a simple
least-recently-used policy. Also see issues #2721 and #2656 .
- Legacy-Id: 17121
2019-12-04 23:02:52 +00:00
Henrik Levkowetz
fc0060079a
Merged in [17085] from sasha@dashcare.nl:
...
Fix #2278 - Notify secretary when a review request is closed.
The assigned reviewer was already notified, but secretaries were always
excluded.
- Legacy-Id: 17108
Note: SVN reference [17085] has been migrated to Git commit 56003f66d8
2019-11-27 22:19:58 +00:00
Henrik Levkowetz
2c28cb3eb0
When group secretary email addresses occurred in some mailtrigger To: entries, they were given with both name and address parts, while when occurring in Cc: entries, no names were present. Fixed one case of this, and adjusted a test case for consistency. Also added a more general utility function to exclude selected email addresses from email address lists.
...
- Legacy-Id: 17107
2019-11-27 21:49:22 +00:00
Henrik Levkowetz
5cf2cac8d0
Added support for bibxml3 entries using the traditional reference entry name (with 'reference.I-D....'), instead of just the plain draft name.
...
- Legacy-Id: 17106
2019-11-27 15:31:40 +00:00
Henrik Levkowetz
2bc5606986
Merged in [17070] from sasha@dashcare.nl:
...
Fix #2061 - Improve 'complete review' workflow for secretaries.
When a secretary completes a review, 'link to a review message'
is automatically selected, and the first non-reply mail is used to
fill in the review details. The secretary can still modify all details.
The order of fields for secretaries is also modified to fit this workflow.
All cases where 'link to review message' is used, by reviewers or
secretaries, now attempt to fill in the 'reviewed version' if found
in the email subject.
- Legacy-Id: 17105
Note: SVN reference [17070] has been migrated to Git commit dc9546211f
2019-11-26 20:22:56 +00:00
Henrik Levkowetz
7ec09554bb
Merged in [17069] from sasha@dashcare.nl:
...
Fix #2074 , fix #2358 - Add history for assignments, requests and unavailability.
- Legacy-Id: 17104
Note: SVN reference [17069] has been migrated to Git commit 65d84155b6
2019-11-26 16:09:43 +00:00
Henrik Levkowetz
47c3afc328
Added a test for bibtex page content-type.
...
- Legacy-Id: 17103
2019-11-26 01:34:35 +00:00
Henrik Levkowetz
8364e119bc
Fixed an incorrect content_type
...
- Legacy-Id: 17102
2019-11-25 18:47:58 +00:00
Sasha Romijn
10a7bee637
Merge reviewer-queue-management on top of 6.111.1.dev0
...
- Legacy-Id: 17094
2019-11-22 12:35:28 +00:00
Robert Sparks
a33ba86452
Add pages to assignment email. Fixes #2838 . Commit ready for merge.
...
- Legacy-Id: 17090
2019-11-21 22:41:11 +00:00
Sasha Romijn
56003f66d8
Fix #2278 - Notify secretary when a review request is closed.
...
The assigned reviewer was already notified, but secretaries were always
excluded.
Commit ready for merge.
- Legacy-Id: 17085
2019-11-21 11:03:21 +00:00
Henrik Levkowetz
424dcfb42d
Some tweaks related to the changes related to #2830 .
...
- Legacy-Id: 17076
2019-11-21 06:01:56 +00:00
Henrik Levkowetz
f0adebbe70
Merged in [17062] from rjsparks@nostrum.com:
...
Change the default template for assigned review emails to name the assigned reviewer. Fixes #2830 .
- Legacy-Id: 17073
Note: SVN reference [17062] has been migrated to Git commit 38e73b6f89
2019-11-21 01:32:10 +00:00
Sasha Romijn
dc9546211f
Fix #2061 - Improve "complete review" workflow for secretaries.
...
When a secretary completes a review, "link to a review message"
is automatically selected, and the first non-reply mail is used to
fill in the review details. The secretary can still modify all details.
The order of fields for secretaries is also modified to fit this workflow.
All cases where "link to review message" is used, by reviewers or
secretaries, now attempt to fill in the "reviewed version" if found
in the email subject.
Commit ready for merge.
- Legacy-Id: 17070
2019-11-20 14:25:05 +00:00
Sasha Romijn
65d84155b6
Fix #2074 , fix #2358 - Add history for assignments, requests and unavailability.
...
Commit ready for merge.
- Legacy-Id: 17069
2019-11-20 11:29:14 +00:00
Henrik Levkowetz
19eb5de983
Merged in [17044] from valery@smyslov.net:
...
Make it clearer that a chair can't revise materials for a meeting once the proceedings deadline has passed
Fixes issue #2612 .
- Legacy-Id: 17067
Note: SVN reference [17044] has been migrated to Git commit 182dae28a8
2019-11-20 10:10:31 +00:00
Robert Sparks
38e73b6f89
Change the default template for assigned review emails to name the assigned reviewer. Fixes #2830 . Commit ready for merge.
...
- Legacy-Id: 17062
2019-11-19 21:27:23 +00:00
Sasha Romijn
0c0980c641
Fix #2420 - Add reviewer back to top of the queue after rejected/withdrawn reviews.
...
- Legacy-Id: 17058
2019-11-19 10:57:56 +00:00
Sasha Romijn
8bb6955d47
Fix #2418 - Account for previous rejected reviews in recommended assignment order
...
- Legacy-Id: 17053
2019-11-18 19:50:33 +00:00
Valery Smyslov
182dae28a8
Fixes issue #2612 . Commit ready for merge.
...
- Legacy-Id: 17044
2019-11-18 08:48:15 +00:00
Henrik Levkowetz
69069d12c6
Merged in [17027] from rcross@amsl.com:
...
Fix issue where draft resurrect feature does not move most recent draft file from the archive directory back to the current draft directory. Fixes #2646 .
- Legacy-Id: 17032
Note: SVN reference [17027] has been migrated to Git commit 9882d7fda8
2019-11-16 07:58:37 +00:00
Ryan Cross
9882d7fda8
Fix issue where draft resurrect feature does not move most recent draft file from the archive directory back to the current draft directory. Fixes #2646 . Commit ready for merge
...
- Legacy-Id: 17027
2019-11-16 05:15:03 +00:00
Sasha Romijn
c36fcdc5a7
Update update_policy_state_for_assignment for new policies, fix tests,
...
fix some other minor things.
- Legacy-Id: 17023
2019-11-13 14:39:42 +00:00
Henrik Levkowetz
68b0e42e94
Tweaked a test person name to match the usage in the code tested.
...
- Legacy-Id: 17020
2019-11-12 18:22:42 +00:00
Henrik Levkowetz
4049804920
Merged in [16981] from rjsparks@nostrum.com:
...
Look at the tree of replaces-relationships when determining if some reviewer has reviewed this (or perhaps an ancestor) of this document. Fixes #2821 .
- Legacy-Id: 16992
Note: SVN reference [16981] has been migrated to Git commit f740adcfc1
2019-11-11 16:57:40 +00:00
Sasha Romijn
1c84e3c363
Add additional tests for queue policies and fix unused import.
...
- Legacy-Id: 16990
2019-11-11 16:32:49 +00:00
Sasha Romijn
ce812a3a4f
- Make skipping unavailable reviews the default, except for the
...
reviewer_overview page.
- Make default_reviewer_rotation_list use a consistent return type
- Legacy-Id: 16986
2019-11-11 14:47:37 +00:00
Henrik Levkowetz
20eb9d8ac1
Merged in [16939] from sasha@dashcare.nl:
...
Fix #2050 - Allow adding review wishes from document and search pages.
On the main page of a document and in document search results, a new
button allows review team members to add a review wish for that document.
For reviewers that are only on one team, this essentially works
identical to tracking a document. Reviewers that are on multiple teams
are lead through an intermediate step to select a review team, and then
returned to their search or document page.
- Legacy-Id: 16985
Note: SVN reference [16939] has been migrated to Git commit 6e55f26dbd
2019-11-11 14:22:54 +00:00
Sasha Romijn
b5a31c3c6a
Update some terminology and docstrings.
...
- Legacy-Id: 16983
2019-11-11 12:31:16 +00:00
Robert Sparks
f740adcfc1
Look at the tree of replaces-relationships when determining if some reviewer has reviewed this (or perhaps an ancestor) of this document. Fixes #2821 . Commit ready for merge.
...
- Legacy-Id: 16981
2019-11-07 23:02:19 +00:00
Henrik Levkowetz
b7724c43d7
Changed some # type: ignore statements to work with the latest mypy
...
- Legacy-Id: 16968
2019-11-05 22:41:18 +00:00
Henrik Levkowetz
c565dca35b
Fixed some .format() calls.
...
- Legacy-Id: 16967
2019-11-05 22:38:54 +00:00
Henrik Levkowetz
5d8aa656a5
Added code to catch bad rev numbers for bibxml3 requests.
...
- Legacy-Id: 16963
2019-11-05 18:24:45 +00:00
Henrik Levkowetz
c233f07b5d
Added a management command to generate draft bibxml files, and also a trial version of datatracker draft bibxml pages.
...
- Legacy-Id: 16962
2019-11-05 18:10:29 +00:00
Sasha Romijn
e518824a69
Initial refactoring of the current reviewer assignment code.
...
- Legacy-Id: 16961
2019-11-05 16:39:31 +00:00
Sasha Romijn
eab14ea1c5
Early work to extract reviewer policy from review/utils.py.
...
- Legacy-Id: 16950
2019-10-31 15:01:14 +00:00
Henrik Levkowetz
0f12d477ad
Merged in [16927] from sasha@dashcare.nl:
...
Refs #2217 - Small cleanup from changeset [16924]
- Legacy-Id: 16947
Note: SVN reference [16924] has been migrated to Git commit 871a4b653b
Note: SVN reference [16927] has been migrated to Git commit 730e64d253
2019-10-30 17:02:01 +00:00
Sasha Romijn
6e55f26dbd
Fix #2050 - Allow adding review wishes from document and search pages.
...
On the main page of a document and in document search results, a new
button allows review team members to add a review wish for that document.
For reviewers that are only on one team, this essentially works
identical to tracking a document. Reviewers that are on multiple teams
are lead through an intermediate step to select a review team, and then
returned to their search or document page.
Commit ready for merge.
- Legacy-Id: 16939
2019-10-29 16:27:56 +00:00
Henrik Levkowetz
63484a8cb5
Merged in [16937] from rjsparks@nostrum.com:
...
Only show a blocked document once in the set of blocked documents on an ADs document page. Fixes #2818 .
- Legacy-Id: 16938
Note: SVN reference [16937] has been migrated to Git commit 8f1e9990cf
2019-10-29 15:03:01 +00:00
Henrik Levkowetz
c606461b22
Merged in [16924] from sasha@dashcare.nl:
...
Fix #2217 - Allow submission of unsolicited reviews by secretaries.
- For team secretaries, a button 'Submit unsolicited review' will now
appear next to 'Request review' on the document's main page.
- If the secretary is a secretary for multiple teams, they are taken
through an intermediate page to select for which team they are
submitting their review.
- The form is similar (and using the same code) as the usual review
completion, with a few extra fields for the review type and reviewer,
which would usually already be known.
- When submitting the review, a ReviewRequest and ReviewAssignment are
automatically created. The assignment is then immediately closed in
the usual way.
- Other workflows are unchanged.
The issues with the review form in #2061 are slightly worse for the
unsolicited review scenario, but that will be improved when #2061 is
fixed.
- Legacy-Id: 16932
Note: SVN reference [16924] has been migrated to Git commit 871a4b653b
2019-10-26 21:16:53 +00:00
Henrik Levkowetz
00fb8d4b43
Merged in [16923] from sasha@dashcare.nl:
...
Fix #2087 - Show doc authors and WG chairs in unassigned reviews views.
- Legacy-Id: 16931
Note: SVN reference [16923] has been migrated to Git commit 93797b3fc1
2019-10-26 20:26:21 +00:00
Henrik Levkowetz
09c34fa131
Merged in [16921] from sasha@dashcare.nl:
...
Fix #2123 - Use a DBTemplate when a review assignment is mailed.
The message sent to a reviewer when a new review is assigned to them,
is now taken from a DBTemplate, allowing it to be customised
per team. This includes a migration to create a default template,
which looks the same as before.
- Legacy-Id: 16928
Note: SVN reference [16921] has been migrated to Git commit 9df5839874
2019-10-26 15:16:18 +00:00
Sasha Romijn
730e64d253
Refs #2217 - Small cleanup from changeset [16924]
...
Commit ready for merge.
- Legacy-Id: 16927
Note: SVN reference [16924] has been migrated to Git commit 871a4b653b
2019-10-26 08:04:31 +00:00
Sasha Romijn
871a4b653b
Fix #2217 - Allow submission of unsolicited reviews by secretaries.
...
- For team secretaries, a button "Submit unsolicited review" will now
appear next to "Request review" on the document's main page.
- If the secretary is a secretary for multiple teams, they are taken
through an intermediate page to select for which team they are
submitting their review.
- The form is similar (and using the same code) as the usual review
completion, with a few extra fields for the review type and reviewer,
which would usually already be known.
- When submitting the review, a ReviewRequest and ReviewAssignment are
automatically created. The assignment is then immediately closed in
the usual way.
- Other workflows are unchanged.
The issues with the review form in #2061 are slightly worse for the
unsolicited review scenario, but that will be improved when #2061 is
fixed.
Commit ready for merge.
- Legacy-Id: 16924
2019-10-24 12:37:59 +00:00
Sasha Romijn
93797b3fc1
Fix #2087 - Show doc authors and WG chairs in unassigned reviews views.
...
Commit ready for merge.
- Legacy-Id: 16923
2019-10-24 07:25:47 +00:00
Sasha Romijn
9df5839874
Fix #2123 - Use a DBTemplate when a review assignment is mailed.
...
The message sent to a reviewer when a new review is assigned to them,
is now taken from a DBTemplate, allowing it to be customised
per team. This includes a migration to create a default template,
which looks the same as before.
Commit ready for merge.
- Legacy-Id: 16921
2019-10-23 16:06:44 +00:00
Henrik Levkowetz
3e9bad1c8b
Merged in [16883] from sasha@dashcare.nl:
...
Fix #2277 - Do not allow reviewers to reject overdue reviews.
If a review request is past the deadline, reviewers will no longer be
able to reject the assignment.
- Legacy-Id: 16909
Note: SVN reference [16883] has been migrated to Git commit 3c2b01b3ff
2019-10-22 20:59:13 +00:00
Henrik Levkowetz
6688d37bb4
Merged in [16875] from rjsparks@nostrum.com:
...
Adds docs with blocking positions to the ADs my-documents page. Fixes #2800 .
- Legacy-Id: 16906
Note: SVN reference [16875] has been migrated to Git commit f7d4600371b3f2a3c92aa184b517ed4ebee3a118
2019-10-22 17:43:54 +00:00
Henrik Levkowetz
04e342b3ce
Merged in [16860] from rjsparks@nostrum.com:
...
Be resilient to statistics queries that provide a state but not a substate. Fixes #2813 .
- Legacy-Id: 16905
Note: SVN reference [16860] has been migrated to Git commit 654ae848f657957d2f7d259293ba523619d81cb5
2019-10-22 16:05:42 +00:00
Henrik Levkowetz
fc2abcce20
Fixed a couple of places where document alias.document was used instead of alias.docs.all().
...
- Legacy-Id: 16901
2019-10-22 14:19:22 +00:00
Henrik Levkowetz
9e21c011f6
Merged in [16854] from rjsparks@nostrum.com:
...
Remove some pre-ReviewAssignment refactor logic, and simplify what remains while still allowing a group secretary to not assign a row on the unassigned requests form after touching the control to assign a reviewer. Fixes #2812 .
- Legacy-Id: 16900
Note: SVN reference [16854] has been migrated to Git commit b158807134e2d26b3e013b6414b6fcbaa0e39f77
2019-10-22 12:43:56 +00:00
Henrik Levkowetz
0313a4f58d
Merged in [16836] from rjsparks@nostrum.com:
...
Changes to displaying the ballot_icon to account for IRSG ballots.
- Legacy-Id: 16896
Note: SVN reference [16836] has been migrated to Git commit 6375aa3bedbd612cd519bf3dccced2465b145593
2019-10-21 19:37:36 +00:00
Sasha Romijn
3c2b01b3ff
Fix #2277 - Do not allow reviewers to reject overdue reviews.
...
If a review request is past the deadline, reviewers will no longer be
able to reject the assignment.
Commit ready for merge.
- Legacy-Id: 16883
2019-10-21 14:15:08 +00:00
Henrik Levkowetz
77abc3868e
Type checking tweaks.
...
- Legacy-Id: 16867
2019-10-15 16:54:33 +00:00
Henrik Levkowetz
5460a5ab84
Merged in [16785] from rjsparks@nostrum.com:
...
Improve alerts when looking at non-current versions of a charter document. Fixes #2774 .
- Legacy-Id: 16845
Note: SVN reference [16785] has been migrated to Git commit 07637c27e1a76d3cbb92cc22b987b9f1426d8d52
2019-10-08 14:24:01 +00:00
Henrik Levkowetz
a895e19882
Merged in [16770] from rjsparks@nostrum.com:
...
Populate completed_on when rejecting a ReviewAssignment. Migrate past rejected assignments accordingly. Fixes #2782 .
- Legacy-Id: 16841
Note: SVN reference [16770] has been migrated to Git commit 661e4c5369dc0d165bfcb56e3278906fe1de3b55
2019-10-08 12:46:49 +00:00
Henrik Levkowetz
1edc863969
Merged in [16763] from rjsparks@nostrum.com:
...
Allow responsible AD to be None for documents in iesg states idexists and dead. Fixes #2803 and #993 .
- Legacy-Id: 16838
Note: SVN reference [16763] has been migrated to Git commit 9f54af355d4e2b17404caa1755be74d22b5edad1
2019-10-07 19:54:56 +00:00
Henrik Levkowetz
8c71252fee
Merged in [16688] from sasha@dashcare.nl:
...
Fix #2478 - When completing review, show which addresses it is posted to.
- Legacy-Id: 16795
Note: SVN reference [16688] has been migrated to Git commit 68ea11a916
2019-10-01 15:02:03 +00:00
Henrik Levkowetz
25ac3b67f5
Merged in [16680] from sasha@dashcare.nl:
...
Fix #2354 - Make review_completed configurable per team and review type
This includes a migration to change mailtrigger slugs to be up to 64
characters instead of 32, as some slugs would not fit and require clunky
abbreviations.
A data migration creates triggers for existing teams, and they are also
created on the fly if a trigger does not exist yet, providing a safe
fallback for new review teams. The review_completed mailtrigger serves
as the template for new triggers.
This commit also includes tests for gather_address_lists(), as none
existed.
- Legacy-Id: 16794
Note: SVN reference [16680] has been migrated to Git commit 1390ae073c
2019-10-01 13:35:52 +00:00
Henrik Levkowetz
70380cb8ea
Merged in [16672] from sasha@dashcare.nl:
...
Fix #2328 - Use mailtriggers to find destinations in review app
As the review app has several conditionals that don't fit
entirely well within mailtriggers, the templates use a bit
of extra context to figure out who exactly to include. This also
extends the tests for review, to check for correct recipients.
It also adds a tiny feature to mailtrigger to entirely exclude
certain addresses, as required by the review-generated mails.
- Legacy-Id: 16793
Note: SVN reference [16672] has been migrated to Git commit 88b7b45b0e
2019-10-01 13:06:48 +00:00
Henrik Levkowetz
632423aa6c
Merged in [16670] from sasha@dashcare.nl:
...
Fix #2590 - Allow secretary to adjust date when completing a review.
This also fixes other issues identified in #2590 , around the
modification of historical document events. The behaviour is now:
- When the assigned reviewer posts a review, a single event is
created, set to current date/time.
- When the secretary records a review in the datatracker, they may
set a different completion date, which is autofilled if an email
is selected. One event is generated for the original completion
date, and one for the secretary's action.
- Each revision generates a new event, rather than updating previous
existing events.
- Legacy-Id: 16791
Note: SVN reference [16670] has been migrated to Git commit 3942f9acc7
2019-10-01 12:05:04 +00:00
Henrik Levkowetz
10c8596664
Merged in [16667] from sasha@dashcare.nl:
...
Fix #2071 - Add optional comment field for close request.
- Legacy-Id: 16786
Note: SVN reference [16667] has been migrated to Git commit 4669b0934b
2019-09-30 20:55:16 +00:00
Henrik Levkowetz
33e8733b91
Fixed up mypy issues or added type:ignore comments as needed for a clean mypy run.
...
- Legacy-Id: 16772
2019-09-30 15:42:18 +00:00
Henrik Levkowetz
a3f59ee9a2
Added conversion of version 3 XML draft submissions to v3 HTML, in addition to text. Added a link to HTML versions (when present) to the document status page, and renamed the link to the htmlized version to 'htmlized'. Converted the submission XML test-file to version 3. Added test code to check that HTML is generated for version 3 XML submissions.
...
- Legacy-Id: 16737
2019-09-20 14:24:44 +00:00
Henrik Levkowetz
44f42cdb3a
Undid the previous commit
...
- Legacy-Id: 16735
2019-09-20 11:30:04 +00:00
Henrik Levkowetz
e3e9f676b7
Added class 'bg-danger' to submission error messages. The big 'Meta-Data errors found' pane on red background is so noticeable that class 'text-danger' which gives bold text is insufficient to stand out clearly. Adding 'bg-danger' gives the specific error messages red background, too.
...
- Legacy-Id: 16734
2019-09-20 11:28:53 +00:00
Henrik Levkowetz
4283740bf1
Added a link to RFCs rendered with inline errata (where available) to the /doc/rfcNNNN pages.
...
- Legacy-Id: 16732
2019-09-13 22:59:38 +00:00
Henrik Levkowetz
96f6f47758
Updated rfc-editor sync code to recognize the new Tooling Issue queue state.
...
- Legacy-Id: 16730
2019-09-11 16:20:25 +00:00
Henrik Levkowetz
3160f55597
Added code to catch a form error regularly caused by form spam and return a failure instead of triggering a server 500.
...
- Legacy-Id: 16728
2019-09-10 16:10:11 +00:00
Henrik Levkowetz
3336f4a11b
Merged in [16656] from rjsparks@nostrum.com:
...
Add IANA expert review tracking.
- Legacy-Id: 16716
Note: SVN reference [16656] has been migrated to Git commit e45a32e49f
2019-09-08 14:34:29 +00:00
Henrik Levkowetz
1c38387279
Merged in [16649] from rjsparks@nostrum.com:
...
Guard against attempts to use the review request view with a ReviewRequest id that does not match the document for the ReviewRequest. This would have exposed #2776 much earlier.
- Legacy-Id: 16710
Note: SVN reference [16649] has been migrated to Git commit 01ceeba131
2019-09-05 22:59:59 +00:00
Henrik Levkowetz
e49ff19255
Merged in [16615] from peter@akayla.com:
...
Spelling correction in a comment. No open issue.
- Legacy-Id: 16697
Note: SVN reference [16615] has been migrated to Git commit 7f6edfcabc
2019-09-03 12:52:26 +00:00
Sasha Romijn
68ea11a916
Fix #2478 - When completing review, show which addresses it is posted to.
...
Commit ready for merge.
- Legacy-Id: 16688
2019-09-02 15:52:26 +00:00
Sasha Romijn
1390ae073c
Fix #2354 - Make review_completed configurable per team and review type
...
This includes a migration to change mailtrigger slugs to be up to 64
characters instead of 32, as some slugs would not fit and require clunky
abbreviations.
A data migration creates triggers for existing teams, and they are also
created on the fly if a trigger does not exist yet, providing a safe
fallback for new review teams. The review_completed mailtrigger serves
as the template for new triggers.
This commit also includes tests for gather_address_lists(), as none
existed.
Commit ready for merge.
- Legacy-Id: 16680
2019-08-30 17:40:55 +00:00
Henrik Levkowetz
7ad34ba69e
The logic for displaying 'Email requested to be sent for earlier discuss' on IESG positions was wrong; it would count later discusses and discusses from other ADs as an 'earlier discuss'. Moved any_email_sent() from ballot to position, and refined the criteria.
...
- Legacy-Id: 16675
2019-08-28 20:56:34 +00:00
Sasha Romijn
88b7b45b0e
Fix #2328 - Use mailtriggers to find destinations in review app
...
As the review app has several conditionals that don't fit
entirely well within mailtriggers, the templates use a bit
of extra context to figure out who exactly to include. This also
extends the tests for review, to check for correct recipients.
It also adds a tiny feature to mailtrigger to entirely exclude
certain addresses, as required by the review-generated mails.
Commit ready for merge.
- Legacy-Id: 16672
2019-08-27 15:15:13 +00:00
Sasha Romijn
3942f9acc7
Fix #2590 - Allow secretary to adjust date when completing a review.
...
This also fixes other issues identified in #2590 , around the
modification of historical document events. The behaviour is now:
- When the assigned reviewer posts a review, a single event is
created, set to current date/time.
- When the secretary records a review in the datatracker, they may
set a different completion date, which is autofilled if an email
is selected. One event is generated for the original completion
date, and one for the secretary's action.
- Each revision generates a new event, rather than updating previous
existing events.
- Legacy-Id: 16670
2019-08-26 12:58:31 +00:00
Sasha Romijn
4669b0934b
Fix #2071 - Add optional comment field for close request. Commit ready for merge.
...
- Legacy-Id: 16667
2019-08-23 11:37:41 +00:00
Henrik Levkowetz
9a9c9fb426
Merged in [16603] from rjsparks@nostrum.com:
...
Remove a debug statement from the command
- Legacy-Id: 16661
Note: SVN reference [16603] has been migrated to Git commit d27096f39022e9bee1ffa84631d5ae847af9be3e
2019-08-20 10:35:06 +00:00
Henrik Levkowetz
509e0da7ab
Merged in [16601] from rjsparks@nostrum.com:
...
A management command to correct the state of several slide presentations uploaded during IETF105, and perform some missed powerpoint to pdf conversions.
- Legacy-Id: 16659
Note: SVN reference [16601] has been migrated to Git commit a14188d95cf200dfbdd93485b89808f3336b0649
2019-08-19 17:50:56 +00:00
Robert Sparks
e45a32e49f
Add IANA expert review tracking. Commit ready for merge.
...
- Legacy-Id: 16656
2019-08-15 20:36:07 +00:00
Robert Sparks
01ceeba131
Guard against attempts to use the review request view with a ReviewRequest id that does not match the document for the ReviewRequest. This would have exposed #2776 much earlier. Commit ready for merge.
...
- Legacy-Id: 16649
2019-08-14 16:06:13 +00:00
Henrik Levkowetz
8e313e4ed5
Adjusted migrations for Python2/3 compatibility.
...
- Legacy-Id: 16633
2019-08-08 17:11:14 +00:00
Peter E. Yee
7f6edfcabc
Spelling correction in a comment. No open issue. Commit ready for merge.
...
- Legacy-Id: 16615
2019-08-04 23:58:43 +00:00
Henrik Levkowetz
41c6bbf62e
Merged in [16563] from housley@vigilsec.com:
...
Improve performance for a few pages
- Legacy-Id: 16613
Note: SVN reference [16563] has been migrated to Git commit 765ce0d0b0
2019-08-04 15:44:06 +00:00
Henrik Levkowetz
0a591e4b2e
Merged in [16562] from rcross@amsl.com:
...
Added encoding='utf-8' parameter to io.open operations in tests that starting failing since adding unicode_literals.
- Legacy-Id: 16588
Note: SVN reference [16562] has been migrated to Git commit d332bfd91d
2019-07-24 23:44:36 +00:00
Henrik Levkowetz
7039520557
Merged in [16557] from pusateri@bangj.com:
...
Partially addresses issue #1926 still displaying markdown as text. Fixes #2704 .
- Legacy-Id: 16576
Note: SVN reference [16557] has been migrated to Git commit f76c46bef0
2019-07-22 18:09:53 +00:00
Russ Housley
765ce0d0b0
Improve performance for a few pages
...
- Legacy-Id: 16563
2019-07-20 22:59:26 +00:00
Ryan Cross
d332bfd91d
Added encoding='utf-8' parameter to io.open operations in tests that starting failing since adding unicode_literals. Commit ready to merge
...
- Legacy-Id: 16562
2019-07-20 22:54:14 +00:00
Henrik Levkowetz
8ec951c44a
Shortened generated document titles a tad, to avoid line wrapping in the IESG agenda package (which breaks the relevant test).
...
- Legacy-Id: 16518
2019-07-18 10:17:17 +00:00
Henrik Levkowetz
bbff4b0e69
Replaced six.ensure_str with django's force_str
...
- Legacy-Id: 16513
2019-07-17 18:43:40 +00:00
Henrik Levkowetz
57e16bfd57
Fixed a typo.
...
- Legacy-Id: 16511
2019-07-17 16:14:55 +00:00
Henrik Levkowetz
e03784132d
Merged changes from current trunk to Py3 branch.
...
- Legacy-Id: 16468
2019-07-16 15:36:16 +00:00
Henrik Levkowetz
bdc73e771a
Python2/3 compatibility: replaced six.ensure_text() with either six.text_type or django's force_text(), depending on the case, and fixed a variable scope issue.
...
- Legacy-Id: 16461
2019-07-16 13:20:05 +00:00
Henrik Levkowetz
8c6eb3a30a
Python2/3 compatibility: Changed the use of open() and StringIO to io.open() etc.
...
- Legacy-Id: 16458
2019-07-15 19:14:04 +00:00
Henrik Levkowetz
2cfb81fc83
Changed instances of email body extaction to use a custom get_payload() function.
...
- Legacy-Id: 16454
2019-07-15 17:15:16 +00:00
Henrik Levkowetz
a5e31c3f40
Py2/3 compatibility: Added __future__ import.
...
- Legacy-Id: 16452
2019-07-15 15:52:18 +00:00
Henrik Levkowetz
28472a462b
Python2/3 compatibility: Added more elements to list (tuple) entries to ensure sorting without exceptions under Python3.
...
- Legacy-Id: 16451
2019-07-15 15:51:26 +00:00
Henrik Levkowetz
855716e1d5
Py2/3 compatibility: Added __future__ import
...
- Legacy-Id: 16448
2019-07-15 15:46:06 +00:00
Henrik Levkowetz
2d7c9629aa
Added 'from __future__' imports all over the place, to bring code behaviour into closer alignment between python2 and python3
...
- Legacy-Id: 16446
2019-07-15 15:40:51 +00:00
Henrik Levkowetz
f481f5c3e6
Replaced use of six with the equivalent pure python3 constructs.
...
- Legacy-Id: 16428
2019-07-08 10:43:47 +00:00
Henrik Levkowetz
f8d4c3c9a6
More assertContains() and BytesIO() related changes.
...
- Legacy-Id: 16411
2019-07-07 12:45:57 +00:00
Henrik Levkowetz
04a728c23d
Fixed bytes/str issues in some migrations (models.Index() arguments).
...
- Legacy-Id: 16410
2019-07-07 12:41:11 +00:00
Henrik Levkowetz
0679eaa8d4
Removed unused imports.
...
- Legacy-Id: 16402
2019-07-04 21:06:57 +00:00
Henrik Levkowetz
f480799af9
Undid unintentional bulk commit
...
- Legacy-Id: 16401
2019-07-04 21:04:46 +00:00
Henrik Levkowetz
fc09a59950
Added decode() of command pipe output.
...
- Legacy-Id: 16400
2019-07-04 21:01:39 +00:00
Henrik Levkowetz
d957f32690
Fixed a syntax error and removed unused imports.
...
- Legacy-Id: 16389
2019-07-04 20:48:55 +00:00
Henrik Levkowetz
a1e7dc9acc
Changed a function name.
...
- Legacy-Id: 16386
2019-07-04 16:10:21 +00:00
Henrik Levkowetz
81fa6dc962
Fixed some issues with bulk changes related to assertContains()
...
- Legacy-Id: 16379
2019-07-04 16:04:39 +00:00
Henrik Levkowetz
f33ecaa1a4
Fixed a test that compared an int with a meeting number string. Changed meeting test data to use meeting number 72 instead of 42, because proceedings code gives 404 for meetings before 65. Changed a number of StringIO() to BytesIO().
...
- Legacy-Id: 16378
2019-07-04 16:01:32 +00:00
Henrik Levkowetz
b7690fbdcd
Changed additional regexes to r strings.
...
- Legacy-Id: 16377
2019-07-04 15:54:23 +00:00
Henrik Levkowetz
0589d0b313
Changed a bunch of regexes to use r strings; also miscellaneous smaller fixes.
...
- Legacy-Id: 16376
2019-07-04 15:51:05 +00:00
Henrik Levkowetz
97a555936d
Changed a large number of test assertions to use assertContains() and removed separate, now unnecessary,status_code checks. Also changed many assertTrue(... in ...) to use assertIn().
...
- Legacy-Id: 16346
2019-06-30 21:03:34 +00:00
Henrik Levkowetz
ff6997df2b
Fixed a case of indeterminate ordering.
...
- Legacy-Id: 16343
2019-06-30 20:58:26 +00:00
Henrik Levkowetz
8b52899459
Fixed some additional str/bytes issues.
...
- Legacy-Id: 16342
2019-06-30 20:56:56 +00:00
Henrik Levkowetz
36cac48063
Fixed a bunch of str/bytes issues.
...
- Legacy-Id: 16341
2019-06-30 20:54:09 +00:00
Henrik Levkowetz
05f275a3af
Changed instances of json.loads(r.content) to r.json(). Changed some instances of assert* to assertContains.
...
- Legacy-Id: 16338
2019-06-30 20:44:45 +00:00
Henrik Levkowetz
15e74e89cb
Converted instances of assertTrue(text in response.content) to the recommended assertContains(response, text), and similar for assertFalse(... in ...)
...
- Legacy-Id: 16336
2019-06-29 13:43:31 +00:00
Henrik Levkowetz
42c620f4ae
Fixed search result ordering where we had comparisons between int and str, which is disallowed in py3.
...
- Legacy-Id: 16335
2019-06-29 13:32:44 +00:00
Henrik Levkowetz
2b1f238204
Changed regex strings to raw strings and fixed a sort comparison int/str issue.
...
- Legacy-Id: 16333
2019-06-29 13:29:13 +00:00
Henrik Levkowetz
484dcece5f
Changed all model __unicode__() methods to __str__()
...
- Legacy-Id: 16330
2019-06-28 21:07:08 +00:00
Henrik Levkowetz
d40a5ac5ac
Removed some regex unicode flags.
...
- Legacy-Id: 16321
2019-06-28 13:33:38 +00:00
Henrik Levkowetz
06daf6ac65
Changed regex strings to raw strings.
...
- Legacy-Id: 16312
2019-06-27 18:08:02 +00:00
Henrik Levkowetz
3ec7e864be
Converted leading tabs to spaces in ietf/**/*.py
...
- Legacy-Id: 16310
2019-06-27 14:51:02 +00:00
Henrik Levkowetz
d7f5c84182
Initial 2to3 patch with added copyright statement updates.
...
- Legacy-Id: 16309
2019-06-27 14:40:54 +00:00
Henrik Levkowetz
db12f2b948
Fixed some name versus pk issues lingering after the Document/DocAlias primary key refactoring. Fixes issue #2729 .
...
- Legacy-Id: 16288
2019-06-19 12:57:52 +00:00
Henrik Levkowetz
7270d5f67a
Added the option to order API resource lists by primary key, for stable ordering when paging through a list.
...
- Legacy-Id: 16284
2019-06-18 12:40:19 +00:00
Henrik Levkowetz
565c55ab05
The Document and DocAlias primary key refactoring caused the Tastypie API under /api/v1/ to change -- reverting that to use the old form, with name ask key.
...
- Legacy-Id: 16282
2019-06-17 18:53:17 +00:00
Henrik Levkowetz
05c5abed53
Added a missing migration
...
- Legacy-Id: 16263
2019-06-16 13:18:06 +00:00
Henrik Levkowetz
be92e6b868
Removed an incorrect log.unreachble() invocation.
...
- Legacy-Id: 16262
2019-06-15 21:32:15 +00:00
Henrik Levkowetz
426870b766
Merged in the Document and DocAlias primary key change and m2m work in ^/personal/henrik/6.96.1-docalias.
...
- Legacy-Id: 16261
2019-06-15 12:00:48 +00:00
Henrik Levkowetz
a2cafded25
Changed DocAlias to be many-to-many, in order to be able to handle STD aliases referring to multiple RFCs.
...
- Legacy-Id: 16249
2019-06-14 20:38:14 +00:00
Henrik Levkowetz
815602351f
This is a series of 50 migrations that changes the Document and DocAlias
...
primary keys from character strings to integers, and makes corresponding code
changes.
This was prompted by database limitations discovered when trying to make
DocAlias use a m2m document field; with 255 long strings as primary keys for
Document and DocAlias this violated the MySQL database limitations.
Changing the primary keys to integers should also improve efficiency.
Due to the data migrations which create the new integer primary keys and adds
corresponding integer foreign keys matching the previous string foreign keys
in all tables having foreign keys to Document and DocAlias, some of these
migrations take a long time. The total set of migrations are expected to have
a runtime on the order of 2 hours.
- Legacy-Id: 16237
2019-06-10 11:32:46 +00:00
Henrik Levkowetz
1b5cdfe2f5
Added review assignment information to the review-document view. Addresses issue #2717 .
...
- Legacy-Id: 16203
2019-05-07 21:53:38 +00:00
Henrik Levkowetz
2538a581c2
Whitespace changes only
...
- Legacy-Id: 16187
2019-05-06 13:32:29 +00:00
Henrik Levkowetz
ed2042da0e
Some additional tweaks to the review assingment migrations.
...
- Legacy-Id: 16183
2019-05-02 15:40:21 +00:00
Henrik Levkowetz
9282195d6c
Fixed some migrations issues that prevented the review assignment refactoring migrations from being reversed and re-applied.
...
- Legacy-Id: 16182
2019-05-02 13:49:14 +00:00
Henrik Levkowetz
ca1f3340c0
Changed a ReviewAssignmentDocEvent type from 'closed_review_request' to 'closed_review_assignment', for consistency and readability.
...
- Legacy-Id: 16181
2019-05-02 12:38:41 +00:00
Henrik Levkowetz
8726e74709
Merged in a refactoring of document review code from rjsparks@nostrum.com. This introduces ReviewAssignments, letting us do multiple assingments for a given RevieRequest, without conflating the assignments and their results with the request itself.
...
- Legacy-Id: 16177
2019-04-30 16:54:06 +00:00
Henrik Levkowetz
bb4fe3fbbf
Undid previous commit
...
- Legacy-Id: 16153
2019-04-22 19:22:42 +00:00
Henrik Levkowetz
cfcefc2e32
Merged in [16144] from housley@vigilsec.com:
...
Remove some clutter from I-D upload page. The information was mived to the Instructions tab, but a higligh to the Note Well and BCP 78 was added. Fixes #2057 .
- Legacy-Id: 16151
Note: SVN reference [16144] has been migrated to Git commit 37851b9742
2019-04-22 17:39:26 +00:00
Henrik Levkowetz
33e0f8c35d
Merged in [16126] from housley@vigilsec.com:
...
Allow Secretariat to handle downrefs when they approve a document
- Legacy-Id: 16134
Note: SVN reference [16126] has been migrated to Git commit 8c7e75101d
2019-04-08 17:02:02 +00:00
Henrik Levkowetz
5aad3a652d
Merged in [16110] from rjsparks@nostrum.com:
...
Include the note itself in email sent when the RFC editor note changes after document approval. Also changed the flow to redirect back to the writeups pages after editing the RFC editor note. Fixes #2672 .
- Legacy-Id: 16130
Note: SVN reference [16110] has been migrated to Git commit fbfd204eb9
2019-04-03 19:30:10 +00:00
Henrik Levkowetz
c7e5459d5a
Merged in [16109] from rjsparks@nostrum.com:
...
Protect drafts in certain IRTF states from expiring. Fixes #2669 .
- Legacy-Id: 16129
Note: SVN reference [16109] has been migrated to Git commit 003e472d04
2019-04-03 19:03:38 +00:00
Russ Housley
8c7e75101d
Allow Secretariat to handle downrefs when they approve a document
...
- Legacy-Id: 16126
2019-04-01 19:46:14 +00:00
Robert Sparks
fbfd204eb9
Include the note itself in email sent when the RFC editor note changes after document approval. Also changed the flow to redirect back to the writeups pages after editing the RFC editor note. Fixes #2672 . Commit ready for merge.
...
- Legacy-Id: 16110
2019-03-28 10:07:11 +00:00
Robert Sparks
003e472d04
Protect drafts in certain IRTF states from expiring. Fixes #2669 . Commit ready for merge.
...
- Legacy-Id: 16109
2019-03-28 08:48:35 +00:00
Peter E. Yee
cfdbae1f3c
Fixed bad calls to rfcdiff for -00 drafts and replaced drafts. Fixes issue #2697 . Commit ready for merge.
...
- Legacy-Id: 16095
2019-03-23 18:17:51 +00:00
Robert Sparks
81c5b5091a
Made some docevent creation more consistent. Addressed the TODOs added during the refactor.
...
- Legacy-Id: 16049
2019-03-19 18:48:05 +00:00
Robert Sparks
f57fb6b8a6
Added the ability to withdraw individual assignments. Added the ability to mark individual assignments no-response.
...
- Legacy-Id: 16039
2019-03-18 21:15:20 +00:00
Robert Sparks
da3174ab68
Improved several views.
...
- Legacy-Id: 16038
2019-03-18 19:41:07 +00:00
Robert Sparks
4b147f2ef8
More cleanup and correction. Caught a pervasive misuse of a state-name
...
- Legacy-Id: 16036
2019-03-15 20:39:06 +00:00
Henrik Levkowetz
56543d565c
Changed sending of PubReq messages to explicitly use on-behalf-of, without Reply-To. Reply-To is picked up as requestor by RT. Fixes issue #2691 anew.
...
- Legacy-Id: 16034
2019-03-14 21:31:40 +00:00
Robert Sparks
334767fa6f
Some admin tweaks and removal of a dead template. Tests all pass now. Functionality is still not right.
...
- Legacy-Id: 16032
2019-03-14 19:14:33 +00:00
Robert Sparks
0856990683
Checkpoint. Most tests do not fail. Oddness with an API resource, and with one template's coverage
...
- Legacy-Id: 16031
2019-03-14 18:39:40 +00:00
Robert Sparks
a4db66564c
Checkpoint. Ended up chasing group.views_review before stats.
...
- Legacy-Id: 16030
2019-03-13 22:02:10 +00:00
Robert Sparks
073ce55f6c
Checkpoint. ReviewTests pass, but others still fail of course. Next step is to address stats.
...
- Legacy-Id: 16021
2019-03-12 17:48:19 +00:00
Henrik Levkowetz
682ddee8e4
Reverted earlier application of on_behalf_of() at mail sending call points, and instead did all on_behalf_of processing in condition_message(). Added insertion of Reply-To header fields in this case. Changed all use of the mail-sending 'extra' parameters to use value lists. Updated a bunch of tests accordingly.
...
- Legacy-Id: 16020
2019-03-11 17:01:33 +00:00
Henrik Levkowetz
df42be5d0c
Converted a test to use .assertIn() instead of .assertTrue(... in ...) for better failure reports.
...
- Legacy-Id: 16016
2019-03-09 14:56:47 +00:00
Robert Sparks
b85052fe63
Checkpoint. Lots of tests will still fail. Reordered some migrations. Brought about half of the ietf.doc.views_review views into line with the new models. Next step is the other half.
...
- Legacy-Id: 16012
2019-03-07 23:08:14 +00:00
Henrik Levkowetz
896f4cd8c7
Fixed a test discrepancy.
...
- Legacy-Id: 15995
2019-03-05 16:19:28 +00:00
Henrik Levkowetz
55bd2e5e42
Fixed some unintentional wg list address changes, and added some other test mail address changes.
...
- Legacy-Id: 15994
2019-03-04 20:54:38 +00:00
Henrik Levkowetz
435a0da12d
Added on_behalf_of() calls for from addresses needing it throughout the code.
...
- Legacy-Id: 15992
2019-03-04 20:14:19 +00:00
Henrik Levkowetz
2b811b3d3d
Updated the tests to always use @ietf.org addresses where appropriate, and not do so when not appropriate. All test user login addresses have been changed away from @ietf.org.
...
- Legacy-Id: 15988
2019-03-04 20:08:48 +00:00
Robert Sparks
82025f9dca
Continuing to checkpoint.
...
- Legacy-Id: 15986
2019-03-01 23:23:39 +00:00
Robert Sparks
e91d706d5b
Checkpointing. This is an incomplete idea. The tests will fail massively.
...
- Legacy-Id: 15985
2019-03-01 23:19:47 +00:00
Henrik Levkowetz
c9db218e31
Increased the DocumentURL.url field length to the legal URL maximum of 2083
...
- Legacy-Id: 15972
2019-02-25 21:05:25 +00:00
Henrik Levkowetz
b57ad67041
Updated code and templates to use the new docman and groupman group features.
...
- Legacy-Id: 15922
2019-01-30 15:59:00 +00:00
Henrik Levkowetz
ef97f2a821
Merged in GroupFeatures refactoring and expansion from ^/personal/henrik/6.89.4.dev0@15911.
...
- Legacy-Id: 15912
2019-01-24 15:25:01 +00:00
Henrik Levkowetz
c87d3741f3
Added 2 utility functions to help create group features query filters, and applied them in 3 places in order to move group feature role list code back into DB queries.
...
- Legacy-Id: 15911
2019-01-23 18:40:39 +00:00
Henrik Levkowetz
57a4c9f41f
Added 9 new group features, and changed list-like char fields to json fields, to get better support for using the values as lists. Modified code to use the group features instead of explicit lists of group types in many places in the code.
...
- Legacy-Id: 15908
2019-01-22 18:11:46 +00:00
Henrik Levkowetz
f671e391f7
Reverted r15071 with respects to showing the submit for publication button to shepherds. Fixes issue #2673 .
...
- Legacy-Id: 15906
2019-01-21 12:32:13 +00:00
Henrik Levkowetz
b4e46cd559
Migration reordering to avoid schema migrations after data migrations.
...
- Legacy-Id: 15881
2019-01-14 14:22:13 +00:00
Robert Sparks
87dd249415
Cleanup: removed the infrastructure for importing reviews from the old review tool. Commit ready for merge.
...
- Legacy-Id: 15865
2019-01-03 21:04:13 +00:00
Robert Sparks
25cc00f925
Refactored DocumentInfo to address overloading the external_url field with strings that are not URLs. Commit ready for merge.
...
- Legacy-Id: 15864
2019-01-02 22:55:00 +00:00
Robert Sparks
f6886f6105
Corrected a conditional expression and improved the test that exercised it. Commit ready for merge.
...
- Legacy-Id: 15822
2018-12-14 21:50:21 +00:00
Robert Sparks
6118975620
Added an explicit ID-Exists state for the IESG state machine. Reworked code so that the IESG state machine always has a state. Added the ability to release a document from a working group, research group, or the independent stream. Releasing a document removes all stream state, and sets the document to have no stream.
...
- Legacy-Id: 15809
2018-12-11 22:38:05 +00:00
Henrik Levkowetz
d2b86bc225
Increased the document limit from 200 to 500 for the AD documents page.
...
- Legacy-Id: 15788
2018-11-26 18:52:18 +00:00
Henrik Levkowetz
68c48f19a0
Improved resolution of an issue with the To: and Cc: addresses of extra review email to responsible AD.
...
- Legacy-Id: 15778
2018-11-20 13:36:12 +00:00
Henrik Levkowetz
9821406f60
Fixed an issue with the To: and Cc: addresses of extra review email to responsible AD.
...
- Legacy-Id: 15777
2018-11-20 13:20:16 +00:00
Henrik Levkowetz
143a58d3cc
Added handling for an EOF exception that can occur when using the django file-based cache.
...
- Legacy-Id: 15769
2018-11-13 13:39:47 +00:00
Henrik Levkowetz
13b20f83cb
Merged in [15720] from rjsparks@nostrum.com:
...
invalidate the get_state_slug cache when the get_state cache is invalidated. Fixes #2630 .
- Legacy-Id: 15760
Note: SVN reference [15720] has been migrated to Git commit f1c1b9fc6c
2018-11-12 15:38:17 +00:00
Henrik Levkowetz
3b811ecb41
Merged in [15708] and [15730] from housley@vigilsec.com:
...
Added a mail alias for all review team secretaries. Fixes #2139 . Use
the alias if there is one for email about review request changes. Added
a test for the review team secretary alias functionality.
- Legacy-Id: 15746
Note: SVN reference [15708] has been migrated to Git commit 6067dcbfef
Note: SVN reference [15730] has been migrated to Git commit d525ade0b0
2018-11-10 19:30:32 +00:00
Henrik Levkowetz
0d9c97c5ca
Added a test that checks the mailarch search failure return, and tweaks the no-result return handling.
...
- Legacy-Id: 15745
2018-11-10 19:06:40 +00:00
Henrik Levkowetz
236ee7639d
Merged in [15706] from kivinen@iki.fi:
...
Added easier to detect error message when search returns 0 results. This currently parses html result from the mailarchive system, but when we get proper API to mailarchive system it should be changed to do that instead. Fixes #2126 .
- Legacy-Id: 15744
Note: SVN reference [15706] has been migrated to Git commit f9eeee0cc9
2018-11-09 21:23:45 +00:00
Henrik Levkowetz
89ef806013
Merged in [15701] from kivinen@iki.fi:
...
Changed format of the reviewer statistics in lists. Fixes #2131 .
- Legacy-Id: 15735
Note: SVN reference [15701] has been migrated to Git commit 56acd00c6c
2018-11-07 05:24:25 +00:00
Russ Housley
d525ade0b0
Use review team secretary alias if there is one for email about review request changes. Add test for review team secretary alias. Commit ready for merge.
...
- Legacy-Id: 15730
2018-11-06 07:26:30 +00:00
Henrik Levkowetz
e4af908a74
Merged in [15698] from rjsparks@nostrum.com:
...
Notify the RFC Editor when an RFC Editor note is changed after a draft has been approved. Fixes #2440 .
- Legacy-Id: 15729
Note: SVN reference [15698] has been migrated to Git commit 43374969f6
2018-11-06 07:13:56 +00:00
Robert Sparks
f1c1b9fc6c
invalidate the get_state_slug cache when the get_state cache is invalidated. Fixes #2630 . Commit ready for merge.
...
- Legacy-Id: 15720
2018-11-05 22:43:02 +00:00
Tero Kivinen
f9eeee0cc9
Added easier to detect error message when search returns 0 results. This currently parses html result from the mailarchive system, but when we get proper API to mailarchive system it should be changed to do that instead. Fixes #2126 . Commit ready for merge.
...
- Legacy-Id: 15706
2018-11-03 11:08:18 +00:00
Tero Kivinen
56acd00c6c
Changed format of the reviewer statistics in lists. Fixes #2131 . Commit ready for merge.
...
- Legacy-Id: 15701
2018-11-03 09:04:57 +00:00
Henrik Levkowetz
3b8d9ae832
Merged in [15684] from rjsparks@nostrum.com:
...
Removed the field and widget that made editing document states easier on the document admin page since they do not survive validation failure of other fields on the form. Excluded states from the modelform since the default states widget is almost impossible to use without producing bad data. If states need to be edited through the admin, it will, for now, need to be done gruelingly through the admin form for State. Fixes #2524 .
- Legacy-Id: 15700
Note: SVN reference [15684] has been migrated to Git commit 128c0a6dbb
2018-11-03 09:01:59 +00:00
Robert Sparks
43374969f6
Notify the RFC Editor when an RFC Editor note is changed after a draft has been approved. Fixes #2440 . Commit ready for merge.
...
- Legacy-Id: 15698
2018-11-03 08:13:10 +00:00
Robert Sparks
5db8831b81
Clearly label cancelled sessions on the week-view on the agenda page. Fixes #2619 . Commit ready for merge.
...
- Legacy-Id: 15694
2018-11-03 06:57:59 +00:00
Henrik Levkowetz
95161df4f4
Merged in [15679] from mahoney@nostrum.com:
...
Verb tense used in Ballot Issued emails now matches whether the LC end date is in the past or future. Fixes issue #2482 .
- Legacy-Id: 15685
Note: SVN reference [15679] has been migrated to Git commit 194d8c89d1
2018-11-03 04:37:41 +00:00
Robert Sparks
128c0a6dbb
Removed the field and widget that made editing document states easier on the document admin page since they do not survive validation failure of other fields on the form. Excluded states from the modelform since the default states widget is almost impossible to use without producing bad data. If states need to be edited through the admin, it will, for now, need to be done gruelingly through the admin form for State. Fixes #2524 . Commit ready for merge.
...
- Legacy-Id: 15684
2018-11-03 04:28:50 +00:00
Jean Mahoney
194d8c89d1
Verb tense used in Ballot Issued emails now matches whether the LC end date is in the past or future. Fixes issue #2482 . Commit ready for merge.
...
- Legacy-Id: 15679
2018-11-03 03:38:52 +00:00
Robert Sparks
b76ea7bcd5
Let a reviewer indicate that an AD should give this review early attention. Fixes #2553 . Commit ready for merge.
...
- Legacy-Id: 15676
2018-11-02 21:23:27 +00:00
Robert Sparks
c7bf147b1d
Let review teams opt in to poking a responsible AD when unhappy reviews are submitted. Fixes #2544 . Commit ready for merge.
...
- Legacy-Id: 15675
2018-11-02 20:18:06 +00:00
Henrik Levkowetz
282a410f3f
Merged in [15613] from rjsparks@nostrum.com:
...
Make having a trailing slash optional for doc/html/docname. Fixes #2247 .
- Legacy-Id: 15618
Note: SVN reference [15613] has been migrated to Git commit 7593230edde63d4d2e8ec04c455e862aa5e71f21
2018-10-30 14:02:46 +00:00
Henrik Levkowetz
90e773aafa
Merged in [15601] from rjsparks@nostrum.com:
...
Corrected some DocTypeName entries' prefix value. Made the search code more robust against DocTypeName objects that have an empty prefix value. Fixes #2599 .
- Legacy-Id: 15604
Note: SVN reference [15601] has been migrated to Git commit 22d459362aec2a06854a515fbcebfec54e8a6e69
2018-10-21 12:36:01 +00:00
Henrik Levkowetz
3508f59f52
Merged in [15596] from rjsparks@nostrum.com:
...
improved coverage for several tests.
- Legacy-Id: 15600
Note: SVN reference [15596] has been migrated to Git commit 6f18ae882532433ba86322b33c34f5f1b0350cb9
2018-10-19 14:27:13 +00:00
Henrik Levkowetz
ef3cbf4684
Merged in [15595] from rjsparks@nostrum.com:
...
Converted stats, submit, sync. and utils/test to use factories. Excluded utils/test_data from coverage checks.
- Legacy-Id: 15599
Note: SVN reference [15595] has been migrated to Git commit 39e76a836996ec9ed8ea449c92bdfae91c3dbaae
2018-10-19 12:54:58 +00:00
Henrik Levkowetz
15c8ab9506
Ensure the send_mail argument to save_position is a boolean.
...
- Legacy-Id: 15547
2018-10-09 16:34:45 +00:00
Henrik Levkowetz
22a2e29db8
Added an send_email field to BallotPostitionDocEvent to reflect whether the 'Send email' button was used to save the ballot position. Reverted a different earlier schema change which had the same purpose. Added icons on documents' IESG evaluation record to reflect this.
...
- Legacy-Id: 15526
2018-10-07 15:08:17 +00:00
Henrik Levkowetz
9e0e5d66b3
Merged in [15492] from rjsparks@nostrum.com:
...
Use factories for ipr tests.
- Legacy-Id: 15516
Note: SVN reference [15492] has been migrated to Git commit 775addc616
2018-10-01 17:51:17 +00:00
Henrik Levkowetz
cfb214c48a
Added a BallotCommentDocEvent, which extends DocEvent with a send_mail field, in order to better be able to show whether ballot discusses and comments were posted with with the 'send email' button or not.
...
- Legacy-Id: 15515
2018-10-01 13:31:17 +00:00
Robert Sparks
775addc616
Use factories for ipr tests. Commit ready for merge.
...
- Legacy-Id: 15492
2018-09-28 23:16:46 +00:00
Henrik Levkowetz
89b8fe6c1b
Moved document methods rfc_number() and rfcnum() to the abstract parent class to have them available also for historical document records. Should fix the recent server 500 on /doc/draft-ietf-aaa-diameter/17/.
...
- Legacy-Id: 15454
2018-09-14 20:29:07 +00:00
Robert Sparks
d9b53a5d6c
Use unversioned links in ics agendas. Partially fixes #2542 . Commit ready for merge.
...
- Legacy-Id: 15446
2018-09-10 20:12:09 +00:00
Robert Sparks
fd8af4b6f7
Review assignment email includes a link to the review request that ensures the reviewer is logged in. Fixes #2543 . Commit ready for merge
...
- Legacy-Id: 15444
2018-09-06 21:39:10 +00:00
Henrik Levkowetz
caa3ec98b4
Changed the menu listing of review dirs and their display on the Directorates page back to what it was before the 'reviews' group type was split out. Added a 'Reviews' column to the Directoratges page.
...
- Legacy-Id: 15420
2018-08-01 18:53:44 +00:00
Henrik Levkowetz
70c5dcc8c4
Merged in [15387] from rjsparks@nostrum.com:
...
Use factories for ietf.iesg.tests.
- Legacy-Id: 15406
Note: SVN reference [15387] has been migrated to Git commit 705e4c84d9
2018-07-24 08:25:07 +00:00
Henrik Levkowetz
ac55203499
Merged in [15380] from rjsparks@nostrum.com:
...
Use factories for ietf.idindex.tests.
- Legacy-Id: 15405
Note: SVN reference [15380] has been migrated to Git commit 2159fdd975
2018-07-24 07:22:26 +00:00
Henrik Levkowetz
85aa1ecc25
Tweaked a test to prevent failures when looking for a specific string in line-wrapped text.
...
- Legacy-Id: 15397
2018-07-19 15:54:18 +00:00
Robert Sparks
705e4c84d9
Use factories for ietf.iesg.tests. Commit ready for merge.
...
- Legacy-Id: 15387
2018-07-19 13:13:05 +00:00
Henrik Levkowetz
db2c326e73
Merged in [15354] from kivinen@iki.fi:
...
Added default to review completion draft version number. If the reviewer
is filling in the review form himself the default will be the latest
version of the draft. If it is someone else filling in the review
then the version number is the latest version at the point when review
was assigned (i.e., it assumes reviewer did review on version he was
requested to and then document authors might have updated the document).
Also mark the document versions that are earlier than the review request
date with red background and those which are newer with green background.
Fixes #2125 .
- Legacy-Id: 15386
Note: SVN reference [15354] has been migrated to Git commit dc3e8ee810
2018-07-18 22:36:01 +00:00
Henrik Levkowetz
b054a142d9
Merged in [15349] from kivinen@iki.fi:
...
Removed the requirement for review_content field to be mandatory when
using \'link\' method. This partially addresses #2520 . Commit ready for
merge.
- Legacy-Id: 15383
Note: SVN reference [15349] has been migrated to Git commit 0783890fa5
2018-07-18 18:20:21 +00:00
Henrik Levkowetz
e8e2db50b3
Merged in [15347] from kivinen@iki.fi:
...
Add review request date to the top. Add tooltips for drafts versions
providing the date they were sumbmitted. Fixes #2218 . Commit ready for
merge.
- Legacy-Id: 15382
Note: SVN reference [15347] has been migrated to Git commit dcabfc84f1
2018-07-18 16:36:35 +00:00
Robert Sparks
2159fdd975
Use factories for ietf.idindex.tests. Commit ready for merge.
...
- Legacy-Id: 15380
2018-07-18 15:35:20 +00:00
Henrik Levkowetz
7abece146c
Merged in [15344] from mahoney@nostrum.com:
...
email confirming interim meeting request now says 'the Area Director of the <area>' instead of '<area> Area Director'. Fixes issue #2522 .
- Legacy-Id: 15378
Note: SVN reference [15344] has been migrated to Git commit 3c478e5c52
2018-07-18 13:16:02 +00:00
Henrik Levkowetz
5b77d01a48
Merged in [15331] from housley@vigilsec.com:
...
Add test for downref in Last Call announcement
- Legacy-Id: 15366
Note: SVN reference [15331] has been migrated to Git commit e2808b1c0b
2018-07-16 16:54:56 +00:00
Tero Kivinen
dc3e8ee810
Added default to review completion draft version number. If the reviewer
...
is filling in the review form himself the default will be the latest
version of the draft. If it is someone else filling in the review
then the version number is the latest version at the point when review
was assigned (i.e., it assumes reviewer did review on version he was
requested to and then document authors might have updated the document).
Also mark the document versions that are earlier than the review request
date with red background and those which are newer with green background.
Fixes #2125 . Commit ready for merge.
- Legacy-Id: 15354
2018-07-14 21:54:04 +00:00
Tero Kivinen
0783890fa5
Removed the requirement for review_content field to be mandatory when
...
using "link" method. This partially addresses #2520 . Commit ready for
merge.
- Legacy-Id: 15349
2018-07-14 20:12:32 +00:00
Tero Kivinen
dcabfc84f1
Add review request date to the top. Add tooltips for drafts versions
...
providing the date they were sumbmitted. Fixes #2218 . Commit ready for
merge.
- Legacy-Id: 15347
2018-07-14 20:07:36 +00:00
Jean Mahoney
3c478e5c52
email confirming interim meeting request now says 'the Area Director of the <area>' instead of '<area> Area Director'. Fixes issue #2522 . Commit ready to merge.
...
- Legacy-Id: 15344
2018-07-14 18:52:38 +00:00
Russ Housley
e2808b1c0b
Add test for downref in Last Call announcement
...
- Legacy-Id: 15331
2018-07-14 16:41:22 +00:00
Henrik Levkowetz
2daef52bea
This commit replaces the code defined group features with features held
...
in a database table:
- Added a GroupFeatures model to the group models, and removed the old
features.py
- Added a agenda type for future use in showing different group types on
different agendas.
- Renamed the group feature has_materials to has_nonsession_materials.
- Added API resources and admin support for the new tables.
- Added a Directorate (with reviews) group type as complement to
Directorate, to distinguish between directorates with and without reviews.
- Adjusted tests as needed.
- Updated the fixtures, and fixed the generate_fixtures script to include
the new AgendaTypeName objects.
There still exists about 70 instances of code comparing the group type
with a list of types; most of these should probably be replaced with new
features, instead, to make it possible to add new group types through the
database table, rather than having to edit the code. That was the purpose
of this refactoring from the start, but the presence of this large number
of comparisons of group type against lists of types defeats the goal until
we add appropriate features and replace the group type list comparisons.
- Legacy-Id: 15316
2018-07-12 10:51:48 +00:00
Henrik Levkowetz
9fe1820640
Tweaked the 'Related documents' part of the Document admin page to more intuitively show the relationships.
...
- Legacy-Id: 15259
2018-06-14 19:22:55 +00:00
Henrik Levkowetz
41a5f5dca4
Merged in [15248] from rjsparks@nostrum.com:
...
Improvements to tests after converting to factories suggested by studying coverage_changes.
- Legacy-Id: 15255
Note: SVN reference [15248] has been migrated to Git commit b86bd84278
2018-06-14 13:11:29 +00:00
Henrik Levkowetz
b3301de22e
Fixed a pyflakes nit.
...
- Legacy-Id: 15253
2018-06-14 12:35:16 +00:00
Henrik Levkowetz
a3c12d937f
Removed two instances of log.assertion(); we have enough data on these now.
...
- Legacy-Id: 15252
2018-06-14 12:03:02 +00:00
Robert Sparks
b86bd84278
Improvements to tests after converting to factories suggested by studying coverage_changes. Commit ready to merge.
...
- Legacy-Id: 15248
2018-06-13 22:09:01 +00:00
Robert Sparks
340b6591b2
Use factories for ietf.doc.tests_status_change. Repair previous commit errors in ietf.doc.tests_material. Commit ready for merge.
...
- Legacy-Id: 15238
2018-06-09 22:16:26 +00:00
Robert Sparks
a2fa0d6400
Use factories for ietf.doc.tests_material and ietf.doc.tests_review. Commit ready for merge.
...
- Legacy-Id: 15237
2018-06-09 21:20:37 +00:00
Robert Sparks
3eeece797a
Use factories for ietf.doc.tests_downref. Commit ready for merge.
...
- Legacy-Id: 15228
2018-06-08 14:42:45 +00:00
Robert Sparks
67df7bd8cf
Use factories for ietf.doc.tests_conflict_review. Commit ready for merge.
...
- Legacy-Id: 15227
2018-06-08 00:13:00 +00:00
Robert Sparks
880dafdb24
Use factories for ietf.doc.tests_charter. Commit ready for merge.
...
- Legacy-Id: 15226
2018-06-07 23:50:27 +00:00
Robert Sparks
6f011a3e56
Use factories for ietf.doc.tests_draft. Commit ready for merge.
...
- Legacy-Id: 15225
2018-06-07 22:03:09 +00:00
Robert Sparks
dcf9e6b40f
Use factories for ietf.doc.tests_ballots. Fixed a long-hidden bug in test_edit_verify_permissions where non-existing usernames were used and passed the tests accidently. Added list_email to the GroupFactory. Commit ready for merge.
...
- Legacy-Id: 15219
2018-06-06 17:59:40 +00:00
Robert Sparks
a064e28926
Factoryalized the rest of ietf.doc.tests. Created draft type specific factories. Commit ready for merge.
...
- Legacy-Id: 15217
2018-06-05 21:17:28 +00:00
Robert Sparks
984806de2d
Trivial commit removing some recently commented out code. Commit ready for merge.
...
- Legacy-Id: 15209
2018-06-04 15:16:47 +00:00
Robert Sparks
84d3c92298
more factoryization of ietf.doc.tests. Commit ready for merge.
...
- Legacy-Id: 15205
2018-06-02 13:39:39 +00:00
Robert Sparks
4e7743c009
More factorization of ietf.doc.tests. Commit ready for merge.
...
- Legacy-Id: 15204
2018-06-01 21:39:22 +00:00
Robert Sparks
4a4a152c9a
Use factories for the rest of the tests in ietf.doc.tests.SearchTests. Commit ready for merge.
...
- Legacy-Id: 15203
2018-06-01 18:54:26 +00:00
Robert Sparks
0a1d9ecd2a
Converted test_search_for_name to use factories. Commit ready for merge.
...
- Legacy-Id: 15202
2018-06-01 15:52:57 +00:00
Robert Sparks
54afc41f8e
Converted test_search to use factories. Commit ready for merge.
...
- Legacy-Id: 15201
2018-06-01 15:16:32 +00:00
Henrik Levkowetz
4db4dd16b0
Merged in ^/personal/henrik/6.79.1-gdpr@15180 containing GDPR-adaptations.
...
- Legacy-Id: 15181
2018-05-28 11:26:24 +00:00
Henrik Levkowetz
81e78c70a0
Added guards against asking for properties on None in a couple of places.
...
- Legacy-Id: 15173
2018-05-26 08:34:27 +00:00
Henrik Levkowetz
2522082979
Changed the email origin field during test to hold user.username in order to exercise more of the code. Changed the EmailFactory to also use user.username as origin.
...
- Legacy-Id: 15172
2018-05-26 08:32:20 +00:00
Robert Sparks
6b779e9d4c
Send email when the responsible AD for a conflict review is changed. Include the stream manager and stream steering group when the responsible AD changes or when the telechat date changes. Fixes #2497 . Commit ready for merge.
...
- Legacy-Id: 15152
2018-05-21 22:02:34 +00:00
Henrik Levkowetz
6c3ec5b18e
Added Email origin to Email record creation throughout the codebase.
...
- Legacy-Id: 15149
2018-05-17 16:56:26 +00:00
Henrik Levkowetz
a66639299d
Removed all references to the removed Person.affiliation field.
...
- Legacy-Id: 15129
2018-05-05 12:47:55 +00:00
Henrik Levkowetz
5f37a71889
Added origin information to all places where we create email address entries.
...
- Legacy-Id: 15127
2018-05-05 12:40:30 +00:00
Robert Sparks
1c16926ee6
Missed adding the migrations. Related to #1963 . Commit ready for merge.
...
- Legacy-Id: 15120
2018-05-03 21:23:07 +00:00
Robert Sparks
1295f1f1d2
Change stream state to replaced when an ISE, IAB, or IRTF document is replaced. Fixes #1963 . Commit ready for merge.
...
- Legacy-Id: 15119
2018-05-03 21:21:38 +00:00
Robert Sparks
8436078af6
Made settings.URL_REGEXPS.name non-greedy. Added a test to exercise the bug at #2429 . Fixes #2429 . Commit ready for merge.
...
- Legacy-Id: 15110
2018-05-03 15:39:00 +00:00
Henrik Levkowetz
d076a1728c
Added a 'recent drafts' page, showing drafs submitted the last 7 days.
...
- Legacy-Id: 15099
2018-05-01 17:55:22 +00:00
Henrik Levkowetz
53c4ac36db
Removed the Person.address field, which is not being used. This was a legacy from the 2001 perl-based datatracker tables. Fixes issue #2504 .
...
- Legacy-Id: 15095
2018-04-27 14:00:33 +00:00
Henrik Levkowetz
198c003b6a
Merged in [15084] from rjsparks@nostrum.com:
...
Corrected the implementation of clear_ballot. Added a test for it. Restored functionality to ballot popups that was missing because a template variable was not passed in.
- Legacy-Id: 15092
Note: SVN reference [15084] has been migrated to Git commit ee346edaba
2018-04-26 13:41:22 +00:00
Henrik Levkowetz
d994a58474
Merged in [15083] from rjsparks@nostrum.com:
...
Removed memoize from latest_event.
- Legacy-Id: 15091
Note: SVN reference [15083] has been migrated to Git commit 1735f86db0
2018-04-26 12:51:45 +00:00
Henrik Levkowetz
c02f8fe331
Merged in [15080] from rjsparks@nostrum.com:
...
Marked a couple of functions as unreachable.
- Legacy-Id: 15089
Note: SVN reference [15080] has been migrated to Git commit 7df28d8bac
2018-04-26 12:08:07 +00:00
Henrik Levkowetz
c7350be50f
Reverted a change to UserFactory to avoid nepalese names. The issue is bigger, and needs a different resulution. Changed the url pattern that used \w to match names to instead use a more inclusive regex.
...
- Legacy-Id: 15088
2018-04-26 11:53:51 +00:00
Robert Sparks
ee346edaba
Corrected the implementation of clear_ballot. Added a test for it. Restored functionality to ballot popups that was missing because a template variable was not passed in. Commit ready for merge.
...
- Legacy-Id: 15084
2018-04-25 19:52:44 +00:00
Robert Sparks
1735f86db0
Removed memoize from latest_event. Commit ready for merge.
...
- Legacy-Id: 15083
2018-04-25 18:15:23 +00:00
Henrik Levkowetz
8e43e7aed0
Merged in [15075] from rjsparks@nostrum.com:
...
Improved testing for docs_for_ad.
- Legacy-Id: 15082
Note: SVN reference [15075] has been migrated to Git commit b7375412ab
2018-04-25 17:21:33 +00:00
Robert Sparks
7df28d8bac
Marked a couple of functions as unreachable. Commit ready for merge.
...
- Legacy-Id: 15080
2018-04-25 15:10:55 +00:00
Henrik Levkowetz
e1eb39b478
Merged in [15074] from rjsparks@nostrum.com:
...
Simplified docs_in_iesg_process. Added a test for it.
- Legacy-Id: 15079
Note: SVN reference [15074] has been migrated to Git commit 57f548ecbd
2018-04-25 13:17:59 +00:00
Henrik Levkowetz
227cb0db4d
Merged in [15073] from rjsparks@nostrum.com:
...
Rearranged ietf/doc/urls.py to allow matching some special pages under /doc without a trailing slash. Adjusted several of those special URLs to work without the trailing slash.
- Legacy-Id: 15078
Note: SVN reference [15073] has been migrated to Git commit da25919f08
2018-04-24 21:27:04 +00:00
Robert Sparks
b7375412ab
Improved testing for docs_for_ad.
...
- Legacy-Id: 15075
2018-04-24 19:22:09 +00:00
Robert Sparks
57f548ecbd
Simplified docs_in_iesg_process. Added a test for it.
...
- Legacy-Id: 15074
2018-04-24 18:27:19 +00:00
Robert Sparks
da25919f08
Rearranged ietf/doc/urls.py to allow matching some special pages under /doc without a trailing slash. Adjusted several of those special URLs to work without the trailing slash.
...
- Legacy-Id: 15073
2018-04-24 18:00:59 +00:00
Henrik Levkowetz
28f4c52c20
Added permission for a document shepherd to request publication. Fixes issue #2509 .
...
- Legacy-Id: 15071
2018-04-23 20:41:04 +00:00
Henrik Levkowetz
c124a018e8
Fixed a typo. Fixes issue #2500 .
...
- Legacy-Id: 15061
2018-04-20 13:06:21 +00:00
Henrik Levkowetz
12d999a384
Modified the IESG position setting API to send email messages about positions set.
...
- Legacy-Id: 15050
2018-04-17 11:57:16 +00:00
Henrik Levkowetz
2ed9face25
Modified the IESG position setting API to send email messages about positions set.
...
- Legacy-Id: 15049
2018-04-17 11:38:40 +00:00
Henrik Levkowetz
1591b3ebd2
Fixed an issue where simplified sorting of DocEvents resulted in some ballot icons not being shown on the IESG agenda documents page.
...
- Legacy-Id: 15046
2018-04-16 10:38:08 +00:00
Henrik Levkowetz
a9fbea113b
Changed incorrect use of 404 status code in api to 400. Fixes issue #2498 .
...
- Legacy-Id: 15044
2018-04-13 11:11:48 +00:00
Henrik Levkowetz
b5d62973c7
Tweaked the error return from Document.get_document_content() to be more helpful during development.
...
- Legacy-Id: 15034
2018-04-09 14:01:37 +00:00
Henrik Levkowetz
ea7728b501
Changed calls to .related_that*() and .relations_that*() to use tuples rather than lists (a slight optimization).
...
- Legacy-Id: 15029
2018-04-07 10:47:16 +00:00
Henrik Levkowetz
bac162d0d0
Reduced the max number of results returned by document searches from 500 to 200, for a better user experience. A faster return and a search term tweak to pinpoint the desired search result is better than a long wait and then maybe having to tweak the search terms anyway.
...
- Legacy-Id: 15027
2018-04-07 10:12:13 +00:00
Henrik Levkowetz
96e4059e43
Undid some memoization; these values can change during an object's lifetime.
...
- Legacy-Id: 15025
2018-04-07 10:07:57 +00:00
Henrik Levkowetz
5446ae642a
Changed the signature of some document methods to not accept lists (but still accept tuples) in order to make caching possible. Added @memoize to some methods.
...
- Legacy-Id: 15024
2018-04-06 21:25:56 +00:00
Henrik Levkowetz
d44c2dc92c
Added another prefetch to search doc query results.
...
- Legacy-Id: 15023
2018-04-06 21:24:07 +00:00
Henrik Levkowetz
6b27daa58a
Imposed sort order (most recent docs first) on document search results, in order to retain the most recent docs in case we have to chop the result list due too many hits.
...
- Legacy-Id: 15022
2018-04-06 21:23:14 +00:00
Henrik Levkowetz
248c2dd055
Added back the on-agenda calendar links to document lists, now in an implementation with better performance characteristics.
...
- Legacy-Id: 15020
2018-04-06 15:17:18 +00:00
Henrik Levkowetz
583d8882c5
Fixed an issue where the change of slide naming between IETF 96 and 97 caused the datatracker to not provide correct link to pre-IETF-97 materials. Thanks to tjw.ietf@gmail.com for the heads-up.
...
- Legacy-Id: 15017
2018-04-05 20:34:56 +00:00
Henrik Levkowetz
6a32a363cc
Merged in [15012] from ford@isoc.org:
...
Add IRTF State option to Additional Search Criteria pulldown.
- Legacy-Id: 15016
Note: SVN reference [15012] has been migrated to Git commit cd912600e6
2018-04-05 14:50:40 +00:00
Mat Ford
cd912600e6
Add IRTF State option to Additional Search Criteria pulldown. Commit ready for merge.
...
- Legacy-Id: 15012
2018-04-05 11:56:37 +00:00
Henrik Levkowetz
421621eb51
Another round of iesg page optimizations. Reduced additional instances of individual lookups to a single lookup followed by annotation of document objects. Reduced several instances of repeating the same work multiple times (queries for telechat documents, queries for telechat dates).
...
- Legacy-Id: 15010
2018-04-05 11:03:26 +00:00
Henrik Levkowetz
67a17bb227
Fixed a number of tests to deal correctly with model method caching.
...
- Legacy-Id: 15009
2018-04-05 10:55:27 +00:00
Henrik Levkowetz
15d45b4d22
Changed the ballot_icon template tag to use an already found ballot if available, rather than doing lookups to find it (twice!).
...
- Legacy-Id: 15007
2018-04-04 17:12:08 +00:00
Henrik Levkowetz
1ec98fdd59
Added @memoize to two Document methods
...
- Legacy-Id: 15006
2018-04-04 17:10:06 +00:00
Henrik Levkowetz
43a9291053
Added an index for (doc, type) on DocEvent to speed up latest_event() queries.
...
- Legacy-Id: 14990
2018-04-01 19:33:16 +00:00
Henrik Levkowetz
675c652052
Additional changes to speed up the IESG agenda docs page: Changed telechat_page_count() to accept a list of documents if that's already been generated, to avoid double work. Changed the reviewed_by_teams list to provide acronyms directly, to avoid group lookups during template rendering. Provided page counts directly to the template instead of repeated (costly) filtering through telechat_page_count, with new document lookups. Removed the telechat_page_count template filter, due to its cost. Tweaked some lookups in fill_in_document_table_attributes() . Added to the select_related() list for documents in IESG agenda_documents().
...
- Legacy-Id: 14988
2018-04-01 18:51:48 +00:00
Henrik Levkowetz
60a60de94b
Replaced inline database lookups with get_active_ads().
...
- Legacy-Id: 14987
2018-04-01 18:38:50 +00:00
Henrik Levkowetz
db3a4eb20e
Changed some instances of .slug to _id
...
- Legacy-Id: 14985
2018-04-01 18:32:27 +00:00
Henrik Levkowetz
4c297ba4c0
Changed settings so that cache keys used by memcached includes the release version, in order to avoid stale and incorrect cache content on new release deployment. Made it easier to pick out cache key composition by normalizing the variable name. Adjusted cache prefix and the composition of some keys to have a unique and consistent cache key prefix.
...
- Legacy-Id: 14943
2018-03-26 21:26:20 +00:00
Henrik Levkowetz
c0eb9e3aa6
Merged in [14899] from rjsparks@nostrum.com:
...
Cleaner charter factory simplifies test code.
- Legacy-Id: 14914
Note: SVN reference [14899] has been migrated to Git commit 8026f86cd3
2018-03-24 21:24:03 +00:00
Henrik Levkowetz
cc717946f5
Merged in [14896] from rjsparks@nostrum.com:
...
Improved test coverage for ietf/doc/views_charter.py.
- Legacy-Id: 14912
Note: SVN reference [14896] has been migrated to Git commit f11907b6a0
2018-03-24 17:54:14 +00:00
Henrik Levkowetz
6d5f604d5b
Tweaked the document list iCalendar links to not show for presentations on days in the past.
...
- Legacy-Id: 14908
2018-03-24 15:29:10 +00:00
Henrik Levkowetz
f48669a8e4
Merged in [14884] from adam@nostrum.com:
...
Adding page count to last call page.
- Legacy-Id: 14907
Note: SVN reference [14884] has been migrated to Git commit e7b984dfa7
2018-03-24 15:09:50 +00:00
Henrik Levkowetz
bd205ae29b
Merged in [14849] from ben@nostrum.com:
...
Give ADs the red Clear Ballot button
- Legacy-Id: 14904
Note: SVN reference [14849] has been migrated to Git commit 7bf02077fd
2018-03-24 13:31:48 +00:00
Robert Sparks
8026f86cd3
Cleaner charter factory simplifies test code. Commit ready for merge.
...
- Legacy-Id: 14899
2018-03-22 14:01:24 +00:00
Robert Sparks
f11907b6a0
Improved test coverage for ietf/doc/views_charter.py. Commit ready for merge.
...
- Legacy-Id: 14896
2018-03-21 21:59:45 +00:00
Adam Roach
e7b984dfa7
Adding page count to last call page. Commit ready for merge.
...
- Legacy-Id: 14884
2018-03-21 09:12:34 +00:00
Ben Campbell
cc96709957
Give ADs the red Clear Ballot button
...
- Legacy-Id: 14848
2018-03-17 16:35:35 +00:00
Henrik Levkowetz
a04e187f0f
Removed some old debug print statements.
...
- Legacy-Id: 14823
2018-03-14 22:11:06 +00:00
Henrik Levkowetz
1fd4a4d1a7
Added session ical links to document lists (WG docs, search results, etc.) for documents on upcoming meeting agendas. Reduced the query and rendering times of document lists some more through additional prefetch_related().
...
- Legacy-Id: 14799
2018-03-14 19:16:50 +00:00
Henrik Levkowetz
fdba464808
Added result caching for a couple of Document methods.
...
- Legacy-Id: 14795
2018-03-14 19:11:18 +00:00
Henrik Levkowetz
6e9bb00f13
Changed html cleaning to differentiate between fragment cleaning and document cleaning. Added an lxml-based cleaner for document cleaning, also permitting <style> tags (but not external style sheets).
...
- Legacy-Id: 14775
2018-03-13 12:48:22 +00:00
Henrik Levkowetz
2c0348cc7a
Found that django's urlize() does not deal well with adjacent parantheses. Replaced it with a filter based on bleach.linkify, which does better.
...
- Legacy-Id: 14752
2018-03-09 15:07:04 +00:00
Henrik Levkowetz
1df3c715d0
Replaced the use of (at least in Django 1.11) buggy urlize() with bleach.linkify(), to avoid some exceptions caused by malformed urlize output, exposed by the new sanitize_html(). Also removed some dead code.
...
- Legacy-Id: 14751
2018-03-09 12:00:15 +00:00
Robert Sparks
975522af35
Make a more appropriate review message when a BoF has an initial charter under consideration. Fixes #2458 . Commit ready for merge.
...
- Legacy-Id: 14715
2018-02-28 20:54:56 +00:00
Henrik Levkowetz
6e1d4d45d8
Added some missing migrations
...
- Legacy-Id: 14697
2018-02-25 20:08:37 +00:00
Henrik Levkowetz
1389775488
Added some missing migrations.
...
- Legacy-Id: 14696
2018-02-25 20:06:50 +00:00
Henrik Levkowetz
1ed8e967e7
Merged in ^/personal/henrik/6.72.1-django-1.11@14676: Upgrade to Django 1.11
...
- Legacy-Id: 14695
2018-02-25 19:55:16 +00:00
Henrik Levkowetz
dc90fa3940
Changed user.is_authenticated and .is_anonymous from method calls to attribute access.
...
- Legacy-Id: 14668
2018-02-22 00:03:30 +00:00
Henrik Levkowetz
6184170828
Changed import path from a deprecated path to the kosher one.
...
- Legacy-Id: 14667
2018-02-22 00:01:01 +00:00
Henrik Levkowetz
26bf387356
Replaced direct assignment to m2m fields with .clear() and .set()
...
- Legacy-Id: 14666
2018-02-21 23:58:25 +00:00
Henrik Levkowetz
36b5e2ef8e
Changed name from .rel to .remote_field for remote accessors.
...
- Legacy-Id: 14665
2018-02-21 23:56:36 +00:00
Henrik Levkowetz
a4768bb514
Removed unused imports. Added some explicit orderings to avoid pagination issues.
...
- Legacy-Id: 14664
2018-02-21 23:54:31 +00:00
Henrik Levkowetz
06362ec046
Got rid of old migrations and created new initial migrations.
...
- Legacy-Id: 14662
2018-02-21 23:46:22 +00:00
Henrik Levkowetz
5638cf3da3
Changed all usage of ForeignKey and OneToOneFiled in model.py files to the compatibility versions from ietf.utils.models.
...
- Legacy-Id: 14661
2018-02-20 15:36:05 +00:00
Henrik Levkowetz
cdc295bab8
Merged in [14655] from housley@vigilsec.com:
...
Strip the HTML tags around the new values in the mail produced by email_iesg_processing_document. Also, provide the previously missing URL at the end of the message. Fixes 2455.
- Legacy-Id: 14657
Note: SVN reference [14655] has been migrated to Git commit 6ea0881a89
2018-02-19 17:36:09 +00:00
Russ Housley
6ea0881a89
Strip the HTML tags around the new values in the mail produced by email_iesg_processing_document. Also, provide the previously missing URL at the end of the message. Fixes 2455.
...
- Legacy-Id: 14655
2018-02-18 20:40:49 +00:00
Henrik Levkowetz
3dd66eba65
Fixed an UnboundLocalError (only partial variable initialization) bug.
...
- Legacy-Id: 14620
2018-02-07 06:13:19 +00:00
Henrik Levkowetz
a00532694d
Merged in [14549] from rjsparks@nostrum.com:
...
Allow those people who can make a review request to edit the request deadline. Send mail to other directorate secretaries when one secretary makes a change to a request. Fixes #2233 .
- Legacy-Id: 14555
Note: SVN reference [14549] has been migrated to Git commit ba8b4d3a38
2018-01-23 19:24:39 +00:00
Henrik Levkowetz
535cd0bccf
Expanded the fields that the 'author' entry of the document search form is applied to, from just author name, to author name, email addresses, and affiliation. Fixes issue #2415 .
...
- Legacy-Id: 14552
2018-01-23 18:12:10 +00:00
Robert Sparks
ba8b4d3a38
Allow those people who can make a review request to edit the request deadline. Send mail to other directorate secretaries when one secretary makes a change to a request. Fixes #2233 . Commit ready for merge.
...
- Legacy-Id: 14549
2018-01-22 21:43:53 +00:00
Henrik Levkowetz
649433874f
Merged in [14539] from rjsparks@nostrum.com:
...
Warn when putting a draft on a telechat that is so close that directorates will probably not have time to complete a review. Fixes #2381 .
- Legacy-Id: 14542
Note: SVN reference [14539] has been migrated to Git commit dfc1d2aa9a
2018-01-19 15:22:16 +00:00
Robert Sparks
dfc1d2aa9a
Warn when putting a draft on a telechat that is so close that directorates will probably not have time to complete a review. Fixes #2381 . Commit ready for merge.
...
- Legacy-Id: 14539
2018-01-18 22:14:30 +00:00
Henrik Levkowetz
07fd714c88
Refined the URL patterns and handling of alternative meeting material file formats, which were broken by an earlier refactoring (v6.57.0). Fixes issue #2436 .
...
- Legacy-Id: 14521
2018-01-14 21:09:28 +00:00
Henrik Levkowetz
97206c6eeb
Added user notification about ballots closed automatically when creating a new ballot.
...
- Legacy-Id: 14471
2017-12-29 15:24:37 +00:00
Henrik Levkowetz
4488fd82a4
Merged in [14467] from housley@vigilsec.com:
...
Close any previous ballots when a charter goes to Internal Review or Extrernal Review. Fixes #2421 .
- Legacy-Id: 14470
Note: SVN reference [14467] has been migrated to Git commit de6121c6c1
2017-12-29 13:40:10 +00:00
Russ Housley
de6121c6c1
Close any previous ballots when a charter goes to Internal Review or Extrernal Review. Fixes #2421 .
...
- Legacy-Id: 14467
2017-12-28 20:09:56 +00:00
Robert Sparks
0a9737a5d2
Include information about previous team reviews in assignement emails. Fixes #2392 . Commit ready for merge.
...
- Legacy-Id: 14466
2017-12-26 22:13:13 +00:00
Henrik Levkowetz
b12bb3ca3c
Guard document replacement following methods against infinite recursion on circular relationships.
...
- Legacy-Id: 14457
2017-12-22 19:28:59 +00:00
Henrik Levkowetz
7d7b7de54f
Fixed an ungarded object attribute access.
...
- Legacy-Id: 14446
2017-12-19 14:38:02 +00:00
Henrik Levkowetz
e1fa3ba381
Limited the iesg ballot position API to ADs (excluding secretariat).
...
- Legacy-Id: 14444
2017-12-19 14:10:43 +00:00
Henrik Levkowetz
6567e707ce
Merged in ^/personal/henrik/6.64.2-ballotapi@14426. This provides personal API keys and a ballot position API at /api/iesg/position. Also added an endpoint description at /api/.
...
- Legacy-Id: 14430
2017-12-17 23:43:44 +00:00
Henrik Levkowetz
a08c8dc76f
Added an API endpoint to support automation of IESG ballot position posting, at /api/iesg/position. Added tests for the API endpoint, and updated the apikey validation decorator tests. Tweaked the decorator to handle a weakness found during testing.
...
- Legacy-Id: 14429
2017-12-17 21:55:27 +00:00
Henrik Levkowetz
b0863c8963
Modified some names.
...
- Legacy-Id: 14428
2017-12-16 18:43:08 +00:00
Henrik Levkowetz
e7209c6e50
Added a new personal event table to keep track of personal API key logins, and a management command to send out reports about activity to users with API keys. Added a weekly cronjob script to trigger weekly reports, and a monthly script for future use. Added a @require_api_key decorator to validate API keys for API key views and log in the API key owner. Modified the API key management urls to use create and disable rather than add and delete. Updated the API key list view. Added an API placeholder view function for ballot position setting, for test purposes. Added tests for the decorator and management command.
...
- Legacy-Id: 14426
2017-12-16 18:37:52 +00:00
Henrik Levkowetz
1f976da5c1
Third part of document read refactoring, after [14406] and [14410]. This replaces all usage of the non-unicode-aware get_document_content() function with unicode-aware Document.text() or Document.text_or_error() methods. This was triggered by yet another report of unicode content not being shown properly, and should fix all instances of document (drafts, agendas, minutes, etc.) display in the datatracker not handling unicode characters properly.
...
- Legacy-Id: 14411
Note: SVN reference [14406] has been migrated to Git commit 967ece7e7d
Note: SVN reference [14410] has been migrated to Git commit 660c81c272
2017-12-11 16:23:51 +00:00
Henrik Levkowetz
660c81c272
Tweaked the file content read refactoring in [14406] to try latin-1 conversion if unicode doesn't work.
...
- Legacy-Id: 14410
Note: SVN reference [14406] has been migrated to Git commit 967ece7e7d
2017-12-10 17:48:09 +00:00
Henrik Levkowetz
967ece7e7d
Started refactoring of reading text from document files (drafts, charters, etc.) in order to normalise on one way of doing this, and making that return unicode rather than undecoded bytes. This is the first step of two, in order to gauge the possible issues and report on discrepancies.
...
- Legacy-Id: 14406
2017-12-08 21:51:11 +00:00
Henrik Levkowetz
4b5e354abe
Merged in [14386] from rjsparks@nostrum.com:
...
Add a per-year RFC feed.
- Legacy-Id: 14391
Note: SVN reference [14386] has been migrated to Git commit 6ab819bdde
2017-12-04 15:29:15 +00:00
Robert Sparks
6ab819bdde
Add a per-year RFC feed. Commit ready for merge.
...
- Legacy-Id: 14386
2017-12-01 17:19:51 +00:00
Henrik Levkowetz
ddfddb61ca
Made the ballot type representation string more expressive, showing both name and doc_type.
...
- Legacy-Id: 14383
2017-12-01 09:27:28 +00:00