altf4arnold/datatracker
1
0
Fork 0
Code Issues Pull requests Actions 2 Packages Projects Releases Wiki Activity

Fix #2278 - Notify secretary when a review request is closed.

Browse source 
The assigned reviewer was already notified, but secretaries were always
excluded.

Commit ready for merge.
 - Legacy-Id: 17085
This commit is contained in:
Sasha Romijn 2019-11-21 11:03:21 +00:00
parent dc9546211f
commit 56003f66d8
2 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
ietf/doc/tests_review.py
View file

@ -189,6 +189,7 @@ class ReviewTests(TestCase):
review_team = ReviewTeamFactory(acronym="reviewteam", name="Review Team", type_id="review", list_email="reviewteam@ietf.org", parent=Group.objects.get(acronym="farfut"))
rev_role = RoleFactory(group=review_team,person__user__username='reviewer',person__user__email='reviewer@example.com',name_id='reviewer')
RoleFactory(group=review_team,person__user__username='reviewsecretary',person__user__email='reviewsecretary@example.com',name_id='secr')
RoleFactory(group=review_team,person__user__username='reviewsecretary2',person__user__email='reviewsecretary2@example.com',name_id='secr')
review_req = ReviewRequestFactory(doc=doc,team=review_team,type_id='early',state_id='assigned',requested_by=rev_role.person,deadline=datetime.datetime.now()+datetime.timedelta(days=20))
ReviewAssignmentFactory(review_request=review_req, state_id='accepted', reviewer=rev_role.person.email_set.first())
@ -229,6 +230,7 @@ class ReviewTests(TestCase):
self.assertEqual(len(outbox), 1)
self.assertTrue('<reviewer@example.com>' in outbox[0]["To"])
self.assertFalse("<reviewsecretary@example.com>" in outbox[0]["To"])
self.assertTrue("<reviewsecretary2@example.com>" in outbox[0]["To"])
mail_content = outbox[0].get_payload(decode=True).decode("utf-8").lower()
self.assertTrue("closed" in mail_content)
self.assertTrue("review_request_close_comment" in mail_content)

2
ietf/review/utils.py
View file

@ -564,7 +564,7 @@ def close_review_request(request, review_req, close_state, close_comment=''):
email_review_request_change(
request, review_req,
"Closed review request for {}: {}".format(review_req.doc.name, close_state.name),
msg=msg, by=request.user.person, notify_secretary=False,
msg=msg, by=request.user.person, notify_secretary=True,
notify_reviewer=True, notify_requested_by=True)
def suggested_review_requests_for_team(team):