Changed format of the reviewer statistics in lists. Fixes #2131. Commit ready for merge.

- Legacy-Id: 15701
This commit is contained in:
Tero Kivinen 2018-11-03 09:04:57 +00:00
parent 542a85d949
commit 56acd00c6c
2 changed files with 5 additions and 2 deletions

View file

@ -355,7 +355,7 @@ class ReviewTests(TestCase):
self.assertIn("unavailable indefinitely", reviewer_label)
self.assertIn("skip next 1", reviewer_label)
self.assertIn("#1", reviewer_label)
self.assertIn("no response 0/1", reviewer_label)
self.assertIn("1 completed", reviewer_label)
# assign
empty_outbox()

View file

@ -833,7 +833,10 @@ def make_assignment_choices(email_queryset, review_req):
could_have_completed = [d for d in req_data if d.state in ["part-completed", "completed", "no-response"]]
if could_have_completed:
no_response = sum(1 for d in could_have_completed if d.state == "no-response")
stats.append("no response {}/{}".format(no_response, len(could_have_completed)))
if no_response > 0:
stats.append("{} no response, {} completed".format(no_response, len(could_have_completed) - no_response))
else:
stats.append("{} completed".format(len(could_have_completed)))
if stats:
explanations.append(", ".join(stats))