altf4arnold/datatracker
1
0
Fork 0
Code Issues Pull requests Actions 2 Packages Projects Releases Wiki Activity

Guard document replacement following methods against infinite recursion on circular relationships.

Browse source 
- Legacy-Id: 14457
This commit is contained in:
Henrik Levkowetz 2017-12-22 19:28:59 +00:00
parent 01af0af2c1
commit b12bb3ca3c
1 changed files with 4 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
ietf/doc/utils.py
View file

@ -650,22 +650,20 @@ def extract_complete_replaces_ancestor_mapping_for_docs(names):
def make_rev_history(doc):
# return document history data for inclusion in doc.json (used by timeline)
def get_predecessors(doc):
predecessors = []
def get_predecessors(doc, predecessors=[]):
if hasattr(doc, 'relateddocument_set'):
for alias in doc.related_that_doc('replaces'):
if alias.document not in predecessors:
predecessors.append(alias.document)
predecessors.extend(get_predecessors(alias.document))
predecessors.extend(get_predecessors(alias.document, predecessors))
return predecessors
def get_ancestors(doc):
ancestors = []
def get_ancestors(doc, ancestors = []):
if hasattr(doc, 'relateddocument_set'):
for alias in doc.related_that('replaces'):
if alias.document not in ancestors:
ancestors.append(alias.document)
ancestors.extend(get_ancestors(alias.document))
ancestors.extend(get_ancestors(alias.document, ancestors))
return ancestors
def get_replaces_tree(doc):