Merged in [16770] from rjsparks@nostrum.com:

Populate completed_on when rejecting a ReviewAssignment. Migrate past rejected assignments accordingly. Fixes #2782.
 - Legacy-Id: 16841
Note: SVN reference [16770] has been migrated to Git commit 661e4c5369dc0d165bfcb56e3278906fe1de3b55

ietf/doc/tests_review.py

@@ -481,6 +481,7 @@ class ReviewTests(TestCase):
 
         assignment = reload_db_objects(assignment)
         self.assertEqual(assignment.state_id, "rejected")
+        self.assertNotEqual(assignment.completed_on,None)
         e = doc.latest_event()
         self.assertEqual(e.type, "closed_review_assignment")
         self.assertTrue("rejected" in e.desc)

ietf/doc/views_review.py

@@ -337,6 +337,7 @@ def reject_reviewer_assignment(request, name, assignment_id):
         if form.is_valid():
             # reject the assignment
             review_assignment.state = ReviewAssignmentStateName.objects.get(slug="rejected")
+            review_assignment.completed_on = datetime.datetime.now()
             review_assignment.save()
 
             ReviewAssignmentDocEvent.objects.create(