Changed the cache-filling code for doc.get_state() to avoid a period where the cache is seen as valid but empty. Addresses an issue where documents occasionally appear to be in an unexpected state.

- Legacy-Id: 18564
2020-10-05 14:55:16 +00:00 · 2020-10-05 14:55:16 +00:00 · 6d36990446
parent 020d560190
commit 6d36990446
1 changed files with 3 additions and 2 deletions
--- a/ietf/doc/models.py
+++ b/ietf/doc/models.py
@ -291,9 +291,10 @@ class DocumentInfo(models.Model):
            state_type = self.type_id

        if not hasattr(self, "state_cache") or self.state_cache == None:
-            self.state_cache = {}
+            state_cache = {}
            for s in self.states.all():
-                self.state_cache[s.type_id] = s
+                state_cache[s.type_id] = s
+            self.state_cache = state_cache

        return self.state_cache.get(state_type, None)