altf4arnold/datatracker
1
0
Fork 0
Code Issues Pull requests Actions 6 Packages Projects Releases Wiki Activity

Merged in [15701] from kivinen@iki.fi:

Browse source 
Changed format of the reviewer statistics in lists. Fixes #2131.
 - Legacy-Id: 15735
Note: SVN reference [15701] has been migrated to Git commit 56acd00c6c
This commit is contained in:
Henrik Levkowetz 2018-11-07 05:24:25 +00:00
parent 98015a64f2 56acd00c6c
commit 89ef806013
2 changed files with 10 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
ietf/doc/tests_review.py
View file

@ -355,7 +355,7 @@ class ReviewTests(TestCase):
self.assertIn("unavailable indefinitely", reviewer_label)
self.assertIn("skip next 1", reviewer_label)
self.assertIn("#1", reviewer_label)
self.assertIn("no response 0/1", reviewer_label)
self.assertIn("1 fully completed", reviewer_label)
# assign
empty_outbox()

11
ietf/review/utils.py
View file

@ -832,8 +832,15 @@ def make_assignment_choices(email_queryset, review_req):
stats.append("currently {count} open, {pages} pages".format(count=currently_open, pages=pages))
could_have_completed = [d for d in req_data if d.state in ["part-completed", "completed", "no-response"]]
if could_have_completed:
no_response = sum(1 for d in could_have_completed if d.state == "no-response")
stats.append("no response {}/{}".format(no_response, len(could_have_completed)))
no_response = len([d for d in req_data if d.state == 'no-response'])
if no_response:
stats.append("%s no response" % no_response)
part_completed = len([d for d in req_data if d.state == 'part-completed'])
if part_completed:
stats.append("%s partially complete" % part_completed)
completed = len([d for d in req_data if d.state == 'completed'])
if completed:
stats.append("%s fully completed" % completed)
if stats:
explanations.append(", ".join(stats))