Improved resolution of an issue with the To: and Cc: addresses of extra review email to responsible AD.

- Legacy-Id: 15778

changelog

@@ -1,3 +1,28 @@
+ietfdb (6.89.0) ietf; urgency=low
+
+  This release provides improved export of statistics charts and data,
+  improved and more consistent test coverage, and fixes a few bugs:
+
+  * Fixed an issue with the To: and Cc: addresses of extra review email to 
+    responsible AD.
+
+  * Changed the liaison tool From: address to <statements@ietf.org>.
+
+  * Always show the liaison submitted date on liaison pages
+
+  * Added testing of unidecode_name() and name_parts(), in order to not rely
+    on random name generation to excercise all paths.
+
+  * Updated highcharts from v4.2.7 to v6.2.0, and added support for CSV export
+    from charts.  Also tweaked the look of the highcharts context menu
+    separators.
+
+  * Added handling for an EOF exception that can occur when using the 
+    django file-based cache.
+
+ -- Henrik Levkowetz <henrik@levkowetz.com>  20 Nov 2018 13:22:15 +0000
+
+
 ietfdb (6.88.0) ietf; urgency=low
 
   **IETF 103 code sprint**

ietf/doc/views_review.py

@@ -647,10 +647,10 @@ def complete_review(request, name, request_id):
                     review.save_with_history([close_event])
 
             if form.cleaned_data['email_ad'] or review_req.result in review_req.team.reviewteamsettings.notify_ad_when.all():
-                (to, cc) = gather_address_lists('review_notify_ad',review_req = review_req)
+                (to, cc) = gather_address_lists('review_notify_ad',review_req = review_req).as_strings()
                 msg_txt = render_to_string("review/notify_ad.txt", {
-                    "to": ', '.join(to),
-                    "cc": ', '.join(cc),
+                    "to": to,
+                    "cc": cc,
                     "review_req": review_req,
                     "settings": settings,
                     "explicit_request": form.cleaned_data['email_ad'],