altf4arnold/datatracker
1
0
Fork 0
Code Issues Pull requests Actions 3 Packages Projects Releases Wiki Activity
14560 commits 1 branch 0 tags 2.6 GiB
Commit graph

148 commits

Author SHA1 Message Date
Henrik Levkowetz 815602351f This is a series of 50 migrations that changes the Document and DocAlias 
primary keys from character strings to integers, and makes corresponding code
changes.

This was prompted by database limitations discovered when trying to make
DocAlias use a m2m document field; with 255 long strings as primary keys for
Document and DocAlias this violated the MySQL database limitations.

Changing the primary keys to integers should also improve efficiency.  

Due to the data migrations which create the new integer primary keys and adds
corresponding integer foreign keys matching the previous string foreign keys
in all tables having foreign keys to Document and DocAlias, some of these
migrations take a long time.  The total set of migrations are expected to have
a runtime on the order of 2 hours.
 - Legacy-Id: 16237
 2019-06-10 11:32:46 +00:00
Henrik Levkowetz ca1f3340c0 Changed a ReviewAssignmentDocEvent type from 'closed_review_request' to 'closed_review_assignment', for consistency and readability. 
- Legacy-Id: 16181
 2019-05-02 12:38:41 +00:00
Henrik Levkowetz 8726e74709 Merged in a refactoring of document review code from rjsparks@nostrum.com. This introduces ReviewAssignments, letting us do multiple assingments for a given RevieRequest, without conflating the assignments and their results with the request itself. 
- Legacy-Id: 16177
 2019-04-30 16:54:06 +00:00
Henrik Levkowetz 3ec9d7b678 Updated the role handling to use GroupFeatures.groupman_roles consistently for group management access. Fixes a IRTF RG delegate permissions issue. 
- Legacy-Id: 16160
 2019-04-25 13:19:30 +00:00
Henrik Levkowetz bb4fe3fbbf Undid previous commit 
- Legacy-Id: 16153
 2019-04-22 19:22:42 +00:00
Henrik Levkowetz cfcefc2e32 Merged in [16144] from housley@vigilsec.com: 
Remove some clutter from I-D upload page.  The information was mived to the Instructions tab, but a higligh to the Note Well and BCP 78 was added. Fixes #2057.
 - Legacy-Id: 16151
Note: SVN reference [16144] has been migrated to Git commit 37851b9742
 2019-04-22 17:39:26 +00:00
Robert Sparks 6dc25cae1a Bring time series stats back into line with what was before. Note there was an off-by-one-day bug in the month-binning in prior releases. 
- Legacy-Id: 16075
 2019-03-20 20:04:06 +00:00
Robert Sparks 81c5b5091a Made some docevent creation more consistent. Addressed the TODOs added during the refactor. 
- Legacy-Id: 16049
 2019-03-19 18:48:05 +00:00
Robert Sparks da3174ab68 Improved several views. 
- Legacy-Id: 16038
 2019-03-18 19:41:07 +00:00
Robert Sparks 4b147f2ef8 More cleanup and correction. Caught a pervasive misuse of a state-name 
- Legacy-Id: 16036
 2019-03-15 20:39:06 +00:00
Robert Sparks 3678d20b0b Some cleanup around stats. Things are well except for the time series graphs. 
- Legacy-Id: 16035
 2019-03-15 16:50:59 +00:00
Robert Sparks a4db66564c Checkpoint. Ended up chasing group.views_review before stats. 
- Legacy-Id: 16030
 2019-03-13 22:02:10 +00:00
Robert Sparks 073ce55f6c Checkpoint. ReviewTests pass, but others still fail of course. Next step is to address stats. 
- Legacy-Id: 16021
 2019-03-12 17:48:19 +00:00
Henrik Levkowetz 682ddee8e4 Reverted earlier application of on_behalf_of() at mail sending call points, and instead did all on_behalf_of processing in condition_message(). Added insertion of Reply-To header fields in this case. Changed all use of the mail-sending 'extra' parameters to use value lists. Updated a bunch of tests accordingly. 
- Legacy-Id: 16020
 2019-03-11 17:01:33 +00:00
Robert Sparks b85052fe63 Checkpoint. Lots of tests will still fail. Reordered some migrations. Brought about half of the ietf.doc.views_review views into line with the new models. Next step is the other half. 
- Legacy-Id: 16012
 2019-03-07 23:08:14 +00:00
Henrik Levkowetz 8a669909bc Changed ietf/utils/mail.py to use unicode strings, and changed a call in ietf/reviv/utils.py to use unicode for mail Subject, to fix a server 500 issue. 
- Legacy-Id: 16007
 2019-03-06 16:57:00 +00:00
Henrik Levkowetz 435a0da12d Added on_behalf_of() calls for from addresses needing it throughout the code. 
- Legacy-Id: 15992
 2019-03-04 20:14:19 +00:00
Robert Sparks e91d706d5b Checkpointing. This is an incomplete idea. The tests will fail massively. 
- Legacy-Id: 15985
 2019-03-01 23:19:47 +00:00
Henrik Levkowetz 57a4c9f41f Added 9 new group features, and changed list-like char fields to json fields, to get better support for using the values as lists. Modified code to use the group features instead of explicit lists of group types in many places in the code. 
- Legacy-Id: 15908
 2019-01-22 18:11:46 +00:00
Henrik Levkowetz e024cca8c4 Merged in [15708] and [15730] from housley@vigilsec.com: 
Added a mail alias for all review team secretaries. Fixes #2139.  Use
the alias if there is one for email about review request changes.  Added
a test for the review team secretary alias functionality.
 - Legacy-Id: 15747
Note: SVN reference [15708] has been migrated to Git commit 6067dcbfef

Note: SVN reference [15730] has been migrated to Git commit d525ade0b0
 2018-11-10 20:32:42 +00:00
Henrik Levkowetz 3b811ecb41 Merged in [15708] and [15730] from housley@vigilsec.com: 
Added a mail alias for all review team secretaries. Fixes #2139.  Use
the alias if there is one for email about review request changes.  Added
a test for the review team secretary alias functionality.
 - Legacy-Id: 15746
Note: SVN reference [15708] has been migrated to Git commit 6067dcbfef

Note: SVN reference [15730] has been migrated to Git commit d525ade0b0
 2018-11-10 19:30:32 +00:00
Henrik Levkowetz 89ef806013 Merged in [15701] from kivinen@iki.fi: 
Changed format of the reviewer statistics in lists. Fixes #2131.
 - Legacy-Id: 15735
Note: SVN reference [15701] has been migrated to Git commit 56acd00c6c
 2018-11-07 05:24:25 +00:00
Russ Housley d525ade0b0 Use review team secretary alias if there is one for email about review request changes. Add test for review team secretary alias. Commit ready for merge. 
- Legacy-Id: 15730
 2018-11-06 07:26:30 +00:00
Tero Kivinen 56acd00c6c Changed format of the reviewer statistics in lists. Fixes #2131. Commit ready for merge. 
- Legacy-Id: 15701
 2018-11-03 09:04:57 +00:00
Robert Sparks fd8af4b6f7 Review assignment email includes a link to the review request that ensures the reviewer is logged in. Fixes #2543. Commit ready for merge 
- Legacy-Id: 15444
 2018-09-06 21:39:10 +00:00
Henrik Levkowetz 080f6b4385 Added group links to the past meetings page, and also important dates links to IETF meetings with important-date pages. 
- Legacy-Id: 15053
 2018-04-18 13:15:30 +00:00
Henrik Levkowetz 838ad9cf44 Added page counts for open review requests on the reviewer assignment drop-downs of /group/*/reviews/manage/unassigned/. Fixes issue #2449. 
- Legacy-Id: 14644
 2018-02-15 18:39:39 +00:00
Robert Sparks 7b89db153e Take a different approach to avoiding the crash when a team secretary uses the bulk assignment form to unassign a request. Reverts r14570. Fixes #2443. Commit ready for merge. 
- Legacy-Id: 14623
 2018-02-07 17:58:27 +00:00
Henrik Levkowetz eb6341d826 Removed the possibility of choosing '(None)' as reviewer from the bulk review request edit form; this prevents a crash on line 1474 of ietf/group/views.py, in manage_review_request(). The view code needs further care in order make it possible to unassign an assignment here. 
- Legacy-Id: 14570
 2018-01-25 15:58:59 +00:00
Robert Sparks ba8b4d3a38 Allow those people who can make a review request to edit the request deadline. Send mail to other directorate secretaries when one secretary makes a change to a request. Fixes #2233. Commit ready for merge. 
- Legacy-Id: 14549
 2018-01-22 21:43:53 +00:00
Robert Sparks 0a9737a5d2 Include information about previous team reviews in assignement emails. Fixes #2392. Commit ready for merge. 
- Legacy-Id: 14466
 2017-12-26 22:13:13 +00:00
Robert Sparks 617dac49d6 Send email to reviewer when request is closed with no response. Fixes #2176. Commit ready to merge. 
- Legacy-Id: 13897
 2017-07-15 12:07:20 +00:00
Henrik Levkowetz ce1b655fa2 Code reorganization, doing away with multiple urls_* and views_ files in ietf.group. No intentional functionality changes. 
- Legacy-Id: 13709
 2017-06-22 15:18:08 +00:00
Henrik Levkowetz 023a32715d Merged in ^/branch/iola/author-stats-r13145 from olau@iola.com, with additional features from ^/personal/henrik/6.52.1-authorstats. 
- Legacy-Id: 13550
 2017-06-06 18:36:59 +00:00
Henrik Levkowetz 2bacdd3a00 Merged in [13500] from rjsparks@nostrum.com: 
Provide assigned dates on review team reviewers page. Fixes #2304. Related to #2305.
 - Legacy-Id: 13518
Note: SVN reference [13500] has been migrated to Git commit e422717f91eb26a0691347beca9380889d8ee890
 2017-06-04 17:31:25 +00:00
Henrik Levkowetz 76628be3fd Merged in ^/branch/iola/author-stats-r13145 from olau@iola.dk, and fixed some tests in code which moved after the latest merge with trunk. The test suite passes, but the migrations are _not_ ready to run, because of numbering conflicts (again due to code changes on trunk since the latest sync). 
- Legacy-Id: 13479
 2017-05-31 20:59:26 +00:00
Henrik Levkowetz 27ff3850eb Fixed a place where the LastCallDocEvent expiry value was set as a date instead of a datetime. 
- Legacy-Id: 13256
 2017-04-30 18:57:05 +00:00
Ole Laursen 5b677dc6ba Merge author stats branch into new branch from trunk 
- Legacy-Id: 13159
 2017-03-28 14:36:40 +00:00
Lars Eggert 8a70e9773d Fix various "RemovedInDjango20Warning" warnings. Commit ready for merge. 
- Legacy-Id: 13112
 2017-03-25 19:16:45 +00:00
Henrik Levkowetz 4daf66d11c Added DocEvent rev= parameter througout the code. 
- Legacy-Id: 12978
 2017-03-06 15:08:21 +00:00
Ole Laursen 9308948195 Add person, affiliation and country (through django-countries) to 
DocumentAuthor, rename author field to email and make it optional (for
modeling old email-less submissions), remove the authors many to many
referencing field from Document as it is not really pointing the right
place.

Update the Secretariat tools to show affiliation and country.

Add migration for getting rid of the fake email addresses that the
migration script created some years ago (just set the author email
field to null).
 - Legacy-Id: 12739
 2017-01-26 17:10:08 +00:00
Robert Sparks 8e007ce50b Make changing skip_next on a review assignment an explicit decision of the assigner. Commit ready for merge. Fixes #2148. 
- Legacy-Id: 12670
 2017-01-19 14:23:09 +00:00
Robert Sparks 10f4892eae Send mail to team secretaries when a review is explicitly requested. Change the From and Subject for assignment emails to reviewers to make it clearer what the review is for and who assigned it. Fixes #2053 and #2114. Commit ready for merge. 
- Legacy-Id: 12593
 2016-12-19 22:32:03 +00:00
Henrik Levkowetz fa684cf6d2 Merged in [12541] from rjsparks@nostrum.com: 
Provide default filters for reviewer settings. Fixes #2093.
 - Legacy-Id: 12546
Note: SVN reference [12541] has been migrated to Git commit df86798cf3
 2016-12-15 21:57:46 +00:00
Henrik Levkowetz b14e981e66 Merged in [12520] from rjsparks@nostrum.com: 
Slight refactor of the review models to capture review team settings. Allows configuring review teams to get automatic suggestions for reviews or not. Provides a better admin for creating/managing review teams. Fixes #2048 and #2072.
 - Legacy-Id: 12544
Note: SVN reference [12520] has been migrated to Git commit b24bdb5bc3
 2016-12-15 20:55:40 +00:00
Henrik Levkowetz 51fedbf483 Merged in [12505] from rjsparks@nostrum.com: 
Disallow requesting directorate reviews of RFCs (such things would better be done with reviews of status change documents). Fixes #2065.
 - Legacy-Id: 12537
Note: SVN reference [12505] has been migrated to Git commit 1ea983a1c2
 2016-12-15 16:31:36 +00:00
Henrik Levkowetz fec5772f9a Deprecation fix: Pass the result of active_review_teams() to a Role.objects query, instead of passing the function. 
- Legacy-Id: 12534
 2016-12-15 13:23:16 +00:00
Robert Sparks b24bdb5bc3 Slight refactor of the review models to capture review team settings. Allows configuring review teams to get automatic suggestions for reviews or not. Provides a better admin for creating/managing review teams. Fixes #2048 and #2072. Commit ready for merge. 
- Legacy-Id: 12520
 2016-12-14 23:26:32 +00:00
Robert Sparks 1ea983a1c2 Disallow requesting directorate reviews of RFCs (such things would better be done with reviews of status change documents). Fixes #2065. Commit ready for merge. 
- Legacy-Id: 12505
 2016-12-12 21:42:53 +00:00
Henrik Levkowetz 03d90163a5 Merged django-1.8 work forward to copy of 6.39.1 
- Legacy-Id: 12504
 2016-12-10 19:32:46 +00:00
Ole Laursen 3f98a1a182 Add missing team constraint in the check for previous reviews by a 
reviewer. Commit ready for merge.
 - Legacy-Id: 12479
 2016-12-08 12:49:56 +00:00
Henrik Levkowetz 3b6f30fc9a Fixed a type mismatch (no_review_from_teams_on_doc() is called with both Document and DocHistory instances; this has to be taken into account) 
- Legacy-Id: 12453
 2016-12-05 14:38:37 +00:00
Ole Laursen 7d8baf0015 Add reviewer name and completion date to previous reviews in manage 
review page
 - Legacy-Id: 12397
 2016-11-25 10:53:37 +00:00
Ole Laursen 39d674b4ca Add missing resource and missing test review secretary settings 
- Legacy-Id: 12313
 2016-11-09 10:07:49 +00:00
Ole Laursen ceec1254f2 Add review team secretary reminders, like those for reviewers 
- Legacy-Id: 12283
 2016-11-08 16:24:28 +00:00
Ole Laursen cde7cfacd5 Modify the reviewer overview page to display up to 10 historic reviews 
per person from the past year instead of only 5.

Add basic reviewer stats to the assignment select box.
 - Legacy-Id: 12279
 2016-11-07 22:32:53 +00:00
Ole Laursen c3e8cabafb Revamp the layout in the manage review requests page. Drop the table 
and instead provide more information about each document to be
reviewed, to help the secretaries determine locally on that page what
action to take. The new layout should also make it easier to fit in
more info, in case it is still found lacking.

The public review request page still provides the previous information
in the summarized tabular form, so the overview can be found there.
 - Legacy-Id: 12278
 2016-11-07 21:20:15 +00:00
Ole Laursen 19a3f10f69 Fix bug in telechat code, a previous rewrite to fix a possible problem 
was misguided - we should always only look at the latest telechat
event
 - Legacy-Id: 12265
 2016-11-03 23:43:01 +00:00
Ole Laursen ac1b93a8a2 Base the assignment checks on persons rather than email addresses - 
otherwise people may use a new email address and not be caught in a
check
 - Legacy-Id: 12264
 2016-11-03 21:01:41 +00:00
Ole Laursen 7461409f7f Fix bug in suggestion algorithm, it was pruning suggestions with 
review requests from all teams, not just the team under consideration
 - Legacy-Id: 12257
 2016-11-03 20:31:44 +00:00
Ole Laursen b9d5352afd Display the reviewed revision in reviewer overview page 
- Legacy-Id: 12245
 2016-11-02 11:33:25 +00:00
Ole Laursen 77d7d8b236 Add totals to review statistics tables and make it possible to select 
multiple teams in the graph and get accumulated counts shown
 - Legacy-Id: 12223
 2016-10-27 21:36:02 +00:00
Ole Laursen 3835532d71 Insert iconic link to review statistics from the team pages 
- Legacy-Id: 12215
 2016-10-26 13:35:32 +00:00
Ole Laursen 2548153894 Fix permission bug, secretaries should be able to request reviews 
- Legacy-Id: 12191
 2016-10-20 19:57:39 +00:00
Ole Laursen d0877a0aa9 Change default of ReviewerSettings.min_interval to null - if it's not 
specified for a reviewer, we don't take it into account
 - Legacy-Id: 12168
 2016-10-18 10:36:42 +00:00
Ole Laursen 78e4fa623e Tweak the sort order so that the minimum interval between reviews is 
considered of lower importance compared to previous reviews/wishes to
review the document
 - Legacy-Id: 12167
 2016-10-17 21:52:07 +00:00
Ole Laursen 6b492ccf59 Only suggest I-Ds for review, not other types of documents 
- Legacy-Id: 12165
 2016-10-17 21:38:15 +00:00
Ole Laursen 399bb3bf4d Make UnavailablePeriod.start_date nullable and import the unavailable 
periods from the Perl tool with start date null as we don't know when
they started.
 - Legacy-Id: 12161
 2016-10-17 19:37:56 +00:00
Ole Laursen bf55237112 Add statistics section with review statistics. Fix a couple of missing tests. 
- Legacy-Id: 12124
 2016-10-13 15:20:04 +00:00
Ole Laursen 59180240af Add a simple reminder system for reviewers so that they can opt in to 
being reminded X days before deadline of an assignment
 - Legacy-Id: 12101
 2016-10-07 16:43:29 +00:00
Ole Laursen 227fdd7953 Add reviews to search results and IESG agenda. Support restricting 
review types so that teams will only have those review types
listed and suggested that they are configured to have.

Fix a couple of things in the importer after having tested it on all
the databases. Set unavailable end date >= 2020 to indefinite.

Fix a couple of bugs.
 - Legacy-Id: 12095
 2016-10-06 14:47:41 +00:00
Ole Laursen 037556bc8f Set request time for auto-suggested review requests to the time where 
the triggering event happened - this is probably only marginally
useful at the moment, but could perhaps be used for statistics later
on (e.g. comparing earliest possible request time vs. assignment time)
 - Legacy-Id: 12085
 2016-10-05 13:04:07 +00:00
Ole Laursen a177dc616b Fix a couple of bugs, add test for reviewer overview page 
- Legacy-Id: 12081
 2016-10-04 20:22:11 +00:00
Ole Laursen 4c7b2847ba Add a utility function for extracting information about review 
requests for a given set of teams/reviewers (making it trivial to
compute statistics), revamp the related doc event code to support this
by referencing the review request directly, add a reviewer overview
page with recent performance for each reviewer as well as
settings/unavailable periods. Fix some bugs and shuffle some of the
review code a bit around.

Finish the importer from the previous Perl-based review tool,
importing log entries, figuring out whether a given review is
early/telechat/last call and fixing corner cases.
 - Legacy-Id: 12080
 2016-10-03 15:52:32 +00:00
Ole Laursen 99beb58291 Implement a round-robin rotation scheme for reviewers instead of 
relying on when they last reviewed. In-order assignments automatically
move the rotation forwards while out-of-order assignments increment
the skip next of the assigned reviewer. Include rotation in open
review assignments email. Fix a couple of issues in the importer.
 - Legacy-Id: 12015
 2016-09-21 16:52:50 +00:00
Ole Laursen 6da25e6bd9 Add personal review overview page for reviewers, add page for editing 
reviewer availability settings, emailing the reviewer/secretary as
necessary, add tests for these pages. Fix a bunch of bugs.
 - Legacy-Id: 11998
 2016-09-19 16:05:32 +00:00
Ole Laursen 119f7256f1 Fix a bug in emailing review request change notifications 
- Legacy-Id: 11920
 2016-09-02 20:28:51 +00:00
Ole Laursen 24dd268a81 Show on document page if teams are not going to review that version 
- Legacy-Id: 11851
 2016-08-24 09:08:37 +00:00
Ole Laursen dd190b87fe Follow replacements when displaying reviews for a draft on the 
document page, too. Add a test to check that recursive replacements
are handled correctly. Polish the display a bit.
 - Legacy-Id: 11847
 2016-08-23 14:55:42 +00:00
Ole Laursen 3bfde085c5 Fix bug 
- Legacy-Id: 11844
 2016-08-23 13:03:16 +00:00
Ole Laursen 1f71268da1 More polish on manage review requests page: Add save and continue 
editing button, reverse sort order so latest (and probably most
interesting) is at the top, disable save buttons when there are no
changes to save
 - Legacy-Id: 11843
 2016-08-23 12:12:24 +00:00
Ole Laursen 7246733154 Reword assignment choices code to make it a bit clearer 
- Legacy-Id: 11838
 2016-08-23 10:06:48 +00:00
Ole Laursen 426542771a Turn ReviewRequest.deadline into a date field with no time 
- Legacy-Id: 11801
 2016-08-17 15:10:39 +00:00
Ole Laursen 0e808518bc Make it possible to request review for more than one team at the time, 
auto-select the team for team secretaries/delegates
 - Legacy-Id: 11786
 2016-08-15 16:05:56 +00:00
Ole Laursen 8a5d9d7a72 Make it more obvious that a review is not completed yet, include 
ongoing reviews in the list on the review document page
 - Legacy-Id: 11785
 2016-08-15 15:46:11 +00:00
Ole Laursen 78062adc2f Use request.build_absolute_uri instead of grabbing the domain from the 
current Site in the review code
 - Legacy-Id: 11753
 2016-08-03 15:13:55 +00:00
Ole Laursen cd1250b22d Be more specific about the revision and deadline in the review request email 
- Legacy-Id: 11633
 2016-07-12 15:33:24 +00:00
Ole Laursen 5b191285d6 Fix role misspelling that prevented review team secretaries from 
accessing protected pages
 - Legacy-Id: 11628
 2016-07-12 13:42:19 +00:00
Ole Laursen db4ea01e20 Take a bunch of factors into account when sorting reviewers for 
assignment to a review request
 - Legacy-Id: 11626
 2016-07-12 13:04:14 +00:00
Ole Laursen 5c8be91b08 Improve review assignment slightly by sorting reviewers by latest 
review - still missing a bunch of factors, and unassignment is now
temporarily gone
 - Legacy-Id: 11531
 2016-07-07 12:17:55 +00:00
Ole Laursen 7aff7d3e72 Fix some bugs in retrieving review requests for replacement documents 
- Legacy-Id: 11529
 2016-07-06 13:27:41 +00:00
Ole Laursen d54459b28a Add tests of suggested review requests, make suggestions take more 
things into account
 - Legacy-Id: 11528
 2016-07-06 13:14:11 +00:00
Ole Laursen 19fff81a4f Rework closing a review request so the logic is reusable, add the more 
specific close reasons to the database migration, add
ReviewRequest.requested_by so it's possible to notify the requester of
a review that it has been dropped.
 - Legacy-Id: 11520
 2016-07-05 16:05:00 +00:00
Ole Laursen e2e66522c7 Add review request page for review teams and first draft of manage 
review requests page.

Add importer for importing review data from the existing Perl tool
(WIP, gets most but not all of the interesting information out).

Fix various bugs.
 - Legacy-Id: 11508
 2016-07-01 16:06:16 +00:00
Ole Laursen 7cbe36fb62 Implement completing a review with tests. One can currently 
enter/upload content or retrieve it from an IETF mailarch archive
through integrated searching support. Support for partial completion.
 - Legacy-Id: 11360
 2016-06-14 11:28:53 +00:00
Ole Laursen b9f4b7005e Add simple email notifications for assigning/rejecting review requests 
- Legacy-Id: 11236
 2016-05-24 14:02:59 +00:00
Ole Laursen 5dd079e2f8 Add support for assigning a reviewer to a review request, still some 
corners missing. Fix a couple of other issues.
 - Legacy-Id: 11227
 2016-05-23 16:42:49 +00:00
Ole Laursen 64a65340a2 Add review tracking models, add a request review page (with test), show 
review requests on doc page
 - Legacy-Id: 11206
 2016-05-19 15:35:30 +00:00