Disallow requesting directorate reviews of RFCs (such things would better be done with reviews of status change documents). Fixes #2065. Commit ready for merge.

- Legacy-Id: 12505

ietf/doc/tests_review.py

@@ -75,6 +75,17 @@ class ReviewTests(TestCase):
             self.assertEqual(req.requested_rev, "01")
             self.assertEqual(doc.latest_event().type, "requested_review")
 
+    def test_request_review_of_rfc(self):
+        make_test_data()
+        doc = Document.objects.filter(states__type_id='draft',states__slug='rfc').first()
+        make_review_data(doc)
+
+        url = urlreverse('ietf.doc.views_review.request_review', kwargs={ "name": doc.name })
+        login_testing_unauthorized(self, "ad", url)
+
+        # get should fail
+        r = self.client.get(url)
+        self.assertEqual(r.status_code, 403)
 
     def test_doc_page(self):
         doc = make_test_data()

ietf/review/utils.py

@@ -29,6 +29,9 @@ def can_request_review_of_doc(user, doc):
     if not user.is_authenticated():
         return False
 
+    if doc.type_id == 'draft' and doc.get_state_slug() != 'active':
+        return False
+
     return (is_authorized_in_doc_stream(user, doc)
             or Role.objects.filter(person__user=user, name="secr", group__in=active_review_teams).exists())