altf4arnold/datatracker
1
0
Fork 0
Code Issues Pull requests Actions 3 Packages Projects Releases Wiki Activity

Fix permission bug, secretaries should be able to request reviews

Browse source 
- Legacy-Id: 12191
This commit is contained in:
Ole Laursen 2016-10-20 19:57:39 +00:00
parent 31931ee0e8
commit 2548153894
2 changed files with 4 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
ietf/doc/tests_review.py
View file

@ -48,7 +48,7 @@ class ReviewTests(TestCase):
review_team = review_req.team
url = urlreverse('ietf.doc.views_review.request_review', kwargs={ "name": doc.name })
login_testing_unauthorized(self, "secretary", url)
login_testing_unauthorized(self, "reviewsecretary", url)
# get
r = self.client.get(url)

5
ietf/review/utils.py
View file

@ -27,13 +27,14 @@ def can_request_review_of_doc(user, doc):
if not user.is_authenticated():
return False
return is_authorized_in_doc_stream(user, doc)
return (is_authorized_in_doc_stream(user, doc)
or Role.objects.filter(person__user=user, name="secr", group__in=active_review_teams).exists())
def can_manage_review_requests_for_team(user, team, allow_non_team_personnel=True):
if not user.is_authenticated():
return False
return (Role.objects.filter(name__in=["secr", "delegate"], person__user=user, group=team).exists()
return (Role.objects.filter(name="secr", person__user=user, group=team).exists()
or (allow_non_team_personnel and has_role(user, "Secretariat")))
def review_requests_to_list_for_docs(docs):