Removed the possibility of choosing '(None)' as reviewer from the bulk review request edit form; this prevents a crash on line 1474 of ietf/group/views.py, in manage_review_request(). The view code needs further care in order make it possible to unassign an assignment here.

- Legacy-Id: 14570

ietf/group/forms.py

@@ -219,7 +219,7 @@ class ManageReviewRequestForm(forms.Form):
 
     action = forms.ChoiceField(choices=ACTIONS, widget=forms.HiddenInput, required=False)
     close = forms.ModelChoiceField(queryset=close_review_request_states(), required=False)
-    reviewer = PersonEmailChoiceField(empty_label="(None)", required=False, label_with="person")
+    reviewer = PersonEmailChoiceField(empty_label=None, required=False, label_with="person")
     add_skip = forms.BooleanField(required=False)
 
     def __init__(self, review_req, *args, **kwargs):

ietf/review/utils.py

@@ -699,7 +699,7 @@ def setup_reviewer_field(field, review_req):
         field.initial = review_req.reviewer_id
 
     choices = make_assignment_choices(field.queryset, review_req)
-    if not field.required:
+    if not field.required and not field.empty_label is None:
         choices = [("", field.empty_label)] + choices
 
     field.choices = choices