altf4arnold/datatracker
1
0
Fork 0
Code Issues Pull requests Actions 3 Packages Projects Releases Wiki Activity

Reword assignment choices code to make it a bit clearer

Browse source 
- Legacy-Id: 11838
This commit is contained in:
Ole Laursen 2016-08-23 10:06:48 +00:00
parent 742bf4b233
commit 7246733154
1 changed files with 10 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
ietf/review/utils.py
View file

@ -333,10 +333,10 @@ def make_assignment_choices(email_queryset, review_req):
now = datetime.datetime.now()
def add_boolean_score(scores, direction, expr, expl):
def add_boolean_score(scores, direction, expr, explanation):
scores.append(int(bool(expr)) * direction)
if expr:
explanations.append(expl)
explanations.append(explanation)
ranking = []
for e in possible_emails:
@ -344,9 +344,6 @@ def make_assignment_choices(email_queryset, review_req):
if not reviewer:
reviewer = ReviewerSettings()
explanations = []
scores = [] # build up score in separate independent components
days_past = None
latest = latest_assignment_for_reviewer.get(e.pk)
if latest is not None:
@ -362,11 +359,17 @@ def make_assignment_choices(email_queryset, review_req):
d = -d
ready_for = "frequency exceeded, ready in {} {}".format(d, "day" if d == 1 else "days")
explanations.append(ready_for)
# we sort the reviewers by separate axes, listing the most
# important things first
scores = []
explanations = []
explanations.append(ready_for) # show ready for explanation first, but sort it after the other issues
add_boolean_score(scores, +1, e.pk in has_reviewed_previous, "reviewed document before")
add_boolean_score(scores, +1, e.pk in would_like_to_review, "wants to review document")
add_boolean_score(scores, -1, e.pk in connections, connections.get(e.pk))
add_boolean_score(scores, -1, e.pk in connections, connections.get(e.pk)) # reviewer is somehow connected: bad
add_boolean_score(scores, -1, reviewer.filter_re and any(re.search(reviewer.filter_re, n) for n in aliases), "filter regexp matches")
add_boolean_score(scores, -1, reviewer.unavailable_until and reviewer.unavailable_until > now, "unavailable until {}".format((reviewer.unavailable_until or now).strftime("%Y-%m-%d %H:%M:%S")))