Commit graph

1673 commits

Author SHA1 Message Date
Henrik Levkowetz 42c620f4ae Fixed search result ordering where we had comparisons between int and str, which is disallowed in py3.
- Legacy-Id: 16335
2019-06-29 13:32:44 +00:00
Henrik Levkowetz 2b1f238204 Changed regex strings to raw strings and fixed a sort comparison int/str issue.
- Legacy-Id: 16333
2019-06-29 13:29:13 +00:00
Henrik Levkowetz 484dcece5f Changed all model __unicode__() methods to __str__()
- Legacy-Id: 16330
2019-06-28 21:07:08 +00:00
Henrik Levkowetz d40a5ac5ac Removed some regex unicode flags.
- Legacy-Id: 16321
2019-06-28 13:33:38 +00:00
Henrik Levkowetz 06daf6ac65 Changed regex strings to raw strings.
- Legacy-Id: 16312
2019-06-27 18:08:02 +00:00
Henrik Levkowetz 3ec7e864be Converted leading tabs to spaces in ietf/**/*.py
- Legacy-Id: 16310
2019-06-27 14:51:02 +00:00
Henrik Levkowetz d7f5c84182 Initial 2to3 patch with added copyright statement updates.
- Legacy-Id: 16309
2019-06-27 14:40:54 +00:00
Henrik Levkowetz db12f2b948 Fixed some name versus pk issues lingering after the Document/DocAlias primary key refactoring. Fixes issue #2729.
- Legacy-Id: 16288
2019-06-19 12:57:52 +00:00
Henrik Levkowetz 7270d5f67a Added the option to order API resource lists by primary key, for stable ordering when paging through a list.
- Legacy-Id: 16284
2019-06-18 12:40:19 +00:00
Henrik Levkowetz 565c55ab05 The Document and DocAlias primary key refactoring caused the Tastypie API under /api/v1/ to change -- reverting that to use the old form, with name ask key.
- Legacy-Id: 16282
2019-06-17 18:53:17 +00:00
Henrik Levkowetz 05c5abed53 Added a missing migration
- Legacy-Id: 16263
2019-06-16 13:18:06 +00:00
Henrik Levkowetz be92e6b868 Removed an incorrect log.unreachble() invocation.
- Legacy-Id: 16262
2019-06-15 21:32:15 +00:00
Henrik Levkowetz 426870b766 Merged in the Document and DocAlias primary key change and m2m work in ^/personal/henrik/6.96.1-docalias.
- Legacy-Id: 16261
2019-06-15 12:00:48 +00:00
Henrik Levkowetz a2cafded25 Changed DocAlias to be many-to-many, in order to be able to handle STD aliases referring to multiple RFCs.
- Legacy-Id: 16249
2019-06-14 20:38:14 +00:00
Henrik Levkowetz 815602351f This is a series of 50 migrations that changes the Document and DocAlias
primary keys from character strings to integers, and makes corresponding code
changes.

This was prompted by database limitations discovered when trying to make
DocAlias use a m2m document field; with 255 long strings as primary keys for
Document and DocAlias this violated the MySQL database limitations.

Changing the primary keys to integers should also improve efficiency.  

Due to the data migrations which create the new integer primary keys and adds
corresponding integer foreign keys matching the previous string foreign keys
in all tables having foreign keys to Document and DocAlias, some of these
migrations take a long time.  The total set of migrations are expected to have
a runtime on the order of 2 hours.
 - Legacy-Id: 16237
2019-06-10 11:32:46 +00:00
Henrik Levkowetz 1b5cdfe2f5 Added review assignment information to the review-document view. Addresses issue #2717.
- Legacy-Id: 16203
2019-05-07 21:53:38 +00:00
Henrik Levkowetz 2538a581c2 Whitespace changes only
- Legacy-Id: 16187
2019-05-06 13:32:29 +00:00
Henrik Levkowetz ed2042da0e Some additional tweaks to the review assingment migrations.
- Legacy-Id: 16183
2019-05-02 15:40:21 +00:00
Henrik Levkowetz 9282195d6c Fixed some migrations issues that prevented the review assignment refactoring migrations from being reversed and re-applied.
- Legacy-Id: 16182
2019-05-02 13:49:14 +00:00
Henrik Levkowetz ca1f3340c0 Changed a ReviewAssignmentDocEvent type from 'closed_review_request' to 'closed_review_assignment', for consistency and readability.
- Legacy-Id: 16181
2019-05-02 12:38:41 +00:00
Henrik Levkowetz 8726e74709 Merged in a refactoring of document review code from rjsparks@nostrum.com. This introduces ReviewAssignments, letting us do multiple assingments for a given RevieRequest, without conflating the assignments and their results with the request itself.
- Legacy-Id: 16177
2019-04-30 16:54:06 +00:00
Henrik Levkowetz bb4fe3fbbf Undid previous commit
- Legacy-Id: 16153
2019-04-22 19:22:42 +00:00
Henrik Levkowetz cfcefc2e32 Merged in [16144] from housley@vigilsec.com:
Remove some clutter from I-D upload page.  The information was mived to the Instructions tab, but a higligh to the Note Well and BCP 78 was added. Fixes #2057.
 - Legacy-Id: 16151
Note: SVN reference [16144] has been migrated to Git commit 37851b9742
2019-04-22 17:39:26 +00:00
Henrik Levkowetz 33e0f8c35d Merged in [16126] from housley@vigilsec.com:
Allow Secretariat to handle downrefs when they approve a document
 - Legacy-Id: 16134
Note: SVN reference [16126] has been migrated to Git commit 8c7e75101d
2019-04-08 17:02:02 +00:00
Henrik Levkowetz 5aad3a652d Merged in [16110] from rjsparks@nostrum.com:
Include the note itself in email sent when the RFC editor note changes after document approval. Also changed the flow to redirect back to the writeups pages after editing the RFC editor note. Fixes #2672.
 - Legacy-Id: 16130
Note: SVN reference [16110] has been migrated to Git commit fbfd204eb9
2019-04-03 19:30:10 +00:00
Henrik Levkowetz c7e5459d5a Merged in [16109] from rjsparks@nostrum.com:
Protect drafts in certain IRTF states from expiring. Fixes #2669.
 - Legacy-Id: 16129
Note: SVN reference [16109] has been migrated to Git commit 003e472d04
2019-04-03 19:03:38 +00:00
Russ Housley 8c7e75101d Allow Secretariat to handle downrefs when they approve a document
- Legacy-Id: 16126
2019-04-01 19:46:14 +00:00
Robert Sparks fbfd204eb9 Include the note itself in email sent when the RFC editor note changes after document approval. Also changed the flow to redirect back to the writeups pages after editing the RFC editor note. Fixes #2672. Commit ready for merge.
- Legacy-Id: 16110
2019-03-28 10:07:11 +00:00
Robert Sparks 003e472d04 Protect drafts in certain IRTF states from expiring. Fixes #2669. Commit ready for merge.
- Legacy-Id: 16109
2019-03-28 08:48:35 +00:00
Peter E. Yee cfdbae1f3c Fixed bad calls to rfcdiff for -00 drafts and replaced drafts. Fixes issue #2697. Commit ready for merge.
- Legacy-Id: 16095
2019-03-23 18:17:51 +00:00
Robert Sparks 81c5b5091a Made some docevent creation more consistent. Addressed the TODOs added during the refactor.
- Legacy-Id: 16049
2019-03-19 18:48:05 +00:00
Robert Sparks f57fb6b8a6 Added the ability to withdraw individual assignments. Added the ability to mark individual assignments no-response.
- Legacy-Id: 16039
2019-03-18 21:15:20 +00:00
Robert Sparks da3174ab68 Improved several views.
- Legacy-Id: 16038
2019-03-18 19:41:07 +00:00
Robert Sparks 4b147f2ef8 More cleanup and correction. Caught a pervasive misuse of a state-name
- Legacy-Id: 16036
2019-03-15 20:39:06 +00:00
Henrik Levkowetz 56543d565c Changed sending of PubReq messages to explicitly use on-behalf-of, without Reply-To. Reply-To is picked up as requestor by RT. Fixes issue #2691 anew.
- Legacy-Id: 16034
2019-03-14 21:31:40 +00:00
Robert Sparks 334767fa6f Some admin tweaks and removal of a dead template. Tests all pass now. Functionality is still not right.
- Legacy-Id: 16032
2019-03-14 19:14:33 +00:00
Robert Sparks 0856990683 Checkpoint. Most tests do not fail. Oddness with an API resource, and with one template's coverage
- Legacy-Id: 16031
2019-03-14 18:39:40 +00:00
Robert Sparks a4db66564c Checkpoint. Ended up chasing group.views_review before stats.
- Legacy-Id: 16030
2019-03-13 22:02:10 +00:00
Robert Sparks 073ce55f6c Checkpoint. ReviewTests pass, but others still fail of course. Next step is to address stats.
- Legacy-Id: 16021
2019-03-12 17:48:19 +00:00
Henrik Levkowetz 682ddee8e4 Reverted earlier application of on_behalf_of() at mail sending call points, and instead did all on_behalf_of processing in condition_message(). Added insertion of Reply-To header fields in this case. Changed all use of the mail-sending 'extra' parameters to use value lists. Updated a bunch of tests accordingly.
- Legacy-Id: 16020
2019-03-11 17:01:33 +00:00
Henrik Levkowetz df42be5d0c Converted a test to use .assertIn() instead of .assertTrue(... in ...) for better failure reports.
- Legacy-Id: 16016
2019-03-09 14:56:47 +00:00
Robert Sparks b85052fe63 Checkpoint. Lots of tests will still fail. Reordered some migrations. Brought about half of the ietf.doc.views_review views into line with the new models. Next step is the other half.
- Legacy-Id: 16012
2019-03-07 23:08:14 +00:00
Henrik Levkowetz 896f4cd8c7 Fixed a test discrepancy.
- Legacy-Id: 15995
2019-03-05 16:19:28 +00:00
Henrik Levkowetz 55bd2e5e42 Fixed some unintentional wg list address changes, and added some other test mail address changes.
- Legacy-Id: 15994
2019-03-04 20:54:38 +00:00
Henrik Levkowetz 435a0da12d Added on_behalf_of() calls for from addresses needing it throughout the code.
- Legacy-Id: 15992
2019-03-04 20:14:19 +00:00
Henrik Levkowetz 2b811b3d3d Updated the tests to always use @ietf.org addresses where appropriate, and not do so when not appropriate. All test user login addresses have been changed away from @ietf.org.
- Legacy-Id: 15988
2019-03-04 20:08:48 +00:00
Robert Sparks 82025f9dca Continuing to checkpoint.
- Legacy-Id: 15986
2019-03-01 23:23:39 +00:00
Robert Sparks e91d706d5b Checkpointing. This is an incomplete idea. The tests will fail massively.
- Legacy-Id: 15985
2019-03-01 23:19:47 +00:00
Henrik Levkowetz c9db218e31 Increased the DocumentURL.url field length to the legal URL maximum of 2083
- Legacy-Id: 15972
2019-02-25 21:05:25 +00:00
Henrik Levkowetz b57ad67041 Updated code and templates to use the new docman and groupman group features.
- Legacy-Id: 15922
2019-01-30 15:59:00 +00:00
Henrik Levkowetz ef97f2a821 Merged in GroupFeatures refactoring and expansion from ^/personal/henrik/6.89.4.dev0@15911.
- Legacy-Id: 15912
2019-01-24 15:25:01 +00:00
Henrik Levkowetz c87d3741f3 Added 2 utility functions to help create group features query filters, and applied them in 3 places in order to move group feature role list code back into DB queries.
- Legacy-Id: 15911
2019-01-23 18:40:39 +00:00
Henrik Levkowetz 57a4c9f41f Added 9 new group features, and changed list-like char fields to json fields, to get better support for using the values as lists. Modified code to use the group features instead of explicit lists of group types in many places in the code.
- Legacy-Id: 15908
2019-01-22 18:11:46 +00:00
Henrik Levkowetz f671e391f7 Reverted r15071 with respects to showing the submit for publication button to shepherds. Fixes issue #2673.
- Legacy-Id: 15906
2019-01-21 12:32:13 +00:00
Henrik Levkowetz b4e46cd559 Migration reordering to avoid schema migrations after data migrations.
- Legacy-Id: 15881
2019-01-14 14:22:13 +00:00
Robert Sparks 87dd249415 Cleanup: removed the infrastructure for importing reviews from the old review tool. Commit ready for merge.
- Legacy-Id: 15865
2019-01-03 21:04:13 +00:00
Robert Sparks 25cc00f925 Refactored DocumentInfo to address overloading the external_url field with strings that are not URLs. Commit ready for merge.
- Legacy-Id: 15864
2019-01-02 22:55:00 +00:00
Robert Sparks f6886f6105 Corrected a conditional expression and improved the test that exercised it. Commit ready for merge.
- Legacy-Id: 15822
2018-12-14 21:50:21 +00:00
Robert Sparks 6118975620 Added an explicit ID-Exists state for the IESG state machine. Reworked code so that the IESG state machine always has a state. Added the ability to release a document from a working group, research group, or the independent stream. Releasing a document removes all stream state, and sets the document to have no stream.
- Legacy-Id: 15809
2018-12-11 22:38:05 +00:00
Henrik Levkowetz d2b86bc225 Increased the document limit from 200 to 500 for the AD documents page.
- Legacy-Id: 15788
2018-11-26 18:52:18 +00:00
Henrik Levkowetz 68c48f19a0 Improved resolution of an issue with the To: and Cc: addresses of extra review email to responsible AD.
- Legacy-Id: 15778
2018-11-20 13:36:12 +00:00
Henrik Levkowetz 9821406f60 Fixed an issue with the To: and Cc: addresses of extra review email to responsible AD.
- Legacy-Id: 15777
2018-11-20 13:20:16 +00:00
Henrik Levkowetz 143a58d3cc Added handling for an EOF exception that can occur when using the django file-based cache.
- Legacy-Id: 15769
2018-11-13 13:39:47 +00:00
Henrik Levkowetz 13b20f83cb Merged in [15720] from rjsparks@nostrum.com:
invalidate the get_state_slug cache when the get_state cache is invalidated. Fixes #2630.
 - Legacy-Id: 15760
Note: SVN reference [15720] has been migrated to Git commit f1c1b9fc6c
2018-11-12 15:38:17 +00:00
Henrik Levkowetz 3b811ecb41 Merged in [15708] and [15730] from housley@vigilsec.com:
Added a mail alias for all review team secretaries. Fixes #2139.  Use
the alias if there is one for email about review request changes.  Added
a test for the review team secretary alias functionality.
 - Legacy-Id: 15746
Note: SVN reference [15708] has been migrated to Git commit 6067dcbfef

Note: SVN reference [15730] has been migrated to Git commit d525ade0b0
2018-11-10 19:30:32 +00:00
Henrik Levkowetz 0d9c97c5ca Added a test that checks the mailarch search failure return, and tweaks the no-result return handling.
- Legacy-Id: 15745
2018-11-10 19:06:40 +00:00
Henrik Levkowetz 236ee7639d Merged in [15706] from kivinen@iki.fi:
Added easier to detect error message when search returns 0 results. This currently parses html result from the mailarchive system, but when we get proper API to mailarchive system it should be changed to do that instead. Fixes #2126.
 - Legacy-Id: 15744
Note: SVN reference [15706] has been migrated to Git commit f9eeee0cc9
2018-11-09 21:23:45 +00:00
Henrik Levkowetz 89ef806013 Merged in [15701] from kivinen@iki.fi:
Changed format of the reviewer statistics in lists. Fixes #2131.
 - Legacy-Id: 15735
Note: SVN reference [15701] has been migrated to Git commit 56acd00c6c
2018-11-07 05:24:25 +00:00
Russ Housley d525ade0b0 Use review team secretary alias if there is one for email about review request changes. Add test for review team secretary alias. Commit ready for merge.
- Legacy-Id: 15730
2018-11-06 07:26:30 +00:00
Henrik Levkowetz e4af908a74 Merged in [15698] from rjsparks@nostrum.com:
Notify the RFC Editor when an RFC Editor note is changed after a draft has been approved. Fixes #2440.
 - Legacy-Id: 15729
Note: SVN reference [15698] has been migrated to Git commit 43374969f6
2018-11-06 07:13:56 +00:00
Robert Sparks f1c1b9fc6c invalidate the get_state_slug cache when the get_state cache is invalidated. Fixes #2630. Commit ready for merge.
- Legacy-Id: 15720
2018-11-05 22:43:02 +00:00
Tero Kivinen f9eeee0cc9 Added easier to detect error message when search returns 0 results. This currently parses html result from the mailarchive system, but when we get proper API to mailarchive system it should be changed to do that instead. Fixes #2126. Commit ready for merge.
- Legacy-Id: 15706
2018-11-03 11:08:18 +00:00
Tero Kivinen 56acd00c6c Changed format of the reviewer statistics in lists. Fixes #2131. Commit ready for merge.
- Legacy-Id: 15701
2018-11-03 09:04:57 +00:00
Henrik Levkowetz 3b8d9ae832 Merged in [15684] from rjsparks@nostrum.com:
Removed the field and widget that made editing document states easier on the document admin page since they do not survive validation failure of other fields on the form. Excluded states from the modelform since the default states widget is almost impossible to use without producing bad data. If states need to be edited through the admin, it will, for now, need to be done gruelingly through the admin form for State. Fixes #2524.
 - Legacy-Id: 15700
Note: SVN reference [15684] has been migrated to Git commit 128c0a6dbb
2018-11-03 09:01:59 +00:00
Robert Sparks 43374969f6 Notify the RFC Editor when an RFC Editor note is changed after a draft has been approved. Fixes #2440. Commit ready for merge.
- Legacy-Id: 15698
2018-11-03 08:13:10 +00:00
Robert Sparks 5db8831b81 Clearly label cancelled sessions on the week-view on the agenda page. Fixes #2619. Commit ready for merge.
- Legacy-Id: 15694
2018-11-03 06:57:59 +00:00
Henrik Levkowetz 95161df4f4 Merged in [15679] from mahoney@nostrum.com:
Verb tense used in Ballot Issued emails now matches whether the LC end date is in the past or future. Fixes issue #2482.
 - Legacy-Id: 15685
Note: SVN reference [15679] has been migrated to Git commit 194d8c89d1
2018-11-03 04:37:41 +00:00
Robert Sparks 128c0a6dbb Removed the field and widget that made editing document states easier on the document admin page since they do not survive validation failure of other fields on the form. Excluded states from the modelform since the default states widget is almost impossible to use without producing bad data. If states need to be edited through the admin, it will, for now, need to be done gruelingly through the admin form for State. Fixes #2524. Commit ready for merge.
- Legacy-Id: 15684
2018-11-03 04:28:50 +00:00
Jean Mahoney 194d8c89d1 Verb tense used in Ballot Issued emails now matches whether the LC end date is in the past or future. Fixes issue #2482. Commit ready for merge.
- Legacy-Id: 15679
2018-11-03 03:38:52 +00:00
Robert Sparks b76ea7bcd5 Let a reviewer indicate that an AD should give this review early attention. Fixes #2553. Commit ready for merge.
- Legacy-Id: 15676
2018-11-02 21:23:27 +00:00
Robert Sparks c7bf147b1d Let review teams opt in to poking a responsible AD when unhappy reviews are submitted. Fixes #2544. Commit ready for merge.
- Legacy-Id: 15675
2018-11-02 20:18:06 +00:00
Henrik Levkowetz 282a410f3f Merged in [15613] from rjsparks@nostrum.com:
Make having a trailing slash optional for doc/html/docname. Fixes #2247.
 - Legacy-Id: 15618
Note: SVN reference [15613] has been migrated to Git commit 7593230edde63d4d2e8ec04c455e862aa5e71f21
2018-10-30 14:02:46 +00:00
Henrik Levkowetz 90e773aafa Merged in [15601] from rjsparks@nostrum.com:
Corrected some DocTypeName entries' prefix value. Made the search code more robust against DocTypeName objects that have an empty prefix value. Fixes #2599.
 - Legacy-Id: 15604
Note: SVN reference [15601] has been migrated to Git commit 22d459362aec2a06854a515fbcebfec54e8a6e69
2018-10-21 12:36:01 +00:00
Henrik Levkowetz 3508f59f52 Merged in [15596] from rjsparks@nostrum.com:
improved coverage for several tests.
 - Legacy-Id: 15600
Note: SVN reference [15596] has been migrated to Git commit 6f18ae882532433ba86322b33c34f5f1b0350cb9
2018-10-19 14:27:13 +00:00
Henrik Levkowetz ef3cbf4684 Merged in [15595] from rjsparks@nostrum.com:
Converted stats, submit, sync. and utils/test to use factories. Excluded utils/test_data from coverage checks.
 - Legacy-Id: 15599
Note: SVN reference [15595] has been migrated to Git commit 39e76a836996ec9ed8ea449c92bdfae91c3dbaae
2018-10-19 12:54:58 +00:00
Henrik Levkowetz 15c8ab9506 Ensure the send_mail argument to save_position is a boolean.
- Legacy-Id: 15547
2018-10-09 16:34:45 +00:00
Henrik Levkowetz 22a2e29db8 Added an send_email field to BallotPostitionDocEvent to reflect whether the 'Send email' button was used to save the ballot position. Reverted a different earlier schema change which had the same purpose. Added icons on documents' IESG evaluation record to reflect this.
- Legacy-Id: 15526
2018-10-07 15:08:17 +00:00
Henrik Levkowetz 9e0e5d66b3 Merged in [15492] from rjsparks@nostrum.com:
Use factories for ipr tests.
 - Legacy-Id: 15516
Note: SVN reference [15492] has been migrated to Git commit 775addc616
2018-10-01 17:51:17 +00:00
Henrik Levkowetz cfb214c48a Added a BallotCommentDocEvent, which extends DocEvent with a send_mail field, in order to better be able to show whether ballot discusses and comments were posted with with the 'send email' button or not.
- Legacy-Id: 15515
2018-10-01 13:31:17 +00:00
Robert Sparks 775addc616 Use factories for ipr tests. Commit ready for merge.
- Legacy-Id: 15492
2018-09-28 23:16:46 +00:00
Henrik Levkowetz 89b8fe6c1b Moved document methods rfc_number() and rfcnum() to the abstract parent class to have them available also for historical document records. Should fix the recent server 500 on /doc/draft-ietf-aaa-diameter/17/.
- Legacy-Id: 15454
2018-09-14 20:29:07 +00:00
Robert Sparks d9b53a5d6c Use unversioned links in ics agendas. Partially fixes #2542. Commit ready for merge.
- Legacy-Id: 15446
2018-09-10 20:12:09 +00:00
Robert Sparks fd8af4b6f7 Review assignment email includes a link to the review request that ensures the reviewer is logged in. Fixes #2543. Commit ready for merge
- Legacy-Id: 15444
2018-09-06 21:39:10 +00:00
Henrik Levkowetz caa3ec98b4 Changed the menu listing of review dirs and their display on the Directorates page back to what it was before the 'reviews' group type was split out. Added a 'Reviews' column to the Directoratges page.
- Legacy-Id: 15420
2018-08-01 18:53:44 +00:00
Henrik Levkowetz 70c5dcc8c4 Merged in [15387] from rjsparks@nostrum.com:
Use factories for ietf.iesg.tests.
 - Legacy-Id: 15406
Note: SVN reference [15387] has been migrated to Git commit 705e4c84d9
2018-07-24 08:25:07 +00:00
Henrik Levkowetz ac55203499 Merged in [15380] from rjsparks@nostrum.com:
Use factories for ietf.idindex.tests.
 - Legacy-Id: 15405
Note: SVN reference [15380] has been migrated to Git commit 2159fdd975
2018-07-24 07:22:26 +00:00
Henrik Levkowetz 85aa1ecc25 Tweaked a test to prevent failures when looking for a specific string in line-wrapped text.
- Legacy-Id: 15397
2018-07-19 15:54:18 +00:00
Robert Sparks 705e4c84d9 Use factories for ietf.iesg.tests. Commit ready for merge.
- Legacy-Id: 15387
2018-07-19 13:13:05 +00:00
Henrik Levkowetz db2c326e73 Merged in [15354] from kivinen@iki.fi:
Added default to review completion draft version number. If the reviewer
is filling in the review form himself the default will be the latest
version of the draft. If it is someone else filling in the review
then the version number is the latest version at the point when review
was assigned (i.e., it assumes reviewer did review on version he was
requested to and then document authors might have updated the document).
Also mark the document versions that are earlier than the review request
date with red background and those which are newer with green background.
Fixes #2125.
 - Legacy-Id: 15386
Note: SVN reference [15354] has been migrated to Git commit dc3e8ee810
2018-07-18 22:36:01 +00:00
Henrik Levkowetz b054a142d9 Merged in [15349] from kivinen@iki.fi:
Removed the requirement for review_content field to be mandatory when
using \'link\' method. This partially addresses #2520. Commit ready for
merge.
 - Legacy-Id: 15383
Note: SVN reference [15349] has been migrated to Git commit 0783890fa5
2018-07-18 18:20:21 +00:00
Henrik Levkowetz e8e2db50b3 Merged in [15347] from kivinen@iki.fi:
Add review request date to the top. Add tooltips for drafts versions
providing the date they were sumbmitted. Fixes #2218. Commit ready for
merge.
 - Legacy-Id: 15382
Note: SVN reference [15347] has been migrated to Git commit dcabfc84f1
2018-07-18 16:36:35 +00:00
Robert Sparks 2159fdd975 Use factories for ietf.idindex.tests. Commit ready for merge.
- Legacy-Id: 15380
2018-07-18 15:35:20 +00:00
Henrik Levkowetz 7abece146c Merged in [15344] from mahoney@nostrum.com:
email confirming interim meeting request now says 'the Area Director of the <area>' instead of '<area> Area Director'. Fixes issue #2522.
 - Legacy-Id: 15378
Note: SVN reference [15344] has been migrated to Git commit 3c478e5c52
2018-07-18 13:16:02 +00:00
Henrik Levkowetz 5b77d01a48 Merged in [15331] from housley@vigilsec.com:
Add test for downref in Last Call announcement
 - Legacy-Id: 15366
Note: SVN reference [15331] has been migrated to Git commit e2808b1c0b
2018-07-16 16:54:56 +00:00
Tero Kivinen dc3e8ee810 Added default to review completion draft version number. If the reviewer
is filling in the review form himself the default will be the latest
version of the draft. If it is someone else filling in the review
then the version number is the latest version at the point when review
was assigned (i.e., it assumes reviewer did review on version he was
requested to and then document authors might have updated the document).
Also mark the document versions that are earlier than the review request
date with red background and those which are newer with green background.
Fixes #2125. Commit ready for merge.
 - Legacy-Id: 15354
2018-07-14 21:54:04 +00:00
Tero Kivinen 0783890fa5 Removed the requirement for review_content field to be mandatory when
using "link" method. This partially addresses #2520. Commit ready for
merge.
 - Legacy-Id: 15349
2018-07-14 20:12:32 +00:00
Tero Kivinen dcabfc84f1 Add review request date to the top. Add tooltips for drafts versions
providing the date they were sumbmitted. Fixes #2218. Commit ready for
merge.
 - Legacy-Id: 15347
2018-07-14 20:07:36 +00:00
Jean Mahoney 3c478e5c52 email confirming interim meeting request now says 'the Area Director of the <area>' instead of '<area> Area Director'. Fixes issue #2522. Commit ready to merge.
- Legacy-Id: 15344
2018-07-14 18:52:38 +00:00
Russ Housley e2808b1c0b Add test for downref in Last Call announcement
- Legacy-Id: 15331
2018-07-14 16:41:22 +00:00
Henrik Levkowetz 2daef52bea This commit replaces the code defined group features with features held
in a database table:

- Added a GroupFeatures model to the group models, and removed the old 
  features.py
- Added a agenda type for future use in showing different group types on
  different agendas.
- Renamed the group feature has_materials to has_nonsession_materials.
- Added API resources and admin support for the new tables.
- Added a Directorate (with reviews) group type as complement to
  Directorate, to distinguish between directorates with and without reviews.
- Adjusted tests as needed.
- Updated the fixtures, and fixed the generate_fixtures script to include
  the new AgendaTypeName objects.

There still exists about 70 instances of code comparing the group type
with a list of types; most of these should probably be replaced with new
features, instead, to make it possible to add new group types through the
database table, rather than having to edit the code.  That was the purpose
of this refactoring from the start, but the presence of this large number
of comparisons of group type against lists of types defeats the goal until
we add appropriate features and replace the group type list comparisons.
 - Legacy-Id: 15316
2018-07-12 10:51:48 +00:00
Henrik Levkowetz 9fe1820640 Tweaked the 'Related documents' part of the Document admin page to more intuitively show the relationships.
- Legacy-Id: 15259
2018-06-14 19:22:55 +00:00
Henrik Levkowetz 41a5f5dca4 Merged in [15248] from rjsparks@nostrum.com:
Improvements to tests after converting to factories suggested by studying coverage_changes.
 - Legacy-Id: 15255
Note: SVN reference [15248] has been migrated to Git commit b86bd84278
2018-06-14 13:11:29 +00:00
Henrik Levkowetz b3301de22e Fixed a pyflakes nit.
- Legacy-Id: 15253
2018-06-14 12:35:16 +00:00
Henrik Levkowetz a3c12d937f Removed two instances of log.assertion(); we have enough data on these now.
- Legacy-Id: 15252
2018-06-14 12:03:02 +00:00
Robert Sparks b86bd84278 Improvements to tests after converting to factories suggested by studying coverage_changes. Commit ready to merge.
- Legacy-Id: 15248
2018-06-13 22:09:01 +00:00
Robert Sparks 340b6591b2 Use factories for ietf.doc.tests_status_change. Repair previous commit errors in ietf.doc.tests_material. Commit ready for merge.
- Legacy-Id: 15238
2018-06-09 22:16:26 +00:00
Robert Sparks a2fa0d6400 Use factories for ietf.doc.tests_material and ietf.doc.tests_review. Commit ready for merge.
- Legacy-Id: 15237
2018-06-09 21:20:37 +00:00
Robert Sparks 3eeece797a Use factories for ietf.doc.tests_downref. Commit ready for merge.
- Legacy-Id: 15228
2018-06-08 14:42:45 +00:00
Robert Sparks 67df7bd8cf Use factories for ietf.doc.tests_conflict_review. Commit ready for merge.
- Legacy-Id: 15227
2018-06-08 00:13:00 +00:00
Robert Sparks 880dafdb24 Use factories for ietf.doc.tests_charter. Commit ready for merge.
- Legacy-Id: 15226
2018-06-07 23:50:27 +00:00
Robert Sparks 6f011a3e56 Use factories for ietf.doc.tests_draft. Commit ready for merge.
- Legacy-Id: 15225
2018-06-07 22:03:09 +00:00
Robert Sparks dcf9e6b40f Use factories for ietf.doc.tests_ballots. Fixed a long-hidden bug in test_edit_verify_permissions where non-existing usernames were used and passed the tests accidently. Added list_email to the GroupFactory. Commit ready for merge.
- Legacy-Id: 15219
2018-06-06 17:59:40 +00:00
Robert Sparks a064e28926 Factoryalized the rest of ietf.doc.tests. Created draft type specific factories. Commit ready for merge.
- Legacy-Id: 15217
2018-06-05 21:17:28 +00:00
Robert Sparks 984806de2d Trivial commit removing some recently commented out code. Commit ready for merge.
- Legacy-Id: 15209
2018-06-04 15:16:47 +00:00
Robert Sparks 84d3c92298 more factoryization of ietf.doc.tests. Commit ready for merge.
- Legacy-Id: 15205
2018-06-02 13:39:39 +00:00
Robert Sparks 4e7743c009 More factorization of ietf.doc.tests. Commit ready for merge.
- Legacy-Id: 15204
2018-06-01 21:39:22 +00:00
Robert Sparks 4a4a152c9a Use factories for the rest of the tests in ietf.doc.tests.SearchTests. Commit ready for merge.
- Legacy-Id: 15203
2018-06-01 18:54:26 +00:00
Robert Sparks 0a1d9ecd2a Converted test_search_for_name to use factories. Commit ready for merge.
- Legacy-Id: 15202
2018-06-01 15:52:57 +00:00
Robert Sparks 54afc41f8e Converted test_search to use factories. Commit ready for merge.
- Legacy-Id: 15201
2018-06-01 15:16:32 +00:00
Henrik Levkowetz 4db4dd16b0 Merged in ^/personal/henrik/6.79.1-gdpr@15180 containing GDPR-adaptations.
- Legacy-Id: 15181
2018-05-28 11:26:24 +00:00
Henrik Levkowetz 81e78c70a0 Added guards against asking for properties on None in a couple of places.
- Legacy-Id: 15173
2018-05-26 08:34:27 +00:00
Henrik Levkowetz 2522082979 Changed the email origin field during test to hold user.username in order to exercise more of the code. Changed the EmailFactory to also use user.username as origin.
- Legacy-Id: 15172
2018-05-26 08:32:20 +00:00
Robert Sparks 6b779e9d4c Send email when the responsible AD for a conflict review is changed. Include the stream manager and stream steering group when the responsible AD changes or when the telechat date changes. Fixes #2497. Commit ready for merge.
- Legacy-Id: 15152
2018-05-21 22:02:34 +00:00
Henrik Levkowetz 6c3ec5b18e Added Email origin to Email record creation throughout the codebase.
- Legacy-Id: 15149
2018-05-17 16:56:26 +00:00
Henrik Levkowetz a66639299d Removed all references to the removed Person.affiliation field.
- Legacy-Id: 15129
2018-05-05 12:47:55 +00:00
Henrik Levkowetz 5f37a71889 Added origin information to all places where we create email address entries.
- Legacy-Id: 15127
2018-05-05 12:40:30 +00:00
Robert Sparks 1c16926ee6 Missed adding the migrations. Related to #1963. Commit ready for merge.
- Legacy-Id: 15120
2018-05-03 21:23:07 +00:00
Robert Sparks 1295f1f1d2 Change stream state to replaced when an ISE, IAB, or IRTF document is replaced. Fixes #1963. Commit ready for merge.
- Legacy-Id: 15119
2018-05-03 21:21:38 +00:00
Robert Sparks 8436078af6 Made settings.URL_REGEXPS.name non-greedy. Added a test to exercise the bug at #2429. Fixes #2429. Commit ready for merge.
- Legacy-Id: 15110
2018-05-03 15:39:00 +00:00
Henrik Levkowetz d076a1728c Added a 'recent drafts' page, showing drafs submitted the last 7 days.
- Legacy-Id: 15099
2018-05-01 17:55:22 +00:00
Henrik Levkowetz 53c4ac36db Removed the Person.address field, which is not being used. This was a legacy from the 2001 perl-based datatracker tables. Fixes issue #2504.
- Legacy-Id: 15095
2018-04-27 14:00:33 +00:00
Henrik Levkowetz 198c003b6a Merged in [15084] from rjsparks@nostrum.com:
Corrected the implementation of clear_ballot. Added a test for it. Restored functionality to ballot popups that was missing because a template variable was not passed in.
 - Legacy-Id: 15092
Note: SVN reference [15084] has been migrated to Git commit ee346edaba
2018-04-26 13:41:22 +00:00
Henrik Levkowetz d994a58474 Merged in [15083] from rjsparks@nostrum.com:
Removed memoize from latest_event.
 - Legacy-Id: 15091
Note: SVN reference [15083] has been migrated to Git commit 1735f86db0
2018-04-26 12:51:45 +00:00
Henrik Levkowetz c02f8fe331 Merged in [15080] from rjsparks@nostrum.com:
Marked a couple of functions as unreachable.
 - Legacy-Id: 15089
Note: SVN reference [15080] has been migrated to Git commit 7df28d8bac
2018-04-26 12:08:07 +00:00
Henrik Levkowetz c7350be50f Reverted a change to UserFactory to avoid nepalese names. The issue is bigger, and needs a different resulution. Changed the url pattern that used \w to match names to instead use a more inclusive regex.
- Legacy-Id: 15088
2018-04-26 11:53:51 +00:00
Robert Sparks ee346edaba Corrected the implementation of clear_ballot. Added a test for it. Restored functionality to ballot popups that was missing because a template variable was not passed in. Commit ready for merge.
- Legacy-Id: 15084
2018-04-25 19:52:44 +00:00
Robert Sparks 1735f86db0 Removed memoize from latest_event. Commit ready for merge.
- Legacy-Id: 15083
2018-04-25 18:15:23 +00:00
Henrik Levkowetz 8e43e7aed0 Merged in [15075] from rjsparks@nostrum.com:
Improved testing for docs_for_ad.
 - Legacy-Id: 15082
Note: SVN reference [15075] has been migrated to Git commit b7375412ab
2018-04-25 17:21:33 +00:00
Robert Sparks 7df28d8bac Marked a couple of functions as unreachable. Commit ready for merge.
- Legacy-Id: 15080
2018-04-25 15:10:55 +00:00
Henrik Levkowetz e1eb39b478 Merged in [15074] from rjsparks@nostrum.com:
Simplified docs_in_iesg_process. Added a test for it.
 - Legacy-Id: 15079
Note: SVN reference [15074] has been migrated to Git commit 57f548ecbd
2018-04-25 13:17:59 +00:00
Henrik Levkowetz 227cb0db4d Merged in [15073] from rjsparks@nostrum.com:
Rearranged ietf/doc/urls.py to allow matching some special pages under /doc without a trailing slash. Adjusted several of those special URLs to work without the trailing slash.
 - Legacy-Id: 15078
Note: SVN reference [15073] has been migrated to Git commit da25919f08
2018-04-24 21:27:04 +00:00
Robert Sparks b7375412ab Improved testing for docs_for_ad.
- Legacy-Id: 15075
2018-04-24 19:22:09 +00:00
Robert Sparks 57f548ecbd Simplified docs_in_iesg_process. Added a test for it.
- Legacy-Id: 15074
2018-04-24 18:27:19 +00:00
Robert Sparks da25919f08 Rearranged ietf/doc/urls.py to allow matching some special pages under /doc without a trailing slash. Adjusted several of those special URLs to work without the trailing slash.
- Legacy-Id: 15073
2018-04-24 18:00:59 +00:00
Henrik Levkowetz 28f4c52c20 Added permission for a document shepherd to request publication. Fixes issue #2509.
- Legacy-Id: 15071
2018-04-23 20:41:04 +00:00
Henrik Levkowetz c124a018e8 Fixed a typo. Fixes issue #2500.
- Legacy-Id: 15061
2018-04-20 13:06:21 +00:00
Henrik Levkowetz 12d999a384 Modified the IESG position setting API to send email messages about positions set.
- Legacy-Id: 15050
2018-04-17 11:57:16 +00:00
Henrik Levkowetz 2ed9face25 Modified the IESG position setting API to send email messages about positions set.
- Legacy-Id: 15049
2018-04-17 11:38:40 +00:00
Henrik Levkowetz 1591b3ebd2 Fixed an issue where simplified sorting of DocEvents resulted in some ballot icons not being shown on the IESG agenda documents page.
- Legacy-Id: 15046
2018-04-16 10:38:08 +00:00
Henrik Levkowetz a9fbea113b Changed incorrect use of 404 status code in api to 400. Fixes issue #2498.
- Legacy-Id: 15044
2018-04-13 11:11:48 +00:00
Henrik Levkowetz b5d62973c7 Tweaked the error return from Document.get_document_content() to be more helpful during development.
- Legacy-Id: 15034
2018-04-09 14:01:37 +00:00
Henrik Levkowetz ea7728b501 Changed calls to .related_that*() and .relations_that*() to use tuples rather than lists (a slight optimization).
- Legacy-Id: 15029
2018-04-07 10:47:16 +00:00
Henrik Levkowetz bac162d0d0 Reduced the max number of results returned by document searches from 500 to 200, for a better user experience. A faster return and a search term tweak to pinpoint the desired search result is better than a long wait and then maybe having to tweak the search terms anyway.
- Legacy-Id: 15027
2018-04-07 10:12:13 +00:00
Henrik Levkowetz 96e4059e43 Undid some memoization; these values can change during an object's lifetime.
- Legacy-Id: 15025
2018-04-07 10:07:57 +00:00
Henrik Levkowetz 5446ae642a Changed the signature of some document methods to not accept lists (but still accept tuples) in order to make caching possible. Added @memoize to some methods.
- Legacy-Id: 15024
2018-04-06 21:25:56 +00:00
Henrik Levkowetz d44c2dc92c Added another prefetch to search doc query results.
- Legacy-Id: 15023
2018-04-06 21:24:07 +00:00
Henrik Levkowetz 6b27daa58a Imposed sort order (most recent docs first) on document search results, in order to retain the most recent docs in case we have to chop the result list due too many hits.
- Legacy-Id: 15022
2018-04-06 21:23:14 +00:00
Henrik Levkowetz 248c2dd055 Added back the on-agenda calendar links to document lists, now in an implementation with better performance characteristics.
- Legacy-Id: 15020
2018-04-06 15:17:18 +00:00
Henrik Levkowetz 583d8882c5 Fixed an issue where the change of slide naming between IETF 96 and 97 caused the datatracker to not provide correct link to pre-IETF-97 materials. Thanks to tjw.ietf@gmail.com for the heads-up.
- Legacy-Id: 15017
2018-04-05 20:34:56 +00:00
Henrik Levkowetz 6a32a363cc Merged in [15012] from ford@isoc.org:
Add IRTF State option to Additional Search Criteria pulldown.
 - Legacy-Id: 15016
Note: SVN reference [15012] has been migrated to Git commit cd912600e6
2018-04-05 14:50:40 +00:00
Mat Ford cd912600e6 Add IRTF State option to Additional Search Criteria pulldown. Commit ready for merge.
- Legacy-Id: 15012
2018-04-05 11:56:37 +00:00
Henrik Levkowetz 421621eb51 Another round of iesg page optimizations. Reduced additional instances of individual lookups to a single lookup followed by annotation of document objects. Reduced several instances of repeating the same work multiple times (queries for telechat documents, queries for telechat dates).
- Legacy-Id: 15010
2018-04-05 11:03:26 +00:00
Henrik Levkowetz 67a17bb227 Fixed a number of tests to deal correctly with model method caching.
- Legacy-Id: 15009
2018-04-05 10:55:27 +00:00
Henrik Levkowetz 15d45b4d22 Changed the ballot_icon template tag to use an already found ballot if available, rather than doing lookups to find it (twice!).
- Legacy-Id: 15007
2018-04-04 17:12:08 +00:00
Henrik Levkowetz 1ec98fdd59 Added @memoize to two Document methods
- Legacy-Id: 15006
2018-04-04 17:10:06 +00:00
Henrik Levkowetz 43a9291053 Added an index for (doc, type) on DocEvent to speed up latest_event() queries.
- Legacy-Id: 14990
2018-04-01 19:33:16 +00:00
Henrik Levkowetz 675c652052 Additional changes to speed up the IESG agenda docs page: Changed telechat_page_count() to accept a list of documents if that's already been generated, to avoid double work. Changed the reviewed_by_teams list to provide acronyms directly, to avoid group lookups during template rendering. Provided page counts directly to the template instead of repeated (costly) filtering through telechat_page_count, with new document lookups. Removed the telechat_page_count template filter, due to its cost. Tweaked some lookups in fill_in_document_table_attributes() . Added to the select_related() list for documents in IESG agenda_documents().
- Legacy-Id: 14988
2018-04-01 18:51:48 +00:00
Henrik Levkowetz 60a60de94b Replaced inline database lookups with get_active_ads().
- Legacy-Id: 14987
2018-04-01 18:38:50 +00:00
Henrik Levkowetz db3a4eb20e Changed some instances of .slug to _id
- Legacy-Id: 14985
2018-04-01 18:32:27 +00:00
Henrik Levkowetz 4c297ba4c0 Changed settings so that cache keys used by memcached includes the release version, in order to avoid stale and incorrect cache content on new release deployment. Made it easier to pick out cache key composition by normalizing the variable name. Adjusted cache prefix and the composition of some keys to have a unique and consistent cache key prefix.
- Legacy-Id: 14943
2018-03-26 21:26:20 +00:00
Henrik Levkowetz c0eb9e3aa6 Merged in [14899] from rjsparks@nostrum.com:
Cleaner charter factory simplifies test code.
 - Legacy-Id: 14914
Note: SVN reference [14899] has been migrated to Git commit 8026f86cd3
2018-03-24 21:24:03 +00:00
Henrik Levkowetz cc717946f5 Merged in [14896] from rjsparks@nostrum.com:
Improved test coverage for ietf/doc/views_charter.py.
 - Legacy-Id: 14912
Note: SVN reference [14896] has been migrated to Git commit f11907b6a0
2018-03-24 17:54:14 +00:00
Henrik Levkowetz 6d5f604d5b Tweaked the document list iCalendar links to not show for presentations on days in the past.
- Legacy-Id: 14908
2018-03-24 15:29:10 +00:00
Henrik Levkowetz f48669a8e4 Merged in [14884] from adam@nostrum.com:
Adding page count to last call page.
 - Legacy-Id: 14907
Note: SVN reference [14884] has been migrated to Git commit e7b984dfa7
2018-03-24 15:09:50 +00:00
Henrik Levkowetz bd205ae29b Merged in [14849] from ben@nostrum.com:
Give ADs the red Clear Ballot button
 - Legacy-Id: 14904
Note: SVN reference [14849] has been migrated to Git commit 7bf02077fd
2018-03-24 13:31:48 +00:00
Robert Sparks 8026f86cd3 Cleaner charter factory simplifies test code. Commit ready for merge.
- Legacy-Id: 14899
2018-03-22 14:01:24 +00:00
Robert Sparks f11907b6a0 Improved test coverage for ietf/doc/views_charter.py. Commit ready for merge.
- Legacy-Id: 14896
2018-03-21 21:59:45 +00:00
Adam Roach e7b984dfa7 Adding page count to last call page. Commit ready for merge.
- Legacy-Id: 14884
2018-03-21 09:12:34 +00:00
Ben Campbell cc96709957 Give ADs the red Clear Ballot button
- Legacy-Id: 14848
2018-03-17 16:35:35 +00:00
Henrik Levkowetz a04e187f0f Removed some old debug print statements.
- Legacy-Id: 14823
2018-03-14 22:11:06 +00:00
Henrik Levkowetz 1fd4a4d1a7 Added session ical links to document lists (WG docs, search results, etc.) for documents on upcoming meeting agendas. Reduced the query and rendering times of document lists some more through additional prefetch_related().
- Legacy-Id: 14799
2018-03-14 19:16:50 +00:00
Henrik Levkowetz fdba464808 Added result caching for a couple of Document methods.
- Legacy-Id: 14795
2018-03-14 19:11:18 +00:00
Henrik Levkowetz 6e9bb00f13 Changed html cleaning to differentiate between fragment cleaning and document cleaning. Added an lxml-based cleaner for document cleaning, also permitting <style> tags (but not external style sheets).
- Legacy-Id: 14775
2018-03-13 12:48:22 +00:00
Henrik Levkowetz 2c0348cc7a Found that django's urlize() does not deal well with adjacent parantheses. Replaced it with a filter based on bleach.linkify, which does better.
- Legacy-Id: 14752
2018-03-09 15:07:04 +00:00
Henrik Levkowetz 1df3c715d0 Replaced the use of (at least in Django 1.11) buggy urlize() with bleach.linkify(), to avoid some exceptions caused by malformed urlize output, exposed by the new sanitize_html(). Also removed some dead code.
- Legacy-Id: 14751
2018-03-09 12:00:15 +00:00
Robert Sparks 975522af35 Make a more appropriate review message when a BoF has an initial charter under consideration. Fixes #2458. Commit ready for merge.
- Legacy-Id: 14715
2018-02-28 20:54:56 +00:00
Henrik Levkowetz 6e1d4d45d8 Added some missing migrations
- Legacy-Id: 14697
2018-02-25 20:08:37 +00:00
Henrik Levkowetz 1389775488 Added some missing migrations.
- Legacy-Id: 14696
2018-02-25 20:06:50 +00:00
Henrik Levkowetz 1ed8e967e7 Merged in ^/personal/henrik/6.72.1-django-1.11@14676: Upgrade to Django 1.11
- Legacy-Id: 14695
2018-02-25 19:55:16 +00:00
Henrik Levkowetz dc90fa3940 Changed user.is_authenticated and .is_anonymous from method calls to attribute access.
- Legacy-Id: 14668
2018-02-22 00:03:30 +00:00
Henrik Levkowetz 6184170828 Changed import path from a deprecated path to the kosher one.
- Legacy-Id: 14667
2018-02-22 00:01:01 +00:00
Henrik Levkowetz 26bf387356 Replaced direct assignment to m2m fields with .clear() and .set()
- Legacy-Id: 14666
2018-02-21 23:58:25 +00:00
Henrik Levkowetz 36b5e2ef8e Changed name from .rel to .remote_field for remote accessors.
- Legacy-Id: 14665
2018-02-21 23:56:36 +00:00
Henrik Levkowetz a4768bb514 Removed unused imports. Added some explicit orderings to avoid pagination issues.
- Legacy-Id: 14664
2018-02-21 23:54:31 +00:00
Henrik Levkowetz 06362ec046 Got rid of old migrations and created new initial migrations.
- Legacy-Id: 14662
2018-02-21 23:46:22 +00:00
Henrik Levkowetz 5638cf3da3 Changed all usage of ForeignKey and OneToOneFiled in model.py files to the compatibility versions from ietf.utils.models.
- Legacy-Id: 14661
2018-02-20 15:36:05 +00:00
Henrik Levkowetz cdc295bab8 Merged in [14655] from housley@vigilsec.com:
Strip the HTML tags around the new values in the mail produced by email_iesg_processing_document. Also, provide the previously missing URL at the end of the message. Fixes 2455.
 - Legacy-Id: 14657
Note: SVN reference [14655] has been migrated to Git commit 6ea0881a89
2018-02-19 17:36:09 +00:00
Russ Housley 6ea0881a89 Strip the HTML tags around the new values in the mail produced by email_iesg_processing_document. Also, provide the previously missing URL at the end of the message. Fixes 2455.
- Legacy-Id: 14655
2018-02-18 20:40:49 +00:00
Henrik Levkowetz 3dd66eba65 Fixed an UnboundLocalError (only partial variable initialization) bug.
- Legacy-Id: 14620
2018-02-07 06:13:19 +00:00
Henrik Levkowetz a00532694d Merged in [14549] from rjsparks@nostrum.com:
Allow those people who can make a review request to edit the request deadline. Send mail to other directorate secretaries when one secretary makes a change to a request. Fixes #2233.
 - Legacy-Id: 14555
Note: SVN reference [14549] has been migrated to Git commit ba8b4d3a38
2018-01-23 19:24:39 +00:00
Henrik Levkowetz 535cd0bccf Expanded the fields that the 'author' entry of the document search form is applied to, from just author name, to author name, email addresses, and affiliation. Fixes issue #2415.
- Legacy-Id: 14552
2018-01-23 18:12:10 +00:00
Robert Sparks ba8b4d3a38 Allow those people who can make a review request to edit the request deadline. Send mail to other directorate secretaries when one secretary makes a change to a request. Fixes #2233. Commit ready for merge.
- Legacy-Id: 14549
2018-01-22 21:43:53 +00:00
Henrik Levkowetz 649433874f Merged in [14539] from rjsparks@nostrum.com:
Warn when putting a draft on a telechat that is so close that directorates will probably not have time to complete a review. Fixes #2381.
 - Legacy-Id: 14542
Note: SVN reference [14539] has been migrated to Git commit dfc1d2aa9a
2018-01-19 15:22:16 +00:00
Robert Sparks dfc1d2aa9a Warn when putting a draft on a telechat that is so close that directorates will probably not have time to complete a review. Fixes #2381. Commit ready for merge.
- Legacy-Id: 14539
2018-01-18 22:14:30 +00:00
Henrik Levkowetz 07fd714c88 Refined the URL patterns and handling of alternative meeting material file formats, which were broken by an earlier refactoring (v6.57.0). Fixes issue #2436.
- Legacy-Id: 14521
2018-01-14 21:09:28 +00:00
Henrik Levkowetz 97206c6eeb Added user notification about ballots closed automatically when creating a new ballot.
- Legacy-Id: 14471
2017-12-29 15:24:37 +00:00
Henrik Levkowetz 4488fd82a4 Merged in [14467] from housley@vigilsec.com:
Close any previous ballots when a charter goes to Internal Review or Extrernal Review.  Fixes #2421.
 - Legacy-Id: 14470
Note: SVN reference [14467] has been migrated to Git commit de6121c6c1
2017-12-29 13:40:10 +00:00
Russ Housley de6121c6c1 Close any previous ballots when a charter goes to Internal Review or Extrernal Review. Fixes #2421.
- Legacy-Id: 14467
2017-12-28 20:09:56 +00:00
Robert Sparks 0a9737a5d2 Include information about previous team reviews in assignement emails. Fixes #2392. Commit ready for merge.
- Legacy-Id: 14466
2017-12-26 22:13:13 +00:00
Henrik Levkowetz b12bb3ca3c Guard document replacement following methods against infinite recursion on circular relationships.
- Legacy-Id: 14457
2017-12-22 19:28:59 +00:00
Henrik Levkowetz 7d7b7de54f Fixed an ungarded object attribute access.
- Legacy-Id: 14446
2017-12-19 14:38:02 +00:00
Henrik Levkowetz e1fa3ba381 Limited the iesg ballot position API to ADs (excluding secretariat).
- Legacy-Id: 14444
2017-12-19 14:10:43 +00:00
Henrik Levkowetz 6567e707ce Merged in ^/personal/henrik/6.64.2-ballotapi@14426. This provides personal API keys and a ballot position API at /api/iesg/position. Also added an endpoint description at /api/.
- Legacy-Id: 14430
2017-12-17 23:43:44 +00:00
Henrik Levkowetz a08c8dc76f Added an API endpoint to support automation of IESG ballot position posting, at /api/iesg/position. Added tests for the API endpoint, and updated the apikey validation decorator tests. Tweaked the decorator to handle a weakness found during testing.
- Legacy-Id: 14429
2017-12-17 21:55:27 +00:00
Henrik Levkowetz b0863c8963 Modified some names.
- Legacy-Id: 14428
2017-12-16 18:43:08 +00:00
Henrik Levkowetz e7209c6e50 Added a new personal event table to keep track of personal API key logins, and a management command to send out reports about activity to users with API keys. Added a weekly cronjob script to trigger weekly reports, and a monthly script for future use. Added a @require_api_key decorator to validate API keys for API key views and log in the API key owner. Modified the API key management urls to use create and disable rather than add and delete. Updated the API key list view. Added an API placeholder view function for ballot position setting, for test purposes. Added tests for the decorator and management command.
- Legacy-Id: 14426
2017-12-16 18:37:52 +00:00
Henrik Levkowetz 1f976da5c1 Third part of document read refactoring, after [14406] and [14410]. This replaces all usage of the non-unicode-aware get_document_content() function with unicode-aware Document.text() or Document.text_or_error() methods. This was triggered by yet another report of unicode content not being shown properly, and should fix all instances of document (drafts, agendas, minutes, etc.) display in the datatracker not handling unicode characters properly.
- Legacy-Id: 14411
Note: SVN reference [14406] has been migrated to Git commit 967ece7e7d

Note: SVN reference [14410] has been migrated to Git commit 660c81c272
2017-12-11 16:23:51 +00:00
Henrik Levkowetz 660c81c272 Tweaked the file content read refactoring in [14406] to try latin-1 conversion if unicode doesn't work.
- Legacy-Id: 14410
Note: SVN reference [14406] has been migrated to Git commit 967ece7e7d
2017-12-10 17:48:09 +00:00
Henrik Levkowetz 967ece7e7d Started refactoring of reading text from document files (drafts, charters, etc.) in order to normalise on one way of doing this, and making that return unicode rather than undecoded bytes. This is the first step of two, in order to gauge the possible issues and report on discrepancies.
- Legacy-Id: 14406
2017-12-08 21:51:11 +00:00
Henrik Levkowetz 4b5e354abe Merged in [14386] from rjsparks@nostrum.com:
Add a per-year RFC feed.
 - Legacy-Id: 14391
Note: SVN reference [14386] has been migrated to Git commit 6ab819bdde
2017-12-04 15:29:15 +00:00
Robert Sparks 6ab819bdde Add a per-year RFC feed. Commit ready for merge.
- Legacy-Id: 14386
2017-12-01 17:19:51 +00:00
Henrik Levkowetz ddfddb61ca Made the ballot type representation string more expressive, showing both name and doc_type.
- Legacy-Id: 14383
2017-12-01 09:27:28 +00:00
Henrik Levkowetz abb69338e2 Added a warning message for the user if ballot creation failed due to an already open ballot. This is a bad state, and should prevented by stricter checks before changing state, but is better than the current situation until we decide exactly which checks to implement.
- Legacy-Id: 14382
2017-11-30 16:10:38 +00:00
Henrik Levkowetz 98d234cd86 Refactored the handling of BallotDocEvent in tests, only creating them as needed, in preparation for stricter checks on state transitions to avoid mismatches between state and ballot.
- Legacy-Id: 14380
2017-11-30 16:02:31 +00:00
Henrik Levkowetz 64653b1aa3 Merged in [14374] from kivinen@iki.fi:
If draft name has rfcXXXX-bis or rfcXXXXbis then add rfcXXXX to diff context menu. Fixes #460 (7 years old ticket).
 - Legacy-Id: 14375
Note: SVN reference [14374] has been migrated to Git commit 23d053ea53
2017-11-16 08:16:38 +00:00
Tero Kivinen 23d053ea53 If draft name has rfcXXXX-bis or rfcXXXXbis then add rfcXXXX to diff context menu. Fixes #460 (7 years old ticket). Commit ready for merge
- Legacy-Id: 14374
2017-11-15 11:33:02 +00:00
Henrik Levkowetz b931be0a07 Merged in [14365] from kivinen@iki.fi:
Added closed date column to closed review list. Fixes #2150.
 - Legacy-Id: 14366
Note: SVN reference [14365] has been migrated to Git commit 7b4727541a
2017-11-13 06:58:42 +00:00
Tero Kivinen 7b4727541a Added closed date column to closed review list. Fixes #2150. Commit ready for merge
- Legacy-Id: 14365
2017-11-11 11:30:00 +00:00
Henrik Levkowetz a942bffbc6 Merged in [14355] from suresh@kaloom.com:
Fixes #2109
 - Legacy-Id: 14360
Note: SVN reference [14355] has been migrated to Git commit 51fa1deef2
2017-11-11 08:18:13 +00:00
Henrik Levkowetz 8499beb010 Added a 'Recent documents' to the IESG pages.
- Legacy-Id: 14300
2017-11-04 12:36:13 +00:00
Henrik Levkowetz 8786b5c700 Tweaked the error message for review message URLs which cannot be retrieved.
- Legacy-Id: 14297
2017-11-03 19:52:34 +00:00
Henrik Levkowetz e899ed6e4d Permit ADs to do wg session materials upload.
- Legacy-Id: 14293
2017-11-03 14:38:50 +00:00
Henrik Levkowetz 0d15cb0e14 Permit document urls to be up to 512 bytes, rather than the default 200
- Legacy-Id: 14230
2017-10-30 11:07:45 +00:00
Henrik Levkowetz e79397d6ad Added cleaning of review_url from the review completion form, to make sure it's retrievable.
- Legacy-Id: 14227
2017-10-27 05:54:34 +00:00
Henrik Levkowetz 4f83548b49 Added a new field Meeting.days to capture the length of a meeting. This is necessary now that we have previous meetings officially starting Sunday, lasting to Friday, and future meetings starting Saturday, Lasting to Friday. We use Meeting.days to calculate Meeting.end_date(). Meeting.get_ietf_monday() and two cut_off() methods have also been updated to be instance methods instead of class methods, and to not assume that a meeting starts on Sunday.
- Legacy-Id: 14225
2017-10-25 13:38:15 +00:00
Henrik Levkowetz 53eb7c8ae8 Added migrations for document url model changes. Updated the name fixtures. Added ability for individual draft authors to edit document urls.
- Legacy-Id: 14172
2017-09-27 16:37:13 +00:00
Henrik Levkowetz 92d425fd9b Added 'Additional URLs' for documents, the same way we have them for groups.
This could be used to point to a document source repository, to extracted
  yang module files, document wikis, and other relevant resources.
 - Legacy-Id: 14166
2017-09-27 10:52:32 +00:00
Henrik Levkowetz cbda2679a9 Removed some unreachable code.
- Legacy-Id: 14150
2017-09-22 14:45:21 +00:00
Henrik Levkowetz da23da1e8e Tweaked Document.relations_that_doc() to accept unicode relationship strings, in order to let it be called from modules importing __future__.unicode_literals.
- Legacy-Id: 14124
2017-09-16 09:24:29 +00:00
Henrik Levkowetz 4174196af0 Fixed a problem with missing extensions for external materials URLs, introduced in earlier doc.href() normalization work.
- Legacy-Id: 14077
2017-08-24 19:18:54 +00:00
Henrik Levkowetz 2ad08d6c59 Merged in [14056] from rjsparks@nostrum.com:
Straightened out some DocHistory timestamps that did not align with the respective DocEvent timestamps. Fixes #1972.
 - Legacy-Id: 14063
Note: SVN reference [14056] has been migrated to Git commit cebcd61b08
2017-08-21 21:25:48 +00:00
Henrik Levkowetz 9312b59153 Merged in [14055] from rjsparks@nostrum.com:
Improved what initial states are offered when the IRTF chair or RG personnel manage adoption of a document. Fixes #2319.
 - Legacy-Id: 14061
Note: SVN reference [14055] has been migrated to Git commit 09a7d720a1
2017-08-21 12:45:49 +00:00
Robert Sparks cebcd61b08 Straightened out some DocHistory timestamps that did not align with the respective DocEvent timestamps. Fixes #1972. Commit ready for merge.
- Legacy-Id: 14056
2017-08-14 20:33:24 +00:00
Robert Sparks 09a7d720a1 Improved what initial states are offered when the IRTF chair or RG personnel manage adoption of a document. Fixes #2319. Commit ready for merge.
- Legacy-Id: 14055
2017-08-14 19:35:48 +00:00
Henrik Levkowetz 55003bdf87 Simplified and corrected some code which uses doc.href(), based on the recent updates to href().
- Legacy-Id: 14026
2017-08-03 18:11:46 +00:00
Henrik Levkowetz 4dad8cdf9a Added a test to check for missing admin models, and added the admin models that were currently missing.
- Legacy-Id: 14021
2017-08-01 14:00:29 +00:00
Henrik Levkowetz e54a24b931 Added a couple of missing migrations.
- Legacy-Id: 14010
2017-07-31 12:11:08 +00:00
Henrik Levkowetz b33b62824e Added a document name validator to avoid new documents with unwanted characters in the name.
- Legacy-Id: 13998
2017-07-28 22:48:30 +00:00
Henrik Levkowetz 4295396891 Make Document.href() point at the rfc when doc.is_rfc().
- Legacy-Id: 13988
2017-07-27 15:28:11 +00:00
Henrik Levkowetz 3c88cf822b Replaced some group-specific agenda and minutes urls with session-specific urls, and more consistently pointed at explicitly named meeting materilas. Related to [13964].
- Legacy-Id: 13968
Note: SVN reference [13964] has been migrated to Git commit a5d8cc85d3
2017-07-24 17:41:49 +00:00
Henrik Levkowetz 7751f54742 Make materials links on the ietf materials page visible to group delegates.
- Legacy-Id: 13939
2017-07-19 11:45:35 +00:00
Henrik Levkowetz 39dbf43da4 Merged in [13918] from kivinen@iki.fi:
Unified the review request views to use same template, so they all
show same data, in same format.
 - Legacy-Id: 13936
Note: SVN reference [13918] has been migrated to Git commit b6e036b63e
2017-07-18 12:57:56 +00:00
Henrik Levkowetz c65015c30d Merged in [13916] from alireza.mohammadi@icann.org:
Better punctuation during state change by adding \" before and after
old and new state.  Fixes issue #1545.
 - Legacy-Id: 13931
Note: SVN reference [13916] has been migrated to Git commit 07c3fe97fd
2017-07-17 14:25:29 +00:00
Henrik Levkowetz 391d5e9ec5 Added a guard for the case that slides might be removed from a session while agenda page construction is in flight.
- Legacy-Id: 13926
2017-07-17 09:22:06 +00:00
Alireza Mohammadi d715d82c24 Better punctuation during state change by adding \" before and after old and new state. Fixes issue #1545.
- Legacy-Id: 13913
2017-07-15 16:16:16 +00:00
Robert Sparks fbde311f43 Allow editing of title for agendas, minutes, and bluesheets documents. Fixes #2317. Commit ready for merge.
- Legacy-Id: 13899
2017-07-15 12:24:02 +00:00
Robert Sparks 7a11217f6f Refined the state changed email message per discussion on tools-development. Fixes #2116. Commit ready for merge.
- Legacy-Id: 13888
2017-07-15 09:36:29 +00:00
Henrik Levkowetz e7f3d7ecb1 Added the last call end date to the first line of the last call announcement event description, on request from worley@ariadne.com.
- Legacy-Id: 13845
2017-07-12 15:03:17 +00:00
Henrik Levkowetz d2395f9521 Merged in [13832] from rjsparks@nostrum.com:
Treat Area Groups similar to Working Groups and Research Groups where it makes sense to do so.
 - Legacy-Id: 13836
Note: SVN reference [13832] has been migrated to Git commit 2c92aa213d
2017-07-11 21:57:01 +00:00
Henrik Levkowetz 1ba4350a05 Corrected code for [13834], handling minutes and other non-agenda meeting urls correctly.
- Legacy-Id: 13835
Note: SVN reference [13834] has been migrated to Git commit aba3861b0b
2017-07-11 21:40:15 +00:00
Henrik Levkowetz aba3861b0b Use a datatracker internal url for session agendas and minutes, to avoid X-Frame-Options SAMEORIGIN preventing agenda display in frames.
- Legacy-Id: 13834
2017-07-11 21:01:57 +00:00
Robert Sparks 2c92aa213d Treat Area Groups similar to Working Groups and Research Groups where it makes sense to do so. Commit ready for merge.
- Legacy-Id: 13832
2017-07-11 19:12:21 +00:00
Henrik Levkowetz 2c39de61ab Replaced the local copy of the draft/rfc htmlization code with rfc2html as installed modeule.
- Legacy-Id: 13827
2017-07-11 13:52:08 +00:00
Henrik Levkowetz f8f7815060 Added a slide abstract [Edit] button on slide document pages also for empty abstracts, to provide the ability to add abstracts.
- Legacy-Id: 13825
2017-07-10 21:46:21 +00:00
Henrik Levkowetz 900174ae57 Added log.unreachable() calls to some functions believed to be unused.
- Legacy-Id: 13818
2017-07-09 15:01:21 +00:00
Henrik Levkowetz d481019803 Added reverse relationships from drafts to submissions to submission checks to the Json API, to make it easier to find the yang checks for a given document.
- Legacy-Id: 13785
2017-07-07 12:55:30 +00:00
Henrik Levkowetz 22f181cdbe Modified the text shown on Chairs' 'Manage DOcument Adoption in Group' button and corrected the logic for which text to show.
- Legacy-Id: 13725
2017-06-28 17:39:11 +00:00
Henrik Levkowetz 5e6ecfbaf5 Refined the appearance and wording of the 'Manage document's adoption' button.
- Legacy-Id: 13680
2017-06-19 18:09:33 +00:00
Henrik Levkowetz b42f1cbeb5 Replaced the use of unaccent.asciify(), which has similar functionality to unidecode.unidecode(). Changed the draft parser to work exclusively with unicode text, which both makes the removal of unaccent easier, and takes us closer to Py35 compatibility. Adjusted callers of the draft parser to send in unicode.
- Legacy-Id: 13673
2017-06-18 18:23:18 +00:00
Henrik Levkowetz a18cf20868 Removed code which has been marked as unreachable since February/March 2017 without triggering any usage indications.
- Legacy-Id: 13667
2017-06-17 17:54:40 +00:00
Henrik Levkowetz 1905d25aee Made changes to the can_adopt_draft() logic, to make it possible for a chair of multiple groups to correct the mistake if adoption was made for the wrong group.
- Legacy-Id: 13662
2017-06-17 14:28:13 +00:00
Henrik Levkowetz 4fc2c6f960 Merged in ^/personal/henrik/6.54.2-yang@13630:
Added a new yang checker, 'yanglint', to the existing Yang checker class, in
addition to the existing 'pyang' checker.

Added modal overlay displays showing the yang check results every place the
yin/yang symbol is shown (red or green) to indicate the presencee and result
of yang checks.  Added a Yang Validation: line in the document
meta-information section on the document's page in the datatracker.

Added the result of the xym extaction to the yang check results, to make
extration failures visible.

Added the version of the used xym, pyang, and yanglint commands to the check
results.

Added an action to move successfully extracted and validated modules to the
module library directories immediately on submission.

Added the xym and pyang repositories as svn:external components, rather than
listing them in requirements.txt, as there has been delays of many months
between essential features in the repositories, and an actual release.  We may
get occasional buildbot failures if broken code is pulled in from the
repository, but better that than the functionality failure of severely
outdated componets.

Added a new management command to re-run yang validation for active drafts for
which yang modules were found at submission time, in order to pick up imported
models which may have arrived in the model libraries after the draft's
submission.  Run daily from bin/daily.

Added a table to hold version information for external commands.  The yang
checker output should include the version information of the used checkers,
but seems unnecessary to run each command with its --version switch every
time we check a module...

Added a new management command to collect version information for external
commands on demand.  To be run daily from bin/daily.

Added tests to verify that xym, pyang and yanglint information is available
on the submission confirmation page, and updated the yang module contained in
the test document to validate under both pyang and yanglint.

Updated admin.py and resource.py files as needed.
 - Legacy-Id: 13634
2017-06-15 20:16:48 +00:00
Henrik Levkowetz d98054c103 Added a new yang checker, 'yanglint', to the existing Yang checker class, in
addition to the existing 'pyang' checker.

Added modal overlay displays showing the yang check results every place the
yin/yang symbol is shown (red or green) to indicate the presencee and result
of yang checks.  Added a Yang Validation: line in the document
meta-information section on the document's page in the datatracker.

Added the result of the xym extaction to the yang check results, to make
extration failures visible.

Added the version of the used xym, pyang, and yanglint commands to the check
results.

Added an action to move successfully extracted and validated modules to the
module library directories immediately on submission.

Added the xym and pyang repositories as svn:external components, rather than
listing them in requirements.txt, as there has been delays of many months
between essential features in the repositories, and an actual release.  We may
get occasional buildbot failures if broken code is pulled in from the
repository, but better that than the functionality failure of severely
outdated componets.

Added a new management command to re-run yang validation for active drafts for
which yang modules were found at submission time, in order to pick up imported
models which may have arrived in the model libraries after the draft's
submission.  Run daily from bin/daily.

Added a table to hold version information for external commands.  The yang
checker output should include the version information of the used checkers,
but seems unnecessary to run each command with its --version switch every
time we check a module...

Added a new management command to collect version information for external
commands on demand.  To be run daily from bin/daily.

Added tests to verify that xym, pyang and yanglint information is available
on the submission confirmation page, and updated the yang module contained in
the test document to validate under both pyang and yanglint.

Updated admin.py and resource.py files as needed.
 - Legacy-Id: 13630
2017-06-15 16:09:28 +00:00
Henrik Levkowetz 1178f9f3ba Removed a debug print statement.
- Legacy-Id: 13570
2017-06-09 19:37:41 +00:00
Henrik Levkowetz 317aac9e55 Fixed a place where a missing document author email address could cause a server 500. There may be additional places needing attention, now that we're not inserting dummy addresses.
- Legacy-Id: 13566
2017-06-08 14:44:54 +00:00
Henrik Levkowetz 023a32715d Merged in ^/branch/iola/author-stats-r13145 from olau@iola.com, with additional features from ^/personal/henrik/6.52.1-authorstats.
- Legacy-Id: 13550
2017-06-06 18:36:59 +00:00
Henrik Levkowetz fb93a8c293 Added dates to unreachable() calls, to make it easier to decide when to remove marked code.
- Legacy-Id: 13538
2017-06-06 07:27:07 +00:00
Henrik Levkowetz 2e20d9df66 Changed all instances of deprecated self.failUnless() unittest method to self.assertTrue().
- Legacy-Id: 13515
2017-06-04 16:24:34 +00:00
Henrik Levkowetz 08f134bf52 Improved review linebreaking tests, based on [13495] from olau@iola.dk.
- Legacy-Id: 13511
Note: SVN reference [13495] has been migrated to Git commit 1a59cf60d3
2017-06-04 15:14:56 +00:00
Henrik Levkowetz 5b2087f910 Eliminated several variations on word wrapping, keeping only what used to be wrap_text(), but renamed as ietf.utils.text.wordwrap(). This performs better than django.utils.text.wrap() when there are indented text parts. Replaced django's default wordwrap filter with one calling ietf.utils.text.wordwrap in templates. Changed to triggered wrapping in some cases, with the maybewordwrap filter, which triggers on lines longer than 100 characters. This fixes the issue with undesired wrapping of reviews.
- Legacy-Id: 13505
2017-06-02 23:13:22 +00:00
Ole Laursen 1a59cf60d3 Introduce a word-wrapping filter that checks if there are lines (containing spaces to not
count URLs) longer than 100 characters, and only wraps the text if that's the case, to 
prevent messing up pre-wrapped text. Use this filter in the review email code.

Branch ready for merge.
 - Legacy-Id: 13495
2017-06-02 13:17:30 +00:00
Henrik Levkowetz a92c2b4ad5 Updated migration numbering to avoid collisions.
- Legacy-Id: 13480
2017-05-31 21:36:08 +00:00
Henrik Levkowetz 76628be3fd Merged in ^/branch/iola/author-stats-r13145 from olau@iola.dk, and fixed some tests in code which moved after the latest merge with trunk. The test suite passes, but the migrations are _not_ ready to run, because of numbering conflicts (again due to code changes on trunk since the latest sync).
- Legacy-Id: 13479
2017-05-31 20:59:26 +00:00
Henrik Levkowetz b81be04f20 Fixed the DOI information for doc/rfc*/bibtex/ temporarily; for a better fix we need to import the DOI values in ietf/sync/rfceditor.py
- Legacy-Id: 13478
2017-05-31 16:29:07 +00:00
Henrik Levkowetz 04e76c9fc9 Added raw_id_fields on DocumentAuthorAdmin to speed up form loading, and added SessionPresentationAdmin to the meeting admin.py
- Legacy-Id: 13395
2017-05-19 14:09:49 +00:00
Henrik Levkowetz 355c5cb626 Updated doc migration 0029 to avoid duplicate actions, and to avoid database referential inconsistency due to case differences in email addresses.
- Legacy-Id: 13370
2017-05-16 15:15:30 +00:00
Henrik Levkowetz 48c275fa64 Merged in [13336] from rcross@amsl.com:
Fix issue where deferring a ballot causes 500 error in Telechat app.  Fixes #1342.
 - Legacy-Id: 13360
Note: SVN reference [13336] has been migrated to Git commit 7542e8daa3
2017-05-15 14:05:25 +00:00
Henrik Levkowetz b7fba37f52 Added a guard to prevent problems with legacy drafts without any draft state.
- Legacy-Id: 13318
2017-05-11 11:47:45 +00:00
Henrik Levkowetz 9635e5e3e4 Fixed some pyflakes issues.
- Legacy-Id: 13313
2017-05-11 09:57:58 +00:00
Henrik Levkowetz 7ed85fa96c Updated doc resources.py with EditedAuthorsDocEventResource
- Legacy-Id: 13311
2017-05-11 05:07:57 +00:00
Henrik Levkowetz 405f76f238 Updated the makeresources command to use the current AppCommand.handle_app_config() interface.
- Legacy-Id: 13306
2017-05-10 20:08:40 +00:00
Robert Sparks 8030fb3965 Created an EditedAuthorsDocEvent to capture the basis or reason for changing a documentauthor set. Mapped a large number of email addresses found from the RFC Editor database and from parsing RFCs to the right Person objects, and creating Person objects as necessary. Updated the documentauthors set for RFCs based on reconciling what the tracker already knew with the RFC Editor database and the parsing the RFCs. Manually inspected the Updates to ensure no author was inappropriately removed from the set. Commit ready for merge.
- Legacy-Id: 13289
2017-05-09 20:16:11 +00:00
Henrik Levkowetz 1e98833863 Removed debug statements.
- Legacy-Id: 13229
2017-04-18 14:12:10 +00:00
Henrik Levkowetz 3d6fed4b5b Removed the 'Document' tab introduced in 6.48.0
- Legacy-Id: 13228
2017-04-17 11:39:36 +00:00
Henrik Levkowetz 7e8aeeefee Moved the caching of htmlized documents into Document.htmlized() in order to avoid caching failed htmliztions (usually because of a missing .txt file).
- Legacy-Id: 13227
2017-04-16 13:17:18 +00:00
Henrik Levkowetz 128be4b2e8 Applied a patch from production to trunk.
- Legacy-Id: 13214
2017-04-14 12:09:46 +00:00
Henrik Levkowetz b4fd2b63a8 Merged in [13205] from housley@vigilsec.com:
Check downref registry when producing Last Call text.  Fixes #2069.
 - Legacy-Id: 13210
Note: SVN reference [13205] has been migrated to Git commit aa7ed23cda
2017-04-12 21:24:33 +00:00
Russ Housley aa7ed23cda Check downref registry when producing Last Call text. Fixes #2069.
- Legacy-Id: 13205
2017-04-12 18:27:05 +00:00
Henrik Levkowetz 902a613250 A migration to match docevent type changes from the downref work.
- Legacy-Id: 13202
2017-04-12 18:21:07 +00:00
Henrik Levkowetz d19179ba44 Merged in [13181] from housley@vigilsec.com:
This completes a good chunk of the downref registry work requested in ticket
#2069. The registry has been imported to the database and can be shown, and
entries can be added to the registry.  Addresses issue #2069.
 - Legacy-Id: 13190
Note: SVN reference [13181] has been migrated to Git commit f0125634f8
2017-04-10 22:47:01 +00:00
Russ Housley f0125634f8 Add downref registry to the datatracker at the request of the IESG. Still need to integrate with Last Call message generation
- Legacy-Id: 13181
2017-04-03 17:36:27 +00:00
Henrik Levkowetz 47463eaa94 Changed a test case to look at the area being tested, rather than the whole page, to avoid test failures due to for instance new menu entries.
- Legacy-Id: 13179
2017-03-31 18:22:08 +00:00
Ole Laursen 5b677dc6ba Merge author stats branch into new branch from trunk
- Legacy-Id: 13159
2017-03-28 14:36:40 +00:00
Henrik Levkowetz 14c748df98 Changed the creation of temporary test dirs to use names which include the test class name, in order to make it possible to run test cases in parallel. Disabled coverage testing when running in parallel (those classes cannot be pickled and distributed to the test runner threads, and also won't pass coverage data back). Tweaked the TestCase.tempdir() method.
- Legacy-Id: 13157
2017-03-27 21:41:18 +00:00
Henrik Levkowetz 487019883f Merged in [13120] from rjsparks@nostrum.com:
Be more explicit on review message subject lines. Fixes #2103.
 - Legacy-Id: 13153
Note: SVN reference [13120] has been migrated to Git commit da5a2363d6
2017-03-27 18:12:22 +00:00
Henrik Levkowetz 6ae137944d Merged in [13115] from mahoney@nostrum.com:
Added draftname to email subject for review request (addresses #2144).
 - Legacy-Id: 13151
Note: SVN reference [13115] has been migrated to Git commit b0cbf9a1c9
2017-03-27 17:09:48 +00:00
Henrik Levkowetz d2c2d80341 Merged in [13112] from lars@netapp.com:
Fix various \'RemovedInDjango20Warning\' warnings.
 - Legacy-Id: 13141
Note: SVN reference [13112] has been migrated to Git commit 8a70e9773d
2017-03-26 22:06:47 +00:00
Henrik Levkowetz 6aee4d4a16 Merged in [13109] from lars@netapp.com:
Rename crawl_history to make_rev_history, which is more descriptive. Fix #2224
(thanks, Robert!) by generating graphs for the entire revision history of a doc,
both forward and backward in time.
 - Legacy-Id: 13140
Note: SVN reference [13109] has been migrated to Git commit e14dcdac8f
2017-03-26 21:42:10 +00:00
Henrik Levkowetz 5afa53a09d Merged in [13108] from lars@netapp.com:
Change \'ID Tracker\' to \'Datatracker\' in various places. Fixes some of #2100.
 - Legacy-Id: 13136
Note: SVN reference [13108] has been migrated to Git commit afdf154e0a
2017-03-25 23:46:18 +00:00
Robert Sparks da5a2363d6 Be more explicit on review message subject lines. Fixes #2103. Commit ready for merge.
- Legacy-Id: 13120
2017-03-25 20:45:08 +00:00
Jean Mahoney b0cbf9a1c9 Added draftname to email subject for review request (addresses #2144). Commit ready for merge.
- Legacy-Id: 13115
2017-03-25 19:52:15 +00:00
Lars Eggert 8a70e9773d Fix various "RemovedInDjango20Warning" warnings. Commit ready for merge.
- Legacy-Id: 13112
2017-03-25 19:16:45 +00:00
Lars Eggert e14dcdac8f Rename crawl_history to make_rev_history, which is more descriptive. Fix #2224
(thanks, Robert!) by generating graphs for the entire revision history of a doc,
both forward and backward in time. Commit ready for merge.
 - Legacy-Id: 13109
2017-03-25 18:52:46 +00:00
Lars Eggert afdf154e0a Change "ID Tracker" to "Datatracker" in various places. Fixes some of #2100.
Commit ready for merge.
 - Legacy-Id: 13108
2017-03-25 18:23:38 +00:00
Henrik Levkowetz d3558524f2 Improved traceback for a logger.error() message.
- Legacy-Id: 13093
2017-03-24 09:03:06 +00:00
Henrik Levkowetz ebef6d06d8 Reverted some links to htmlized draft versions, on request.
- Legacy-Id: 13091
2017-03-23 10:57:19 +00:00
Henrik Levkowetz b603791cae Another fix for get_file_path().
- Legacy-Id: 13088
2017-03-23 10:39:35 +00:00
Henrik Levkowetz eef984202f Better handling of missing documents (such as rfc575)
- Legacy-Id: 13060
2017-03-22 12:07:08 +00:00
Henrik Levkowetz 570ef785d6 Improved Document.get_file_path().
- Legacy-Id: 13059
2017-03-22 12:06:28 +00:00
Henrik Levkowetz 9082b0abe5 Another tweak to the rev pattern, and exception handling when breaking apart name an rev for documents which don't use the charter rev model.
- Legacy-Id: 13057
2017-03-22 09:50:07 +00:00
Henrik Levkowetz 5203118041 Changed one more draft directory reference to use the draft archive setting.
- Legacy-Id: 13056
2017-03-22 09:48:11 +00:00
Henrik Levkowetz 475d18ea8e Changed where to look for the text version of expired drafts.
- Legacy-Id: 13052
2017-03-21 15:12:30 +00:00
Henrik Levkowetz e8043e53fb Made Document.htmlized() be a bit smarter about handling documents which have not been provided in .txt format.
- Legacy-Id: 13050
2017-03-21 14:02:43 +00:00
Henrik Levkowetz 814e1315b5 Added a new document tab for some documents, showing htmlized drafts and RFCs
using the htmlization code previously developed for tools.ietf.org.  As the
generation of the htmlized page is a bit too costly to do on the fly for
often-referenced drafts and RFCs, the part of each page which contains the
htmlized document is cached on file with a cache time of 2 weeks.

Changed all links which pointed to the htmlized version on tools to instead
point at the datatracker htmlized document.

Tweaked some URLs which didn't permit retrieval of intermediate-rev-charters.

Narrowed the pattern for document names to disallow dots in names, and
instead explicitly enumerated the few historical draftw with dots in the
name.

Added a file-system cache for the htmlized documents, and specified a
max_entries value for caches, overriding the default 300 entries.

Tweaked the code for new author email entries to provide a time if missing
in an updated entry.

Changed links in various email templates which pointed at tools.ietf.org
pages to instead point at datatracker pages, where appropriate.

Changed the search result rows to provide links to both the current meta-
information document pages (with a (i) info symbol) and to the new htmlized
document pages.
 - Legacy-Id: 13040
2017-03-20 14:08:52 +00:00
Henrik Levkowetz a67e9dd5c4 Added a number of new methods on DocumentInfo/Document/DocHistory, to support the new htmlized document page. Added caching for some methods.
- Legacy-Id: 13039
2017-03-20 13:51:46 +00:00
Henrik Levkowetz d6d6fd65db Applied a patch rjsparks@nostrum.com to make ballot grids show for statchg documents in ietf last call.
- Legacy-Id: 13015
2017-03-15 14:57:20 +00:00
Henrik Levkowetz fe8cd06a76 Back out the htmlization code for the moment.
- Legacy-Id: 12997
2017-03-12 12:12:44 +00:00
Henrik Levkowetz 2ba55b1b5b Added text() and htmlized() methods on Document, to help with display of htmlized text.
- Legacy-Id: 12992
2017-03-11 13:44:03 +00:00
Henrik Levkowetz 8eb447e77f Added an improved guard against trying to fetch milestones for a group value of None.
- Legacy-Id: 12989
2017-03-08 15:19:08 +00:00
Henrik Levkowetz 707b006d17 Added a guard against trying to fetch milestones for a group value of None.
- Legacy-Id: 12988
2017-03-08 15:14:58 +00:00
Henrik Levkowetz de2356d693 Added a migration for the tweaked DocEvent.rev field.
- Legacy-Id: 12979
2017-03-07 09:48:22 +00:00
Henrik Levkowetz 4daf66d11c Added DocEvent rev= parameter througout the code.
- Legacy-Id: 12978
2017-03-06 15:08:21 +00:00
Henrik Levkowetz 05d57f6577 Added a 'rev' field to DocEvent, and removed the corresponding field from NewRevisionDocEvent and SubmissionDocEvent. Added a migration for an initial schema change, one data migration to copy and infer revision information, another schema migration to remove extraneous revision field, and another data migration to fix up bad timestamps and bad revision info from the period 2016-09-10 to 2016-10-04.
- Legacy-Id: 12974
2017-03-05 19:59:27 +00:00
Henrik Levkowetz dd305e0d87 Fixed a bug in the StateAdmin list_filter setting.
- Legacy-Id: 12972
2017-03-04 16:19:29 +00:00
Henrik Levkowetz 0bebccd1cb Added a data migration which adds 2 new WG states: 'Waiting for Implementation' and 'Held by WG'.
- Legacy-Id: 12969
2017-03-04 13:46:17 +00:00
Henrik Levkowetz 9bbd50119f Added a filter bar for state-type to the admin page for doc.models.State.
- Legacy-Id: 12968
2017-03-04 13:45:08 +00:00
Henrik Levkowetz 387068f67d Updated unreachable markings.
- Legacy-Id: 12967
2017-03-04 05:38:23 +00:00
Henrik Levkowetz c006c44423 Added setting of document author for review document objects.
- Legacy-Id: 12957
2017-03-03 19:40:09 +00:00
Henrik Levkowetz 541085b1a8 Changed email notifications for reviews done to save the message as a Message instance before sending it. Added test code to check that a Message instance is created and matches what goes out.
- Legacy-Id: 12955
2017-03-03 15:45:29 +00:00
Henrik Levkowetz ea70381f29 Merged in [12950] from rcross@amsl.com:
Fixes #2219.  Area Group chairs are denied material management access.
 - Legacy-Id: 12951
Note: SVN reference [12950] has been migrated to Git commit c6d1a59aa4
2017-03-02 21:21:07 +00:00
Henrik Levkowetz 225c1d9afe Changed the state choices in the document adoption form to exclude the few that should not be available, rather than explicitly list all others. Makes adding WG/RG states simpler.
- Legacy-Id: 12949
2017-03-02 20:07:50 +00:00
Henrik Levkowetz 695bf37bc6 Merged in [12930] from rjsparks@nostrum.com:
Use the Role email associated with a reviewer as the From when emailing a review. Fixes #2201.
 - Legacy-Id: 12936
Note: SVN reference [12930] has been migrated to Git commit 8577a5e84a
2017-02-28 21:50:12 +00:00
Henrik Levkowetz 6af4ce62aa Removed debugging code.
- Legacy-Id: 12934
2017-02-28 20:42:19 +00:00
Henrik Levkowetz 5bb5ca727b Created a special function log.unreachable() to mark code unreachable, and changed a function name from log.affirm() to log.assertion().
- Legacy-Id: 12933
2017-02-28 20:16:52 +00:00
Robert Sparks 8577a5e84a Use the Role email associated with a reviewer as the From when emailing a review. Fixes #2201. Commit ready for merge.
- Legacy-Id: 12930
2017-02-28 18:40:09 +00:00
Henrik Levkowetz 5f053ad21a Cleaned up the remaining explicit url names, using dotted-paths to view
functions instead.  In all almost 700 changes.
 - Legacy-Id: 12923
2017-02-26 23:21:49 +00:00
Henrik Levkowetz c58c51f919 Added a migration which captures the added validator for title fields.
- Legacy-Id: 12907
2017-02-24 10:24:34 +00:00
Henrik Levkowetz 27351c4349 Fixed url lookups for doc.views_doc.document_main() to only use dotted-path, and removed the doc_view explicit url name. Fixes a 500 error in /submit/status/NNNN/.
- Legacy-Id: 12897
2017-02-22 11:40:55 +00:00
Henrik Levkowetz 988a2b808f Added explicit charset setting and consistent encoding to several email paths through the datatracker. After introducing support for non-ascii names in email addresses, using role.formatted_email() to insert names into email content doesn't work any more, since uncode names will now be rfc2047-encoded in formatted_email(). Added another method role.name_and_email() for this case. Replaced another case of '%s <%s>' name-and-email formatting with formataddr(). Fixed some tests which did not send unicode email bodies to the email functions. Fixes issue #2017.
- Legacy-Id: 12896
2017-02-21 19:17:10 +00:00
Henrik Levkowetz c889856dfa Added a validator to Document.title to prevent control chars in the title (complementing a recent cleanup of more than 120 instances of document titles containing vertical tabs)
- Legacy-Id: 12893
2017-02-20 20:47:37 +00:00
Henrik Levkowetz 8930d29a8e Merged in Django-1.10 upgrade work from ^/personal/henrik/6.43.1-django-1.10
- Legacy-Id: 12881
2017-02-19 18:18:00 +00:00
Ole Laursen 4d8dd3ee4f Format rfc123 -> RFC 123 on references pages
- Legacy-Id: 12867
2017-02-17 17:17:53 +00:00
Henrik Levkowetz b8815b00c5 Don't use person.plain_name() when constructing email addresses, as it can contain unicode characters which the current email pipeline can't handle correctly. Use person.plain_ascii() instead (or person.formatted_email()).
- Legacy-Id: 12865
2017-02-16 22:59:53 +00:00
Henrik Levkowetz 74af0f5658 Replaced another bunch of explicit url names with dotted-path to the view function.
- Legacy-Id: 12849
2017-02-15 22:11:20 +00:00
Ole Laursen b2ff10b0f2 Add support for extracting the country line from the author addresses
to the draft parser (incorporating patch from trunk), store the
extracted country instead of trying to turn it into an ISO country
code, add country and continent name models and add initial data for
those, add helper function for cleaning the countries, add author
country and continent charts, move the affiliation models to
stats/models.py, fix a bunch of bugs.
 - Legacy-Id: 12846
2017-02-15 18:43:57 +00:00
Henrik Levkowetz 29567adf34 Merged in [12835] from rcross@amsl.com:
Fixes #2202.  Interim sessions appear unordered.  Switch templates to use ordered assignments() related object manager.  Also removed now unused template filters.
 - Legacy-Id: 12839
Note: SVN reference [12835] has been migrated to Git commit 8607be0e21
2017-02-14 16:22:54 +00:00
Ryan Cross 8607be0e21 Fixes #2202. Interim sessions appear unordered. Switch templates to use ordered assignments() related object manager. Also removed now unused template filters. Commit ready for merge.
- Legacy-Id: 12835
2017-02-13 22:30:21 +00:00
Henrik Levkowetz aa5e61d958 Updated all urlpatterns to use ietf.utils.urls.url() instead of django's,
in order to autogenerate dotted path url pattern names.  Updated a number
of url reverses to use dotted path, and removed explicit url pattern names
as needed.

Changed some imports to prevent import of ietf.urls before django
initialization was complete.


Changed 3 cases of form classes being curried to functions; django 1.10
didn't accept that.

Started converting old-style middleware classes to new-style middleware
functions (incomplete).

Tweaked a nomcom decorator to preserve function names and attributes, like
a good decorator should.

Replaced the removed django templatetag 'removetags' with our own version
which uses bleach, and does sanitizing in addition to removing explicitly
mentionied html tags.

Rewrote the filename argument handling in a management command which had
broken with the upgrade.
 - Legacy-Id: 12818
2017-02-11 14:43:01 +00:00
Henrik Levkowetz 19d585255a Django 1.10 does not permit the view argument to url() to be a string any more. Changed all cases view arguments to url() which were strings to instead reference the actual imported function.
- Legacy-Id: 12815
2017-02-10 14:49:16 +00:00
Henrik Levkowetz 088e2ca7f4 Removed dead code which used to work around a now fixed bug (and also used a now removed django function)
- Legacy-Id: 12813
2017-02-10 14:43:37 +00:00
Henrik Levkowetz ffb029300f Added a guard to prevent trying to get a document path for a meeting document when the document is not associated with a meeting session.
- Legacy-Id: 12790
2017-02-08 17:00:12 +00:00
Henrik Levkowetz 8a8283f537 Fixed a pyflakes issue.
- Legacy-Id: 12788
2017-02-07 17:50:06 +00:00
Ole Laursen ef251c6bc7 Add author affiliation chart.
Also add a model for registering an alias for an affiliation so that
we can group affiliations that are considered the same for statistical
purposes, and a model for registering unimportant endings like Inc.
and GmbH.

Affiliation grouping is done through three means: stripping
uninteresting endings, merging entries that only differ in case and
aliases that map from case-insensitive alias to name.

Stripping endings and merging based on case seem to reduce the number
of needed manually maintained aliases greatly.
 - Legacy-Id: 12785
2017-02-03 18:49:43 +00:00
Henrik Levkowetz 0948c4a0f3 Applying format_html() in simple_tag-registered tags as per the suggestions for Django-1.9 upgrade wasn't straightforward. Reverting to earlier code for ballot-icond link.
- Legacy-Id: 12782
2017-02-02 14:24:36 +00:00
Henrik Levkowetz e94129641d @register.simple_tag now (in Django 1.9) needs explicit mark_safe() (or format_html() which invokes mark_safe()). Fixed one case which needed this.
- Legacy-Id: 12779
2017-02-01 20:46:51 +00:00
Henrik Levkowetz de3976bec0 Merged in Django 1.9 upgrade work from ^/personal/henrik/6.41.1-django-1.9
- Legacy-Id: 12764
2017-01-31 15:13:01 +00:00
Henrik Levkowetz 40e8380751 Merged django 1.9 work forward to copy of trunk @6.41.0
- Legacy-Id: 12756
2017-01-30 23:13:02 +00:00
Ole Laursen 698965e3d1 Fix one last fake email addresses that managed to escape the migration
- Legacy-Id: 12743
2017-01-27 12:33:05 +00:00
Henrik Levkowetz ccfbde8d33 Fixed an issue with building links from URLs which are already part of a link. Fixes issue #2175.
- Legacy-Id: 12742
2017-01-26 20:11:46 +00:00
Henrik Levkowetz 0481d97650 Fixed a place where missing queryargument data could cause a 500 error.
- Legacy-Id: 12741
2017-01-26 19:24:34 +00:00
Ole Laursen 9308948195 Add person, affiliation and country (through django-countries) to
DocumentAuthor, rename author field to email and make it optional (for
modeling old email-less submissions), remove the authors many to many
referencing field from Document as it is not really pointing the right
place.

Update the Secretariat tools to show affiliation and country.

Add migration for getting rid of the fake email addresses that the
migration script created some years ago (just set the author email
field to null).
 - Legacy-Id: 12739
2017-01-26 17:10:08 +00:00
Henrik Levkowetz 2ab4caa90f Merged in [12722] from rjsparks@nostrum.com:
Added programs to the datatracker. Added use of restructuredtext for group about pages. Generalized several places where code handles different group types. Improved testing of group about.
 - Legacy-Id: 12725
Note: SVN reference [12722] has been migrated to Git commit e0ea8b0f57
2017-01-24 21:30:10 +00:00
Robert Sparks e0ea8b0f57 Added programs to the datatracker. Added use of restructuredtext for group about pages. Generalized several places where code handles different group types. Improved testing of group about. Commit ready for merge.
- Legacy-Id: 12722
2017-01-24 19:55:49 +00:00
Henrik Levkowetz e2640f358b Changed semantics for can_manage_group() to include chairs etc, and changed calls with the old semantics to use can_manage_group_type(). Rewrote can_manage_group() in terms of can_manage_group_type() and additional checks. Fixes issue #2155.
- Legacy-Id: 12719
2017-01-23 22:54:36 +00:00
Henrik Levkowetz 5a5bb1f03f Removed useless code.
- Legacy-Id: 12718
2017-01-23 21:29:36 +00:00
Henrik Levkowetz 613f0c8233 Pyflakes fixes.
- Legacy-Id: 12714
2017-01-23 18:35:58 +00:00
Henrik Levkowetz ef1b404fe3 Removed an extraneous request parameter.
- Legacy-Id: 12712
2017-01-23 18:21:15 +00:00
Henrik Levkowetz 6de7be6953 Specified strip=False for another bunch of CharField form fields with Textarea widgets.
- Legacy-Id: 12711
2017-01-23 17:38:56 +00:00
Henrik Levkowetz fa60671148 Fixed another instance of '=' being used for comparison in a template.
- Legacy-Id: 12708
2017-01-19 21:21:10 +00:00
Henrik Levkowetz 1dba613197 Merged in [12675] from rjsparks@nostrum.com:
Removed some unnecessary randomness in tests introduced in last commit.
 - Legacy-Id: 12678
Note: SVN reference [12675] has been migrated to Git commit 4f2f691de6
2017-01-19 17:24:08 +00:00
Henrik Levkowetz fd2304e446 In Django 1.9, CharField form fields will be whitespace-stripped by default. Added strip=False for the status change review form content. Also removed a superfluous f.close().
- Legacy-Id: 12677
2017-01-19 17:15:28 +00:00
Henrik Levkowetz 7c2a161a5f Removed some remaining instances of render using context_instance. Fixed a case of tuple length of list of tuples passed to a template to be the same for all tuples.
- Legacy-Id: 12676
2017-01-19 17:08:27 +00:00
Robert Sparks 4f2f691de6 Removed some unnecessary randomness in tests introduced in last commit. Commit ready for merge.
- Legacy-Id: 12675
2017-01-19 16:37:00 +00:00
Henrik Levkowetz b4480a1625 Merged in [12670] from rjsparks@nostrum.com:
Make changing skip_next on a review assignment an explicit decision of the assigner.  Fixes #2148.
 - Legacy-Id: 12671
Note: SVN reference [12670] has been migrated to Git commit 8e007ce50b
2017-01-19 15:25:22 +00:00
Robert Sparks 8e007ce50b Make changing skip_next on a review assignment an explicit decision of the assigner. Commit ready for merge. Fixes #2148.
- Legacy-Id: 12670
2017-01-19 14:23:09 +00:00
Henrik Levkowetz 79dc639f46 Merged in [12665] from rjsparks@nostrum.com:
Make it easier to see who's really next in reviewer rotation.
 - Legacy-Id: 12668
Note: SVN reference [12665] has been migrated to Git commit 49dcf67fd5
2017-01-18 16:30:29 +00:00
Henrik Levkowetz dd82df50a1 Merged in [12627] from rjsparks@nostrum.com:
Added some convenience navigation for review team secretaries to the menu. Restructured the menu lightly around Documents and Role-related links. Added navigation from a reviewers \'My Reviews\' page back to the review team pages. Fixes #2079.
 - Legacy-Id: 12667
Note: SVN reference [12627] has been migrated to Git commit 41d3bb61b4
2017-01-18 15:55:11 +00:00
Henrik Levkowetz 7a8555599f Added a link to the group datatracker page to the new group announcement (and review) emails. Fixes issue #2140.
- Legacy-Id: 12666
2017-01-17 22:22:46 +00:00
Robert Sparks 0dd2e460f3 Make it easier to see what reviews need to be closed as "No Response". Fixes #2128. Commit ready for merge.
- Legacy-Id: 12664
2017-01-17 21:04:42 +00:00
Ole Laursen 641d92cf49 Add many-to-many field with formal languages to Document and add formal
language statistics
 - Legacy-Id: 12658
2017-01-16 17:06:54 +00:00
Ole Laursen 6378594033 Add word count and submit format statistics
- Legacy-Id: 12656
2017-01-16 11:36:38 +00:00
Henrik Levkowetz 7b95411f58 The context_instance parameter to render_to_response() and render_to_string() is now deprecated. Fixed this, and generally changed the idiom render_to_response('template.html', {}, RequestContext(request)) to the newer and simpler render(request, 'template.html', {}). About 200 instances.
- Legacy-Id: 12637
2017-01-09 21:26:30 +00:00
Henrik Levkowetz a21812633d Removed unnecessary leading slash in url pattern, silencing a system check warning.
- Legacy-Id: 12632
2017-01-09 16:28:59 +00:00
Robert Sparks 41d3bb61b4 Added some convenience navigation for review team secretaries to the menu. Restructured the menu lightly around Documents and Role-related links. Added navigation from a reviewers "My Reviews" page back to the review team pages. Fixes #2079. Commit ready for merge.
- Legacy-Id: 12627
2016-12-23 21:20:55 +00:00
Henrik Levkowetz 5cc3b6448e Django 1.9: Removed additional instances of deprecated django.conf.urls.patterns()
- Legacy-Id: 12623
2016-12-22 18:14:57 +00:00
Henrik Levkowetz d5460b8f7f Django 1.9: Merged work forward to copy of latest release.
- Legacy-Id: 12621
2016-12-22 17:30:50 +00:00
Henrik Levkowetz c2541ec04b Django 1.9: Removed deprecated use of django.conf.urls.patterns() from all urls*.py files.
- Legacy-Id: 12618
2016-12-22 17:21:57 +00:00
Robert Sparks 6091d3c6a3 Tweak the docevent description for the event noting that a chartering effort has been abandoned. Fixes #2099. Commit ready for merge.
- Legacy-Id: 12606
2016-12-21 22:14:58 +00:00
Robert Sparks 6ca953ae24 Improve the team review content templates. Related to #2075. Commit ready for merge.
- Legacy-Id: 12595
2016-12-20 05:38:02 +00:00
Robert Sparks fbd2cd493d Provide templates for directly entered review contents for those teams/review-types that have them. Fixes #2075. Commit ready for merge.
- Legacy-Id: 12594
2016-12-19 23:21:11 +00:00
Robert Sparks 10f4892eae Send mail to team secretaries when a review is explicitly requested. Change the From and Subject for assignment emails to reviewers to make it clearer what the review is for and who assigned it. Fixes #2053 and #2114. Commit ready for merge.
- Legacy-Id: 12593
2016-12-19 22:32:03 +00:00
Robert Sparks 7c182375af Change how we display review text to follow the tecnique used with other large blocks of pasted or imported text (shepherds writeups for instance). Fixes #2104. Commit ready for merge.
- Legacy-Id: 12588
2016-12-19 20:38:51 +00:00
Henrik Levkowetz ff3638e365 Merged in [12549] from rjsparks@nostrum.com:
allow ads and secretaries to edit the review request comment. Fixes #2096. (Again).
 - Legacy-Id: 12550
Note: SVN reference [12549] has been migrated to Git commit 32b431cf24
2016-12-15 23:10:28 +00:00
Henrik Levkowetz 8dcc1d20a2 Merged in [12545] from rjsparks@nostrum.com:
Allow a review request to include a comment to show to the review team secretary at assignment time and the reviewer at review time. Fixes #2096.
 - Legacy-Id: 12548
Note: SVN reference [12545] has been migrated to Git commit 6fcd8b8a16
2016-12-15 22:45:25 +00:00
Henrik Levkowetz eafa070790 Merged in [12543] from rjsparks@nostrum.com:
Provide defaults on the Request review form. Fixes #2108.
 - Legacy-Id: 12547
Note: SVN reference [12543] has been migrated to Git commit 870fa59d0c
2016-12-15 22:10:12 +00:00
Henrik Levkowetz b14e981e66 Merged in [12520] from rjsparks@nostrum.com:
Slight refactor of the review models to capture review team settings. Allows configuring review teams to get automatic suggestions for reviews or not. Provides a better admin for creating/managing review teams. Fixes #2048 and #2072.
 - Legacy-Id: 12544
Note: SVN reference [12520] has been migrated to Git commit b24bdb5bc3
2016-12-15 20:55:40 +00:00
Henrik Levkowetz 51fedbf483 Merged in [12505] from rjsparks@nostrum.com:
Disallow requesting directorate reviews of RFCs (such things would better be done with reviews of status change documents). Fixes #2065.
 - Legacy-Id: 12537
Note: SVN reference [12505] has been migrated to Git commit 1ea983a1c2
2016-12-15 16:31:36 +00:00
Henrik Levkowetz 17a7f59cd6 Deprecation fixes: Use request.GET or request.POST as appropriate, instead of request.REQUEST.
- Legacy-Id: 12533
2016-12-15 13:21:33 +00:00
Henrik Levkowetz ff9b8a9bdb Deprecation fixes: Explicitly say that redirects are permanent.
- Legacy-Id: 12532
2016-12-15 13:19:51 +00:00
Henrik Levkowetz 8e56935cfd Undid commit 12527, which contained much too much.
- Legacy-Id: 12528
2016-12-15 10:38:54 +00:00
Henrik Levkowetz e3c6e0ac6b Changed the state shown in all_id.txt for drafts which have entered IESG processing, but then been replaced, to show as 'Replaced' instead of 'In IESG Processing'. This is consistent with how they are shown in all_id2.txt.
- Legacy-Id: 12527
2016-12-15 10:36:15 +00:00
Robert Sparks b24bdb5bc3 Slight refactor of the review models to capture review team settings. Allows configuring review teams to get automatic suggestions for reviews or not. Provides a better admin for creating/managing review teams. Fixes #2048 and #2072. Commit ready for merge.
- Legacy-Id: 12520
2016-12-14 23:26:32 +00:00
Henrik Levkowetz 9a3f6b059b Merged Django-1.8 upgrade work to trunk. Adjusted migration names, and added migrations as necessary. Fixed some instances of broken html.
- Legacy-Id: 12507
2016-12-13 05:55:46 +00:00
Robert Sparks 1ea983a1c2 Disallow requesting directorate reviews of RFCs (such things would better be done with reviews of status change documents). Fixes #2065. Commit ready for merge.
- Legacy-Id: 12505
2016-12-12 21:42:53 +00:00
Henrik Levkowetz 03d90163a5 Merged django-1.8 work forward to copy of 6.39.1
- Legacy-Id: 12504
2016-12-10 19:32:46 +00:00
Henrik Levkowetz 3c956c9896 Added migrations for new timezone data, validation on ReviewerSettings.filter_re, and new docevent types.
- Legacy-Id: 12493
2016-12-09 12:41:38 +00:00
Henrik Levkowetz 57eb5844e5 Merged in [12489] from rjsparks@nostrum.com:
Save a new reviewrequest for each team requested in the request form. Fixes #2094.
 - Legacy-Id: 12491
Note: SVN reference [12489] has been migrated to Git commit 4fff1ab101e4f7cd27dc8ded889e09905866076f
2016-12-09 12:01:48 +00:00
Henrik Levkowetz 8c7a400683 Merged in [12486] from rjsparks@nostrum.com:
Fill in CC list defaults for review completion mail. Make the mail come from the reviewer instead of the default secretariat address. Fixes #2078 and #2054.
 - Legacy-Id: 12488
Note: SVN reference [12486] has been migrated to Git commit 062707f51b351e1fcd5d682b23af8c7feeb2442d
2016-12-08 23:44:50 +00:00
Henrik Levkowetz e40afaedf0 Check event type only when an event is available.
- Legacy-Id: 12484
2016-12-08 17:57:59 +00:00
Henrik Levkowetz 2c27d5c611 Moved optional text wrapping before html escaping in markup_unicode(), used by get_unicode_document_content(). Fixes a problem with lines being wrapped when they should not be.
- Legacy-Id: 12480
2016-12-08 16:27:05 +00:00
Henrik Levkowetz 19ec458668 Added migrations for the model changes done for the Django 1.8 upgrade.
- Legacy-Id: 12478
2016-12-07 19:41:48 +00:00
Henrik Levkowetz 7fbf2e8609 Changed the deprecated model._meta.get_all_field_names() to a supported construct.
- Legacy-Id: 12475
2016-12-07 18:27:57 +00:00
Henrik Levkowetz e4ce339235 Merged in [12461] from rjsparks@nostrum.com:
Added migration to fetch text from reviews in the mail archives and populate the review documents. Fixes #2064.  Will patch into production.
 - Legacy-Id: 12463
Note: SVN reference [12461] has been migrated to Git commit 63a9599bafdcacf49f1bb374b2156d8473da93d1
2016-12-05 21:03:49 +00:00
Henrik Levkowetz 14776bae70 Merged django18 work forward to r12447
- Legacy-Id: 12455
2016-12-05 15:03:40 +00:00
Henrik Levkowetz 1d5a7a692a Added a DB consistency check, and 2 new doc.statetype values found by the check for consistency.
- Legacy-Id: 12451
2016-12-05 14:12:19 +00:00
Henrik Levkowetz 0bb7854591 Merged django18 work forward to 6.39
- Legacy-Id: 12449
2016-12-05 14:01:25 +00:00
Henrik Levkowetz 486e394cbf Added more document information to the personal profile pages at /person/<full name>, after a suggestion from Benoit Claise. Fixes issue #2066.
- Legacy-Id: 12447
2016-12-05 13:00:01 +00:00
Henrik Levkowetz 37f9aa06be Merged in [12438] from rjsparks@nostrum.com:
Don't show teams with only 'No response' reviews in the search result rows, using the same logic as used for the document main page. Fixes #2070.
 - Legacy-Id: 12441
Note: SVN reference [12438] has been migrated to Git commit d1c0c053327594c8a594ad2ad779fac9974d8eaa
2016-12-01 22:16:32 +00:00
Henrik Levkowetz e3ce2a9657 Tweaked the admin for doc.models.Document to capture a comment about changes made, and save those in the document history, using .save_with_history(). This makes the admin useful again for doing document changes. See issue #2067.
- Legacy-Id: 12434
2016-12-01 16:35:23 +00:00
Henrik Levkowetz c79b40bc88 Changed the handling of DocEvent 'rev' fields in document history. We should give DocEvent a 'rev' field which is always filled in; the current handling is error prone and much to complicated.
- Legacy-Id: 12433
2016-12-01 13:49:36 +00:00
Henrik Levkowetz b914f46313 Merged in ^/branch/iola/review-tracker-r12128@12397, bringing in the review tool functionality described in RFC7735. This adds the ability to set up review management pages for review teams such as genart, secdir, opsdir, etc.; letting the review team secretaries manage requested and completed reviews; letting the reviewers keep track of and document their reviews, and more. See the RFC for full specification, and the branch commit log for a full commit history.
- Legacy-Id: 12419
2016-11-29 14:54:19 +00:00
Henrik Levkowetz e6121ac0f8 Fixed a bad filter argument found by the Django 1.8 code.
- Legacy-Id: 12408
2016-11-28 21:06:42 +00:00
Henrik Levkowetz 671df0492a Fixed an issue where a queryset filter argument didn't have the right datatype.
- Legacy-Id: 12403
2016-11-28 18:05:14 +00:00
Henrik Levkowetz b00824a6bf Merged in [12385] from rjsparks@nostrum.com:
Added an extra highlight to the ballot_icon box when the viewer holds a blocking position in that ballot. Fixes #2046.
 - Legacy-Id: 12388
Note: SVN reference [12385] has been migrated to Git commit 3c63fdb800
2016-11-18 13:43:28 +00:00
Robert Sparks 3c63fdb800 Added an extra highlight to the ballot_icon box when the viewer holds a blocking position in that ballot. Fixes #2046. Commit ready for merge.
- Legacy-Id: 12385
2016-11-18 04:52:13 +00:00
Robert Sparks ab96f6c89c Fix an issue with the agenda linking to group type "other" slides. Will patch production. Commit ready for merge.
- Legacy-Id: 12338
2016-11-13 01:58:53 +00:00
Ole Laursen e171aa657e Add support for revising a closed review, mostly to allow reviewers to
correct historic entries with missing data
 - Legacy-Id: 12314
2016-11-09 16:20:58 +00:00
Ole Laursen cde7cfacd5 Modify the reviewer overview page to display up to 10 historic reviews
per person from the past year instead of only 5.

Add basic reviewer stats to the assignment select box.
 - Legacy-Id: 12279
2016-11-07 22:32:53 +00:00
Henrik Levkowetz 27abaae2e4 Tweaked and enhanced doc.admin.DocEventAdmin.
- Legacy-Id: 12276
2016-11-07 18:38:34 +00:00
Henrik Levkowetz 7f1c1e43f2 Replaced the use of plain DocEvent for submission doc events with a SubmissionDocEvent that carries rev and a FK to submission.
- Legacy-Id: 12275
2016-11-07 18:21:34 +00:00