Removed some unnecessary randomness in tests introduced in last commit.
- Legacy-Id: 12678
Note: SVN reference [12675] has been migrated to Git commit 4f2f691de6
Make changing skip_next on a review assignment an explicit decision of the assigner. Fixes#2148.
- Legacy-Id: 12671
Note: SVN reference [12670] has been migrated to Git commit 8e007ce50b
Make it easier to see who's really next in reviewer rotation.
- Legacy-Id: 12668
Note: SVN reference [12665] has been migrated to Git commit 49dcf67fd5
Added some convenience navigation for review team secretaries to the menu. Restructured the menu lightly around Documents and Role-related links. Added navigation from a reviewers \'My Reviews\' page back to the review team pages. Fixes#2079.
- Legacy-Id: 12667
Note: SVN reference [12627] has been migrated to Git commit 41d3bb61b4
allow ads and secretaries to edit the review request comment. Fixes#2096. (Again).
- Legacy-Id: 12550
Note: SVN reference [12549] has been migrated to Git commit 32b431cf24
Allow a review request to include a comment to show to the review team secretary at assignment time and the reviewer at review time. Fixes#2096.
- Legacy-Id: 12548
Note: SVN reference [12545] has been migrated to Git commit 6fcd8b8a16
Slight refactor of the review models to capture review team settings. Allows configuring review teams to get automatic suggestions for reviews or not. Provides a better admin for creating/managing review teams. Fixes#2048 and #2072.
- Legacy-Id: 12544
Note: SVN reference [12520] has been migrated to Git commit b24bdb5bc3
Disallow requesting directorate reviews of RFCs (such things would better be done with reviews of status change documents). Fixes#2065.
- Legacy-Id: 12537
Note: SVN reference [12505] has been migrated to Git commit 1ea983a1c2
Save a new reviewrequest for each team requested in the request form. Fixes#2094.
- Legacy-Id: 12491
Note: SVN reference [12489] has been migrated to Git commit 4fff1ab101e4f7cd27dc8ded889e09905866076f
Fill in CC list defaults for review completion mail. Make the mail come from the reviewer instead of the default secretariat address. Fixes#2078 and #2054.
- Legacy-Id: 12488
Note: SVN reference [12486] has been migrated to Git commit 062707f51b351e1fcd5d682b23af8c7feeb2442d
Added migration to fetch text from reviews in the mail archives and populate the review documents. Fixes#2064. Will patch into production.
- Legacy-Id: 12463
Note: SVN reference [12461] has been migrated to Git commit 63a9599bafdcacf49f1bb374b2156d8473da93d1
Don't show teams with only 'No response' reviews in the search result rows, using the same logic as used for the document main page. Fixes#2070.
- Legacy-Id: 12441
Note: SVN reference [12438] has been migrated to Git commit d1c0c053327594c8a594ad2ad779fac9974d8eaa
Added an extra highlight to the ballot_icon box when the viewer holds a blocking position in that ballot. Fixes#2046.
- Legacy-Id: 12388
Note: SVN reference [12385] has been migrated to Git commit 3c63fdb800
review test code use a separate reviewer and reviewsecretary user to
avoid confounding things - also let these use Unicode in their names
to check for Unicode trouble.
- Legacy-Id: 12175
Don't show the request publication button for ise,irtf, and iab drafts after publication has already been requested. Fixes#2019.
- Legacy-Id: 12122
Note: SVN reference [12104] has been migrated to Git commit 933134f4cc
review types so that teams will only have those review types
listed and suggested that they are configured to have.
Fix a couple of things in the importer after having tested it on all
the databases. Set unavailable end date >= 2020 to indefinite.
Fix a couple of bugs.
- Legacy-Id: 12095
requests for a given set of teams/reviewers (making it trivial to
compute statistics), revamp the related doc event code to support this
by referencing the review request directly, add a reviewer overview
page with recent performance for each reviewer as well as
settings/unavailable periods. Fix some bugs and shuffle some of the
review code a bit around.
Finish the importer from the previous Perl-based review tool,
importing log entries, figuring out whether a given review is
early/telechat/last call and fixing corner cases.
- Legacy-Id: 12080
relying on when they last reviewed. In-order assignments automatically
move the rotation forwards while out-of-order assignments increment
the skip next of the assigned reviewer. Include rotation in open
review assignments email. Fix a couple of issues in the importer.
- Legacy-Id: 12015
Set up removing the order field from Document.
Modified the meeting materials, proceedings, and session details views to use the order field on SessionPresentation.
Added bootstrapped views to upload session materials (agendas, slides, minutes, and bluesheets).
Integrated upload into the session details view.
Commit ready for merge.
- Legacy-Id: 11989
Put WG summary information on the rechartering page. Fixes#2000.
- Legacy-Id: 11881
Note: SVN reference [11859] has been migrated to Git commit b6978debb6
Enabled and refined document_main view for bluesheets.
Improved migration for 95 and 96 bluesheets, adding DocAlias and DocEvent creation.
Added bluesheet upload to the session details view.
Moved a function out of secr/proceedings/views into its own util.py file to allow reusing it in other modules without introducing circular imports.
- Legacy-Id: 11811
Note: SVN reference [11778] has been migrated to Git commit 0611444b36bc071e8db068a093cc1ad93bb69659
Annotated the document state selection list with indications of
whether the state is an IETF or IRTF state. Fixes#1968.
- Legacy-Id: 11722
Note: SVN reference [11721] has been migrated to Git commit 0925e8e242
Generate a message to Secretary and IESG when AD changes a draft state
to 'Approved'. Fixes issue #796.
- Legacy-Id: 11714
Note: SVN reference [11687] has been migrated to Git commit ae87e84610
Note: SVN reference [11710] has been migrated to Git commit 65bb1f2738
Clarify that the consensus field is talking about whether the doument will include the consensus boilerplate when it is published as an RFC. Fixes#1955.
- Legacy-Id: 11684
Note: SVN reference [11663] has been migrated to Git commit 9d5a94713e
specific close reasons to the database migration, add
ReviewRequest.requested_by so it's possible to notify the requester of
a review that it has been dropped.
- Legacy-Id: 11520
review requests page.
Add importer for importing review data from the existing Perl tool
(WIP, gets most but not all of the interesting information out).
Fix various bugs.
- Legacy-Id: 11508
enter/upload content or retrieve it from an IETF mailarch archive
through integrated searching support. Support for partial completion.
- Legacy-Id: 11360
The secretariat and the Team Chair can now edit team groups. In
addition, if the team in within the IETF, Area Directors can edit
it. And, if the team is within the IRTF, the IRTF Chair can edit it.
Cleaned up the checking permission for a user to
manage a group. Also, cleanly handle a set of group parent links did
for a loop. Fixes#1915.
- Legacy-Id: 11091
Note: SVN reference [11064] has been migrated to Git commit 1c509cd64c
Note: SVN reference [11082] has been migrated to Git commit 858530c214
Assigned default consensus for IETF stream documents, partly fixing #1403 - IRTF/IAB may want more, this just does IETF stream.
- Legacy-Id: 11089
Note: SVN reference [11083] has been migrated to Git commit 9ca4e98d46
Added in support for displaying results from selected submission checks as symbols on draft pages and in draft lists. For now, that means that drafts with yang modules will show either a green or orange yang symbol, depending on the result of the submission yang validation check.
- Legacy-Id: 10996
page. Each WG/RG now gets a list with an initial set of rules to
populate the list.
Refine the community list management interface a bit to support the
group lists better - group lists aren't connected to the usual track
icons so need to be able to add/remove individual drafts.
Change the "name contains" rule to support regular expressions to
enable each group to have a default replacement for the previously
implemented "related documents" search. Maintain a materialized view
of the regexp-matched drafts with a call in the submit code to avoid
having to scan all drafts/~1000 group rules all the time.
- Legacy-Id: 10963
From a user perspective: Use friendlier URLs for lists. Reuse the
search results table for displaying lists. Simplify the management
pages and improve the search rule UI to help fill in the values and
validating them, instead of just providing a text field. Fixes#1874.
Add an explicit button for adding individual documents. Include all
changes in the document change streams, not just some changes. Fix a
concurrency issue that allows changed documents to escape the search
rules. Don't create an empty list just be logging in.
From a code maintenance perspective: Clean up the models. Replace the
background caching scheme with direct queries. Get rid of a big chunk
of code. Speed up the code that adds track buttons to search results.
Add tests of all community views. Fixes#1422. Also fix some minor
bugs and oddities here and there.
There's still some work to do with respect to integrating the group
lists better.
- Legacy-Id: 10921
Added test for proper eneration of the approval message with and without an RFC Editor Note.
- Legacy-Id: 10901
Note: SVN reference [10839] has been migrated to Git commit b4b14112b8
Show all sessions associated with a document.
Remove the day/seq urls from the materials tree.
Allow sessionpresentation.rev to be None, meaning \'current version\'.
Streamlined workflows to focus on current versions of a draft as a default.
Allow adding and editing sessionpresentations when looking at a specific document.
Allow adding drafts when looking at a specific session.
Add the meeting tab to 'team' groups.
Refactored several utility classes and expanded on factories.
Fixes#1908 and #1910.
- Legacy-Id: 10865
Note: SVN reference [10856] has been migrated to Git commit e8d40c8402
Handle expiring the last call of status change documents. Be more robust about errors when expiring last calls. Fixes#1911.
- Legacy-Id: 10819
Note: SVN reference [10811] has been migrated to Git commit e7f90214c5
Create the approval ballot for charters when the charter enters external review (or iesg review if external review is skipped). Fixes#1792.
- Legacy-Id: 10812
Note: SVN reference [10803] has been migrated to Git commit b1f229cf9d
Added the ability to associate documents with sessions from the document main page.
Integrated the group meetings tab with the secretariat meeting request and meeting materials pages.
Made better use of bootstrap styling for the meetings tab and session details view.
- Legacy-Id: 10784
Note: SVN reference [10779] has been migrated to Git commit 776b95106f
The IESG Telechat Agenda now shows "(Has RFC Editor Note)" after the I-D
filename if there is an RFC Editor Note associated with the document. This
was added to the html and txt versions of the agenda. It was not added to the
Secretariat view or the Scribe view of the agenda.
For transition, when an AD edits the RFC Editor Note, they need to move the
text from the current writeup into the new field. Returning documents on the
telechat agenda seems to be the biggest opportunity for something to fall
between the cracks. If an event of type "changed_rfc_editor_note' exists, and
the string "RFC Editor Note" appears in the text of the most recent
'changed_ballot_writeup_text' event, then a message is shown that tells the AD
to remove the RFC Editor Note from the writeup.
- Legacy-Id: 10783
Note: SVN reference [10770] has been migrated to Git commit 4b5ac9e09e
Note: SVN reference [10771] has been migrated to Git commit 46589ee421
Note: SVN reference [10772] has been migrated to Git commit c73659e95c
Note: SVN reference [10773] has been migrated to Git commit 2e6633c016
Fix \'RemovedInDjango19Warning: The django.forms.util module has been renamed.
Use django.forms.utils instead.\'
- Legacy-Id: 10778
Note: SVN reference [10764] has been migrated to Git commit a001822cab
independent of the search form, to enable them to be reused in the
community lists.
Also clean up the related code a bit, use SearchForm to handle other
document types, and fix missing ids in the HTML so that one can click
the "by" labels to hit the corresponding radio button.
- Legacy-Id: 10729
This set of changes focuses on improvements to the nomcom portion of
the datatracker.
These changes:
- Simplify the nomcom form for comments. Make it more obvious who
receives mail when a comment is supplied. Fixes#1849.
- Simplify the nomcom form for nominations. Provide a primary workflow
where nominations choose an existing Person, and a secondary
workflow for nominating new people.
- Allow nominees to add a comment when accepting or declining a
nomination. Fixes#1845.
- Organize the list of nominees on the feedback page. Fixes#1786 and
#1809.
- Simplify the mechanisms used to display feedback message counts.
- Regroup the feedback view to make it easier to see where to spend
review effort. Fixes#1866.
- Capture when nomcom members last reviewed feedback for a given
nominee. Add badges when new feedback is avaliable. Improve the
layout of the feedback index page. Fixes#1850.
- Reorganize the tab navigation on the nomcom private pages. Made it
more obvious when the chair is doing something that only the chair
gets to see. Fixes#1788 and #1795.
- Regroup multiselect options to make classifying pending feedback
simpler. Make the control larger and resizable. Fixes#1495.
- Simplify the chair's views for editing nominee records. Replace the
merge nominee form with a request to the secretariat to merge Person
records. Fixes#1847.
- Added merging nominees to the secretariat's persson merging script.
- Show information for concluded nomcoms. Close feedback and
nomination for concluded nomcoms. Fixes#1856.
- Improve the questionnaire templates, reminding the nominee that
receiving the questionnaire does not imply they have accepted a
nomination. Fixes#1807.
- Remove the description field from Postion. Simplify the Position
list and the Position edit form. Make the nomcom pages more self
documenting. Add a page to help nomcom chiars through setting up a
new nomcom. Fixes#1867 and #1768.
- Remove the type from the template pathname for the requirements
templates. Make the requirements views work for both types plain and
rst. Changed the default type for new nomcom requirement templates
to rst.
- Remove 'incumbent' from the models. Fixes#1771.
- Adjust the models for Nominee and Nomination to better associate
Nominee objects with Person objects.
- Remove BaseNomcomForm and the implementation of custom fieldsets.
- Replace the custom message framework with the django provided
messages framework.
- Improve SearchablePersonField to show the primary email address for
any search result where a name appears more than once.
- Add the use of factory-boy for generating test data. Normalize
management of a test directory for test nomcom public keys.
Significantly improve test coverage of the nomcom related code.
- Legacy-Id: 10703
Note: SVN reference [10629] has been migrated to Git commit c8bbfbad78
for RFC1786, the authors field is empty and the date wrong. Need to check
whether this is an error in the database or in the code. But still: Commit ready
for merge.
- Legacy-Id: 10676
focused on supporting the IRTF better, but also removing some redundancies
(i.e., including group_info.txt instead of duplicating something similar.)
Commit ready for merge.
- Legacy-Id: 10674