Commit graph

1084 commits

Author SHA1 Message Date
Henrik Levkowetz 5b2087f910 Eliminated several variations on word wrapping, keeping only what used to be wrap_text(), but renamed as ietf.utils.text.wordwrap(). This performs better than django.utils.text.wrap() when there are indented text parts. Replaced django's default wordwrap filter with one calling ietf.utils.text.wordwrap in templates. Changed to triggered wrapping in some cases, with the maybewordwrap filter, which triggers on lines longer than 100 characters. This fixes the issue with undesired wrapping of reviews.
- Legacy-Id: 13505
2017-06-02 23:13:22 +00:00
Ole Laursen 1a59cf60d3 Introduce a word-wrapping filter that checks if there are lines (containing spaces to not
count URLs) longer than 100 characters, and only wraps the text if that's the case, to 
prevent messing up pre-wrapped text. Use this filter in the review email code.

Branch ready for merge.
 - Legacy-Id: 13495
2017-06-02 13:17:30 +00:00
Henrik Levkowetz a92c2b4ad5 Updated migration numbering to avoid collisions.
- Legacy-Id: 13480
2017-05-31 21:36:08 +00:00
Henrik Levkowetz 76628be3fd Merged in ^/branch/iola/author-stats-r13145 from olau@iola.dk, and fixed some tests in code which moved after the latest merge with trunk. The test suite passes, but the migrations are _not_ ready to run, because of numbering conflicts (again due to code changes on trunk since the latest sync).
- Legacy-Id: 13479
2017-05-31 20:59:26 +00:00
Henrik Levkowetz b81be04f20 Fixed the DOI information for doc/rfc*/bibtex/ temporarily; for a better fix we need to import the DOI values in ietf/sync/rfceditor.py
- Legacy-Id: 13478
2017-05-31 16:29:07 +00:00
Henrik Levkowetz 04e76c9fc9 Added raw_id_fields on DocumentAuthorAdmin to speed up form loading, and added SessionPresentationAdmin to the meeting admin.py
- Legacy-Id: 13395
2017-05-19 14:09:49 +00:00
Henrik Levkowetz 355c5cb626 Updated doc migration 0029 to avoid duplicate actions, and to avoid database referential inconsistency due to case differences in email addresses.
- Legacy-Id: 13370
2017-05-16 15:15:30 +00:00
Henrik Levkowetz 48c275fa64 Merged in [13336] from rcross@amsl.com:
Fix issue where deferring a ballot causes 500 error in Telechat app.  Fixes #1342.
 - Legacy-Id: 13360
Note: SVN reference [13336] has been migrated to Git commit 7542e8daa3
2017-05-15 14:05:25 +00:00
Henrik Levkowetz b7fba37f52 Added a guard to prevent problems with legacy drafts without any draft state.
- Legacy-Id: 13318
2017-05-11 11:47:45 +00:00
Henrik Levkowetz 9635e5e3e4 Fixed some pyflakes issues.
- Legacy-Id: 13313
2017-05-11 09:57:58 +00:00
Henrik Levkowetz 7ed85fa96c Updated doc resources.py with EditedAuthorsDocEventResource
- Legacy-Id: 13311
2017-05-11 05:07:57 +00:00
Henrik Levkowetz 405f76f238 Updated the makeresources command to use the current AppCommand.handle_app_config() interface.
- Legacy-Id: 13306
2017-05-10 20:08:40 +00:00
Robert Sparks 8030fb3965 Created an EditedAuthorsDocEvent to capture the basis or reason for changing a documentauthor set. Mapped a large number of email addresses found from the RFC Editor database and from parsing RFCs to the right Person objects, and creating Person objects as necessary. Updated the documentauthors set for RFCs based on reconciling what the tracker already knew with the RFC Editor database and the parsing the RFCs. Manually inspected the Updates to ensure no author was inappropriately removed from the set. Commit ready for merge.
- Legacy-Id: 13289
2017-05-09 20:16:11 +00:00
Henrik Levkowetz 1e98833863 Removed debug statements.
- Legacy-Id: 13229
2017-04-18 14:12:10 +00:00
Henrik Levkowetz 3d6fed4b5b Removed the 'Document' tab introduced in 6.48.0
- Legacy-Id: 13228
2017-04-17 11:39:36 +00:00
Henrik Levkowetz 7e8aeeefee Moved the caching of htmlized documents into Document.htmlized() in order to avoid caching failed htmliztions (usually because of a missing .txt file).
- Legacy-Id: 13227
2017-04-16 13:17:18 +00:00
Henrik Levkowetz 128be4b2e8 Applied a patch from production to trunk.
- Legacy-Id: 13214
2017-04-14 12:09:46 +00:00
Henrik Levkowetz b4fd2b63a8 Merged in [13205] from housley@vigilsec.com:
Check downref registry when producing Last Call text.  Fixes #2069.
 - Legacy-Id: 13210
Note: SVN reference [13205] has been migrated to Git commit aa7ed23cda
2017-04-12 21:24:33 +00:00
Russ Housley aa7ed23cda Check downref registry when producing Last Call text. Fixes #2069.
- Legacy-Id: 13205
2017-04-12 18:27:05 +00:00
Henrik Levkowetz 902a613250 A migration to match docevent type changes from the downref work.
- Legacy-Id: 13202
2017-04-12 18:21:07 +00:00
Henrik Levkowetz d19179ba44 Merged in [13181] from housley@vigilsec.com:
This completes a good chunk of the downref registry work requested in ticket
#2069. The registry has been imported to the database and can be shown, and
entries can be added to the registry.  Addresses issue #2069.
 - Legacy-Id: 13190
Note: SVN reference [13181] has been migrated to Git commit f0125634f8
2017-04-10 22:47:01 +00:00
Russ Housley f0125634f8 Add downref registry to the datatracker at the request of the IESG. Still need to integrate with Last Call message generation
- Legacy-Id: 13181
2017-04-03 17:36:27 +00:00
Henrik Levkowetz 47463eaa94 Changed a test case to look at the area being tested, rather than the whole page, to avoid test failures due to for instance new menu entries.
- Legacy-Id: 13179
2017-03-31 18:22:08 +00:00
Ole Laursen 5b677dc6ba Merge author stats branch into new branch from trunk
- Legacy-Id: 13159
2017-03-28 14:36:40 +00:00
Henrik Levkowetz 14c748df98 Changed the creation of temporary test dirs to use names which include the test class name, in order to make it possible to run test cases in parallel. Disabled coverage testing when running in parallel (those classes cannot be pickled and distributed to the test runner threads, and also won't pass coverage data back). Tweaked the TestCase.tempdir() method.
- Legacy-Id: 13157
2017-03-27 21:41:18 +00:00
Henrik Levkowetz 487019883f Merged in [13120] from rjsparks@nostrum.com:
Be more explicit on review message subject lines. Fixes #2103.
 - Legacy-Id: 13153
Note: SVN reference [13120] has been migrated to Git commit da5a2363d6
2017-03-27 18:12:22 +00:00
Henrik Levkowetz 6ae137944d Merged in [13115] from mahoney@nostrum.com:
Added draftname to email subject for review request (addresses #2144).
 - Legacy-Id: 13151
Note: SVN reference [13115] has been migrated to Git commit b0cbf9a1c9
2017-03-27 17:09:48 +00:00
Henrik Levkowetz d2c2d80341 Merged in [13112] from lars@netapp.com:
Fix various \'RemovedInDjango20Warning\' warnings.
 - Legacy-Id: 13141
Note: SVN reference [13112] has been migrated to Git commit 8a70e9773d
2017-03-26 22:06:47 +00:00
Henrik Levkowetz 6aee4d4a16 Merged in [13109] from lars@netapp.com:
Rename crawl_history to make_rev_history, which is more descriptive. Fix #2224
(thanks, Robert!) by generating graphs for the entire revision history of a doc,
both forward and backward in time.
 - Legacy-Id: 13140
Note: SVN reference [13109] has been migrated to Git commit e14dcdac8f
2017-03-26 21:42:10 +00:00
Henrik Levkowetz 5afa53a09d Merged in [13108] from lars@netapp.com:
Change \'ID Tracker\' to \'Datatracker\' in various places. Fixes some of #2100.
 - Legacy-Id: 13136
Note: SVN reference [13108] has been migrated to Git commit afdf154e0a
2017-03-25 23:46:18 +00:00
Robert Sparks da5a2363d6 Be more explicit on review message subject lines. Fixes #2103. Commit ready for merge.
- Legacy-Id: 13120
2017-03-25 20:45:08 +00:00
Jean Mahoney b0cbf9a1c9 Added draftname to email subject for review request (addresses #2144). Commit ready for merge.
- Legacy-Id: 13115
2017-03-25 19:52:15 +00:00
Lars Eggert 8a70e9773d Fix various "RemovedInDjango20Warning" warnings. Commit ready for merge.
- Legacy-Id: 13112
2017-03-25 19:16:45 +00:00
Lars Eggert e14dcdac8f Rename crawl_history to make_rev_history, which is more descriptive. Fix #2224
(thanks, Robert!) by generating graphs for the entire revision history of a doc,
both forward and backward in time. Commit ready for merge.
 - Legacy-Id: 13109
2017-03-25 18:52:46 +00:00
Lars Eggert afdf154e0a Change "ID Tracker" to "Datatracker" in various places. Fixes some of #2100.
Commit ready for merge.
 - Legacy-Id: 13108
2017-03-25 18:23:38 +00:00
Henrik Levkowetz d3558524f2 Improved traceback for a logger.error() message.
- Legacy-Id: 13093
2017-03-24 09:03:06 +00:00
Henrik Levkowetz ebef6d06d8 Reverted some links to htmlized draft versions, on request.
- Legacy-Id: 13091
2017-03-23 10:57:19 +00:00
Henrik Levkowetz b603791cae Another fix for get_file_path().
- Legacy-Id: 13088
2017-03-23 10:39:35 +00:00
Henrik Levkowetz eef984202f Better handling of missing documents (such as rfc575)
- Legacy-Id: 13060
2017-03-22 12:07:08 +00:00
Henrik Levkowetz 570ef785d6 Improved Document.get_file_path().
- Legacy-Id: 13059
2017-03-22 12:06:28 +00:00
Henrik Levkowetz 9082b0abe5 Another tweak to the rev pattern, and exception handling when breaking apart name an rev for documents which don't use the charter rev model.
- Legacy-Id: 13057
2017-03-22 09:50:07 +00:00
Henrik Levkowetz 5203118041 Changed one more draft directory reference to use the draft archive setting.
- Legacy-Id: 13056
2017-03-22 09:48:11 +00:00
Henrik Levkowetz 475d18ea8e Changed where to look for the text version of expired drafts.
- Legacy-Id: 13052
2017-03-21 15:12:30 +00:00
Henrik Levkowetz e8043e53fb Made Document.htmlized() be a bit smarter about handling documents which have not been provided in .txt format.
- Legacy-Id: 13050
2017-03-21 14:02:43 +00:00
Henrik Levkowetz 814e1315b5 Added a new document tab for some documents, showing htmlized drafts and RFCs
using the htmlization code previously developed for tools.ietf.org.  As the
generation of the htmlized page is a bit too costly to do on the fly for
often-referenced drafts and RFCs, the part of each page which contains the
htmlized document is cached on file with a cache time of 2 weeks.

Changed all links which pointed to the htmlized version on tools to instead
point at the datatracker htmlized document.

Tweaked some URLs which didn't permit retrieval of intermediate-rev-charters.

Narrowed the pattern for document names to disallow dots in names, and
instead explicitly enumerated the few historical draftw with dots in the
name.

Added a file-system cache for the htmlized documents, and specified a
max_entries value for caches, overriding the default 300 entries.

Tweaked the code for new author email entries to provide a time if missing
in an updated entry.

Changed links in various email templates which pointed at tools.ietf.org
pages to instead point at datatracker pages, where appropriate.

Changed the search result rows to provide links to both the current meta-
information document pages (with a (i) info symbol) and to the new htmlized
document pages.
 - Legacy-Id: 13040
2017-03-20 14:08:52 +00:00
Henrik Levkowetz a67e9dd5c4 Added a number of new methods on DocumentInfo/Document/DocHistory, to support the new htmlized document page. Added caching for some methods.
- Legacy-Id: 13039
2017-03-20 13:51:46 +00:00
Henrik Levkowetz d6d6fd65db Applied a patch rjsparks@nostrum.com to make ballot grids show for statchg documents in ietf last call.
- Legacy-Id: 13015
2017-03-15 14:57:20 +00:00
Henrik Levkowetz fe8cd06a76 Back out the htmlization code for the moment.
- Legacy-Id: 12997
2017-03-12 12:12:44 +00:00
Henrik Levkowetz 2ba55b1b5b Added text() and htmlized() methods on Document, to help with display of htmlized text.
- Legacy-Id: 12992
2017-03-11 13:44:03 +00:00
Henrik Levkowetz 8eb447e77f Added an improved guard against trying to fetch milestones for a group value of None.
- Legacy-Id: 12989
2017-03-08 15:19:08 +00:00
Henrik Levkowetz 707b006d17 Added a guard against trying to fetch milestones for a group value of None.
- Legacy-Id: 12988
2017-03-08 15:14:58 +00:00
Henrik Levkowetz de2356d693 Added a migration for the tweaked DocEvent.rev field.
- Legacy-Id: 12979
2017-03-07 09:48:22 +00:00
Henrik Levkowetz 4daf66d11c Added DocEvent rev= parameter througout the code.
- Legacy-Id: 12978
2017-03-06 15:08:21 +00:00
Henrik Levkowetz 05d57f6577 Added a 'rev' field to DocEvent, and removed the corresponding field from NewRevisionDocEvent and SubmissionDocEvent. Added a migration for an initial schema change, one data migration to copy and infer revision information, another schema migration to remove extraneous revision field, and another data migration to fix up bad timestamps and bad revision info from the period 2016-09-10 to 2016-10-04.
- Legacy-Id: 12974
2017-03-05 19:59:27 +00:00
Henrik Levkowetz dd305e0d87 Fixed a bug in the StateAdmin list_filter setting.
- Legacy-Id: 12972
2017-03-04 16:19:29 +00:00
Henrik Levkowetz 0bebccd1cb Added a data migration which adds 2 new WG states: 'Waiting for Implementation' and 'Held by WG'.
- Legacy-Id: 12969
2017-03-04 13:46:17 +00:00
Henrik Levkowetz 9bbd50119f Added a filter bar for state-type to the admin page for doc.models.State.
- Legacy-Id: 12968
2017-03-04 13:45:08 +00:00
Henrik Levkowetz 387068f67d Updated unreachable markings.
- Legacy-Id: 12967
2017-03-04 05:38:23 +00:00
Henrik Levkowetz c006c44423 Added setting of document author for review document objects.
- Legacy-Id: 12957
2017-03-03 19:40:09 +00:00
Henrik Levkowetz 541085b1a8 Changed email notifications for reviews done to save the message as a Message instance before sending it. Added test code to check that a Message instance is created and matches what goes out.
- Legacy-Id: 12955
2017-03-03 15:45:29 +00:00
Henrik Levkowetz ea70381f29 Merged in [12950] from rcross@amsl.com:
Fixes #2219.  Area Group chairs are denied material management access.
 - Legacy-Id: 12951
Note: SVN reference [12950] has been migrated to Git commit c6d1a59aa4
2017-03-02 21:21:07 +00:00
Henrik Levkowetz 225c1d9afe Changed the state choices in the document adoption form to exclude the few that should not be available, rather than explicitly list all others. Makes adding WG/RG states simpler.
- Legacy-Id: 12949
2017-03-02 20:07:50 +00:00
Henrik Levkowetz 695bf37bc6 Merged in [12930] from rjsparks@nostrum.com:
Use the Role email associated with a reviewer as the From when emailing a review. Fixes #2201.
 - Legacy-Id: 12936
Note: SVN reference [12930] has been migrated to Git commit 8577a5e84a
2017-02-28 21:50:12 +00:00
Henrik Levkowetz 6af4ce62aa Removed debugging code.
- Legacy-Id: 12934
2017-02-28 20:42:19 +00:00
Henrik Levkowetz 5bb5ca727b Created a special function log.unreachable() to mark code unreachable, and changed a function name from log.affirm() to log.assertion().
- Legacy-Id: 12933
2017-02-28 20:16:52 +00:00
Robert Sparks 8577a5e84a Use the Role email associated with a reviewer as the From when emailing a review. Fixes #2201. Commit ready for merge.
- Legacy-Id: 12930
2017-02-28 18:40:09 +00:00
Henrik Levkowetz 5f053ad21a Cleaned up the remaining explicit url names, using dotted-paths to view
functions instead.  In all almost 700 changes.
 - Legacy-Id: 12923
2017-02-26 23:21:49 +00:00
Henrik Levkowetz c58c51f919 Added a migration which captures the added validator for title fields.
- Legacy-Id: 12907
2017-02-24 10:24:34 +00:00
Henrik Levkowetz 27351c4349 Fixed url lookups for doc.views_doc.document_main() to only use dotted-path, and removed the doc_view explicit url name. Fixes a 500 error in /submit/status/NNNN/.
- Legacy-Id: 12897
2017-02-22 11:40:55 +00:00
Henrik Levkowetz 988a2b808f Added explicit charset setting and consistent encoding to several email paths through the datatracker. After introducing support for non-ascii names in email addresses, using role.formatted_email() to insert names into email content doesn't work any more, since uncode names will now be rfc2047-encoded in formatted_email(). Added another method role.name_and_email() for this case. Replaced another case of '%s <%s>' name-and-email formatting with formataddr(). Fixed some tests which did not send unicode email bodies to the email functions. Fixes issue #2017.
- Legacy-Id: 12896
2017-02-21 19:17:10 +00:00
Henrik Levkowetz c889856dfa Added a validator to Document.title to prevent control chars in the title (complementing a recent cleanup of more than 120 instances of document titles containing vertical tabs)
- Legacy-Id: 12893
2017-02-20 20:47:37 +00:00
Henrik Levkowetz 8930d29a8e Merged in Django-1.10 upgrade work from ^/personal/henrik/6.43.1-django-1.10
- Legacy-Id: 12881
2017-02-19 18:18:00 +00:00
Ole Laursen 4d8dd3ee4f Format rfc123 -> RFC 123 on references pages
- Legacy-Id: 12867
2017-02-17 17:17:53 +00:00
Henrik Levkowetz b8815b00c5 Don't use person.plain_name() when constructing email addresses, as it can contain unicode characters which the current email pipeline can't handle correctly. Use person.plain_ascii() instead (or person.formatted_email()).
- Legacy-Id: 12865
2017-02-16 22:59:53 +00:00
Henrik Levkowetz 74af0f5658 Replaced another bunch of explicit url names with dotted-path to the view function.
- Legacy-Id: 12849
2017-02-15 22:11:20 +00:00
Ole Laursen b2ff10b0f2 Add support for extracting the country line from the author addresses
to the draft parser (incorporating patch from trunk), store the
extracted country instead of trying to turn it into an ISO country
code, add country and continent name models and add initial data for
those, add helper function for cleaning the countries, add author
country and continent charts, move the affiliation models to
stats/models.py, fix a bunch of bugs.
 - Legacy-Id: 12846
2017-02-15 18:43:57 +00:00
Henrik Levkowetz 29567adf34 Merged in [12835] from rcross@amsl.com:
Fixes #2202.  Interim sessions appear unordered.  Switch templates to use ordered assignments() related object manager.  Also removed now unused template filters.
 - Legacy-Id: 12839
Note: SVN reference [12835] has been migrated to Git commit 8607be0e21
2017-02-14 16:22:54 +00:00
Ryan Cross 8607be0e21 Fixes #2202. Interim sessions appear unordered. Switch templates to use ordered assignments() related object manager. Also removed now unused template filters. Commit ready for merge.
- Legacy-Id: 12835
2017-02-13 22:30:21 +00:00
Henrik Levkowetz aa5e61d958 Updated all urlpatterns to use ietf.utils.urls.url() instead of django's,
in order to autogenerate dotted path url pattern names.  Updated a number
of url reverses to use dotted path, and removed explicit url pattern names
as needed.

Changed some imports to prevent import of ietf.urls before django
initialization was complete.


Changed 3 cases of form classes being curried to functions; django 1.10
didn't accept that.

Started converting old-style middleware classes to new-style middleware
functions (incomplete).

Tweaked a nomcom decorator to preserve function names and attributes, like
a good decorator should.

Replaced the removed django templatetag 'removetags' with our own version
which uses bleach, and does sanitizing in addition to removing explicitly
mentionied html tags.

Rewrote the filename argument handling in a management command which had
broken with the upgrade.
 - Legacy-Id: 12818
2017-02-11 14:43:01 +00:00
Henrik Levkowetz 19d585255a Django 1.10 does not permit the view argument to url() to be a string any more. Changed all cases view arguments to url() which were strings to instead reference the actual imported function.
- Legacy-Id: 12815
2017-02-10 14:49:16 +00:00
Henrik Levkowetz 088e2ca7f4 Removed dead code which used to work around a now fixed bug (and also used a now removed django function)
- Legacy-Id: 12813
2017-02-10 14:43:37 +00:00
Henrik Levkowetz ffb029300f Added a guard to prevent trying to get a document path for a meeting document when the document is not associated with a meeting session.
- Legacy-Id: 12790
2017-02-08 17:00:12 +00:00
Henrik Levkowetz 8a8283f537 Fixed a pyflakes issue.
- Legacy-Id: 12788
2017-02-07 17:50:06 +00:00
Ole Laursen ef251c6bc7 Add author affiliation chart.
Also add a model for registering an alias for an affiliation so that
we can group affiliations that are considered the same for statistical
purposes, and a model for registering unimportant endings like Inc.
and GmbH.

Affiliation grouping is done through three means: stripping
uninteresting endings, merging entries that only differ in case and
aliases that map from case-insensitive alias to name.

Stripping endings and merging based on case seem to reduce the number
of needed manually maintained aliases greatly.
 - Legacy-Id: 12785
2017-02-03 18:49:43 +00:00
Henrik Levkowetz 0948c4a0f3 Applying format_html() in simple_tag-registered tags as per the suggestions for Django-1.9 upgrade wasn't straightforward. Reverting to earlier code for ballot-icond link.
- Legacy-Id: 12782
2017-02-02 14:24:36 +00:00
Henrik Levkowetz e94129641d @register.simple_tag now (in Django 1.9) needs explicit mark_safe() (or format_html() which invokes mark_safe()). Fixed one case which needed this.
- Legacy-Id: 12779
2017-02-01 20:46:51 +00:00
Henrik Levkowetz de3976bec0 Merged in Django 1.9 upgrade work from ^/personal/henrik/6.41.1-django-1.9
- Legacy-Id: 12764
2017-01-31 15:13:01 +00:00
Henrik Levkowetz 40e8380751 Merged django 1.9 work forward to copy of trunk @6.41.0
- Legacy-Id: 12756
2017-01-30 23:13:02 +00:00
Ole Laursen 698965e3d1 Fix one last fake email addresses that managed to escape the migration
- Legacy-Id: 12743
2017-01-27 12:33:05 +00:00
Henrik Levkowetz ccfbde8d33 Fixed an issue with building links from URLs which are already part of a link. Fixes issue #2175.
- Legacy-Id: 12742
2017-01-26 20:11:46 +00:00
Henrik Levkowetz 0481d97650 Fixed a place where missing queryargument data could cause a 500 error.
- Legacy-Id: 12741
2017-01-26 19:24:34 +00:00
Ole Laursen 9308948195 Add person, affiliation and country (through django-countries) to
DocumentAuthor, rename author field to email and make it optional (for
modeling old email-less submissions), remove the authors many to many
referencing field from Document as it is not really pointing the right
place.

Update the Secretariat tools to show affiliation and country.

Add migration for getting rid of the fake email addresses that the
migration script created some years ago (just set the author email
field to null).
 - Legacy-Id: 12739
2017-01-26 17:10:08 +00:00
Henrik Levkowetz 2ab4caa90f Merged in [12722] from rjsparks@nostrum.com:
Added programs to the datatracker. Added use of restructuredtext for group about pages. Generalized several places where code handles different group types. Improved testing of group about.
 - Legacy-Id: 12725
Note: SVN reference [12722] has been migrated to Git commit e0ea8b0f57
2017-01-24 21:30:10 +00:00
Robert Sparks e0ea8b0f57 Added programs to the datatracker. Added use of restructuredtext for group about pages. Generalized several places where code handles different group types. Improved testing of group about. Commit ready for merge.
- Legacy-Id: 12722
2017-01-24 19:55:49 +00:00
Henrik Levkowetz e2640f358b Changed semantics for can_manage_group() to include chairs etc, and changed calls with the old semantics to use can_manage_group_type(). Rewrote can_manage_group() in terms of can_manage_group_type() and additional checks. Fixes issue #2155.
- Legacy-Id: 12719
2017-01-23 22:54:36 +00:00
Henrik Levkowetz 5a5bb1f03f Removed useless code.
- Legacy-Id: 12718
2017-01-23 21:29:36 +00:00
Henrik Levkowetz 613f0c8233 Pyflakes fixes.
- Legacy-Id: 12714
2017-01-23 18:35:58 +00:00
Henrik Levkowetz ef1b404fe3 Removed an extraneous request parameter.
- Legacy-Id: 12712
2017-01-23 18:21:15 +00:00
Henrik Levkowetz 6de7be6953 Specified strip=False for another bunch of CharField form fields with Textarea widgets.
- Legacy-Id: 12711
2017-01-23 17:38:56 +00:00
Henrik Levkowetz fa60671148 Fixed another instance of '=' being used for comparison in a template.
- Legacy-Id: 12708
2017-01-19 21:21:10 +00:00
Henrik Levkowetz 1dba613197 Merged in [12675] from rjsparks@nostrum.com:
Removed some unnecessary randomness in tests introduced in last commit.
 - Legacy-Id: 12678
Note: SVN reference [12675] has been migrated to Git commit 4f2f691de6
2017-01-19 17:24:08 +00:00
Henrik Levkowetz fd2304e446 In Django 1.9, CharField form fields will be whitespace-stripped by default. Added strip=False for the status change review form content. Also removed a superfluous f.close().
- Legacy-Id: 12677
2017-01-19 17:15:28 +00:00
Henrik Levkowetz 7c2a161a5f Removed some remaining instances of render using context_instance. Fixed a case of tuple length of list of tuples passed to a template to be the same for all tuples.
- Legacy-Id: 12676
2017-01-19 17:08:27 +00:00
Robert Sparks 4f2f691de6 Removed some unnecessary randomness in tests introduced in last commit. Commit ready for merge.
- Legacy-Id: 12675
2017-01-19 16:37:00 +00:00
Henrik Levkowetz b4480a1625 Merged in [12670] from rjsparks@nostrum.com:
Make changing skip_next on a review assignment an explicit decision of the assigner.  Fixes #2148.
 - Legacy-Id: 12671
Note: SVN reference [12670] has been migrated to Git commit 8e007ce50b
2017-01-19 15:25:22 +00:00
Robert Sparks 8e007ce50b Make changing skip_next on a review assignment an explicit decision of the assigner. Commit ready for merge. Fixes #2148.
- Legacy-Id: 12670
2017-01-19 14:23:09 +00:00
Henrik Levkowetz 79dc639f46 Merged in [12665] from rjsparks@nostrum.com:
Make it easier to see who's really next in reviewer rotation.
 - Legacy-Id: 12668
Note: SVN reference [12665] has been migrated to Git commit 49dcf67fd5
2017-01-18 16:30:29 +00:00
Henrik Levkowetz dd82df50a1 Merged in [12627] from rjsparks@nostrum.com:
Added some convenience navigation for review team secretaries to the menu. Restructured the menu lightly around Documents and Role-related links. Added navigation from a reviewers \'My Reviews\' page back to the review team pages. Fixes #2079.
 - Legacy-Id: 12667
Note: SVN reference [12627] has been migrated to Git commit 41d3bb61b4
2017-01-18 15:55:11 +00:00
Henrik Levkowetz 7a8555599f Added a link to the group datatracker page to the new group announcement (and review) emails. Fixes issue #2140.
- Legacy-Id: 12666
2017-01-17 22:22:46 +00:00
Robert Sparks 0dd2e460f3 Make it easier to see what reviews need to be closed as "No Response". Fixes #2128. Commit ready for merge.
- Legacy-Id: 12664
2017-01-17 21:04:42 +00:00
Ole Laursen 641d92cf49 Add many-to-many field with formal languages to Document and add formal
language statistics
 - Legacy-Id: 12658
2017-01-16 17:06:54 +00:00
Ole Laursen 6378594033 Add word count and submit format statistics
- Legacy-Id: 12656
2017-01-16 11:36:38 +00:00
Henrik Levkowetz 7b95411f58 The context_instance parameter to render_to_response() and render_to_string() is now deprecated. Fixed this, and generally changed the idiom render_to_response('template.html', {}, RequestContext(request)) to the newer and simpler render(request, 'template.html', {}). About 200 instances.
- Legacy-Id: 12637
2017-01-09 21:26:30 +00:00
Henrik Levkowetz a21812633d Removed unnecessary leading slash in url pattern, silencing a system check warning.
- Legacy-Id: 12632
2017-01-09 16:28:59 +00:00
Robert Sparks 41d3bb61b4 Added some convenience navigation for review team secretaries to the menu. Restructured the menu lightly around Documents and Role-related links. Added navigation from a reviewers "My Reviews" page back to the review team pages. Fixes #2079. Commit ready for merge.
- Legacy-Id: 12627
2016-12-23 21:20:55 +00:00
Henrik Levkowetz 5cc3b6448e Django 1.9: Removed additional instances of deprecated django.conf.urls.patterns()
- Legacy-Id: 12623
2016-12-22 18:14:57 +00:00
Henrik Levkowetz d5460b8f7f Django 1.9: Merged work forward to copy of latest release.
- Legacy-Id: 12621
2016-12-22 17:30:50 +00:00
Henrik Levkowetz c2541ec04b Django 1.9: Removed deprecated use of django.conf.urls.patterns() from all urls*.py files.
- Legacy-Id: 12618
2016-12-22 17:21:57 +00:00
Robert Sparks 6091d3c6a3 Tweak the docevent description for the event noting that a chartering effort has been abandoned. Fixes #2099. Commit ready for merge.
- Legacy-Id: 12606
2016-12-21 22:14:58 +00:00
Robert Sparks 6ca953ae24 Improve the team review content templates. Related to #2075. Commit ready for merge.
- Legacy-Id: 12595
2016-12-20 05:38:02 +00:00
Robert Sparks fbd2cd493d Provide templates for directly entered review contents for those teams/review-types that have them. Fixes #2075. Commit ready for merge.
- Legacy-Id: 12594
2016-12-19 23:21:11 +00:00
Robert Sparks 10f4892eae Send mail to team secretaries when a review is explicitly requested. Change the From and Subject for assignment emails to reviewers to make it clearer what the review is for and who assigned it. Fixes #2053 and #2114. Commit ready for merge.
- Legacy-Id: 12593
2016-12-19 22:32:03 +00:00
Robert Sparks 7c182375af Change how we display review text to follow the tecnique used with other large blocks of pasted or imported text (shepherds writeups for instance). Fixes #2104. Commit ready for merge.
- Legacy-Id: 12588
2016-12-19 20:38:51 +00:00
Henrik Levkowetz ff3638e365 Merged in [12549] from rjsparks@nostrum.com:
allow ads and secretaries to edit the review request comment. Fixes #2096. (Again).
 - Legacy-Id: 12550
Note: SVN reference [12549] has been migrated to Git commit 32b431cf24
2016-12-15 23:10:28 +00:00
Henrik Levkowetz 8dcc1d20a2 Merged in [12545] from rjsparks@nostrum.com:
Allow a review request to include a comment to show to the review team secretary at assignment time and the reviewer at review time. Fixes #2096.
 - Legacy-Id: 12548
Note: SVN reference [12545] has been migrated to Git commit 6fcd8b8a16
2016-12-15 22:45:25 +00:00
Henrik Levkowetz eafa070790 Merged in [12543] from rjsparks@nostrum.com:
Provide defaults on the Request review form. Fixes #2108.
 - Legacy-Id: 12547
Note: SVN reference [12543] has been migrated to Git commit 870fa59d0c
2016-12-15 22:10:12 +00:00
Henrik Levkowetz b14e981e66 Merged in [12520] from rjsparks@nostrum.com:
Slight refactor of the review models to capture review team settings. Allows configuring review teams to get automatic suggestions for reviews or not. Provides a better admin for creating/managing review teams. Fixes #2048 and #2072.
 - Legacy-Id: 12544
Note: SVN reference [12520] has been migrated to Git commit b24bdb5bc3
2016-12-15 20:55:40 +00:00
Henrik Levkowetz 51fedbf483 Merged in [12505] from rjsparks@nostrum.com:
Disallow requesting directorate reviews of RFCs (such things would better be done with reviews of status change documents). Fixes #2065.
 - Legacy-Id: 12537
Note: SVN reference [12505] has been migrated to Git commit 1ea983a1c2
2016-12-15 16:31:36 +00:00
Henrik Levkowetz 17a7f59cd6 Deprecation fixes: Use request.GET or request.POST as appropriate, instead of request.REQUEST.
- Legacy-Id: 12533
2016-12-15 13:21:33 +00:00
Henrik Levkowetz ff9b8a9bdb Deprecation fixes: Explicitly say that redirects are permanent.
- Legacy-Id: 12532
2016-12-15 13:19:51 +00:00
Henrik Levkowetz 8e56935cfd Undid commit 12527, which contained much too much.
- Legacy-Id: 12528
2016-12-15 10:38:54 +00:00
Henrik Levkowetz e3c6e0ac6b Changed the state shown in all_id.txt for drafts which have entered IESG processing, but then been replaced, to show as 'Replaced' instead of 'In IESG Processing'. This is consistent with how they are shown in all_id2.txt.
- Legacy-Id: 12527
2016-12-15 10:36:15 +00:00
Robert Sparks b24bdb5bc3 Slight refactor of the review models to capture review team settings. Allows configuring review teams to get automatic suggestions for reviews or not. Provides a better admin for creating/managing review teams. Fixes #2048 and #2072. Commit ready for merge.
- Legacy-Id: 12520
2016-12-14 23:26:32 +00:00
Henrik Levkowetz 9a3f6b059b Merged Django-1.8 upgrade work to trunk. Adjusted migration names, and added migrations as necessary. Fixed some instances of broken html.
- Legacy-Id: 12507
2016-12-13 05:55:46 +00:00
Robert Sparks 1ea983a1c2 Disallow requesting directorate reviews of RFCs (such things would better be done with reviews of status change documents). Fixes #2065. Commit ready for merge.
- Legacy-Id: 12505
2016-12-12 21:42:53 +00:00
Henrik Levkowetz 03d90163a5 Merged django-1.8 work forward to copy of 6.39.1
- Legacy-Id: 12504
2016-12-10 19:32:46 +00:00
Henrik Levkowetz 3c956c9896 Added migrations for new timezone data, validation on ReviewerSettings.filter_re, and new docevent types.
- Legacy-Id: 12493
2016-12-09 12:41:38 +00:00
Henrik Levkowetz 57eb5844e5 Merged in [12489] from rjsparks@nostrum.com:
Save a new reviewrequest for each team requested in the request form. Fixes #2094.
 - Legacy-Id: 12491
Note: SVN reference [12489] has been migrated to Git commit 4fff1ab101e4f7cd27dc8ded889e09905866076f
2016-12-09 12:01:48 +00:00
Henrik Levkowetz 8c7a400683 Merged in [12486] from rjsparks@nostrum.com:
Fill in CC list defaults for review completion mail. Make the mail come from the reviewer instead of the default secretariat address. Fixes #2078 and #2054.
 - Legacy-Id: 12488
Note: SVN reference [12486] has been migrated to Git commit 062707f51b351e1fcd5d682b23af8c7feeb2442d
2016-12-08 23:44:50 +00:00
Henrik Levkowetz e40afaedf0 Check event type only when an event is available.
- Legacy-Id: 12484
2016-12-08 17:57:59 +00:00
Henrik Levkowetz 2c27d5c611 Moved optional text wrapping before html escaping in markup_unicode(), used by get_unicode_document_content(). Fixes a problem with lines being wrapped when they should not be.
- Legacy-Id: 12480
2016-12-08 16:27:05 +00:00
Henrik Levkowetz 19ec458668 Added migrations for the model changes done for the Django 1.8 upgrade.
- Legacy-Id: 12478
2016-12-07 19:41:48 +00:00
Henrik Levkowetz 7fbf2e8609 Changed the deprecated model._meta.get_all_field_names() to a supported construct.
- Legacy-Id: 12475
2016-12-07 18:27:57 +00:00
Henrik Levkowetz e4ce339235 Merged in [12461] from rjsparks@nostrum.com:
Added migration to fetch text from reviews in the mail archives and populate the review documents. Fixes #2064.  Will patch into production.
 - Legacy-Id: 12463
Note: SVN reference [12461] has been migrated to Git commit 63a9599bafdcacf49f1bb374b2156d8473da93d1
2016-12-05 21:03:49 +00:00
Henrik Levkowetz 14776bae70 Merged django18 work forward to r12447
- Legacy-Id: 12455
2016-12-05 15:03:40 +00:00
Henrik Levkowetz 1d5a7a692a Added a DB consistency check, and 2 new doc.statetype values found by the check for consistency.
- Legacy-Id: 12451
2016-12-05 14:12:19 +00:00
Henrik Levkowetz 0bb7854591 Merged django18 work forward to 6.39
- Legacy-Id: 12449
2016-12-05 14:01:25 +00:00
Henrik Levkowetz 486e394cbf Added more document information to the personal profile pages at /person/<full name>, after a suggestion from Benoit Claise. Fixes issue #2066.
- Legacy-Id: 12447
2016-12-05 13:00:01 +00:00
Henrik Levkowetz 37f9aa06be Merged in [12438] from rjsparks@nostrum.com:
Don't show teams with only 'No response' reviews in the search result rows, using the same logic as used for the document main page. Fixes #2070.
 - Legacy-Id: 12441
Note: SVN reference [12438] has been migrated to Git commit d1c0c053327594c8a594ad2ad779fac9974d8eaa
2016-12-01 22:16:32 +00:00
Henrik Levkowetz e3ce2a9657 Tweaked the admin for doc.models.Document to capture a comment about changes made, and save those in the document history, using .save_with_history(). This makes the admin useful again for doing document changes. See issue #2067.
- Legacy-Id: 12434
2016-12-01 16:35:23 +00:00