altf4arnold/datatracker
1
0
Fork 0
Code Issues Pull requests Actions 3 Packages Projects Releases Wiki Activity

Guard against reviewer name not being filled in properly (still

Browse source 
containing a @) on the complete review page
 - Legacy-Id: 12127
This commit is contained in:
Ole Laursen 2016-10-13 15:54:11 +00:00
parent 336e2bbc5e
commit 5a878981fe
1 changed files with 3 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
ietf/doc/views_review.py
View file

@ -367,6 +367,9 @@ class CompleteReviewForm(forms.Form):
return get_cleaned_text_file_content(self.cleaned_data["review_file"])
def clean(self):
if "@" in self.review_req.reviewer.person.ascii:
raise forms.ValidationError("Reviewer name must be filled in (the ASCII version is currently \"{}\" - since it contains an @ sign the name is probably still the original email address).".format(self.review_req.reviewer.person.ascii))
def require_field(f):
if not self.cleaned_data.get(f):
self.add_error(f, ValidationError("You must fill in this field."))