Refs #2217 - Small cleanup from changeset [16924]
- Legacy-Id: 16947
Note: SVN reference [16924] has been migrated to Git commit 871a4b653b
Note: SVN reference [16927] has been migrated to Git commit 730e64d253
On the main page of a document and in document search results, a new
button allows review team members to add a review wish for that document.
For reviewers that are only on one team, this essentially works
identical to tracking a document. Reviewers that are on multiple teams
are lead through an intermediate step to select a review team, and then
returned to their search or document page.
Commit ready for merge.
- Legacy-Id: 16939
Only show a blocked document once in the set of blocked documents on an ADs document page. Fixes#2818.
- Legacy-Id: 16938
Note: SVN reference [16937] has been migrated to Git commit 8f1e9990cf
Fix#2217 - Allow submission of unsolicited reviews by secretaries.
- For team secretaries, a button 'Submit unsolicited review' will now
appear next to 'Request review' on the document's main page.
- If the secretary is a secretary for multiple teams, they are taken
through an intermediate page to select for which team they are
submitting their review.
- The form is similar (and using the same code) as the usual review
completion, with a few extra fields for the review type and reviewer,
which would usually already be known.
- When submitting the review, a ReviewRequest and ReviewAssignment are
automatically created. The assignment is then immediately closed in
the usual way.
- Other workflows are unchanged.
The issues with the review form in #2061 are slightly worse for the
unsolicited review scenario, but that will be improved when #2061 is
fixed.
- Legacy-Id: 16932
Note: SVN reference [16924] has been migrated to Git commit 871a4b653b
Fix#2087 - Show doc authors and WG chairs in unassigned reviews views.
- Legacy-Id: 16931
Note: SVN reference [16923] has been migrated to Git commit 93797b3fc1
Fix#2123 - Use a DBTemplate when a review assignment is mailed.
The message sent to a reviewer when a new review is assigned to them,
is now taken from a DBTemplate, allowing it to be customised
per team. This includes a migration to create a default template,
which looks the same as before.
- Legacy-Id: 16928
Note: SVN reference [16921] has been migrated to Git commit 9df5839874
- For team secretaries, a button "Submit unsolicited review" will now
appear next to "Request review" on the document's main page.
- If the secretary is a secretary for multiple teams, they are taken
through an intermediate page to select for which team they are
submitting their review.
- The form is similar (and using the same code) as the usual review
completion, with a few extra fields for the review type and reviewer,
which would usually already be known.
- When submitting the review, a ReviewRequest and ReviewAssignment are
automatically created. The assignment is then immediately closed in
the usual way.
- Other workflows are unchanged.
The issues with the review form in #2061 are slightly worse for the
unsolicited review scenario, but that will be improved when #2061 is
fixed.
Commit ready for merge.
- Legacy-Id: 16924
The message sent to a reviewer when a new review is assigned to them,
is now taken from a DBTemplate, allowing it to be customised
per team. This includes a migration to create a default template,
which looks the same as before.
Commit ready for merge.
- Legacy-Id: 16921
Fix#2277 - Do not allow reviewers to reject overdue reviews.
If a review request is past the deadline, reviewers will no longer be
able to reject the assignment.
- Legacy-Id: 16909
Note: SVN reference [16883] has been migrated to Git commit 3c2b01b3ff
Adds docs with blocking positions to the ADs my-documents page. Fixes#2800.
- Legacy-Id: 16906
Note: SVN reference [16875] has been migrated to Git commit f7d4600371b3f2a3c92aa184b517ed4ebee3a118
Be resilient to statistics queries that provide a state but not a substate. Fixes#2813.
- Legacy-Id: 16905
Note: SVN reference [16860] has been migrated to Git commit 654ae848f657957d2f7d259293ba523619d81cb5
Remove some pre-ReviewAssignment refactor logic, and simplify what remains while still allowing a group secretary to not assign a row on the unassigned requests form after touching the control to assign a reviewer. Fixes#2812.
- Legacy-Id: 16900
Note: SVN reference [16854] has been migrated to Git commit b158807134e2d26b3e013b6414b6fcbaa0e39f77
Changes to displaying the ballot_icon to account for IRSG ballots.
- Legacy-Id: 16896
Note: SVN reference [16836] has been migrated to Git commit 6375aa3bedbd612cd519bf3dccced2465b145593
Improve alerts when looking at non-current versions of a charter document. Fixes#2774.
- Legacy-Id: 16845
Note: SVN reference [16785] has been migrated to Git commit 07637c27e1a76d3cbb92cc22b987b9f1426d8d52
Populate completed_on when rejecting a ReviewAssignment. Migrate past rejected assignments accordingly. Fixes#2782.
- Legacy-Id: 16841
Note: SVN reference [16770] has been migrated to Git commit 661e4c5369dc0d165bfcb56e3278906fe1de3b55
Allow responsible AD to be None for documents in iesg states idexists and dead. Fixes#2803 and #993.
- Legacy-Id: 16838
Note: SVN reference [16763] has been migrated to Git commit 9f54af355d4e2b17404caa1755be74d22b5edad1
Fix#2478 - When completing review, show which addresses it is posted to.
- Legacy-Id: 16795
Note: SVN reference [16688] has been migrated to Git commit 68ea11a916
Fix#2354 - Make review_completed configurable per team and review type
This includes a migration to change mailtrigger slugs to be up to 64
characters instead of 32, as some slugs would not fit and require clunky
abbreviations.
A data migration creates triggers for existing teams, and they are also
created on the fly if a trigger does not exist yet, providing a safe
fallback for new review teams. The review_completed mailtrigger serves
as the template for new triggers.
This commit also includes tests for gather_address_lists(), as none
existed.
- Legacy-Id: 16794
Note: SVN reference [16680] has been migrated to Git commit 1390ae073c
Fix#2328 - Use mailtriggers to find destinations in review app
As the review app has several conditionals that don't fit
entirely well within mailtriggers, the templates use a bit
of extra context to figure out who exactly to include. This also
extends the tests for review, to check for correct recipients.
It also adds a tiny feature to mailtrigger to entirely exclude
certain addresses, as required by the review-generated mails.
- Legacy-Id: 16793
Note: SVN reference [16672] has been migrated to Git commit 88b7b45b0e
Fix#2590 - Allow secretary to adjust date when completing a review.
This also fixes other issues identified in #2590, around the
modification of historical document events. The behaviour is now:
- When the assigned reviewer posts a review, a single event is
created, set to current date/time.
- When the secretary records a review in the datatracker, they may
set a different completion date, which is autofilled if an email
is selected. One event is generated for the original completion
date, and one for the secretary's action.
- Each revision generates a new event, rather than updating previous
existing events.
- Legacy-Id: 16791
Note: SVN reference [16670] has been migrated to Git commit 3942f9acc7
Guard against attempts to use the review request view with a ReviewRequest id that does not match the document for the ReviewRequest. This would have exposed #2776 much earlier.
- Legacy-Id: 16710
Note: SVN reference [16649] has been migrated to Git commit 01ceeba131
This includes a migration to change mailtrigger slugs to be up to 64
characters instead of 32, as some slugs would not fit and require clunky
abbreviations.
A data migration creates triggers for existing teams, and they are also
created on the fly if a trigger does not exist yet, providing a safe
fallback for new review teams. The review_completed mailtrigger serves
as the template for new triggers.
This commit also includes tests for gather_address_lists(), as none
existed.
Commit ready for merge.
- Legacy-Id: 16680
As the review app has several conditionals that don't fit
entirely well within mailtriggers, the templates use a bit
of extra context to figure out who exactly to include. This also
extends the tests for review, to check for correct recipients.
It also adds a tiny feature to mailtrigger to entirely exclude
certain addresses, as required by the review-generated mails.
Commit ready for merge.
- Legacy-Id: 16672
This also fixes other issues identified in #2590, around the
modification of historical document events. The behaviour is now:
- When the assigned reviewer posts a review, a single event is
created, set to current date/time.
- When the secretary records a review in the datatracker, they may
set a different completion date, which is autofilled if an email
is selected. One event is generated for the original completion
date, and one for the secretary's action.
- Each revision generates a new event, rather than updating previous
existing events.
- Legacy-Id: 16670
Remove a debug statement from the command
- Legacy-Id: 16661
Note: SVN reference [16603] has been migrated to Git commit d27096f39022e9bee1ffa84631d5ae847af9be3e
A management command to correct the state of several slide presentations uploaded during IETF105, and perform some missed powerpoint to pdf conversions.
- Legacy-Id: 16659
Note: SVN reference [16601] has been migrated to Git commit a14188d95cf200dfbdd93485b89808f3336b0649
Added encoding='utf-8' parameter to io.open operations in tests that starting failing since adding unicode_literals.
- Legacy-Id: 16588
Note: SVN reference [16562] has been migrated to Git commit d332bfd91d
Partially addresses issue #1926 still displaying markdown as text. Fixes#2704.
- Legacy-Id: 16576
Note: SVN reference [16557] has been migrated to Git commit f76c46bef0
primary keys from character strings to integers, and makes corresponding code
changes.
This was prompted by database limitations discovered when trying to make
DocAlias use a m2m document field; with 255 long strings as primary keys for
Document and DocAlias this violated the MySQL database limitations.
Changing the primary keys to integers should also improve efficiency.
Due to the data migrations which create the new integer primary keys and adds
corresponding integer foreign keys matching the previous string foreign keys
in all tables having foreign keys to Document and DocAlias, some of these
migrations take a long time. The total set of migrations are expected to have
a runtime on the order of 2 hours.
- Legacy-Id: 16237
Remove some clutter from I-D upload page. The information was mived to the Instructions tab, but a higligh to the Note Well and BCP 78 was added. Fixes#2057.
- Legacy-Id: 16151
Note: SVN reference [16144] has been migrated to Git commit 37851b9742
Allow Secretariat to handle downrefs when they approve a document
- Legacy-Id: 16134
Note: SVN reference [16126] has been migrated to Git commit 8c7e75101d
Include the note itself in email sent when the RFC editor note changes after document approval. Also changed the flow to redirect back to the writeups pages after editing the RFC editor note. Fixes#2672.
- Legacy-Id: 16130
Note: SVN reference [16110] has been migrated to Git commit fbfd204eb9
Protect drafts in certain IRTF states from expiring. Fixes#2669.
- Legacy-Id: 16129
Note: SVN reference [16109] has been migrated to Git commit 003e472d04
invalidate the get_state_slug cache when the get_state cache is invalidated. Fixes#2630.
- Legacy-Id: 15760
Note: SVN reference [15720] has been migrated to Git commit f1c1b9fc6c
Added a mail alias for all review team secretaries. Fixes#2139. Use
the alias if there is one for email about review request changes. Added
a test for the review team secretary alias functionality.
- Legacy-Id: 15746
Note: SVN reference [15708] has been migrated to Git commit 6067dcbfef
Note: SVN reference [15730] has been migrated to Git commit d525ade0b0
Added easier to detect error message when search returns 0 results. This currently parses html result from the mailarchive system, but when we get proper API to mailarchive system it should be changed to do that instead. Fixes#2126.
- Legacy-Id: 15744
Note: SVN reference [15706] has been migrated to Git commit f9eeee0cc9
Changed format of the reviewer statistics in lists. Fixes#2131.
- Legacy-Id: 15735
Note: SVN reference [15701] has been migrated to Git commit 56acd00c6c
