altf4arnold/datatracker
1
0
Fork 0
Code Issues Pull requests Actions 3 Packages Projects Releases Wiki Activity
12409 commits 1 branch 0 tags 2.6 GiB
Commit graph

1495 commits

Author SHA1 Message Date
Henrik Levkowetz a5e31c3f40 Py2/3 compatibility: Added __future__ import. 
- Legacy-Id: 16452
 2019-07-15 15:52:18 +00:00
Henrik Levkowetz 28472a462b Python2/3 compatibility: Added more elements to list (tuple) entries to ensure sorting without exceptions under Python3. 
- Legacy-Id: 16451
 2019-07-15 15:51:26 +00:00
Henrik Levkowetz 855716e1d5 Py2/3 compatibility: Added __future__ import 
- Legacy-Id: 16448
 2019-07-15 15:46:06 +00:00
Henrik Levkowetz 2d7c9629aa Added 'from __future__' imports all over the place, to bring code behaviour into closer alignment between python2 and python3 
- Legacy-Id: 16446
 2019-07-15 15:40:51 +00:00
Henrik Levkowetz f481f5c3e6 Replaced use of six with the equivalent pure python3 constructs. 
- Legacy-Id: 16428
 2019-07-08 10:43:47 +00:00
Henrik Levkowetz f8d4c3c9a6 More assertContains() and BytesIO() related changes. 
- Legacy-Id: 16411
 2019-07-07 12:45:57 +00:00
Henrik Levkowetz 04a728c23d Fixed bytes/str issues in some migrations (models.Index() arguments). 
- Legacy-Id: 16410
 2019-07-07 12:41:11 +00:00
Henrik Levkowetz 0679eaa8d4 Removed unused imports. 
- Legacy-Id: 16402
 2019-07-04 21:06:57 +00:00
Henrik Levkowetz f480799af9 Undid unintentional bulk commit 
- Legacy-Id: 16401
 2019-07-04 21:04:46 +00:00
Henrik Levkowetz fc09a59950 Added decode() of command pipe output. 
- Legacy-Id: 16400
 2019-07-04 21:01:39 +00:00
Henrik Levkowetz d957f32690 Fixed a syntax error and removed unused imports. 
- Legacy-Id: 16389
 2019-07-04 20:48:55 +00:00
Henrik Levkowetz a1e7dc9acc Changed a function name. 
- Legacy-Id: 16386
 2019-07-04 16:10:21 +00:00
Henrik Levkowetz 81fa6dc962 Fixed some issues with bulk changes related to assertContains() 
- Legacy-Id: 16379
 2019-07-04 16:04:39 +00:00
Henrik Levkowetz f33ecaa1a4 Fixed a test that compared an int with a meeting number string. Changed meeting test data to use meeting number 72 instead of 42, because proceedings code gives 404 for meetings before 65. Changed a number of StringIO() to BytesIO(). 
- Legacy-Id: 16378
 2019-07-04 16:01:32 +00:00
Henrik Levkowetz b7690fbdcd Changed additional regexes to r strings. 
- Legacy-Id: 16377
 2019-07-04 15:54:23 +00:00
Henrik Levkowetz 0589d0b313 Changed a bunch of regexes to use r strings; also miscellaneous smaller fixes. 
- Legacy-Id: 16376
 2019-07-04 15:51:05 +00:00
Henrik Levkowetz 97a555936d Changed a large number of test assertions to use assertContains() and removed separate, now unnecessary,status_code checks. Also changed many assertTrue(... in ...) to use assertIn(). 
- Legacy-Id: 16346
 2019-06-30 21:03:34 +00:00
Henrik Levkowetz ff6997df2b Fixed a case of indeterminate ordering. 
- Legacy-Id: 16343
 2019-06-30 20:58:26 +00:00
Henrik Levkowetz 8b52899459 Fixed some additional str/bytes issues. 
- Legacy-Id: 16342
 2019-06-30 20:56:56 +00:00
Henrik Levkowetz 36cac48063 Fixed a bunch of str/bytes issues. 
- Legacy-Id: 16341
 2019-06-30 20:54:09 +00:00
Henrik Levkowetz 05f275a3af Changed instances of json.loads(r.content) to r.json(). Changed some instances of assert* to assertContains. 
- Legacy-Id: 16338
 2019-06-30 20:44:45 +00:00
Henrik Levkowetz 15e74e89cb Converted instances of assertTrue(text in response.content) to the recommended assertContains(response, text), and similar for assertFalse(... in ...) 
- Legacy-Id: 16336
 2019-06-29 13:43:31 +00:00
Henrik Levkowetz 42c620f4ae Fixed search result ordering where we had comparisons between int and str, which is disallowed in py3. 
- Legacy-Id: 16335
 2019-06-29 13:32:44 +00:00
Henrik Levkowetz 2b1f238204 Changed regex strings to raw strings and fixed a sort comparison int/str issue. 
- Legacy-Id: 16333
 2019-06-29 13:29:13 +00:00
Henrik Levkowetz 484dcece5f Changed all model __unicode__() methods to __str__() 
- Legacy-Id: 16330
 2019-06-28 21:07:08 +00:00
Henrik Levkowetz d40a5ac5ac Removed some regex unicode flags. 
- Legacy-Id: 16321
 2019-06-28 13:33:38 +00:00
Henrik Levkowetz 06daf6ac65 Changed regex strings to raw strings. 
- Legacy-Id: 16312
 2019-06-27 18:08:02 +00:00
Henrik Levkowetz 3ec7e864be Converted leading tabs to spaces in ietf/**/*.py 
- Legacy-Id: 16310
 2019-06-27 14:51:02 +00:00
Henrik Levkowetz d7f5c84182 Initial 2to3 patch with added copyright statement updates. 
- Legacy-Id: 16309
 2019-06-27 14:40:54 +00:00
Henrik Levkowetz db12f2b948 Fixed some name versus pk issues lingering after the Document/DocAlias primary key refactoring. Fixes issue #2729. 
- Legacy-Id: 16288
 2019-06-19 12:57:52 +00:00
Henrik Levkowetz 7270d5f67a Added the option to order API resource lists by primary key, for stable ordering when paging through a list. 
- Legacy-Id: 16284
 2019-06-18 12:40:19 +00:00
Henrik Levkowetz 565c55ab05 The Document and DocAlias primary key refactoring caused the Tastypie API under /api/v1/ to change -- reverting that to use the old form, with name ask key. 
- Legacy-Id: 16282
 2019-06-17 18:53:17 +00:00
Henrik Levkowetz 05c5abed53 Added a missing migration 
- Legacy-Id: 16263
 2019-06-16 13:18:06 +00:00
Henrik Levkowetz be92e6b868 Removed an incorrect log.unreachble() invocation. 
- Legacy-Id: 16262
 2019-06-15 21:32:15 +00:00
Henrik Levkowetz 426870b766 Merged in the Document and DocAlias primary key change and m2m work in ^/personal/henrik/6.96.1-docalias. 
- Legacy-Id: 16261
 2019-06-15 12:00:48 +00:00
Henrik Levkowetz a2cafded25 Changed DocAlias to be many-to-many, in order to be able to handle STD aliases referring to multiple RFCs. 
- Legacy-Id: 16249
 2019-06-14 20:38:14 +00:00
Henrik Levkowetz 815602351f This is a series of 50 migrations that changes the Document and DocAlias 
primary keys from character strings to integers, and makes corresponding code
changes.

This was prompted by database limitations discovered when trying to make
DocAlias use a m2m document field; with 255 long strings as primary keys for
Document and DocAlias this violated the MySQL database limitations.

Changing the primary keys to integers should also improve efficiency.  

Due to the data migrations which create the new integer primary keys and adds
corresponding integer foreign keys matching the previous string foreign keys
in all tables having foreign keys to Document and DocAlias, some of these
migrations take a long time.  The total set of migrations are expected to have
a runtime on the order of 2 hours.
 - Legacy-Id: 16237
 2019-06-10 11:32:46 +00:00
Henrik Levkowetz 1b5cdfe2f5 Added review assignment information to the review-document view. Addresses issue #2717. 
- Legacy-Id: 16203
 2019-05-07 21:53:38 +00:00
Henrik Levkowetz 2538a581c2 Whitespace changes only 
- Legacy-Id: 16187
 2019-05-06 13:32:29 +00:00
Henrik Levkowetz ed2042da0e Some additional tweaks to the review assingment migrations. 
- Legacy-Id: 16183
 2019-05-02 15:40:21 +00:00
Henrik Levkowetz 9282195d6c Fixed some migrations issues that prevented the review assignment refactoring migrations from being reversed and re-applied. 
- Legacy-Id: 16182
 2019-05-02 13:49:14 +00:00
Henrik Levkowetz ca1f3340c0 Changed a ReviewAssignmentDocEvent type from 'closed_review_request' to 'closed_review_assignment', for consistency and readability. 
- Legacy-Id: 16181
 2019-05-02 12:38:41 +00:00
Henrik Levkowetz 8726e74709 Merged in a refactoring of document review code from rjsparks@nostrum.com. This introduces ReviewAssignments, letting us do multiple assingments for a given RevieRequest, without conflating the assignments and their results with the request itself. 
- Legacy-Id: 16177
 2019-04-30 16:54:06 +00:00
Henrik Levkowetz bb4fe3fbbf Undid previous commit 
- Legacy-Id: 16153
 2019-04-22 19:22:42 +00:00
Henrik Levkowetz cfcefc2e32 Merged in [16144] from housley@vigilsec.com: 
Remove some clutter from I-D upload page.  The information was mived to the Instructions tab, but a higligh to the Note Well and BCP 78 was added. Fixes #2057.
 - Legacy-Id: 16151
Note: SVN reference [16144] has been migrated to Git commit 37851b9742
 2019-04-22 17:39:26 +00:00
Henrik Levkowetz 33e0f8c35d Merged in [16126] from housley@vigilsec.com: 
Allow Secretariat to handle downrefs when they approve a document
 - Legacy-Id: 16134
Note: SVN reference [16126] has been migrated to Git commit 8c7e75101d
 2019-04-08 17:02:02 +00:00
Henrik Levkowetz 5aad3a652d Merged in [16110] from rjsparks@nostrum.com: 
Include the note itself in email sent when the RFC editor note changes after document approval. Also changed the flow to redirect back to the writeups pages after editing the RFC editor note. Fixes #2672.
 - Legacy-Id: 16130
Note: SVN reference [16110] has been migrated to Git commit fbfd204eb9
 2019-04-03 19:30:10 +00:00
Henrik Levkowetz c7e5459d5a Merged in [16109] from rjsparks@nostrum.com: 
Protect drafts in certain IRTF states from expiring. Fixes #2669.
 - Legacy-Id: 16129
Note: SVN reference [16109] has been migrated to Git commit 003e472d04
 2019-04-03 19:03:38 +00:00
Russ Housley 8c7e75101d Allow Secretariat to handle downrefs when they approve a document 
- Legacy-Id: 16126
 2019-04-01 19:46:14 +00:00
Robert Sparks fbfd204eb9 Include the note itself in email sent when the RFC editor note changes after document approval. Also changed the flow to redirect back to the writeups pages after editing the RFC editor note. Fixes #2672. Commit ready for merge. 
- Legacy-Id: 16110
 2019-03-28 10:07:11 +00:00
Robert Sparks 003e472d04 Protect drafts in certain IRTF states from expiring. Fixes #2669. Commit ready for merge. 
- Legacy-Id: 16109
 2019-03-28 08:48:35 +00:00
Peter E. Yee cfdbae1f3c Fixed bad calls to rfcdiff for -00 drafts and replaced drafts. Fixes issue #2697. Commit ready for merge. 
- Legacy-Id: 16095
 2019-03-23 18:17:51 +00:00
Robert Sparks 81c5b5091a Made some docevent creation more consistent. Addressed the TODOs added during the refactor. 
- Legacy-Id: 16049
 2019-03-19 18:48:05 +00:00
Robert Sparks f57fb6b8a6 Added the ability to withdraw individual assignments. Added the ability to mark individual assignments no-response. 
- Legacy-Id: 16039
 2019-03-18 21:15:20 +00:00
Robert Sparks da3174ab68 Improved several views. 
- Legacy-Id: 16038
 2019-03-18 19:41:07 +00:00
Robert Sparks 4b147f2ef8 More cleanup and correction. Caught a pervasive misuse of a state-name 
- Legacy-Id: 16036
 2019-03-15 20:39:06 +00:00
Henrik Levkowetz 56543d565c Changed sending of PubReq messages to explicitly use on-behalf-of, without Reply-To. Reply-To is picked up as requestor by RT. Fixes issue #2691 anew. 
- Legacy-Id: 16034
 2019-03-14 21:31:40 +00:00
Robert Sparks 334767fa6f Some admin tweaks and removal of a dead template. Tests all pass now. Functionality is still not right. 
- Legacy-Id: 16032
 2019-03-14 19:14:33 +00:00
Robert Sparks 0856990683 Checkpoint. Most tests do not fail. Oddness with an API resource, and with one template's coverage 
- Legacy-Id: 16031
 2019-03-14 18:39:40 +00:00
Robert Sparks a4db66564c Checkpoint. Ended up chasing group.views_review before stats. 
- Legacy-Id: 16030
 2019-03-13 22:02:10 +00:00
Robert Sparks 073ce55f6c Checkpoint. ReviewTests pass, but others still fail of course. Next step is to address stats. 
- Legacy-Id: 16021
 2019-03-12 17:48:19 +00:00
Henrik Levkowetz 682ddee8e4 Reverted earlier application of on_behalf_of() at mail sending call points, and instead did all on_behalf_of processing in condition_message(). Added insertion of Reply-To header fields in this case. Changed all use of the mail-sending 'extra' parameters to use value lists. Updated a bunch of tests accordingly. 
- Legacy-Id: 16020
 2019-03-11 17:01:33 +00:00
Henrik Levkowetz df42be5d0c Converted a test to use .assertIn() instead of .assertTrue(... in ...) for better failure reports. 
- Legacy-Id: 16016
 2019-03-09 14:56:47 +00:00
Robert Sparks b85052fe63 Checkpoint. Lots of tests will still fail. Reordered some migrations. Brought about half of the ietf.doc.views_review views into line with the new models. Next step is the other half. 
- Legacy-Id: 16012
 2019-03-07 23:08:14 +00:00
Henrik Levkowetz 896f4cd8c7 Fixed a test discrepancy. 
- Legacy-Id: 15995
 2019-03-05 16:19:28 +00:00
Henrik Levkowetz 55bd2e5e42 Fixed some unintentional wg list address changes, and added some other test mail address changes. 
- Legacy-Id: 15994
 2019-03-04 20:54:38 +00:00
Henrik Levkowetz 435a0da12d Added on_behalf_of() calls for from addresses needing it throughout the code. 
- Legacy-Id: 15992
 2019-03-04 20:14:19 +00:00
Henrik Levkowetz 2b811b3d3d Updated the tests to always use @ietf.org addresses where appropriate, and not do so when not appropriate. All test user login addresses have been changed away from @ietf.org. 
- Legacy-Id: 15988
 2019-03-04 20:08:48 +00:00
Robert Sparks 82025f9dca Continuing to checkpoint. 
- Legacy-Id: 15986
 2019-03-01 23:23:39 +00:00
Robert Sparks e91d706d5b Checkpointing. This is an incomplete idea. The tests will fail massively. 
- Legacy-Id: 15985
 2019-03-01 23:19:47 +00:00
Henrik Levkowetz c9db218e31 Increased the DocumentURL.url field length to the legal URL maximum of 2083 
- Legacy-Id: 15972
 2019-02-25 21:05:25 +00:00
Henrik Levkowetz b57ad67041 Updated code and templates to use the new docman and groupman group features. 
- Legacy-Id: 15922
 2019-01-30 15:59:00 +00:00
Henrik Levkowetz ef97f2a821 Merged in GroupFeatures refactoring and expansion from ^/personal/henrik/6.89.4.dev0@15911. 
- Legacy-Id: 15912
 2019-01-24 15:25:01 +00:00
Henrik Levkowetz c87d3741f3 Added 2 utility functions to help create group features query filters, and applied them in 3 places in order to move group feature role list code back into DB queries. 
- Legacy-Id: 15911
 2019-01-23 18:40:39 +00:00
Henrik Levkowetz 57a4c9f41f Added 9 new group features, and changed list-like char fields to json fields, to get better support for using the values as lists. Modified code to use the group features instead of explicit lists of group types in many places in the code. 
- Legacy-Id: 15908
 2019-01-22 18:11:46 +00:00
Henrik Levkowetz f671e391f7 Reverted r15071 with respects to showing the submit for publication button to shepherds. Fixes issue #2673. 
- Legacy-Id: 15906
 2019-01-21 12:32:13 +00:00
Henrik Levkowetz b4e46cd559 Migration reordering to avoid schema migrations after data migrations. 
- Legacy-Id: 15881
 2019-01-14 14:22:13 +00:00
Robert Sparks 87dd249415 Cleanup: removed the infrastructure for importing reviews from the old review tool. Commit ready for merge. 
- Legacy-Id: 15865
 2019-01-03 21:04:13 +00:00
Robert Sparks 25cc00f925 Refactored DocumentInfo to address overloading the external_url field with strings that are not URLs. Commit ready for merge. 
- Legacy-Id: 15864
 2019-01-02 22:55:00 +00:00
Robert Sparks f6886f6105 Corrected a conditional expression and improved the test that exercised it. Commit ready for merge. 
- Legacy-Id: 15822
 2018-12-14 21:50:21 +00:00
Robert Sparks 6118975620 Added an explicit ID-Exists state for the IESG state machine. Reworked code so that the IESG state machine always has a state. Added the ability to release a document from a working group, research group, or the independent stream. Releasing a document removes all stream state, and sets the document to have no stream. 
- Legacy-Id: 15809
 2018-12-11 22:38:05 +00:00
Henrik Levkowetz d2b86bc225 Increased the document limit from 200 to 500 for the AD documents page. 
- Legacy-Id: 15788
 2018-11-26 18:52:18 +00:00
Henrik Levkowetz 68c48f19a0 Improved resolution of an issue with the To: and Cc: addresses of extra review email to responsible AD. 
- Legacy-Id: 15778
 2018-11-20 13:36:12 +00:00
Henrik Levkowetz 9821406f60 Fixed an issue with the To: and Cc: addresses of extra review email to responsible AD. 
- Legacy-Id: 15777
 2018-11-20 13:20:16 +00:00
Henrik Levkowetz 143a58d3cc Added handling for an EOF exception that can occur when using the django file-based cache. 
- Legacy-Id: 15769
 2018-11-13 13:39:47 +00:00
Henrik Levkowetz 13b20f83cb Merged in [15720] from rjsparks@nostrum.com: 
invalidate the get_state_slug cache when the get_state cache is invalidated. Fixes #2630.
 - Legacy-Id: 15760
Note: SVN reference [15720] has been migrated to Git commit f1c1b9fc6c
 2018-11-12 15:38:17 +00:00
Henrik Levkowetz 3b811ecb41 Merged in [15708] and [15730] from housley@vigilsec.com: 
Added a mail alias for all review team secretaries. Fixes #2139.  Use
the alias if there is one for email about review request changes.  Added
a test for the review team secretary alias functionality.
 - Legacy-Id: 15746
Note: SVN reference [15708] has been migrated to Git commit 6067dcbfef

Note: SVN reference [15730] has been migrated to Git commit d525ade0b0
 2018-11-10 19:30:32 +00:00
Henrik Levkowetz 0d9c97c5ca Added a test that checks the mailarch search failure return, and tweaks the no-result return handling. 
- Legacy-Id: 15745
 2018-11-10 19:06:40 +00:00
Henrik Levkowetz 236ee7639d Merged in [15706] from kivinen@iki.fi: 
Added easier to detect error message when search returns 0 results. This currently parses html result from the mailarchive system, but when we get proper API to mailarchive system it should be changed to do that instead. Fixes #2126.
 - Legacy-Id: 15744
Note: SVN reference [15706] has been migrated to Git commit f9eeee0cc9
 2018-11-09 21:23:45 +00:00
Henrik Levkowetz 89ef806013 Merged in [15701] from kivinen@iki.fi: 
Changed format of the reviewer statistics in lists. Fixes #2131.
 - Legacy-Id: 15735
Note: SVN reference [15701] has been migrated to Git commit 56acd00c6c
 2018-11-07 05:24:25 +00:00
Russ Housley d525ade0b0 Use review team secretary alias if there is one for email about review request changes. Add test for review team secretary alias. Commit ready for merge. 
- Legacy-Id: 15730
 2018-11-06 07:26:30 +00:00
Henrik Levkowetz e4af908a74 Merged in [15698] from rjsparks@nostrum.com: 
Notify the RFC Editor when an RFC Editor note is changed after a draft has been approved. Fixes #2440.
 - Legacy-Id: 15729
Note: SVN reference [15698] has been migrated to Git commit 43374969f6
 2018-11-06 07:13:56 +00:00
Robert Sparks f1c1b9fc6c invalidate the get_state_slug cache when the get_state cache is invalidated. Fixes #2630. Commit ready for merge. 
- Legacy-Id: 15720
 2018-11-05 22:43:02 +00:00
Tero Kivinen f9eeee0cc9 Added easier to detect error message when search returns 0 results. This currently parses html result from the mailarchive system, but when we get proper API to mailarchive system it should be changed to do that instead. Fixes #2126. Commit ready for merge. 
- Legacy-Id: 15706
 2018-11-03 11:08:18 +00:00
Tero Kivinen 56acd00c6c Changed format of the reviewer statistics in lists. Fixes #2131. Commit ready for merge. 
- Legacy-Id: 15701
 2018-11-03 09:04:57 +00:00
Henrik Levkowetz 3b8d9ae832 Merged in [15684] from rjsparks@nostrum.com: 
Removed the field and widget that made editing document states easier on the document admin page since they do not survive validation failure of other fields on the form. Excluded states from the modelform since the default states widget is almost impossible to use without producing bad data. If states need to be edited through the admin, it will, for now, need to be done gruelingly through the admin form for State. Fixes #2524.
 - Legacy-Id: 15700
Note: SVN reference [15684] has been migrated to Git commit 128c0a6dbb
 2018-11-03 09:01:59 +00:00
Robert Sparks 43374969f6 Notify the RFC Editor when an RFC Editor note is changed after a draft has been approved. Fixes #2440. Commit ready for merge. 
- Legacy-Id: 15698
 2018-11-03 08:13:10 +00:00
Robert Sparks 5db8831b81 Clearly label cancelled sessions on the week-view on the agenda page. Fixes #2619. Commit ready for merge. 
- Legacy-Id: 15694
 2018-11-03 06:57:59 +00:00
Henrik Levkowetz 95161df4f4 Merged in [15679] from mahoney@nostrum.com: 
Verb tense used in Ballot Issued emails now matches whether the LC end date is in the past or future. Fixes issue #2482.
 - Legacy-Id: 15685
Note: SVN reference [15679] has been migrated to Git commit 194d8c89d1
 2018-11-03 04:37:41 +00:00
Robert Sparks 128c0a6dbb Removed the field and widget that made editing document states easier on the document admin page since they do not survive validation failure of other fields on the form. Excluded states from the modelform since the default states widget is almost impossible to use without producing bad data. If states need to be edited through the admin, it will, for now, need to be done gruelingly through the admin form for State. Fixes #2524. Commit ready for merge. 
- Legacy-Id: 15684
 2018-11-03 04:28:50 +00:00
Jean Mahoney 194d8c89d1 Verb tense used in Ballot Issued emails now matches whether the LC end date is in the past or future. Fixes issue #2482. Commit ready for merge. 
- Legacy-Id: 15679
 2018-11-03 03:38:52 +00:00
Robert Sparks b76ea7bcd5 Let a reviewer indicate that an AD should give this review early attention. Fixes #2553. Commit ready for merge. 
- Legacy-Id: 15676
 2018-11-02 21:23:27 +00:00
Robert Sparks c7bf147b1d Let review teams opt in to poking a responsible AD when unhappy reviews are submitted. Fixes #2544. Commit ready for merge. 
- Legacy-Id: 15675
 2018-11-02 20:18:06 +00:00
Henrik Levkowetz 282a410f3f Merged in [15613] from rjsparks@nostrum.com: 
Make having a trailing slash optional for doc/html/docname. Fixes #2247.
 - Legacy-Id: 15618
Note: SVN reference [15613] has been migrated to Git commit 7593230edde63d4d2e8ec04c455e862aa5e71f21
 2018-10-30 14:02:46 +00:00
Henrik Levkowetz 90e773aafa Merged in [15601] from rjsparks@nostrum.com: 
Corrected some DocTypeName entries' prefix value. Made the search code more robust against DocTypeName objects that have an empty prefix value. Fixes #2599.
 - Legacy-Id: 15604
Note: SVN reference [15601] has been migrated to Git commit 22d459362aec2a06854a515fbcebfec54e8a6e69
 2018-10-21 12:36:01 +00:00
Henrik Levkowetz 3508f59f52 Merged in [15596] from rjsparks@nostrum.com: 
improved coverage for several tests.
 - Legacy-Id: 15600
Note: SVN reference [15596] has been migrated to Git commit 6f18ae882532433ba86322b33c34f5f1b0350cb9
 2018-10-19 14:27:13 +00:00
Henrik Levkowetz ef3cbf4684 Merged in [15595] from rjsparks@nostrum.com: 
Converted stats, submit, sync. and utils/test to use factories. Excluded utils/test_data from coverage checks.
 - Legacy-Id: 15599
Note: SVN reference [15595] has been migrated to Git commit 39e76a836996ec9ed8ea449c92bdfae91c3dbaae
 2018-10-19 12:54:58 +00:00
Henrik Levkowetz 15c8ab9506 Ensure the send_mail argument to save_position is a boolean. 
- Legacy-Id: 15547
 2018-10-09 16:34:45 +00:00
Henrik Levkowetz 22a2e29db8 Added an send_email field to BallotPostitionDocEvent to reflect whether the 'Send email' button was used to save the ballot position. Reverted a different earlier schema change which had the same purpose. Added icons on documents' IESG evaluation record to reflect this. 
- Legacy-Id: 15526
 2018-10-07 15:08:17 +00:00
Henrik Levkowetz 9e0e5d66b3 Merged in [15492] from rjsparks@nostrum.com: 
Use factories for ipr tests.
 - Legacy-Id: 15516
Note: SVN reference [15492] has been migrated to Git commit 775addc616
 2018-10-01 17:51:17 +00:00
Henrik Levkowetz cfb214c48a Added a BallotCommentDocEvent, which extends DocEvent with a send_mail field, in order to better be able to show whether ballot discusses and comments were posted with with the 'send email' button or not. 
- Legacy-Id: 15515
 2018-10-01 13:31:17 +00:00
Robert Sparks 775addc616 Use factories for ipr tests. Commit ready for merge. 
- Legacy-Id: 15492
 2018-09-28 23:16:46 +00:00
Henrik Levkowetz 89b8fe6c1b Moved document methods rfc_number() and rfcnum() to the abstract parent class to have them available also for historical document records. Should fix the recent server 500 on /doc/draft-ietf-aaa-diameter/17/. 
- Legacy-Id: 15454
 2018-09-14 20:29:07 +00:00
Robert Sparks d9b53a5d6c Use unversioned links in ics agendas. Partially fixes #2542. Commit ready for merge. 
- Legacy-Id: 15446
 2018-09-10 20:12:09 +00:00
Robert Sparks fd8af4b6f7 Review assignment email includes a link to the review request that ensures the reviewer is logged in. Fixes #2543. Commit ready for merge 
- Legacy-Id: 15444
 2018-09-06 21:39:10 +00:00
Henrik Levkowetz caa3ec98b4 Changed the menu listing of review dirs and their display on the Directorates page back to what it was before the 'reviews' group type was split out. Added a 'Reviews' column to the Directoratges page. 
- Legacy-Id: 15420
 2018-08-01 18:53:44 +00:00
Henrik Levkowetz 70c5dcc8c4 Merged in [15387] from rjsparks@nostrum.com: 
Use factories for ietf.iesg.tests.
 - Legacy-Id: 15406
Note: SVN reference [15387] has been migrated to Git commit 705e4c84d9
 2018-07-24 08:25:07 +00:00
Henrik Levkowetz ac55203499 Merged in [15380] from rjsparks@nostrum.com: 
Use factories for ietf.idindex.tests.
 - Legacy-Id: 15405
Note: SVN reference [15380] has been migrated to Git commit 2159fdd975
 2018-07-24 07:22:26 +00:00
Henrik Levkowetz 85aa1ecc25 Tweaked a test to prevent failures when looking for a specific string in line-wrapped text. 
- Legacy-Id: 15397
 2018-07-19 15:54:18 +00:00
Robert Sparks 705e4c84d9 Use factories for ietf.iesg.tests. Commit ready for merge. 
- Legacy-Id: 15387
 2018-07-19 13:13:05 +00:00
Henrik Levkowetz db2c326e73 Merged in [15354] from kivinen@iki.fi: 
Added default to review completion draft version number. If the reviewer
is filling in the review form himself the default will be the latest
version of the draft. If it is someone else filling in the review
then the version number is the latest version at the point when review
was assigned (i.e., it assumes reviewer did review on version he was
requested to and then document authors might have updated the document).
Also mark the document versions that are earlier than the review request
date with red background and those which are newer with green background.
Fixes #2125.
 - Legacy-Id: 15386
Note: SVN reference [15354] has been migrated to Git commit dc3e8ee810
 2018-07-18 22:36:01 +00:00
Henrik Levkowetz b054a142d9 Merged in [15349] from kivinen@iki.fi: 
Removed the requirement for review_content field to be mandatory when
using \'link\' method. This partially addresses #2520. Commit ready for
merge.
 - Legacy-Id: 15383
Note: SVN reference [15349] has been migrated to Git commit 0783890fa5
 2018-07-18 18:20:21 +00:00
Henrik Levkowetz e8e2db50b3 Merged in [15347] from kivinen@iki.fi: 
Add review request date to the top. Add tooltips for drafts versions
providing the date they were sumbmitted. Fixes #2218. Commit ready for
merge.
 - Legacy-Id: 15382
Note: SVN reference [15347] has been migrated to Git commit dcabfc84f1
 2018-07-18 16:36:35 +00:00
Robert Sparks 2159fdd975 Use factories for ietf.idindex.tests. Commit ready for merge. 
- Legacy-Id: 15380
 2018-07-18 15:35:20 +00:00
Henrik Levkowetz 7abece146c Merged in [15344] from mahoney@nostrum.com: 
email confirming interim meeting request now says 'the Area Director of the <area>' instead of '<area> Area Director'. Fixes issue #2522.
 - Legacy-Id: 15378
Note: SVN reference [15344] has been migrated to Git commit 3c478e5c52
 2018-07-18 13:16:02 +00:00
Henrik Levkowetz 5b77d01a48 Merged in [15331] from housley@vigilsec.com: 
Add test for downref in Last Call announcement
 - Legacy-Id: 15366
Note: SVN reference [15331] has been migrated to Git commit e2808b1c0b
 2018-07-16 16:54:56 +00:00
Tero Kivinen dc3e8ee810 Added default to review completion draft version number. If the reviewer 
is filling in the review form himself the default will be the latest
version of the draft. If it is someone else filling in the review
then the version number is the latest version at the point when review
was assigned (i.e., it assumes reviewer did review on version he was
requested to and then document authors might have updated the document).
Also mark the document versions that are earlier than the review request
date with red background and those which are newer with green background.
Fixes #2125. Commit ready for merge.
 - Legacy-Id: 15354
 2018-07-14 21:54:04 +00:00
Tero Kivinen 0783890fa5 Removed the requirement for review_content field to be mandatory when 
using "link" method. This partially addresses #2520. Commit ready for
merge.
 - Legacy-Id: 15349
 2018-07-14 20:12:32 +00:00
Tero Kivinen dcabfc84f1 Add review request date to the top. Add tooltips for drafts versions 
providing the date they were sumbmitted. Fixes #2218. Commit ready for
merge.
 - Legacy-Id: 15347
 2018-07-14 20:07:36 +00:00
Jean Mahoney 3c478e5c52 email confirming interim meeting request now says 'the Area Director of the <area>' instead of '<area> Area Director'. Fixes issue #2522. Commit ready to merge. 
- Legacy-Id: 15344
 2018-07-14 18:52:38 +00:00
Russ Housley e2808b1c0b Add test for downref in Last Call announcement 
- Legacy-Id: 15331
 2018-07-14 16:41:22 +00:00
Henrik Levkowetz 2daef52bea This commit replaces the code defined group features with features held 
in a database table:

- Added a GroupFeatures model to the group models, and removed the old 
  features.py
- Added a agenda type for future use in showing different group types on
  different agendas.
- Renamed the group feature has_materials to has_nonsession_materials.
- Added API resources and admin support for the new tables.
- Added a Directorate (with reviews) group type as complement to
  Directorate, to distinguish between directorates with and without reviews.
- Adjusted tests as needed.
- Updated the fixtures, and fixed the generate_fixtures script to include
  the new AgendaTypeName objects.

There still exists about 70 instances of code comparing the group type
with a list of types; most of these should probably be replaced with new
features, instead, to make it possible to add new group types through the
database table, rather than having to edit the code.  That was the purpose
of this refactoring from the start, but the presence of this large number
of comparisons of group type against lists of types defeats the goal until
we add appropriate features and replace the group type list comparisons.
 - Legacy-Id: 15316
 2018-07-12 10:51:48 +00:00
Henrik Levkowetz 9fe1820640 Tweaked the 'Related documents' part of the Document admin page to more intuitively show the relationships. 
- Legacy-Id: 15259
 2018-06-14 19:22:55 +00:00
Henrik Levkowetz 41a5f5dca4 Merged in [15248] from rjsparks@nostrum.com: 
Improvements to tests after converting to factories suggested by studying coverage_changes.
 - Legacy-Id: 15255
Note: SVN reference [15248] has been migrated to Git commit b86bd84278
 2018-06-14 13:11:29 +00:00
Henrik Levkowetz b3301de22e Fixed a pyflakes nit. 
- Legacy-Id: 15253
 2018-06-14 12:35:16 +00:00
Henrik Levkowetz a3c12d937f Removed two instances of log.assertion(); we have enough data on these now. 
- Legacy-Id: 15252
 2018-06-14 12:03:02 +00:00
Robert Sparks b86bd84278 Improvements to tests after converting to factories suggested by studying coverage_changes. Commit ready to merge. 
- Legacy-Id: 15248
 2018-06-13 22:09:01 +00:00
Robert Sparks 340b6591b2 Use factories for ietf.doc.tests_status_change. Repair previous commit errors in ietf.doc.tests_material. Commit ready for merge. 
- Legacy-Id: 15238
 2018-06-09 22:16:26 +00:00
Robert Sparks a2fa0d6400 Use factories for ietf.doc.tests_material and ietf.doc.tests_review. Commit ready for merge. 
- Legacy-Id: 15237
 2018-06-09 21:20:37 +00:00
Robert Sparks 3eeece797a Use factories for ietf.doc.tests_downref. Commit ready for merge. 
- Legacy-Id: 15228
 2018-06-08 14:42:45 +00:00
Robert Sparks 67df7bd8cf Use factories for ietf.doc.tests_conflict_review. Commit ready for merge. 
- Legacy-Id: 15227
 2018-06-08 00:13:00 +00:00
Robert Sparks 880dafdb24 Use factories for ietf.doc.tests_charter. Commit ready for merge. 
- Legacy-Id: 15226
 2018-06-07 23:50:27 +00:00
Robert Sparks 6f011a3e56 Use factories for ietf.doc.tests_draft. Commit ready for merge. 
- Legacy-Id: 15225
 2018-06-07 22:03:09 +00:00
Robert Sparks dcf9e6b40f Use factories for ietf.doc.tests_ballots. Fixed a long-hidden bug in test_edit_verify_permissions where non-existing usernames were used and passed the tests accidently. Added list_email to the GroupFactory. Commit ready for merge. 
- Legacy-Id: 15219
 2018-06-06 17:59:40 +00:00
Robert Sparks a064e28926 Factoryalized the rest of ietf.doc.tests. Created draft type specific factories. Commit ready for merge. 
- Legacy-Id: 15217
 2018-06-05 21:17:28 +00:00
Robert Sparks 984806de2d Trivial commit removing some recently commented out code. Commit ready for merge. 
- Legacy-Id: 15209
 2018-06-04 15:16:47 +00:00
Robert Sparks 84d3c92298 more factoryization of ietf.doc.tests. Commit ready for merge. 
- Legacy-Id: 15205
 2018-06-02 13:39:39 +00:00
Robert Sparks 4e7743c009 More factorization of ietf.doc.tests. Commit ready for merge. 
- Legacy-Id: 15204
 2018-06-01 21:39:22 +00:00
Robert Sparks 4a4a152c9a Use factories for the rest of the tests in ietf.doc.tests.SearchTests. Commit ready for merge. 
- Legacy-Id: 15203
 2018-06-01 18:54:26 +00:00
Robert Sparks 0a1d9ecd2a Converted test_search_for_name to use factories. Commit ready for merge. 
- Legacy-Id: 15202
 2018-06-01 15:52:57 +00:00
Robert Sparks 54afc41f8e Converted test_search to use factories. Commit ready for merge. 
- Legacy-Id: 15201
 2018-06-01 15:16:32 +00:00
Henrik Levkowetz 4db4dd16b0 Merged in ^/personal/henrik/6.79.1-gdpr@15180 containing GDPR-adaptations. 
- Legacy-Id: 15181
 2018-05-28 11:26:24 +00:00
Henrik Levkowetz 81e78c70a0 Added guards against asking for properties on None in a couple of places. 
- Legacy-Id: 15173
 2018-05-26 08:34:27 +00:00
Henrik Levkowetz 2522082979 Changed the email origin field during test to hold user.username in order to exercise more of the code. Changed the EmailFactory to also use user.username as origin. 
- Legacy-Id: 15172
 2018-05-26 08:32:20 +00:00
Robert Sparks 6b779e9d4c Send email when the responsible AD for a conflict review is changed. Include the stream manager and stream steering group when the responsible AD changes or when the telechat date changes. Fixes #2497. Commit ready for merge. 
- Legacy-Id: 15152
 2018-05-21 22:02:34 +00:00
Henrik Levkowetz 6c3ec5b18e Added Email origin to Email record creation throughout the codebase. 
- Legacy-Id: 15149
 2018-05-17 16:56:26 +00:00
Henrik Levkowetz a66639299d Removed all references to the removed Person.affiliation field. 
- Legacy-Id: 15129
 2018-05-05 12:47:55 +00:00
Henrik Levkowetz 5f37a71889 Added origin information to all places where we create email address entries. 
- Legacy-Id: 15127
 2018-05-05 12:40:30 +00:00
Robert Sparks 1c16926ee6 Missed adding the migrations. Related to #1963. Commit ready for merge. 
- Legacy-Id: 15120
 2018-05-03 21:23:07 +00:00
Robert Sparks 1295f1f1d2 Change stream state to replaced when an ISE, IAB, or IRTF document is replaced. Fixes #1963. Commit ready for merge. 
- Legacy-Id: 15119
 2018-05-03 21:21:38 +00:00
Robert Sparks 8436078af6 Made settings.URL_REGEXPS.name non-greedy. Added a test to exercise the bug at #2429. Fixes #2429. Commit ready for merge. 
- Legacy-Id: 15110
 2018-05-03 15:39:00 +00:00
Henrik Levkowetz d076a1728c Added a 'recent drafts' page, showing drafs submitted the last 7 days. 
- Legacy-Id: 15099
 2018-05-01 17:55:22 +00:00
Henrik Levkowetz 53c4ac36db Removed the Person.address field, which is not being used. This was a legacy from the 2001 perl-based datatracker tables. Fixes issue #2504. 
- Legacy-Id: 15095
 2018-04-27 14:00:33 +00:00
Henrik Levkowetz 198c003b6a Merged in [15084] from rjsparks@nostrum.com: 
Corrected the implementation of clear_ballot. Added a test for it. Restored functionality to ballot popups that was missing because a template variable was not passed in.
 - Legacy-Id: 15092
Note: SVN reference [15084] has been migrated to Git commit ee346edaba
 2018-04-26 13:41:22 +00:00
Henrik Levkowetz d994a58474 Merged in [15083] from rjsparks@nostrum.com: 
Removed memoize from latest_event.
 - Legacy-Id: 15091
Note: SVN reference [15083] has been migrated to Git commit 1735f86db0
 2018-04-26 12:51:45 +00:00
Henrik Levkowetz c02f8fe331 Merged in [15080] from rjsparks@nostrum.com: 
Marked a couple of functions as unreachable.
 - Legacy-Id: 15089
Note: SVN reference [15080] has been migrated to Git commit 7df28d8bac
 2018-04-26 12:08:07 +00:00
Henrik Levkowetz c7350be50f Reverted a change to UserFactory to avoid nepalese names. The issue is bigger, and needs a different resulution. Changed the url pattern that used \w to match names to instead use a more inclusive regex. 
- Legacy-Id: 15088
 2018-04-26 11:53:51 +00:00
Robert Sparks ee346edaba Corrected the implementation of clear_ballot. Added a test for it. Restored functionality to ballot popups that was missing because a template variable was not passed in. Commit ready for merge. 
- Legacy-Id: 15084
 2018-04-25 19:52:44 +00:00
Robert Sparks 1735f86db0 Removed memoize from latest_event. Commit ready for merge. 
- Legacy-Id: 15083
 2018-04-25 18:15:23 +00:00
Henrik Levkowetz 8e43e7aed0 Merged in [15075] from rjsparks@nostrum.com: 
Improved testing for docs_for_ad.
 - Legacy-Id: 15082
Note: SVN reference [15075] has been migrated to Git commit b7375412ab
 2018-04-25 17:21:33 +00:00
Robert Sparks 7df28d8bac Marked a couple of functions as unreachable. Commit ready for merge. 
- Legacy-Id: 15080
 2018-04-25 15:10:55 +00:00
Henrik Levkowetz e1eb39b478 Merged in [15074] from rjsparks@nostrum.com: 
Simplified docs_in_iesg_process. Added a test for it.
 - Legacy-Id: 15079
Note: SVN reference [15074] has been migrated to Git commit 57f548ecbd
 2018-04-25 13:17:59 +00:00
Henrik Levkowetz 227cb0db4d Merged in [15073] from rjsparks@nostrum.com: 
Rearranged ietf/doc/urls.py to allow matching some special pages under /doc without a trailing slash. Adjusted several of those special URLs to work without the trailing slash.
 - Legacy-Id: 15078
Note: SVN reference [15073] has been migrated to Git commit da25919f08
 2018-04-24 21:27:04 +00:00
Robert Sparks b7375412ab Improved testing for docs_for_ad. 
- Legacy-Id: 15075
 2018-04-24 19:22:09 +00:00
Robert Sparks 57f548ecbd Simplified docs_in_iesg_process. Added a test for it. 
- Legacy-Id: 15074
 2018-04-24 18:27:19 +00:00
Robert Sparks da25919f08 Rearranged ietf/doc/urls.py to allow matching some special pages under /doc without a trailing slash. Adjusted several of those special URLs to work without the trailing slash. 
- Legacy-Id: 15073
 2018-04-24 18:00:59 +00:00
Henrik Levkowetz 28f4c52c20 Added permission for a document shepherd to request publication. Fixes issue #2509. 
- Legacy-Id: 15071
 2018-04-23 20:41:04 +00:00
Henrik Levkowetz c124a018e8 Fixed a typo. Fixes issue #2500. 
- Legacy-Id: 15061
 2018-04-20 13:06:21 +00:00
Henrik Levkowetz 12d999a384 Modified the IESG position setting API to send email messages about positions set. 
- Legacy-Id: 15050
 2018-04-17 11:57:16 +00:00
Henrik Levkowetz 2ed9face25 Modified the IESG position setting API to send email messages about positions set. 
- Legacy-Id: 15049
 2018-04-17 11:38:40 +00:00
Henrik Levkowetz 1591b3ebd2 Fixed an issue where simplified sorting of DocEvents resulted in some ballot icons not being shown on the IESG agenda documents page. 
- Legacy-Id: 15046
 2018-04-16 10:38:08 +00:00
Henrik Levkowetz a9fbea113b Changed incorrect use of 404 status code in api to 400. Fixes issue #2498. 
- Legacy-Id: 15044
 2018-04-13 11:11:48 +00:00
Henrik Levkowetz b5d62973c7 Tweaked the error return from Document.get_document_content() to be more helpful during development. 
- Legacy-Id: 15034
 2018-04-09 14:01:37 +00:00
Henrik Levkowetz ea7728b501 Changed calls to .related_that*() and .relations_that*() to use tuples rather than lists (a slight optimization). 
- Legacy-Id: 15029
 2018-04-07 10:47:16 +00:00
Henrik Levkowetz bac162d0d0 Reduced the max number of results returned by document searches from 500 to 200, for a better user experience. A faster return and a search term tweak to pinpoint the desired search result is better than a long wait and then maybe having to tweak the search terms anyway. 
- Legacy-Id: 15027
 2018-04-07 10:12:13 +00:00
Henrik Levkowetz 96e4059e43 Undid some memoization; these values can change during an object's lifetime. 
- Legacy-Id: 15025
 2018-04-07 10:07:57 +00:00
Henrik Levkowetz 5446ae642a Changed the signature of some document methods to not accept lists (but still accept tuples) in order to make caching possible. Added @memoize to some methods. 
- Legacy-Id: 15024
 2018-04-06 21:25:56 +00:00
Henrik Levkowetz d44c2dc92c Added another prefetch to search doc query results. 
- Legacy-Id: 15023
 2018-04-06 21:24:07 +00:00
Henrik Levkowetz 6b27daa58a Imposed sort order (most recent docs first) on document search results, in order to retain the most recent docs in case we have to chop the result list due too many hits. 
- Legacy-Id: 15022
 2018-04-06 21:23:14 +00:00
Henrik Levkowetz 248c2dd055 Added back the on-agenda calendar links to document lists, now in an implementation with better performance characteristics. 
- Legacy-Id: 15020
 2018-04-06 15:17:18 +00:00
Henrik Levkowetz 583d8882c5 Fixed an issue where the change of slide naming between IETF 96 and 97 caused the datatracker to not provide correct link to pre-IETF-97 materials. Thanks to tjw.ietf@gmail.com for the heads-up. 
- Legacy-Id: 15017
 2018-04-05 20:34:56 +00:00
Henrik Levkowetz 6a32a363cc Merged in [15012] from ford@isoc.org: 
Add IRTF State option to Additional Search Criteria pulldown.
 - Legacy-Id: 15016
Note: SVN reference [15012] has been migrated to Git commit cd912600e6
 2018-04-05 14:50:40 +00:00
Mat Ford cd912600e6 Add IRTF State option to Additional Search Criteria pulldown. Commit ready for merge. 
- Legacy-Id: 15012
 2018-04-05 11:56:37 +00:00
Henrik Levkowetz 421621eb51 Another round of iesg page optimizations. Reduced additional instances of individual lookups to a single lookup followed by annotation of document objects. Reduced several instances of repeating the same work multiple times (queries for telechat documents, queries for telechat dates). 
- Legacy-Id: 15010
 2018-04-05 11:03:26 +00:00
Henrik Levkowetz 67a17bb227 Fixed a number of tests to deal correctly with model method caching. 
- Legacy-Id: 15009
 2018-04-05 10:55:27 +00:00
Henrik Levkowetz 15d45b4d22 Changed the ballot_icon template tag to use an already found ballot if available, rather than doing lookups to find it (twice!). 
- Legacy-Id: 15007
 2018-04-04 17:12:08 +00:00
Henrik Levkowetz 1ec98fdd59 Added @memoize to two Document methods 
- Legacy-Id: 15006
 2018-04-04 17:10:06 +00:00
Henrik Levkowetz 43a9291053 Added an index for (doc, type) on DocEvent to speed up latest_event() queries. 
- Legacy-Id: 14990
 2018-04-01 19:33:16 +00:00
Henrik Levkowetz 675c652052 Additional changes to speed up the IESG agenda docs page: Changed telechat_page_count() to accept a list of documents if that's already been generated, to avoid double work. Changed the reviewed_by_teams list to provide acronyms directly, to avoid group lookups during template rendering. Provided page counts directly to the template instead of repeated (costly) filtering through telechat_page_count, with new document lookups. Removed the telechat_page_count template filter, due to its cost. Tweaked some lookups in fill_in_document_table_attributes() . Added to the select_related() list for documents in IESG agenda_documents(). 
- Legacy-Id: 14988
 2018-04-01 18:51:48 +00:00
Henrik Levkowetz 60a60de94b Replaced inline database lookups with get_active_ads(). 
- Legacy-Id: 14987
 2018-04-01 18:38:50 +00:00
Henrik Levkowetz db3a4eb20e Changed some instances of .slug to _id 
- Legacy-Id: 14985
 2018-04-01 18:32:27 +00:00
Henrik Levkowetz 4c297ba4c0 Changed settings so that cache keys used by memcached includes the release version, in order to avoid stale and incorrect cache content on new release deployment. Made it easier to pick out cache key composition by normalizing the variable name. Adjusted cache prefix and the composition of some keys to have a unique and consistent cache key prefix. 
- Legacy-Id: 14943
 2018-03-26 21:26:20 +00:00
Henrik Levkowetz c0eb9e3aa6 Merged in [14899] from rjsparks@nostrum.com: 
Cleaner charter factory simplifies test code.
 - Legacy-Id: 14914
Note: SVN reference [14899] has been migrated to Git commit 8026f86cd3
 2018-03-24 21:24:03 +00:00
Henrik Levkowetz cc717946f5 Merged in [14896] from rjsparks@nostrum.com: 
Improved test coverage for ietf/doc/views_charter.py.
 - Legacy-Id: 14912
Note: SVN reference [14896] has been migrated to Git commit f11907b6a0
 2018-03-24 17:54:14 +00:00
Henrik Levkowetz 6d5f604d5b Tweaked the document list iCalendar links to not show for presentations on days in the past. 
- Legacy-Id: 14908
 2018-03-24 15:29:10 +00:00
Henrik Levkowetz f48669a8e4 Merged in [14884] from adam@nostrum.com: 
Adding page count to last call page.
 - Legacy-Id: 14907
Note: SVN reference [14884] has been migrated to Git commit e7b984dfa7
 2018-03-24 15:09:50 +00:00
Henrik Levkowetz bd205ae29b Merged in [14849] from ben@nostrum.com: 
Give ADs the red Clear Ballot button
 - Legacy-Id: 14904
Note: SVN reference [14849] has been migrated to Git commit 7bf02077fd
 2018-03-24 13:31:48 +00:00
Robert Sparks 8026f86cd3 Cleaner charter factory simplifies test code. Commit ready for merge. 
- Legacy-Id: 14899
 2018-03-22 14:01:24 +00:00
Robert Sparks f11907b6a0 Improved test coverage for ietf/doc/views_charter.py. Commit ready for merge. 
- Legacy-Id: 14896
 2018-03-21 21:59:45 +00:00
Adam Roach e7b984dfa7 Adding page count to last call page. Commit ready for merge. 
- Legacy-Id: 14884
 2018-03-21 09:12:34 +00:00
Ben Campbell cc96709957 Give ADs the red Clear Ballot button 
- Legacy-Id: 14848
 2018-03-17 16:35:35 +00:00
Henrik Levkowetz a04e187f0f Removed some old debug print statements. 
- Legacy-Id: 14823
 2018-03-14 22:11:06 +00:00
Henrik Levkowetz 1fd4a4d1a7 Added session ical links to document lists (WG docs, search results, etc.) for documents on upcoming meeting agendas. Reduced the query and rendering times of document lists some more through additional prefetch_related(). 
- Legacy-Id: 14799
 2018-03-14 19:16:50 +00:00
Henrik Levkowetz fdba464808 Added result caching for a couple of Document methods. 
- Legacy-Id: 14795
 2018-03-14 19:11:18 +00:00
Henrik Levkowetz 6e9bb00f13 Changed html cleaning to differentiate between fragment cleaning and document cleaning. Added an lxml-based cleaner for document cleaning, also permitting <style> tags (but not external style sheets). 
- Legacy-Id: 14775
 2018-03-13 12:48:22 +00:00
Henrik Levkowetz 2c0348cc7a Found that django's urlize() does not deal well with adjacent parantheses. Replaced it with a filter based on bleach.linkify, which does better. 
- Legacy-Id: 14752
 2018-03-09 15:07:04 +00:00
Henrik Levkowetz 1df3c715d0 Replaced the use of (at least in Django 1.11) buggy urlize() with bleach.linkify(), to avoid some exceptions caused by malformed urlize output, exposed by the new sanitize_html(). Also removed some dead code. 
- Legacy-Id: 14751
 2018-03-09 12:00:15 +00:00
Robert Sparks 975522af35 Make a more appropriate review message when a BoF has an initial charter under consideration. Fixes #2458. Commit ready for merge. 
- Legacy-Id: 14715
 2018-02-28 20:54:56 +00:00
Henrik Levkowetz 6e1d4d45d8 Added some missing migrations 
- Legacy-Id: 14697
 2018-02-25 20:08:37 +00:00
Henrik Levkowetz 1389775488 Added some missing migrations. 
- Legacy-Id: 14696
 2018-02-25 20:06:50 +00:00
Henrik Levkowetz 1ed8e967e7 Merged in ^/personal/henrik/6.72.1-django-1.11@14676: Upgrade to Django 1.11 
- Legacy-Id: 14695
 2018-02-25 19:55:16 +00:00
Henrik Levkowetz dc90fa3940 Changed user.is_authenticated and .is_anonymous from method calls to attribute access. 
- Legacy-Id: 14668
 2018-02-22 00:03:30 +00:00
Henrik Levkowetz 6184170828 Changed import path from a deprecated path to the kosher one. 
- Legacy-Id: 14667
 2018-02-22 00:01:01 +00:00
Henrik Levkowetz 26bf387356 Replaced direct assignment to m2m fields with .clear() and .set() 
- Legacy-Id: 14666
 2018-02-21 23:58:25 +00:00
Henrik Levkowetz 36b5e2ef8e Changed name from .rel to .remote_field for remote accessors. 
- Legacy-Id: 14665
 2018-02-21 23:56:36 +00:00
Henrik Levkowetz a4768bb514 Removed unused imports. Added some explicit orderings to avoid pagination issues. 
- Legacy-Id: 14664
 2018-02-21 23:54:31 +00:00
Henrik Levkowetz 06362ec046 Got rid of old migrations and created new initial migrations. 
- Legacy-Id: 14662
 2018-02-21 23:46:22 +00:00
Henrik Levkowetz 5638cf3da3 Changed all usage of ForeignKey and OneToOneFiled in model.py files to the compatibility versions from ietf.utils.models. 
- Legacy-Id: 14661
 2018-02-20 15:36:05 +00:00
Henrik Levkowetz cdc295bab8 Merged in [14655] from housley@vigilsec.com: 
Strip the HTML tags around the new values in the mail produced by email_iesg_processing_document. Also, provide the previously missing URL at the end of the message. Fixes 2455.
 - Legacy-Id: 14657
Note: SVN reference [14655] has been migrated to Git commit 6ea0881a89
 2018-02-19 17:36:09 +00:00
Russ Housley 6ea0881a89 Strip the HTML tags around the new values in the mail produced by email_iesg_processing_document. Also, provide the previously missing URL at the end of the message. Fixes 2455. 
- Legacy-Id: 14655
 2018-02-18 20:40:49 +00:00
Henrik Levkowetz 3dd66eba65 Fixed an UnboundLocalError (only partial variable initialization) bug. 
- Legacy-Id: 14620
 2018-02-07 06:13:19 +00:00
Henrik Levkowetz a00532694d Merged in [14549] from rjsparks@nostrum.com: 
Allow those people who can make a review request to edit the request deadline. Send mail to other directorate secretaries when one secretary makes a change to a request. Fixes #2233.
 - Legacy-Id: 14555
Note: SVN reference [14549] has been migrated to Git commit ba8b4d3a38
 2018-01-23 19:24:39 +00:00
Henrik Levkowetz 535cd0bccf Expanded the fields that the 'author' entry of the document search form is applied to, from just author name, to author name, email addresses, and affiliation. Fixes issue #2415. 
- Legacy-Id: 14552
 2018-01-23 18:12:10 +00:00
Robert Sparks ba8b4d3a38 Allow those people who can make a review request to edit the request deadline. Send mail to other directorate secretaries when one secretary makes a change to a request. Fixes #2233. Commit ready for merge. 
- Legacy-Id: 14549
 2018-01-22 21:43:53 +00:00
Henrik Levkowetz 649433874f Merged in [14539] from rjsparks@nostrum.com: 
Warn when putting a draft on a telechat that is so close that directorates will probably not have time to complete a review. Fixes #2381.
 - Legacy-Id: 14542
Note: SVN reference [14539] has been migrated to Git commit dfc1d2aa9a
 2018-01-19 15:22:16 +00:00
Robert Sparks dfc1d2aa9a Warn when putting a draft on a telechat that is so close that directorates will probably not have time to complete a review. Fixes #2381. Commit ready for merge. 
- Legacy-Id: 14539
 2018-01-18 22:14:30 +00:00
Henrik Levkowetz 07fd714c88 Refined the URL patterns and handling of alternative meeting material file formats, which were broken by an earlier refactoring (v6.57.0). Fixes issue #2436. 
- Legacy-Id: 14521
 2018-01-14 21:09:28 +00:00
Henrik Levkowetz 97206c6eeb Added user notification about ballots closed automatically when creating a new ballot. 
- Legacy-Id: 14471
 2017-12-29 15:24:37 +00:00
Henrik Levkowetz 4488fd82a4 Merged in [14467] from housley@vigilsec.com: 
Close any previous ballots when a charter goes to Internal Review or Extrernal Review.  Fixes #2421.
 - Legacy-Id: 14470
Note: SVN reference [14467] has been migrated to Git commit de6121c6c1
 2017-12-29 13:40:10 +00:00
Russ Housley de6121c6c1 Close any previous ballots when a charter goes to Internal Review or Extrernal Review. Fixes #2421. 
- Legacy-Id: 14467
 2017-12-28 20:09:56 +00:00
Robert Sparks 0a9737a5d2 Include information about previous team reviews in assignement emails. Fixes #2392. Commit ready for merge. 
- Legacy-Id: 14466
 2017-12-26 22:13:13 +00:00
Henrik Levkowetz b12bb3ca3c Guard document replacement following methods against infinite recursion on circular relationships. 
- Legacy-Id: 14457
 2017-12-22 19:28:59 +00:00
Henrik Levkowetz 7d7b7de54f Fixed an ungarded object attribute access. 
- Legacy-Id: 14446
 2017-12-19 14:38:02 +00:00
Henrik Levkowetz e1fa3ba381 Limited the iesg ballot position API to ADs (excluding secretariat). 
- Legacy-Id: 14444
 2017-12-19 14:10:43 +00:00
Henrik Levkowetz 6567e707ce Merged in ^/personal/henrik/6.64.2-ballotapi@14426. This provides personal API keys and a ballot position API at /api/iesg/position. Also added an endpoint description at /api/. 
- Legacy-Id: 14430
 2017-12-17 23:43:44 +00:00
Henrik Levkowetz a08c8dc76f Added an API endpoint to support automation of IESG ballot position posting, at /api/iesg/position. Added tests for the API endpoint, and updated the apikey validation decorator tests. Tweaked the decorator to handle a weakness found during testing. 
- Legacy-Id: 14429
 2017-12-17 21:55:27 +00:00
Henrik Levkowetz b0863c8963 Modified some names. 
- Legacy-Id: 14428
 2017-12-16 18:43:08 +00:00
Henrik Levkowetz e7209c6e50 Added a new personal event table to keep track of personal API key logins, and a management command to send out reports about activity to users with API keys. Added a weekly cronjob script to trigger weekly reports, and a monthly script for future use. Added a @require_api_key decorator to validate API keys for API key views and log in the API key owner. Modified the API key management urls to use create and disable rather than add and delete. Updated the API key list view. Added an API placeholder view function for ballot position setting, for test purposes. Added tests for the decorator and management command. 
- Legacy-Id: 14426
 2017-12-16 18:37:52 +00:00
Henrik Levkowetz 1f976da5c1 Third part of document read refactoring, after [14406] and [14410]. This replaces all usage of the non-unicode-aware get_document_content() function with unicode-aware Document.text() or Document.text_or_error() methods. This was triggered by yet another report of unicode content not being shown properly, and should fix all instances of document (drafts, agendas, minutes, etc.) display in the datatracker not handling unicode characters properly. 
- Legacy-Id: 14411
Note: SVN reference [14406] has been migrated to Git commit 967ece7e7d

Note: SVN reference [14410] has been migrated to Git commit 660c81c272
 2017-12-11 16:23:51 +00:00
Henrik Levkowetz 660c81c272 Tweaked the file content read refactoring in [14406] to try latin-1 conversion if unicode doesn't work. 
- Legacy-Id: 14410
Note: SVN reference [14406] has been migrated to Git commit 967ece7e7d
 2017-12-10 17:48:09 +00:00