Commit graph

9524 commits

Author SHA1 Message Date
Henrik Levkowetz 20eb9d8ac1 Merged in [16939] from sasha@dashcare.nl:
Fix #2050 - Allow adding review wishes from document and search pages.
On the main page of a document and in document search results, a new
button allows review team members to add a review wish for that document.

For reviewers that are only on one team, this essentially works
identical to tracking a document. Reviewers that are on multiple teams
are lead through an intermediate step to select a review team, and then
returned to their search or document page.
 - Legacy-Id: 16985
Note: SVN reference [16939] has been migrated to Git commit 6e55f26dbd
2019-11-11 14:22:54 +00:00
Sasha Romijn 48f72f2501 Add tests for default reviewer rotation list.
- Legacy-Id: 16984
2019-11-11 13:48:06 +00:00
Sasha Romijn b5a31c3c6a Update some terminology and docstrings.
- Legacy-Id: 16983
2019-11-11 12:31:16 +00:00
Henrik Levkowetz 290a98631f Merged in [16564] from pusateri@bangj.com and added tests:
Convert markdown to html if Accept header prioritizes text/html over text/markdown. Fixes #1926.
 - Legacy-Id: 16982
Note: SVN reference [16564] has been migrated to Git commit 65b3f93afe
2019-11-09 17:15:39 +00:00
Robert Sparks f740adcfc1 Look at the tree of replaces-relationships when determining if some reviewer has reviewed this (or perhaps an ancestor) of this document. Fixes #2821. Commit ready for merge.
- Legacy-Id: 16981
2019-11-07 23:02:19 +00:00
Henrik Levkowetz 49e0c26d9e Merged in [16977] from rjsparks@nostrum.com:
Disregard unassigned reviews when building the sets to compare when checking for race-conditions on assigning reviews. Partially addresses #2821.
 - Legacy-Id: 16980
Note: SVN reference [16977] has been migrated to Git commit 5c08b4096a
2019-11-07 23:00:38 +00:00
Robert Sparks 5c08b4096a Disregard unassigned reviews when building the sets to compare when checking for race-conditions on assigning reviews. Partially addresses #2821. Commit ready for merge.
- Legacy-Id: 16977
2019-11-07 16:16:33 +00:00
Henrik Levkowetz 48fd1a165e Moved the ietf/names/generate_fixtures.py command to a management command generate_name_fixture, and updated it to include a necessary dbtemplate object.
- Legacy-Id: 16976
2019-11-07 15:40:10 +00:00
Henrik Levkowetz a69459623c Set version info and settings back to development mode
- Legacy-Id: 16973
2019-11-05 23:29:53 +00:00
Henrik Levkowetz 893035a36a Set version info to release version 6.110.0 before branching.
- Legacy-Id: 16971
2019-11-05 23:29:42 +00:00
Henrik Levkowetz b7724c43d7 Changed some # type: ignore statements to work with the latest mypy
- Legacy-Id: 16968
2019-11-05 22:41:18 +00:00
Henrik Levkowetz c565dca35b Fixed some .format() calls.
- Legacy-Id: 16967
2019-11-05 22:38:54 +00:00
Robert Sparks fa00beab0e Use the recently released shepherd writeup templates. Fixes #2820. Commit ready for merge,
- Legacy-Id: 16966
2019-11-05 21:11:10 +00:00
Henrik Levkowetz 5d8aa656a5 Added code to catch bad rev numbers for bibxml3 requests.
- Legacy-Id: 16963
2019-11-05 18:24:45 +00:00
Henrik Levkowetz c233f07b5d Added a management command to generate draft bibxml files, and also a trial version of datatracker draft bibxml pages.
- Legacy-Id: 16962
2019-11-05 18:10:29 +00:00
Sasha Romijn e518824a69 Initial refactoring of the current reviewer assignment code.
- Legacy-Id: 16961
2019-11-05 16:39:31 +00:00
Henrik Levkowetz bf299bbfb5 Be more liberal with v3 xml submissions.
- Legacy-Id: 16956
2019-11-04 18:13:22 +00:00
Henrik Levkowetz d5b6292060 Fixed a pyflakes issue.
- Legacy-Id: 16955
2019-11-04 18:11:59 +00:00
Henrik Levkowetz feaa5038a0 Rewrote the ietf/bin/fix-ambiguous-timestamps command as a management command (fix_ambiguous_timestamps) and made it look at all instances of DateTimeField by means of model introspection.
- Legacy-Id: 16954
2019-11-04 12:56:52 +00:00
Henrik Levkowetz cee82e9f43 Merged in [16934] from sasha@dashcare.nl:
Fix #2088 - Sort unassigned review requests by doc name by default.
 - Legacy-Id: 16952
Note: SVN reference [16934] has been migrated to Git commit f075eced5c
2019-11-02 16:31:48 +00:00
Henrik Levkowetz 77a56473c3 Merged in [16933] from sasha@dashcare.nl:
Fix #2119 - Allow specifying review type for suggested reviews in LC and telechat
If a review is suggested on the 'manage unassigned reviews' page, and
the document is in both last call and telechat, the assign form now asks
for the type of review that should be assigned.
This commit also fixes two bugs in this process:
- Comparisons in some cases between strings and integers
  (group/views.py:1485/1487)
- Rejections when assigning suggested reviews, as they could be
  considered a newly opened request due to not having a pk
  (group/views.py:1508)
 - Legacy-Id: 16951
Note: SVN reference [16933] has been migrated to Git commit ee4bc0cb07
2019-10-31 17:31:21 +00:00
Sasha Romijn eab14ea1c5 Early work to extract reviewer policy from review/utils.py.
- Legacy-Id: 16950
2019-10-31 15:01:14 +00:00
Sasha Romijn 2caf18dcd3 Quick fix to stop mypy from failing
- Legacy-Id: 16949
2019-10-31 14:55:00 +00:00
Henrik Levkowetz 0f12d477ad Merged in [16927] from sasha@dashcare.nl:
Refs #2217 - Small cleanup from changeset [16924]
 - Legacy-Id: 16947
Note: SVN reference [16924] has been migrated to Git commit 871a4b653b

Note: SVN reference [16927] has been migrated to Git commit 730e64d253
2019-10-30 17:02:01 +00:00
Henrik Levkowetz 5065dc8871 Set version info and settings back to development mode
- Legacy-Id: 16945
2019-10-30 13:34:54 +00:00
Henrik Levkowetz 091ab95cc8 Set version info to release version 6.109.0 before branching.
- Legacy-Id: 16943
2019-10-30 13:34:41 +00:00
Henrik Levkowetz a37bd907cc Merged in [16926] from rjsparks@nostrum.com:
Flipped a sense to put the grace period on the right side of 'today' when sending review overdue reminders to team secretaries. Fixes #2816.
 - Legacy-Id: 16940
Note: SVN reference [16926] has been migrated to Git commit 7560e116bf
2019-10-30 13:01:53 +00:00
Sasha Romijn 6e55f26dbd Fix #2050 - Allow adding review wishes from document and search pages.
On the main page of a document and in document search results, a new
button allows review team members to add a review wish for that document.

For reviewers that are only on one team, this essentially works
identical to tracking a document. Reviewers that are on multiple teams
are lead through an intermediate step to select a review team, and then
returned to their search or document page.

Commit ready for merge.
 - Legacy-Id: 16939
2019-10-29 16:27:56 +00:00
Henrik Levkowetz 63484a8cb5 Merged in [16937] from rjsparks@nostrum.com:
Only show a blocked document once in the set of blocked documents on an ADs document page. Fixes #2818.
 - Legacy-Id: 16938
Note: SVN reference [16937] has been migrated to Git commit 8f1e9990cf
2019-10-29 15:03:01 +00:00
Robert Sparks 8f1e9990cf Only show a blocked document once in the set of blocked documents on an ADs document page. Fixes #2818. Commit ready for merge.
- Legacy-Id: 16937
2019-10-29 14:41:04 +00:00
Henrik Levkowetz 156b492d84 Added mising GET parameters to the fragment cache in the agenda.ics template. Fixes issue #2817.
- Legacy-Id: 16935
2019-10-28 15:09:25 +00:00
Sasha Romijn f075eced5c Fix #2088 - Sort unassigned review requests by doc name by default.
Commit ready for merge.
 - Legacy-Id: 16934
2019-10-28 12:27:15 +00:00
Sasha Romijn ee4bc0cb07 Fix #2119 - Allow specifying review type for suggested reviews in LC and telechat
If a review is suggested on the "manage unassigned reviews" page, and
the document is in both last call and telechat, the assign form now asks
for the type of review that should be assigned.

This commit also fixes two bugs in this process:
- Comparisons in some cases between strings and integers
  (group/views.py:1485/1487)
- Rejections when assigning suggested reviews, as they could be
  considered a newly opened request due to not having a pk
  (group/views.py:1508)
  
Commit ready for merge.
 - Legacy-Id: 16933
2019-10-28 11:43:48 +00:00
Henrik Levkowetz c606461b22 Merged in [16924] from sasha@dashcare.nl:
Fix #2217 - Allow submission of unsolicited reviews by secretaries.
- For team secretaries, a button 'Submit unsolicited review' will now
  appear next to 'Request review' on the document's main page.
- If the secretary is a secretary for multiple teams, they are taken
  through an intermediate page to select for which team they are
  submitting their review.
- The form is similar (and using the same code) as the usual review
  completion, with a few extra fields for the review type and reviewer,
  which would usually already be known.
- When submitting the review, a ReviewRequest and ReviewAssignment are
  automatically created. The assignment is then immediately closed in
  the usual way.
- Other workflows are unchanged.
The issues with the review form in #2061 are slightly worse for the
unsolicited review scenario, but that will be improved when #2061 is
fixed.
 - Legacy-Id: 16932
Note: SVN reference [16924] has been migrated to Git commit 871a4b653b
2019-10-26 21:16:53 +00:00
Henrik Levkowetz 00fb8d4b43 Merged in [16923] from sasha@dashcare.nl:
Fix #2087 - Show doc authors and WG chairs in unassigned reviews views.
 - Legacy-Id: 16931
Note: SVN reference [16923] has been migrated to Git commit 93797b3fc1
2019-10-26 20:26:21 +00:00
Henrik Levkowetz 3c82dc6184 Merged in [16922] from sasha@dashcare.nl:
Fix #2584 - Add additional content validation for uploaded texts.
Permitted MIME types are now text/plain, text/markdown and text/x-rst.
This applies to all usages of get_cleaned_text_file_content(),
including reviews, but also other similar places where text can either
be written either into a textarea or uploaded.
 - Legacy-Id: 16930
Note: SVN reference [16922] has been migrated to Git commit fd53f98854
2019-10-26 15:42:58 +00:00
Henrik Levkowetz a597f32a17 Normalized ietf/name/fixtures/names.json using jq --sort-keys 'sort_by(.model, .pk)'
- Legacy-Id: 16929
2019-10-26 15:19:15 +00:00
Henrik Levkowetz 09c34fa131 Merged in [16921] from sasha@dashcare.nl:
Fix #2123 - Use a DBTemplate when a review assignment is mailed.
The message sent to a reviewer when a new review is assigned to them,
is now taken from a DBTemplate, allowing it to be customised
per team. This includes a migration to create a default template,
which looks the same as before.
 - Legacy-Id: 16928
Note: SVN reference [16921] has been migrated to Git commit 9df5839874
2019-10-26 15:16:18 +00:00
Sasha Romijn 730e64d253 Refs #2217 - Small cleanup from changeset [16924]
Commit ready for merge.
 - Legacy-Id: 16927
Note: SVN reference [16924] has been migrated to Git commit 871a4b653b
2019-10-26 08:04:31 +00:00
Robert Sparks 7560e116bf Flipped a sense to put the grace period on the right side of "today" when sending review overdue reminders to team secretaries. Fixes #2816. Commit ready for merge.
- Legacy-Id: 16926
2019-10-25 20:32:16 +00:00
Sasha Romijn 871a4b653b Fix #2217 - Allow submission of unsolicited reviews by secretaries.
- For team secretaries, a button "Submit unsolicited review" will now
  appear next to "Request review" on the document's main page.
- If the secretary is a secretary for multiple teams, they are taken
  through an intermediate page to select for which team they are
  submitting their review.
- The form is similar (and using the same code) as the usual review
  completion, with a few extra fields for the review type and reviewer,
  which would usually already be known.
- When submitting the review, a ReviewRequest and ReviewAssignment are
  automatically created. The assignment is then immediately closed in
  the usual way.
- Other workflows are unchanged.

The issues with the review form in #2061 are slightly worse for the
unsolicited review scenario, but that will be improved when #2061 is
fixed.

Commit ready for merge.
 - Legacy-Id: 16924
2019-10-24 12:37:59 +00:00
Sasha Romijn 93797b3fc1 Fix #2087 - Show doc authors and WG chairs in unassigned reviews views.
Commit ready for merge.
 - Legacy-Id: 16923
2019-10-24 07:25:47 +00:00
Sasha Romijn fd53f98854 Fix #2584 - Add additional content validation for uploaded texts.
Permitted MIME types are now text/plain, text/markdown and text/x-rst.
This applies to all usages of get_cleaned_text_file_content(),
including reviews, but also other similar places where text can either
be written either into a textarea or uploaded.

Commit ready for merge.
 - Legacy-Id: 16922
2019-10-23 20:15:30 +00:00
Sasha Romijn 9df5839874 Fix #2123 - Use a DBTemplate when a review assignment is mailed.
The message sent to a reviewer when a new review is assigned to them,
is now taken from a DBTemplate, allowing it to be customised
per team. This includes a migration to create a default template,
which looks the same as before.

Commit ready for merge.
 - Legacy-Id: 16921
2019-10-23 16:06:44 +00:00
Henrik Levkowetz c508884ed9 Set version info and settings back to development mode
- Legacy-Id: 16919
2019-10-23 15:58:07 +00:00
Henrik Levkowetz 704b1f37de Set version info to release version 6.108.0 before branching.
- Legacy-Id: 16917
2019-10-23 15:57:57 +00:00
Henrik Levkowetz 31b09a710e Added a migration for a changed help text.
- Legacy-Id: 16914
2019-10-23 15:31:18 +00:00
Henrik Levkowetz 91d0a79a16 Merged in [16904] from sasha@dashcare.nl:
Fix #2118 - Always list all last call drafts in assignment summary.
If a draft is scheduled for a telechat, but also assigned for LC review,
it will now be listed both in the telechat section and under 'last calls'.
 - Legacy-Id: 16913
Note: SVN reference [16904] has been migrated to Git commit 82c63b49f3
2019-10-23 15:16:30 +00:00
Henrik Levkowetz 399d0e1797 Merged in [16902] from sasha@dashcare.nl:
Ref #2526 - Fix test failure in [16895]
This also makes a small text clarification, which was also the initial
reason for the test failure.
 - Legacy-Id: 16912
Note: SVN reference [16895] has been migrated to Git commit ef1e8006f0

Note: SVN reference [16902] has been migrated to Git commit 78a1464e77
2019-10-23 13:31:46 +00:00
Henrik Levkowetz 97be7f31ea Merged in [16895] from sasha@dashcare.nl:
Fix #2526 - List previous reviews in assignments email.
This includes a migration to update the database templates. Note that
not all templates currently included them (secdir at least), and
previous reviews are only listed in templates that included */** before.
As before, previous reviews are only included if they are done by the
same reviewer(s) as the current assignment.
This also fixes a bug in database template 182
(/group/defaults/email/open_assignments.txt) which referred to 
r.review_request..doc.rev and r.review_request..requested_rev
in the template, and updates the test to use the current version of
template 182.
 - Legacy-Id: 16911
Note: SVN reference [16895] has been migrated to Git commit ef1e8006f0
2019-10-22 22:09:08 +00:00
Henrik Levkowetz 4a486a6c4d Merged in [16891] from sasha@dashcare.nl:
Fix #2198 - Set default start date for UnavailabilityPeriod to today.
 - Legacy-Id: 16910
Note: SVN reference [16891] has been migrated to Git commit a7a2ee4a39
2019-10-22 21:20:51 +00:00
Henrik Levkowetz 3e9bad1c8b Merged in [16883] from sasha@dashcare.nl:
Fix #2277 - Do not allow reviewers to reject overdue reviews.
If a review request is past the deadline, reviewers will no longer be
able to reject the assignment.
 - Legacy-Id: 16909
Note: SVN reference [16883] has been migrated to Git commit 3c2b01b3ff
2019-10-22 20:59:13 +00:00
Henrik Levkowetz 2b211f1595 Merged in [16907] from rjsparks@nostrum.com:
Correct construction for a reverse URL in an edge case. Fixes #2815.
 - Legacy-Id: 16908
Note: SVN reference [16907] has been migrated to Git commit cca04b6330
2019-10-22 19:28:28 +00:00
Robert Sparks cca04b6330 Correct construction for a reverse URL in an edge case. Fixes #2815. Commit ready for merge.
- Legacy-Id: 16907
2019-10-22 18:24:57 +00:00
Henrik Levkowetz 6688d37bb4 Merged in [16875] from rjsparks@nostrum.com:
Adds docs with blocking positions to the ADs my-documents page. Fixes #2800.
 - Legacy-Id: 16906
Note: SVN reference [16875] has been migrated to Git commit f7d4600371b3f2a3c92aa184b517ed4ebee3a118
2019-10-22 17:43:54 +00:00
Henrik Levkowetz 04e342b3ce Merged in [16860] from rjsparks@nostrum.com:
Be resilient to statistics queries that provide a state but not a substate. Fixes #2813.
 - Legacy-Id: 16905
Note: SVN reference [16860] has been migrated to Git commit 654ae848f657957d2f7d259293ba523619d81cb5
2019-10-22 16:05:42 +00:00
Sasha Romijn 82c63b49f3 Fix #2118 - Always list all last call drafts in assignment summary.
If a draft is scheduled for a telechat, but also assigned for LC review,
it will now be listed both in the telechat section and under "last calls".

Commit ready for merge.
 - Legacy-Id: 16904
2019-10-22 14:55:04 +00:00
Sasha Romijn 78a1464e77 Ref #2526 - Fix test failure in [16895]
This also makes a small text clarification, which was also the initial
reason for the test failure.

Commit ready for merge.
 - Legacy-Id: 16902
Note: SVN reference [16895] has been migrated to Git commit ef1e8006f0
2019-10-22 14:34:36 +00:00
Henrik Levkowetz fc2abcce20 Fixed a couple of places where document alias.document was used instead of alias.docs.all().
- Legacy-Id: 16901
2019-10-22 14:19:22 +00:00
Henrik Levkowetz 9e21c011f6 Merged in [16854] from rjsparks@nostrum.com:
Remove some pre-ReviewAssignment refactor logic, and simplify what remains while still allowing a group secretary to not assign a row on the unassigned requests form after touching the control to assign a reviewer. Fixes #2812.
 - Legacy-Id: 16900
Note: SVN reference [16854] has been migrated to Git commit b158807134e2d26b3e013b6414b6fcbaa0e39f77
2019-10-22 12:43:56 +00:00
Henrik Levkowetz a4e49d8ec0 Merged in [16853] from rjsparks@nostrum.com:
Add submitted and posted dates to several ipr notification email messages. Fixes #2807.
 - Legacy-Id: 16899
Note: SVN reference [16853] has been migrated to Git commit f39d1568f0c4a8f4b1ebd3dee887fff6b3d8049b
2019-10-22 12:23:07 +00:00
Henrik Levkowetz 286ee2f961 Merged in [16852] from sasha@dashcare.nl:
Fix #2331 - Show stacked bar graph for in time and late reviews.
On the stats page, a single stacked bar graph is now shown which
combines in time and late reviews, replacing the separate graphs for
these statistics.
Tests for the charts are also expanded to validate the actual
graph content for both stacked and non-stacked charts.
 - Legacy-Id: 16898
Note: SVN reference [16852] has been migrated to Git commit f651320ef3
2019-10-22 11:49:39 +00:00
Henrik Levkowetz 1674356ee5 Merged in [16850] from sasha@dashcare.nl:
Fix #2185 - Close review assignments when reviewer is removed from team.
If a reviewer is removed from a team, any accepted or assigned review
assignments are set to rejected if the request deadline has not passed,
or set to no-response when the request deadline has passed.
Per [16819], if this scenario happens, and there are no other active or 
completed review assignments, the request is shown as an
unassigned review.
 - Legacy-Id: 16897
Note: SVN reference [16819] has been migrated to Git commit fdb4c2a055

Note: SVN reference [16850] has been migrated to Git commit e145832808
2019-10-21 21:56:05 +00:00
Henrik Levkowetz 0313a4f58d Merged in [16836] from rjsparks@nostrum.com:
Changes to displaying the ballot_icon to account for IRSG ballots.
 - Legacy-Id: 16896
Note: SVN reference [16836] has been migrated to Git commit 6375aa3bedbd612cd519bf3dccced2465b145593
2019-10-21 19:37:36 +00:00
Sasha Romijn ef1e8006f0 Fix #2526 - List previous reviews in assignments email.
This includes a migration to update the database templates. Note that
not all templates currently included them (secdir at least), and
previous reviews are only listed in templates that included */** before.

As before, previous reviews are only included if they are done by the
same reviewer(s) as the current assignment.

This also fixes a bug in database template 182
(/group/defaults/email/open_assignments.txt) which referred to 
r.review_request..doc.rev and r.review_request..requested_rev
in the template, and updates the test to use the current version of
template 182.

Commit ready for merge.
 - Legacy-Id: 16895
2019-10-21 19:11:56 +00:00
Sasha Romijn a7a2ee4a39 Fix #2198 - Set default start date for UnavailabilityPeriod to today.
Commit ready for merge.
 - Legacy-Id: 16891
2019-10-21 15:16:33 +00:00
Henrik Levkowetz f2758fe49c Set version info and settings back to development mode
- Legacy-Id: 16889
2019-10-21 15:02:33 +00:00
Henrik Levkowetz 90c2781e59 Set version info to release version 6.107.0 before branching.
- Legacy-Id: 16887
2019-10-21 15:02:21 +00:00
Henrik Levkowetz b7fba956fd Merged in [16825] from rjsparks@nostrum.com:
Don't copy early reviews to ietf_last_call by default.
 - Legacy-Id: 16884
Note: SVN reference [16825] has been migrated to Git commit 54c221b6e03b573041600645d34316292e058d66
2019-10-21 14:28:22 +00:00
Sasha Romijn 3c2b01b3ff Fix #2277 - Do not allow reviewers to reject overdue reviews.
If a review request is past the deadline, reviewers will no longer be
able to reject the assignment.

Commit ready for merge.
 - Legacy-Id: 16883
2019-10-21 14:15:08 +00:00
Henrik Levkowetz 496eb50253 Merged in [16824] from rjsparks@nostrum.com:
Use last-call@ietf.org.
 - Legacy-Id: 16882
Note: SVN reference [16824] has been migrated to Git commit 039d62370dd27764a54c62c7d70959d43f36e880
2019-10-21 14:08:11 +00:00
Henrik Levkowetz 1656b0012c Merged in [16819] from sasha@dashcare.nl:
Fix #2186 - Return review req to 'requested' status if no review assignments are open.
If a review assignment is rejected, withdrawn, marked no response, etc.,
and this leaves a review request without any assigned/accepted/completed
review assignments, return the request state to 'requested', which means
it will be shown as an unassigned review in all interfaces.
 - Legacy-Id: 16881
Note: SVN reference [16819] has been migrated to Git commit fdb4c2a055
2019-10-21 13:45:03 +00:00
Henrik Levkowetz 45465f1174 Merged in [16818] from rjsparks@nostrum.com:
Make hybrid pdfs when converting ppt materials to pdf. Fixes #2769.
 - Legacy-Id: 16880
Note: SVN reference [16818] has been migrated to Git commit 84270a71d0e7373c5e05ddc834e91c445a1296ed
2019-10-21 13:17:33 +00:00
Henrik Levkowetz c474b42f2d Send review reminders output to log, rather than stdout (since this is run from cron, stdout and stderr should be quiet if nothing unexpected happens)
- Legacy-Id: 16878
2019-10-18 14:46:59 +00:00
Henrik Levkowetz e2cc982969 Added a guard against missing conflrev state in iesg agenda code.
- Legacy-Id: 16877
2019-10-17 17:26:40 +00:00
Henrik Levkowetz c05562cb5d Set version info and settings back to development mode
- Legacy-Id: 16873
2019-10-16 14:14:40 +00:00
Henrik Levkowetz 8aa645f6f6 Set version info to release version 6.106.0 before branching.
- Legacy-Id: 16871
2019-10-16 14:14:25 +00:00
Henrik Levkowetz 7728231f74 Migration for help text changes for a couple of ReviewTeamSettings and ReviewerSettings fields.
- Legacy-Id: 16868
2019-10-15 17:22:52 +00:00
Henrik Levkowetz 77abc3868e Type checking tweaks.
- Legacy-Id: 16867
2019-10-15 16:54:33 +00:00
Henrik Levkowetz a288401fd1 Type checking tweaks.
- Legacy-Id: 16866
2019-10-15 16:50:43 +00:00
Henrik Levkowetz 447525de73 Tweaked the output of mypy_test().
- Legacy-Id: 16865
2019-10-15 16:48:23 +00:00
Henrik Levkowetz 4d7db7e1d4 Rearranged some migrations.
- Legacy-Id: 16864
2019-10-15 16:46:42 +00:00
Henrik Levkowetz a66fa82b06 Fixed some review reminders issues.
- Legacy-Id: 16863
2019-10-15 16:46:12 +00:00
Henrik Levkowetz 994e0ba6cc Moved the code that generates .txt and .html draft files from .xml to a place where potential errors can be caught and displayed better. Related to ticket #2814.
- Legacy-Id: 16862
2019-10-15 14:33:35 +00:00
Henrik Levkowetz 5b3b9c2791 Reverting the previous commit
- Legacy-Id: 16857
2019-10-10 18:32:49 +00:00
Henrik Levkowetz c58f370104 Updated requirements3.txt. Explicitly listing mypy version requirements is counter-productive as it is determined by django-stubs.
- Legacy-Id: 16856
2019-10-10 18:31:25 +00:00
Sasha Romijn f651320ef3 Fix #2331 - Show stacked bar graph for in time and late reviews.
On the stats page, a single stacked bar graph is now shown which
combines in time and late reviews, replacing the separate graphs for
these statistics.

Tests for the charts are also expanded to validate the actual
graph content for both stacked and non-stacked charts.

Commit ready for merge.
 - Legacy-Id: 16852
2019-10-09 15:46:22 +00:00
Henrik Levkowetz 985397803b Corrected some migration numbers.
- Legacy-Id: 16851
2019-10-09 14:33:33 +00:00
Sasha Romijn e145832808 Fix #2185 - Close review assignments when reviewer is removed from team.
If a reviewer is removed from a team, any accepted or assigned review
assignments are set to rejected if the request deadline has not passed,
or set to no-response when the request deadline has passed.

Per [16819], if this scenario happens, and there are no other active or 
completed review assignments, the request is shown as an
unassigned review.

Commit ready for merge.
 - Legacy-Id: 16850
Note: SVN reference [16819] has been migrated to Git commit fdb4c2a055
2019-10-09 13:36:25 +00:00
Henrik Levkowetz fab9580bb0 Merged in [16815] from rjsparks@nostrum.com:
Link to the about pages for groups even if they don't have a charter (some have other forms of descriptive text, and all have more information on the group pages than they did a few years ago). Fixes #2744.
 - Legacy-Id: 16848
Note: SVN reference [16815] has been migrated to Git commit 26e3e62c567d8146a27a976f1da0710eeda46ba2
2019-10-08 22:24:06 +00:00
Henrik Levkowetz 38a85632c1 Merged in [16813] from rjsparks@nostrum.com:
Don't offer to propose slides when the next view will not allow you to propose slides. Fixes #2763.
 - Legacy-Id: 16847
Note: SVN reference [16813] has been migrated to Git commit 1ec4f7f41e6bf9945c4e4e5a55d50f7535b0fbbc
2019-10-08 16:18:54 +00:00
Henrik Levkowetz be641ac22a Merged in [16792] from sasha@dashcare.nl:
Fix #2475 - Send opt-in reminders for unconfirmed review assignments.
If enabled for a team, reminders will be sent every X days to reviewers
for review assignments they have not accepted or rejected.
 - Legacy-Id: 16846
Note: SVN reference [16792] has been migrated to Git commit 486b6daa29
2019-10-08 15:57:28 +00:00
Henrik Levkowetz 5460a5ab84 Merged in [16785] from rjsparks@nostrum.com:
Improve alerts when looking at non-current versions of a charter document. Fixes #2774.
 - Legacy-Id: 16845
Note: SVN reference [16785] has been migrated to Git commit 07637c27e1a76d3cbb92cc22b987b9f1426d8d52
2019-10-08 14:24:01 +00:00
Henrik Levkowetz 9361b7d540 Turned the ReviewAssignmentAdmin.review field into a raw_id_field, to avoid a form that lists all documents in the database in a drop-down. Fixes issue #2810.
- Legacy-Id: 16843
2019-10-08 13:57:25 +00:00
Henrik Levkowetz 0763dc3856 Merged in [16771] from rjsparks@nostrum.com:
Add migration intended for r16770. Related to #2782.
 - Legacy-Id: 16842
Note: SVN reference [16771] has been migrated to Git commit f3fb0f8c20941710d675ca4bb2873635c2fa8624
2019-10-08 13:12:29 +00:00
Henrik Levkowetz a895e19882 Merged in [16770] from rjsparks@nostrum.com:
Populate completed_on when rejecting a ReviewAssignment. Migrate past rejected assignments accordingly. Fixes #2782.
 - Legacy-Id: 16841
Note: SVN reference [16770] has been migrated to Git commit 661e4c5369dc0d165bfcb56e3278906fe1de3b55
2019-10-08 12:46:49 +00:00
Henrik Levkowetz cc8263a91c Renamed and fixed up a migration that caused multiple leaf nodes.
- Legacy-Id: 16840
2019-10-08 10:58:46 +00:00
Henrik Levkowetz 678f8a5787 Merged in [16765] from sasha@dashcare.nl:
Refs #2277 - Send daily reminders of overdue reviews to secretaries
 - Legacy-Id: 16839
Note: SVN reference [16765] has been migrated to Git commit cc64992204
2019-10-08 10:41:37 +00:00
Henrik Levkowetz 1edc863969 Merged in [16763] from rjsparks@nostrum.com:
Allow responsible AD to be None for documents in iesg states idexists and dead. Fixes #2803 and #993.
 - Legacy-Id: 16838
Note: SVN reference [16763] has been migrated to Git commit 9f54af355d4e2b17404caa1755be74d22b5edad1
2019-10-07 19:54:56 +00:00
Henrik Levkowetz 058a8c3cf2 Merged in [16762] from rjsparks@nostrum.com:
Use form validation to prevent interim slide titles that end with -nn until we change interims to use the modern HREF schemes. Fixes #2797.
 - Legacy-Id: 16837
Note: SVN reference [16762] has been migrated to Git commit 40b066560cb01191a5f7995a0fd04a32f1abbddd
2019-10-07 19:28:31 +00:00
Henrik Levkowetz 7811f4bcf3 Set version info and settings back to development mode
- Legacy-Id: 16831
2019-10-07 15:07:13 +00:00
Henrik Levkowetz 1d26d3182e Set version info to release version 6.105.0 before branching.
- Legacy-Id: 16829
2019-10-07 15:06:38 +00:00
Henrik Levkowetz 0c6bca8e59 Merged in [16759] from rjsparks@nostrum.com:
Restrict comments total on nomcom private index to comments on positions. Fixes #2792.
 - Legacy-Id: 16826
Note: SVN reference [16759] has been migrated to Git commit 7aa57e9f57
2019-10-04 20:54:05 +00:00
Henrik Levkowetz 09e38dffa0 Merged in [16705] from sasha@dashcare.nl:
Fix #2337 - Send periodic reminders of open reviews every X days (opt-in)
The interleaved_migrations_test currently fails due to the various 
migrations that have been added for individual tickets/commits (unless
--permit-mixed-migrations is set). I think this is better fixed in a
later cleanup, as doing it now could cause confusion when merging
individual commits, and more migrations are likely to be added soon.
 - Legacy-Id: 16823
Note: SVN reference [16705] has been migrated to Git commit ec56a03ec6
2019-10-04 17:09:57 +00:00
Henrik Levkowetz 4c3e869d5c Merged in [16704] from sasha@dashcare.nl:
Fix #2231 - Send reminders before long UnavailabilityPeriods expire
A notification is sent to the team secretary and reviewer, if an
unavailability period lasting 30 days or more will end in 3 days.
 - Legacy-Id: 16822
Note: SVN reference [16704] has been migrated to Git commit 179c151f9e
2019-10-04 14:07:54 +00:00
Henrik Levkowetz d798196f5a Merged in [16703] from sasha@dashcare.nl:
Ref #2231 - Fix send-review-reminders and add it to daily cron
This fixes a syntax error and a Python 3 incompatibility, and adds
send-review-reminders to the daily cron script.
Important notes:
- I have not tested to what degree the existing reminders work as they
  should, as that's out of scope. It does have tests.
- I can't assess whether the virtualenv activation works in the
  production setup, and it may be obsolete as bin/daily also
  activates the virtualenv.
- The same Python 3 incompatibility (execfile() no longer exists) seems
  to exist in various other scripts.
 - Legacy-Id: 16821
Note: SVN reference [16703] has been migrated to Git commit 296b126c70
2019-10-04 13:04:37 +00:00
Henrik Levkowetz 9e43474612 Fixed an issue with the htmlization of links in release notes.
- Legacy-Id: 16820
2019-10-03 21:58:38 +00:00
Sasha Romijn fdb4c2a055 Fix #2186 - Return review req to 'requested' status if no review assignments are open.
If a review assignment is rejected, withdrawn, marked no response, etc.,
and this leaves a review request without any assigned/accepted/completed
review assignments, return the request state to "requested", which means
it will be shown as an unassigned review in all interfaces.

Commit ready for merge.
 - Legacy-Id: 16819
2019-10-03 09:02:34 +00:00
Henrik Levkowetz 9d4ca615d3 Merged in [16607] from rcross@amsl.com:
Fix issue where third session requests, which rerequire AD approval, get left with approved status, instead of scheduled, after Secretraiat sends out notifications of official schedule.  Fixes #2765.
 - Legacy-Id: 16817
Note: SVN reference [16607] has been migrated to Git commit 9a82586e1b
2019-10-02 20:55:54 +00:00
Henrik Levkowetz 7931b3196d Merged in [16701] from rcross@amsl.com:
Add migration to remove any break / registration sessions that have already been created for future meetings.  Goes with changes for #2713.
 - Legacy-Id: 16816
Note: SVN reference [16701] has been migrated to Git commit 0bbdbca8ac
2019-10-02 20:53:30 +00:00
Henrik Levkowetz 07375b46f8 Added log.unreachable() for the code that creates unknown-email-*' addresses. Addresses issue #2696.
- Legacy-Id: 16814
2019-10-02 17:45:44 +00:00
Henrik Levkowetz 4af77bbc8e Fixed a bug in gather_submission_submitter().
- Legacy-Id: 16808
2019-10-02 04:07:00 +00:00
Henrik Levkowetz bee8d13a57 Removed some test assertions which are incorrect after the previous commit
- Legacy-Id: 16806
2019-10-01 22:13:20 +00:00
Henrik Levkowetz 038e90649d From rcross@amsl.com: Don't copy breaks etc, when creating new Empty Schedule for meetings. Fixes issue #2713.
- Legacy-Id: 16805
2019-10-01 20:30:40 +00:00
Henrik Levkowetz 92a84117b4 Added a type hint stub file for ietf/api/__init__.py, to capture variables created during module initialization.
- Legacy-Id: 16804
2019-10-01 20:29:02 +00:00
Henrik Levkowetz 445f2cf614 Set version info and settings back to development mode
- Legacy-Id: 16801
2019-10-01 16:16:03 +00:00
Henrik Levkowetz 535650bec0 Set version info to release version 6.104.0 before branching.
- Legacy-Id: 16799
2019-10-01 16:15:53 +00:00
Henrik Levkowetz 5a5d18c5c5 Removed 2 package.json files that interfered with bower operation.
- Legacy-Id: 16796
2019-10-01 15:39:47 +00:00
Henrik Levkowetz 8c71252fee Merged in [16688] from sasha@dashcare.nl:
Fix #2478 - When completing review, show which addresses it is posted to.
 - Legacy-Id: 16795
Note: SVN reference [16688] has been migrated to Git commit 68ea11a916
2019-10-01 15:02:03 +00:00
Henrik Levkowetz 25ac3b67f5 Merged in [16680] from sasha@dashcare.nl:
Fix #2354 - Make review_completed configurable per team and review type
This includes a migration to change mailtrigger slugs to be up to 64
characters instead of 32, as some slugs would not fit and require clunky
abbreviations.
A data migration creates triggers for existing teams, and they are also
created on the fly if a trigger does not exist yet, providing a safe
fallback for new review teams. The review_completed mailtrigger serves
as the template for new triggers.
This commit also includes tests for gather_address_lists(), as none
existed.
 - Legacy-Id: 16794
Note: SVN reference [16680] has been migrated to Git commit 1390ae073c
2019-10-01 13:35:52 +00:00
Henrik Levkowetz 70380cb8ea Merged in [16672] from sasha@dashcare.nl:
Fix #2328 - Use mailtriggers to find destinations in review app
As the review app has several conditionals that don't fit
entirely well within mailtriggers, the templates use a bit
of extra context to figure out who exactly to include. This also
extends the tests for review, to check for correct recipients.
It also adds a tiny feature to mailtrigger to entirely exclude
certain addresses, as required by the review-generated mails.
 - Legacy-Id: 16793
Note: SVN reference [16672] has been migrated to Git commit 88b7b45b0e
2019-10-01 13:06:48 +00:00
Sasha Romijn 486b6daa29 Fix #2475 - Send opt-in reminders for unconfirmed review assignments.
If enabled for a team, reminders will be sent every X days to reviewers
for review assignments they have not accepted or rejected.

Commit ready for merge.
 - Legacy-Id: 16792
2019-10-01 13:01:19 +00:00
Henrik Levkowetz 632423aa6c Merged in [16670] from sasha@dashcare.nl:
Fix #2590 - Allow secretary to adjust date when completing a review.
This also fixes other issues identified in #2590, around the
modification of historical document events. The behaviour is now:
- When the assigned reviewer posts a review, a single event is
  created, set to current date/time.
- When the secretary records a review in the datatracker, they may
  set a different completion date, which is autofilled if an email
  is selected. One event is generated for the original completion
  date, and one for the secretary's action.
- Each revision generates a new event, rather than updating previous
  existing events.
 - Legacy-Id: 16791
Note: SVN reference [16670] has been migrated to Git commit 3942f9acc7
2019-10-01 12:05:04 +00:00
Henrik Levkowetz 24ede9a1ae In wordwrap(), consider lines consisting entirely of some non-alphanumeric characters like ---- or === to be block (paragraph) separators. Fixes issue #2806.
- Legacy-Id: 16790
2019-10-01 11:08:41 +00:00
Henrik Levkowetz 12bf466832 Merged in [16668] from sasha@dashcare.nl:
Fix #2560 - Sort names in history when changing list of members.
 - Legacy-Id: 16789
Note: SVN reference [16668] has been migrated to Git commit de9cde9e43
2019-10-01 10:15:46 +00:00
Henrik Levkowetz c63ace2721 Removed debug-related code from group edit clean_acronym(). Fixes issue #2804.
- Legacy-Id: 16787
2019-09-30 21:37:40 +00:00
Henrik Levkowetz 10c8596664 Merged in [16667] from sasha@dashcare.nl:
Fix #2071 - Add optional comment field for close request.
 - Legacy-Id: 16786
Note: SVN reference [16667] has been migrated to Git commit 4669b0934b
2019-09-30 20:55:16 +00:00
Henrik Levkowetz 4c28f69172 Set version info and settings back to development mode
- Legacy-Id: 16781
2019-09-30 16:55:49 +00:00
Henrik Levkowetz b93cc3e83d Set version info to release version 6.103.1 before branching.
- Legacy-Id: 16779
2019-09-30 16:55:38 +00:00
Henrik Levkowetz 902f7769d1 Fixed incorrect type hints for Migration.dependencies.
- Legacy-Id: 16776
2019-09-30 16:25:58 +00:00
Henrik Levkowetz 33e8733b91 Fixed up mypy issues or added type:ignore comments as needed for a clean mypy run.
- Legacy-Id: 16772
2019-09-30 15:42:18 +00:00
Henrik Levkowetz 2d858f2e0a Added mypy and django-stubs to Py3 requirements, and added a mypy test case.
- Legacy-Id: 16768
2019-09-30 15:37:32 +00:00
Henrik Levkowetz 4ed73d2ba9 Removed unused .py file
- Legacy-Id: 16767
2019-09-30 15:35:03 +00:00
Sasha Romijn cc64992204 Refs #2277 - Send daily reminders of overdue reviews to secretaries
Commit ready for merge.
 - Legacy-Id: 16765
2019-09-30 12:27:43 +00:00
Henrik Levkowetz e0479d8d13 Changed the call signature of docevent_from_submission() to take an optional Person object, rather than person name. Added a type hint for the signature.
- Legacy-Id: 16764
2019-09-29 20:00:49 +00:00
Henrik Levkowetz a1db2d5aef Tweaked the condition for waiving submission email confirmation slightly.
- Legacy-Id: 16760
2019-09-27 06:12:55 +00:00
Robert Sparks 7aa57e9f57 Restrict comments total on nomcom private index to comments on positions. Fixes #2792. Commit ready for merge.
- Legacy-Id: 16759
2019-09-26 21:49:55 +00:00
Henrik Levkowetz 60ba9f5a27 Set version info and settings back to development mode
- Legacy-Id: 16756
2019-09-26 18:42:35 +00:00
Henrik Levkowetz 4c9cddfaa6 Set version info to release version 6.103.0 before branching.
- Legacy-Id: 16754
2019-09-26 18:42:24 +00:00
Henrik Levkowetz 3939c0b88c Changed draft submission to not require an email round-trip when the submitter is logged in. Added corresponding test cases.
- Legacy-Id: 16749
2019-09-26 14:43:26 +00:00
Henrik Levkowetz 466bd0675e Added asciiFullname and asciiSurname attributes to the XML submission test template.
- Legacy-Id: 16748
2019-09-26 14:41:48 +00:00
Henrik Levkowetz 125ec9b3b7 Added a template interpolation variable for document title to the submission test text template.
- Legacy-Id: 16747
2019-09-26 14:40:36 +00:00
Henrik Levkowetz eabf121abe Added code to detect conflicting information for draft name, revision, and title when both XML and text versions of a document are submitted.
- Legacy-Id: 16746
2019-09-26 14:38:47 +00:00
Henrik Levkowetz 78889979a1 Changed the draft submission form and views so that an email address is required for each author in order to complete self-service draft submission. It is possible to add these as metadata updates, but this will lead to submission through the secretariat (and the email addresses will still be required). Also updated related templates to make the handling of form section headings more consistent.
- Legacy-Id: 16745
2019-09-23 17:26:16 +00:00
Henrik Levkowetz 1efd28752c Added some caching to /release/ pages. With now more than 350 releases, the page response times had increased to typically 4s. Caching in view and template brought this down to ~160ms.
- Legacy-Id: 16744
2019-09-21 12:36:08 +00:00
Henrik Levkowetz d7c4639d4f Set version info and settings back to development mode
- Legacy-Id: 16742
2019-09-20 16:19:14 +00:00
Henrik Levkowetz 638436364e Set version info to release version 6.102.0 before branching.
- Legacy-Id: 16740
2019-09-20 16:18:41 +00:00
Henrik Levkowetz a3f59ee9a2 Added conversion of version 3 XML draft submissions to v3 HTML, in addition to text. Added a link to HTML versions (when present) to the document status page, and renamed the link to the htmlized version to 'htmlized'. Converted the submission XML test-file to version 3. Added test code to check that HTML is generated for version 3 XML submissions.
- Legacy-Id: 16737
2019-09-20 14:24:44 +00:00
Henrik Levkowetz 2c72d33b84 Added class 'bg-danger' to submission error messages. The big 'Meta-Data errors found' pane on red background is so noticeable that class 'text-danger' which gives bold text is insufficient to stand out clearly. Adding 'bg-danger' gives the specific error messages red background, too.
- Legacy-Id: 16736
2019-09-20 11:31:09 +00:00
Henrik Levkowetz 44f42cdb3a Undid the previous commit
- Legacy-Id: 16735
2019-09-20 11:30:04 +00:00
Henrik Levkowetz e3e9f676b7 Added class 'bg-danger' to submission error messages. The big 'Meta-Data errors found' pane on red background is so noticeable that class 'text-danger' which gives bold text is insufficient to stand out clearly. Adding 'bg-danger' gives the specific error messages red background, too.
- Legacy-Id: 16734
2019-09-20 11:28:53 +00:00
Henrik Levkowetz 4283740bf1 Added a link to RFCs rendered with inline errata (where available) to the /doc/rfcNNNN pages.
- Legacy-Id: 16732
2019-09-13 22:59:38 +00:00
Henrik Levkowetz 96f6f47758 Updated rfc-editor sync code to recognize the new Tooling Issue queue state.
- Legacy-Id: 16730
2019-09-11 16:20:25 +00:00
Henrik Levkowetz 3e67a395b5 Updated ietf.sync.rfceditor.parse_index() to use the new rfc-index schema (changed placement of the page-count element).
- Legacy-Id: 16729
2019-09-11 12:48:19 +00:00
Henrik Levkowetz 3160f55597 Added code to catch a form error regularly caused by form spam and return a failure instead of triggering a server 500.
- Legacy-Id: 16728
2019-09-10 16:10:11 +00:00
Henrik Levkowetz 81bc17533a Set version info and settings back to development mode
- Legacy-Id: 16723
2019-09-08 15:29:06 +00:00
Henrik Levkowetz b1e8e4a1d1 Set version info to release version 6.101.0 before branching.
- Legacy-Id: 16721
2019-09-08 15:28:40 +00:00
Henrik Levkowetz 28bd819f91 Updated bower-managed static web assets
- Legacy-Id: 16718
2019-09-08 15:02:28 +00:00
Henrik Levkowetz 3336f4a11b Merged in [16656] from rjsparks@nostrum.com:
Add IANA expert review tracking.
 - Legacy-Id: 16716
Note: SVN reference [16656] has been migrated to Git commit e45a32e49f
2019-09-08 14:34:29 +00:00
Henrik Levkowetz 100aa3f35d Removed OBE page 'todo' under 'release'.
- Legacy-Id: 16711
2019-09-05 23:02:23 +00:00
Henrik Levkowetz 1c38387279 Merged in [16649] from rjsparks@nostrum.com:
Guard against attempts to use the review request view with a ReviewRequest id that does not match the document for the ReviewRequest. This would have exposed #2776 much earlier.
 - Legacy-Id: 16710
Note: SVN reference [16649] has been migrated to Git commit 01ceeba131
2019-09-05 22:59:59 +00:00
Henrik Levkowetz 3349d64479 Merged in [16647] from rjsparks@nostrum.com:
Corrected a view that was looking at review assignment ids when it should have been looking at request review ids. Fixes #2776.
 - Legacy-Id: 16708
Note: SVN reference [16647] has been migrated to Git commit 87de06c97c
2019-09-05 21:26:54 +00:00
Henrik Levkowetz 513e60432b Added a 'domain' variable to context supplied to the agenda_package.txt template. Fixes issue #2793.
- Legacy-Id: 16707
2019-09-05 18:49:18 +00:00
Henrik Levkowetz aafc66c490 Merged in [16646] from rjsparks@nostrum.com:
Don't manually linewrap when looking at feedback - let the pasted styling do that. Fixes #2761.
 - Legacy-Id: 16706
Note: SVN reference [16646] has been migrated to Git commit 33838840d1
2019-09-05 18:46:24 +00:00
Sasha Romijn ec56a03ec6 Fix #2337 - Send periodic reminders of open reviews every X days (opt-in)
The interleaved_migrations_test currently fails due to the various 
migrations that have been added for individual tickets/commits (unless
--permit-mixed-migrations is set). I think this is better fixed in a
later cleanup, as doing it now could cause confusion when merging
individual commits, and more migrations are likely to be added soon.

Commit ready for merge.
 - Legacy-Id: 16705
2019-09-05 15:02:56 +00:00
Sasha Romijn 179c151f9e Fix #2231 - Send reminders before long UnavailabilityPeriods expire
A notification is sent to the team secretary and reviewer, if an
unavailability period lasting 30 days or more will end in 3 days.
Commit ready for merge.
 - Legacy-Id: 16704
2019-09-05 11:59:40 +00:00
Sasha Romijn 296b126c70 Ref #2231 - Fix send-review-reminders and add it to daily cron
This fixes a syntax error and a Python 3 incompatibility, and adds
send-review-reminders to the daily cron script.

Important notes:
- I have not tested to what degree the existing reminders work as they
  should, as that's out of scope. It does have tests.
- I can't assess whether the virtualenv activation works in the
  production setup, and it may be obsolete as bin/daily also
  activates the virtualenv.
- The same Python 3 incompatibility (execfile() no longer exists) seems
  to exist in various other scripts.
  
Commit ready for merge.
 - Legacy-Id: 16703
2019-09-05 10:50:39 +00:00
Ryan Cross f950f1b8ea Remove temporary print statements. Commit ready for merge.
- Legacy-Id: 16702
2019-09-03 21:16:10 +00:00
Ryan Cross 0bbdbca8ac Add migration to remove any break / registration sessions that have already been created for future meetings. Goes with changes for #2713. Commit ready for merge.
- Legacy-Id: 16701
2019-09-03 21:03:19 +00:00
Henrik Levkowetz 46fbcfbc01 Merged in [16631] from rjsparks@nostrum.com:
Converted tabs to spaces. Whitespace changes only.
 - Legacy-Id: 16700
Note: SVN reference [16631] has been migrated to Git commit 19a9ce9a95
2019-09-03 19:42:01 +00:00
Henrik Levkowetz 8472cf2226 Merged in [16630] from rjsparks@nostrum.com:
Rework how we are labeling constraints to provide a quick-fix for session requests at IETF106. Turned off several javascript functions that added/enforced old (possibly no longer correct) semantics for the session request forms. Fixes #2754.
 - Legacy-Id: 16699
Note: SVN reference [16630] has been migrated to Git commit 10422f87d2
2019-09-03 16:43:12 +00:00
Henrik Levkowetz e021eb8924 Merged in [16629] from rjsparks@nostrum.com:
Removing unused template. I think it was an artifact of the Django 1.2 to 1.6 conversion from 6 years ago.
 - Legacy-Id: 16698
Note: SVN reference [16629] has been migrated to Git commit 798a57c9ab
2019-09-03 14:46:14 +00:00
Henrik Levkowetz e49ff19255 Merged in [16615] from peter@akayla.com:
Spelling correction in a comment.  No open issue.
 - Legacy-Id: 16697
Note: SVN reference [16615] has been migrated to Git commit 7f6edfcabc
2019-09-03 12:52:26 +00:00
Henrik Levkowetz f26020631e Merged in [16614] from peter@akayla.com:
Improved so that new draft diffs (from the working group drafts page) work correctly for both -00 drafts and later revisions.  Fixes issue #2697.
 - Legacy-Id: 16693
Note: SVN reference [16614] has been migrated to Git commit 390ff04722
2019-09-03 12:28:45 +00:00
Henrik Levkowetz 506dcb3472 Merged in [16604] from rjsparks@nostrum.com:
Look at all scheduled sessions for a group when deciding to display a cancelled banner. Fixes #2764.
 - Legacy-Id: 16691
Note: SVN reference [16604] has been migrated to Git commit aea3c1a55b1b14f9da90d0cfb03891e7129f8632
2019-09-03 11:08:59 +00:00
Sasha Romijn 68ea11a916 Fix #2478 - When completing review, show which addresses it is posted to.
Commit ready for merge.
 - Legacy-Id: 16688
2019-09-02 15:52:26 +00:00
Sasha Romijn 1390ae073c Fix #2354 - Make review_completed configurable per team and review type
This includes a migration to change mailtrigger slugs to be up to 64
characters instead of 32, as some slugs would not fit and require clunky
abbreviations.
A data migration creates triggers for existing teams, and they are also
created on the fly if a trigger does not exist yet, providing a safe
fallback for new review teams. The review_completed mailtrigger serves
as the template for new triggers.
This commit also includes tests for gather_address_lists(), as none
existed.

Commit ready for merge.
 - Legacy-Id: 16680
2019-08-30 17:40:55 +00:00
Henrik Levkowetz 7ad34ba69e The logic for displaying 'Email requested to be sent for earlier discuss' on IESG positions was wrong; it would count later discusses and discusses from other ADs as an 'earlier discuss'. Moved any_email_sent() from ballot to position, and refined the criteria.
- Legacy-Id: 16675
2019-08-28 20:56:34 +00:00
Sasha Romijn 88b7b45b0e Fix #2328 - Use mailtriggers to find destinations in review app
As the review app has several conditionals that don't fit
entirely well within mailtriggers, the templates use a bit
of extra context to figure out who exactly to include. This also
extends the tests for review, to check for correct recipients.
It also adds a tiny feature to mailtrigger to entirely exclude
certain addresses, as required by the review-generated mails.

Commit ready for merge.
 - Legacy-Id: 16672
2019-08-27 15:15:13 +00:00
Sasha Romijn 3942f9acc7 Fix #2590 - Allow secretary to adjust date when completing a review.
This also fixes other issues identified in #2590, around the
modification of historical document events. The behaviour is now:
- When the assigned reviewer posts a review, a single event is
  created, set to current date/time.
- When the secretary records a review in the datatracker, they may
  set a different completion date, which is autofilled if an email
  is selected. One event is generated for the original completion
  date, and one for the secretary's action.
- Each revision generates a new event, rather than updating previous
  existing events.
 - Legacy-Id: 16670
2019-08-26 12:58:31 +00:00
Sasha Romijn de9cde9e43 Fix #2560 - Sort names in history when changing list of members. Commit ready for merge.
- Legacy-Id: 16668
2019-08-23 11:57:40 +00:00
Sasha Romijn 4669b0934b Fix #2071 - Add optional comment field for close request. Commit ready for merge.
- Legacy-Id: 16667
2019-08-23 11:37:41 +00:00
Henrik Levkowetz dc6201eeeb Made sure Person.active_drafts() and .expired_drafts() don't return duplicate entries. Fixes issue #2784.
- Legacy-Id: 16665
2019-08-20 22:43:51 +00:00
Henrik Levkowetz 50d2160afe Removed a BOM
- Legacy-Id: 16664
2019-08-20 19:53:10 +00:00
Henrik Levkowetz 9a9c9fb426 Merged in [16603] from rjsparks@nostrum.com:
Remove a debug statement from the command
 - Legacy-Id: 16661
Note: SVN reference [16603] has been migrated to Git commit d27096f39022e9bee1ffa84631d5ae847af9be3e
2019-08-20 10:35:06 +00:00
Henrik Levkowetz 80db16632e Added a migration to fix some m2m table columns incorrectly left as varchar(8) when we changed the size of name slugs to varchar(32).
- Legacy-Id: 16660
2019-08-19 19:21:18 +00:00
Henrik Levkowetz 509e0da7ab Merged in [16601] from rjsparks@nostrum.com:
A management command to correct the state of several slide presentations uploaded during IETF105, and perform some missed powerpoint to pdf conversions.
 - Legacy-Id: 16659
Note: SVN reference [16601] has been migrated to Git commit a14188d95cf200dfbdd93485b89808f3336b0649
2019-08-19 17:50:56 +00:00
Robert Sparks e45a32e49f Add IANA expert review tracking. Commit ready for merge.
- Legacy-Id: 16656
2019-08-15 20:36:07 +00:00
Robert Sparks 38244111e4 Sigh. This is the last part of removing the todo page (along with r16650 and part of r16649. Apologies this got smeared out. Commit ready for merge.
- Legacy-Id: 16655
2019-08-15 20:35:20 +00:00
Robert Sparks 4d77769345 Remove the bootstrap project todo page. #2778 points to the old content so we can make new tickets for anything that is still relevant. r16649 unintentionally had part of what should have been in this commit (the changes to /ietf/release/urls.py). Commit ready for merge.
- Legacy-Id: 16650
2019-08-14 16:09:39 +00:00
Robert Sparks 01ceeba131 Guard against attempts to use the review request view with a ReviewRequest id that does not match the document for the ReviewRequest. This would have exposed #2776 much earlier. Commit ready for merge.
- Legacy-Id: 16649
2019-08-14 16:06:13 +00:00
Robert Sparks 87de06c97c Corrected a view that was looking at review assignment ids when it should have been looking at request review ids. Fixes #2776. Commit ready for merge.
- Legacy-Id: 16647
2019-08-13 18:13:50 +00:00
Robert Sparks 33838840d1 Don't manually linewrap when looking at feedback - let the pasted styling do that. Fixes #2761. Commit ready for merge.
- Legacy-Id: 16646
2019-08-12 19:22:39 +00:00
Henrik Levkowetz b2be7975c9 Merged in [16600] from rjsparks@nostrum.com:
Fixed a subtle bug in the code that converts slides to PDF that was writing back into settings.
 - Legacy-Id: 16645
Note: SVN reference [16600] has been migrated to Git commit b4714f95579efcb5051438239a5df002036c9975
2019-08-10 18:06:40 +00:00
Henrik Levkowetz 7e34b3cd60 Merged in [16599] from rjsparks@nostrum.com:
Correct the uploaded_filename for slides that go through the approve-proposed-slides workflow.
 - Legacy-Id: 16644
Note: SVN reference [16599] has been migrated to Git commit f6b05ae963b9933dc8522f5db86eb33086d8f040
2019-08-10 17:29:51 +00:00
Henrik Levkowetz 8a9e6911cd Merged in [16598] from rjsparks@nostrum.com:
Add the ppt* to pdf conversion to the approve-suggested-slides workflow. Fixes #2762.
 - Legacy-Id: 16643
Note: SVN reference [16598] has been migrated to Git commit c43dcaa8ea707c089fc66f52c361944cef1d4874
2019-08-10 17:00:49 +00:00
Henrik Levkowetz 5d2a22e052 Added textual information about patent aplication formats according, as input to future extension of the regex set.
- Legacy-Id: 16641
2019-08-10 16:42:10 +00:00
Henrik Levkowetz 92590b70bf Updated contact address and text for submission problems to streamline secretariat handling.
- Legacy-Id: 16639
2019-08-09 21:58:40 +00:00
Henrik Levkowetz 8f53f44953 Added some new formats to the regex validator for patent numbers and patent application numbers. This is still not comprehensive.
- Legacy-Id: 16638
2019-08-09 20:10:06 +00:00
Henrik Levkowetz 8e313e4ed5 Adjusted migrations for Python2/3 compatibility.
- Legacy-Id: 16633
2019-08-08 17:11:14 +00:00
Henrik Levkowetz 9a2c409238 Updated database options settings to match our production database and dump files.
- Legacy-Id: 16632
2019-08-08 13:10:24 +00:00
Robert Sparks 19a9ce9a95 Converted tabs to spaces. Whitespace changes only. Commit ready for merge.
- Legacy-Id: 16631
2019-08-07 20:27:57 +00:00
Robert Sparks 10422f87d2 Rework how we are labeling constraints to provide a quick-fix for session requests at IETF106. Turned off several javascript functions that added/enforced old (possibly no longer correct) semantics for the session request forms. Fixes #2754. Commit ready for merge.
- Legacy-Id: 16630
2019-08-07 02:03:15 +00:00
Robert Sparks 798a57c9ab Removing unused template. I think it was an artifact of the Django 1.2 to 1.6 conversion from 6 years ago.
- Legacy-Id: 16629
2019-08-06 21:41:10 +00:00
Henrik Levkowetz 22e0d39e4b Fixed an issue where text file charset information would be overwritten on upload of multiple files for a draft. Fixes issue #2768.
- Legacy-Id: 16626
2019-08-06 15:41:13 +00:00
Henrik Levkowetz 1eb1e0c242 Added 30 minutes caching to agenda.ics
- Legacy-Id: 16624
2019-08-05 17:24:56 +00:00
Henrik Levkowetz ce3368db82 Set version info and settings back to development mode
- Legacy-Id: 16622
2019-08-05 16:43:20 +00:00
Henrik Levkowetz 150edb13dc Set version info to release version 6.100.0 before branching.
- Legacy-Id: 16620
2019-08-05 16:43:10 +00:00
Peter E. Yee 7f6edfcabc Spelling correction in a comment. No open issue. Commit ready for merge.
- Legacy-Id: 16615
2019-08-04 23:58:43 +00:00
Peter E. Yee 390ff04722 Improved so that new draft diffs (from the working group drafts page) work correctly for both -00 drafts and later revisions. Fixes issue #2697. Commit ready for merge.
- Legacy-Id: 16614
2019-08-04 23:55:15 +00:00
Henrik Levkowetz 41c6bbf62e Merged in [16563] from housley@vigilsec.com:
Improve performance for a few pages
 - Legacy-Id: 16613
Note: SVN reference [16563] has been migrated to Git commit 765ce0d0b0
2019-08-04 15:44:06 +00:00
Henrik Levkowetz b541f5c246 Merged in [16594] from rjsparks@nostrum.com:
Use unversioned slide link from the materials popup from the agenda page. Fixes #2756.
 - Legacy-Id: 16612
Note: SVN reference [16594] has been migrated to Git commit 51a874dec4a06a707eb3547f6dd443cfbed94bd4
2019-08-03 20:42:46 +00:00
Henrik Levkowetz c27b285c58 Merged in [16593] from rjsparks@nostrum.com:
Sort the documents in the agenda, minutes, bluesheets section of the session_details view. Fixes #2759.
 - Legacy-Id: 16611
Note: SVN reference [16593] has been migrated to Git commit f2dd064afdc77168c12897a630600a17631b390f
2019-08-03 15:41:14 +00:00
Henrik Levkowetz 1a35504693 Merged in [16592] from rjsparks@nostrum.com:
Change how the session details page links to documents to not link to a specific version. Fixes #2758. See also #2756.
 - Legacy-Id: 16610
Note: SVN reference [16592] has been migrated to Git commit c6c086b122dbd57cb6a55ed7f68be4a8dfd877b6
2019-08-01 20:17:59 +00:00
Henrik Levkowetz 2b1dd0f3e8 Merged in [16590] from rjsparks@nostrum.com:
Example of using webtest. The full testcase was not converted because the add_rule form is modified in-flight by javascript when a control value is changed.
 - Legacy-Id: 16609
Note: SVN reference [16590] has been migrated to Git commit e89f200abc0d9af7609e4bff3592f87eddee1359
2019-08-01 15:09:51 +00:00
Henrik Levkowetz b873af1eac Merged in [16583] from rjsparks@nostrum.com:
Restore ability to remove documents while managing a personal list. Required updating code to match the recent change to Document's primary key. Fixes #2757.
 - Legacy-Id: 16608
Note: SVN reference [16583] has been migrated to Git commit 821609888a2c8a6db67867dd334103b034157d20
2019-08-01 14:27:00 +00:00
Ryan Cross 9a82586e1b Fix issue where third session requests, which rerequire AD approval, get left with approved status, instead of scheduled, after Secretraiat sends out notifications of official schedule. Fixes #2765. Commit ready for merge.
- Legacy-Id: 16607
2019-07-31 23:02:20 +00:00
Henrik Levkowetz baa639ba01 Merged in [16569] from rjsparks@nostrum.com:
Add quotes around document name in the mailarchive search link on a document's main page. Fixes #2659.
 - Legacy-Id: 16606
Note: SVN reference [16569] has been migrated to Git commit b4a40313c95511693ae8a361aabb355878555fb7
2019-07-31 22:04:16 +00:00
Henrik Levkowetz 4e131f1f2e Merged in [16589] from rjsparks@nostrum.com:
Show a calendar of upcoming meetings. Fixes #2719.
 - Legacy-Id: 16602
Note: SVN reference [16589] has been migrated to Git commit d3b70a46b882979fabb82972921a6ad177c06b08
2019-07-31 15:21:20 +00:00
Henrik Levkowetz 2418459afc Prevent login case issues by generating apache permissions file entries for both uppercase and lowercase logins.
- Legacy-Id: 16597
2019-07-29 19:20:38 +00:00
Henrik Levkowetz 19d38356a0 Preliminary work on converting bower management of web resources to yarn. New management command, replacing bower_install will be needed.
- Legacy-Id: 16591
2019-07-25 20:28:18 +00:00
Henrik Levkowetz 0a591e4b2e Merged in [16562] from rcross@amsl.com:
Added encoding='utf-8' parameter to io.open operations in tests that starting failing since adding unicode_literals.
 - Legacy-Id: 16588
Note: SVN reference [16562] has been migrated to Git commit d332bfd91d
2019-07-24 23:44:36 +00:00
Henrik Levkowetz 4fb9f8ba19 Merged in [16561] from rjsparks@nostrum.com:
Prompt for login for approving slide suggestions instead of just presenting an error. Fixes #2750.
 - Legacy-Id: 16587
Note: SVN reference [16561] has been migrated to Git commit c80d7072104bbc8bb68281a0dcb442e4971c7dad
2019-07-24 22:51:54 +00:00
Henrik Levkowetz de43926eba Merged in [16559] from fenton@bluepopcorn.net:
Added Closing Notes to history and about pages for groups. Fixes issue #2725.
 - Legacy-Id: 16586
Note: SVN reference [16559] has been migrated to Git commit 93b4d6fcc4
2019-07-24 19:49:45 +00:00
Henrik Levkowetz 1ea89276ce Merged in [16558] from rjsparks@nostrum.com:
Make removed IPR disclosures visually distinctive on search results. Partially addresses #2687.
 - Legacy-Id: 16585
Note: SVN reference [16558] has been migrated to Git commit b4a27c59164d13a0840d285532355e0af696be33
2019-07-24 19:04:45 +00:00
Henrik Levkowetz 07c5e33bc4 Added conditional decoding of bytes subject text, before interpolating into a new unicode string.
- Legacy-Id: 16577
2019-07-22 18:19:55 +00:00
Henrik Levkowetz 7039520557 Merged in [16557] from pusateri@bangj.com:
Partially addresses issue #1926 still displaying markdown as text. Fixes #2704.
 - Legacy-Id: 16576
Note: SVN reference [16557] has been migrated to Git commit f76c46bef0
2019-07-22 18:09:53 +00:00
Henrik Levkowetz 5a1c35909a Updated a test to match the change in r16560
- Legacy-Id: 16575
2019-07-22 17:55:29 +00:00
Henrik Levkowetz 915d8e3c2a Added LookupError to the exceptions caught during text upload decoding, leading to upload form validation error.
- Legacy-Id: 16573
2019-07-22 15:47:40 +00:00
Henrik Levkowetz 7b08563edd Added a migration for the slidesubmission.time field
- Legacy-Id: 16571
2019-07-21 21:05:22 +00:00
Henrik Levkowetz 23ac054ad6 Merged in [16554] from rjsparks@nostrum.com:
Rework how SlideSuggestion objects name their files. Improve the UI when there are multiple pending suggestions for updating the same presentation.
 - Legacy-Id: 16570
Note: SVN reference [16554] has been migrated to Git commit 1e8eb0ed6d227e32816c4bc352a7301691eaaaac
2019-07-21 21:03:13 +00:00
Tom Pusateri 65b3f93afe Convert markdown to html if Accept header prioritizes text/html over text/markdown. Fixes #1926. Commit ready for merge.
- Legacy-Id: 16564
2019-07-21 03:14:35 +00:00
Russ Housley 765ce0d0b0 Improve performance for a few pages
- Legacy-Id: 16563
2019-07-20 22:59:26 +00:00
Ryan Cross d332bfd91d Added encoding='utf-8' parameter to io.open operations in tests that starting failing since adding unicode_literals. Commit ready to merge
- Legacy-Id: 16562
2019-07-20 22:54:14 +00:00
Henrik Levkowetz c22d0b9540 Show group pages also for groups of type adhoc and ise.
- Legacy-Id: 16560
2019-07-20 20:10:08 +00:00
Jim Fenton 93b4d6fcc4 Added Closing Notes to history and about pages for groups. Fixes issue #2725. Commit ready for merge.
- Legacy-Id: 16559
2019-07-20 19:47:32 +00:00
Tom Pusateri f76c46bef0 Partially addresses issue #1926 still displaying markdown as text. Fixes #2704. Commit ready for merge.
- Legacy-Id: 16557
2019-07-20 18:58:34 +00:00
Henrik Levkowetz 3d35cb028b Added another check before building submitter email for mailtrigger entries.
- Legacy-Id: 16550
2019-07-19 00:16:11 +00:00
Henrik Levkowetz c3ffd09c6b Set version info and settings back to development mode
- Legacy-Id: 16528
2019-07-18 20:35:08 +00:00
Henrik Levkowetz 33db5c523a Set version info to release version 6.99.1 before branching.
- Legacy-Id: 16526
2019-07-18 20:34:55 +00:00
Henrik Levkowetz 8adae6176d Improved a check for authenticated user.
- Legacy-Id: 16521
2019-07-18 19:30:01 +00:00
Henrik Levkowetz b3244242aa Fixed some issues with the Py2/3 changes to the populate_yang_model_dirs management command.
- Legacy-Id: 16520
2019-07-18 18:53:14 +00:00
Henrik Levkowetz ee369934b2 Added a check for submitter found before trying to get name and email.
- Legacy-Id: 16519
2019-07-18 17:08:55 +00:00
Henrik Levkowetz 8ec951c44a Shortened generated document titles a tad, to avoid line wrapping in the IESG agenda package (which breaks the relevant test).
- Legacy-Id: 16518
2019-07-18 10:17:17 +00:00
Henrik Levkowetz e3f083e6d3 Merged in [16515] from rjsparks@nostrum.com:
Save files correctly when updates to an existing set of slides are proposed. Fixes #2748.
 - Legacy-Id: 16517
Note: SVN reference [16515] has been migrated to Git commit 41fd67c6847b82d9e9f006f5bb79c03bc5b8b577
2019-07-17 21:25:46 +00:00
Henrik Levkowetz fb3d4ddb0b Added information about versions (Datatracker, Python, and Django) at the beginning of test suite runs.
- Legacy-Id: 16516
2019-07-17 20:54:51 +00:00
Henrik Levkowetz bbff4b0e69 Replaced six.ensure_str with django's force_str
- Legacy-Id: 16513
2019-07-17 18:43:40 +00:00
Henrik Levkowetz 57e16bfd57 Fixed a typo.
- Legacy-Id: 16511
2019-07-17 16:14:55 +00:00
Henrik Levkowetz 618d6021b0 Read pdf files as binary.
- Legacy-Id: 16510
2019-07-17 16:05:19 +00:00
Henrik Levkowetz db47cb6b0f Replaced the error on bad Submission.submitter email address with syslog logging.
- Legacy-Id: 16509
2019-07-17 14:30:57 +00:00
Henrik Levkowetz 9170395905 Added a email gather handler for submission_submitter that tries an Alias name lookuup if the submitter doesn't look as if it contains an email address.
- Legacy-Id: 16508
2019-07-17 14:29:42 +00:00
Henrik Levkowetz 6ea87414b5 Fixed some issues with the changed import path of ietf.settings_local.
- Legacy-Id: 16507
2019-07-17 14:27:26 +00:00
Henrik Levkowetz 820539e822 Changed import path for settings_local.py to work with absolute_import under Py2, and also under Py3.
- Legacy-Id: 16506
2019-07-17 13:42:36 +00:00
Henrik Levkowetz 6ef24e9c4e Changed agenda file reading to read files as binary when looking for draft names listed in the agenda.
- Legacy-Id: 16505
2019-07-17 13:38:46 +00:00
Henrik Levkowetz 8d2d732210 Set version info and settings back to development mode
- Legacy-Id: 16480
2019-07-16 22:22:16 +00:00
Henrik Levkowetz 88c2ade196 Set version info to release version 6.99.0 before branching.
- Legacy-Id: 16478
2019-07-16 22:22:03 +00:00
Henrik Levkowetz 627f8a7eab Modified code to write release coverage json data to gzip file under both Py2 and Py3.
- Legacy-Id: 16475
2019-07-16 21:58:38 +00:00
Henrik Levkowetz f47212f239 Use BinaryField instead of our own EncryptedTextField which relied on cleartext and ciphertext being the same type.
- Legacy-Id: 16472
2019-07-16 19:28:45 +00:00
Henrik Levkowetz ad1821f63a Enabled the wiki management command under py2
- Legacy-Id: 16471
2019-07-16 19:12:00 +00:00
Henrik Levkowetz e03784132d Merged changes from current trunk to Py3 branch.
- Legacy-Id: 16468
2019-07-16 15:36:16 +00:00
Henrik Levkowetz c51e211fba Set version info and settings back to development mode
- Legacy-Id: 16466
2019-07-16 14:14:45 +00:00
Henrik Levkowetz 88af016f36 Set version info to release version 6.98.4 before branching.
- Legacy-Id: 16464
2019-07-16 14:14:29 +00:00
Henrik Levkowetz bdc73e771a Python2/3 compatibility: replaced six.ensure_text() with either six.text_type or django's force_text(), depending on the case, and fixed a variable scope issue.
- Legacy-Id: 16461
2019-07-16 13:20:05 +00:00
Henrik Levkowetz ef4a41c14b Fixed a bytes/str issue with the arguments to syslog.openlog()
- Legacy-Id: 16460
2019-07-16 13:18:37 +00:00
Henrik Levkowetz 46aec6eb85 Python2/3 compatibility: tentative version of create_group_wikis; may need more work.
- Legacy-Id: 16459
2019-07-16 13:17:12 +00:00
Henrik Levkowetz 8c6eb3a30a Python2/3 compatibility: Changed the use of open() and StringIO to io.open() etc.
- Legacy-Id: 16458
2019-07-15 19:14:04 +00:00
Henrik Levkowetz 44f51c1d64 The beginning of a dev file download helper.
- Legacy-Id: 16456
2019-07-15 19:03:35 +00:00
Henrik Levkowetz ea8c84d2f6 Python2/3 compatibility: used @python_2_unicode_compatible to provide __unicode__() versions of __str__() methods.
- Legacy-Id: 16455
2019-07-15 18:01:26 +00:00
Henrik Levkowetz 2cfb81fc83 Changed instances of email body extaction to use a custom get_payload() function.
- Legacy-Id: 16454
2019-07-15 17:15:16 +00:00
Henrik Levkowetz 99a7f9c263 Python2/3 compatibility: Added force_str or force_bytes in some places, to ensure the argument right type
- Legacy-Id: 16453
2019-07-15 17:13:46 +00:00
Henrik Levkowetz a5e31c3f40 Py2/3 compatibility: Added __future__ import.
- Legacy-Id: 16452
2019-07-15 15:52:18 +00:00
Henrik Levkowetz 28472a462b Python2/3 compatibility: Added more elements to list (tuple) entries to ensure sorting without exceptions under Python3.
- Legacy-Id: 16451
2019-07-15 15:51:26 +00:00
Henrik Levkowetz 831fb18f8a Python2/3 compatibility: Added force_str or force_bytes in some places, to ensure the argument right type
- Legacy-Id: 16450
2019-07-15 15:49:35 +00:00
Henrik Levkowetz eb42394534 Py2/3 compatibility: Added __future__ import.
- Legacy-Id: 16449
2019-07-15 15:47:31 +00:00
Henrik Levkowetz 855716e1d5 Py2/3 compatibility: Added __future__ import
- Legacy-Id: 16448
2019-07-15 15:46:06 +00:00
Henrik Levkowetz 1fae7839e2 Py2/3 compatibility: Added __future__ import and an explicit encoding scheme, not relying on py3's implicit utf-8
- Legacy-Id: 16447
2019-07-15 15:44:38 +00:00
Henrik Levkowetz 2d7c9629aa Added 'from __future__' imports all over the place, to bring code behaviour into closer alignment between python2 and python3
- Legacy-Id: 16446
2019-07-15 15:40:51 +00:00
Henrik Levkowetz 6ace81b25d Corrected the order of string prefix 'r' and 'b' under python2.
- Legacy-Id: 16445
2019-07-15 15:37:48 +00:00
Henrik Levkowetz 19afa444f8 Changed the redirect tests to accept a set of correct redirect urls, rather than one single, since the queryarg order isn't stable across python versions.
- Legacy-Id: 16444
2019-07-15 15:36:38 +00:00
Henrik Levkowetz 01ece5bddc Added a warnings filter and a conversion of syslgog tag argument to 'str'.
- Legacy-Id: 16443
2019-07-15 15:35:17 +00:00
Henrik Levkowetz 71ea5ae379 Updated the file header generated by the makeresources managment command to set Copyright and file encoding, and use io.open() for py2/3 compatibility.
- Legacy-Id: 16441
2019-07-15 14:35:25 +00:00
Henrik Levkowetz ccf58c9526 Removed a couple of old unused setting variables, and added the equivalent current one.
- Legacy-Id: 16440
2019-07-09 15:56:38 +00:00
Henrik Levkowetz 58eca93f9a Added validation of email addresses extracted by get_email_addresses_from_text().
- Legacy-Id: 16439
2019-07-09 13:02:49 +00:00
Henrik Levkowetz 6732e7acff Fixed an issue with a gzip file mode.
- Legacy-Id: 16436
2019-07-08 18:30:34 +00:00
Henrik Levkowetz 4f19a9f6ef Updated the datatracker ADMINS list.
- Legacy-Id: 16435
2019-07-08 18:18:32 +00:00
Henrik Levkowetz 8a8138eb18 Added a debug import.
- Legacy-Id: 16434
2019-07-08 18:14:40 +00:00
Henrik Levkowetz edc1da3023 Added a validation step for SearchablePersonField, to avoid later server 500 errors on bad input.
- Legacy-Id: 16433
2019-07-08 18:14:05 +00:00
Henrik Levkowetz f481f5c3e6 Replaced use of six with the equivalent pure python3 constructs.
- Legacy-Id: 16428
2019-07-08 10:43:47 +00:00
Henrik Levkowetz 4094a472d7 Removed a debug print call.
- Legacy-Id: 16426
2019-07-07 21:04:10 +00:00
Henrik Levkowetz 10f623cc75 Merged in [16096] from rcross@amsl.com:
Update admin permissions. Grant secretariat change permissions on dbtemplate so they can update proceedings pages.
 - Legacy-Id: 16424
Note: SVN reference [16096] has been migrated to Git commit 3089404f3d
2019-07-07 19:26:50 +00:00
Henrik Levkowetz 13c69a1a55 Turned off html autoescape in IPR email templates.
- Legacy-Id: 16423
2019-07-07 13:14:42 +00:00
Henrik Levkowetz 671b4035ea Fixed a syntax issue and removed debug calls.
- Legacy-Id: 16421
2019-07-07 13:04:54 +00:00
Henrik Levkowetz 48bab56be9 Removed a print() call
- Legacy-Id: 16420
2019-07-07 13:04:20 +00:00
Henrik Levkowetz 472a3ed039 Refined our parseaddr() to deal correctly with both bytes and str
- Legacy-Id: 16419
2019-07-07 13:03:11 +00:00
Henrik Levkowetz 10380e22b5 Added another warnings filter.
- Legacy-Id: 16418
2019-07-07 13:00:00 +00:00
Henrik Levkowetz 63f0896644 Changed tobinary file mode for pdf file. Fixed a str/num comparison.
- Legacy-Id: 16417
2019-07-07 12:59:26 +00:00
Henrik Levkowetz 9d5641da64 Removed unnecessary asserts on r.status_code; this will be checked by assertContains().
- Legacy-Id: 16416
2019-07-07 12:58:01 +00:00
Henrik Levkowetz ec571401fe Fixed a base64 bytes/str issue.
- Legacy-Id: 16415
2019-07-07 12:51:58 +00:00
Henrik Levkowetz 4368e8cca1 Corrected a comment
- Legacy-Id: 16414
2019-07-07 12:51:06 +00:00
Henrik Levkowetz dfd3b60322 Removed tests for the confirm_acronym field removed in [16412].
- Legacy-Id: 16413
Note: SVN reference [16412] has been migrated to Git commit 1997a90d10
2019-07-07 12:50:27 +00:00