Merged in [16825] from rjsparks@nostrum.com:

Don't copy early reviews to ietf_last_call by default.
 - Legacy-Id: 16884
Note: SVN reference [16825] has been migrated to Git commit 54c221b6e03b573041600645d34316292e058d66

ietf/mailtrigger/migrations/0012_dont_last_call_early_reviews.py

@@ -0,0 +1,28 @@
+# Copyright The IETF Trust 2019, All Rights Reserved
+# -*- coding: utf-8 -*-
+# Generated by Django 1.11.25 on 2019-10-04 13:12
+from __future__ import unicode_literals
+
+from django.db import migrations
+
+def forward(apps, shema_editor):
+    MailTrigger = apps.get_model('mailtrigger', 'MailTrigger')
+    for trigger in MailTrigger.objects.filter(slug__startswith='review_completed',slug__endswith='early'):
+        trigger.cc.remove('ietf_last_call')
+
+
+def reverse(apps, shema_editor):
+    MailTrigger = apps.get_model('mailtrigger', 'MailTrigger')
+    for trigger in MailTrigger.objects.filter(slug__startswith='review_completed',slug__endswith='early'):
+        trigger.cc.add('ietf_last_call')
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ('mailtrigger', '0011_ietf_last_call'),
+    ]
+
+    operations = [
+        migrations.RunPython(forward, reverse),
+    ]

ietf/mailtrigger/utils.py

@@ -50,6 +50,8 @@ def get_mailtrigger(slug, create_from_slug_if_not_exists, desc_if_not_exists):
             mailtrigger = MailTrigger.objects.create(slug=slug, desc=desc_if_not_exists)
             mailtrigger.to.set(template.to.all())
             mailtrigger.cc.set(template.cc.all())
+            if slug.startswith('review_completed') and slug.endswith('early'):
+                mailtrigger.cc.remove('ietf_last_call')
         else:
             raise
     return mailtrigger

ietf/name/fixtures/names.json

@@ -4010,7 +4010,6 @@
   {
     "fields": {
       "cc": [
-        "ietf_last_call",
         "review_doc_all_parties",
         "review_doc_group_mail_list"
       ],
@@ -4055,7 +4054,6 @@
   {
     "fields": {
       "cc": [
-        "ietf_last_call",
         "review_doc_all_parties",
         "review_doc_group_mail_list"
       ],
@@ -4100,7 +4098,6 @@
   {
     "fields": {
       "cc": [
-        "ietf_last_call",
         "review_doc_all_parties",
         "review_doc_group_mail_list"
       ],
@@ -4145,7 +4142,6 @@
   {
     "fields": {
       "cc": [
-        "ietf_last_call",
         "review_doc_all_parties",
         "review_doc_group_mail_list"
       ],
@@ -4190,7 +4186,6 @@
   {
     "fields": {
       "cc": [
-        "ietf_last_call",
         "review_doc_all_parties",
         "review_doc_group_mail_list"
       ],
@@ -4235,7 +4230,6 @@
   {
     "fields": {
       "cc": [
-        "ietf_last_call",
         "review_doc_all_parties",
         "review_doc_group_mail_list"
       ],
@@ -4280,7 +4274,6 @@
   {
     "fields": {
       "cc": [
-        "ietf_last_call",
         "review_doc_all_parties",
         "review_doc_group_mail_list"
       ],
@@ -4325,7 +4318,6 @@
   {
     "fields": {
       "cc": [
-        "ietf_last_call",
         "review_doc_all_parties",
         "review_doc_group_mail_list"
       ],
@@ -4370,7 +4362,6 @@
   {
     "fields": {
       "cc": [
-        "ietf_last_call",
         "review_doc_all_parties",
         "review_doc_group_mail_list"
       ],
@@ -4415,7 +4406,6 @@
   {
     "fields": {
       "cc": [
-        "ietf_last_call",
         "review_doc_all_parties",
         "review_doc_group_mail_list"
       ],