Merged in [16977] from rjsparks@nostrum.com:

Disregard unassigned reviews when building the sets to compare when checking for race-conditions on assigning reviews. Partially addresses #2821.
 - Legacy-Id: 16980
Note: SVN reference [16977] has been migrated to Git commit 5c08b4096a
This commit is contained in:
Henrik Levkowetz 2019-11-07 23:00:38 +00:00
commit 49e0c26d9e

View file

@ -1507,6 +1507,7 @@ def manage_review_requests(request, acronym, group_type=None, assignment_status=
# check for conflicts
review_requests_dict = { six.text_type(r.pk): r for r in review_requests if r.pk}
posted_reqs = set(request.POST.getlist("reviewrequest", []))
posted_reqs.discard(u'None')
current_reqs = set(review_requests_dict.keys())
closed_reqs = posted_reqs - current_reqs