Disregard unassigned reviews when building the sets to compare when checking for race-conditions on assigning reviews. Partially addresses #2821. Commit ready for merge.

- Legacy-Id: 16977
2019-11-07 16:16:33 +00:00 · 2019-11-07 16:16:33 +00:00 · 5c08b4096a
parent a69459623c
commit 5c08b4096a
1 changed files with 1 additions and 0 deletions
--- a/ietf/group/views.py
+++ b/ietf/group/views.py
@ -1507,6 +1507,7 @@ def manage_review_requests(request, acronym, group_type=None, assignment_status=
        # check for conflicts
        review_requests_dict = { six.text_type(r.pk): r for r in review_requests if r.pk}
        posted_reqs = set(request.POST.getlist("reviewrequest", []))
+        posted_reqs.discard(u'None')
        current_reqs = set(review_requests_dict.keys())

        closed_reqs = posted_reqs - current_reqs