Remove the rest of the log.assertions checking that iesg_state existed in places we expected it to. Removed unnecessary imports.
- Legacy-Id: 17522
Note: SVN reference [17496] has been migrated to Git commit db5d11ea32
for displaying violated constraints in the new schedule editor, with
the old of a new field, ConstraintName.editor_label.
Add support for displaying room capacity violations.
Add support for selecting a session and displaying information about
it similar to the existing scheduling editor.
Add support for sorting unassigned sessions.
Clean up markup and styles a bit, and fix some bugs.
Expand HTML-based test and add JS test that exercises the
Javascript-based functionality.
Switch to using Chrome driver instead of PhantomJS since the HTML
engine in PhantomJS is apparently too old to support the constructs in
the new schema editor.
Add a workaround for LiveServerTestCase clashing with IetfTestRunner
fixture loading.
- Legacy-Id: 17519
Remove log.assertion that was checking that we covered the edges when we changed documents to always have an iesg state.
- Legacy-Id: 17517
Note: SVN reference [17495] has been migrated to Git commit f2b106cf8c
Use current email addresses when we have them when listing document authors. Fixes#1902.
- Legacy-Id: 17516
Note: SVN reference [17494] has been migrated to Git commit 8583a0a098
Changed awkward IESG/IAB Nominating Committee names to just NomCom, updated a ref. Fixes#2860.
- Legacy-Id: 17515
Note: SVN reference [17493] has been migrated to Git commit cf98a644e3da5d2a4303156048ef6aed039f908e
On session request form make Special Requests field smaller and display 200 character limit. Fixes#2875.
- Legacy-Id: 17514
Note: SVN reference [17492] has been migrated to Git commit a99c37cd47
Basic regex validation on community rule entry form. Fixes#2928.
- Legacy-Id: 17512
Note: SVN reference [17490] has been migrated to Git commit 70a20b3e8c
Remove redundant URL secr/groups/search because search page is available here secr/groups. Resolves issue with Add link. Fixes#2708.
- Legacy-Id: 17511
Note: SVN reference [17489] has been migrated to Git commit 5d3601334e
Remove drafts secretariat tool because this functionality is now provided by the core Datatracker. Moved ID reports to proceedings tool. Fixes#1655.
- Legacy-Id: 17508
Note: SVN reference [17488] has been migrated to Git commit 5649bfdfd1
Let chairs know what to do after material submission uploads have been cut off. Fixes#2887.
- Legacy-Id: 17507
Note: SVN reference [17487] has been migrated to Git commit ebdadf38f2
When requesting a new WG session, and retrieving information about the previous session, look back to the previous time the group met, instead of simply checking the previous IETF meeting and maybe not finding any information to retrieve.
- Legacy-Id: 17504
Note: SVN reference [17484] has been migrated to Git commit 88f11669fd
Changed so that only WGs/RGs can be closed, per RJS. Fixes#1578.
- Legacy-Id: 17503
Note: SVN reference [17483] has been migrated to Git commit 4737f0588e
Show UTC times in interim announcements if the interim has a non-UTC timzone. Fixes#2922.
- Legacy-Id: 17482
Note: SVN reference [17480] has been migrated to Git commit 091ac7e37f
Make required AD approval of virtual interims configurable. Fixes#2912.
- Legacy-Id: 17426
Note: SVN reference [17425] has been migrated to Git commit 6248706959
Don't warn about idcutoff when the cutoff is after the meeting starts. Fixes#2907.
- Legacy-Id: 17422
Note: SVN reference [17419] has been migrated to Git commit edc41a8705
Move charters for replaced groups to a new replaced state. Close any outstanding ballots on them. Fixes#2889, #2873, and #1286.
- Legacy-Id: 17420
Note: SVN reference [17396] has been migrated to Git commit 79bb245f8a
per day. This opens the possibility of having the slots not match
across the different rooms.
Add colors to session in areas/IRTF. Add support for toggling display
of areas/IRTF.
Show graphical hint when a time slot is overfull.
- Legacy-Id: 17415
basic version with timeslots in a fixed grid and drag and drop for
assigning and unassigning. Compared to the existing JS based view, it
is missing session details (attendences etc.), conflicts and other
warnings, toggling of sessions in areas, area coloring, extending to
next timeslot and probably more.
Add new auxiliary view to copy a schedule for the new schedule editor.
- Legacy-Id: 17389
The new timerange, time_relation and wg_adjacent constraints, along with the
joint_with_groups option, are now reflected in the special requests field.
This allows them to be taken into account while scheduling sessions.
- Legacy-Id: 17378
Add rfp-announce@ietf.org to Announcement app To: address list. Changed name of secr dashboard from WG Chair Dahsboard to IETF Dashboard.
- Legacy-Id: 17359
Note: SVN reference [17336] has been migrated to Git commit b1b27e648c
Allow review team secretaries and the secretariat to reset the next reviewer in queue for review teams using the RotateAlphabetically policy. Partially addresses #2879.
- Legacy-Id: 17358
Note: SVN reference [17325] has been migrated to Git commit afb818c298
- Also adds additional tests for the SessionForm
- Fixes a javascript error in session requests for non-WG groups,
that could cause incorrect form behaviour.
- Expands the tests added in [17289] a bit.
- Legacy-Id: 17321
Note: SVN reference [17289] has been migrated to Git commit a227813dc5
Make internal review email about an RG use the IRSG instead of the IESG in text and addresses. Fixes#2881.
- Legacy-Id: 17307
Note: SVN reference [17288] has been migrated to Git commit 4cce1b5e08
Default use_milestone_dates to True. Allow changing use_milestone_dates from the edit milestone dates form for charters if it is the initial chartering effort. Fixes#2884.
- Legacy-Id: 17306
Note: SVN reference [17287] has been migrated to Git commit 3568e72ec5
Create DocEvent when related IprDisclosure is posted or removed. Fixes#2811.
- Legacy-Id: 17291
Note: SVN reference [17284] has been migrated to Git commit b02b42da81
This impacts scheduling, because area meetings should not conflict with any
other session from their area. However, several area meetings have type WG,
and therefore look like ordinary WGs apart from meeting scheduling conflicts.
This new flag will allow distinguishing regular WGs from WGs whose meetings
must not conflict with anything else from their area.
The included migration sets this flag for the currently known area meetings:
dispatch, gendispatch, intarea, opsarea/opsawg, rtgarea, rtgwg, saag,
secdispatch, tsvarea, irtfopen
- Legacy-Id: 17290
This adds three new constraints to the database and relevant UIs:
- timerange: "This WG can't meet during these timeframes"
- wg_adjacent: "Schedule adjacent to another WG (directly following,
no breaks, same room)"
- time_relation: schedule the two sessions of one WG on subsequent
days or with at least one day seperation
- Legacy-Id: 17289
Add links to user profiles from nominee list and feedback page. Fixes#2839.
- Legacy-Id: 17283
Note: SVN reference [17275] has been migrated to Git commit cd77c76372
Set a meaningful state in a test fixture. Tests surprisingly were not broken by this though.
- Legacy-Id: 17272
Note: SVN reference [17268] has been migrated to Git commit 8a5f960569
Improve the tests for session draft bundles to exercise the code that extracts draftnames from agendas.
- Legacy-Id: 17271
Note: SVN reference [17266] has been migrated to Git commit a5dab5385c
Restrict the ability to change whether a group uses milestone dates to the ADs and the secretariat. Fixes#2869.
- Legacy-Id: 17236
Note: SVN reference [17234] has been migrated to Git commit b4ac9f83f1
Be clear about who changed a group's personnel in the resulting email message. Fixes#2868.
- Legacy-Id: 17235
Note: SVN reference [17233] has been migrated to Git commit f0f522322a
Update some uses of pos.ad in templates to pos.balloter. Fixes#2863.
- Legacy-Id: 17224
Note: SVN reference [17219] has been migrated to Git commit af0a9954fe
Tighten validation of session conflicts in the session request tool,
preventing conflicts where source = target. Make sure the 'use
previous session' button doesn't carry forward conflicts that are no
longer valid.
Also fix a bug with the group list in the dropdowns being computed
statically at module import time instead of being queried dynamically
upon each page request.
- Legacy-Id: 17222
Note: SVN reference [17217] has been migrated to Git commit c34fec535f
Upgrade to the newer js-cookie library that replaced jquery.cookie. Fixes#2832.
- Legacy-Id: 17221
Note: SVN reference [17211] has been migrated to Git commit d9ea373b81
preventing conflicts where source = target. Make sure the "use
previous session" button doesn't carry forward conflicts that are no
longer valid.
Also fix a bug with the group list in the dropdowns being computed
statically at module import time instead of being queried dynamically
upon each page request.
Commit ready for merge
- Legacy-Id: 17217
Make it easier for the nomcom chair to manage generic IESG requirements. Fixes#2794.
- Legacy-Id: 17216
Note: SVN reference [17201] has been migrated to Git commit c9d944b312
Update admin permissions. Grant access to LiaisonStatementGroupContacts.
- Legacy-Id: 17199
Note: SVN reference [17195] has been migrated to Git commit 1f1d88fe24
Fix problem with assignments to the same session causing a crash.
- Legacy-Id: 17192
Note: SVN reference [17181] has been migrated to Git commit b9e5c9b967
Add references and referened-by buttons to each RFC listed on the peron profile page. In addition, changed the buttons on the document references and document referenced-by pages to match the buttons on the main document page (the buttons with the long arrows). Fixes#2854, although it does not include the number of references in the button.
- Legacy-Id: 17191
Note: SVN reference [17179] has been migrated to Git commit 3460f9242f
Works around a problem with displaying IESG evaluation information for non-approve ballot types. Partially addresses #2851.
- Legacy-Id: 17183
Note: SVN reference [17173] has been migrated to Git commit 5773d62c1b
This provides support for IRSG ballots, similar to the IESG ballots support which has been in use for quite some time. The IRSG ballots differ from IESG ballots in a number of ways, described in detail in the RFP and SoW for this work and implemented here.
- Legacy-Id: 17164
Only gather addresses instead of name_addrs for the group_secretaries Mailtrigger Recipient. Fixes#2847.
- Legacy-Id: 17156
Note: SVN reference [17148] has been migrated to Git commit d22da6259b
* Renamed Meeting.agenda to Meeting.schedule together with a bunch of related
internal things
* Moved Session.status, .requested, and .requested_by to a new SchedulingEvent.
* Turned sessions into regular sessions and non-sessions into misc.
sessions in the UI and code to avoid ambiguity.
This doesn't change the data in the DB except for uses of
TimeSlotTypeName where 'session' is now 'regular'.
- Legacy-Id: 17153
Add links to the main website and the mailarchive to the search page.
- Legacy-Id: 17145
Note: SVN reference [17120] has been migrated to Git commit 54fea0ff57
sessions in the UI and code to avoid ambiguity.
This doesn't change the data in the DB except for uses of
TimeSlotTypeName where 'session' is now 'regular'.
- Legacy-Id: 17128
This abstracts queue management, making it possible to implement different
policies for each team. It provides two concrete policies:
RotateAlphabeticallyReviewerQueuePolicy, which rotates an alphabetically
ordered reviewer list with consideration for skip indications, and is the
default policy; and LeastRecentlyUsedReviewerQueuePolicy, a simple
least-recently-used policy. Also see issues #2721 and #2656.
- Legacy-Id: 17121
Fix#2278 - Notify secretary when a review request is closed.
The assigned reviewer was already notified, but secretaries were always
excluded.
- Legacy-Id: 17108
Note: SVN reference [17085] has been migrated to Git commit 56003f66d8
Fix#2061 - Improve 'complete review' workflow for secretaries.
When a secretary completes a review, 'link to a review message'
is automatically selected, and the first non-reply mail is used to
fill in the review details. The secretary can still modify all details.
The order of fields for secretaries is also modified to fit this workflow.
All cases where 'link to review message' is used, by reviewers or
secretaries, now attempt to fill in the 'reviewed version' if found
in the email subject.
- Legacy-Id: 17105
Note: SVN reference [17070] has been migrated to Git commit dc9546211f
Fix#2074, fix#2358 - Add history for assignments, requests and unavailability.
- Legacy-Id: 17104
Note: SVN reference [17069] has been migrated to Git commit 65d84155b6
Moved hard coded defaults for max items to show and days to show to
the settings.py.
- Legacy-Id: 17099
Note: SVN reference [17083] has been migrated to Git commit 90428d6d5f
Use doc.name explicitly now that name is no lonker the pk. Pointed out by Sasha in #2050.
- Legacy-Id: 17089
Note: SVN reference [17071] has been migrated to Git commit f0a5fa6f9e
Change the default template for assigned review emails to name the assigned reviewer. Fixes#2830.
- Legacy-Id: 17073
Note: SVN reference [17062] has been migrated to Git commit 38e73b6f89
When a secretary completes a review, "link to a review message"
is automatically selected, and the first non-reply mail is used to
fill in the review details. The secretary can still modify all details.
The order of fields for secretaries is also modified to fit this workflow.
All cases where "link to review message" is used, by reviewers or
secretaries, now attempt to fill in the "reviewed version" if found
in the email subject.
Commit ready for merge.
- Legacy-Id: 17070
Allow slides drag-drop between sessions for groups meeting with multiple sessions. Fixes#2700.
- Legacy-Id: 17068
Note: SVN reference [17024] has been migrated to Git commit 1016b3a514
Note: SVN reference [17061] has been migrated to Git commit fabd2f6ca5
Make it clearer that a chair can't revise materials for a meeting once the proceedings deadline has passed
Fixes issue #2612.
- Legacy-Id: 17067
Note: SVN reference [17044] has been migrated to Git commit 182dae28a8
Added padding to the <th> column in the unavailability period list of
the reviewers page.
- Legacy-Id: 17065
Note: SVN reference [17037] has been migrated to Git commit c41e5b5ddb
Added two new configuration settings for the review team secretary,
one to set how many days to include in the reviewers list, and
another one to limit the number of completed items in the list for
each person. This version replaces the one I did earlier, and includes
much more test cases to test different limits on the reviewers page.
- Legacy-Id: 17057
Note: SVN reference [17034] has been migrated to Git commit b5d864499f
Reviewers can set this flag in their reviewer settings, which triggers
a mail to be sent to the secretary. They are then kept on top of the
recommended assignment order. This flag is automatically reset when any
assignment is made to the reviewer.
- Legacy-Id: 17048
Reviewers page template changes. Changed draft names so they never wrap.
Changed the Unavailability period table so it is much narrower.
- Legacy-Id: 17043
Note: SVN reference [17033] has been migrated to Git commit 996fcf8a54
Add edit button for Secreatriat on concluded groups. Fixes#2781.
- Legacy-Id: 17042
Note: SVN reference [17031] has been migrated to Git commit da2733610c
Adds Closing note field to state specific WG edit. Fixes#2779.
- Legacy-Id: 17039
Note: SVN reference [17028] has been migrated to Git commit 020d4a393c
one to set how many days to include in the reviewers list, and
another one to limit the number of completed items in the list for
each person. This version replaces the one I did earlier, and includes
much more test cases to test different limits on the reviewers page.
Commit ready for merge.
- Legacy-Id: 17034
Fix issue where draft resurrect feature does not move most recent draft file from the archive directory back to the current draft directory. Fixes#2646.
- Legacy-Id: 17032
Note: SVN reference [17027] has been migrated to Git commit 9882d7fda8
Look at the tree of replaces-relationships when determining if some reviewer has reviewed this (or perhaps an ancestor) of this document. Fixes#2821.
- Legacy-Id: 16992
Note: SVN reference [16981] has been migrated to Git commit f740adcfc1
Use the recently released shepherd writeup templates. Fixes#2820. ,
- Legacy-Id: 16991
Note: SVN reference [16966] has been migrated to Git commit fa00beab0e
Fix#2050 - Allow adding review wishes from document and search pages.
On the main page of a document and in document search results, a new
button allows review team members to add a review wish for that document.
For reviewers that are only on one team, this essentially works
identical to tracking a document. Reviewers that are on multiple teams
are lead through an intermediate step to select a review team, and then
returned to their search or document page.
- Legacy-Id: 16985
Note: SVN reference [16939] has been migrated to Git commit 6e55f26dbd
Convert markdown to html if Accept header prioritizes text/html over text/markdown. Fixes#1926.
- Legacy-Id: 16982
Note: SVN reference [16564] has been migrated to Git commit 65b3f93afe
Disregard unassigned reviews when building the sets to compare when checking for race-conditions on assigning reviews. Partially addresses #2821.
- Legacy-Id: 16980
Note: SVN reference [16977] has been migrated to Git commit 5c08b4096a
Fix#2088 - Sort unassigned review requests by doc name by default.
- Legacy-Id: 16952
Note: SVN reference [16934] has been migrated to Git commit f075eced5c
Fix#2119 - Allow specifying review type for suggested reviews in LC and telechat
If a review is suggested on the 'manage unassigned reviews' page, and
the document is in both last call and telechat, the assign form now asks
for the type of review that should be assigned.
This commit also fixes two bugs in this process:
- Comparisons in some cases between strings and integers
(group/views.py:1485/1487)
- Rejections when assigning suggested reviews, as they could be
considered a newly opened request due to not having a pk
(group/views.py:1508)
- Legacy-Id: 16951
Note: SVN reference [16933] has been migrated to Git commit ee4bc0cb07
Refs #2217 - Small cleanup from changeset [16924]
- Legacy-Id: 16947
Note: SVN reference [16924] has been migrated to Git commit 871a4b653b
Note: SVN reference [16927] has been migrated to Git commit 730e64d253
Flipped a sense to put the grace period on the right side of 'today' when sending review overdue reminders to team secretaries. Fixes#2816.
- Legacy-Id: 16940
Note: SVN reference [16926] has been migrated to Git commit 7560e116bf
On the main page of a document and in document search results, a new
button allows review team members to add a review wish for that document.
For reviewers that are only on one team, this essentially works
identical to tracking a document. Reviewers that are on multiple teams
are lead through an intermediate step to select a review team, and then
returned to their search or document page.
Commit ready for merge.
- Legacy-Id: 16939
Only show a blocked document once in the set of blocked documents on an ADs document page. Fixes#2818.
- Legacy-Id: 16938
Note: SVN reference [16937] has been migrated to Git commit 8f1e9990cf
If a review is suggested on the "manage unassigned reviews" page, and
the document is in both last call and telechat, the assign form now asks
for the type of review that should be assigned.
This commit also fixes two bugs in this process:
- Comparisons in some cases between strings and integers
(group/views.py:1485/1487)
- Rejections when assigning suggested reviews, as they could be
considered a newly opened request due to not having a pk
(group/views.py:1508)
Commit ready for merge.
- Legacy-Id: 16933
Fix#2217 - Allow submission of unsolicited reviews by secretaries.
- For team secretaries, a button 'Submit unsolicited review' will now
appear next to 'Request review' on the document's main page.
- If the secretary is a secretary for multiple teams, they are taken
through an intermediate page to select for which team they are
submitting their review.
- The form is similar (and using the same code) as the usual review
completion, with a few extra fields for the review type and reviewer,
which would usually already be known.
- When submitting the review, a ReviewRequest and ReviewAssignment are
automatically created. The assignment is then immediately closed in
the usual way.
- Other workflows are unchanged.
The issues with the review form in #2061 are slightly worse for the
unsolicited review scenario, but that will be improved when #2061 is
fixed.
- Legacy-Id: 16932
Note: SVN reference [16924] has been migrated to Git commit 871a4b653b
Fix#2087 - Show doc authors and WG chairs in unassigned reviews views.
- Legacy-Id: 16931
Note: SVN reference [16923] has been migrated to Git commit 93797b3fc1
Fix#2584 - Add additional content validation for uploaded texts.
Permitted MIME types are now text/plain, text/markdown and text/x-rst.
This applies to all usages of get_cleaned_text_file_content(),
including reviews, but also other similar places where text can either
be written either into a textarea or uploaded.
- Legacy-Id: 16930
Note: SVN reference [16922] has been migrated to Git commit fd53f98854
Fix#2123 - Use a DBTemplate when a review assignment is mailed.
The message sent to a reviewer when a new review is assigned to them,
is now taken from a DBTemplate, allowing it to be customised
per team. This includes a migration to create a default template,
which looks the same as before.
- Legacy-Id: 16928
Note: SVN reference [16921] has been migrated to Git commit 9df5839874
- For team secretaries, a button "Submit unsolicited review" will now
appear next to "Request review" on the document's main page.
- If the secretary is a secretary for multiple teams, they are taken
through an intermediate page to select for which team they are
submitting their review.
- The form is similar (and using the same code) as the usual review
completion, with a few extra fields for the review type and reviewer,
which would usually already be known.
- When submitting the review, a ReviewRequest and ReviewAssignment are
automatically created. The assignment is then immediately closed in
the usual way.
- Other workflows are unchanged.
The issues with the review form in #2061 are slightly worse for the
unsolicited review scenario, but that will be improved when #2061 is
fixed.
Commit ready for merge.
- Legacy-Id: 16924
Permitted MIME types are now text/plain, text/markdown and text/x-rst.
This applies to all usages of get_cleaned_text_file_content(),
including reviews, but also other similar places where text can either
be written either into a textarea or uploaded.
Commit ready for merge.
- Legacy-Id: 16922
The message sent to a reviewer when a new review is assigned to them,
is now taken from a DBTemplate, allowing it to be customised
per team. This includes a migration to create a default template,
which looks the same as before.
Commit ready for merge.
- Legacy-Id: 16921
Fix#2118 - Always list all last call drafts in assignment summary.
If a draft is scheduled for a telechat, but also assigned for LC review,
it will now be listed both in the telechat section and under 'last calls'.
- Legacy-Id: 16913
Note: SVN reference [16904] has been migrated to Git commit 82c63b49f3
Ref #2526 - Fix test failure in [16895]
This also makes a small text clarification, which was also the initial
reason for the test failure.
- Legacy-Id: 16912
Note: SVN reference [16895] has been migrated to Git commit ef1e8006f0
Note: SVN reference [16902] has been migrated to Git commit 78a1464e77
Fix#2526 - List previous reviews in assignments email.
This includes a migration to update the database templates. Note that
not all templates currently included them (secdir at least), and
previous reviews are only listed in templates that included */** before.
As before, previous reviews are only included if they are done by the
same reviewer(s) as the current assignment.
This also fixes a bug in database template 182
(/group/defaults/email/open_assignments.txt) which referred to
r.review_request..doc.rev and r.review_request..requested_rev
in the template, and updates the test to use the current version of
template 182.
- Legacy-Id: 16911
Note: SVN reference [16895] has been migrated to Git commit ef1e8006f0
Fix#2198 - Set default start date for UnavailabilityPeriod to today.
- Legacy-Id: 16910
Note: SVN reference [16891] has been migrated to Git commit a7a2ee4a39
Fix#2277 - Do not allow reviewers to reject overdue reviews.
If a review request is past the deadline, reviewers will no longer be
able to reject the assignment.
- Legacy-Id: 16909
Note: SVN reference [16883] has been migrated to Git commit 3c2b01b3ff
Correct construction for a reverse URL in an edge case. Fixes#2815.
- Legacy-Id: 16908
Note: SVN reference [16907] has been migrated to Git commit cca04b6330
