Be clear about who changed a group's personnel in the resulting email message. Fixes #2868. Commit ready for merge.

- Legacy-Id: 17233
This commit is contained in:
Robert Sparks 2020-01-15 21:38:44 +00:00
parent 0040a85395
commit f0f522322a
2 changed files with 2 additions and 0 deletions

View file

@ -627,6 +627,7 @@ class GroupEditTests(TestCase):
self.assertTrue('Personnel change' in outbox[0]['Subject'])
for prefix in ['ad1','ad2','aread','marschairman','marsdelegate']:
self.assertTrue(prefix+'@' in outbox[0]['To'])
self.assertTrue(outbox[0].get_payload(decode=True).decode(str(outbox[0].get_charset())).startswith('Sec Retary'))
def test_edit_field(self):

View file

@ -1003,6 +1003,7 @@ def edit(request, group_type=None, acronym=None, action="edit", field=None):
changed_personnel.update(set(old)^set(new))
if personnel_change_text!="":
personnel_change_text = "%s has updated %s personnel:\n\n" % (request.user.person.plain_name(), group.acronym.upper() ) + personnel_change_text
email_personnel_change(request, group, personnel_change_text, changed_personnel)
# update urls