altf4arnold/datatracker
1
0
Fork 0
Code Issues Pull requests Actions 6 Packages Projects Releases Wiki Activity
11134 commits 1 branch 0 tags 2.6 GiB
Commit graph

550 commits

Author SHA1 Message Date
Henrik Levkowetz 991c7a5e54 Captured another GroupFeatures model tweak. 
- Legacy-Id: 15330
 2018-07-14 16:26:11 +00:00
Henrik Levkowetz 8783fb11ab Fixed a migration ordering issue 
- Legacy-Id: 15322
 2018-07-13 03:40:32 +00:00
Robert Sparks 5b1a68a922 Converted ietf.group.tests to factories. Commit ready for merge. 
- Legacy-Id: 15321
 2018-07-12 21:23:50 +00:00
Henrik Levkowetz 2daef52bea This commit replaces the code defined group features with features held 
in a database table:

- Added a GroupFeatures model to the group models, and removed the old 
  features.py
- Added a agenda type for future use in showing different group types on
  different agendas.
- Renamed the group feature has_materials to has_nonsession_materials.
- Added API resources and admin support for the new tables.
- Added a Directorate (with reviews) group type as complement to
  Directorate, to distinguish between directorates with and without reviews.
- Adjusted tests as needed.
- Updated the fixtures, and fixed the generate_fixtures script to include
  the new AgendaTypeName objects.

There still exists about 70 instances of code comparing the group type
with a list of types; most of these should probably be replaced with new
features, instead, to make it possible to add new group types through the
database table, rather than having to edit the code.  That was the purpose
of this refactoring from the start, but the presence of this large number
of comparisons of group type against lists of types defeats the goal until
we add appropriate features and replace the group type list comparisons.
 - Legacy-Id: 15316
 2018-07-12 10:51:48 +00:00
Henrik Levkowetz e87442f33a Merged in [15282] from housley@vigilsec.com: 
Set reply-to for I-D Announcements that include a CC to a mail list.  Fixes #2530.
 - Legacy-Id: 15289
Note: SVN reference [15282] has been migrated to Git commit 733c304e3d
 2018-07-10 17:16:47 +00:00
Henrik Levkowetz c9cc9ff214 Upped the permitted number of search results for the /stream/ise/ page (and friends) from 200 to 1000. Fixes issue #2527. 
- Legacy-Id: 15281
 2018-06-26 16:43:40 +00:00
Robert Sparks 13df62f8ba Tweaked the color palatte for the agenda editor. Commit ready for merge. 
- Legacy-Id: 15247
 2018-06-13 19:58:08 +00:00
Robert Sparks dcf9e6b40f Use factories for ietf.doc.tests_ballots. Fixed a long-hidden bug in test_edit_verify_permissions where non-existing usernames were used and passed the tests accidently. Added list_email to the GroupFactory. Commit ready for merge. 
- Legacy-Id: 15219
 2018-06-06 17:59:40 +00:00
Robert Sparks 84d3c92298 more factoryization of ietf.doc.tests. Commit ready for merge. 
- Legacy-Id: 15205
 2018-06-02 13:39:39 +00:00
Henrik Levkowetz 6c3ec5b18e Added Email origin to Email record creation throughout the codebase. 
- Legacy-Id: 15149
 2018-05-17 16:56:26 +00:00
Henrik Levkowetz 421621eb51 Another round of iesg page optimizations. Reduced additional instances of individual lookups to a single lookup followed by annotation of document objects. Reduced several instances of repeating the same work multiple times (queries for telechat documents, queries for telechat dates). 
- Legacy-Id: 15010
 2018-04-05 11:03:26 +00:00
Adam Roach 3c4c0f2584 Updated (deprecated, unregistered) 'text/json' with 'application/json' everwhere. Commit ready for merge. 
- Legacy-Id: 14843
 2018-03-17 15:14:57 +00:00
Henrik Levkowetz fac3053d48 Fixed an issue with the milestone edit changes. 
- Legacy-Id: 14762
 2018-03-09 21:27:58 +00:00
Henrik Levkowetz cb051a7f59 Changed the handling of the milestone edit form to defer deletion if deletion is indicated together with other changes to the same milestone. Instead emit a warning, and ask for deletion without simultaneous changes to the milestone. 
- Legacy-Id: 14761
 2018-03-09 20:05:09 +00:00
Henrik Levkowetz 2c0348cc7a Found that django's urlize() does not deal well with adjacent parantheses. Replaced it with a filter based on bleach.linkify, which does better. 
- Legacy-Id: 14752
 2018-03-09 15:07:04 +00:00
Henrik Levkowetz 1ed8e967e7 Merged in ^/personal/henrik/6.72.1-django-1.11@14676: Upgrade to Django 1.11 
- Legacy-Id: 14695
 2018-02-25 19:55:16 +00:00
Henrik Levkowetz 5192440c9e Rewrote the head-of-rotation review assignment loop to guarantee that it will terminate. This should fix the 'gateway timeout' issues we've seen lately, when review request volume in some review teams have been such that multiple assignments to the head of queue members have triggered the issue. 
- Legacy-Id: 14684
 2018-02-22 22:18:19 +00:00
Henrik Levkowetz 26bf387356 Replaced direct assignment to m2m fields with .clear() and .set() 
- Legacy-Id: 14666
 2018-02-21 23:58:25 +00:00
Henrik Levkowetz 36b5e2ef8e Changed name from .rel to .remote_field for remote accessors. 
- Legacy-Id: 14665
 2018-02-21 23:56:36 +00:00
Henrik Levkowetz 06362ec046 Got rid of old migrations and created new initial migrations. 
- Legacy-Id: 14662
 2018-02-21 23:46:22 +00:00
Henrik Levkowetz 5638cf3da3 Changed all usage of ForeignKey and OneToOneFiled in model.py files to the compatibility versions from ietf.utils.models. 
- Legacy-Id: 14661
 2018-02-20 15:36:05 +00:00
Henrik Levkowetz 1825406695 Added a presence check before removing a list element. Addresses a 500 in unassigned review form POST. 
- Legacy-Id: 14642
 2018-02-14 14:32:33 +00:00
Robert Sparks 7b89db153e Take a different approach to avoiding the crash when a team secretary uses the bulk assignment form to unassign a request. Reverts r14570. Fixes #2443. Commit ready for merge. 
- Legacy-Id: 14623
 2018-02-07 17:58:27 +00:00
Henrik Levkowetz bf7157341f Merged in [14572] from rjsparks@nostrum.com: 
Corrected the filter for closed review requests. Fixes #2152.
 - Legacy-Id: 14573
Note: SVN reference [14572] has been migrated to Git commit 68725913b5
 2018-01-26 20:02:23 +00:00
Henrik Levkowetz eb6341d826 Removed the possibility of choosing '(None)' as reviewer from the bulk review request edit form; this prevents a crash on line 1474 of ietf/group/views.py, in manage_review_request(). The view code needs further care in order make it possible to unassign an assignment here. 
- Legacy-Id: 14570
 2018-01-25 15:58:59 +00:00
Robert Sparks 15d23299d8 Add navigation to nomcom pages for nomcom members. Put the RFC Status change link in a saner place in the navigation. Fixes #1411 and #2433. Commit ready for merge. 
- Legacy-Id: 14497
 2018-01-09 22:10:10 +00:00
Henrik Levkowetz 7a0a99001c Merged in [14468] from rjsparks@nostrum.com: 
Add the ability to add a comment to a group's history. Fixes #1483.
 - Legacy-Id: 14485
Note: SVN reference [14468] has been migrated to Git commit 13e8f8982c
 2018-01-01 00:42:10 +00:00
Robert Sparks 13e8f8982c Add the ability to add a comment to a group's history. Fixes #1483. Commit ready for merge. 
- Legacy-Id: 14468
 2017-12-28 20:48:58 +00:00
Tero Kivinen 5c1f1dfbd7 Fixed save-continue to work. Fixes #2383. Commit ready for merge 
- Legacy-Id: 14359
 2017-11-11 07:23:50 +00:00
Tero Kivinen 7c7e9ae698 Moved email open assignment summary from subpage to the main review request page. Fixes #2091. Commit ready for merge 
- Legacy-Id: 14356
 2017-11-11 06:29:05 +00:00
Henrik Levkowetz d7618ce26b An improved handling of the 'no active roles' message. 
- Legacy-Id: 14207
 2017-10-13 12:05:44 +00:00
Henrik Levkowetz dfaf5a56ac Renamed groupfilters to group_filters 
- Legacy-Id: 14206
 2017-10-13 11:58:42 +00:00
Henrik Levkowetz efea15e728 Renamed group_tags to groupfilters 
- Legacy-Id: 14205
 2017-10-13 11:55:12 +00:00
Henrik Levkowetz cbda2679a9 Removed some unreachable code. 
- Legacy-Id: 14150
 2017-09-22 14:45:21 +00:00
Henrik Levkowetz a440a30f95 Refined a test case which could fail incorrectly when PersonFactory produced multiple persons who shared the same name during a test run, using TestCase.assertMailboxContains(). 
- Legacy-Id: 14140
 2017-09-19 19:49:51 +00:00
Henrik Levkowetz 4dad8cdf9a Added a test to check for missing admin models, and added the admin models that were currently missing. 
- Legacy-Id: 14021
 2017-08-01 14:00:29 +00:00
Henrik Levkowetz 13bd9e1b59 Merged in [13905] from david.i.allan@ericsson.com: 
Fixes issue #2183.

    2183 fix to status update forms
 - Legacy-Id: 13914
Note: SVN reference [13905] has been migrated to Git commit 6964155a00
 2017-07-15 16:28:36 +00:00
David I. Allan 6964155a00 2183 fix to status update forms commit ready for merge 
- Legacy-Id: 13905
 2017-07-15 14:32:09 +00:00
Peter E. Yee 0d2e3cd32e Allows ADs to manage meeting materials from the meeting/##/materials page. Fixes #2213. Commit ready for merge. 
- Legacy-Id: 13900
 2017-07-15 12:40:13 +00:00
Henrik Levkowetz d2395f9521 Merged in [13832] from rjsparks@nostrum.com: 
Treat Area Groups similar to Working Groups and Research Groups where it makes sense to do so.
 - Legacy-Id: 13836
Note: SVN reference [13832] has been migrated to Git commit 2c92aa213d
 2017-07-11 21:57:01 +00:00
Robert Sparks 2c92aa213d Treat Area Groups similar to Working Groups and Research Groups where it makes sense to do so. Commit ready for merge. 
- Legacy-Id: 13832
 2017-07-11 19:12:21 +00:00
Henrik Levkowetz 900174ae57 Added log.unreachable() calls to some functions believed to be unused. 
- Legacy-Id: 13818
 2017-07-09 15:01:21 +00:00
Henrik Levkowetz b4e2081009 Added a log assertion for calls to can_manage_group_type. 
- Legacy-Id: 13782
 2017-07-06 13:59:00 +00:00
Henrik Levkowetz 6c2331a34e Added test cases for ADs and IRTF Chair for the chartering buttons on /group/chartering. 
- Legacy-Id: 13781
 2017-07-06 13:57:52 +00:00
Henrik Levkowetz 9e5db7ce5c Make sure that factory groups have a type. 
- Legacy-Id: 13780
 2017-07-06 13:56:59 +00:00
Henrik Levkowetz b97d45f5ba Call can_manage_group_type() with the right information. Fixes an issue with chartering buttons not being visible for ADs. 
- Legacy-Id: 13778
 2017-07-06 10:56:08 +00:00
Henrik Levkowetz 108c00a0a3 Merged in [13731] from rjsparks@nostrum.com: 
Reworked how review assigments are processed in order to ensure a team's queue rotates when it should. Fixes #2305.
 - Legacy-Id: 13743
Note: SVN reference [13731] has been migrated to Git commit 7f5cef056ade1641f1d815b0a5f35962077d6d01
 2017-06-30 20:16:22 +00:00
Henrik Levkowetz ce1b655fa2 Code reorganization, doing away with multiple urls_* and views_ files in ietf.group. No intentional functionality changes. 
- Legacy-Id: 13709
 2017-06-22 15:18:08 +00:00
Henrik Levkowetz dcc1bca058 Added assertion logging for found group parent loops to is_decendant_of(). 
- Legacy-Id: 13687
 2017-06-20 13:18:33 +00:00
Henrik Levkowetz e87e3eb661 Added circular parent relationship detection in the Group.is_decendant_of() method and in the group edit form data cleaning. 
- Legacy-Id: 13686
 2017-06-19 23:34:52 +00:00
Henrik Levkowetz f5298d7bb8 Fixed a bug in which operations were available on the /group/chartering/ 'Chartering or re-chartering' page, so that not only operations on groups in a chartering state is shown, but also the options to start chartering. Fixes issue #2312. 
- Legacy-Id: 13584
 2017-06-12 19:25:39 +00:00
Henrik Levkowetz 023a32715d Merged in ^/branch/iola/author-stats-r13145 from olau@iola.com, with additional features from ^/personal/henrik/6.52.1-authorstats. 
- Legacy-Id: 13550
 2017-06-06 18:36:59 +00:00
Henrik Levkowetz a28940fc1e Name/email formatting tweaks, to complement [13536]. 
- Legacy-Id: 13540
Note: SVN reference [13536] has been migrated to Git commit 55d36e284d
 2017-06-06 08:11:31 +00:00
Henrik Levkowetz e19290e98d Merged in [13532] from rjsparks@nostrum.com: 
Add an expertise field to reviewer settings. Fixes #2308. ,
 - Legacy-Id: 13539
Note: SVN reference [13532] has been migrated to Git commit d845fba8bec765f2f81ae1a4bbca52c9bceb6e02
 2017-06-06 07:54:03 +00:00
Henrik Levkowetz 55d36e284d Changed the '%s <%s>'%(name,email) idiom in several places to use email.utils.formataddr() instead, to avoid future problems with names that would need quotes. Added comments in 2 places where this change would not be appropriate. 
- Legacy-Id: 13536
 2017-06-05 22:40:11 +00:00
Henrik Levkowetz 2bacdd3a00 Merged in [13500] from rjsparks@nostrum.com: 
Provide assigned dates on review team reviewers page. Fixes #2304. Related to #2305.
 - Legacy-Id: 13518
Note: SVN reference [13500] has been migrated to Git commit e422717f91eb26a0691347beca9380889d8ee890
 2017-06-04 17:31:25 +00:00
Henrik Levkowetz 5b2087f910 Eliminated several variations on word wrapping, keeping only what used to be wrap_text(), but renamed as ietf.utils.text.wordwrap(). This performs better than django.utils.text.wrap() when there are indented text parts. Replaced django's default wordwrap filter with one calling ietf.utils.text.wordwrap in templates. Changed to triggered wrapping in some cases, with the maybewordwrap filter, which triggers on lines longer than 100 characters. This fixes the issue with undesired wrapping of reviews. 
- Legacy-Id: 13505
 2017-06-02 23:13:22 +00:00
Henrik Levkowetz d82b8bf036 Reverted one of the changes in [13296], and added a comment explaining the relationship between the role list in roles_for_group_type() and the fields in the following GroupForm. 
- Legacy-Id: 13297
Note: SVN reference [13296] has been migrated to Git commit a59331dd63
 2017-05-10 13:22:16 +00:00
Henrik Levkowetz a59331dd63 Align the roles edit buttons on a group's about page with the roles that the group edit GroupForm will accept. Avoids edit forms without any fields and some server 500 errors. 
- Legacy-Id: 13296
 2017-05-10 13:05:51 +00:00
Robert Sparks 2e54a5c443 Distinguish group that have session requests from those that do not on the materials/editable-groups page. Fixes #2284. Commit ready for merge. 
- Legacy-Id: 13246
 2017-04-19 18:04:48 +00:00
Henrik Levkowetz 7e3ee06b0b Adjusted test to match new name fixture. 
- Legacy-Id: 13209
 2017-04-12 21:23:29 +00:00
Henrik Levkowetz 14c748df98 Changed the creation of temporary test dirs to use names which include the test class name, in order to make it possible to run test cases in parallel. Disabled coverage testing when running in parallel (those classes cannot be pickled and distributed to the test runner threads, and also won't pass coverage data back). Tweaked the TestCase.tempdir() method. 
- Legacy-Id: 13157
 2017-03-27 21:41:18 +00:00
Lars Eggert 76a3c8bdc0 Update vnu.jar and fix various HTML5 nits it found during a test crawl. 
Commit ready for merge.
 - Legacy-Id: 13118
 2017-03-25 20:21:14 +00:00
Lars Eggert 8a70e9773d Fix various "RemovedInDjango20Warning" warnings. Commit ready for merge. 
- Legacy-Id: 13112
 2017-03-25 19:16:45 +00:00
Henrik Levkowetz 483d5f9a2a Silenced an unnecessary error which could occur when looking for charter documents for groups (such as bofs) without them, by asking the API for a group description. 
- Legacy-Id: 13025
 2017-03-19 19:24:37 +00:00
Henrik Levkowetz 58dae78a43 Modified the REST API to provide group descriptions taken from the group charters if group.description is blank. 
- Legacy-Id: 12993
 2017-03-11 13:46:19 +00:00
Henrik Levkowetz 4daf66d11c Added DocEvent rev= parameter througout the code. 
- Legacy-Id: 12978
 2017-03-06 15:08:21 +00:00
Henrik Levkowetz cbc0e72fee Added a migration which captures the ordering on Role. 
- Legacy-Id: 12938
 2017-03-01 11:33:42 +00:00
Henrik Levkowetz 089f23f011 Added ordering to Role, and a roles section at the top of the personal profile page. 
- Legacy-Id: 12931
 2017-02-28 19:33:28 +00:00
Henrik Levkowetz 5f053ad21a Cleaned up the remaining explicit url names, using dotted-paths to view 
functions instead.  In all almost 700 changes.
 - Legacy-Id: 12923
 2017-02-26 23:21:49 +00:00
Henrik Levkowetz 23ebe5d35d This addresses ease of editing various group attributes, and in particular is 
intended to make it easier to see that you can edit things like the
external/additional URLs:

 - Added the ability to edit individual fields in a group's about page, and
   added edit buttons for editable fields on the about page, just as for
   documents (the ability to edit all editable fields already was available
   from the 'Edit group' button on the /group//about/ page).

 - Made the tab label for the group-about tab consistently say 'About',
   instead of 'Charter' for some groups.

 = Shifted the position of the about tab to the start of the tab line.

 - Removed the datatracker account requirement information at the top of the
   group edit page for users logged in to their account.

 - Tweaked the 'Show update' link on the 'Status Update' line.

 - Changed the label for the external URLs from 'More Info' to 'Additional
   URLs', which was already in use on the edit form.
 - Legacy-Id: 12904
 2017-02-23 20:55:38 +00:00
Henrik Levkowetz fb6e24b6dd Changed the AD email list results from get_group_ad_emails() to make more sense when the group is an area, not a wg. 
- Legacy-Id: 12900
 2017-02-22 17:33:42 +00:00
Henrik Levkowetz 27351c4349 Fixed url lookups for doc.views_doc.document_main() to only use dotted-path, and removed the doc_view explicit url name. Fixes a 500 error in /submit/status/NNNN/. 
- Legacy-Id: 12897
 2017-02-22 11:40:55 +00:00
Henrik Levkowetz 988a2b808f Added explicit charset setting and consistent encoding to several email paths through the datatracker. After introducing support for non-ascii names in email addresses, using role.formatted_email() to insert names into email content doesn't work any more, since uncode names will now be rfc2047-encoded in formatted_email(). Added another method role.name_and_email() for this case. Replaced another case of '%s <%s>' name-and-email formatting with formataddr(). Fixed some tests which did not send unicode email bodies to the email functions. Fixes issue #2017. 
- Legacy-Id: 12896
 2017-02-21 19:17:10 +00:00
Henrik Levkowetz 8930d29a8e Merged in Django-1.10 upgrade work from ^/personal/henrik/6.43.1-django-1.10 
- Legacy-Id: 12881
 2017-02-19 18:18:00 +00:00
Henrik Levkowetz cf4a4b02a7 Reworked the email address handling in order to be able to support non-ascii names as part of email address fields. Reworked the generation of user names in the test suite to generate names from multiple non-ascii locales. Fixes issue #2080. 
- Legacy-Id: 12872
 2017-02-18 21:50:18 +00:00
Henrik Levkowetz 3fd890abbd Fixed a urlreverse kwargs bug. 
- Legacy-Id: 12819
 2017-02-11 14:48:55 +00:00
Henrik Levkowetz aa5e61d958 Updated all urlpatterns to use ietf.utils.urls.url() instead of django's, 
in order to autogenerate dotted path url pattern names.  Updated a number
of url reverses to use dotted path, and removed explicit url pattern names
as needed.

Changed some imports to prevent import of ietf.urls before django
initialization was complete.


Changed 3 cases of form classes being curried to functions; django 1.10
didn't accept that.

Started converting old-style middleware classes to new-style middleware
functions (incomplete).

Tweaked a nomcom decorator to preserve function names and attributes, like
a good decorator should.

Replaced the removed django templatetag 'removetags' with our own version
which uses bleach, and does sanitizing in addition to removing explicitly
mentionied html tags.

Rewrote the filename argument handling in a management command which had
broken with the upgrade.
 - Legacy-Id: 12818
 2017-02-11 14:43:01 +00:00
Henrik Levkowetz 0922c6c984 Added ordering by name to group personnel lists in edit and about views. This ordering is by the person's profile name, without attempting to determine which name part is family name or given name. Fixes #2184. 
- Legacy-Id: 12817
 2017-02-10 22:02:29 +00:00
Henrik Levkowetz 19d585255a Django 1.10 does not permit the view argument to url() to be a string any more. Changed all cases view arguments to url() which were strings to instead reference the actual imported function. 
- Legacy-Id: 12815
 2017-02-10 14:49:16 +00:00
Henrik Levkowetz 40e8380751 Merged django 1.9 work forward to copy of trunk @6.41.0 
- Legacy-Id: 12756
 2017-01-30 23:13:02 +00:00
Henrik Levkowetz 1d7b081dd9 Fixed a migration reference issue. 
- Legacy-Id: 12728
 2017-01-24 22:02:00 +00:00
Henrik Levkowetz 2ab4caa90f Merged in [12722] from rjsparks@nostrum.com: 
Added programs to the datatracker. Added use of restructuredtext for group about pages. Generalized several places where code handles different group types. Improved testing of group about.
 - Legacy-Id: 12725
Note: SVN reference [12722] has been migrated to Git commit e0ea8b0f57
 2017-01-24 21:30:10 +00:00
Robert Sparks e0ea8b0f57 Added programs to the datatracker. Added use of restructuredtext for group about pages. Generalized several places where code handles different group types. Improved testing of group about. Commit ready for merge. 
- Legacy-Id: 12722
 2017-01-24 19:55:49 +00:00
Henrik Levkowetz e2640f358b Changed semantics for can_manage_group() to include chairs etc, and changed calls with the old semantics to use can_manage_group_type(). Rewrote can_manage_group() in terms of can_manage_group_type() and additional checks. Fixes issue #2155. 
- Legacy-Id: 12719
 2017-01-23 22:54:36 +00:00
Henrik Levkowetz 6de7be6953 Specified strip=False for another bunch of CharField form fields with Textarea widgets. 
- Legacy-Id: 12711
 2017-01-23 17:38:56 +00:00
Henrik Levkowetz 823dd980f1 Merged in [12706] from rjsparks@nostrum.com: 
Restrict editing ReviewSettings.skip_next to team secretaries and the secretariat. Improve validation of skip_next value. Fixes #2149.
 - Legacy-Id: 12710
Note: SVN reference [12706] has been migrated to Git commit 518f7a1d65
 2017-01-23 17:32:37 +00:00
Robert Sparks 518f7a1d65 Restrict editing ReviewSettings.skip_next to team secretaries and the secretariat. Improve validation of skip_next value. Fixes #2149. Commit ready for merge. 
- Legacy-Id: 12706
 2017-01-19 19:17:29 +00:00
Henrik Levkowetz 1dba613197 Merged in [12675] from rjsparks@nostrum.com: 
Removed some unnecessary randomness in tests introduced in last commit.
 - Legacy-Id: 12678
Note: SVN reference [12675] has been migrated to Git commit 4f2f691de6
 2017-01-19 17:24:08 +00:00
Robert Sparks 4f2f691de6 Removed some unnecessary randomness in tests introduced in last commit. Commit ready for merge. 
- Legacy-Id: 12675
 2017-01-19 16:37:00 +00:00
Henrik Levkowetz b4480a1625 Merged in [12670] from rjsparks@nostrum.com: 
Make changing skip_next on a review assignment an explicit decision of the assigner.  Fixes #2148.
 - Legacy-Id: 12671
Note: SVN reference [12670] has been migrated to Git commit 8e007ce50b
 2017-01-19 15:25:22 +00:00
Robert Sparks 8e007ce50b Make changing skip_next on a review assignment an explicit decision of the assigner. Commit ready for merge. Fixes #2148. 
- Legacy-Id: 12670
 2017-01-19 14:23:09 +00:00
Henrik Levkowetz 79dc639f46 Merged in [12665] from rjsparks@nostrum.com: 
Make it easier to see who's really next in reviewer rotation.
 - Legacy-Id: 12668
Note: SVN reference [12665] has been migrated to Git commit 49dcf67fd5
 2017-01-18 16:30:29 +00:00
Robert Sparks 49dcf67fd5 Make it easier to see who's really next in reviewer rotation. Commit ready for merge. 
- Legacy-Id: 12665
 2017-01-17 22:04:16 +00:00
Henrik Levkowetz 438195c832 Aligned some Group edit form field limits with those of the Group model. Fixes issue #2137. 
- Legacy-Id: 12646
 2017-01-12 13:57:26 +00:00
Henrik Levkowetz 7b95411f58 The context_instance parameter to render_to_response() and render_to_string() is now deprecated. Fixed this, and generally changed the idiom render_to_response('template.html', {}, RequestContext(request)) to the newer and simpler render(request, 'template.html', {}). About 200 instances. 
- Legacy-Id: 12637
 2017-01-09 21:26:30 +00:00
Henrik Levkowetz 5cc3b6448e Django 1.9: Removed additional instances of deprecated django.conf.urls.patterns() 
- Legacy-Id: 12623
 2016-12-22 18:14:57 +00:00
Henrik Levkowetz c2541ec04b Django 1.9: Removed deprecated use of django.conf.urls.patterns() from all urls*.py files. 
- Legacy-Id: 12618
 2016-12-22 17:21:57 +00:00
Henrik Levkowetz 481a96c935 Changed the handling of skip tests and messages in order to show which tests will be skipped, and why, at the start of a test run. 
- Legacy-Id: 12568
 2016-12-17 21:49:53 +00:00
Henrik Levkowetz fa684cf6d2 Merged in [12541] from rjsparks@nostrum.com: 
Provide default filters for reviewer settings. Fixes #2093.
 - Legacy-Id: 12546
Note: SVN reference [12541] has been migrated to Git commit df86798cf3
 2016-12-15 21:57:46 +00:00
Henrik Levkowetz ff9b8a9bdb Deprecation fixes: Explicitly say that redirects are permanent. 
- Legacy-Id: 12532
 2016-12-15 13:19:51 +00:00
Henrik Levkowetz 8e56935cfd Undid commit 12527, which contained much too much. 
- Legacy-Id: 12528
 2016-12-15 10:38:54 +00:00
Henrik Levkowetz e3c6e0ac6b Changed the state shown in all_id.txt for drafts which have entered IESG processing, but then been replaced, to show as 'Replaced' instead of 'In IESG Processing'. This is consistent with how they are shown in all_id2.txt. 
- Legacy-Id: 12527
 2016-12-15 10:36:15 +00:00
Henrik Levkowetz 57eb5844e5 Merged in [12489] from rjsparks@nostrum.com: 
Save a new reviewrequest for each team requested in the request form. Fixes #2094.
 - Legacy-Id: 12491
Note: SVN reference [12489] has been migrated to Git commit 4fff1ab101e4f7cd27dc8ded889e09905866076f
 2016-12-09 12:01:48 +00:00
Henrik Levkowetz 83a260c6c0 Merged in [12482] from rjsparks@nostrum.com: 
Improves control of email headers for review summary messages. Provides team-specific templates for review summary messages. Fixes #2092 and #2082.
 - Legacy-Id: 12483
Note: SVN reference [12482] has been migrated to Git commit 06179c7485dac6c69b2aa30e66095a23a4460209
 2016-12-08 17:55:37 +00:00
Ole Laursen 7d8baf0015 Add reviewer name and completion date to previous reviews in manage 
review page
 - Legacy-Id: 12397
 2016-11-25 10:53:37 +00:00
Ole Laursen 39d674b4ca Add missing resource and missing test review secretary settings 
- Legacy-Id: 12313
 2016-11-09 10:07:49 +00:00
Ole Laursen ceec1254f2 Add review team secretary reminders, like those for reviewers 
- Legacy-Id: 12283
 2016-11-08 16:24:28 +00:00
Ole Laursen cde7cfacd5 Modify the reviewer overview page to display up to 10 historic reviews 
per person from the past year instead of only 5.

Add basic reviewer stats to the assignment select box.
 - Legacy-Id: 12279
 2016-11-07 22:32:53 +00:00
Ole Laursen c3e8cabafb Revamp the layout in the manage review requests page. Drop the table 
and instead provide more information about each document to be
reviewed, to help the secretaries determine locally on that page what
action to take. The new layout should also make it easier to fit in
more info, in case it is still found lacking.

The public review request page still provides the previous information
in the summarized tabular form, so the overview can be found there.
 - Legacy-Id: 12278
 2016-11-07 21:20:15 +00:00
Ole Laursen 58dd25ff79 Split up open review requests on the review team page in assigned and 
unassigned requests to make it easier to just work with the unassigned
ones. Use same split on the manage reviews page which is now two
pages.
 - Legacy-Id: 12266
 2016-11-04 17:19:33 +00:00
Ole Laursen b9d5352afd Display the reviewed revision in reviewer overview page 
- Legacy-Id: 12245
 2016-11-02 11:33:25 +00:00
Ole Laursen 3835532d71 Insert iconic link to review statistics from the team pages 
- Legacy-Id: 12215
 2016-10-26 13:35:32 +00:00
Ole Laursen 1febf2465d Fix a bug in the logic that determines which roles are editable (the 
bug had the reviewer field showing up on non-dir pages)
 - Legacy-Id: 12186
 2016-10-20 15:30:35 +00:00
Ole Laursen 4b987436c0 Fix a missing HttpResponseForbidden in review statistics, make the 
review test code use a separate reviewer and reviewsecretary user to
avoid confounding things - also let these use Unicode in their names
to check for Unicode trouble.
 - Legacy-Id: 12175
 2016-10-19 11:58:49 +00:00
Ole Laursen d0877a0aa9 Change default of ReviewerSettings.min_interval to null - if it's not 
specified for a reviewer, we don't take it into account
 - Legacy-Id: 12168
 2016-10-18 10:36:42 +00:00
Ole Laursen a216694c4c Add missing guard on the manage review button so it only shows up if 
the user can access the manage review page
 - Legacy-Id: 12166
 2016-10-17 21:43:35 +00:00
Ole Laursen 399bb3bf4d Make UnavailablePeriod.start_date nullable and import the unavailable 
periods from the Perl tool with start date null as we don't know when
they started.
 - Legacy-Id: 12161
 2016-10-17 19:37:56 +00:00
Ole Laursen 505b4fcea3 Fix redirection problem when group_type is not given. 
- Legacy-Id: 12136
 2016-10-13 19:34:39 +00:00
Ole Laursen 958ba5ba95 Make new branch from trunk and merge in review-tracker-r11921 
- Legacy-Id: 12129
 2016-10-13 16:38:47 +00:00
Ole Laursen bf55237112 Add statistics section with review statistics. Fix a couple of missing tests. 
- Legacy-Id: 12124
 2016-10-13 15:20:04 +00:00
Ole Laursen 46dd4682bf Remove debug output 
- Legacy-Id: 12102
 2016-10-07 16:49:37 +00:00
Ole Laursen 59180240af Add a simple reminder system for reviewers so that they can opt in to 
being reminded X days before deadline of an assignment
 - Legacy-Id: 12101
 2016-10-07 16:43:29 +00:00
Ole Laursen 227fdd7953 Add reviews to search results and IESG agenda. Support restricting 
review types so that teams will only have those review types
listed and suggested that they are configured to have.

Fix a couple of things in the importer after having tested it on all
the databases. Set unavailable end date >= 2020 to indefinite.

Fix a couple of bugs.
 - Legacy-Id: 12095
 2016-10-06 14:47:41 +00:00
Ole Laursen a177dc616b Fix a couple of bugs, add test for reviewer overview page 
- Legacy-Id: 12081
 2016-10-04 20:22:11 +00:00
Ole Laursen 4c7b2847ba Add a utility function for extracting information about review 
requests for a given set of teams/reviewers (making it trivial to
compute statistics), revamp the related doc event code to support this
by referencing the review request directly, add a reviewer overview
page with recent performance for each reviewer as well as
settings/unavailable periods. Fix some bugs and shuffle some of the
review code a bit around.

Finish the importer from the previous Perl-based review tool,
importing log entries, figuring out whether a given review is
early/telechat/last call and fixing corner cases.
 - Legacy-Id: 12080
 2016-10-03 15:52:32 +00:00
Henrik Levkowetz 7f772641d4 Change the cache key construction to deal with query arguments containing spaces. Fixes 500 errors which would otherwise occur. 
- Legacy-Id: 12035
 2016-09-25 13:53:22 +00:00
Ole Laursen 99beb58291 Implement a round-robin rotation scheme for reviewers instead of 
relying on when they last reviewed. In-order assignments automatically
move the rotation forwards while out-of-order assignments increment
the skip next of the assigned reviewer. Include rotation in open
review assignments email. Fix a couple of issues in the importer.
 - Legacy-Id: 12015
 2016-09-21 16:52:50 +00:00
Henrik Levkowetz e553ff80d8 Added an is_bof flag to json_agenda. Also added group state information. Changed the group information to use historic information instead of current. 
- Legacy-Id: 12009
 2016-09-20 20:28:22 +00:00
Ole Laursen 6da25e6bd9 Add personal review overview page for reviewers, add page for editing 
reviewer availability settings, emailing the reviewer/secretary as
necessary, add tests for these pages. Fix a bunch of bugs.
 - Legacy-Id: 11998
 2016-09-19 16:05:32 +00:00
Ole Laursen 74a02be9bf Create new branch from trunk@r11921, and merge review-tracker-r11360 into it 
- Legacy-Id: 11923
 2016-09-06 10:17:12 +00:00
Ole Laursen 1f7d4870a8 Refactor role handling in group editing slightly and add support for 
editing reviewer roles in review teams. Also fix a couple of review
related bugs.
 - Legacy-Id: 11921
 2016-09-05 12:33:54 +00:00
Henrik Levkowetz 2c484d5abb Added another migration dependency, to avoid looking for removed tables. 
- Legacy-Id: 11880
 2016-08-26 10:30:21 +00:00
Henrik Levkowetz 2b226ae7b7 Improved test coverage somewhat by making more of the group tests apply to both the /group/acronym and /wg/acronym (or equivalent) url forms. 
- Legacy-Id: 11857
 2016-08-24 16:50:54 +00:00
Henrik Levkowetz cf5ac68b09 Renumbered and updated the migrations merged in from the eventsaving work. Made the dochistory-adding migration idempotent, and added progress indication as this migration may take as much as an hour to run. 
- Legacy-Id: 11854
 2016-08-24 15:37:25 +00:00
Ole Laursen dd190b87fe Follow replacements when displaying reviews for a draft on the 
document page, too. Add a test to check that recursive replacements
are handled correctly. Polish the display a bit.
 - Legacy-Id: 11847
 2016-08-23 14:55:42 +00:00
Ole Laursen 16e28481f6 Add page for emailing open review assignments summary to the review team list 
- Legacy-Id: 11846
 2016-08-23 14:06:47 +00:00
Ole Laursen 1f71268da1 More polish on manage review requests page: Add save and continue 
editing button, reverse sort order so latest (and probably most
interesting) is at the top, disable save buttons when there are no
changes to save
 - Legacy-Id: 11843
 2016-08-23 12:12:24 +00:00
Henrik Levkowetz 4b0a9360f0 Merged in ^/branch/iola/event-saving-refactor-r10291, which refactors document saving to always use doc.save_with_history(events), and requires accompanying events. This branch also provides refactoring of recurring regexes in url patterns into a dictionary. As part of the merge, also refactored new code which didn't use the save_with_history() method. 
- Legacy-Id: 11840
 2016-08-23 10:52:08 +00:00
Ole Laursen 507baade01 Add refresh button to manage reviews page, make save detect changes in 
the requests and pop the page back up for confirmation if so
 - Legacy-Id: 11827
 2016-08-19 16:40:09 +00:00
Ole Laursen 5eba7bf38e Fix a bug 
- Legacy-Id: 11807
 2016-08-17 16:12:17 +00:00
Ole Laursen 426542771a Turn ReviewRequest.deadline into a date field with no time 
- Legacy-Id: 11801
 2016-08-17 15:10:39 +00:00
Robert Sparks 4631df61ef improve some test coverage. Commit ready for merge. 
- Legacy-Id: 11767
 2016-08-09 18:31:05 +00:00
Robert Sparks 9b2d73b365 add status reports to proceedings. add a view for the applicable status report for a given meeting. Commit ready for merge. 
- Legacy-Id: 11766
 2016-08-09 15:42:40 +00:00
Henrik Levkowetz 34370c6e16 Merged in [11656] from rjsparks@nostrum.com: 
Enhanced factories to simplify test writing.
 - Legacy-Id: 11682
Note: SVN reference [11656] has been migrated to Git commit 030ea1c939
 2016-07-16 14:15:41 +00:00
Henrik Levkowetz c7cecf66e9 Added a test case for group home. 
- Legacy-Id: 11652
 2016-07-13 19:20:13 +00:00
Henrik Levkowetz 8ca48aac42 Make group acronym regex patterns consistent. 
There were multiple different regex patterns in different urlpattern
declarations, with some of them permitting characters which should not
occur in group acronym.  Changed them to consistently use [-a-z0-9]+ .
 - Legacy-Id: 11651
 2016-07-13 19:19:15 +00:00
Henrik Levkowetz 211943148d Make the group factory produce groups with valid acronyms 
- Legacy-Id: 11650
 2016-07-13 18:48:53 +00:00
Ole Laursen f7eeb1f0f1 Add missing constraint on team in manage review request page 
- Legacy-Id: 11636
 2016-07-12 16:12:04 +00:00
Ole Laursen db4ea01e20 Take a bunch of factors into account when sorting reviewers for 
assignment to a review request
 - Legacy-Id: 11626
 2016-07-12 13:04:14 +00:00