altf4arnold/datatracker
1
0
Fork 0
Code Issues Pull requests Actions 2 Packages Projects Releases Wiki Activity

Added a presence check before removing a list element. Addresses a 500 in unassigned review form POST.

Browse source 
- Legacy-Id: 14642
This commit is contained in:
Henrik Levkowetz 2018-02-14 14:32:33 +00:00
parent ba8a173a5c
commit 1825406695
1 changed files with 4 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
ietf/group/views.py
View file

@ -1485,7 +1485,10 @@ def manage_review_requests(request, acronym, group_type=None, assignment_status=
while head_of_rotation in assignments_by_person:
review_req = assignments_by_person[head_of_rotation]
assign_review_request_to_reviewer(request, review_req, review_req.form.cleaned_data["reviewer"],review_req.form.cleaned_data["add_skip"])
reqs_to_assign.remove(review_req)
if review_req in reqs_to_assign:
# XXX FIXME: It's not clear how we could end up here, but
# it has happened. See traceback email dated 14 Feb 2018
reqs_to_assign.remove(review_req)
head_of_rotation = reviewer_rotation_list(group)[0]
for review_req in reqs_to_assign: