altf4arnold/datatracker
1
0
Fork 0
Code Issues Pull requests Actions 6 Packages Projects Releases Wiki Activity
11134 commits 1 branch 0 tags 2.6 GiB
Commit graph

550 commits

Author SHA1 Message Date
Henrik Levkowetz 682ddee8e4 Reverted earlier application of on_behalf_of() at mail sending call points, and instead did all on_behalf_of processing in condition_message(). Added insertion of Reply-To header fields in this case. Changed all use of the mail-sending 'extra' parameters to use value lists. Updated a bunch of tests accordingly. 
- Legacy-Id: 16020
 2019-03-11 17:01:33 +00:00
Henrik Levkowetz 4fd9247bc4 Tweaks to group_features_group_filter() 
- Legacy-Id: 16015
 2019-03-07 23:35:47 +00:00
Henrik Levkowetz 9e36246a91 Rewrote a function to be more readable and actually do the right thing. This moved some filtering from database into code, but it seems acceptable here. 
- Legacy-Id: 16013
 2019-03-07 23:22:14 +00:00
Henrik Levkowetz 267e9eebc6 Transitioned group/views.py to unicode strings 
- Legacy-Id: 16011
 2019-03-07 14:58:49 +00:00
Henrik Levkowetz 435a0da12d Added on_behalf_of() calls for from addresses needing it throughout the code. 
- Legacy-Id: 15992
 2019-03-04 20:14:19 +00:00
Henrik Levkowetz 2b811b3d3d Updated the tests to always use @ietf.org addresses where appropriate, and not do so when not appropriate. All test user login addresses have been changed away from @ietf.org. 
- Legacy-Id: 15988
 2019-03-04 20:08:48 +00:00
Robert Sparks e91d706d5b Checkpointing. This is an incomplete idea. The tests will fail massively. 
- Legacy-Id: 15985
 2019-03-01 23:19:47 +00:00
Henrik Levkowetz 137159fd41 Removed the GroupFeatures.has_dependencies field. 
- Legacy-Id: 15971
 2019-02-25 21:04:16 +00:00
Henrik Levkowetz 8f0cca05db Backed out the removal of the has_dependencies field (and database column), to be done in the next release, to avoid unnecessary issues with disappearing columns during deployment 
- Legacy-Id: 15962
 2019-02-25 12:20:33 +00:00
Henrik Levkowetz 6c1b57509d Increased the document count for group document lists from the default(200) to 500, as MPLS now exceeds 200. 
- Legacy-Id: 15961
 2019-02-21 19:53:25 +00:00
Henrik Levkowetz e8a59ce1e5 Rewrote the submission deduce_group() to consider all groups with acronyms that are also GroupTypeNames. Added GroupTypeName for iesg,ise,adhoc groups, and appropriate GroupFeatures for each. Updated the names.json fixture. 
- Legacy-Id: 15960
 2019-02-21 15:27:58 +00:00
Henrik Levkowetz d53f9db779 Modified a view function to fill in missing default CommunityLists for groups with features.has_documents == True. 
- Legacy-Id: 15957
 2019-02-18 12:12:46 +00:00
Henrik Levkowetz 720943af72 Removed the has_dependencies GroupFeature, and used has_documents instead in the one place it was used. 
- Legacy-Id: 15934
 2019-02-07 15:56:48 +00:00
Henrik Levkowetz b57ad67041 Updated code and templates to use the new docman and groupman group features. 
- Legacy-Id: 15922
 2019-01-30 15:59:00 +00:00
Henrik Levkowetz 0885422534 Added new docman and groupman GroupFeature fields. 
- Legacy-Id: 15920
 2019-01-30 15:55:23 +00:00
Henrik Levkowetz 8ba7cf144f Updated migrations to split the matman_roles group feature into matman, docman and groupman features. 
- Legacy-Id: 15919
 2019-01-30 15:54:00 +00:00
Henrik Levkowetz 5d88a0805b Added a tiny management command to list group types per feature. 
- Legacy-Id: 15918
 2019-01-30 15:52:33 +00:00
Henrik Levkowetz d1f1be5b01 Second correction to the default values of the GroupFeatures JSONField fields, and updated the migration to match. 
- Legacy-Id: 15915
 2019-01-24 20:22:44 +00:00
Henrik Levkowetz 6590e4f4ad Corrected the default values of the GroupFeatures JSONField fields, and updated the migration to match. 
- Legacy-Id: 15914
 2019-01-24 20:08:29 +00:00
Henrik Levkowetz c87d3741f3 Added 2 utility functions to help create group features query filters, and applied them in 3 places in order to move group feature role list code back into DB queries. 
- Legacy-Id: 15911
 2019-01-23 18:40:39 +00:00
Henrik Levkowetz 37f46183db Added some copyright and encoding strings. 
- Legacy-Id: 15910
 2019-01-23 18:38:16 +00:00
Henrik Levkowetz f076127317 Added a migration that seems to have resulted from running a newer version of django-simple-history. 
- Legacy-Id: 15909
 2019-01-22 18:14:26 +00:00
Henrik Levkowetz 57a4c9f41f Added 9 new group features, and changed list-like char fields to json fields, to get better support for using the values as lists. Modified code to use the group features instead of explicit lists of group types in many places in the code. 
- Legacy-Id: 15908
 2019-01-22 18:11:46 +00:00
Henrik Levkowetz af4131bb1c Merged in [15865] from rjsparks@nostrum.com: 
Cleanup: removed the infrastructure for importing reviews from the old review tool.
 - Legacy-Id: 15877
Note: SVN reference [15865] has been migrated to Git commit 87dd249415
 2019-01-08 14:39:16 +00:00
Henrik Levkowetz 55935eadd4 Merged in [15828] from rjsparks@nostrum.com: 
Show more group types on the concluded groups page. Fixes #2643.
 - Legacy-Id: 15871
Note: SVN reference [15828] has been migrated to Git commit ac4deed500
 2019-01-07 13:39:20 +00:00
Henrik Levkowetz a84ae9a10d Added a migration to capture changes to HistoricalRecords triggered by changes in django-simple-history 
- Legacy-Id: 15836
 2018-12-19 08:02:45 +00:00
Henrik Levkowetz c8e15fad50 Fixed a pyflakes issue 
- Legacy-Id: 15830
 2018-12-18 14:45:48 +00:00
Robert Sparks ac4deed500 Show more group types on the concluded groups page. Fixes #2643. Commit ready for merge. 
- Legacy-Id: 15828
 2018-12-17 21:34:30 +00:00
Henrik Levkowetz 1bddfdffa5 Removed an assertion for iesg state for documents that can be in any stream. 
- Legacy-Id: 15827
 2018-12-17 14:03:55 +00:00
Henrik Levkowetz a1fc8722f2 Merged in [15824] from rjsparks@nostrum.com: 
Make it more obvious that a group has been replaced when looking at its pages. Fixes #2661.
 - Legacy-Id: 15826
Note: SVN reference [15824] has been migrated to Git commit fdf0964c40
 2018-12-16 20:43:12 +00:00
Robert Sparks fdf0964c40 Make it more obvious that a group has been replaced when looking at its pages. Fixes #2661. Commit ready for merge. 
- Legacy-Id: 15824
 2018-12-14 22:25:55 +00:00
Henrik Levkowetz e37303b441 Merged in [15822] and [15809] from rjsparks@nostrum.com: 
Added an explicit ID-Exists state for the IESG state machine.
    Reworked code so that the IESG state machine always has a state.
    Added the ability to release a document from a working group,
    research group, or the independent stream. Releasing a document
    removes all stream state, and sets the document to have no stream.
 - Legacy-Id: 15823
Note: SVN reference [15809] has been migrated to Git commit 6118975620

Note: SVN reference [15822] has been migrated to Git commit f6886f6105
 2018-12-14 22:17:58 +00:00
Henrik Levkowetz f65fcdd2c4 Merged in [15804] from rjsparks@nostrum.com: 
Add history to ReviewerSettings. Fixes #2147.
 - Legacy-Id: 15811
Note: SVN reference [15804] has been migrated to Git commit cb707248e2
 2018-12-13 14:29:58 +00:00
Robert Sparks 6118975620 Added an explicit ID-Exists state for the IESG state machine. Reworked code so that the IESG state machine always has a state. Added the ability to release a document from a working group, research group, or the independent stream. Releasing a document removes all stream state, and sets the document to have no stream. 
- Legacy-Id: 15809
 2018-12-11 22:38:05 +00:00
Robert Sparks cb707248e2 Add history to ReviewerSettings. Fixes #2147. Commit ready for merge. 
- Legacy-Id: 15804
 2018-12-03 22:23:01 +00:00
Henrik Levkowetz 44e28707cc Merged in [15709] from rjsparks@nostrum.com: 
Show counts on the active groups page and on the active wgs page. Fixes #2060.
 - Legacy-Id: 15755
Note: SVN reference [15709] has been migrated to Git commit cb02df1681
 2018-11-12 12:24:41 +00:00
Henrik Levkowetz 98015a64f2 Merged in [15683] and [15699] from housley@vigilsec.com: 
Do not show reasons for review team member unavailability outside the team. Fixes #2614.
 - Legacy-Id: 15732
Note: SVN reference [15683] has been migrated to Git commit 6ff552640e

Note: SVN reference [15699] has been migrated to Git commit 895aa0cfbe
 2018-11-06 14:43:58 +00:00
Robert Sparks cb02df1681 Show counts on the active groups page and on the active wgs page. Fixes #2060. Commit ready for merge. 
- Legacy-Id: 15709
 2018-11-04 01:33:34 +00:00
Russ Housley 895aa0cfbe Commit ready for merge. 
- Legacy-Id: 15699
 2018-11-03 08:41:23 +00:00
Russ Housley 6ff552640e Do not show reasons for review team member unavailability outside the team. Fixes #2614. Commit ready for merge. 
- Legacy-Id: 15683
 2018-11-03 04:24:32 +00:00
Robert Sparks 16ae849d68 Only do state-parent cross-validation on the group edit form when both fields are used on the form. (Many invocations of the form suppress all but one field.) Fixes #2597. Commit ready for merge. 
- Legacy-Id: 15681
 2018-11-03 03:55:53 +00:00
Henrik Levkowetz caa3ec98b4 Changed the menu listing of review dirs and their display on the Directorates page back to what it was before the 'reviews' group type was split out. Added a 'Reviews' column to the Directoratges page. 
- Legacy-Id: 15420
 2018-08-01 18:53:44 +00:00
Henrik Levkowetz 0c732d6538 Guard against comparing email origin with username of None. 
- Legacy-Id: 15419
 2018-07-31 14:27:31 +00:00
Henrik Levkowetz 6350f92ed1 Merged in [15370] from rjsparks@nostrum.com: 
Use factories for ietf.group.tests_review.
 - Legacy-Id: 15404
Note: SVN reference [15370] has been migrated to Git commit 61932cbc9e
 2018-07-24 06:14:47 +00:00
Henrik Levkowetz 2e83c529b1 Merged in [15355] from rjsparks@nostrum.com: 
Used factories for ietf.group.tests_info.
 - Legacy-Id: 15398
Note: SVN reference [15355] has been migrated to Git commit 5a0b005939
 2018-07-19 15:54:53 +00:00
Henrik Levkowetz ed208a5ebb Merged in [15342] from peter@akayla.com: 
Added optional reviewer unavailability reason support.  Fixes issue #2146.
 - Legacy-Id: 15375
Note: SVN reference [15342] has been migrated to Git commit f4eba7d4df
 2018-07-17 15:27:20 +00:00
Robert Sparks 61932cbc9e Use factories for ietf.group.tests_review. Commit ready for merge. 
- Legacy-Id: 15370
 2018-07-16 21:07:03 +00:00
Robert Sparks 5a0b005939 Used factories for ietf.group.tests_info. Commit ready for merge. 
- Legacy-Id: 15355
 2018-07-14 22:03:11 +00:00
Henrik Levkowetz 3807299eee Merged in [15321] from rjsparks@nostrum.com: 
Converted ietf.group.tests to factories.
 - Legacy-Id: 15350
Note: SVN reference [15321] has been migrated to Git commit 5b1a68a922
 2018-07-14 20:58:09 +00:00
Peter E. Yee f4eba7d4df Added optional reviewer unavailability reason support. Fixes issue #2146. Commit ready for merge. 
- Legacy-Id: 15342
 2018-07-14 18:04:31 +00:00
Henrik Levkowetz 991c7a5e54 Captured another GroupFeatures model tweak. 
- Legacy-Id: 15330
 2018-07-14 16:26:11 +00:00
Henrik Levkowetz 8783fb11ab Fixed a migration ordering issue 
- Legacy-Id: 15322
 2018-07-13 03:40:32 +00:00
Robert Sparks 5b1a68a922 Converted ietf.group.tests to factories. Commit ready for merge. 
- Legacy-Id: 15321
 2018-07-12 21:23:50 +00:00
Henrik Levkowetz 2daef52bea This commit replaces the code defined group features with features held 
in a database table:

- Added a GroupFeatures model to the group models, and removed the old 
  features.py
- Added a agenda type for future use in showing different group types on
  different agendas.
- Renamed the group feature has_materials to has_nonsession_materials.
- Added API resources and admin support for the new tables.
- Added a Directorate (with reviews) group type as complement to
  Directorate, to distinguish between directorates with and without reviews.
- Adjusted tests as needed.
- Updated the fixtures, and fixed the generate_fixtures script to include
  the new AgendaTypeName objects.

There still exists about 70 instances of code comparing the group type
with a list of types; most of these should probably be replaced with new
features, instead, to make it possible to add new group types through the
database table, rather than having to edit the code.  That was the purpose
of this refactoring from the start, but the presence of this large number
of comparisons of group type against lists of types defeats the goal until
we add appropriate features and replace the group type list comparisons.
 - Legacy-Id: 15316
 2018-07-12 10:51:48 +00:00
Henrik Levkowetz e87442f33a Merged in [15282] from housley@vigilsec.com: 
Set reply-to for I-D Announcements that include a CC to a mail list.  Fixes #2530.
 - Legacy-Id: 15289
Note: SVN reference [15282] has been migrated to Git commit 733c304e3d
 2018-07-10 17:16:47 +00:00
Henrik Levkowetz c9cc9ff214 Upped the permitted number of search results for the /stream/ise/ page (and friends) from 200 to 1000. Fixes issue #2527. 
- Legacy-Id: 15281
 2018-06-26 16:43:40 +00:00
Robert Sparks 13df62f8ba Tweaked the color palatte for the agenda editor. Commit ready for merge. 
- Legacy-Id: 15247
 2018-06-13 19:58:08 +00:00
Robert Sparks dcf9e6b40f Use factories for ietf.doc.tests_ballots. Fixed a long-hidden bug in test_edit_verify_permissions where non-existing usernames were used and passed the tests accidently. Added list_email to the GroupFactory. Commit ready for merge. 
- Legacy-Id: 15219
 2018-06-06 17:59:40 +00:00
Robert Sparks 84d3c92298 more factoryization of ietf.doc.tests. Commit ready for merge. 
- Legacy-Id: 15205
 2018-06-02 13:39:39 +00:00
Henrik Levkowetz 6c3ec5b18e Added Email origin to Email record creation throughout the codebase. 
- Legacy-Id: 15149
 2018-05-17 16:56:26 +00:00
Henrik Levkowetz 421621eb51 Another round of iesg page optimizations. Reduced additional instances of individual lookups to a single lookup followed by annotation of document objects. Reduced several instances of repeating the same work multiple times (queries for telechat documents, queries for telechat dates). 
- Legacy-Id: 15010
 2018-04-05 11:03:26 +00:00
Adam Roach 3c4c0f2584 Updated (deprecated, unregistered) 'text/json' with 'application/json' everwhere. Commit ready for merge. 
- Legacy-Id: 14843
 2018-03-17 15:14:57 +00:00
Henrik Levkowetz fac3053d48 Fixed an issue with the milestone edit changes. 
- Legacy-Id: 14762
 2018-03-09 21:27:58 +00:00
Henrik Levkowetz cb051a7f59 Changed the handling of the milestone edit form to defer deletion if deletion is indicated together with other changes to the same milestone. Instead emit a warning, and ask for deletion without simultaneous changes to the milestone. 
- Legacy-Id: 14761
 2018-03-09 20:05:09 +00:00
Henrik Levkowetz 2c0348cc7a Found that django's urlize() does not deal well with adjacent parantheses. Replaced it with a filter based on bleach.linkify, which does better. 
- Legacy-Id: 14752
 2018-03-09 15:07:04 +00:00
Henrik Levkowetz 1ed8e967e7 Merged in ^/personal/henrik/6.72.1-django-1.11@14676: Upgrade to Django 1.11 
- Legacy-Id: 14695
 2018-02-25 19:55:16 +00:00
Henrik Levkowetz 5192440c9e Rewrote the head-of-rotation review assignment loop to guarantee that it will terminate. This should fix the 'gateway timeout' issues we've seen lately, when review request volume in some review teams have been such that multiple assignments to the head of queue members have triggered the issue. 
- Legacy-Id: 14684
 2018-02-22 22:18:19 +00:00
Henrik Levkowetz 26bf387356 Replaced direct assignment to m2m fields with .clear() and .set() 
- Legacy-Id: 14666
 2018-02-21 23:58:25 +00:00
Henrik Levkowetz 36b5e2ef8e Changed name from .rel to .remote_field for remote accessors. 
- Legacy-Id: 14665
 2018-02-21 23:56:36 +00:00
Henrik Levkowetz 06362ec046 Got rid of old migrations and created new initial migrations. 
- Legacy-Id: 14662
 2018-02-21 23:46:22 +00:00
Henrik Levkowetz 5638cf3da3 Changed all usage of ForeignKey and OneToOneFiled in model.py files to the compatibility versions from ietf.utils.models. 
- Legacy-Id: 14661
 2018-02-20 15:36:05 +00:00
Henrik Levkowetz 1825406695 Added a presence check before removing a list element. Addresses a 500 in unassigned review form POST. 
- Legacy-Id: 14642
 2018-02-14 14:32:33 +00:00
Robert Sparks 7b89db153e Take a different approach to avoiding the crash when a team secretary uses the bulk assignment form to unassign a request. Reverts r14570. Fixes #2443. Commit ready for merge. 
- Legacy-Id: 14623
 2018-02-07 17:58:27 +00:00
Henrik Levkowetz bf7157341f Merged in [14572] from rjsparks@nostrum.com: 
Corrected the filter for closed review requests. Fixes #2152.
 - Legacy-Id: 14573
Note: SVN reference [14572] has been migrated to Git commit 68725913b5
 2018-01-26 20:02:23 +00:00
Henrik Levkowetz eb6341d826 Removed the possibility of choosing '(None)' as reviewer from the bulk review request edit form; this prevents a crash on line 1474 of ietf/group/views.py, in manage_review_request(). The view code needs further care in order make it possible to unassign an assignment here. 
- Legacy-Id: 14570
 2018-01-25 15:58:59 +00:00
Robert Sparks 15d23299d8 Add navigation to nomcom pages for nomcom members. Put the RFC Status change link in a saner place in the navigation. Fixes #1411 and #2433. Commit ready for merge. 
- Legacy-Id: 14497
 2018-01-09 22:10:10 +00:00
Henrik Levkowetz 7a0a99001c Merged in [14468] from rjsparks@nostrum.com: 
Add the ability to add a comment to a group's history. Fixes #1483.
 - Legacy-Id: 14485
Note: SVN reference [14468] has been migrated to Git commit 13e8f8982c
 2018-01-01 00:42:10 +00:00
Robert Sparks 13e8f8982c Add the ability to add a comment to a group's history. Fixes #1483. Commit ready for merge. 
- Legacy-Id: 14468
 2017-12-28 20:48:58 +00:00
Tero Kivinen 5c1f1dfbd7 Fixed save-continue to work. Fixes #2383. Commit ready for merge 
- Legacy-Id: 14359
 2017-11-11 07:23:50 +00:00
Tero Kivinen 7c7e9ae698 Moved email open assignment summary from subpage to the main review request page. Fixes #2091. Commit ready for merge 
- Legacy-Id: 14356
 2017-11-11 06:29:05 +00:00
Henrik Levkowetz d7618ce26b An improved handling of the 'no active roles' message. 
- Legacy-Id: 14207
 2017-10-13 12:05:44 +00:00
Henrik Levkowetz dfaf5a56ac Renamed groupfilters to group_filters 
- Legacy-Id: 14206
 2017-10-13 11:58:42 +00:00
Henrik Levkowetz efea15e728 Renamed group_tags to groupfilters 
- Legacy-Id: 14205
 2017-10-13 11:55:12 +00:00
Henrik Levkowetz cbda2679a9 Removed some unreachable code. 
- Legacy-Id: 14150
 2017-09-22 14:45:21 +00:00
Henrik Levkowetz a440a30f95 Refined a test case which could fail incorrectly when PersonFactory produced multiple persons who shared the same name during a test run, using TestCase.assertMailboxContains(). 
- Legacy-Id: 14140
 2017-09-19 19:49:51 +00:00
Henrik Levkowetz 4dad8cdf9a Added a test to check for missing admin models, and added the admin models that were currently missing. 
- Legacy-Id: 14021
 2017-08-01 14:00:29 +00:00
Henrik Levkowetz 13bd9e1b59 Merged in [13905] from david.i.allan@ericsson.com: 
Fixes issue #2183.

    2183 fix to status update forms
 - Legacy-Id: 13914
Note: SVN reference [13905] has been migrated to Git commit 6964155a00
 2017-07-15 16:28:36 +00:00
David I. Allan 6964155a00 2183 fix to status update forms commit ready for merge 
- Legacy-Id: 13905
 2017-07-15 14:32:09 +00:00
Peter E. Yee 0d2e3cd32e Allows ADs to manage meeting materials from the meeting/##/materials page. Fixes #2213. Commit ready for merge. 
- Legacy-Id: 13900
 2017-07-15 12:40:13 +00:00
Henrik Levkowetz d2395f9521 Merged in [13832] from rjsparks@nostrum.com: 
Treat Area Groups similar to Working Groups and Research Groups where it makes sense to do so.
 - Legacy-Id: 13836
Note: SVN reference [13832] has been migrated to Git commit 2c92aa213d
 2017-07-11 21:57:01 +00:00
Robert Sparks 2c92aa213d Treat Area Groups similar to Working Groups and Research Groups where it makes sense to do so. Commit ready for merge. 
- Legacy-Id: 13832
 2017-07-11 19:12:21 +00:00
Henrik Levkowetz 900174ae57 Added log.unreachable() calls to some functions believed to be unused. 
- Legacy-Id: 13818
 2017-07-09 15:01:21 +00:00
Henrik Levkowetz b4e2081009 Added a log assertion for calls to can_manage_group_type. 
- Legacy-Id: 13782
 2017-07-06 13:59:00 +00:00
Henrik Levkowetz 6c2331a34e Added test cases for ADs and IRTF Chair for the chartering buttons on /group/chartering. 
- Legacy-Id: 13781
 2017-07-06 13:57:52 +00:00
Henrik Levkowetz 9e5db7ce5c Make sure that factory groups have a type. 
- Legacy-Id: 13780
 2017-07-06 13:56:59 +00:00
Henrik Levkowetz b97d45f5ba Call can_manage_group_type() with the right information. Fixes an issue with chartering buttons not being visible for ADs. 
- Legacy-Id: 13778
 2017-07-06 10:56:08 +00:00
Henrik Levkowetz 108c00a0a3 Merged in [13731] from rjsparks@nostrum.com: 
Reworked how review assigments are processed in order to ensure a team's queue rotates when it should. Fixes #2305.
 - Legacy-Id: 13743
Note: SVN reference [13731] has been migrated to Git commit 7f5cef056ade1641f1d815b0a5f35962077d6d01
 2017-06-30 20:16:22 +00:00
Henrik Levkowetz ce1b655fa2 Code reorganization, doing away with multiple urls_* and views_ files in ietf.group. No intentional functionality changes. 
- Legacy-Id: 13709
 2017-06-22 15:18:08 +00:00
Henrik Levkowetz dcc1bca058 Added assertion logging for found group parent loops to is_decendant_of(). 
- Legacy-Id: 13687
 2017-06-20 13:18:33 +00:00
Henrik Levkowetz e87e3eb661 Added circular parent relationship detection in the Group.is_decendant_of() method and in the group edit form data cleaning. 
- Legacy-Id: 13686
 2017-06-19 23:34:52 +00:00