Henrik Levkowetz
cfcefc2e32
Merged in [16144] from housley@vigilsec.com:
...
Remove some clutter from I-D upload page. The information was mived to the Instructions tab, but a higligh to the Note Well and BCP 78 was added. Fixes #2057 .
- Legacy-Id: 16151
Note: SVN reference [16144] has been migrated to Git commit 37851b9742
2019-04-22 17:39:26 +00:00
Henrik Levkowetz
82672519df
Undid previous merge
...
- Legacy-Id: 16113
2019-03-28 11:05:25 +00:00
Henrik Levkowetz
6a159ebdfd
Merged in [16094] from magnus.westerlund@ericsson.com:
...
Added sortable columns to Review Team Reviewers page. Partially addresses issue #2656
- Legacy-Id: 16112
Note: SVN reference [16094] has been migrated to Git commit 0c0e75861e
2019-03-28 11:02:52 +00:00
Robert Sparks
6dc25cae1a
Bring time series stats back into line with what was before. Note there was an off-by-one-day bug in the month-binning in prior releases.
...
- Legacy-Id: 16075
2019-03-20 20:04:06 +00:00
Robert Sparks
81c5b5091a
Made some docevent creation more consistent. Addressed the TODOs added during the refactor.
...
- Legacy-Id: 16049
2019-03-19 18:48:05 +00:00
Robert Sparks
da3174ab68
Improved several views.
...
- Legacy-Id: 16038
2019-03-18 19:41:07 +00:00
Robert Sparks
4b147f2ef8
More cleanup and correction. Caught a pervasive misuse of a state-name
...
- Legacy-Id: 16036
2019-03-15 20:39:06 +00:00
Robert Sparks
3678d20b0b
Some cleanup around stats. Things are well except for the time series graphs.
...
- Legacy-Id: 16035
2019-03-15 16:50:59 +00:00
Robert Sparks
334767fa6f
Some admin tweaks and removal of a dead template. Tests all pass now. Functionality is still not right.
...
- Legacy-Id: 16032
2019-03-14 19:14:33 +00:00
Robert Sparks
a4db66564c
Checkpoint. Ended up chasing group.views_review before stats.
...
- Legacy-Id: 16030
2019-03-13 22:02:10 +00:00
Robert Sparks
073ce55f6c
Checkpoint. ReviewTests pass, but others still fail of course. Next step is to address stats.
...
- Legacy-Id: 16021
2019-03-12 17:48:19 +00:00
Henrik Levkowetz
682ddee8e4
Reverted earlier application of on_behalf_of() at mail sending call points, and instead did all on_behalf_of processing in condition_message(). Added insertion of Reply-To header fields in this case. Changed all use of the mail-sending 'extra' parameters to use value lists. Updated a bunch of tests accordingly.
...
- Legacy-Id: 16020
2019-03-11 17:01:33 +00:00
Robert Sparks
b85052fe63
Checkpoint. Lots of tests will still fail. Reordered some migrations. Brought about half of the ietf.doc.views_review views into line with the new models. Next step is the other half.
...
- Legacy-Id: 16012
2019-03-07 23:08:14 +00:00
Henrik Levkowetz
8a669909bc
Changed ietf/utils/mail.py to use unicode strings, and changed a call in ietf/reviv/utils.py to use unicode for mail Subject, to fix a server 500 issue.
...
- Legacy-Id: 16007
2019-03-06 16:57:00 +00:00
Henrik Levkowetz
435a0da12d
Added on_behalf_of() calls for from addresses needing it throughout the code.
...
- Legacy-Id: 15992
2019-03-04 20:14:19 +00:00
Robert Sparks
82025f9dca
Continuing to checkpoint.
...
- Legacy-Id: 15986
2019-03-01 23:23:39 +00:00
Robert Sparks
e91d706d5b
Checkpointing. This is an incomplete idea. The tests will fail massively.
...
- Legacy-Id: 15985
2019-03-01 23:19:47 +00:00
Henrik Levkowetz
57a4c9f41f
Added 9 new group features, and changed list-like char fields to json fields, to get better support for using the values as lists. Modified code to use the group features instead of explicit lists of group types in many places in the code.
...
- Legacy-Id: 15908
2019-01-22 18:11:46 +00:00
Robert Sparks
87dd249415
Cleanup: removed the infrastructure for importing reviews from the old review tool. Commit ready for merge.
...
- Legacy-Id: 15865
2019-01-03 21:04:13 +00:00
Henrik Levkowetz
da380342bc
Merged in [15808] from rjsparks@nostrum.com:
...
Allow notify_ad_when to be blank.
- Legacy-Id: 15815
Note: SVN reference [15808] has been migrated to Git commit 6d14714f19
2018-12-13 17:22:14 +00:00
Henrik Levkowetz
f65fcdd2c4
Merged in [15804] from rjsparks@nostrum.com:
...
Add history to ReviewerSettings. Fixes #2147 .
- Legacy-Id: 15811
Note: SVN reference [15804] has been migrated to Git commit cb707248e2
2018-12-13 14:29:58 +00:00
Robert Sparks
6d14714f19
Allow notify_ad_when to be blank. Commit ready for merge.
...
- Legacy-Id: 15808
2018-12-06 21:18:26 +00:00
Robert Sparks
cb707248e2
Add history to ReviewerSettings. Fixes #2147 . Commit ready for merge.
...
- Legacy-Id: 15804
2018-12-03 22:23:01 +00:00
Henrik Levkowetz
e024cca8c4
Merged in [15708] and [15730] from housley@vigilsec.com:
...
Added a mail alias for all review team secretaries. Fixes #2139 . Use
the alias if there is one for email about review request changes. Added
a test for the review team secretary alias functionality.
- Legacy-Id: 15747
Note: SVN reference [15708] has been migrated to Git commit 6067dcbfef
Note: SVN reference [15730] has been migrated to Git commit d525ade0b0
2018-11-10 20:32:42 +00:00
Henrik Levkowetz
3b811ecb41
Merged in [15708] and [15730] from housley@vigilsec.com:
...
Added a mail alias for all review team secretaries. Fixes #2139 . Use
the alias if there is one for email about review request changes. Added
a test for the review team secretary alias functionality.
- Legacy-Id: 15746
Note: SVN reference [15708] has been migrated to Git commit 6067dcbfef
Note: SVN reference [15730] has been migrated to Git commit d525ade0b0
2018-11-10 19:30:32 +00:00
Henrik Levkowetz
0d9c97c5ca
Added a test that checks the mailarch search failure return, and tweaks the no-result return handling.
...
- Legacy-Id: 15745
2018-11-10 19:06:40 +00:00
Henrik Levkowetz
236ee7639d
Merged in [15706] from kivinen@iki.fi:
...
Added easier to detect error message when search returns 0 results. This currently parses html result from the mailarchive system, but when we get proper API to mailarchive system it should be changed to do that instead. Fixes #2126 .
- Legacy-Id: 15744
Note: SVN reference [15706] has been migrated to Git commit f9eeee0cc9
2018-11-09 21:23:45 +00:00
Henrik Levkowetz
89ef806013
Merged in [15701] from kivinen@iki.fi:
...
Changed format of the reviewer statistics in lists. Fixes #2131 .
- Legacy-Id: 15735
Note: SVN reference [15701] has been migrated to Git commit 56acd00c6c
2018-11-07 05:24:25 +00:00
Russ Housley
d525ade0b0
Use review team secretary alias if there is one for email about review request changes. Add test for review team secretary alias. Commit ready for merge.
...
- Legacy-Id: 15730
2018-11-06 07:26:30 +00:00
Russ Housley
6067dcbfef
Allow a mail alias for all review team secretaries. Fixes #2139 . Commit ready for merge.
...
- Legacy-Id: 15708
2018-11-03 11:55:07 +00:00
Tero Kivinen
f9eeee0cc9
Added easier to detect error message when search returns 0 results. This currently parses html result from the mailarchive system, but when we get proper API to mailarchive system it should be changed to do that instead. Fixes #2126 . Commit ready for merge.
...
- Legacy-Id: 15706
2018-11-03 11:08:18 +00:00
Tero Kivinen
56acd00c6c
Changed format of the reviewer statistics in lists. Fixes #2131 . Commit ready for merge.
...
- Legacy-Id: 15701
2018-11-03 09:04:57 +00:00
Robert Sparks
c7bf147b1d
Let review teams opt in to poking a responsible AD when unhappy reviews are submitted. Fixes #2544 . Commit ready for merge.
...
- Legacy-Id: 15675
2018-11-02 20:18:06 +00:00
Robert Sparks
fd8af4b6f7
Review assignment email includes a link to the review request that ensures the reviewer is logged in. Fixes #2543 . Commit ready for merge
...
- Legacy-Id: 15444
2018-09-06 21:39:10 +00:00
Henrik Levkowetz
6350f92ed1
Merged in [15370] from rjsparks@nostrum.com:
...
Use factories for ietf.group.tests_review.
- Legacy-Id: 15404
Note: SVN reference [15370] has been migrated to Git commit 61932cbc9e
2018-07-24 06:14:47 +00:00
Henrik Levkowetz
0ade20b1b8
Added a missing migration (for review unavailable-period reason)
...
- Legacy-Id: 15402
2018-07-23 22:32:41 +00:00
Henrik Levkowetz
ed208a5ebb
Merged in [15342] from peter@akayla.com:
...
Added optional reviewer unavailability reason support. Fixes issue #2146 .
- Legacy-Id: 15375
Note: SVN reference [15342] has been migrated to Git commit f4eba7d4df
2018-07-17 15:27:20 +00:00
Robert Sparks
61932cbc9e
Use factories for ietf.group.tests_review. Commit ready for merge.
...
- Legacy-Id: 15370
2018-07-16 21:07:03 +00:00
Peter E. Yee
f4eba7d4df
Added optional reviewer unavailability reason support. Fixes issue #2146 . Commit ready for merge.
...
- Legacy-Id: 15342
2018-07-14 18:04:31 +00:00
Henrik Levkowetz
2daef52bea
This commit replaces the code defined group features with features held
...
in a database table:
- Added a GroupFeatures model to the group models, and removed the old
features.py
- Added a agenda type for future use in showing different group types on
different agendas.
- Renamed the group feature has_materials to has_nonsession_materials.
- Added API resources and admin support for the new tables.
- Added a Directorate (with reviews) group type as complement to
Directorate, to distinguish between directorates with and without reviews.
- Adjusted tests as needed.
- Updated the fixtures, and fixed the generate_fixtures script to include
the new AgendaTypeName objects.
There still exists about 70 instances of code comparing the group type
with a list of types; most of these should probably be replaced with new
features, instead, to make it possible to add new group types through the
database table, rather than having to edit the code. That was the purpose
of this refactoring from the start, but the presence of this large number
of comparisons of group type against lists of types defeats the goal until
we add appropriate features and replace the group type list comparisons.
- Legacy-Id: 15316
2018-07-12 10:51:48 +00:00
Robert Sparks
a2fa0d6400
Use factories for ietf.doc.tests_material and ietf.doc.tests_review. Commit ready for merge.
...
- Legacy-Id: 15237
2018-06-09 21:20:37 +00:00
Henrik Levkowetz
6c3ec5b18e
Added Email origin to Email record creation throughout the codebase.
...
- Legacy-Id: 15149
2018-05-17 16:56:26 +00:00
Henrik Levkowetz
5f37a71889
Added origin information to all places where we create email address entries.
...
- Legacy-Id: 15127
2018-05-05 12:40:30 +00:00
Henrik Levkowetz
080f6b4385
Added group links to the past meetings page, and also important dates links to IETF meetings with important-date pages.
...
- Legacy-Id: 15053
2018-04-18 13:15:30 +00:00
Henrik Levkowetz
1ed8e967e7
Merged in ^/personal/henrik/6.72.1-django-1.11@14676: Upgrade to Django 1.11
...
- Legacy-Id: 14695
2018-02-25 19:55:16 +00:00
Henrik Levkowetz
06362ec046
Got rid of old migrations and created new initial migrations.
...
- Legacy-Id: 14662
2018-02-21 23:46:22 +00:00
Henrik Levkowetz
5638cf3da3
Changed all usage of ForeignKey and OneToOneFiled in model.py files to the compatibility versions from ietf.utils.models.
...
- Legacy-Id: 14661
2018-02-20 15:36:05 +00:00
Henrik Levkowetz
838ad9cf44
Added page counts for open review requests on the reviewer assignment drop-downs of /group/*/reviews/manage/unassigned/. Fixes issue #2449 .
...
- Legacy-Id: 14644
2018-02-15 18:39:39 +00:00
Robert Sparks
7b89db153e
Take a different approach to avoiding the crash when a team secretary uses the bulk assignment form to unassign a request. Reverts r14570. Fixes #2443 . Commit ready for merge.
...
- Legacy-Id: 14623
2018-02-07 17:58:27 +00:00
Henrik Levkowetz
eb6341d826
Removed the possibility of choosing '(None)' as reviewer from the bulk review request edit form; this prevents a crash on line 1474 of ietf/group/views.py, in manage_review_request(). The view code needs further care in order make it possible to unassign an assignment here.
...
- Legacy-Id: 14570
2018-01-25 15:58:59 +00:00