Commit graph

440 commits

Author SHA1 Message Date
Henrik Levkowetz 421621eb51 Another round of iesg page optimizations. Reduced additional instances of individual lookups to a single lookup followed by annotation of document objects. Reduced several instances of repeating the same work multiple times (queries for telechat documents, queries for telechat dates).
- Legacy-Id: 15010
2018-04-05 11:03:26 +00:00
Adam Roach 3c4c0f2584 Updated (deprecated, unregistered) 'text/json' with 'application/json' everwhere. Commit ready for merge.
- Legacy-Id: 14843
2018-03-17 15:14:57 +00:00
Henrik Levkowetz fac3053d48 Fixed an issue with the milestone edit changes.
- Legacy-Id: 14762
2018-03-09 21:27:58 +00:00
Henrik Levkowetz cb051a7f59 Changed the handling of the milestone edit form to defer deletion if deletion is indicated together with other changes to the same milestone. Instead emit a warning, and ask for deletion without simultaneous changes to the milestone.
- Legacy-Id: 14761
2018-03-09 20:05:09 +00:00
Henrik Levkowetz 2c0348cc7a Found that django's urlize() does not deal well with adjacent parantheses. Replaced it with a filter based on bleach.linkify, which does better.
- Legacy-Id: 14752
2018-03-09 15:07:04 +00:00
Henrik Levkowetz 1ed8e967e7 Merged in ^/personal/henrik/6.72.1-django-1.11@14676: Upgrade to Django 1.11
- Legacy-Id: 14695
2018-02-25 19:55:16 +00:00
Henrik Levkowetz 5192440c9e Rewrote the head-of-rotation review assignment loop to guarantee that it will terminate. This should fix the 'gateway timeout' issues we've seen lately, when review request volume in some review teams have been such that multiple assignments to the head of queue members have triggered the issue.
- Legacy-Id: 14684
2018-02-22 22:18:19 +00:00
Henrik Levkowetz 26bf387356 Replaced direct assignment to m2m fields with .clear() and .set()
- Legacy-Id: 14666
2018-02-21 23:58:25 +00:00
Henrik Levkowetz 36b5e2ef8e Changed name from .rel to .remote_field for remote accessors.
- Legacy-Id: 14665
2018-02-21 23:56:36 +00:00
Henrik Levkowetz 06362ec046 Got rid of old migrations and created new initial migrations.
- Legacy-Id: 14662
2018-02-21 23:46:22 +00:00
Henrik Levkowetz 5638cf3da3 Changed all usage of ForeignKey and OneToOneFiled in model.py files to the compatibility versions from ietf.utils.models.
- Legacy-Id: 14661
2018-02-20 15:36:05 +00:00
Henrik Levkowetz 1825406695 Added a presence check before removing a list element. Addresses a 500 in unassigned review form POST.
- Legacy-Id: 14642
2018-02-14 14:32:33 +00:00
Robert Sparks 7b89db153e Take a different approach to avoiding the crash when a team secretary uses the bulk assignment form to unassign a request. Reverts r14570. Fixes #2443. Commit ready for merge.
- Legacy-Id: 14623
2018-02-07 17:58:27 +00:00
Henrik Levkowetz bf7157341f Merged in [14572] from rjsparks@nostrum.com:
Corrected the filter for closed review requests. Fixes #2152.
 - Legacy-Id: 14573
Note: SVN reference [14572] has been migrated to Git commit 68725913b5
2018-01-26 20:02:23 +00:00
Henrik Levkowetz eb6341d826 Removed the possibility of choosing '(None)' as reviewer from the bulk review request edit form; this prevents a crash on line 1474 of ietf/group/views.py, in manage_review_request(). The view code needs further care in order make it possible to unassign an assignment here.
- Legacy-Id: 14570
2018-01-25 15:58:59 +00:00
Robert Sparks 15d23299d8 Add navigation to nomcom pages for nomcom members. Put the RFC Status change link in a saner place in the navigation. Fixes #1411 and #2433. Commit ready for merge.
- Legacy-Id: 14497
2018-01-09 22:10:10 +00:00
Henrik Levkowetz 7a0a99001c Merged in [14468] from rjsparks@nostrum.com:
Add the ability to add a comment to a group's history. Fixes #1483.
 - Legacy-Id: 14485
Note: SVN reference [14468] has been migrated to Git commit 13e8f8982c
2018-01-01 00:42:10 +00:00
Robert Sparks 13e8f8982c Add the ability to add a comment to a group's history. Fixes #1483. Commit ready for merge.
- Legacy-Id: 14468
2017-12-28 20:48:58 +00:00
Tero Kivinen 5c1f1dfbd7 Fixed save-continue to work. Fixes #2383. Commit ready for merge
- Legacy-Id: 14359
2017-11-11 07:23:50 +00:00
Tero Kivinen 7c7e9ae698 Moved email open assignment summary from subpage to the main review request page. Fixes #2091. Commit ready for merge
- Legacy-Id: 14356
2017-11-11 06:29:05 +00:00
Henrik Levkowetz d7618ce26b An improved handling of the 'no active roles' message.
- Legacy-Id: 14207
2017-10-13 12:05:44 +00:00
Henrik Levkowetz dfaf5a56ac Renamed groupfilters to group_filters
- Legacy-Id: 14206
2017-10-13 11:58:42 +00:00
Henrik Levkowetz efea15e728 Renamed group_tags to groupfilters
- Legacy-Id: 14205
2017-10-13 11:55:12 +00:00
Henrik Levkowetz cbda2679a9 Removed some unreachable code.
- Legacy-Id: 14150
2017-09-22 14:45:21 +00:00
Henrik Levkowetz a440a30f95 Refined a test case which could fail incorrectly when PersonFactory produced multiple persons who shared the same name during a test run, using TestCase.assertMailboxContains().
- Legacy-Id: 14140
2017-09-19 19:49:51 +00:00
Henrik Levkowetz 4dad8cdf9a Added a test to check for missing admin models, and added the admin models that were currently missing.
- Legacy-Id: 14021
2017-08-01 14:00:29 +00:00
Henrik Levkowetz 13bd9e1b59 Merged in [13905] from david.i.allan@ericsson.com:
Fixes issue #2183.

    2183 fix to status update forms
 - Legacy-Id: 13914
Note: SVN reference [13905] has been migrated to Git commit 6964155a00
2017-07-15 16:28:36 +00:00
David I. Allan 6964155a00 2183 fix to status update forms commit ready for merge
- Legacy-Id: 13905
2017-07-15 14:32:09 +00:00
Peter E. Yee 0d2e3cd32e Allows ADs to manage meeting materials from the meeting/##/materials page. Fixes #2213. Commit ready for merge.
- Legacy-Id: 13900
2017-07-15 12:40:13 +00:00
Henrik Levkowetz d2395f9521 Merged in [13832] from rjsparks@nostrum.com:
Treat Area Groups similar to Working Groups and Research Groups where it makes sense to do so.
 - Legacy-Id: 13836
Note: SVN reference [13832] has been migrated to Git commit 2c92aa213d
2017-07-11 21:57:01 +00:00
Robert Sparks 2c92aa213d Treat Area Groups similar to Working Groups and Research Groups where it makes sense to do so. Commit ready for merge.
- Legacy-Id: 13832
2017-07-11 19:12:21 +00:00
Henrik Levkowetz 900174ae57 Added log.unreachable() calls to some functions believed to be unused.
- Legacy-Id: 13818
2017-07-09 15:01:21 +00:00
Henrik Levkowetz b4e2081009 Added a log assertion for calls to can_manage_group_type.
- Legacy-Id: 13782
2017-07-06 13:59:00 +00:00
Henrik Levkowetz 6c2331a34e Added test cases for ADs and IRTF Chair for the chartering buttons on /group/chartering.
- Legacy-Id: 13781
2017-07-06 13:57:52 +00:00
Henrik Levkowetz 9e5db7ce5c Make sure that factory groups have a type.
- Legacy-Id: 13780
2017-07-06 13:56:59 +00:00
Henrik Levkowetz b97d45f5ba Call can_manage_group_type() with the right information. Fixes an issue with chartering buttons not being visible for ADs.
- Legacy-Id: 13778
2017-07-06 10:56:08 +00:00
Henrik Levkowetz 108c00a0a3 Merged in [13731] from rjsparks@nostrum.com:
Reworked how review assigments are processed in order to ensure a team's queue rotates when it should. Fixes #2305.
 - Legacy-Id: 13743
Note: SVN reference [13731] has been migrated to Git commit 7f5cef056ade1641f1d815b0a5f35962077d6d01
2017-06-30 20:16:22 +00:00
Henrik Levkowetz ce1b655fa2 Code reorganization, doing away with multiple urls_* and views_ files in ietf.group. No intentional functionality changes.
- Legacy-Id: 13709
2017-06-22 15:18:08 +00:00
Henrik Levkowetz dcc1bca058 Added assertion logging for found group parent loops to is_decendant_of().
- Legacy-Id: 13687
2017-06-20 13:18:33 +00:00
Henrik Levkowetz e87e3eb661 Added circular parent relationship detection in the Group.is_decendant_of() method and in the group edit form data cleaning.
- Legacy-Id: 13686
2017-06-19 23:34:52 +00:00
Henrik Levkowetz f5298d7bb8 Fixed a bug in which operations were available on the /group/chartering/ 'Chartering or re-chartering' page, so that not only operations on groups in a chartering state is shown, but also the options to start chartering. Fixes issue #2312.
- Legacy-Id: 13584
2017-06-12 19:25:39 +00:00
Henrik Levkowetz 023a32715d Merged in ^/branch/iola/author-stats-r13145 from olau@iola.com, with additional features from ^/personal/henrik/6.52.1-authorstats.
- Legacy-Id: 13550
2017-06-06 18:36:59 +00:00
Henrik Levkowetz a28940fc1e Name/email formatting tweaks, to complement [13536].
- Legacy-Id: 13540
Note: SVN reference [13536] has been migrated to Git commit 55d36e284d
2017-06-06 08:11:31 +00:00
Henrik Levkowetz e19290e98d Merged in [13532] from rjsparks@nostrum.com:
Add an expertise field to reviewer settings. Fixes #2308. ,
 - Legacy-Id: 13539
Note: SVN reference [13532] has been migrated to Git commit d845fba8bec765f2f81ae1a4bbca52c9bceb6e02
2017-06-06 07:54:03 +00:00
Henrik Levkowetz 55d36e284d Changed the '%s <%s>'%(name,email) idiom in several places to use email.utils.formataddr() instead, to avoid future problems with names that would need quotes. Added comments in 2 places where this change would not be appropriate.
- Legacy-Id: 13536
2017-06-05 22:40:11 +00:00
Henrik Levkowetz 2bacdd3a00 Merged in [13500] from rjsparks@nostrum.com:
Provide assigned dates on review team reviewers page. Fixes #2304. Related to #2305.
 - Legacy-Id: 13518
Note: SVN reference [13500] has been migrated to Git commit e422717f91eb26a0691347beca9380889d8ee890
2017-06-04 17:31:25 +00:00
Henrik Levkowetz 5b2087f910 Eliminated several variations on word wrapping, keeping only what used to be wrap_text(), but renamed as ietf.utils.text.wordwrap(). This performs better than django.utils.text.wrap() when there are indented text parts. Replaced django's default wordwrap filter with one calling ietf.utils.text.wordwrap in templates. Changed to triggered wrapping in some cases, with the maybewordwrap filter, which triggers on lines longer than 100 characters. This fixes the issue with undesired wrapping of reviews.
- Legacy-Id: 13505
2017-06-02 23:13:22 +00:00
Henrik Levkowetz d82b8bf036 Reverted one of the changes in [13296], and added a comment explaining the relationship between the role list in roles_for_group_type() and the fields in the following GroupForm.
- Legacy-Id: 13297
Note: SVN reference [13296] has been migrated to Git commit a59331dd63
2017-05-10 13:22:16 +00:00
Henrik Levkowetz a59331dd63 Align the roles edit buttons on a group's about page with the roles that the group edit GroupForm will accept. Avoids edit forms without any fields and some server 500 errors.
- Legacy-Id: 13296
2017-05-10 13:05:51 +00:00
Robert Sparks 2e54a5c443 Distinguish group that have session requests from those that do not on the materials/editable-groups page. Fixes #2284. Commit ready for merge.
- Legacy-Id: 13246
2017-04-19 18:04:48 +00:00