Commit graph

440 commits

Author SHA1 Message Date
Ole Laursen 58dd25ff79 Split up open review requests on the review team page in assigned and
unassigned requests to make it easier to just work with the unassigned
ones. Use same split on the manage reviews page which is now two
pages.
 - Legacy-Id: 12266
2016-11-04 17:19:33 +00:00
Ole Laursen b9d5352afd Display the reviewed revision in reviewer overview page
- Legacy-Id: 12245
2016-11-02 11:33:25 +00:00
Ole Laursen 3835532d71 Insert iconic link to review statistics from the team pages
- Legacy-Id: 12215
2016-10-26 13:35:32 +00:00
Ole Laursen 1febf2465d Fix a bug in the logic that determines which roles are editable (the
bug had the reviewer field showing up on non-dir pages)
 - Legacy-Id: 12186
2016-10-20 15:30:35 +00:00
Ole Laursen 4b987436c0 Fix a missing HttpResponseForbidden in review statistics, make the
review test code use a separate reviewer and reviewsecretary user to
avoid confounding things - also let these use Unicode in their names
to check for Unicode trouble.
 - Legacy-Id: 12175
2016-10-19 11:58:49 +00:00
Ole Laursen d0877a0aa9 Change default of ReviewerSettings.min_interval to null - if it's not
specified for a reviewer, we don't take it into account
 - Legacy-Id: 12168
2016-10-18 10:36:42 +00:00
Ole Laursen a216694c4c Add missing guard on the manage review button so it only shows up if
the user can access the manage review page
 - Legacy-Id: 12166
2016-10-17 21:43:35 +00:00
Ole Laursen 399bb3bf4d Make UnavailablePeriod.start_date nullable and import the unavailable
periods from the Perl tool with start date null as we don't know when
they started.
 - Legacy-Id: 12161
2016-10-17 19:37:56 +00:00
Ole Laursen 505b4fcea3 Fix redirection problem when group_type is not given.
- Legacy-Id: 12136
2016-10-13 19:34:39 +00:00
Ole Laursen 958ba5ba95 Make new branch from trunk and merge in review-tracker-r11921
- Legacy-Id: 12129
2016-10-13 16:38:47 +00:00
Ole Laursen bf55237112 Add statistics section with review statistics. Fix a couple of missing tests.
- Legacy-Id: 12124
2016-10-13 15:20:04 +00:00
Ole Laursen 46dd4682bf Remove debug output
- Legacy-Id: 12102
2016-10-07 16:49:37 +00:00
Ole Laursen 59180240af Add a simple reminder system for reviewers so that they can opt in to
being reminded X days before deadline of an assignment
 - Legacy-Id: 12101
2016-10-07 16:43:29 +00:00
Ole Laursen 227fdd7953 Add reviews to search results and IESG agenda. Support restricting
review types so that teams will only have those review types
listed and suggested that they are configured to have.

Fix a couple of things in the importer after having tested it on all
the databases. Set unavailable end date >= 2020 to indefinite.

Fix a couple of bugs.
 - Legacy-Id: 12095
2016-10-06 14:47:41 +00:00
Ole Laursen a177dc616b Fix a couple of bugs, add test for reviewer overview page
- Legacy-Id: 12081
2016-10-04 20:22:11 +00:00
Ole Laursen 4c7b2847ba Add a utility function for extracting information about review
requests for a given set of teams/reviewers (making it trivial to
compute statistics), revamp the related doc event code to support this
by referencing the review request directly, add a reviewer overview
page with recent performance for each reviewer as well as
settings/unavailable periods. Fix some bugs and shuffle some of the
review code a bit around.

Finish the importer from the previous Perl-based review tool,
importing log entries, figuring out whether a given review is
early/telechat/last call and fixing corner cases.
 - Legacy-Id: 12080
2016-10-03 15:52:32 +00:00
Henrik Levkowetz 7f772641d4 Change the cache key construction to deal with query arguments containing spaces. Fixes 500 errors which would otherwise occur.
- Legacy-Id: 12035
2016-09-25 13:53:22 +00:00
Ole Laursen 99beb58291 Implement a round-robin rotation scheme for reviewers instead of
relying on when they last reviewed. In-order assignments automatically
move the rotation forwards while out-of-order assignments increment
the skip next of the assigned reviewer. Include rotation in open
review assignments email. Fix a couple of issues in the importer.
 - Legacy-Id: 12015
2016-09-21 16:52:50 +00:00
Henrik Levkowetz e553ff80d8 Added an is_bof flag to json_agenda. Also added group state information. Changed the group information to use historic information instead of current.
- Legacy-Id: 12009
2016-09-20 20:28:22 +00:00
Ole Laursen 6da25e6bd9 Add personal review overview page for reviewers, add page for editing
reviewer availability settings, emailing the reviewer/secretary as
necessary, add tests for these pages. Fix a bunch of bugs.
 - Legacy-Id: 11998
2016-09-19 16:05:32 +00:00
Ole Laursen 74a02be9bf Create new branch from trunk@r11921, and merge review-tracker-r11360 into it
- Legacy-Id: 11923
2016-09-06 10:17:12 +00:00
Ole Laursen 1f7d4870a8 Refactor role handling in group editing slightly and add support for
editing reviewer roles in review teams. Also fix a couple of review
related bugs.
 - Legacy-Id: 11921
2016-09-05 12:33:54 +00:00
Henrik Levkowetz 2c484d5abb Added another migration dependency, to avoid looking for removed tables.
- Legacy-Id: 11880
2016-08-26 10:30:21 +00:00
Henrik Levkowetz 2b226ae7b7 Improved test coverage somewhat by making more of the group tests apply to both the /group/acronym and /wg/acronym (or equivalent) url forms.
- Legacy-Id: 11857
2016-08-24 16:50:54 +00:00
Henrik Levkowetz cf5ac68b09 Renumbered and updated the migrations merged in from the eventsaving work. Made the dochistory-adding migration idempotent, and added progress indication as this migration may take as much as an hour to run.
- Legacy-Id: 11854
2016-08-24 15:37:25 +00:00
Ole Laursen dd190b87fe Follow replacements when displaying reviews for a draft on the
document page, too. Add a test to check that recursive replacements
are handled correctly. Polish the display a bit.
 - Legacy-Id: 11847
2016-08-23 14:55:42 +00:00
Ole Laursen 16e28481f6 Add page for emailing open review assignments summary to the review team list
- Legacy-Id: 11846
2016-08-23 14:06:47 +00:00
Ole Laursen 1f71268da1 More polish on manage review requests page: Add save and continue
editing button, reverse sort order so latest (and probably most
interesting) is at the top, disable save buttons when there are no
changes to save
 - Legacy-Id: 11843
2016-08-23 12:12:24 +00:00
Henrik Levkowetz 4b0a9360f0 Merged in ^/branch/iola/event-saving-refactor-r10291, which refactors document saving to always use doc.save_with_history(events), and requires accompanying events. This branch also provides refactoring of recurring regexes in url patterns into a dictionary. As part of the merge, also refactored new code which didn't use the save_with_history() method.
- Legacy-Id: 11840
2016-08-23 10:52:08 +00:00
Ole Laursen 507baade01 Add refresh button to manage reviews page, make save detect changes in
the requests and pop the page back up for confirmation if so
 - Legacy-Id: 11827
2016-08-19 16:40:09 +00:00
Ole Laursen 5eba7bf38e Fix a bug
- Legacy-Id: 11807
2016-08-17 16:12:17 +00:00
Ole Laursen 426542771a Turn ReviewRequest.deadline into a date field with no time
- Legacy-Id: 11801
2016-08-17 15:10:39 +00:00
Robert Sparks 4631df61ef improve some test coverage. Commit ready for merge.
- Legacy-Id: 11767
2016-08-09 18:31:05 +00:00
Robert Sparks 9b2d73b365 add status reports to proceedings. add a view for the applicable status report for a given meeting. Commit ready for merge.
- Legacy-Id: 11766
2016-08-09 15:42:40 +00:00
Henrik Levkowetz 34370c6e16 Merged in [11656] from rjsparks@nostrum.com:
Enhanced factories to simplify test writing.
 - Legacy-Id: 11682
Note: SVN reference [11656] has been migrated to Git commit 030ea1c939
2016-07-16 14:15:41 +00:00
Henrik Levkowetz c7cecf66e9 Added a test case for group home.
- Legacy-Id: 11652
2016-07-13 19:20:13 +00:00
Henrik Levkowetz 8ca48aac42 Make group acronym regex patterns consistent.
There were multiple different regex patterns in different urlpattern
declarations, with some of them permitting characters which should not
occur in group acronym.  Changed them to consistently use [-a-z0-9]+ .
 - Legacy-Id: 11651
2016-07-13 19:19:15 +00:00
Henrik Levkowetz 211943148d Make the group factory produce groups with valid acronyms
- Legacy-Id: 11650
2016-07-13 18:48:53 +00:00
Ole Laursen f7eeb1f0f1 Add missing constraint on team in manage review request page
- Legacy-Id: 11636
2016-07-12 16:12:04 +00:00
Ole Laursen db4ea01e20 Take a bunch of factors into account when sorting reviewers for
assignment to a review request
 - Legacy-Id: 11626
2016-07-12 13:04:14 +00:00
Henrik Levkowetz 8b6d8c9f44 Replaced the hardcoded 'Area Director' approval role with a group-dependent list of approval roles. Fixes issue #1980.
- Legacy-Id: 11575
2016-07-09 16:59:50 +00:00
Henrik Levkowetz 85fb050b2e Brought back, by popular demand, a tab with the link to a group's tools pages (which was removed in release 6.25.0).
- Legacy-Id: 11559
2016-07-08 11:17:58 +00:00
Ole Laursen 5c8be91b08 Improve review assignment slightly by sorting reviewers by latest
review - still missing a bunch of factors, and unassignment is now
temporarily gone
 - Legacy-Id: 11531
2016-07-07 12:17:55 +00:00
Ole Laursen d54459b28a Add tests of suggested review requests, make suggestions take more
things into account
 - Legacy-Id: 11528
2016-07-06 13:14:11 +00:00
Ole Laursen 19fff81a4f Rework closing a review request so the logic is reusable, add the more
specific close reasons to the database migration, add
ReviewRequest.requested_by so it's possible to notify the requester of
a review that it has been dropped.
 - Legacy-Id: 11520
2016-07-05 16:05:00 +00:00
Ole Laursen e2e66522c7 Add review request page for review teams and first draft of manage
review requests page.

Add importer for importing review data from the existing Perl tool
(WIP, gets most but not all of the interesting information out).

Fix various bugs.
 - Legacy-Id: 11508
2016-07-01 16:06:16 +00:00
Henrik Levkowetz a36cf95572 Refactored the code to skip coverage testing a bit, and added skipping of template and url coverage.
- Legacy-Id: 11472
2016-06-24 15:39:59 +00:00
Henrik Levkowetz 6fa181763b Changed the code test coverage checking to never register coverage counts for tests that are sometimes skipped. Removed now unwanted skip settings from the releasetest settings.
- Legacy-Id: 11453
2016-06-21 20:39:28 +00:00
Henrik Levkowetz 54fc7adb9a Fixed a typo.
- Legacy-Id: 11443
2016-06-21 18:59:44 +00:00
Henrik Levkowetz e6a005dba6 Added a score of setting save/restores to test setup/teardown actions.
- Legacy-Id: 11436
2016-06-21 07:51:02 +00:00
Henrik Levkowetz e110419916 Merged in ^/personal/henrik/6.22.1-acctdeps which provides import of addresses subscribed to IETF mailing lists, and additional datatracker account creation requirements. Also a table and form for manual whitelisting of account logins, in order to handle cases which fall outside the default requirements. Fixed some tests.
- Legacy-Id: 11389
2016-06-15 22:10:50 +00:00
Henrik Levkowetz 7c033d3daa Only check state.slug in GroupForm.clean() if state is set.
- Legacy-Id: 11388
2016-06-15 20:02:51 +00:00
Henrik Levkowetz d251692b96 Added a clean() method to the Group creation form which requires a BoF to have a parent group. Fixes issue #1970.
- Legacy-Id: 11387
2016-06-15 19:46:47 +00:00
Henrik Levkowetz 2ba1bde0ba Reverted a bad to group/urls_info.py
- Legacy-Id: 11355
2016-06-14 04:56:50 +00:00
Henrik Levkowetz 9eacdbf2c6 Merged in ^/personal/henrik/6.21.1-biophoto@11313, with work from rjsparks@nostrum.com and henrik@levkowetz.com which provides support for profile biography and photo.
- Legacy-Id: 11314
2016-06-10 19:36:47 +00:00
Henrik Levkowetz 4cb87b5b09 An additional photo test, and a test function rename.
- Legacy-Id: 11313
2016-06-10 18:36:28 +00:00
Henrik Levkowetz ebe45e5312 Added tests for various photo pages.
- Legacy-Id: 11305
2016-06-09 21:59:17 +00:00
Henrik Levkowetz 3e54101e06 Renamed group.views.all_photos() back to chair_photos(). Added differentiated ordering by role to group photo pages. Moved the external links (dependency graph and tools pages) off of the tabs, to the charter page.
- Legacy-Id: 11304
2016-06-09 21:58:35 +00:00
Henrik Levkowetz 7c53eb1843 Renamed group.views.all_photos() back to chair_photos(). Added differentiated ordering by role to group photo pages. Moved the external links (dependency graph and tools pages) off of the tabs, to the charter page.
- Legacy-Id: 11303
2016-06-09 21:58:01 +00:00
Henrik Levkowetz b0cd3a0066 Fixed a problem with accessing a group's workflow customisation page from /group/{{acronym}} instead of /wg/{{acronym}}/.
- Legacy-Id: 11290
2016-06-07 18:13:55 +00:00
Henrik Levkowetz 7edecaee27 Added photo page support for individual groups, and tweaked some names. This provides a photo page for the IAB, but also as a benefit photo pages for other groups.
- Legacy-Id: 11287
2016-06-06 16:33:24 +00:00
Henrik Levkowetz c5e0814e11 Made the photo url and view function names more generic. Shortened a tab name.
- Legacy-Id: 11272
2016-06-05 09:49:24 +00:00
Henrik Levkowetz 14a4ea177c Merged in ^/personal/rjs/6.21.1.dev0@11257
- Legacy-Id: 11259
2016-06-01 16:37:01 +00:00
Henrik Levkowetz 92214726fd Renamed some files under ietf/group/ which contained views but didn't have 'views' in the name.
- Legacy-Id: 11190
2016-05-13 15:59:10 +00:00
Ole Laursen b6d4c5ffe8 Drop naming community URL patterns, just reverse them directly from
the view
 - Legacy-Id: 11175
2016-05-06 18:10:37 +00:00
Ole Laursen 9faae5e915 Merged community list branch with trunk
- Legacy-Id: 11174
2016-05-06 17:36:04 +00:00
Henrik Levkowetz 3327936884 Added a migration to match the changed GROUP_EVENT_CHOICES.
- Legacy-Id: 11155
2016-05-05 12:26:54 +00:00
Robert Sparks eda3f8fba5 Add an entry to GROUP_EVENT_CHOICES for status updates. Fixes #1948. Commit ready for merge.
- Legacy-Id: 11116
2016-04-08 17:41:01 +00:00
Robert Sparks 1f8cc9a4f1 Add a page to show the active status reports all in one place. Fixes #1951. Commit ready for merge.
- Legacy-Id: 11112
2016-04-08 17:31:16 +00:00
Henrik Levkowetz 50c9b32420 Merged in [11085] from bartosz.balazinski@interdigital.com:
Added validation for the dependency graph output type (one of 'dot', 'pdf', 'svg').  Added an area column to the directorate summary page.

    Commit fixes bug #1887, fixes bug #1940.
 - Legacy-Id: 11095
Note: SVN reference [11085] has been migrated to Git commit b46081f514
2016-04-04 20:08:33 +00:00
Bartosz Balazinski b46081f514 Commit fixes bug #1887, fixes bug #1940. Commit ready to merge
- Legacy-Id: 11085
2016-04-02 21:21:05 +00:00
Russ Housley 858530c214 Cleaned up the checking permission for a user to manage a group. Also, cleanly handle a set of group parent links did for a loop.
- Legacy-Id: 11082
2016-04-02 21:06:33 +00:00
Russ Housley 1c509cd64c The secretariat and the Team Chair can now edit team groups. In addition, if the team in within the IETF, Area Directors can edit it. And, if the team is within the IRTF, the IRTF Chair can edit it. Fixes #1915.
- Legacy-Id: 11064
2016-04-02 15:10:10 +00:00
Robert Sparks ca6512e4fa Capture "Status update" summaries for groups that want to provide them. These updates show on the groups charter (or about) page, and in the group history. The most recent update provided before proceedings corrections closing date is included in the group's page in the meeting proceedings. This addresses the majority of #1773 (a ticket entered on behalf of the IESG). Commit ready for merge.
- Legacy-Id: 10969
2016-03-23 19:42:01 +00:00
Ole Laursen c061caaf04 Merge in changes from community-list-cleanup
- Legacy-Id: 10968
2016-03-23 13:31:24 +00:00
Ole Laursen c7589f9b6a Integrate community lists for groups with the existing group documents
page. Each WG/RG now gets a list with an initial set of rules to
populate the list.

Refine the community list management interface a bit to support the
group lists better - group lists aren't connected to the usual track
icons so need to be able to add/remove individual drafts.

Change the "name contains" rule to support regular expressions to
enable each group to have a default replacement for the previously
implemented "related documents" search. Maintain a materialized view
of the regexp-matched drafts with a call in the submit code to avoid
having to scan all drafts/~1000 group rules all the time.
 - Legacy-Id: 10963
2016-03-22 12:48:44 +00:00
Henrik Levkowetz 0005027d3e Merged in [10932] from rjsparks@nostrum.com:
Restrict related documents included in the 1wg-charter* views to those that update or obsolete WG produced RFCs.
 - Legacy-Id: 10935
Note: SVN reference [10932] has been migrated to Git commit d654610393
2016-03-16 08:54:30 +00:00
Robert Sparks d654610393 Restrict related documents included in the 1wg-charter* views to those that update or obsolete WG produced RFCs. Commit ready for merge.
- Legacy-Id: 10932
2016-03-16 03:37:35 +00:00
Henrik Levkowetz 6e6a8baa13 Fixed a typo.
- Legacy-Id: 10931
2016-03-15 23:15:44 +00:00
Henrik Levkowetz adb8625635 Introduced caching for the api resources.
- Legacy-Id: 10929
2016-03-15 23:12:04 +00:00
Henrik Levkowetz 846a02c3f9 Fixed pyflakes complaints introduced with pyflakes 1.1.0
- Legacy-Id: 10896
2016-03-04 21:24:26 +00:00
Henrik Levkowetz 860a3f8e26 Merged in [10862] from rjsparks@nostrum.com:
Group concluded working groups by area. Fixes #1670.
 - Legacy-Id: 10881
Note: SVN reference [10862] has been migrated to Git commit c332e52cbe
2016-02-29 21:43:35 +00:00
Henrik Levkowetz 1ca89775c7 Since the list-archive tab on group pages can sometimes be a tab and sometimes a link out, positioning it between the always-tab and always link-out entries seems reasonable.
- Legacy-Id: 10869
2016-02-28 20:41:22 +00:00
Robert Sparks c332e52cbe Group concluded working groups by area. Fixes #1670. Commit ready for merge.
- Legacy-Id: 10862
2016-02-28 18:23:25 +00:00
Robert Sparks 9431c42394 Data cleanup: place old groups in better states and better areas. Remove a few groups that appear to have never existed (as groups). Commit ready for merge.
- Legacy-Id: 10861
2016-02-28 18:21:52 +00:00
Robert Sparks e8d40c8402 Show all sessions associated with a document.
Remove the day/seq urls from the materials tree.
Allow sessionpresentation.rev to be None, meaning "current version".
Streamlined workflows to focus on current versions of a draft as a default.
Allow adding and editing sessionpresentations when looking at a specific document.
Allow adding drafts when looking at a specific session.
Add the meeting tab to 'team' groups.
Refactored several utility classes and expanded on factories.
Fixes #1908 and #1910.
Commit ready for merge.
 - Legacy-Id: 10856
2016-02-23 16:51:44 +00:00
Robert Sparks a39f207df3 Add the meetings tab to groups of type team
- Legacy-Id: 10855
2016-02-23 16:36:41 +00:00
Robert Sparks 78ca39f237 checkpoint: start of a view showing all sessions associated with a document
- Legacy-Id: 10844
2016-02-17 16:38:33 +00:00
Robert Sparks 4ed83dd7fc Fill in the list archive tab, showing both mailarchive and mhonarc links when they exists. Preserve the immediate link-to-archive behavior for the group pages for lists that are not in mailarchive/mhonarc. Provides a url at the datatracker for the mailman listinfo pages to use that will show both types of archive. Commit ready for merge.
- Legacy-Id: 10840
2016-02-15 20:01:51 +00:00
Robert Sparks 776b95106f Added the ability to associate documents with sessions from the document main page.
Integrated the group meetings tab with the secretariat meeting request and meeting materials pages.
Made better use of bootstrap styling for the meetings tab and session details view.
Commit ready for merge.
 - Legacy-Id: 10779
2016-02-04 21:51:04 +00:00
Robert Sparks 0db79011f2 Provide navigation for session requests from the meeting tab.
- Legacy-Id: 10759
2016-02-01 16:32:36 +00:00
Robert Sparks a9abd3c2cd Tweak factories to not randomly create keys that violate constraints. Commit ready for merge
- Legacy-Id: 10756
2016-01-28 20:12:00 +00:00
Ole Laursen 197bc07771 Refactor search-related utilities slightly to make them more
independent of the search form, to enable them to be reused in the
community lists.

Also clean up the related code a bit, use SearchForm to handle other
document types, and fix missing ids in the HTML so that one can click
the "by" labels to hit the corresponding radio button.
 - Legacy-Id: 10729
2016-01-25 18:11:49 +00:00
Robert Sparks 7d43d3ada4 Adds a meetings tab to the group information page. Links to minutes, agendas, and materials for each session at each meeting. Improves the UI for the session materials page. Commit ready for merge.
- Legacy-Id: 10719
2016-01-20 22:59:14 +00:00
Robert Sparks 1a9401a72f preparing to merge forward
- Legacy-Id: 10715
2016-01-19 22:41:21 +00:00
Ole Laursen 540ef748f7 Fix community list track/untrack on document page, also fix the
attached Javascript which had a split personality regarding how to
deal with a repeated click
 - Legacy-Id: 10714
2016-01-19 11:27:47 +00:00
Henrik Levkowetz f1ca9a0f1c Shave off 10 seconds of test running time by not reading more than the start of files when checing that aliases exist.
- Legacy-Id: 10705
2016-01-16 22:31:31 +00:00
Henrik Levkowetz 6c8629c4a9 Merged in [10629] from rjsparks@nostrum.com:
This set of changes focuses on improvements to the nomcom portion of
    the datatracker. 

    These changes:

    - Simplify the nomcom form for comments. Make it more obvious who
      receives mail when a comment is supplied. Fixes #1849.

    - Simplify the nomcom form for nominations. Provide a primary workflow
      where nominations choose an existing Person, and a secondary
      workflow for nominating new people. 

    - Allow nominees to add a comment when accepting or declining a
      nomination. Fixes #1845.

    - Organize the list of nominees on the feedback page. Fixes #1786 and
      #1809.

    - Simplify the mechanisms used to display feedback message counts.

    - Regroup the feedback view to make it easier to see where to spend
      review effort. Fixes #1866.

    - Capture when nomcom members last reviewed feedback for a given
      nominee. Add badges when new feedback is avaliable. Improve the
      layout of the feedback index page. Fixes #1850.

    - Reorganize the tab navigation on the nomcom private pages. Made it
      more obvious when the chair is doing something that only the chair
      gets to see. Fixes #1788 and #1795.

    - Regroup multiselect options to make classifying pending feedback
      simpler. Make the control larger and resizable. Fixes #1495.

    - Simplify the chair's views for editing nominee records. Replace the
      merge nominee form with a request to the secretariat to merge Person
      records. Fixes #1847. 

    - Added merging nominees to the secretariat's persson merging script. 

    - Show information for concluded nomcoms. Close feedback and
      nomination for concluded nomcoms. Fixes #1856.

    - Improve the questionnaire templates, reminding the nominee that
      receiving the questionnaire does not imply they have accepted a
      nomination. Fixes #1807.

    - Remove the description field from Postion. Simplify the Position
      list and the Position edit form. Make the nomcom pages more self
      documenting. Add a page to help nomcom chiars through setting up a
      new nomcom. Fixes #1867 and #1768.

    - Remove the type from the template pathname for the requirements
      templates. Make the requirements views work for both types plain and
      rst. Changed the default type for new nomcom requirement templates
      to rst.

    - Remove 'incumbent' from the models. Fixes #1771.

    - Adjust the models for Nominee and Nomination to better associate
      Nominee objects with Person objects.

    - Remove BaseNomcomForm and the implementation of custom fieldsets.

    - Replace the custom message framework with the django provided
      messages framework.

    - Improve SearchablePersonField to show the primary email address for
      any search result where a name appears more than once.

    - Add the use of factory-boy for generating test data. Normalize
      management of a test directory for test nomcom public keys.
      Significantly improve test coverage of the nomcom related code.
 - Legacy-Id: 10703
Note: SVN reference [10629] has been migrated to Git commit c8bbfbad78
2016-01-15 21:59:49 +00:00
Ole Laursen b7232d0ab7 Revamp tracked/not tracked icons in search results to not do one query
per document, and make them work on all search result pages, move the
utility function to community/
 - Legacy-Id: 10690
2016-01-14 18:04:05 +00:00
Lars Eggert eabe46b3f8 Fix a "RemovedInDjango19Warning" warning. Commit ready for merge.
- Legacy-Id: 10671
2016-01-13 12:17:36 +00:00
Henrik Levkowetz 4bc31b9856 Merged in [10623] from lars@netapp.com:
Simplify the dependency graph generation, by relying on dot to generate PDF (and
now also SVG) directly. Default to showing SVG from the link on a group's page.
 - Legacy-Id: 10650
Note: SVN reference [10623] has been migrated to Git commit f1dcfcafb6
2016-01-12 17:14:11 +00:00
Henrik Levkowetz 9bf1ff01f1 Merged in [10621] from lars@netapp.com:
Use js tablesort almost everywhere I thought it would make sense. While I
touched the pages, I also corrected a few minor HTML nits, capitalization
inconsistencies and some other minor things.
Range r10605:r10621
 - Legacy-Id: 10647
Note: SVN reference [10621] has been migrated to Git commit 7d3c2681e2
2016-01-12 16:47:18 +00:00
Henrik Levkowetz d3c5609cde Added some tests for the group role email utility functions used by the alias generation scripts. Tempted to start using factory boy, but will wait till Robert's work in the nomcom branch comes in.
- Legacy-Id: 10544
2015-12-04 23:10:01 +00:00
Henrik Levkowetz 9b274111eb Added group secretaries to the alias lists. Refactored related utility functions to less code with fewer branches with greater generality.
- Legacy-Id: 10543
2015-12-04 20:30:43 +00:00
Robert Sparks e81b473282 Expose views for concluded nomcoms. Close feedback and nomination. Initial work on factory-boy based testing. Partially addresses #1856
- Legacy-Id: 10520
2015-11-25 22:17:41 +00:00
Henrik Levkowetz c5ad40c250 Merged in [10430] from rjsparks@nostrum.com:
Reflect the right group type in personnel change messages. Fixes #1746.
 - Legacy-Id: 10444
Note: SVN reference [10430] has been migrated to Git commit 24e451739c
2015-11-07 22:31:18 +00:00
Robert Sparks 24e451739c Reflect the right group type in personnel change messages. Fixes #1746. Commit ready for merge.
- Legacy-Id: 10430
2015-11-05 06:32:04 +00:00
Henrik Levkowetz db7aa73eb4 Merged in [10418] from henrik@levkowetz.com:
Modified the test data to use some AD and WG chair names that contain non-ascii characters, and fixed test issues found.
 - Legacy-Id: 10420
Note: SVN reference [10418] has been migrated to Git commit cf7d794b09
2015-11-04 08:46:35 +00:00
Henrik Levkowetz cf7d794b09 Modified the test data to use some AD and WG chair names that contain non-ascii characters, and fixed test issues found.
- Legacy-Id: 10418
2015-11-04 07:34:56 +00:00
Henrik Levkowetz 7113663676 Merged in [10405] from rjsparks@nostrum.com:
Addresses an issue where the WG document page would show the same document in more than one section. Fixes #1827.
 - Legacy-Id: 10412
Note: SVN reference [10405] has been migrated to Git commit 95df98b6d4
2015-11-03 15:44:53 +00:00
Robert Sparks 95df98b6d4 Addresses an issue where the WG document page would show the same document in more than one section. Fixes #1827. Commit ready for merge.
- Legacy-Id: 10405
2015-11-03 12:29:10 +00:00
Suresh Krishnan e454031b47 Changes to unapproved milestones (e.g. attaching a draft) will not trigger a mail to the WG. Fixes #1818. Commit ready for merge.
- Legacy-Id: 10346
2015-10-31 08:42:37 +00:00
Ole Laursen b9301ef174 Fix weird migration issue
- Legacy-Id: 10327
2015-10-28 10:41:34 +00:00
Ole Laursen 86c3a430d1 Merge in ^/branch/iola/event-saving-refactor-r10076, fixing a few problems
- Legacy-Id: 10298
2015-10-27 10:37:06 +00:00
Henrik Levkowetz 199f4600d9 Save/restore GROUP_VIRTUAL_PATH, the same way we do with DRAFT_VIRTUAL_PATH when modifying it for tests.
- Legacy-Id: 10227
2015-10-17 18:11:54 +00:00
Henrik Levkowetz caa56e97a4 Renamed the two get_email_aliases functions to have distinct names.
- Legacy-Id: 10201
2015-10-13 18:12:59 +00:00
Ole Laursen 20f79316ff Summary: Make the pruning of empty BOF charters look at a history for
empty files too
 - Legacy-Id: 10187
2015-10-12 13:19:45 +00:00
Robert Sparks 1a277b00ec This release improves visibility into where and when the datatracker
sends email. It makes where the datatracker sends email for a given 
action data driven, and it shows where email will be sent for actions
on documents and groups.

Commit ready for merge.
 - Legacy-Id: 10186
2015-10-10 23:08:09 +00:00
Robert Sparks f0f5a51eb6 (Rocky) merge forward.
- Legacy-Id: 10157
2015-10-09 03:16:24 +00:00
Ole Laursen 5b480c4aee Summary: Add migrations to get rid of some empty charters that have
been accidentally created in the past - this has the side-effect of fixing a
couple of crawler errors. Also fix the state of CICM and add
the text for RRGs charter.
 - Legacy-Id: 10147
2015-10-08 16:10:46 +00:00
Ole Laursen 63d96e0354 Summary: Get rid of submit_initial_charter hack, only create a charter
when a first revision has actually been submitted.
 - Legacy-Id: 10136
2015-10-06 15:14:31 +00:00
Ole Laursen 6f044eea08 Summary: Move definition of document names and group acronyms to
settings.URL_REGEXPS, partly to cleanup the urls.py files, partly to
make sure that all URL patterns agree on what constitutes a name
 - Legacy-Id: 10114
2015-10-01 14:16:16 +00:00
Ole Laursen 9545e620b8 Summary: Add migration for renaming x3s3.3 to x3s3dot3
- Legacy-Id: 10113
2015-10-01 12:05:48 +00:00
Ole Laursen e1f0917659 Summary: Add new document saving API, Document.save_with_history(events).
The new API requires at least one event and will automatically save a
snapshot of the document and related state. Document.save() will now
throw an exception if called directly, as the new API is intended to
ensure that documents are saved with both an appropriate snapsnot and
relevant history log, both of which are easily defeated by just
calling .save() directly.

To simplify things, the snapshot is generated after the changes to a
document have been made (in anticipation of coming changes), instead
of before as was usual.

While revising the existing code to work with this API, a couple of
missing events was discovered:

- In draft expiry, a "Document has expired" event was only generated
  in case an IESG process had started on the document - now it's
  always generated, as the document changes its state in any case

- Synchronization updates like title and abstract amendmends from the
  RFC Editor were silently (except for RFC publication) applied and
  not accompanied by a descriptive event - they now are

- do_replace in the Secretariat tools now adds an event

- Proceedings post_process in the Secretariat tools now adds an event

- do_withdraw in the Secretariat tools now adds an event

A migration is needed for snapshotting all documents, takes a while to
run. It turns out that a single document had a bad foreign key so the
migration fixes that too.
 - Legacy-Id: 10101
2015-09-28 14:01:03 +00:00
Robert Sparks dbe4e3789d removed all the milestone reminder machinery
- Legacy-Id: 10091
2015-09-17 20:27:07 +00:00
Robert Sparks f5b6465e81 mailtoken becomes mailtrigger
- Legacy-Id: 10090
2015-09-17 20:03:45 +00:00
Robert Sparks e5a6ab4385 email expansions for groups
- Legacy-Id: 10058
2015-08-25 18:10:51 +00:00
Robert Sparks 90c3426e2f updated mailtoken utilities to match the model refactor. Morphed all the code using the utilities to match. Added paths to get Cc through as needed. Next up: Recipient selection form for the iesg save-and-send-email workflow
- Legacy-Id: 10040
2015-08-23 18:15:06 +00:00
Robert Sparks 8a74604a1b Done with the second pass focusing on test coverage. Lots of test tweaks, some new tests, a couple of bugs fixed. The session request code views need to be redone to allow testing.
- Legacy-Id: 10035
2015-08-21 16:39:00 +00:00
Robert Sparks 56ddf4ca2e checkpoint. includes moderate change to how personnel changes are sent out
- Legacy-Id: 10020
2015-08-17 22:11:54 +00:00
Robert Sparks 89f038a1e3 checkpoint
- Legacy-Id: 10019
2015-08-17 20:24:16 +00:00
Robert Sparks 839d0f89ad checkpoint
- Legacy-Id: 10016
2015-08-13 19:41:02 +00:00
Henrik Levkowetz 2fe8dcb4c2 Added a very simple html version of the json API, to make it easier to explore the api manually.
- Legacy-Id: 9991
2015-08-09 16:28:55 +00:00
Henrik Levkowetz 11411d2c30 Merged in an update from trunk@9942.
- Legacy-Id: 9961
2015-08-03 14:12:38 +00:00
Henrik Levkowetz 0bf86be4ac Added a max-age to the cache control of /group/groupmenu.ajax, in order to improve local caching.
- Legacy-Id: 9947
2015-08-01 14:57:29 +00:00
Henrik Levkowetz 17b100ec51 Merged in [9924] from rjsparks@nostrum.com:
Adds views of active areas, area groups, teams, and directorates.
Adds navigation to those views to the base menus.
Unifies URL patterns shared between group/urls and group/urls_info, 
exposing the same view at, e.g., /group/stir and /wg/stir/.
Improves testing, primarily of group/info.py
 - Legacy-Id: 9930
Note: SVN reference [9924] has been migrated to Git commit 461af5af19
2015-08-01 10:12:40 +00:00
Robert Sparks 461af5af19 Adds views of active areas, area groups, teams, and directorates.
Adds navigation to those views to the base menus.

Unifies URL patterns shared between group/urls and group/urls_info, 
exposing the same view at, e.g., /group/stir and /wg/stir/.

Improves testing, primarily of group/info.py 

Commit ready for merge.
 - Legacy-Id: 9924
2015-07-30 21:51:38 +00:00
Lars Eggert b367007e6e Make nav title capitalization consistent with other text. Consistently add
arrows for tabs that navigate away from the site. Shorten some text.
Commit ready for merge.
 - Legacy-Id: 9849
2015-07-22 10:57:32 +00:00
Henrik Levkowetz f9bca1b6cc Merged in [9812] from suresh.krishnan@ericsson.com:
Informing ADs, chairs and delegates of WG personnel changes. Fixes #1310.
 - Legacy-Id: 9824
Note: SVN reference [9812] has been migrated to Git commit 7feee30d46
2015-07-20 12:54:13 +00:00
Henrik Levkowetz 99a5ba4722 Merged in [9802] from bartosz.balazinski@interdigital.com:
Fixed references (relative to absolute) in template  ietf/templates/group/active_areas.html, fixed build failure on unused import in file 0006_auto_20150718_0509.py,
 - Legacy-Id: 9816
Note: SVN reference [9802] has been migrated to Git commit dba620f8f1
2015-07-19 13:02:53 +00:00
Suresh Krishnan 7feee30d46 Informing ADs, chairs and delegates of WG personnel changes. Fixes #1310. Commit ready for merge
- Legacy-Id: 9812
2015-07-18 16:52:50 +00:00
Bartosz Balazinski dba620f8f1 Fixed references (relative to absolute) in template ietf/templates/group/active_areas.html, fixed build failure on unused import in file 0006_auto_20150718_0509.py, commit ready for merge
- Legacy-Id: 9802
2015-07-18 15:32:57 +00:00
Bartosz Balazinski 7fb17b0b98 Generated the area description page, fixes 1753, commit ready for merge
- Legacy-Id: 9798
2015-07-18 15:07:59 +00:00
Henrik Levkowetz 60b126b492 Merged in [9779] from lars@netapp.com:
Remove the code that used to calculate table_rows, now that the HTML doesn't
use it anymore.
 - Legacy-Id: 9795
Note: SVN reference [9779] has been migrated to Git commit ee1ea031452864ec1df0a92eb6d2512036d7e949
2015-07-18 14:09:28 +00:00
Robert Sparks 61474a4988 Correct typo in field label. Fixes #1731. Commit ready for merge.
- Legacy-Id: 9711
2015-07-09 14:27:03 +00:00
Henrik Levkowetz f45c124427 Merged in [9652] from rjsparks@nostrum.com:
Provide color for ART.
 - Legacy-Id: 9675
Note: SVN reference [9652] has been migrated to Git commit 7744e0cf5d64b0a1bb45e897b71830f0426c522c
2015-06-22 19:41:47 +00:00
Henrik Levkowetz 9067f88fa7 Merged in [9650] from rjsparks@nostrum.com:
Set the parent for newly created RGs. Be more robust if an RG has no parent. Test creation of an RG. Fixes #1718 and #1719.
 - Legacy-Id: 9661
Note: SVN reference [9650] has been migrated to Git commit b9bf7594001f0014ff4c2ac3688b431f1fcd39ec
2015-06-03 16:52:49 +00:00
Henrik Levkowetz 80f36c899e Removed inappropriate group actions and information from external group info pages. Fixes issue #1651.
- Legacy-Id: 9615
2015-05-11 20:19:27 +00:00
Robert Sparks 547a1ae7a8 deflake
- Legacy-Id: 9601
2015-05-04 15:36:00 +00:00
Robert Sparks 4e1b3b2888 let the IAB see the new pages
- Legacy-Id: 9600
2015-05-04 15:10:34 +00:00