Commit graph

127 commits

Author SHA1 Message Date
Henrik Levkowetz 1ed8e967e7 Merged in ^/personal/henrik/6.72.1-django-1.11@14676: Upgrade to Django 1.11
- Legacy-Id: 14695
2018-02-25 19:55:16 +00:00
Henrik Levkowetz 06362ec046 Got rid of old migrations and created new initial migrations.
- Legacy-Id: 14662
2018-02-21 23:46:22 +00:00
Henrik Levkowetz 5638cf3da3 Changed all usage of ForeignKey and OneToOneFiled in model.py files to the compatibility versions from ietf.utils.models.
- Legacy-Id: 14661
2018-02-20 15:36:05 +00:00
Henrik Levkowetz 838ad9cf44 Added page counts for open review requests on the reviewer assignment drop-downs of /group/*/reviews/manage/unassigned/. Fixes issue #2449.
- Legacy-Id: 14644
2018-02-15 18:39:39 +00:00
Robert Sparks 7b89db153e Take a different approach to avoiding the crash when a team secretary uses the bulk assignment form to unassign a request. Reverts r14570. Fixes #2443. Commit ready for merge.
- Legacy-Id: 14623
2018-02-07 17:58:27 +00:00
Henrik Levkowetz eb6341d826 Removed the possibility of choosing '(None)' as reviewer from the bulk review request edit form; this prevents a crash on line 1474 of ietf/group/views.py, in manage_review_request(). The view code needs further care in order make it possible to unassign an assignment here.
- Legacy-Id: 14570
2018-01-25 15:58:59 +00:00
Robert Sparks ba8b4d3a38 Allow those people who can make a review request to edit the request deadline. Send mail to other directorate secretaries when one secretary makes a change to a request. Fixes #2233. Commit ready for merge.
- Legacy-Id: 14549
2018-01-22 21:43:53 +00:00
Robert Sparks 0a9737a5d2 Include information about previous team reviews in assignement emails. Fixes #2392. Commit ready for merge.
- Legacy-Id: 14466
2017-12-26 22:13:13 +00:00
Tero Kivinen 7b4727541a Added closed date column to closed review list. Fixes #2150. Commit ready for merge
- Legacy-Id: 14365
2017-11-11 11:30:00 +00:00
Henrik Levkowetz 2c1438c240 Moved unidecode_name from utils.text to person.name.
Modified UserFactory to use a new locale for each new user, instead of the
same locale for a whole test run.  This (almost) ensures the exercise of
code to deal with non-ascii names, something which would not happen if a
locale with ascii names was chosen at the start of a run.

Modified name.initials() to not use non-word characters as initials.

Modified unidecode_name() to do more normalization, to conform to the
conventions used in internet-drafts.

Added saving of the factory-boy random state in order to be able to re-run
a test suite with the same pseudo-random sequence as in a previous failed
run.

Fixed an issue with email formatting in test_api_submit_ok().

Modified the draft author extraction code to deal better with names with
embedded apostrophes.
 - Legacy-Id: 14141
2017-09-20 15:36:30 +00:00
Henrik Levkowetz 33b275b04f Added ietf.utils.text.unidecode_name() and replaced various uses of unidecode() with it, in order to normalize the generation of ascii versions of names, to avoid different practices in space stripping and space normalization in different parts of the code.
- Legacy-Id: 14128
2017-09-17 15:12:18 +00:00
Henrik Levkowetz 4dad8cdf9a Added a test to check for missing admin models, and added the admin models that were currently missing.
- Legacy-Id: 14021
2017-08-01 14:00:29 +00:00
Robert Sparks 617dac49d6 Send email to reviewer when request is closed with no response. Fixes #2176. Commit ready to merge.
- Legacy-Id: 13897
2017-07-15 12:07:20 +00:00
Henrik Levkowetz 108c00a0a3 Merged in [13731] from rjsparks@nostrum.com:
Reworked how review assigments are processed in order to ensure a team's queue rotates when it should. Fixes #2305.
 - Legacy-Id: 13743
Note: SVN reference [13731] has been migrated to Git commit 7f5cef056ade1641f1d815b0a5f35962077d6d01
2017-06-30 20:16:22 +00:00
Henrik Levkowetz ce1b655fa2 Code reorganization, doing away with multiple urls_* and views_ files in ietf.group. No intentional functionality changes.
- Legacy-Id: 13709
2017-06-22 15:18:08 +00:00
Henrik Levkowetz 023a32715d Merged in ^/branch/iola/author-stats-r13145 from olau@iola.com, with additional features from ^/personal/henrik/6.52.1-authorstats.
- Legacy-Id: 13550
2017-06-06 18:36:59 +00:00
Henrik Levkowetz e19290e98d Merged in [13532] from rjsparks@nostrum.com:
Add an expertise field to reviewer settings. Fixes #2308. ,
 - Legacy-Id: 13539
Note: SVN reference [13532] has been migrated to Git commit d845fba8bec765f2f81ae1a4bbca52c9bceb6e02
2017-06-06 07:54:03 +00:00
Henrik Levkowetz 2bacdd3a00 Merged in [13500] from rjsparks@nostrum.com:
Provide assigned dates on review team reviewers page. Fixes #2304. Related to #2305.
 - Legacy-Id: 13518
Note: SVN reference [13500] has been migrated to Git commit e422717f91eb26a0691347beca9380889d8ee890
2017-06-04 17:31:25 +00:00
Henrik Levkowetz 76628be3fd Merged in ^/branch/iola/author-stats-r13145 from olau@iola.dk, and fixed some tests in code which moved after the latest merge with trunk. The test suite passes, but the migrations are _not_ ready to run, because of numbering conflicts (again due to code changes on trunk since the latest sync).
- Legacy-Id: 13479
2017-05-31 20:59:26 +00:00
Henrik Levkowetz 27ff3850eb Fixed a place where the LastCallDocEvent expiry value was set as a date instead of a datetime.
- Legacy-Id: 13256
2017-04-30 18:57:05 +00:00
Ole Laursen 5b677dc6ba Merge author stats branch into new branch from trunk
- Legacy-Id: 13159
2017-03-28 14:36:40 +00:00
Lars Eggert 8a70e9773d Fix various "RemovedInDjango20Warning" warnings. Commit ready for merge.
- Legacy-Id: 13112
2017-03-25 19:16:45 +00:00
Henrik Levkowetz 4daf66d11c Added DocEvent rev= parameter througout the code.
- Legacy-Id: 12978
2017-03-06 15:08:21 +00:00
Henrik Levkowetz fd9a0d12b5 Renamed a couple of migrations.
- Legacy-Id: 12973
2017-03-05 12:03:15 +00:00
Henrik Levkowetz 119f48699c Added a data migration to add author information to existing reviews.
- Legacy-Id: 12960
2017-03-03 21:14:45 +00:00
Ole Laursen 9308948195 Add person, affiliation and country (through django-countries) to
DocumentAuthor, rename author field to email and make it optional (for
modeling old email-less submissions), remove the authors many to many
referencing field from Document as it is not really pointing the right
place.

Update the Secretariat tools to show affiliation and country.

Add migration for getting rid of the fake email addresses that the
migration script created some years ago (just set the author email
field to null).
 - Legacy-Id: 12739
2017-01-26 17:10:08 +00:00
Robert Sparks 8e007ce50b Make changing skip_next on a review assignment an explicit decision of the assigner. Commit ready for merge. Fixes #2148.
- Legacy-Id: 12670
2017-01-19 14:23:09 +00:00
Henrik Levkowetz 24c9751df4 Merged in [12596] from rjsparks@nostrum.com:
Show other completed reviews of a document on page showing the status of a review request. Fixes #2083.
 - Legacy-Id: 12605
Note: SVN reference [12596] has been migrated to Git commit 2bad0b0bcd
2016-12-21 19:19:31 +00:00
Henrik Levkowetz ec0d6a7e4f Merged in [12593] from rjsparks@nostrum.com:
Send mail to team secretaries when a review is explicitly requested. Change the From and Subject for assignment emails to reviewers to make it clearer what the review is for and who assigned it. Fixes #2053 and #2114.
 - Legacy-Id: 12602
Note: SVN reference [12593] has been migrated to Git commit 10f4892eae
2016-12-21 18:01:00 +00:00
Robert Sparks 2bad0b0bcd Show other completed reviews of a document on page showing the status of a review request. Fixes #2083. Commit ready for merge.
- Legacy-Id: 12596
2016-12-20 22:22:44 +00:00
Robert Sparks 10f4892eae Send mail to team secretaries when a review is explicitly requested. Change the From and Subject for assignment emails to reviewers to make it clearer what the review is for and who assigned it. Fixes #2053 and #2114. Commit ready for merge.
- Legacy-Id: 12593
2016-12-19 22:32:03 +00:00
Henrik Levkowetz d401e6ba67 Fixed an error in migration dependency.
- Legacy-Id: 12592
2016-12-19 21:42:21 +00:00
Henrik Levkowetz 80c0e65428 Merged in [12540] from rjsparks@nostrum.com:
Missed adding a migration to svn for r12521.  Should only be applied after r12521.
 - Legacy-Id: 12591
Note: SVN reference [12540] has been migrated to Git commit 68bdff6fd5
2016-12-19 21:39:54 +00:00
Henrik Levkowetz fb891ecf05 Merged in [12521] from rjsparks@nostrum.com:
Removes classes obviated in r12520.  Should be held for release after r12520 is released?
 - Legacy-Id: 12590
Note: SVN reference [12521] has been migrated to Git commit 483d9db895
2016-12-19 21:19:49 +00:00
Henrik Levkowetz 45d4ce67c7 Adjusted the ReviewRequest.comment AddField migration to match the change in model.
- Legacy-Id: 12553
2016-12-16 12:55:37 +00:00
Henrik Levkowetz ff3638e365 Merged in [12549] from rjsparks@nostrum.com:
allow ads and secretaries to edit the review request comment. Fixes #2096. (Again).
 - Legacy-Id: 12550
Note: SVN reference [12549] has been migrated to Git commit 32b431cf24
2016-12-15 23:10:28 +00:00
Henrik Levkowetz 8dcc1d20a2 Merged in [12545] from rjsparks@nostrum.com:
Allow a review request to include a comment to show to the review team secretary at assignment time and the reviewer at review time. Fixes #2096.
 - Legacy-Id: 12548
Note: SVN reference [12545] has been migrated to Git commit 6fcd8b8a16
2016-12-15 22:45:25 +00:00
Henrik Levkowetz fa684cf6d2 Merged in [12541] from rjsparks@nostrum.com:
Provide default filters for reviewer settings. Fixes #2093.
 - Legacy-Id: 12546
Note: SVN reference [12541] has been migrated to Git commit df86798cf3
2016-12-15 21:57:46 +00:00
Robert Sparks 6fcd8b8a16 Allow a review request to include a comment to show to the review team secretary at assignment time and the reviewer at review time. Fixes #2096. Commit ready for merge.
- Legacy-Id: 12545
2016-12-15 21:52:12 +00:00
Henrik Levkowetz b14e981e66 Merged in [12520] from rjsparks@nostrum.com:
Slight refactor of the review models to capture review team settings. Allows configuring review teams to get automatic suggestions for reviews or not. Provides a better admin for creating/managing review teams. Fixes #2048 and #2072.
 - Legacy-Id: 12544
Note: SVN reference [12520] has been migrated to Git commit b24bdb5bc3
2016-12-15 20:55:40 +00:00
Robert Sparks df86798cf3 Provide default filters for reviewer settings. Fixes #2093. Commit ready for merge.
- Legacy-Id: 12541
2016-12-15 19:48:37 +00:00
Robert Sparks 68bdff6fd5 Missed adding a migration to svn for r12521. Commit ready to merge. Should only be applied after r12521.
- Legacy-Id: 12540
2016-12-15 19:30:36 +00:00
Henrik Levkowetz 51fedbf483 Merged in [12505] from rjsparks@nostrum.com:
Disallow requesting directorate reviews of RFCs (such things would better be done with reviews of status change documents). Fixes #2065.
 - Legacy-Id: 12537
Note: SVN reference [12505] has been migrated to Git commit 1ea983a1c2
2016-12-15 16:31:36 +00:00
Henrik Levkowetz fec5772f9a Deprecation fix: Pass the result of active_review_teams() to a Role.objects query, instead of passing the function.
- Legacy-Id: 12534
2016-12-15 13:23:16 +00:00
Robert Sparks 483d9db895 Removes classes obviated in r12520. Commit ready for merge. Should be held for release after r12520 is released?
- Legacy-Id: 12521
2016-12-15 03:57:21 +00:00
Robert Sparks b24bdb5bc3 Slight refactor of the review models to capture review team settings. Allows configuring review teams to get automatic suggestions for reviews or not. Provides a better admin for creating/managing review teams. Fixes #2048 and #2072. Commit ready for merge.
- Legacy-Id: 12520
2016-12-14 23:26:32 +00:00
Henrik Levkowetz 9a3f6b059b Merged Django-1.8 upgrade work to trunk. Adjusted migration names, and added migrations as necessary. Fixed some instances of broken html.
- Legacy-Id: 12507
2016-12-13 05:55:46 +00:00
Robert Sparks 1ea983a1c2 Disallow requesting directorate reviews of RFCs (such things would better be done with reviews of status change documents). Fixes #2065. Commit ready for merge.
- Legacy-Id: 12505
2016-12-12 21:42:53 +00:00
Henrik Levkowetz 03d90163a5 Merged django-1.8 work forward to copy of 6.39.1
- Legacy-Id: 12504
2016-12-10 19:32:46 +00:00
Henrik Levkowetz 3c956c9896 Added migrations for new timezone data, validation on ReviewerSettings.filter_re, and new docevent types.
- Legacy-Id: 12493
2016-12-09 12:41:38 +00:00