Show other completed reviews of a document on page showing the status of a review request. Fixes #2083. Commit ready for merge.

- Legacy-Id: 12596
This commit is contained in:
Robert Sparks 2016-12-20 22:22:44 +00:00
parent 6ca953ae24
commit 2bad0b0bcd
2 changed files with 18 additions and 0 deletions

View file

@ -158,6 +158,12 @@ class ReviewRequest(models.Model):
def __unicode__(self):
return u"%s review on %s by %s %s" % (self.type, self.doc, self.team, self.state)
def other_requests(self):
return self.doc.reviewrequest_set.exclude(id=self.id)
def other_completed_requests(self):
return self.other_requests().filter(state_id__in=['completed','part-completed'])
def get_default_review_types():
return ReviewTypeName.objects.filter(slug__in=['early','lc','telechat'])

View file

@ -67,6 +67,18 @@
</tr>
{% endif %}
<tr>
<th></th>
<th>Other Reviews</th>
<td>
{% for req in review_req.other_completed_requests %}
{% if req.reviewer == review_req.reviewer %}<strong>{% endif %}
<a href="{% url "ietf.doc.views_review.review_request" name=req.doc request_id=req.id %}">{{req.team.acronym|capfirst}} {{req.type.name}} review of -{{req.reviewed_rev}} by {{req.reviewer.person.plain_name}}</a> {% if req.reviewed_rev != req.doc.rev %} (<a href="{{ rfcdiff_base_url }}?url1={{ req.doc.name }}-{{ req.reviewed_rev }}&url2={{ req.doc.name }}-{{ req.doc.rev }}">diff</a>){% endif %}</br>
{% if req.reviewer == review_req.reviewer %}</strong>{% endif %}
{% endfor %}
</td>
</tr>
{% if review_req.comment %}
<tr>
<th></th>