altf4arnold/datatracker
1
0
Fork 0
Code Issues Pull requests Actions 3 Packages Projects Releases Wiki Activity
11178 commits 1 branch 0 tags 2.6 GiB
Commit graph

1323 commits

Author SHA1 Message Date
Henrik Levkowetz 42c620f4ae Fixed search result ordering where we had comparisons between int and str, which is disallowed in py3. 
- Legacy-Id: 16335
 2019-06-29 13:32:44 +00:00
Henrik Levkowetz 2b1f238204 Changed regex strings to raw strings and fixed a sort comparison int/str issue. 
- Legacy-Id: 16333
 2019-06-29 13:29:13 +00:00
Henrik Levkowetz 484dcece5f Changed all model __unicode__() methods to __str__() 
- Legacy-Id: 16330
 2019-06-28 21:07:08 +00:00
Henrik Levkowetz d40a5ac5ac Removed some regex unicode flags. 
- Legacy-Id: 16321
 2019-06-28 13:33:38 +00:00
Henrik Levkowetz 06daf6ac65 Changed regex strings to raw strings. 
- Legacy-Id: 16312
 2019-06-27 18:08:02 +00:00
Henrik Levkowetz 3ec7e864be Converted leading tabs to spaces in ietf/**/*.py 
- Legacy-Id: 16310
 2019-06-27 14:51:02 +00:00
Henrik Levkowetz d7f5c84182 Initial 2to3 patch with added copyright statement updates. 
- Legacy-Id: 16309
 2019-06-27 14:40:54 +00:00
Henrik Levkowetz db12f2b948 Fixed some name versus pk issues lingering after the Document/DocAlias primary key refactoring. Fixes issue #2729. 
- Legacy-Id: 16288
 2019-06-19 12:57:52 +00:00
Henrik Levkowetz 7270d5f67a Added the option to order API resource lists by primary key, for stable ordering when paging through a list. 
- Legacy-Id: 16284
 2019-06-18 12:40:19 +00:00
Henrik Levkowetz 565c55ab05 The Document and DocAlias primary key refactoring caused the Tastypie API under /api/v1/ to change -- reverting that to use the old form, with name ask key. 
- Legacy-Id: 16282
 2019-06-17 18:53:17 +00:00
Henrik Levkowetz 05c5abed53 Added a missing migration 
- Legacy-Id: 16263
 2019-06-16 13:18:06 +00:00
Henrik Levkowetz be92e6b868 Removed an incorrect log.unreachble() invocation. 
- Legacy-Id: 16262
 2019-06-15 21:32:15 +00:00
Henrik Levkowetz 426870b766 Merged in the Document and DocAlias primary key change and m2m work in ^/personal/henrik/6.96.1-docalias. 
- Legacy-Id: 16261
 2019-06-15 12:00:48 +00:00
Henrik Levkowetz a2cafded25 Changed DocAlias to be many-to-many, in order to be able to handle STD aliases referring to multiple RFCs. 
- Legacy-Id: 16249
 2019-06-14 20:38:14 +00:00
Henrik Levkowetz 815602351f This is a series of 50 migrations that changes the Document and DocAlias 
primary keys from character strings to integers, and makes corresponding code
changes.

This was prompted by database limitations discovered when trying to make
DocAlias use a m2m document field; with 255 long strings as primary keys for
Document and DocAlias this violated the MySQL database limitations.

Changing the primary keys to integers should also improve efficiency.  

Due to the data migrations which create the new integer primary keys and adds
corresponding integer foreign keys matching the previous string foreign keys
in all tables having foreign keys to Document and DocAlias, some of these
migrations take a long time.  The total set of migrations are expected to have
a runtime on the order of 2 hours.
 - Legacy-Id: 16237
 2019-06-10 11:32:46 +00:00
Henrik Levkowetz 1b5cdfe2f5 Added review assignment information to the review-document view. Addresses issue #2717. 
- Legacy-Id: 16203
 2019-05-07 21:53:38 +00:00
Henrik Levkowetz 2538a581c2 Whitespace changes only 
- Legacy-Id: 16187
 2019-05-06 13:32:29 +00:00
Henrik Levkowetz ed2042da0e Some additional tweaks to the review assingment migrations. 
- Legacy-Id: 16183
 2019-05-02 15:40:21 +00:00
Henrik Levkowetz 9282195d6c Fixed some migrations issues that prevented the review assignment refactoring migrations from being reversed and re-applied. 
- Legacy-Id: 16182
 2019-05-02 13:49:14 +00:00
Henrik Levkowetz ca1f3340c0 Changed a ReviewAssignmentDocEvent type from 'closed_review_request' to 'closed_review_assignment', for consistency and readability. 
- Legacy-Id: 16181
 2019-05-02 12:38:41 +00:00
Henrik Levkowetz 8726e74709 Merged in a refactoring of document review code from rjsparks@nostrum.com. This introduces ReviewAssignments, letting us do multiple assingments for a given RevieRequest, without conflating the assignments and their results with the request itself. 
- Legacy-Id: 16177
 2019-04-30 16:54:06 +00:00
Henrik Levkowetz bb4fe3fbbf Undid previous commit 
- Legacy-Id: 16153
 2019-04-22 19:22:42 +00:00
Henrik Levkowetz cfcefc2e32 Merged in [16144] from housley@vigilsec.com: 
Remove some clutter from I-D upload page.  The information was mived to the Instructions tab, but a higligh to the Note Well and BCP 78 was added. Fixes #2057.
 - Legacy-Id: 16151
Note: SVN reference [16144] has been migrated to Git commit 37851b9742
 2019-04-22 17:39:26 +00:00
Henrik Levkowetz 33e0f8c35d Merged in [16126] from housley@vigilsec.com: 
Allow Secretariat to handle downrefs when they approve a document
 - Legacy-Id: 16134
Note: SVN reference [16126] has been migrated to Git commit 8c7e75101d
 2019-04-08 17:02:02 +00:00
Henrik Levkowetz 5aad3a652d Merged in [16110] from rjsparks@nostrum.com: 
Include the note itself in email sent when the RFC editor note changes after document approval. Also changed the flow to redirect back to the writeups pages after editing the RFC editor note. Fixes #2672.
 - Legacy-Id: 16130
Note: SVN reference [16110] has been migrated to Git commit fbfd204eb9
 2019-04-03 19:30:10 +00:00
Henrik Levkowetz c7e5459d5a Merged in [16109] from rjsparks@nostrum.com: 
Protect drafts in certain IRTF states from expiring. Fixes #2669.
 - Legacy-Id: 16129
Note: SVN reference [16109] has been migrated to Git commit 003e472d04
 2019-04-03 19:03:38 +00:00
Russ Housley 8c7e75101d Allow Secretariat to handle downrefs when they approve a document 
- Legacy-Id: 16126
 2019-04-01 19:46:14 +00:00
Robert Sparks fbfd204eb9 Include the note itself in email sent when the RFC editor note changes after document approval. Also changed the flow to redirect back to the writeups pages after editing the RFC editor note. Fixes #2672. Commit ready for merge. 
- Legacy-Id: 16110
 2019-03-28 10:07:11 +00:00
Robert Sparks 003e472d04 Protect drafts in certain IRTF states from expiring. Fixes #2669. Commit ready for merge. 
- Legacy-Id: 16109
 2019-03-28 08:48:35 +00:00
Peter E. Yee cfdbae1f3c Fixed bad calls to rfcdiff for -00 drafts and replaced drafts. Fixes issue #2697. Commit ready for merge. 
- Legacy-Id: 16095
 2019-03-23 18:17:51 +00:00
Robert Sparks 81c5b5091a Made some docevent creation more consistent. Addressed the TODOs added during the refactor. 
- Legacy-Id: 16049
 2019-03-19 18:48:05 +00:00
Robert Sparks f57fb6b8a6 Added the ability to withdraw individual assignments. Added the ability to mark individual assignments no-response. 
- Legacy-Id: 16039
 2019-03-18 21:15:20 +00:00
Robert Sparks da3174ab68 Improved several views. 
- Legacy-Id: 16038
 2019-03-18 19:41:07 +00:00
Robert Sparks 4b147f2ef8 More cleanup and correction. Caught a pervasive misuse of a state-name 
- Legacy-Id: 16036
 2019-03-15 20:39:06 +00:00
Henrik Levkowetz 56543d565c Changed sending of PubReq messages to explicitly use on-behalf-of, without Reply-To. Reply-To is picked up as requestor by RT. Fixes issue #2691 anew. 
- Legacy-Id: 16034
 2019-03-14 21:31:40 +00:00
Robert Sparks 334767fa6f Some admin tweaks and removal of a dead template. Tests all pass now. Functionality is still not right. 
- Legacy-Id: 16032
 2019-03-14 19:14:33 +00:00
Robert Sparks 0856990683 Checkpoint. Most tests do not fail. Oddness with an API resource, and with one template's coverage 
- Legacy-Id: 16031
 2019-03-14 18:39:40 +00:00
Robert Sparks a4db66564c Checkpoint. Ended up chasing group.views_review before stats. 
- Legacy-Id: 16030
 2019-03-13 22:02:10 +00:00
Robert Sparks 073ce55f6c Checkpoint. ReviewTests pass, but others still fail of course. Next step is to address stats. 
- Legacy-Id: 16021
 2019-03-12 17:48:19 +00:00
Henrik Levkowetz 682ddee8e4 Reverted earlier application of on_behalf_of() at mail sending call points, and instead did all on_behalf_of processing in condition_message(). Added insertion of Reply-To header fields in this case. Changed all use of the mail-sending 'extra' parameters to use value lists. Updated a bunch of tests accordingly. 
- Legacy-Id: 16020
 2019-03-11 17:01:33 +00:00
Henrik Levkowetz df42be5d0c Converted a test to use .assertIn() instead of .assertTrue(... in ...) for better failure reports. 
- Legacy-Id: 16016
 2019-03-09 14:56:47 +00:00
Robert Sparks b85052fe63 Checkpoint. Lots of tests will still fail. Reordered some migrations. Brought about half of the ietf.doc.views_review views into line with the new models. Next step is the other half. 
- Legacy-Id: 16012
 2019-03-07 23:08:14 +00:00
Henrik Levkowetz 896f4cd8c7 Fixed a test discrepancy. 
- Legacy-Id: 15995
 2019-03-05 16:19:28 +00:00
Henrik Levkowetz 55bd2e5e42 Fixed some unintentional wg list address changes, and added some other test mail address changes. 
- Legacy-Id: 15994
 2019-03-04 20:54:38 +00:00
Henrik Levkowetz 435a0da12d Added on_behalf_of() calls for from addresses needing it throughout the code. 
- Legacy-Id: 15992
 2019-03-04 20:14:19 +00:00
Henrik Levkowetz 2b811b3d3d Updated the tests to always use @ietf.org addresses where appropriate, and not do so when not appropriate. All test user login addresses have been changed away from @ietf.org. 
- Legacy-Id: 15988
 2019-03-04 20:08:48 +00:00
Robert Sparks 82025f9dca Continuing to checkpoint. 
- Legacy-Id: 15986
 2019-03-01 23:23:39 +00:00
Robert Sparks e91d706d5b Checkpointing. This is an incomplete idea. The tests will fail massively. 
- Legacy-Id: 15985
 2019-03-01 23:19:47 +00:00
Henrik Levkowetz c9db218e31 Increased the DocumentURL.url field length to the legal URL maximum of 2083 
- Legacy-Id: 15972
 2019-02-25 21:05:25 +00:00
Henrik Levkowetz b57ad67041 Updated code and templates to use the new docman and groupman group features. 
- Legacy-Id: 15922
 2019-01-30 15:59:00 +00:00
Henrik Levkowetz ef97f2a821 Merged in GroupFeatures refactoring and expansion from ^/personal/henrik/6.89.4.dev0@15911. 
- Legacy-Id: 15912
 2019-01-24 15:25:01 +00:00
Henrik Levkowetz c87d3741f3 Added 2 utility functions to help create group features query filters, and applied them in 3 places in order to move group feature role list code back into DB queries. 
- Legacy-Id: 15911
 2019-01-23 18:40:39 +00:00
Henrik Levkowetz 57a4c9f41f Added 9 new group features, and changed list-like char fields to json fields, to get better support for using the values as lists. Modified code to use the group features instead of explicit lists of group types in many places in the code. 
- Legacy-Id: 15908
 2019-01-22 18:11:46 +00:00
Henrik Levkowetz f671e391f7 Reverted r15071 with respects to showing the submit for publication button to shepherds. Fixes issue #2673. 
- Legacy-Id: 15906
 2019-01-21 12:32:13 +00:00
Henrik Levkowetz b4e46cd559 Migration reordering to avoid schema migrations after data migrations. 
- Legacy-Id: 15881
 2019-01-14 14:22:13 +00:00
Robert Sparks 87dd249415 Cleanup: removed the infrastructure for importing reviews from the old review tool. Commit ready for merge. 
- Legacy-Id: 15865
 2019-01-03 21:04:13 +00:00
Robert Sparks 25cc00f925 Refactored DocumentInfo to address overloading the external_url field with strings that are not URLs. Commit ready for merge. 
- Legacy-Id: 15864
 2019-01-02 22:55:00 +00:00
Robert Sparks f6886f6105 Corrected a conditional expression and improved the test that exercised it. Commit ready for merge. 
- Legacy-Id: 15822
 2018-12-14 21:50:21 +00:00
Robert Sparks 6118975620 Added an explicit ID-Exists state for the IESG state machine. Reworked code so that the IESG state machine always has a state. Added the ability to release a document from a working group, research group, or the independent stream. Releasing a document removes all stream state, and sets the document to have no stream. 
- Legacy-Id: 15809
 2018-12-11 22:38:05 +00:00
Henrik Levkowetz d2b86bc225 Increased the document limit from 200 to 500 for the AD documents page. 
- Legacy-Id: 15788
 2018-11-26 18:52:18 +00:00
Henrik Levkowetz 68c48f19a0 Improved resolution of an issue with the To: and Cc: addresses of extra review email to responsible AD. 
- Legacy-Id: 15778
 2018-11-20 13:36:12 +00:00
Henrik Levkowetz 9821406f60 Fixed an issue with the To: and Cc: addresses of extra review email to responsible AD. 
- Legacy-Id: 15777
 2018-11-20 13:20:16 +00:00
Henrik Levkowetz 143a58d3cc Added handling for an EOF exception that can occur when using the django file-based cache. 
- Legacy-Id: 15769
 2018-11-13 13:39:47 +00:00
Henrik Levkowetz 13b20f83cb Merged in [15720] from rjsparks@nostrum.com: 
invalidate the get_state_slug cache when the get_state cache is invalidated. Fixes #2630.
 - Legacy-Id: 15760
Note: SVN reference [15720] has been migrated to Git commit f1c1b9fc6c
 2018-11-12 15:38:17 +00:00
Henrik Levkowetz 3b811ecb41 Merged in [15708] and [15730] from housley@vigilsec.com: 
Added a mail alias for all review team secretaries. Fixes #2139.  Use
the alias if there is one for email about review request changes.  Added
a test for the review team secretary alias functionality.
 - Legacy-Id: 15746
Note: SVN reference [15708] has been migrated to Git commit 6067dcbfef

Note: SVN reference [15730] has been migrated to Git commit d525ade0b0
 2018-11-10 19:30:32 +00:00
Henrik Levkowetz 0d9c97c5ca Added a test that checks the mailarch search failure return, and tweaks the no-result return handling. 
- Legacy-Id: 15745
 2018-11-10 19:06:40 +00:00
Henrik Levkowetz 236ee7639d Merged in [15706] from kivinen@iki.fi: 
Added easier to detect error message when search returns 0 results. This currently parses html result from the mailarchive system, but when we get proper API to mailarchive system it should be changed to do that instead. Fixes #2126.
 - Legacy-Id: 15744
Note: SVN reference [15706] has been migrated to Git commit f9eeee0cc9
 2018-11-09 21:23:45 +00:00
Henrik Levkowetz 89ef806013 Merged in [15701] from kivinen@iki.fi: 
Changed format of the reviewer statistics in lists. Fixes #2131.
 - Legacy-Id: 15735
Note: SVN reference [15701] has been migrated to Git commit 56acd00c6c
 2018-11-07 05:24:25 +00:00
Russ Housley d525ade0b0 Use review team secretary alias if there is one for email about review request changes. Add test for review team secretary alias. Commit ready for merge. 
- Legacy-Id: 15730
 2018-11-06 07:26:30 +00:00
Henrik Levkowetz e4af908a74 Merged in [15698] from rjsparks@nostrum.com: 
Notify the RFC Editor when an RFC Editor note is changed after a draft has been approved. Fixes #2440.
 - Legacy-Id: 15729
Note: SVN reference [15698] has been migrated to Git commit 43374969f6
 2018-11-06 07:13:56 +00:00
Robert Sparks f1c1b9fc6c invalidate the get_state_slug cache when the get_state cache is invalidated. Fixes #2630. Commit ready for merge. 
- Legacy-Id: 15720
 2018-11-05 22:43:02 +00:00
Tero Kivinen f9eeee0cc9 Added easier to detect error message when search returns 0 results. This currently parses html result from the mailarchive system, but when we get proper API to mailarchive system it should be changed to do that instead. Fixes #2126. Commit ready for merge. 
- Legacy-Id: 15706
 2018-11-03 11:08:18 +00:00
Tero Kivinen 56acd00c6c Changed format of the reviewer statistics in lists. Fixes #2131. Commit ready for merge. 
- Legacy-Id: 15701
 2018-11-03 09:04:57 +00:00
Henrik Levkowetz 3b8d9ae832 Merged in [15684] from rjsparks@nostrum.com: 
Removed the field and widget that made editing document states easier on the document admin page since they do not survive validation failure of other fields on the form. Excluded states from the modelform since the default states widget is almost impossible to use without producing bad data. If states need to be edited through the admin, it will, for now, need to be done gruelingly through the admin form for State. Fixes #2524.
 - Legacy-Id: 15700
Note: SVN reference [15684] has been migrated to Git commit 128c0a6dbb
 2018-11-03 09:01:59 +00:00
Robert Sparks 43374969f6 Notify the RFC Editor when an RFC Editor note is changed after a draft has been approved. Fixes #2440. Commit ready for merge. 
- Legacy-Id: 15698
 2018-11-03 08:13:10 +00:00
Robert Sparks 5db8831b81 Clearly label cancelled sessions on the week-view on the agenda page. Fixes #2619. Commit ready for merge. 
- Legacy-Id: 15694
 2018-11-03 06:57:59 +00:00
Henrik Levkowetz 95161df4f4 Merged in [15679] from mahoney@nostrum.com: 
Verb tense used in Ballot Issued emails now matches whether the LC end date is in the past or future. Fixes issue #2482.
 - Legacy-Id: 15685
Note: SVN reference [15679] has been migrated to Git commit 194d8c89d1
 2018-11-03 04:37:41 +00:00
Robert Sparks 128c0a6dbb Removed the field and widget that made editing document states easier on the document admin page since they do not survive validation failure of other fields on the form. Excluded states from the modelform since the default states widget is almost impossible to use without producing bad data. If states need to be edited through the admin, it will, for now, need to be done gruelingly through the admin form for State. Fixes #2524. Commit ready for merge. 
- Legacy-Id: 15684
 2018-11-03 04:28:50 +00:00
Jean Mahoney 194d8c89d1 Verb tense used in Ballot Issued emails now matches whether the LC end date is in the past or future. Fixes issue #2482. Commit ready for merge. 
- Legacy-Id: 15679
 2018-11-03 03:38:52 +00:00
Robert Sparks b76ea7bcd5 Let a reviewer indicate that an AD should give this review early attention. Fixes #2553. Commit ready for merge. 
- Legacy-Id: 15676
 2018-11-02 21:23:27 +00:00
Robert Sparks c7bf147b1d Let review teams opt in to poking a responsible AD when unhappy reviews are submitted. Fixes #2544. Commit ready for merge. 
- Legacy-Id: 15675
 2018-11-02 20:18:06 +00:00
Henrik Levkowetz 282a410f3f Merged in [15613] from rjsparks@nostrum.com: 
Make having a trailing slash optional for doc/html/docname. Fixes #2247.
 - Legacy-Id: 15618
Note: SVN reference [15613] has been migrated to Git commit 7593230edde63d4d2e8ec04c455e862aa5e71f21
 2018-10-30 14:02:46 +00:00
Henrik Levkowetz 90e773aafa Merged in [15601] from rjsparks@nostrum.com: 
Corrected some DocTypeName entries' prefix value. Made the search code more robust against DocTypeName objects that have an empty prefix value. Fixes #2599.
 - Legacy-Id: 15604
Note: SVN reference [15601] has been migrated to Git commit 22d459362aec2a06854a515fbcebfec54e8a6e69
 2018-10-21 12:36:01 +00:00
Henrik Levkowetz 3508f59f52 Merged in [15596] from rjsparks@nostrum.com: 
improved coverage for several tests.
 - Legacy-Id: 15600
Note: SVN reference [15596] has been migrated to Git commit 6f18ae882532433ba86322b33c34f5f1b0350cb9
 2018-10-19 14:27:13 +00:00
Henrik Levkowetz ef3cbf4684 Merged in [15595] from rjsparks@nostrum.com: 
Converted stats, submit, sync. and utils/test to use factories. Excluded utils/test_data from coverage checks.
 - Legacy-Id: 15599
Note: SVN reference [15595] has been migrated to Git commit 39e76a836996ec9ed8ea449c92bdfae91c3dbaae
 2018-10-19 12:54:58 +00:00
Henrik Levkowetz 15c8ab9506 Ensure the send_mail argument to save_position is a boolean. 
- Legacy-Id: 15547
 2018-10-09 16:34:45 +00:00
Henrik Levkowetz 22a2e29db8 Added an send_email field to BallotPostitionDocEvent to reflect whether the 'Send email' button was used to save the ballot position. Reverted a different earlier schema change which had the same purpose. Added icons on documents' IESG evaluation record to reflect this. 
- Legacy-Id: 15526
 2018-10-07 15:08:17 +00:00
Henrik Levkowetz 9e0e5d66b3 Merged in [15492] from rjsparks@nostrum.com: 
Use factories for ipr tests.
 - Legacy-Id: 15516
Note: SVN reference [15492] has been migrated to Git commit 775addc616
 2018-10-01 17:51:17 +00:00
Henrik Levkowetz cfb214c48a Added a BallotCommentDocEvent, which extends DocEvent with a send_mail field, in order to better be able to show whether ballot discusses and comments were posted with with the 'send email' button or not. 
- Legacy-Id: 15515
 2018-10-01 13:31:17 +00:00
Robert Sparks 775addc616 Use factories for ipr tests. Commit ready for merge. 
- Legacy-Id: 15492
 2018-09-28 23:16:46 +00:00
Henrik Levkowetz 89b8fe6c1b Moved document methods rfc_number() and rfcnum() to the abstract parent class to have them available also for historical document records. Should fix the recent server 500 on /doc/draft-ietf-aaa-diameter/17/. 
- Legacy-Id: 15454
 2018-09-14 20:29:07 +00:00
Robert Sparks d9b53a5d6c Use unversioned links in ics agendas. Partially fixes #2542. Commit ready for merge. 
- Legacy-Id: 15446
 2018-09-10 20:12:09 +00:00
Robert Sparks fd8af4b6f7 Review assignment email includes a link to the review request that ensures the reviewer is logged in. Fixes #2543. Commit ready for merge 
- Legacy-Id: 15444
 2018-09-06 21:39:10 +00:00
Henrik Levkowetz caa3ec98b4 Changed the menu listing of review dirs and their display on the Directorates page back to what it was before the 'reviews' group type was split out. Added a 'Reviews' column to the Directoratges page. 
- Legacy-Id: 15420
 2018-08-01 18:53:44 +00:00
Henrik Levkowetz 70c5dcc8c4 Merged in [15387] from rjsparks@nostrum.com: 
Use factories for ietf.iesg.tests.
 - Legacy-Id: 15406
Note: SVN reference [15387] has been migrated to Git commit 705e4c84d9
 2018-07-24 08:25:07 +00:00
Henrik Levkowetz ac55203499 Merged in [15380] from rjsparks@nostrum.com: 
Use factories for ietf.idindex.tests.
 - Legacy-Id: 15405
Note: SVN reference [15380] has been migrated to Git commit 2159fdd975
 2018-07-24 07:22:26 +00:00
Henrik Levkowetz 85aa1ecc25 Tweaked a test to prevent failures when looking for a specific string in line-wrapped text. 
- Legacy-Id: 15397
 2018-07-19 15:54:18 +00:00
Robert Sparks 705e4c84d9 Use factories for ietf.iesg.tests. Commit ready for merge. 
- Legacy-Id: 15387
 2018-07-19 13:13:05 +00:00
Henrik Levkowetz db2c326e73 Merged in [15354] from kivinen@iki.fi: 
Added default to review completion draft version number. If the reviewer
is filling in the review form himself the default will be the latest
version of the draft. If it is someone else filling in the review
then the version number is the latest version at the point when review
was assigned (i.e., it assumes reviewer did review on version he was
requested to and then document authors might have updated the document).
Also mark the document versions that are earlier than the review request
date with red background and those which are newer with green background.
Fixes #2125.
 - Legacy-Id: 15386
Note: SVN reference [15354] has been migrated to Git commit dc3e8ee810
 2018-07-18 22:36:01 +00:00
Henrik Levkowetz b054a142d9 Merged in [15349] from kivinen@iki.fi: 
Removed the requirement for review_content field to be mandatory when
using \'link\' method. This partially addresses #2520. Commit ready for
merge.
 - Legacy-Id: 15383
Note: SVN reference [15349] has been migrated to Git commit 0783890fa5
 2018-07-18 18:20:21 +00:00