Henrik Levkowetz
e03784132d
Merged changes from current trunk to Py3 branch.
...
- Legacy-Id: 16468
2019-07-16 15:36:16 +00:00
Henrik Levkowetz
bdc73e771a
Python2/3 compatibility: replaced six.ensure_text() with either six.text_type or django's force_text(), depending on the case, and fixed a variable scope issue.
...
- Legacy-Id: 16461
2019-07-16 13:20:05 +00:00
Henrik Levkowetz
8c6eb3a30a
Python2/3 compatibility: Changed the use of open() and StringIO to io.open() etc.
...
- Legacy-Id: 16458
2019-07-15 19:14:04 +00:00
Henrik Levkowetz
f8d4c3c9a6
More assertContains() and BytesIO() related changes.
...
- Legacy-Id: 16411
2019-07-07 12:45:57 +00:00
Henrik Levkowetz
81fa6dc962
Fixed some issues with bulk changes related to assertContains()
...
- Legacy-Id: 16379
2019-07-04 16:04:39 +00:00
Henrik Levkowetz
05f275a3af
Changed instances of json.loads(r.content) to r.json(). Changed some instances of assert* to assertContains.
...
- Legacy-Id: 16338
2019-06-30 20:44:45 +00:00
Henrik Levkowetz
15e74e89cb
Converted instances of assertTrue(text in response.content) to the recommended assertContains(response, text), and similar for assertFalse(... in ...)
...
- Legacy-Id: 16336
2019-06-29 13:43:31 +00:00
Henrik Levkowetz
d7f5c84182
Initial 2to3 patch with added copyright statement updates.
...
- Legacy-Id: 16309
2019-06-27 14:40:54 +00:00
Henrik Levkowetz
426870b766
Merged in the Document and DocAlias primary key change and m2m work in ^/personal/henrik/6.96.1-docalias.
...
- Legacy-Id: 16261
2019-06-15 12:00:48 +00:00
Henrik Levkowetz
a2cafded25
Changed DocAlias to be many-to-many, in order to be able to handle STD aliases referring to multiple RFCs.
...
- Legacy-Id: 16249
2019-06-14 20:38:14 +00:00
Henrik Levkowetz
ca1f3340c0
Changed a ReviewAssignmentDocEvent type from 'closed_review_request' to 'closed_review_assignment', for consistency and readability.
...
- Legacy-Id: 16181
2019-05-02 12:38:41 +00:00
Henrik Levkowetz
8726e74709
Merged in a refactoring of document review code from rjsparks@nostrum.com. This introduces ReviewAssignments, letting us do multiple assingments for a given RevieRequest, without conflating the assignments and their results with the request itself.
...
- Legacy-Id: 16177
2019-04-30 16:54:06 +00:00
Henrik Levkowetz
bb4fe3fbbf
Undid previous commit
...
- Legacy-Id: 16153
2019-04-22 19:22:42 +00:00
Henrik Levkowetz
cfcefc2e32
Merged in [16144] from housley@vigilsec.com:
...
Remove some clutter from I-D upload page. The information was mived to the Instructions tab, but a higligh to the Note Well and BCP 78 was added. Fixes #2057 .
- Legacy-Id: 16151
Note: SVN reference [16144] has been migrated to Git commit 37851b9742
2019-04-22 17:39:26 +00:00
Robert Sparks
f57fb6b8a6
Added the ability to withdraw individual assignments. Added the ability to mark individual assignments no-response.
...
- Legacy-Id: 16039
2019-03-18 21:15:20 +00:00
Robert Sparks
da3174ab68
Improved several views.
...
- Legacy-Id: 16038
2019-03-18 19:41:07 +00:00
Robert Sparks
4b147f2ef8
More cleanup and correction. Caught a pervasive misuse of a state-name
...
- Legacy-Id: 16036
2019-03-15 20:39:06 +00:00
Robert Sparks
0856990683
Checkpoint. Most tests do not fail. Oddness with an API resource, and with one template's coverage
...
- Legacy-Id: 16031
2019-03-14 18:39:40 +00:00
Robert Sparks
a4db66564c
Checkpoint. Ended up chasing group.views_review before stats.
...
- Legacy-Id: 16030
2019-03-13 22:02:10 +00:00
Robert Sparks
073ce55f6c
Checkpoint. ReviewTests pass, but others still fail of course. Next step is to address stats.
...
- Legacy-Id: 16021
2019-03-12 17:48:19 +00:00
Henrik Levkowetz
682ddee8e4
Reverted earlier application of on_behalf_of() at mail sending call points, and instead did all on_behalf_of processing in condition_message(). Added insertion of Reply-To header fields in this case. Changed all use of the mail-sending 'extra' parameters to use value lists. Updated a bunch of tests accordingly.
...
- Legacy-Id: 16020
2019-03-11 17:01:33 +00:00
Robert Sparks
b85052fe63
Checkpoint. Lots of tests will still fail. Reordered some migrations. Brought about half of the ietf.doc.views_review views into line with the new models. Next step is the other half.
...
- Legacy-Id: 16012
2019-03-07 23:08:14 +00:00
Henrik Levkowetz
2b811b3d3d
Updated the tests to always use @ietf.org addresses where appropriate, and not do so when not appropriate. All test user login addresses have been changed away from @ietf.org.
...
- Legacy-Id: 15988
2019-03-04 20:08:48 +00:00
Henrik Levkowetz
3b811ecb41
Merged in [15708] and [15730] from housley@vigilsec.com:
...
Added a mail alias for all review team secretaries. Fixes #2139 . Use
the alias if there is one for email about review request changes. Added
a test for the review team secretary alias functionality.
- Legacy-Id: 15746
Note: SVN reference [15708] has been migrated to Git commit 6067dcbfef
Note: SVN reference [15730] has been migrated to Git commit d525ade0b0
2018-11-10 19:30:32 +00:00
Henrik Levkowetz
0d9c97c5ca
Added a test that checks the mailarch search failure return, and tweaks the no-result return handling.
...
- Legacy-Id: 15745
2018-11-10 19:06:40 +00:00
Henrik Levkowetz
89ef806013
Merged in [15701] from kivinen@iki.fi:
...
Changed format of the reviewer statistics in lists. Fixes #2131 .
- Legacy-Id: 15735
Note: SVN reference [15701] has been migrated to Git commit 56acd00c6c
2018-11-07 05:24:25 +00:00
Russ Housley
d525ade0b0
Use review team secretary alias if there is one for email about review request changes. Add test for review team secretary alias. Commit ready for merge.
...
- Legacy-Id: 15730
2018-11-06 07:26:30 +00:00
Tero Kivinen
56acd00c6c
Changed format of the reviewer statistics in lists. Fixes #2131 . Commit ready for merge.
...
- Legacy-Id: 15701
2018-11-03 09:04:57 +00:00
Robert Sparks
b76ea7bcd5
Let a reviewer indicate that an AD should give this review early attention. Fixes #2553 . Commit ready for merge.
...
- Legacy-Id: 15676
2018-11-02 21:23:27 +00:00
Robert Sparks
c7bf147b1d
Let review teams opt in to poking a responsible AD when unhappy reviews are submitted. Fixes #2544 . Commit ready for merge.
...
- Legacy-Id: 15675
2018-11-02 20:18:06 +00:00
Robert Sparks
fd8af4b6f7
Review assignment email includes a link to the review request that ensures the reviewer is logged in. Fixes #2543 . Commit ready for merge
...
- Legacy-Id: 15444
2018-09-06 21:39:10 +00:00
Henrik Levkowetz
2daef52bea
This commit replaces the code defined group features with features held
...
in a database table:
- Added a GroupFeatures model to the group models, and removed the old
features.py
- Added a agenda type for future use in showing different group types on
different agendas.
- Renamed the group feature has_materials to has_nonsession_materials.
- Added API resources and admin support for the new tables.
- Added a Directorate (with reviews) group type as complement to
Directorate, to distinguish between directorates with and without reviews.
- Adjusted tests as needed.
- Updated the fixtures, and fixed the generate_fixtures script to include
the new AgendaTypeName objects.
There still exists about 70 instances of code comparing the group type
with a list of types; most of these should probably be replaced with new
features, instead, to make it possible to add new group types through the
database table, rather than having to edit the code. That was the purpose
of this refactoring from the start, but the presence of this large number
of comparisons of group type against lists of types defeats the goal until
we add appropriate features and replace the group type list comparisons.
- Legacy-Id: 15316
2018-07-12 10:51:48 +00:00
Robert Sparks
a2fa0d6400
Use factories for ietf.doc.tests_material and ietf.doc.tests_review. Commit ready for merge.
...
- Legacy-Id: 15237
2018-06-09 21:20:37 +00:00
Robert Sparks
ba8b4d3a38
Allow those people who can make a review request to edit the request deadline. Send mail to other directorate secretaries when one secretary makes a change to a request. Fixes #2233 . Commit ready for merge.
...
- Legacy-Id: 14549
2018-01-22 21:43:53 +00:00
Robert Sparks
0a9737a5d2
Include information about previous team reviews in assignement emails. Fixes #2392 . Commit ready for merge.
...
- Legacy-Id: 14466
2017-12-26 22:13:13 +00:00
Henrik Levkowetz
e79397d6ad
Added cleaning of review_url from the review completion form, to make sure it's retrievable.
...
- Legacy-Id: 14227
2017-10-27 05:54:34 +00:00
Henrik Levkowetz
39dbf43da4
Merged in [13918] from kivinen@iki.fi:
...
Unified the review request views to use same template, so they all
show same data, in same format.
- Legacy-Id: 13936
Note: SVN reference [13918] has been migrated to Git commit b6e036b63e
2017-07-18 12:57:56 +00:00
Henrik Levkowetz
023a32715d
Merged in ^/branch/iola/author-stats-r13145 from olau@iola.com, with additional features from ^/personal/henrik/6.52.1-authorstats.
...
- Legacy-Id: 13550
2017-06-06 18:36:59 +00:00
Henrik Levkowetz
2e20d9df66
Changed all instances of deprecated self.failUnless() unittest method to self.assertTrue().
...
- Legacy-Id: 13515
2017-06-04 16:24:34 +00:00
Henrik Levkowetz
08f134bf52
Improved review linebreaking tests, based on [13495] from olau@iola.dk.
...
- Legacy-Id: 13511
Note: SVN reference [13495] has been migrated to Git commit 1a59cf60d3
2017-06-04 15:14:56 +00:00
Ole Laursen
1a59cf60d3
Introduce a word-wrapping filter that checks if there are lines (containing spaces to not
...
count URLs) longer than 100 characters, and only wraps the text if that's the case, to
prevent messing up pre-wrapped text. Use this filter in the review email code.
Branch ready for merge.
- Legacy-Id: 13495
2017-06-02 13:17:30 +00:00
Henrik Levkowetz
76628be3fd
Merged in ^/branch/iola/author-stats-r13145 from olau@iola.dk, and fixed some tests in code which moved after the latest merge with trunk. The test suite passes, but the migrations are _not_ ready to run, because of numbering conflicts (again due to code changes on trunk since the latest sync).
...
- Legacy-Id: 13479
2017-05-31 20:59:26 +00:00
Ole Laursen
5b677dc6ba
Merge author stats branch into new branch from trunk
...
- Legacy-Id: 13159
2017-03-28 14:36:40 +00:00
Henrik Levkowetz
14c748df98
Changed the creation of temporary test dirs to use names which include the test class name, in order to make it possible to run test cases in parallel. Disabled coverage testing when running in parallel (those classes cannot be pickled and distributed to the test runner threads, and also won't pass coverage data back). Tweaked the TestCase.tempdir() method.
...
- Legacy-Id: 13157
2017-03-27 21:41:18 +00:00
Lars Eggert
8a70e9773d
Fix various "RemovedInDjango20Warning" warnings. Commit ready for merge.
...
- Legacy-Id: 13112
2017-03-25 19:16:45 +00:00
Henrik Levkowetz
4daf66d11c
Added DocEvent rev= parameter througout the code.
...
- Legacy-Id: 12978
2017-03-06 15:08:21 +00:00
Henrik Levkowetz
c006c44423
Added setting of document author for review document objects.
...
- Legacy-Id: 12957
2017-03-03 19:40:09 +00:00
Henrik Levkowetz
541085b1a8
Changed email notifications for reviews done to save the message as a Message instance before sending it. Added test code to check that a Message instance is created and matches what goes out.
...
- Legacy-Id: 12955
2017-03-03 15:45:29 +00:00
Robert Sparks
8577a5e84a
Use the Role email associated with a reviewer as the From when emailing a review. Fixes #2201 . Commit ready for merge.
...
- Legacy-Id: 12930
2017-02-28 18:40:09 +00:00
Henrik Levkowetz
27351c4349
Fixed url lookups for doc.views_doc.document_main() to only use dotted-path, and removed the doc_view explicit url name. Fixes a 500 error in /submit/status/NNNN/.
...
- Legacy-Id: 12897
2017-02-22 11:40:55 +00:00