Commit graph

831 commits

Author SHA1 Message Date
Henrik Levkowetz e4ce339235 Merged in [12461] from rjsparks@nostrum.com:
Added migration to fetch text from reviews in the mail archives and populate the review documents. Fixes #2064.  Will patch into production.
 - Legacy-Id: 12463
Note: SVN reference [12461] has been migrated to Git commit 63a9599bafdcacf49f1bb374b2156d8473da93d1
2016-12-05 21:03:49 +00:00
Henrik Levkowetz 486e394cbf Added more document information to the personal profile pages at /person/<full name>, after a suggestion from Benoit Claise. Fixes issue #2066.
- Legacy-Id: 12447
2016-12-05 13:00:01 +00:00
Henrik Levkowetz 37f9aa06be Merged in [12438] from rjsparks@nostrum.com:
Don't show teams with only 'No response' reviews in the search result rows, using the same logic as used for the document main page. Fixes #2070.
 - Legacy-Id: 12441
Note: SVN reference [12438] has been migrated to Git commit d1c0c053327594c8a594ad2ad779fac9974d8eaa
2016-12-01 22:16:32 +00:00
Henrik Levkowetz e3ce2a9657 Tweaked the admin for doc.models.Document to capture a comment about changes made, and save those in the document history, using .save_with_history(). This makes the admin useful again for doing document changes. See issue #2067.
- Legacy-Id: 12434
2016-12-01 16:35:23 +00:00
Henrik Levkowetz c79b40bc88 Changed the handling of DocEvent 'rev' fields in document history. We should give DocEvent a 'rev' field which is always filled in; the current handling is error prone and much to complicated.
- Legacy-Id: 12433
2016-12-01 13:49:36 +00:00
Henrik Levkowetz b914f46313 Merged in ^/branch/iola/review-tracker-r12128@12397, bringing in the review tool functionality described in RFC7735. This adds the ability to set up review management pages for review teams such as genart, secdir, opsdir, etc.; letting the review team secretaries manage requested and completed reviews; letting the reviewers keep track of and document their reviews, and more. See the RFC for full specification, and the branch commit log for a full commit history.
- Legacy-Id: 12419
2016-11-29 14:54:19 +00:00
Henrik Levkowetz b00824a6bf Merged in [12385] from rjsparks@nostrum.com:
Added an extra highlight to the ballot_icon box when the viewer holds a blocking position in that ballot. Fixes #2046.
 - Legacy-Id: 12388
Note: SVN reference [12385] has been migrated to Git commit 3c63fdb800
2016-11-18 13:43:28 +00:00
Robert Sparks 3c63fdb800 Added an extra highlight to the ballot_icon box when the viewer holds a blocking position in that ballot. Fixes #2046. Commit ready for merge.
- Legacy-Id: 12385
2016-11-18 04:52:13 +00:00
Robert Sparks ab96f6c89c Fix an issue with the agenda linking to group type "other" slides. Will patch production. Commit ready for merge.
- Legacy-Id: 12338
2016-11-13 01:58:53 +00:00
Ole Laursen e171aa657e Add support for revising a closed review, mostly to allow reviewers to
correct historic entries with missing data
 - Legacy-Id: 12314
2016-11-09 16:20:58 +00:00
Ole Laursen cde7cfacd5 Modify the reviewer overview page to display up to 10 historic reviews
per person from the past year instead of only 5.

Add basic reviewer stats to the assignment select box.
 - Legacy-Id: 12279
2016-11-07 22:32:53 +00:00
Henrik Levkowetz 27abaae2e4 Tweaked and enhanced doc.admin.DocEventAdmin.
- Legacy-Id: 12276
2016-11-07 18:38:34 +00:00
Henrik Levkowetz 7f1c1e43f2 Replaced the use of plain DocEvent for submission doc events with a SubmissionDocEvent that carries rev and a FK to submission.
- Legacy-Id: 12275
2016-11-07 18:21:34 +00:00
Henrik Levkowetz 288d211ca1 Made doc.views_stat.make_title() more robust against inconsistent query arguments.
- Legacy-Id: 12242
2016-10-30 18:16:52 +00:00
Henrik Levkowetz aec77c2385 Rewrote Document.href() to not do database queries when possible, as that has a big performance impact. Fixed a number of tests which relied on href() not doing the right thing for simplified test data. Added caching of canonical_name(), which can be quite heavy. Additional refactoring in a number of places, to use better test data and avoid test failures for good code :-)
- Legacy-Id: 12226
2016-10-28 16:59:42 +00:00
Ole Laursen 3835532d71 Insert iconic link to review statistics from the team pages
- Legacy-Id: 12215
2016-10-26 13:35:32 +00:00
Henrik Levkowetz a2c8fa0178 Added a Document.pub_date() method which returns the RFC publication datetime or other documents' new-revision datetime. Changed the generated bibtex entries to use pub_date(). Added tests for bibtext entries. Added 'bibtexparser' to requirements.txt. Fixes issue #2032.
- Legacy-Id: 12212
2016-10-25 18:07:48 +00:00
Henrik Levkowetz cae4ab0024 Added caching of Document.href() values.
- Legacy-Id: 12210
2016-10-25 00:14:21 +00:00
Ole Laursen 2548153894 Fix permission bug, secretaries should be able to request reviews
- Legacy-Id: 12191
2016-10-20 19:57:39 +00:00
Ole Laursen 4b987436c0 Fix a missing HttpResponseForbidden in review statistics, make the
review test code use a separate reviewer and reviewsecretary user to
avoid confounding things - also let these use Unicode in their names
to check for Unicode trouble.
 - Legacy-Id: 12175
2016-10-19 11:58:49 +00:00
Ole Laursen d0877a0aa9 Change default of ReviewerSettings.min_interval to null - if it's not
specified for a reviewer, we don't take it into account
 - Legacy-Id: 12168
2016-10-18 10:36:42 +00:00
Ole Laursen e11a911d86 Include from in the list of messages when completing a review and
searching for the review email, redo layout somewhat to accommodate
this and improve the presentation of the message date.
 - Legacy-Id: 12163
2016-10-17 21:26:36 +00:00
Ole Laursen e1f69171b5 xslugify the last name part when constructing a name for the review document
- Legacy-Id: 12147
2016-10-14 09:42:34 +00:00
Ole Laursen e3fbc070f9 Fix bug in reference in resources
- Legacy-Id: 12143
2016-10-14 08:43:21 +00:00
Ole Laursen 9de2d49823 Fixup some of the migrations a bit upon the merge with trunk.
- Legacy-Id: 12135
2016-10-13 19:20:26 +00:00
Ole Laursen 958ba5ba95 Make new branch from trunk and merge in review-tracker-r11921
- Legacy-Id: 12129
2016-10-13 16:38:47 +00:00
Ole Laursen 5a878981fe Guard against reviewer name not being filled in properly (still
containing a @) on the complete review page
 - Legacy-Id: 12127
2016-10-13 15:54:11 +00:00
Henrik Levkowetz 99b22efc96 Merged in [12104] from rjsparks@nostrum.com:
Don't show the request publication button for ise,irtf, and iab drafts after publication has already been requested. Fixes #2019.
 - Legacy-Id: 12122
Note: SVN reference [12104] has been migrated to Git commit 933134f4cc
2016-10-12 18:39:22 +00:00
Robert Sparks 933134f4cc Don't show the request publication button for ise,irtf, and iab drafts after publication has already been requested. Fixes #2019. Commit ready for merge.
- Legacy-Id: 12104
2016-10-07 17:29:05 +00:00
Ole Laursen 227fdd7953 Add reviews to search results and IESG agenda. Support restricting
review types so that teams will only have those review types
listed and suggested that they are configured to have.

Fix a couple of things in the importer after having tested it on all
the databases. Set unavailable end date >= 2020 to indefinite.

Fix a couple of bugs.
 - Legacy-Id: 12095
2016-10-06 14:47:41 +00:00
Henrik Levkowetz 5f03d70bd7 Added admin support for the DocumentAuthor model.
- Legacy-Id: 12089
2016-10-05 15:16:46 +00:00
Ole Laursen 0aa8f8a7cc Don't automatically open a new review request if there's already
another open request in the team
 - Legacy-Id: 12086
2016-10-05 13:34:15 +00:00
Ole Laursen a177dc616b Fix a couple of bugs, add test for reviewer overview page
- Legacy-Id: 12081
2016-10-04 20:22:11 +00:00
Ole Laursen 4c7b2847ba Add a utility function for extracting information about review
requests for a given set of teams/reviewers (making it trivial to
compute statistics), revamp the related doc event code to support this
by referencing the review request directly, add a reviewer overview
page with recent performance for each reviewer as well as
settings/unavailable periods. Fix some bugs and shuffle some of the
review code a bit around.

Finish the importer from the previous Perl-based review tool,
importing log entries, figuring out whether a given review is
early/telechat/last call and fixing corner cases.
 - Legacy-Id: 12080
2016-10-03 15:52:32 +00:00
Henrik Levkowetz a9f879cd0e Tweaked admin models.
- Legacy-Id: 12071
2016-10-01 13:36:31 +00:00
Henrik Levkowetz e3a7d47fdc Moved some code and tweaked settings to ignore sql debug functions when calculating code coverage.
- Legacy-Id: 12069
2016-09-30 21:29:32 +00:00
Henrik Levkowetz 9e18351a0b Refined the sql debug info, making the table of queries sortable and adding duplication counts and accumulated query time.
- Legacy-Id: 12068
2016-09-30 20:38:18 +00:00
Robert Sparks c34356db94 Modified the rfc feed to better represent dois. Fixes #2014. Commit ready for merge.
- Legacy-Id: 12055
2016-09-28 17:52:39 +00:00
Henrik Levkowetz 7f772641d4 Change the cache key construction to deal with query arguments containing spaces. Fixes 500 errors which would otherwise occur.
- Legacy-Id: 12035
2016-09-25 13:53:22 +00:00
Henrik Levkowetz 8c34e9d78d Merged in ^/branch/proceedings/6.33.1.dev0 from rjsparks@nostrum.com and rcross@amsl.com. This provides new ietf meeting proceedings pages.
- Legacy-Id: 12028
2016-09-23 17:33:43 +00:00
Ole Laursen c586feb579 Fix an old bug in draft resurrection, it was using the long gone
doc.idinternal in an explanation
 - Legacy-Id: 12027
2016-09-23 15:29:27 +00:00
Ole Laursen 99beb58291 Implement a round-robin rotation scheme for reviewers instead of
relying on when they last reviewed. In-order assignments automatically
move the rotation forwards while out-of-order assignments increment
the skip next of the assigned reviewer. Include rotation in open
review assignments email. Fix a couple of issues in the importer.
 - Legacy-Id: 12015
2016-09-21 16:52:50 +00:00
Henrik Levkowetz 5089651e17 Don't use EmptyQuerySet directly; return Class.objects.none() instead.
- Legacy-Id: 12013
2016-09-21 11:23:57 +00:00
Henrik Levkowetz d0c3331f9f Clarified the differences between Document.href() and Document.get_absolute_url(). Updated PLAN.
- Legacy-Id: 12012
2016-09-20 21:05:14 +00:00
Henrik Levkowetz 9e66c16fa7 Made retrieve_search_results() always return a queryset, which lets us use .exists() on the returned value as needed.
- Legacy-Id: 12007
2016-09-20 18:32:20 +00:00
Henrik Levkowetz f8bca9bcf6 Reverted inadvertent commit
- Legacy-Id: 12006
2016-09-20 18:31:16 +00:00
Henrik Levkowetz e917c5a0df Added made group a json object in the json_agenda, and added session.group.type information.
- Legacy-Id: 12005
2016-09-20 18:24:08 +00:00
Ole Laursen 6da25e6bd9 Add personal review overview page for reviewers, add page for editing
reviewer availability settings, emailing the reviewer/secretary as
necessary, add tests for these pages. Fix a bunch of bugs.
 - Legacy-Id: 11998
2016-09-19 16:05:32 +00:00
Robert Sparks 02ee5dc5d7 (somewhat bumpy) merge forward from proceedings/6.31.1.dev0
- Legacy-Id: 11992
2016-09-14 22:09:30 +00:00
Robert Sparks 53f41a6327 Added an order field to SessionPresentation.
Set up removing the order field from Document.
Modified the meeting materials, proceedings, and session details views to use the order field on SessionPresentation.
Added bootstrapped views to upload session materials (agendas, slides, minutes, and bluesheets). 
Integrated upload into the session details view.
Commit ready for merge.
 - Legacy-Id: 11989
2016-09-14 19:11:31 +00:00