Add edit button for Secreatriat on concluded groups. Fixes#2781.
- Legacy-Id: 17042
Note: SVN reference [17031] has been migrated to Git commit da2733610c
Adds Closing note field to state specific WG edit. Fixes#2779.
- Legacy-Id: 17039
Note: SVN reference [17028] has been migrated to Git commit 020d4a393c
Fix issue where draft resurrect feature does not move most recent draft file from the archive directory back to the current draft directory. Fixes#2646.
- Legacy-Id: 17032
Note: SVN reference [17027] has been migrated to Git commit 9882d7fda8
Look at the tree of replaces-relationships when determining if some reviewer has reviewed this (or perhaps an ancestor) of this document. Fixes#2821.
- Legacy-Id: 16992
Note: SVN reference [16981] has been migrated to Git commit f740adcfc1
Use the recently released shepherd writeup templates. Fixes#2820. ,
- Legacy-Id: 16991
Note: SVN reference [16966] has been migrated to Git commit fa00beab0e
Fix#2050 - Allow adding review wishes from document and search pages.
On the main page of a document and in document search results, a new
button allows review team members to add a review wish for that document.
For reviewers that are only on one team, this essentially works
identical to tracking a document. Reviewers that are on multiple teams
are lead through an intermediate step to select a review team, and then
returned to their search or document page.
- Legacy-Id: 16985
Note: SVN reference [16939] has been migrated to Git commit 6e55f26dbd
Convert markdown to html if Accept header prioritizes text/html over text/markdown. Fixes#1926.
- Legacy-Id: 16982
Note: SVN reference [16564] has been migrated to Git commit 65b3f93afe
Disregard unassigned reviews when building the sets to compare when checking for race-conditions on assigning reviews. Partially addresses #2821.
- Legacy-Id: 16980
Note: SVN reference [16977] has been migrated to Git commit 5c08b4096a
Fix#2088 - Sort unassigned review requests by doc name by default.
- Legacy-Id: 16952
Note: SVN reference [16934] has been migrated to Git commit f075eced5c
Fix#2119 - Allow specifying review type for suggested reviews in LC and telechat
If a review is suggested on the 'manage unassigned reviews' page, and
the document is in both last call and telechat, the assign form now asks
for the type of review that should be assigned.
This commit also fixes two bugs in this process:
- Comparisons in some cases between strings and integers
(group/views.py:1485/1487)
- Rejections when assigning suggested reviews, as they could be
considered a newly opened request due to not having a pk
(group/views.py:1508)
- Legacy-Id: 16951
Note: SVN reference [16933] has been migrated to Git commit ee4bc0cb07
Refs #2217 - Small cleanup from changeset [16924]
- Legacy-Id: 16947
Note: SVN reference [16924] has been migrated to Git commit 871a4b653b
Note: SVN reference [16927] has been migrated to Git commit 730e64d253
Flipped a sense to put the grace period on the right side of 'today' when sending review overdue reminders to team secretaries. Fixes#2816.
- Legacy-Id: 16940
Note: SVN reference [16926] has been migrated to Git commit 7560e116bf
On the main page of a document and in document search results, a new
button allows review team members to add a review wish for that document.
For reviewers that are only on one team, this essentially works
identical to tracking a document. Reviewers that are on multiple teams
are lead through an intermediate step to select a review team, and then
returned to their search or document page.
Commit ready for merge.
- Legacy-Id: 16939
Only show a blocked document once in the set of blocked documents on an ADs document page. Fixes#2818.
- Legacy-Id: 16938
Note: SVN reference [16937] has been migrated to Git commit 8f1e9990cf
If a review is suggested on the "manage unassigned reviews" page, and
the document is in both last call and telechat, the assign form now asks
for the type of review that should be assigned.
This commit also fixes two bugs in this process:
- Comparisons in some cases between strings and integers
(group/views.py:1485/1487)
- Rejections when assigning suggested reviews, as they could be
considered a newly opened request due to not having a pk
(group/views.py:1508)
Commit ready for merge.
- Legacy-Id: 16933
Fix#2217 - Allow submission of unsolicited reviews by secretaries.
- For team secretaries, a button 'Submit unsolicited review' will now
appear next to 'Request review' on the document's main page.
- If the secretary is a secretary for multiple teams, they are taken
through an intermediate page to select for which team they are
submitting their review.
- The form is similar (and using the same code) as the usual review
completion, with a few extra fields for the review type and reviewer,
which would usually already be known.
- When submitting the review, a ReviewRequest and ReviewAssignment are
automatically created. The assignment is then immediately closed in
the usual way.
- Other workflows are unchanged.
The issues with the review form in #2061 are slightly worse for the
unsolicited review scenario, but that will be improved when #2061 is
fixed.
- Legacy-Id: 16932
Note: SVN reference [16924] has been migrated to Git commit 871a4b653b
Fix#2087 - Show doc authors and WG chairs in unassigned reviews views.
- Legacy-Id: 16931
Note: SVN reference [16923] has been migrated to Git commit 93797b3fc1
Fix#2584 - Add additional content validation for uploaded texts.
Permitted MIME types are now text/plain, text/markdown and text/x-rst.
This applies to all usages of get_cleaned_text_file_content(),
including reviews, but also other similar places where text can either
be written either into a textarea or uploaded.
- Legacy-Id: 16930
Note: SVN reference [16922] has been migrated to Git commit fd53f98854
Fix#2123 - Use a DBTemplate when a review assignment is mailed.
The message sent to a reviewer when a new review is assigned to them,
is now taken from a DBTemplate, allowing it to be customised
per team. This includes a migration to create a default template,
which looks the same as before.
- Legacy-Id: 16928
Note: SVN reference [16921] has been migrated to Git commit 9df5839874
