altf4arnold/datatracker
1
0
Fork 0
Code Issues Pull requests Actions 3 Packages Projects Releases Wiki Activity
13632 commits 1 branch 0 tags 2.6 GiB
Commit graph

295 commits

Author SHA1 Message Date
Jennifer Richards 6df0377fa1 Fix several review reminder problems. 
Send secretary's review reminders to secretary instead of assignee. 
Send unconfirmed assignment reminders based on assignment age and CC secretaries. 
Correctly separate open review reminders by review team.

Fixes #3482. Fixes #3324. Commit ready for merge.
 - Legacy-Id: 19848
 2022-01-14 19:14:06 +00:00
Robert Sparks 5c28a85cf1 Merged in [19555] from jennifer@painless-security.com: 
Use temporary directories instead of 'real' filesystem for tests. Fixes #3414.
 - Legacy-Id: 19561
Note: SVN reference [19555] has been migrated to Git commit 81d9234d54
 2021-11-08 18:16:56 +00:00
Jennifer Richards 81d9234d54 Use temporary directories instead of "real" filesystem for tests. Fixes #3414. Commit ready for merge. 
- Legacy-Id: 19555
 2021-11-05 19:45:57 +00:00
Robert Sparks cd748cd760 Update internal references to trac.tools.ietf.org to point to trac.ietf.org. Remove several links into tools.ietf.org. Commit ready for merge. 
- Legacy-Id: 19422
 2021-10-13 21:43:44 +00:00
Robert Sparks b99eecc1ae Bring the factory-boy and Faker dependencies forward through some minor breaking changes. Stop using the deprecated fr_QC locale in Faker. Commit ready for merge. 
- Legacy-Id: 19270
 2021-08-03 22:22:35 +00:00
Jennifer Richards 92c9f856a4 Refactor reviewer queue policy handling of "skip" setting. Fixes #3038. Commit ready for merge. 
- Legacy-Id: 18833
 2021-02-16 19:31:50 +00:00
Robert Sparks d8a24a8e2a Corrected a typo in a test. 
- Legacy-Id: 18767
 2020-12-15 20:34:47 +00:00
Robert Sparks e059ec3d70 Merged in [18743] from rjsparks@nostrum.com: 
Cleaning some pyflakes that made it into the last commit.
 - Legacy-Id: 18760
Note: SVN reference [18743] has been migrated to Git commit 3697a9e9a4
 2020-12-11 21:57:14 +00:00
Robert Sparks 17ab884b19 Merged in [18736] from rjsparks@nostrum.com: 
Fixup document that had no type. Remove dangling review document. Fixes #3145.
 - Legacy-Id: 18759
Note: SVN reference [18736] has been migrated to Git commit 708ab108e6
 2020-12-11 21:53:14 +00:00
Robert Sparks 3697a9e9a4 Cleaning some pyflakes that made it into the last commit. Commit ready for merge. 
- Legacy-Id: 18743
 2020-12-08 15:50:43 +00:00
Robert Sparks 708ab108e6 Fixup document that had no type. Remove dangling review document. Fixes #3145. Commit ready for merge. 
- Legacy-Id: 18736
 2020-12-07 19:36:47 +00:00
Henrik Levkowetz 8ebef27026 Related to issue #2186: The issue asked for changing review requests from state 'assigned' back to state 'requested' if the last associated assignment is withdrawn. However, the code to implement this makes the change for all assignment states, and also when there has been no state change. Changed to be more discerning. 
- Legacy-Id: 18722
 2020-12-01 15:36:04 +00:00
Robert Sparks 863582e56a Completed repair migration for disconnected and confused reviews. Branch ready for merge. 
- Legacy-Id: 18522
 2020-09-25 16:08:09 +00:00
Robert Sparks a2a0fdfae8 Early migration, mostly comments, committed to facilitate conversation. 
- Legacy-Id: 18515
 2020-09-23 15:28:33 +00:00
Henrik Levkowetz a1b1a919ab Merged in [18373] from mark@painless-security.com: 
Filter out reviewers who have rejected reviewing this document in the past from the list of suggested reviewers.  Fixes #2996.
 - Legacy-Id: 18448
Note: SVN reference [18373] has been migrated to Git commit d105f8ba5b
 2020-08-31 11:21:07 +00:00
Mark J. Donnelly d105f8ba5b Filter out reviewers who have rejected reviewing this document in the past from the list of suggested reviewers. Fixes #2996. Commit ready for merge. 
- Legacy-Id: 18373
 2020-08-13 15:03:54 +00:00
Henrik Levkowetz 8fcfd2073a Added a migration where Django 2.0 captures more model information than 1.11 did. 
- Legacy-Id: 17845
 2020-05-20 07:31:35 +00:00
Henrik Levkowetz bc05e7a8d0 Refactored many instances of msg.get_payload(decode=True).decode('utf-8') and similar to get_payload_text(msg), which uses msg.get_charset() to get the actual charset to do the decoding, in a consistent manner. Also removed some instances of force_str, but more remain. 
- Legacy-Id: 17807
 2020-05-16 20:20:05 +00:00
Henrik Levkowetz 2b68095b82 Merged in [17794] from mark@painless-security.com: 
Add the 'msg' variable for interpolation on reviewer availability change emails, and reformat the add-a-period email.  Fixes #2891.
 - Legacy-Id: 17799
Note: SVN reference [17794] has been migrated to Git commit 96bc71f51f150cec7043aca60d0156d35847019b
 2020-05-15 11:33:03 +00:00
Henrik Levkowetz 9aeda11a29 Removed some Py2 compatibility decorators. 
- Legacy-Id: 17673
 2020-04-21 13:54:31 +00:00
Henrik Levkowetz 02e0ccf441 Removed a renamed migration 
- Legacy-Id: 17620
 2020-04-14 19:29:09 +00:00
Henrik Levkowetz f10ddadc0e Merged in changes from trunk up to r17584. 
- Legacy-Id: 17593
 2020-04-07 16:02:52 +00:00
Henrik Levkowetz 87bf4e8d58 Make sure to strip possible mail header field values of whitespace before applying email.utils.unquite(). Resolution by kivinen@iki.fi, Fixes issue #2899. 
- Legacy-Id: 17485
 2020-03-21 17:34:37 +00:00
Henrik Levkowetz 89ec88dd7d - Legacy-Id: 17401 2020-03-07 12:46:53 +00:00
Henrik Levkowetz a69ffdc87a Added a migration 
- Legacy-Id: 17399
 2020-03-06 21:01:13 +00:00
Henrik Levkowetz 726fcbf27d Removed all __future__ imports. 
- Legacy-Id: 17391
 2020-03-05 23:53:42 +00:00
Henrik Levkowetz ab173cb2eb Removed further six usage: six.string_types, six.integer_types, six.moves.urllib instances. 
- Legacy-Id: 17390
 2020-03-05 20:46:58 +00:00
Henrik Levkowetz e9a37d8ac8 Removed six.text_type(), changed six.moves.urllib to plain urllib, and removed now unused six imports. 
- Legacy-Id: 17385
 2020-03-05 14:41:41 +00:00
Henrik Levkowetz af6ca37513 Admin model tweak, added a raw_id_field. 
- Legacy-Id: 17382
 2020-03-03 21:00:35 +00:00
Henrik Levkowetz 941a27bf72 Fixed a Py2/3 issue with review.mailarchive.construct_query_url(). 
- Legacy-Id: 17379
 2020-03-03 17:00:13 +00:00
Henrik Levkowetz 1017c21167 Renamed a migration to conform to migration naming conventions, using underscores instead of dashes in the name. 
- Legacy-Id: 17376
 2020-03-03 12:22:48 +00:00
Henrik Levkowetz 0487cfce3e Changed ReviewerSettings history change-reason field to TextField 
- Legacy-Id: 17184
 2020-01-06 18:50:36 +00:00
Henrik Levkowetz 49fc0d7a71 Change varchar(100) to text field for HistoricalReviewerSettings.history_change_reason, to accomodate longer change descriptions. 
- Legacy-Id: 17171
 2019-12-21 19:56:16 +00:00
Henrik Levkowetz d9c19449ce Fixed a migration overlap issue. 
- Legacy-Id: 17123
 2019-12-05 18:04:37 +00:00
Henrik Levkowetz fcb6806d17 Merged in work from sasha@dashcare.nl on Review Queue Managemnt: 
This abstracts queue management, making it possible to implement different
policies for each team. It provides two concrete policies:
RotateAlphabeticallyReviewerQueuePolicy, which rotates an alphabetically
ordered reviewer list with consideration for skip indications, and is the
default policy; and LeastRecentlyUsedReviewerQueuePolicy, a simple
least-recently-used policy.  Also see issues #2721 and #2656.
 - Legacy-Id: 17121
 2019-12-04 23:02:52 +00:00
Henrik Levkowetz fc0060079a Merged in [17085] from sasha@dashcare.nl: 
Fix #2278 - Notify secretary when a review request is closed.
The assigned reviewer was already notified, but secretaries were always
excluded.
 - Legacy-Id: 17108
Note: SVN reference [17085] has been migrated to Git commit 56003f66d8
 2019-11-27 22:19:58 +00:00
Henrik Levkowetz 7ec09554bb Merged in [17069] from sasha@dashcare.nl: 
Fix #2074, fix #2358 - Add history for assignments, requests and unavailability.
 - Legacy-Id: 17104
Note: SVN reference [17069] has been migrated to Git commit 65d84155b6
 2019-11-26 16:09:43 +00:00
Sasha Romijn 9e2dfbfe7f Fix review migration issue caused by merge 
- Legacy-Id: 17095
 2019-11-22 12:40:03 +00:00
Sasha Romijn 10a7bee637 Merge reviewer-queue-management on top of 6.111.1.dev0 
- Legacy-Id: 17094
 2019-11-22 12:35:28 +00:00
Sasha Romijn b64066b742 Fix LeastRecentlyUsed policy ordering. 
- Legacy-Id: 17092
 2019-11-22 11:00:58 +00:00
Sasha Romijn 384c0ac7af Improve LeastRecentlyUsed performance with select_related() fix 
- Legacy-Id: 17091
 2019-11-22 10:05:51 +00:00
Sasha Romijn 6bf7d15b70 Add a limit to the update_policy_state_for_assignment loop to prevent 
infinite loops, e.g. when a team has only a single reviewer.
 - Legacy-Id: 17087
 2019-11-21 12:37:02 +00:00
Sasha Romijn 084978e105 Fix issue where reviewers that left the team would be included in LeastRecentlyUsed 
- Legacy-Id: 17086
 2019-11-21 11:24:33 +00:00
Sasha Romijn 56003f66d8 Fix #2278 - Notify secretary when a review request is closed. 
The assigned reviewer was already notified, but secretaries were always
excluded.

Commit ready for merge.
 - Legacy-Id: 17085
 2019-11-21 11:03:21 +00:00
Henrik Levkowetz 424dcfb42d Some tweaks related to the changes related to #2830. 
- Legacy-Id: 17076
 2019-11-21 06:01:56 +00:00
Henrik Levkowetz f0adebbe70 Merged in [17062] from rjsparks@nostrum.com: 
Change the default template for assigned review emails to name the assigned reviewer. Fixes #2830.
 - Legacy-Id: 17073
Note: SVN reference [17062] has been migrated to Git commit 38e73b6f89
 2019-11-21 01:32:10 +00:00
Sasha Romijn 65d84155b6 Fix #2074, fix #2358 - Add history for assignments, requests and unavailability. 
Commit ready for merge.
 - Legacy-Id: 17069
 2019-11-20 11:29:14 +00:00
Robert Sparks 38e73b6f89 Change the default template for assigned review emails to name the assigned reviewer. Fixes #2830. Commit ready for merge. 
- Legacy-Id: 17062
 2019-11-19 21:27:23 +00:00
Sasha Romijn 3db8a0f39d Fix issue where queue might not advance correctly while managing 
unassigned reviews, when some reviewers have a skip count.
 - Legacy-Id: 17060
 2019-11-19 11:53:12 +00:00
Sasha Romijn b1eb2643f0 Cleanup. Branch ready for merge. (see email) 
- Legacy-Id: 17059
 2019-11-19 11:14:29 +00:00