Commit graph

876 commits

Author SHA1 Message Date
Robert Sparks 311b4728e1 Restore ADs ability to charter new groups. Fixes #3397. Commit ready for merge,
- Legacy-Id: 19315
2021-09-02 23:25:36 +00:00
Robert Sparks aeff343eee Show new group types on active groups page, but see #3393. Commit ready for merge.
- Legacy-Id: 19313
2021-09-01 15:54:25 +00:00
Robert Sparks 4240ce088e Adjust tests to match changes to permissions made in through the admin. These need to use the data rather than the code. See #3393. Commit ready for merge.
- Legacy-Id: 19311
2021-09-01 14:30:09 +00:00
Robert Sparks 847f37dbf7 Add IETF Administrative LLC groups. Fixes #3302. Commit ready for merge.
- Legacy-Id: 19310
2021-08-31 22:13:38 +00:00
Robert Sparks d42730300a Add IAB Administrative Support Group group type. Add IAB groups to the group menu. Clearly delineate group types in the group menu. Fixes #3295 and #3296. Commit ready for merge.
- Legacy-Id: 19307
2021-08-30 19:39:21 +00:00
Jennifer Richards 2060173f3a Improve proceedings display with new title block, configurable host logos, and additional PDF or URL materials. Fixes #3147. Commit ready for merge.
- Legacy-Id: 19306
2021-08-30 17:02:49 +00:00
Robert Sparks 62a3a4fe41 Restrict group creation to the secretariat. Commit ready to merge.
- Legacy-Id: 19277
2021-08-05 14:56:28 +00:00
Robert Sparks f3b72e4bc1 Improve tests that look person names in responses. Commit ready for merge.
- Legacy-Id: 19271
2021-08-04 14:46:11 +00:00
Robert Sparks b99eecc1ae Bring the factory-boy and Faker dependencies forward through some minor breaking changes. Stop using the deprecated fr_QC locale in Faker. Commit ready for merge.
- Legacy-Id: 19270
2021-08-03 22:22:35 +00:00
Robert Sparks a29480703f Changed implementation of can_manage_all_groups_of_type to use GroupFeatures.groupman_authroles. Commit ready for merge.
- Legacy-Id: 19259
2021-07-22 19:29:50 +00:00
Robert Sparks 359889c1f7 Changed the signature of can_manage_all_groups_of_type to only take a type_id. Removed the logic that tried to distinguish permissions for teams by parent - that should be modeled as separate type_ids instead. Commit ready for merge.
- Legacy-Id: 19258
2021-07-22 18:34:57 +00:00
Robert Sparks 7ede0942d0 Rename ietf.group.utils.can_manage_group_type to can_manage_all_groups_of_type to improve code readability where it is used. Commit ready for merge.
- Legacy-Id: 19256
2021-07-22 18:05:06 +00:00
Robert Sparks c01fea3920 Show groupman_authroles in the GroupFeatures admin list. Commit ready for merge.
- Legacy-Id: 19254
2021-07-21 20:10:30 +00:00
Robert Sparks 84717102b0 Add BOF Requests to the datatracker. Commit ready for merge.
- Legacy-Id: 19228
2021-07-15 20:15:54 +00:00
Robert Sparks 62c364899c Guard a sort that gets a mix of integers and None. Commit ready for merge.
- Legacy-Id: 19224
2021-07-15 16:28:15 +00:00
Robert Sparks 805d1f4a7e Use BOF consistently.
- Legacy-Id: 19212
2021-07-14 17:33:14 +00:00
Robert Sparks f5a04263e5 Added the notion of responsible leadership.
- Legacy-Id: 19202
2021-07-07 17:49:35 +00:00
Robert Sparks d61e26567d Scroll to buttons before clicking on them in Selenium tests. Fixes #3314. Commit ready for merge.
- Legacy-Id: 19153
2021-06-24 16:39:36 +00:00
Robert Sparks a32d00af0a When removing reviewers from a review team, change the state of only that team's assignments. Check to make sure the person being removed doesn't have another reviewer Role (with a different Email) in the same team. Change the disposition of any assignments from that team for the removed reviewer to 'withdrawn' rather than 'rejected'. Fixes #3320. Commit ready for merge.
- Legacy-Id: 19151
2021-06-24 15:44:55 +00:00
Robert Sparks 44566f80cb reorder migrations
- Legacy-Id: 19086
2021-06-04 23:08:49 +00:00
Robert Sparks b7c3d03cba Merged in [19083] from jennifer@painless-security.com:
Fix renamed field in group migrations 0043 and 0044. Fixes error in 19075.
 - Legacy-Id: 19085
Note: SVN reference [19083] has been migrated to Git commit f5a1730257
2021-06-04 23:02:42 +00:00
Jennifer Richards f5a1730257 Fix renamed field in group migrations 0043 and 0044. Fixes error in 19075. Commit ready for merge.
- Legacy-Id: 19083
2021-06-04 21:58:53 +00:00
Robert Sparks 5bb08bc103 Merged in [19075] from jennifer@painless-security.com:
Clean up handling of non-WG groups on the group edit page; restrict parent/child group relationships by type. Fixes #3253.
 - Legacy-Id: 19079
Note: SVN reference [19075] has been migrated to Git commit 2a2e5f0c24
2021-06-04 19:59:29 +00:00
Jennifer Richards 2a2e5f0c24 Clean up handling of non-WG groups on the group edit page; restrict parent/child group relationships by type. Fixes #3253. Commit ready for merge.
- Legacy-Id: 19075
2021-06-04 17:31:53 +00:00
Robert Sparks b8b3047d99 Merged in [19022] from housley@vigilsec.com:
Add test for creation of RG Chairs in the irtg.org domain.
 - Legacy-Id: 19023
Note: SVN reference [19022] has been migrated to Git commit c42935363a
2021-05-20 22:02:02 +00:00
Russ Housley c42935363a Add test for creation of RG Chairs in the irtg.org domain. Commit ready for merge.
- Legacy-Id: 19022
2021-05-20 20:15:49 +00:00
Robert Sparks ed68a97685 Merged in [18993] from housley@vigilsec.com:
Add aliases for RGs in irtf.org and IAB programs in iab.org. Fixes #3271
 - Legacy-Id: 19021
Note: SVN reference [18993] has been migrated to Git commit 886b99c273
2021-05-20 20:14:49 +00:00
Russ Housley 886b99c273 Add aliases for RGs in irtf.org and IAB programs in iab.org. Fixes #3271
- Legacy-Id: 18993
2021-05-13 20:34:11 +00:00
Robert Sparks 216ec499df Checkpointing. Remaining work: convert meetingregistation fixup to a migration and a mgmt comment. Flesh out testing of 8989 rule 2 and fix the known edge case bug. Remove old implementation and connect UI to the new implementation.
- Legacy-Id: 18971
2021-05-01 19:57:04 +00:00
Robert Sparks 6d7a0b6d0f Merged in [18939] from jennifer@painless-security.com:
Consolidate repeated searchable field code into SearchableField class. Fix single-valued searchable fields. Make javascript test config reusable. Use Django Form.media for JS/CSS inclusion. Fixes #3196, #3204.
 - Legacy-Id: 18948
Note: SVN reference [18939] has been migrated to Git commit 17d37723f7
2021-04-12 22:07:03 +00:00
Robert Sparks 404d115934 Merged in [18936] from rjsparks@nostrum.com:
Retain strict acronym validation, specifically disallowing hyphens, for new groups of types that create documents, while allowing existing groups and new non-document-creating groups to validate when they contain hyphens. Fixes #3236. Commit
 - Legacy-Id: 18945
Note: SVN reference [18936] has been migrated to Git commit 04f5b4ae4dcbbf8a39281f0b79b1a6271439fd1a
2021-04-12 17:08:58 +00:00
Jennifer Richards 17d37723f7 Consolidate repeated searchable field code into SearchableField class. Fix single-valued searchable fields. Make javascript test config reusable. Use Django Form.media for JS/CSS inclusion. Fixes #3196, #3204. Commit ready for merge.
- Legacy-Id: 18939
2021-04-09 15:18:11 +00:00
Russ Housley 45b14c83a7 Convert generate-draft-aliaes and generate-wg-aliases into management commands: generate_draft_aliases and generate_group_aliases. Also provide tests for the new management commands.
- Legacy-Id: 18913
2021-03-13 17:30:35 +00:00
Jennifer Richards e11583a87f Allow assignment of Person as "action holder" for a Doc, plus rudimentary automation of assignment. Fixes #3146. Commit ready for merge.
- Legacy-Id: 18829
2021-02-12 20:31:00 +00:00
Jennifer Richards df37793e14 Use Roles instead of dedicated model for liaison statement group contacts. Fixes #3100. Commit ready for merge.
- Legacy-Id: 18828
2021-02-12 16:39:20 +00:00
Robert Sparks 9a9f3fa360 Merged in [18798] from jennifer@painless-security.com:
Improve handling of submissions for closed working groups. Fixes #3058.
 - Legacy-Id: 18807
Note: SVN reference [18798] has been migrated to Git commit 233bff8196
2021-01-27 23:19:42 +00:00
Jennifer Richards 233bff8196 Improve handling of submissions for closed working groups. Fixes #3058. Commit ready for merge.
- Legacy-Id: 18798
2021-01-18 14:55:25 +00:00
Robert Sparks 03e5121f72 Remove HistoricalGroupFeatures. Fixes #3152. Commit ready for merge.
- Legacy-Id: 18782
2020-12-18 18:57:26 +00:00
Robert Sparks 643749316b Allow program leads to request meetings. Fixes #3141. Commit ready for merge.
- Legacy-Id: 18718
2020-11-23 20:36:47 +00:00
Henrik Levkowetz 088033d843 Added matching indexes to a number of models with ordering by multiple keys.
- Legacy-Id: 18664
2020-11-09 19:41:12 +00:00
Henrik Levkowetz 552c0c9d70 Added a GroupHistory.ad_role() method.
- Legacy-Id: 18647
2020-10-27 11:39:55 +00:00
Henrik Levkowetz a2758d5feb Fixed a test case bug that compared a py3 string with bytes.
- Legacy-Id: 18544
2020-10-02 12:22:40 +00:00
Robert Sparks cf2a198d5f Create a yangcatalog support group and populate its initial roles. Commit ready for merge.
- Legacy-Id: 18502
2020-09-17 20:57:06 +00:00
Robert Sparks 2b70735fd2 Improved the classification of some github related external resources. Tightened validation of new resource values. Commit ready to merge.
- Legacy-Id: 18378
2020-08-17 23:50:22 +00:00
Henrik Levkowetz 57938b039d Converted many cases of plain-text 403 messages to use a properly styled page instead, with a login link when appropriate. Also changed some API endpoint 400 responses to a more correct 403.
- Legacy-Id: 18339
2020-08-06 10:59:52 +00:00
Henrik Levkowetz e4bc508abc Merged in [18298] from rjsparks@nostrum.com:
Convert IRTF area groups into their own group type rather than attempting to overload AG. Fixes #3027.
 - Legacy-Id: 18320
Note: SVN reference [18298] has been migrated to Git commit 2b10465aa7
2020-07-30 14:27:17 +00:00
Henrik Levkowetz 0ac92d3ae4 Merged in [18299] from rjsparks@nostrum.com:
Missing migrations from 18298.
 - Legacy-Id: 18309
Note: SVN reference [18299] has been migrated to Git commit e7e1cc2a8e
2020-07-29 14:37:51 +00:00
Robert Sparks e7e1cc2a8e Missing migrations from 18298. Commit ready for merge.
- Legacy-Id: 18299
2020-07-28 18:55:43 +00:00
Robert Sparks 2b10465aa7 Convert IRTF area groups into their own group type rather than attempting to overload AG. Fixes #3027. Commit ready for merge.
- Legacy-Id: 18298
2020-07-28 18:54:44 +00:00
Jim Fenton 1cacc6715b Adds programs to concluded groups page. Fixes #3023. Commit ready for merge.
- Legacy-Id: 18275
2020-07-25 19:02:26 +00:00
Jim Fenton 65c7080b1f Interim change to prevent chairs from editing milestone description. Fixes #3036. Commit ready for merge.
- Legacy-Id: 18272
2020-07-25 18:01:31 +00:00
Henrik Levkowetz 068493d8bd Merged in [18205] from rjsparks@nostrum.com:
Add rudimentary validation to the admin group form acronym field. Partially addresses #3026.
 - Legacy-Id: 18215
Note: SVN reference [18205] has been migrated to Git commit 82928b8033
2020-07-21 20:06:56 +00:00
Robert Sparks 82928b8033 Add rudimentary validation to the admin group form acronym field. Partially addresses #3026. Commit ready for merge.
- Legacy-Id: 18205
2020-07-20 20:00:05 +00:00
Henrik Levkowetz 606cedd796 Merged in the ExtResource work from rjsparks@nostrum.com, based on a feature request and contributions from rsalz@akamai.com. This provides external resource models for Person, Group, and Document models, as a generalisation of the previous related-URL concept. This provides a consistent labelling and classification of URLs and other resources related to a Group, Document, or Person. The GroupURL (and similar) classes will be removed in a later step. Some DocumentURL instances (such as auth48 URLs) remain to convert, as they have come in with other merged-in work while the ExtResource work was in transit.
- Legacy-Id: 18192
2020-07-20 01:58:26 +00:00
Robert Sparks 6227162e53 Updated mgmt command to find github repos to back up. Improved test coverage of branch changes. Branch ready for merge.
- Legacy-Id: 18163
2020-07-13 17:36:34 +00:00
Robert Sparks 99df95d542 Cleaned up created names. Improved validation during migration. Cleaned up migration output. Cleaned the last of the awp includes from secr views. Removed now unused secr templates. Build extresource urls correctly during submission and when creating group wikis.
- Legacy-Id: 18158
2020-07-13 16:03:39 +00:00
Robert Sparks 53f7bc3ce6 migrated forward
- Legacy-Id: 18144
2020-07-09 21:07:05 +00:00
Robert Sparks 066ee27505 preparing to merge forward
- Legacy-Id: 18143
2020-07-09 20:29:45 +00:00
Robert Sparks c6f55a3306 Fixed some test scaffolding that used non-existent keys (uncovered by recent improvements in sqlite3 integrity checking). Commit ready for merge.
- Legacy-Id: 18130
2020-07-02 20:05:02 +00:00
Henrik Levkowetz 12fc334279 Renamed and adjusted a migration to avoid multiple migration leaf nodes.
- Legacy-Id: 18101
2020-06-29 17:02:42 +00:00
Henrik Levkowetz 6170ebd64a Merged in the final part of the automatic scheduler from sasha@dashcare.nl.
- Legacy-Id: 18100
2020-06-29 16:54:51 +00:00
Henrik Levkowetz 8892a6b725 Removed unused imports.
- Legacy-Id: 18089
2020-06-27 17:40:28 +00:00
Henrik Levkowetz cb9006eb26 Changed skip messages from test suites to use print() instead of sys.stderr.write(), to match other output from the test runner.
- Legacy-Id: 18087
2020-06-27 17:32:02 +00:00
Henrik Levkowetz bbb5b9ce3f Merged in [18064] from rjsparks@nostrum.com:
Change group edit field url regexp to accept the field names (specifically role names) we use by allowing hyphens.
 - Legacy-Id: 18072
Note: SVN reference [18064] has been migrated to Git commit db0f902145
2020-06-27 11:55:12 +00:00
Robert Sparks db0f902145 Change group edit field url regexp to accept the field names (specifically role names) we use by allowing hyphens. Commit ready to merge.
- Legacy-Id: 18064
2020-06-25 20:41:49 +00:00
Robert Sparks bf53bf1057 Merged forward. Added some missing parts to the XMPPURLValidator.
- Legacy-Id: 18050
2020-06-24 19:01:45 +00:00
Sasha Romijn 9dd0035a19 Fix migrations after rebase.
- Legacy-Id: 17994
2020-06-15 20:51:46 +00:00
Robert Sparks c69556efe1 Improve admin form validation for used_roles. Commit ready for merge.
- Legacy-Id: 17992
2020-06-15 19:14:42 +00:00
Sasha Romijn 6e026926f0 Rebase automatic-scheduler-2 onto 7.3.2.dev0
- Legacy-Id: 17990
2020-06-15 12:29:39 +00:00
Henrik Levkowetz 567449d3d2 Merged in [17908] from rjsparks@nostrum.com:
Add used_roles to Group and default_used_roles to GroupFeatures. Dynamically build the group edit form to provide a field for all used_roles. Fixes #2785 and #2572. Partially addresses #2160.
 - Legacy-Id: 17960
Note: SVN reference [17908] has been migrated to Git commit 2862727d02
2020-06-10 12:58:29 +00:00
Henrik Levkowetz 542c165907 Added a migration to create login and person records for the mail-archive and registration-system users.
- Legacy-Id: 17934
2020-06-08 19:19:25 +00:00
Robert Sparks 2862727d02 Add used_roles to Group and default_used_roles to GroupFeatures. Dynamically build the group edit form to provide a field for all used_roles. Fixes #2785 and #2572. Partially addresses #2160. Commit ready for merge.
- Legacy-Id: 17908
2020-06-04 21:05:33 +00:00
Sasha Romijn 57d8ffb27a Re-introduce Group.meeting_seen_as_area and use it in automatic scheduler
- Legacy-Id: 17901
2020-06-01 09:25:51 +00:00
Henrik Levkowetz 65c6a878f7 Merged in [17843] from housley@vigilsec.com:
Create slowpages cache for some very stable pages
 - Legacy-Id: 17874
Note: SVN reference [17843] has been migrated to Git commit f7886df212
2020-05-21 22:03:38 +00:00
Robert Sparks 8a0578040e Added better self-descriptive __str__ functions to PersonExtResource, GroupExtResource, and DocExtResource
- Legacy-Id: 17871
2020-05-21 20:59:44 +00:00
Robert Sparks 02e1226a03 Added appropriate Admin classes
- Legacy-Id: 17870
2020-05-21 20:48:03 +00:00
Robert Sparks 38ba0f401d merged forward
- Legacy-Id: 17868
2020-05-21 18:30:48 +00:00
Robert Sparks 785f6243f1 explicit resource names for classes with the word resource in their name
- Legacy-Id: 17857
2020-05-20 18:28:05 +00:00
Russ Housley f7886df212 Create slowpages cache for some very stable pages
- Legacy-Id: 17843
2020-05-19 21:29:25 +00:00
Robert Sparks 7e57be2bd3 merged forward ^/personal/rjs/explore-extref
- Legacy-Id: 17840
2020-05-19 18:47:47 +00:00
Henrik Levkowetz 0a885bfbb7 Fixed a test that incorrectly lookdef or author.name instead of author.plain_name()
- Legacy-Id: 17827
2020-05-19 09:13:00 +00:00
Henrik Levkowetz 488ff08352 Merged in ^/personal/henrik/6.129.2-django2.0 which contains an upgrade of Django from 1.11 to 2.0, with the code changes needed.
- Legacy-Id: 17817
2020-05-18 06:50:50 +00:00
Henrik Levkowetz bc05e7a8d0 Refactored many instances of msg.get_payload(decode=True).decode('utf-8') and similar to get_payload_text(msg), which uses msg.get_charset() to get the actual charset to do the decoding, in a consistent manner. Also removed some instances of force_str, but more remain.
- Legacy-Id: 17807
2020-05-16 20:20:05 +00:00
Henrik Levkowetz 6bb0a33a8d Fleshed out a review test slightly, and did some refactoring.
- Legacy-Id: 17801
2020-05-15 14:51:25 +00:00
Henrik Levkowetz 2b68095b82 Merged in [17794] from mark@painless-security.com:
Add the 'msg' variable for interpolation on reviewer availability change emails, and reformat the add-a-period email.  Fixes #2891.
 - Legacy-Id: 17799
Note: SVN reference [17794] has been migrated to Git commit 96bc71f51f150cec7043aca60d0156d35847019b
2020-05-15 11:33:03 +00:00
Henrik Levkowetz 154876a12a Merged in ^/trunk@17782 (just ahead of release 6.130.0)
- Legacy-Id: 17783
2020-05-12 15:54:46 +00:00
Robert Sparks fb8e5c6842 Allow IAB programs to use normal meeting mechanics. Fixes #2970. Commit ready for merge.
- Legacy-Id: 17764
2020-05-08 21:11:25 +00:00
Henrik Levkowetz 6d7c5b52ee Django 2.0 conversion. Test suite passes, except for javascript tests.
- Legacy-Id: 17762
2020-05-08 13:07:07 +00:00
Robert Sparks 7587d564d4 Added GroupExtResources to the group about page, and added the ability to edit them.
- Legacy-Id: 17685
2020-04-24 21:47:24 +00:00
Robert Sparks 2de9eb93b5 Added validation to the migrations. Added external resources to the draft display page. Built an editor for DocExternalResources.
- Legacy-Id: 17683
2020-04-24 16:14:43 +00:00
Henrik Levkowetz 9aeda11a29 Removed some Py2 compatibility decorators.
- Legacy-Id: 17673
2020-04-21 13:54:31 +00:00
Robert Sparks fec811de36 Show recent meetings on a group's meeting tab even if there aren't other past meetings. Fixes #2961. Commit ready for merge.
- Legacy-Id: 17663
2020-04-20 17:31:28 +00:00
Robert Sparks 672f9bce26 Added display-name. Refined migrations.
- Legacy-Id: 17646
2020-04-15 19:54:29 +00:00
Henrik Levkowetz f10ddadc0e Merged in changes from trunk up to r17584.
- Legacy-Id: 17593
2020-04-07 16:02:52 +00:00
Henrik Levkowetz 7084e6e662 Merged in [17557] from fenton@bluepopcorn.net:
Provide more consistent links to people pages. Fixes #2918.
 - Legacy-Id: 17561
Note: SVN reference [17557] has been migrated to Git commit b9c5152714
2020-03-30 20:07:25 +00:00
Jim Fenton b9c5152714 Provide more consistent links to people pages. Fixes #2918. Commit ready for merge.
- Legacy-Id: 17557
2020-03-28 19:07:40 +00:00
Robert Sparks c055d37dcb Removed extref app. Refined population migrations.
- Legacy-Id: 17509
2020-03-22 19:27:28 +00:00
Henrik Levkowetz 19fcb37b31 Merged in [17483] from peter@akayla.com:
Changed so that only WGs/RGs can be closed, per RJS.  Fixes #1578.
 - Legacy-Id: 17503
Note: SVN reference [17483] has been migrated to Git commit 4737f0588e
2020-03-22 13:01:30 +00:00
Peter E. Yee 4737f0588e Changed so that only WGs/RGs can be closed, per RJS. Fixes #1578. Commit ready for merge.
- Legacy-Id: 17483
2020-03-21 17:17:25 +00:00
Robert Sparks 316dd183d9 first run at external resources
- Legacy-Id: 17470
2020-03-19 23:32:24 +00:00
Robert Sparks 79bb245f8a Move charters for replaced groups to a new replaced state. Close any outstanding ballots on them. Fixes #2889, #2873, and #1286. Commit ready for merge.
- Legacy-Id: 17396
2020-03-06 16:47:59 +00:00
Henrik Levkowetz 726fcbf27d Removed all __future__ imports.
- Legacy-Id: 17391
2020-03-05 23:53:42 +00:00
Henrik Levkowetz 1c808bf63b Removed further six usage.
- Legacy-Id: 17387
2020-03-05 15:54:32 +00:00
Henrik Levkowetz 566971a6ae Removed further six usage.
- Legacy-Id: 17386
2020-03-05 15:10:33 +00:00
Henrik Levkowetz e9a37d8ac8 Removed six.text_type(), changed six.moves.urllib to plain urllib, and removed now unused six imports.
- Legacy-Id: 17385
2020-03-05 14:41:41 +00:00
Robert Sparks afb818c298 Allow review team secretaries and the secretariat to reset the next reviewer in queue for review teams using the RotateAlphabetically policy. Partially addresses #2879. Commit ready for merge.
- Legacy-Id: 17325
2020-02-21 23:08:20 +00:00
Robert Sparks 3568e72ec5 Default use_milestone_dates to True. Allow changing use_milestone_dates from the edit milestone dates form for charters if it is the initial chartering effort. Fixes #2884. Commit ready for merge.
- Legacy-Id: 17287
2020-02-11 18:53:40 +00:00
Robert Sparks 7c3a4ce3f5 Only show groups in reasonable states when showing current chartering efforts (otherwise crufty charter states can would lead to abandoned or replaced groups showing here). Fixes #2872. Commit ready for merge.
- Legacy-Id: 17246
2020-01-17 20:14:22 +00:00
Robert Sparks b4ac9f83f1 Restrict the ability to change whether a group uses milestone dates to the ADs and the secretariat. Fixes #2869. Commit ready for merge.
- Legacy-Id: 17234
2020-01-16 21:19:29 +00:00
Robert Sparks f0f522322a Be clear about who changed a group's personnel in the resulting email message. Fixes #2868. Commit ready for merge.
- Legacy-Id: 17233
2020-01-15 21:38:44 +00:00
Henrik Levkowetz e99f1cdc86 Merged in [17185] from rjsparks@nostrum.com:
Adds support for dateless milestones. Fixes #2799.
 - Legacy-Id: 17198
Note: SVN reference [17185] has been migrated to Git commit 42e5163b09
2020-01-08 16:07:29 +00:00
Robert Sparks 42e5163b09 Adds support for dateless milestones. Fixes #2799. Commit ready for merge.
- Legacy-Id: 17185
2020-01-06 20:48:53 +00:00
Robert Sparks f71e9995a7 Dateless milestone work. Commit in preparation for merging forward.
- Legacy-Id: 17174
2019-12-24 21:38:26 +00:00
Henrik Levkowetz 06fe583351 Merged /branch/iola/meeting-improvement-r16992@17152 from olau@iola.dk:
* Renamed Meeting.agenda to Meeting.schedule together with a bunch of related
   internal things

* Moved Session.status, .requested, and .requested_by to a new SchedulingEvent.

* Turned sessions into regular sessions and non-sessions into misc.
  sessions in the UI and code to avoid ambiguity.

  This doesn't change the data in the DB except for uses of
  TimeSlotTypeName where 'session' is now 'regular'.
 - Legacy-Id: 17153
2019-12-17 23:43:07 +00:00
Ole Laursen 568670c060 Turn sessions into regular sessions and non-sessions into misc.
sessions in the UI and code to avoid ambiguity.

This doesn't change the data in the DB except for uses of
TimeSlotTypeName where 'session' is now 'regular'.
 - Legacy-Id: 17128
2019-12-06 20:02:26 +00:00
Henrik Levkowetz 6f8263eb6e Added fallback handling from utf-8 to latin1 when reading charter text files.
- Legacy-Id: 17126
2019-12-06 14:17:22 +00:00
Ole Laursen 3957743b85 Move Session.status, .requested, and .requested_by to a new SchedulingEvent
- Legacy-Id: 17122
2019-12-05 12:41:09 +00:00
Henrik Levkowetz fcb6806d17 Merged in work from sasha@dashcare.nl on Review Queue Managemnt:
This abstracts queue management, making it possible to implement different
policies for each team. It provides two concrete policies:
RotateAlphabeticallyReviewerQueuePolicy, which rotates an alphabetically
ordered reviewer list with consideration for skip indications, and is the
default policy; and LeastRecentlyUsedReviewerQueuePolicy, a simple
least-recently-used policy.  Also see issues #2721 and #2656.
 - Legacy-Id: 17121
2019-12-04 23:02:52 +00:00
Henrik Levkowetz 7ec09554bb Merged in [17069] from sasha@dashcare.nl:
Fix #2074, fix #2358 - Add history for assignments, requests and unavailability.
 - Legacy-Id: 17104
Note: SVN reference [17069] has been migrated to Git commit 65d84155b6
2019-11-26 16:09:43 +00:00
Henrik Levkowetz 994e5b36b5 Merged in [17083] from kivinen@iki.fi:
Moved hard coded defaults for max items to show and days to show to
the settings.py.
 - Legacy-Id: 17099
Note: SVN reference [17083] has been migrated to Git commit 90428d6d5f
2019-11-23 04:46:51 +00:00
Sasha Romijn 10a7bee637 Merge reviewer-queue-management on top of 6.111.1.dev0
- Legacy-Id: 17094
2019-11-22 12:35:28 +00:00
Tero Kivinen 90428d6d5f Moved hard coded defaults for max items to show and days to show to
the settings.py. Commit ready for merge.
 - Legacy-Id: 17083
2019-11-21 07:27:20 +00:00
Sasha Romijn 65d84155b6 Fix #2074, fix #2358 - Add history for assignments, requests and unavailability.
Commit ready for merge.
 - Legacy-Id: 17069
2019-11-20 11:29:14 +00:00
Henrik Levkowetz 19eb5de983 Merged in [17044] from valery@smyslov.net:
Make it clearer that a chair can't revise materials for a meeting once the proceedings deadline has passed

    Fixes issue #2612.
 - Legacy-Id: 17067
Note: SVN reference [17044] has been migrated to Git commit 182dae28a8
2019-11-20 10:10:31 +00:00
Sasha Romijn 3db8a0f39d Fix issue where queue might not advance correctly while managing
unassigned reviews, when some reviewers have a skip count.
 - Legacy-Id: 17060
2019-11-19 11:53:12 +00:00
Henrik Levkowetz e070aacc86 Merged in [17034] from kivinen@iki.fi:
Added two new configuration settings for the review team secretary,
one to set how many days to include in the reviewers list, and
another one to limit the number of completed items in the list for
each person. This version replaces the one I did earlier, and includes
much more test cases to test different limits on the reviewers page.
 - Legacy-Id: 17057
Note: SVN reference [17034] has been migrated to Git commit b5d864499f
2019-11-19 10:24:50 +00:00
Sasha Romijn 554a839864 Fix #2336 - Add "select me next for an assignment".
Reviewers can set this flag in their reviewer settings, which triggers
a mail to be sent to the secretary. They are then kept on top of the
recommended assignment order. This flag is automatically reset when any
assignment is made to the reviewer.
 - Legacy-Id: 17048
2019-11-18 12:30:11 +00:00
Valery Smyslov 182dae28a8 Fixes issue #2612. Commit ready for merge.
- Legacy-Id: 17044
2019-11-18 08:48:15 +00:00
Tero Kivinen b5d864499f Added two new configuration settings for the review team secretary,
one to set how many days to include in the reviewers list, and
another one to limit the number of completed items in the list for
each person. This version replaces the one I did earlier, and includes
much more test cases to test different limits on the reviewers page.
Commit ready for merge.
 - Legacy-Id: 17034
2019-11-16 09:41:55 +00:00
Jim Fenton 020d4a393c Adds Closing note field to state specific WG edit. Fixes #2779. Commit ready for merge.
- Legacy-Id: 17028
2019-11-16 05:46:51 +00:00
Sasha Romijn ce812a3a4f - Make skipping unavailable reviews the default, except for the
reviewer_overview page.
- Make default_reviewer_rotation_list use a consistent return type
 - Legacy-Id: 16986
2019-11-11 14:47:37 +00:00
Sasha Romijn b5a31c3c6a Update some terminology and docstrings.
- Legacy-Id: 16983
2019-11-11 12:31:16 +00:00
Robert Sparks 5c08b4096a Disregard unassigned reviews when building the sets to compare when checking for race-conditions on assigning reviews. Partially addresses #2821. Commit ready for merge.
- Legacy-Id: 16977
2019-11-07 16:16:33 +00:00
Henrik Levkowetz b7724c43d7 Changed some # type: ignore statements to work with the latest mypy
- Legacy-Id: 16968
2019-11-05 22:41:18 +00:00
Sasha Romijn e518824a69 Initial refactoring of the current reviewer assignment code.
- Legacy-Id: 16961
2019-11-05 16:39:31 +00:00
Henrik Levkowetz cee82e9f43 Merged in [16934] from sasha@dashcare.nl:
Fix #2088 - Sort unassigned review requests by doc name by default.
 - Legacy-Id: 16952
Note: SVN reference [16934] has been migrated to Git commit f075eced5c
2019-11-02 16:31:48 +00:00
Henrik Levkowetz 77a56473c3 Merged in [16933] from sasha@dashcare.nl:
Fix #2119 - Allow specifying review type for suggested reviews in LC and telechat
If a review is suggested on the 'manage unassigned reviews' page, and
the document is in both last call and telechat, the assign form now asks
for the type of review that should be assigned.
This commit also fixes two bugs in this process:
- Comparisons in some cases between strings and integers
  (group/views.py:1485/1487)
- Rejections when assigning suggested reviews, as they could be
  considered a newly opened request due to not having a pk
  (group/views.py:1508)
 - Legacy-Id: 16951
Note: SVN reference [16933] has been migrated to Git commit ee4bc0cb07
2019-10-31 17:31:21 +00:00
Sasha Romijn eab14ea1c5 Early work to extract reviewer policy from review/utils.py.
- Legacy-Id: 16950
2019-10-31 15:01:14 +00:00
Henrik Levkowetz a37bd907cc Merged in [16926] from rjsparks@nostrum.com:
Flipped a sense to put the grace period on the right side of 'today' when sending review overdue reminders to team secretaries. Fixes #2816.
 - Legacy-Id: 16940
Note: SVN reference [16926] has been migrated to Git commit 7560e116bf
2019-10-30 13:01:53 +00:00
Sasha Romijn f075eced5c Fix #2088 - Sort unassigned review requests by doc name by default.
Commit ready for merge.
 - Legacy-Id: 16934
2019-10-28 12:27:15 +00:00
Sasha Romijn ee4bc0cb07 Fix #2119 - Allow specifying review type for suggested reviews in LC and telechat
If a review is suggested on the "manage unassigned reviews" page, and
the document is in both last call and telechat, the assign form now asks
for the type of review that should be assigned.

This commit also fixes two bugs in this process:
- Comparisons in some cases between strings and integers
  (group/views.py:1485/1487)
- Rejections when assigning suggested reviews, as they could be
  considered a newly opened request due to not having a pk
  (group/views.py:1508)
  
Commit ready for merge.
 - Legacy-Id: 16933
2019-10-28 11:43:48 +00:00
Henrik Levkowetz 00fb8d4b43 Merged in [16923] from sasha@dashcare.nl:
Fix #2087 - Show doc authors and WG chairs in unassigned reviews views.
 - Legacy-Id: 16931
Note: SVN reference [16923] has been migrated to Git commit 93797b3fc1
2019-10-26 20:26:21 +00:00
Robert Sparks 7560e116bf Flipped a sense to put the grace period on the right side of "today" when sending review overdue reminders to team secretaries. Fixes #2816. Commit ready for merge.
- Legacy-Id: 16926
2019-10-25 20:32:16 +00:00
Sasha Romijn 93797b3fc1 Fix #2087 - Show doc authors and WG chairs in unassigned reviews views.
Commit ready for merge.
 - Legacy-Id: 16923
2019-10-24 07:25:47 +00:00
Henrik Levkowetz 91d0a79a16 Merged in [16904] from sasha@dashcare.nl:
Fix #2118 - Always list all last call drafts in assignment summary.
If a draft is scheduled for a telechat, but also assigned for LC review,
it will now be listed both in the telechat section and under 'last calls'.
 - Legacy-Id: 16913
Note: SVN reference [16904] has been migrated to Git commit 82c63b49f3
2019-10-23 15:16:30 +00:00
Henrik Levkowetz 399d0e1797 Merged in [16902] from sasha@dashcare.nl:
Ref #2526 - Fix test failure in [16895]
This also makes a small text clarification, which was also the initial
reason for the test failure.
 - Legacy-Id: 16912
Note: SVN reference [16895] has been migrated to Git commit ef1e8006f0

Note: SVN reference [16902] has been migrated to Git commit 78a1464e77
2019-10-23 13:31:46 +00:00
Henrik Levkowetz 97be7f31ea Merged in [16895] from sasha@dashcare.nl:
Fix #2526 - List previous reviews in assignments email.
This includes a migration to update the database templates. Note that
not all templates currently included them (secdir at least), and
previous reviews are only listed in templates that included */** before.
As before, previous reviews are only included if they are done by the
same reviewer(s) as the current assignment.
This also fixes a bug in database template 182
(/group/defaults/email/open_assignments.txt) which referred to 
r.review_request..doc.rev and r.review_request..requested_rev
in the template, and updates the test to use the current version of
template 182.
 - Legacy-Id: 16911
Note: SVN reference [16895] has been migrated to Git commit ef1e8006f0
2019-10-22 22:09:08 +00:00
Henrik Levkowetz 4a486a6c4d Merged in [16891] from sasha@dashcare.nl:
Fix #2198 - Set default start date for UnavailabilityPeriod to today.
 - Legacy-Id: 16910
Note: SVN reference [16891] has been migrated to Git commit a7a2ee4a39
2019-10-22 21:20:51 +00:00
Sasha Romijn 82c63b49f3 Fix #2118 - Always list all last call drafts in assignment summary.
If a draft is scheduled for a telechat, but also assigned for LC review,
it will now be listed both in the telechat section and under "last calls".

Commit ready for merge.
 - Legacy-Id: 16904
2019-10-22 14:55:04 +00:00
Sasha Romijn 78a1464e77 Ref #2526 - Fix test failure in [16895]
This also makes a small text clarification, which was also the initial
reason for the test failure.

Commit ready for merge.
 - Legacy-Id: 16902
Note: SVN reference [16895] has been migrated to Git commit ef1e8006f0
2019-10-22 14:34:36 +00:00
Henrik Levkowetz 9e21c011f6 Merged in [16854] from rjsparks@nostrum.com:
Remove some pre-ReviewAssignment refactor logic, and simplify what remains while still allowing a group secretary to not assign a row on the unassigned requests form after touching the control to assign a reviewer. Fixes #2812.
 - Legacy-Id: 16900
Note: SVN reference [16854] has been migrated to Git commit b158807134e2d26b3e013b6414b6fcbaa0e39f77
2019-10-22 12:43:56 +00:00
Henrik Levkowetz 1674356ee5 Merged in [16850] from sasha@dashcare.nl:
Fix #2185 - Close review assignments when reviewer is removed from team.
If a reviewer is removed from a team, any accepted or assigned review
assignments are set to rejected if the request deadline has not passed,
or set to no-response when the request deadline has passed.
Per [16819], if this scenario happens, and there are no other active or 
completed review assignments, the request is shown as an
unassigned review.
 - Legacy-Id: 16897
Note: SVN reference [16819] has been migrated to Git commit fdb4c2a055

Note: SVN reference [16850] has been migrated to Git commit e145832808
2019-10-21 21:56:05 +00:00
Sasha Romijn ef1e8006f0 Fix #2526 - List previous reviews in assignments email.
This includes a migration to update the database templates. Note that
not all templates currently included them (secdir at least), and
previous reviews are only listed in templates that included */** before.

As before, previous reviews are only included if they are done by the
same reviewer(s) as the current assignment.

This also fixes a bug in database template 182
(/group/defaults/email/open_assignments.txt) which referred to 
r.review_request..doc.rev and r.review_request..requested_rev
in the template, and updates the test to use the current version of
template 182.

Commit ready for merge.
 - Legacy-Id: 16895
2019-10-21 19:11:56 +00:00
Sasha Romijn a7a2ee4a39 Fix #2198 - Set default start date for UnavailabilityPeriod to today.
Commit ready for merge.
 - Legacy-Id: 16891
2019-10-21 15:16:33 +00:00
Henrik Levkowetz 1656b0012c Merged in [16819] from sasha@dashcare.nl:
Fix #2186 - Return review req to 'requested' status if no review assignments are open.
If a review assignment is rejected, withdrawn, marked no response, etc.,
and this leaves a review request without any assigned/accepted/completed
review assignments, return the request state to 'requested', which means
it will be shown as an unassigned review in all interfaces.
 - Legacy-Id: 16881
Note: SVN reference [16819] has been migrated to Git commit fdb4c2a055
2019-10-21 13:45:03 +00:00
Henrik Levkowetz 77abc3868e Type checking tweaks.
- Legacy-Id: 16867
2019-10-15 16:54:33 +00:00
Henrik Levkowetz a66fa82b06 Fixed some review reminders issues.
- Legacy-Id: 16863
2019-10-15 16:46:12 +00:00
Sasha Romijn e145832808 Fix #2185 - Close review assignments when reviewer is removed from team.
If a reviewer is removed from a team, any accepted or assigned review
assignments are set to rejected if the request deadline has not passed,
or set to no-response when the request deadline has passed.

Per [16819], if this scenario happens, and there are no other active or 
completed review assignments, the request is shown as an
unassigned review.

Commit ready for merge.
 - Legacy-Id: 16850
Note: SVN reference [16819] has been migrated to Git commit fdb4c2a055
2019-10-09 13:36:25 +00:00
Henrik Levkowetz fab9580bb0 Merged in [16815] from rjsparks@nostrum.com:
Link to the about pages for groups even if they don't have a charter (some have other forms of descriptive text, and all have more information on the group pages than they did a few years ago). Fixes #2744.
 - Legacy-Id: 16848
Note: SVN reference [16815] has been migrated to Git commit 26e3e62c567d8146a27a976f1da0710eeda46ba2
2019-10-08 22:24:06 +00:00
Henrik Levkowetz be641ac22a Merged in [16792] from sasha@dashcare.nl:
Fix #2475 - Send opt-in reminders for unconfirmed review assignments.
If enabled for a team, reminders will be sent every X days to reviewers
for review assignments they have not accepted or rejected.
 - Legacy-Id: 16846
Note: SVN reference [16792] has been migrated to Git commit 486b6daa29
2019-10-08 15:57:28 +00:00
Henrik Levkowetz 678f8a5787 Merged in [16765] from sasha@dashcare.nl:
Refs #2277 - Send daily reminders of overdue reviews to secretaries
 - Legacy-Id: 16839
Note: SVN reference [16765] has been migrated to Git commit cc64992204
2019-10-08 10:41:37 +00:00
Henrik Levkowetz 09e38dffa0 Merged in [16705] from sasha@dashcare.nl:
Fix #2337 - Send periodic reminders of open reviews every X days (opt-in)
The interleaved_migrations_test currently fails due to the various 
migrations that have been added for individual tickets/commits (unless
--permit-mixed-migrations is set). I think this is better fixed in a
later cleanup, as doing it now could cause confusion when merging
individual commits, and more migrations are likely to be added soon.
 - Legacy-Id: 16823
Note: SVN reference [16705] has been migrated to Git commit ec56a03ec6
2019-10-04 17:09:57 +00:00
Henrik Levkowetz 4c3e869d5c Merged in [16704] from sasha@dashcare.nl:
Fix #2231 - Send reminders before long UnavailabilityPeriods expire
A notification is sent to the team secretary and reviewer, if an
unavailability period lasting 30 days or more will end in 3 days.
 - Legacy-Id: 16822
Note: SVN reference [16704] has been migrated to Git commit 179c151f9e
2019-10-04 14:07:54 +00:00
Sasha Romijn fdb4c2a055 Fix #2186 - Return review req to 'requested' status if no review assignments are open.
If a review assignment is rejected, withdrawn, marked no response, etc.,
and this leaves a review request without any assigned/accepted/completed
review assignments, return the request state to "requested", which means
it will be shown as an unassigned review in all interfaces.

Commit ready for merge.
 - Legacy-Id: 16819
2019-10-03 09:02:34 +00:00
Sasha Romijn 486b6daa29 Fix #2475 - Send opt-in reminders for unconfirmed review assignments.
If enabled for a team, reminders will be sent every X days to reviewers
for review assignments they have not accepted or rejected.

Commit ready for merge.
 - Legacy-Id: 16792
2019-10-01 13:01:19 +00:00
Henrik Levkowetz 12bf466832 Merged in [16668] from sasha@dashcare.nl:
Fix #2560 - Sort names in history when changing list of members.
 - Legacy-Id: 16789
Note: SVN reference [16668] has been migrated to Git commit de9cde9e43
2019-10-01 10:15:46 +00:00
Henrik Levkowetz c63ace2721 Removed debug-related code from group edit clean_acronym(). Fixes issue #2804.
- Legacy-Id: 16787
2019-09-30 21:37:40 +00:00
Henrik Levkowetz 10c8596664 Merged in [16667] from sasha@dashcare.nl:
Fix #2071 - Add optional comment field for close request.
 - Legacy-Id: 16786
Note: SVN reference [16667] has been migrated to Git commit 4669b0934b
2019-09-30 20:55:16 +00:00
Henrik Levkowetz 33e8733b91 Fixed up mypy issues or added type:ignore comments as needed for a clean mypy run.
- Legacy-Id: 16772
2019-09-30 15:42:18 +00:00
Sasha Romijn cc64992204 Refs #2277 - Send daily reminders of overdue reviews to secretaries
Commit ready for merge.
 - Legacy-Id: 16765
2019-09-30 12:27:43 +00:00
Henrik Levkowetz 3349d64479 Merged in [16647] from rjsparks@nostrum.com:
Corrected a view that was looking at review assignment ids when it should have been looking at request review ids. Fixes #2776.
 - Legacy-Id: 16708
Note: SVN reference [16647] has been migrated to Git commit 87de06c97c
2019-09-05 21:26:54 +00:00
Sasha Romijn ec56a03ec6 Fix #2337 - Send periodic reminders of open reviews every X days (opt-in)
The interleaved_migrations_test currently fails due to the various 
migrations that have been added for individual tickets/commits (unless
--permit-mixed-migrations is set). I think this is better fixed in a
later cleanup, as doing it now could cause confusion when merging
individual commits, and more migrations are likely to be added soon.

Commit ready for merge.
 - Legacy-Id: 16705
2019-09-05 15:02:56 +00:00
Sasha Romijn 179c151f9e Fix #2231 - Send reminders before long UnavailabilityPeriods expire
A notification is sent to the team secretary and reviewer, if an
unavailability period lasting 30 days or more will end in 3 days.
Commit ready for merge.
 - Legacy-Id: 16704
2019-09-05 11:59:40 +00:00
Sasha Romijn de9cde9e43 Fix #2560 - Sort names in history when changing list of members. Commit ready for merge.
- Legacy-Id: 16668
2019-08-23 11:57:40 +00:00
Sasha Romijn 4669b0934b Fix #2071 - Add optional comment field for close request. Commit ready for merge.
- Legacy-Id: 16667
2019-08-23 11:37:41 +00:00
Robert Sparks 87de06c97c Corrected a view that was looking at review assignment ids when it should have been looking at request review ids. Fixes #2776. Commit ready for merge.
- Legacy-Id: 16647
2019-08-13 18:13:50 +00:00
Henrik Levkowetz 8e313e4ed5 Adjusted migrations for Python2/3 compatibility.
- Legacy-Id: 16633
2019-08-08 17:11:14 +00:00
Henrik Levkowetz de43926eba Merged in [16559] from fenton@bluepopcorn.net:
Added Closing Notes to history and about pages for groups. Fixes issue #2725.
 - Legacy-Id: 16586
Note: SVN reference [16559] has been migrated to Git commit 93b4d6fcc4
2019-07-24 19:49:45 +00:00
Henrik Levkowetz 5a1c35909a Updated a test to match the change in r16560
- Legacy-Id: 16575
2019-07-22 17:55:29 +00:00
Jim Fenton 93b4d6fcc4 Added Closing Notes to history and about pages for groups. Fixes issue #2725. Commit ready for merge.
- Legacy-Id: 16559
2019-07-20 19:47:32 +00:00
Henrik Levkowetz bdc73e771a Python2/3 compatibility: replaced six.ensure_text() with either six.text_type or django's force_text(), depending on the case, and fixed a variable scope issue.
- Legacy-Id: 16461
2019-07-16 13:20:05 +00:00
Henrik Levkowetz 8c6eb3a30a Python2/3 compatibility: Changed the use of open() and StringIO to io.open() etc.
- Legacy-Id: 16458
2019-07-15 19:14:04 +00:00
Henrik Levkowetz a5e31c3f40 Py2/3 compatibility: Added __future__ import.
- Legacy-Id: 16452
2019-07-15 15:52:18 +00:00
Henrik Levkowetz 2d7c9629aa Added 'from __future__' imports all over the place, to bring code behaviour into closer alignment between python2 and python3
- Legacy-Id: 16446
2019-07-15 15:40:51 +00:00
Henrik Levkowetz f481f5c3e6 Replaced use of six with the equivalent pure python3 constructs.
- Legacy-Id: 16428
2019-07-08 10:43:47 +00:00
Henrik Levkowetz 4368e8cca1 Corrected a comment
- Legacy-Id: 16414
2019-07-07 12:51:06 +00:00
Henrik Levkowetz dfd3b60322 Removed tests for the confirm_acronym field removed in [16412].
- Legacy-Id: 16413
Note: SVN reference [16412] has been migrated to Git commit 1997a90d10
2019-07-07 12:50:27 +00:00
Henrik Levkowetz 1997a90d10 Removed the insertion of 'confirm_acronym' in the active form in clean_acronym(). It triggers an exception due to changing a dictionary while the django validation code is iterating through the form fields. XXX Check if we need to put this back some other way, or if we can handle acronym re-use through the admin instead.
- Legacy-Id: 16412
2019-07-07 12:49:17 +00:00
Henrik Levkowetz 0679eaa8d4 Removed unused imports.
- Legacy-Id: 16402
2019-07-04 21:06:57 +00:00
Henrik Levkowetz f480799af9 Undid unintentional bulk commit
- Legacy-Id: 16401
2019-07-04 21:04:46 +00:00
Henrik Levkowetz fc09a59950 Added decode() of command pipe output.
- Legacy-Id: 16400
2019-07-04 21:01:39 +00:00
Henrik Levkowetz fa85e6edee Typo fixes and removal of an unused import.
- Legacy-Id: 16394
2019-07-04 20:55:32 +00:00
Henrik Levkowetz 89e265d798 Fixed an instance of changing a dictionary inside a loop over its keys.
- Legacy-Id: 16387
2019-07-04 16:12:09 +00:00
Henrik Levkowetz 97a555936d Changed a large number of test assertions to use assertContains() and removed separate, now unnecessary,status_code checks. Also changed many assertTrue(... in ...) to use assertIn().
- Legacy-Id: 16346
2019-06-30 21:03:34 +00:00
Henrik Levkowetz aad1d0f1e5 Fixed another str/bytes issue.
- Legacy-Id: 16344
2019-06-30 21:00:38 +00:00
Henrik Levkowetz 15e74e89cb Converted instances of assertTrue(text in response.content) to the recommended assertContains(response, text), and similar for assertFalse(... in ...)
- Legacy-Id: 16336
2019-06-29 13:43:31 +00:00
Henrik Levkowetz 2b1f238204 Changed regex strings to raw strings and fixed a sort comparison int/str issue.
- Legacy-Id: 16333
2019-06-29 13:29:13 +00:00
Henrik Levkowetz 484dcece5f Changed all model __unicode__() methods to __str__()
- Legacy-Id: 16330
2019-06-28 21:07:08 +00:00
Henrik Levkowetz e39ac52071 Removed 2to3-generated list() around .items() iterator in for loops.
- Legacy-Id: 16315
2019-06-27 18:11:17 +00:00
Henrik Levkowetz 240d5bc64d Replaced force_unicode() with force_text()
- Legacy-Id: 16313
2019-06-27 18:08:56 +00:00