altf4arnold/datatracker
1
0
Fork 0
Code Issues Pull requests Actions 3 Packages Projects Releases Wiki Activity
8296 commits 1 branch 0 tags 2.6 GiB
Commit graph

6821 commits

Author SHA1 Message Date
Henrik Levkowetz fa60671148 Fixed another instance of '=' being used for comparison in a template. 
- Legacy-Id: 12708
 2017-01-19 21:21:10 +00:00
Henrik Levkowetz 450c39af23 Changed the failure leeway of the code coverage test percentage from 0.005% back to 0.02%. 
- Legacy-Id: 12707
 2017-01-19 20:01:19 +00:00
Robert Sparks 518f7a1d65 Restrict editing ReviewSettings.skip_next to team secretaries and the secretariat. Improve validation of skip_next value. Fixes #2149. Commit ready for merge. 
- Legacy-Id: 12706
 2017-01-19 19:17:29 +00:00
Henrik Levkowetz 93b1ba1e8f Set version info and settings back to development mode 
- Legacy-Id: 12684
 2017-01-19 17:41:11 +00:00
Henrik Levkowetz 2cd92a9f50 Set version info to release version 6.40.4 before branching. 
- Legacy-Id: 12682
 2017-01-19 17:41:04 +00:00
Henrik Levkowetz 4c86cfc63d Fixed two cases of templates using '=' in tests instead of '=='. 
- Legacy-Id: 12679
 2017-01-19 17:30:27 +00:00
Henrik Levkowetz 1dba613197 Merged in [12675] from rjsparks@nostrum.com: 
Removed some unnecessary randomness in tests introduced in last commit.
 - Legacy-Id: 12678
Note: SVN reference [12675] has been migrated to Git commit 4f2f691de6
 2017-01-19 17:24:08 +00:00
Henrik Levkowetz fd2304e446 In Django 1.9, CharField form fields will be whitespace-stripped by default. Added strip=False for the status change review form content. Also removed a superfluous f.close(). 
- Legacy-Id: 12677
 2017-01-19 17:15:28 +00:00
Henrik Levkowetz 7c2a161a5f Removed some remaining instances of render using context_instance. Fixed a case of tuple length of list of tuples passed to a template to be the same for all tuples. 
- Legacy-Id: 12676
 2017-01-19 17:08:27 +00:00
Robert Sparks 4f2f691de6 Removed some unnecessary randomness in tests introduced in last commit. Commit ready for merge. 
- Legacy-Id: 12675
 2017-01-19 16:37:00 +00:00
Henrik Levkowetz 2414b932e2 Deprecation fix: removed 'load firstof from future'. 
- Legacy-Id: 12674
 2017-01-19 16:16:52 +00:00
Henrik Levkowetz 7d71a24358 Added a save for a session presentation object before adding a reference to it. 
- Legacy-Id: 12673
 2017-01-19 16:11:37 +00:00
Henrik Levkowetz 82760fb21f Deprecation fix: Changed all instances of the old syntax for the 'cycle' template tag to use the new syntax. 
- Legacy-Id: 12672
 2017-01-19 16:10:13 +00:00
Henrik Levkowetz b4480a1625 Merged in [12670] from rjsparks@nostrum.com: 
Make changing skip_next on a review assignment an explicit decision of the assigner.  Fixes #2148.
 - Legacy-Id: 12671
Note: SVN reference [12670] has been migrated to Git commit 8e007ce50b
 2017-01-19 15:25:22 +00:00
Robert Sparks 8e007ce50b Make changing skip_next on a review assignment an explicit decision of the assigner. Commit ready for merge. Fixes #2148. 
- Legacy-Id: 12670
 2017-01-19 14:23:09 +00:00
Henrik Levkowetz 7d25922e9b Enabled correct time sorting and reporting for interim meetings on /group/{{acronym}}/meetings/, and tweaked the date format. Fixes issue #2145. 
- Legacy-Id: 12669
 2017-01-18 19:24:14 +00:00
Henrik Levkowetz 79dc639f46 Merged in [12665] from rjsparks@nostrum.com: 
Make it easier to see who's really next in reviewer rotation.
 - Legacy-Id: 12668
Note: SVN reference [12665] has been migrated to Git commit 49dcf67fd5
 2017-01-18 16:30:29 +00:00
Henrik Levkowetz dd82df50a1 Merged in [12627] from rjsparks@nostrum.com: 
Added some convenience navigation for review team secretaries to the menu. Restructured the menu lightly around Documents and Role-related links. Added navigation from a reviewers \'My Reviews\' page back to the review team pages. Fixes #2079.
 - Legacy-Id: 12667
Note: SVN reference [12627] has been migrated to Git commit 41d3bb61b4
 2017-01-18 15:55:11 +00:00
Henrik Levkowetz 7a8555599f Added a link to the group datatracker page to the new group announcement (and review) emails. Fixes issue #2140. 
- Legacy-Id: 12666
 2017-01-17 22:22:46 +00:00
Robert Sparks 49dcf67fd5 Make it easier to see who's really next in reviewer rotation. Commit ready for merge. 
- Legacy-Id: 12665
 2017-01-17 22:04:16 +00:00
Robert Sparks 0dd2e460f3 Make it easier to see what reviews need to be closed as "No Response". Fixes #2128. Commit ready for merge. 
- Legacy-Id: 12664
 2017-01-17 21:04:42 +00:00
Henrik Levkowetz 438195c832 Aligned some Group edit form field limits with those of the Group model. Fixes issue #2137. 
- Legacy-Id: 12646
 2017-01-12 13:57:26 +00:00
Henrik Levkowetz 6eec4c2648 Converted all management commands which set up additional command-line switches to use the argparse approach instead of the deprecated optparse approach. 
- Legacy-Id: 12645
 2017-01-11 18:42:38 +00:00
Henrik Levkowetz e6fe2c65fb Excluded some non-testable files from code coverage measurements. 
- Legacy-Id: 12644
 2017-01-11 15:33:22 +00:00
Henrik Levkowetz 246e1e7780 Removed an inadvertently duplicated template for loop. Fixes issue #2136. 
- Legacy-Id: 12643
 2017-01-11 15:27:26 +00:00
Henrik Levkowetz 8833228d62 Added guards against instances of queryset filtering using an object without primary key. 
- Legacy-Id: 12642
 2017-01-11 15:24:27 +00:00
Henrik Levkowetz 74753b6c35 Added a guard against an instance of queryset filtering using an object without primary key. 
- Legacy-Id: 12640
 2017-01-10 20:51:00 +00:00
Henrik Levkowetz fef0060251 Added password reset links in 2 places; on the login form and in the User menu -- it's not been really easy to find that page. 
- Legacy-Id: 12638
 2017-01-10 14:14:07 +00:00
Henrik Levkowetz 7b95411f58 The context_instance parameter to render_to_response() and render_to_string() is now deprecated. Fixed this, and generally changed the idiom render_to_response('template.html', {}, RequestContext(request)) to the newer and simpler render(request, 'template.html', {}). About 200 instances. 
- Legacy-Id: 12637
 2017-01-09 21:26:30 +00:00
Henrik Levkowetz 5286dfdbc8 Made sure that sessionpresentation objects are saved before adding them to a m2m set. 
- Legacy-Id: 12636
 2017-01-09 21:23:14 +00:00
Henrik Levkowetz e290de8f16 Disabled a deprecation warning for code in bootstrap3.utils 
- Legacy-Id: 12635
 2017-01-09 21:21:59 +00:00
Henrik Levkowetz 9c095365dd Commented out debug output from ietf.utils.urls.url(). Tweaked the url() handling of django views. 
- Legacy-Id: 12634
 2017-01-09 16:32:38 +00:00
Henrik Levkowetz 4ba6d6f329 Added a new middleware class to silence a deprecation warning, and added a new filterwarning to ignore a warning about using a deprecated class in the now unused TimedeltaField. 
- Legacy-Id: 12633
 2017-01-09 16:30:53 +00:00
Henrik Levkowetz a21812633d Removed unnecessary leading slash in url pattern, silencing a system check warning. 
- Legacy-Id: 12632
 2017-01-09 16:28:59 +00:00
Robert Sparks 41d3bb61b4 Added some convenience navigation for review team secretaries to the menu. Restructured the menu lightly around Documents and Role-related links. Added navigation from a reviewers "My Reviews" page back to the review team pages. Fixes #2079. Commit ready for merge. 
- Legacy-Id: 12627
 2016-12-23 21:20:55 +00:00
Henrik Levkowetz 334445d0d0 Added a warnings ignore for an issue which pops up on ietfa. 
- Legacy-Id: 12626
 2016-12-22 19:44:34 +00:00
Henrik Levkowetz 725ce16c4c Added a variation on the manage.py script which will pick up our local python virtualenv under env/. This is for use when invoking django management commands externally, for instance in email pipelines from /etc/aliases. 
- Legacy-Id: 12625
 2016-12-22 19:43:30 +00:00
Henrik Levkowetz 5cc3b6448e Django 1.9: Removed additional instances of deprecated django.conf.urls.patterns() 
- Legacy-Id: 12623
 2016-12-22 18:14:57 +00:00
Henrik Levkowetz eb5aa9a691 Django 1.9: Refined the autonaming url() replacement. 
- Legacy-Id: 12622
 2016-12-22 18:08:21 +00:00
Henrik Levkowetz d5460b8f7f Django 1.9: Merged work forward to copy of latest release. 
- Legacy-Id: 12621
 2016-12-22 17:30:50 +00:00
Henrik Levkowetz 6759dd6496 Django 1.9: Changes merged forward from previous datatracker django-1.9 branch. 
- Legacy-Id: 12619
 2016-12-22 17:24:45 +00:00
Henrik Levkowetz c2541ec04b Django 1.9: Removed deprecated use of django.conf.urls.patterns() from all urls*.py files. 
- Legacy-Id: 12618
 2016-12-22 17:21:57 +00:00
Henrik Levkowetz bfc44dea82 Django 1.9: Added an alternative implementation of urls() which derives an url pattern name from the callable, in order to maintain DRY for url patterns. 
- Legacy-Id: 12617
 2016-12-22 17:20:29 +00:00
Henrik Levkowetz 3944ab95cc Django 1.9: Supplied a required argument to TemplateDoesNotExist() 
- Legacy-Id: 12616
 2016-12-22 17:14:51 +00:00
Henrik Levkowetz 471bbde4d5 Django 1.9: Adjusted import path 
- Legacy-Id: 12615
 2016-12-22 17:13:26 +00:00
Henrik Levkowetz c7a0d74481 Set version info and settings back to development mode 
- Legacy-Id: 12613
 2016-12-22 10:08:42 +00:00
Henrik Levkowetz d7488e4e88 Set version info to release version 6.40.3 before branching. 
- Legacy-Id: 12611
 2016-12-22 10:08:35 +00:00
Henrik Levkowetz 1456862c4e Merged in [12606] from rjsparks@nostrum.com: 
Tweak the docevent description for the event noting that a chartering effort has been abandoned. Fixes #2099.
 - Legacy-Id: 12608
Note: SVN reference [12606] has been migrated to Git commit 6091d3c6a3
 2016-12-21 22:34:51 +00:00
Robert Sparks 6091d3c6a3 Tweak the docevent description for the event noting that a chartering effort has been abandoned. Fixes #2099. Commit ready for merge. 
- Legacy-Id: 12606
 2016-12-21 22:14:58 +00:00
Henrik Levkowetz 24c9751df4 Merged in [12596] from rjsparks@nostrum.com: 
Show other completed reviews of a document on page showing the status of a review request. Fixes #2083.
 - Legacy-Id: 12605
Note: SVN reference [12596] has been migrated to Git commit 2bad0b0bcd
 2016-12-21 19:19:31 +00:00
Henrik Levkowetz 4486b3192f Merged in [12595] from rjsparks@nostrum.com: 
Improve the team review content templates. Related to #2075.
 - Legacy-Id: 12604
Note: SVN reference [12595] has been migrated to Git commit 6ca953ae24
 2016-12-21 18:52:12 +00:00
Henrik Levkowetz e0abd068f9 Merged in [12594] from rjsparks@nostrum.com: 
Provide templates for directly entered review contents for those teams/review-types that have them. Fixes #2075.
 - Legacy-Id: 12603
Note: SVN reference [12594] has been migrated to Git commit fbd2cd493d
 2016-12-21 18:14:25 +00:00
Henrik Levkowetz ec0d6a7e4f Merged in [12593] from rjsparks@nostrum.com: 
Send mail to team secretaries when a review is explicitly requested. Change the From and Subject for assignment emails to reviewers to make it clearer what the review is for and who assigned it. Fixes #2053 and #2114.
 - Legacy-Id: 12602
Note: SVN reference [12593] has been migrated to Git commit 10f4892eae
 2016-12-21 18:01:00 +00:00
Henrik Levkowetz 7686ce736c Merged in [12589] from rjsparks@nostrum.com: 
Show additional details about a review request when completing it. Fixes #2112.
 - Legacy-Id: 12601
Note: SVN reference [12589] has been migrated to Git commit 128fec09bd
 2016-12-21 17:38:02 +00:00
Henrik Levkowetz 7e6baf15b7 Merged in [12588] from rjsparks@nostrum.com: 
Change how we display review text to follow the tecnique used with other large blocks of pasted or imported text (shepherds writeups for instance). Fixes #2104.
 - Legacy-Id: 12600
Note: SVN reference [12588] has been migrated to Git commit 7c182375af
 2016-12-21 17:26:03 +00:00
Henrik Levkowetz 8e9858379b Fixed some pyflakes and form initialization issues with the upgrade to DurationField. 
- Legacy-Id: 12599
 2016-12-21 17:03:39 +00:00
Henrik Levkowetz 67b2fc1107 Extended the form fields used for duration to accept additional formats, including formats the secretariat are currently using, in order to avoid trouble with the TimedeltaField --> DurationField transition. 
- Legacy-Id: 12598
 2016-12-21 15:26:32 +00:00
Henrik Levkowetz 3d6b370c59 Upgraded custom TimedeltaFields to use the builtin DurationField from Django 1.8, and adjusted forms and initialization values accordingly. 
- Legacy-Id: 12597
 2016-12-20 22:56:34 +00:00
Robert Sparks 2bad0b0bcd Show other completed reviews of a document on page showing the status of a review request. Fixes #2083. Commit ready for merge. 
- Legacy-Id: 12596
 2016-12-20 22:22:44 +00:00
Robert Sparks 6ca953ae24 Improve the team review content templates. Related to #2075. Commit ready for merge. 
- Legacy-Id: 12595
 2016-12-20 05:38:02 +00:00
Robert Sparks fbd2cd493d Provide templates for directly entered review contents for those teams/review-types that have them. Fixes #2075. Commit ready for merge. 
- Legacy-Id: 12594
 2016-12-19 23:21:11 +00:00
Robert Sparks 10f4892eae Send mail to team secretaries when a review is explicitly requested. Change the From and Subject for assignment emails to reviewers to make it clearer what the review is for and who assigned it. Fixes #2053 and #2114. Commit ready for merge. 
- Legacy-Id: 12593
 2016-12-19 22:32:03 +00:00
Henrik Levkowetz d401e6ba67 Fixed an error in migration dependency. 
- Legacy-Id: 12592
 2016-12-19 21:42:21 +00:00
Henrik Levkowetz 80c0e65428 Merged in [12540] from rjsparks@nostrum.com: 
Missed adding a migration to svn for r12521.  Should only be applied after r12521.
 - Legacy-Id: 12591
Note: SVN reference [12540] has been migrated to Git commit 68bdff6fd5
 2016-12-19 21:39:54 +00:00
Henrik Levkowetz fb891ecf05 Merged in [12521] from rjsparks@nostrum.com: 
Removes classes obviated in r12520.  Should be held for release after r12520 is released?
 - Legacy-Id: 12590
Note: SVN reference [12521] has been migrated to Git commit 483d9db895
 2016-12-19 21:19:49 +00:00
Robert Sparks 128fec09bd Show additional details about a review request when completing it. Fixes #2112. Commit ready for merge. 
- Legacy-Id: 12589
 2016-12-19 21:06:06 +00:00
Robert Sparks 7c182375af Change how we display review text to follow the tecnique used with other large blocks of pasted or imported text (shepherds writeups for instance). Fixes #2104. Commit ready for merge. 
- Legacy-Id: 12588
 2016-12-19 20:38:51 +00:00
Henrik Levkowetz 0399ca5c35 Adjusted an import path. 
- Legacy-Id: 12583
 2016-12-19 13:54:07 +00:00
Henrik Levkowetz faa7088d06 Adjusted an import path. 
- Legacy-Id: 12582
 2016-12-19 13:53:36 +00:00
Henrik Levkowetz 244a7a96e4 Import import_module directly instead of through django, which is deprecated. 
- Legacy-Id: 12581
 2016-12-19 13:52:58 +00:00
Henrik Levkowetz 7e3088993e Delay an import which causes not ready complaints if handled too early. 
- Legacy-Id: 12580
 2016-12-19 13:52:00 +00:00
Henrik Levkowetz 6f6406b097 Set version info and settings back to development mode 
- Legacy-Id: 12577
 2016-12-18 15:01:07 +00:00
Henrik Levkowetz 6904adc952 Set version info to release version 6.40.2 before branching. 
- Legacy-Id: 12575
 2016-12-18 15:00:59 +00:00
Henrik Levkowetz 481a96c935 Changed the handling of skip tests and messages in order to show which tests will be skipped, and why, at the start of a test run. 
- Legacy-Id: 12568
 2016-12-17 21:49:53 +00:00
Henrik Levkowetz 5e3f3378d3 Updated scripts in ietf/bin/ to look in env/bin/ for the virtualenv activation script. 
- Legacy-Id: 12560
 2016-12-16 17:50:04 +00:00
Henrik Levkowetz ef8adb11df Set version info and settings back to development mode 
- Legacy-Id: 12557
 2016-12-16 12:59:28 +00:00
Henrik Levkowetz 8f4c29bc8e Set version info to release version 6.40.1 before branching. 
- Legacy-Id: 12555
 2016-12-16 12:59:20 +00:00
Henrik Levkowetz 45d4ce67c7 Adjusted the ReviewRequest.comment AddField migration to match the change in model. 
- Legacy-Id: 12553
 2016-12-16 12:55:37 +00:00
Henrik Levkowetz 61ce846d6c Fixed a html nit; nbsp without semicolon. 
- Legacy-Id: 12551
 2016-12-16 09:03:45 +00:00
Henrik Levkowetz ff3638e365 Merged in [12549] from rjsparks@nostrum.com: 
allow ads and secretaries to edit the review request comment. Fixes #2096. (Again).
 - Legacy-Id: 12550
Note: SVN reference [12549] has been migrated to Git commit 32b431cf24
 2016-12-15 23:10:28 +00:00
Robert Sparks 32b431cf24 allow ads and secretaries to edit the review request comment. Fixes #2096. (Again). Commit ready for merge. 
- Legacy-Id: 12549
 2016-12-15 22:54:40 +00:00
Henrik Levkowetz 8dcc1d20a2 Merged in [12545] from rjsparks@nostrum.com: 
Allow a review request to include a comment to show to the review team secretary at assignment time and the reviewer at review time. Fixes #2096.
 - Legacy-Id: 12548
Note: SVN reference [12545] has been migrated to Git commit 6fcd8b8a16
 2016-12-15 22:45:25 +00:00
Henrik Levkowetz eafa070790 Merged in [12543] from rjsparks@nostrum.com: 
Provide defaults on the Request review form. Fixes #2108.
 - Legacy-Id: 12547
Note: SVN reference [12543] has been migrated to Git commit 870fa59d0c
 2016-12-15 22:10:12 +00:00
Henrik Levkowetz fa684cf6d2 Merged in [12541] from rjsparks@nostrum.com: 
Provide default filters for reviewer settings. Fixes #2093.
 - Legacy-Id: 12546
Note: SVN reference [12541] has been migrated to Git commit df86798cf3
 2016-12-15 21:57:46 +00:00
Robert Sparks 6fcd8b8a16 Allow a review request to include a comment to show to the review team secretary at assignment time and the reviewer at review time. Fixes #2096. Commit ready for merge. 
- Legacy-Id: 12545
 2016-12-15 21:52:12 +00:00
Henrik Levkowetz b14e981e66 Merged in [12520] from rjsparks@nostrum.com: 
Slight refactor of the review models to capture review team settings. Allows configuring review teams to get automatic suggestions for reviews or not. Provides a better admin for creating/managing review teams. Fixes #2048 and #2072.
 - Legacy-Id: 12544
Note: SVN reference [12520] has been migrated to Git commit b24bdb5bc3
 2016-12-15 20:55:40 +00:00
Robert Sparks 870fa59d0c Provide defaults on the Request review form. Fixes #2108. Commit ready for merge. 
- Legacy-Id: 12543
 2016-12-15 20:36:15 +00:00
Robert Sparks df86798cf3 Provide default filters for reviewer settings. Fixes #2093. Commit ready for merge. 
- Legacy-Id: 12541
 2016-12-15 19:48:37 +00:00
Robert Sparks 68bdff6fd5 Missed adding a migration to svn for r12521. Commit ready to merge. Should only be applied after r12521. 
- Legacy-Id: 12540
 2016-12-15 19:30:36 +00:00
Henrik Levkowetz 98b15c8240 Merged in [12518] from rjsparks@nostrum.com: 
Fixes href() for bluesheets. Fixes #2107.  Will patch into production
 - Legacy-Id: 12539
Note: SVN reference [12518] has been migrated to Git commit 18fdfc0617
 2016-12-15 18:21:15 +00:00
Henrik Levkowetz 84bfdde831 Merged in [12506] from rjsparks@nostrum.com: 
Show the review requester on review team summary pages. Fixes #2095.
 - Legacy-Id: 12538
Note: SVN reference [12506] has been migrated to Git commit 962e3f8443
 2016-12-15 17:04:27 +00:00
Henrik Levkowetz 51fedbf483 Merged in [12505] from rjsparks@nostrum.com: 
Disallow requesting directorate reviews of RFCs (such things would better be done with reviews of status change documents). Fixes #2065.
 - Legacy-Id: 12537
Note: SVN reference [12505] has been migrated to Git commit 1ea983a1c2
 2016-12-15 16:31:36 +00:00
Henrik Levkowetz 65481b5df7 Moved warnings settings from manage.py and test_runner.py to one single place, settings.py. Decreased the verbosity level when invoking 'loaddata' from the test runner. 
- Legacy-Id: 12535
 2016-12-15 13:25:20 +00:00
Henrik Levkowetz fec5772f9a Deprecation fix: Pass the result of active_review_teams() to a Role.objects query, instead of passing the function. 
- Legacy-Id: 12534
 2016-12-15 13:23:16 +00:00
Henrik Levkowetz 17a7f59cd6 Deprecation fixes: Use request.GET or request.POST as appropriate, instead of request.REQUEST. 
- Legacy-Id: 12533
 2016-12-15 13:21:33 +00:00
Henrik Levkowetz ff9b8a9bdb Deprecation fixes: Explicitly say that redirects are permanent. 
- Legacy-Id: 12532
 2016-12-15 13:19:51 +00:00
Henrik Levkowetz cc333d9430 Changed method of retrieving an app's models. Also now importing import_module from importlib instead of from django. 
- Legacy-Id: 12531
 2016-12-15 13:17:07 +00:00
Henrik Levkowetz b3740bcfca Removed instances of 'load future' from templates that don't need it any more. 
- Legacy-Id: 12530
 2016-12-15 13:14:16 +00:00
Henrik Levkowetz 173f5419ac Changed the state shown in all_id.txt for drafts which have entered IESG processing, but then been replaced, to show as 'Replaced' instead of 'In IESG Processing'. This is consistent with how they are shown in all_id2.txt. 
- Legacy-Id: 12529
 2016-12-15 10:44:23 +00:00
Henrik Levkowetz 8e56935cfd Undid commit 12527, which contained much too much. 
- Legacy-Id: 12528
 2016-12-15 10:38:54 +00:00