If a review is suggested on the "manage unassigned reviews" page, and
the document is in both last call and telechat, the assign form now asks
for the type of review that should be assigned.
This commit also fixes two bugs in this process:
- Comparisons in some cases between strings and integers
(group/views.py:1485/1487)
- Rejections when assigning suggested reviews, as they could be
considered a newly opened request due to not having a pk
(group/views.py:1508)
Commit ready for merge.
- Legacy-Id: 16933
Fix#2217 - Allow submission of unsolicited reviews by secretaries.
- For team secretaries, a button 'Submit unsolicited review' will now
appear next to 'Request review' on the document's main page.
- If the secretary is a secretary for multiple teams, they are taken
through an intermediate page to select for which team they are
submitting their review.
- The form is similar (and using the same code) as the usual review
completion, with a few extra fields for the review type and reviewer,
which would usually already be known.
- When submitting the review, a ReviewRequest and ReviewAssignment are
automatically created. The assignment is then immediately closed in
the usual way.
- Other workflows are unchanged.
The issues with the review form in #2061 are slightly worse for the
unsolicited review scenario, but that will be improved when #2061 is
fixed.
- Legacy-Id: 16932
Note: SVN reference [16924] has been migrated to Git commit 871a4b653b
Fix#2087 - Show doc authors and WG chairs in unassigned reviews views.
- Legacy-Id: 16931
Note: SVN reference [16923] has been migrated to Git commit 93797b3fc1
- For team secretaries, a button "Submit unsolicited review" will now
appear next to "Request review" on the document's main page.
- If the secretary is a secretary for multiple teams, they are taken
through an intermediate page to select for which team they are
submitting their review.
- The form is similar (and using the same code) as the usual review
completion, with a few extra fields for the review type and reviewer,
which would usually already be known.
- When submitting the review, a ReviewRequest and ReviewAssignment are
automatically created. The assignment is then immediately closed in
the usual way.
- Other workflows are unchanged.
The issues with the review form in #2061 are slightly worse for the
unsolicited review scenario, but that will be improved when #2061 is
fixed.
Commit ready for merge.
- Legacy-Id: 16924
Fix#2277 - Do not allow reviewers to reject overdue reviews.
If a review request is past the deadline, reviewers will no longer be
able to reject the assignment.
- Legacy-Id: 16909
Note: SVN reference [16883] has been migrated to Git commit 3c2b01b3ff
Adds docs with blocking positions to the ADs my-documents page. Fixes#2800.
- Legacy-Id: 16906
Note: SVN reference [16875] has been migrated to Git commit f7d4600371b3f2a3c92aa184b517ed4ebee3a118
Add submitted and posted dates to several ipr notification email messages. Fixes#2807.
- Legacy-Id: 16899
Note: SVN reference [16853] has been migrated to Git commit f39d1568f0c4a8f4b1ebd3dee887fff6b3d8049b
Fix#2331 - Show stacked bar graph for in time and late reviews.
On the stats page, a single stacked bar graph is now shown which
combines in time and late reviews, replacing the separate graphs for
these statistics.
Tests for the charts are also expanded to validate the actual
graph content for both stacked and non-stacked charts.
- Legacy-Id: 16898
Note: SVN reference [16852] has been migrated to Git commit f651320ef3
On the stats page, a single stacked bar graph is now shown which
combines in time and late reviews, replacing the separate graphs for
these statistics.
Tests for the charts are also expanded to validate the actual
graph content for both stacked and non-stacked charts.
Commit ready for merge.
- Legacy-Id: 16852
Link to the about pages for groups even if they don't have a charter (some have other forms of descriptive text, and all have more information on the group pages than they did a few years ago). Fixes#2744.
- Legacy-Id: 16848
Note: SVN reference [16815] has been migrated to Git commit 26e3e62c567d8146a27a976f1da0710eeda46ba2
Don't offer to propose slides when the next view will not allow you to propose slides. Fixes#2763.
- Legacy-Id: 16847
Note: SVN reference [16813] has been migrated to Git commit 1ec4f7f41e6bf9945c4e4e5a55d50f7535b0fbbc
Fix#2475 - Send opt-in reminders for unconfirmed review assignments.
If enabled for a team, reminders will be sent every X days to reviewers
for review assignments they have not accepted or rejected.
- Legacy-Id: 16846
Note: SVN reference [16792] has been migrated to Git commit 486b6daa29
Improve alerts when looking at non-current versions of a charter document. Fixes#2774.
- Legacy-Id: 16845
Note: SVN reference [16785] has been migrated to Git commit 07637c27e1a76d3cbb92cc22b987b9f1426d8d52
Refs #2277 - Send daily reminders of overdue reviews to secretaries
- Legacy-Id: 16839
Note: SVN reference [16765] has been migrated to Git commit cc64992204
Fix#2337 - Send periodic reminders of open reviews every X days (opt-in)
The interleaved_migrations_test currently fails due to the various
migrations that have been added for individual tickets/commits (unless
--permit-mixed-migrations is set). I think this is better fixed in a
later cleanup, as doing it now could cause confusion when merging
individual commits, and more migrations are likely to be added soon.
- Legacy-Id: 16823
Note: SVN reference [16705] has been migrated to Git commit ec56a03ec6
Fix#2231 - Send reminders before long UnavailabilityPeriods expire
A notification is sent to the team secretary and reviewer, if an
unavailability period lasting 30 days or more will end in 3 days.
- Legacy-Id: 16822
Note: SVN reference [16704] has been migrated to Git commit 179c151f9e
Fix#2478 - When completing review, show which addresses it is posted to.
- Legacy-Id: 16795
Note: SVN reference [16688] has been migrated to Git commit 68ea11a916
If enabled for a team, reminders will be sent every X days to reviewers
for review assignments they have not accepted or rejected.
Commit ready for merge.
- Legacy-Id: 16792
Corrected a view that was looking at review assignment ids when it should have been looking at request review ids. Fixes#2776.
- Legacy-Id: 16708
Note: SVN reference [16647] has been migrated to Git commit 87de06c97c
The interleaved_migrations_test currently fails due to the various
migrations that have been added for individual tickets/commits (unless
--permit-mixed-migrations is set). I think this is better fixed in a
later cleanup, as doing it now could cause confusion when merging
individual commits, and more migrations are likely to be added soon.
Commit ready for merge.
- Legacy-Id: 16705
A notification is sent to the team secretary and reviewer, if an
unavailability period lasting 30 days or more will end in 3 days.
Commit ready for merge.
- Legacy-Id: 16704
Improved so that new draft diffs (from the working group drafts page) work correctly for both -00 drafts and later revisions. Fixes issue #2697.
- Legacy-Id: 16693
Note: SVN reference [16614] has been migrated to Git commit 390ff04722
Look at all scheduled sessions for a group when deciding to display a cancelled banner. Fixes#2764.
- Legacy-Id: 16691
Note: SVN reference [16604] has been migrated to Git commit aea3c1a55b1b14f9da90d0cfb03891e7129f8632
Use unversioned slide link from the materials popup from the agenda page. Fixes#2756.
- Legacy-Id: 16612
Note: SVN reference [16594] has been migrated to Git commit 51a874dec4a06a707eb3547f6dd443cfbed94bd4
Change how the session details page links to documents to not link to a specific version. Fixes#2758. See also #2756.
- Legacy-Id: 16610
Note: SVN reference [16592] has been migrated to Git commit c6c086b122dbd57cb6a55ed7f68be4a8dfd877b6
Example of using webtest. The full testcase was not converted because the add_rule form is modified in-flight by javascript when a control value is changed.
- Legacy-Id: 16609
Note: SVN reference [16590] has been migrated to Git commit e89f200abc0d9af7609e4bff3592f87eddee1359
Add quotes around document name in the mailarchive search link on a document's main page. Fixes#2659.
- Legacy-Id: 16606
Note: SVN reference [16569] has been migrated to Git commit b4a40313c95511693ae8a361aabb355878555fb7
Show a calendar of upcoming meetings. Fixes#2719.
- Legacy-Id: 16602
Note: SVN reference [16589] has been migrated to Git commit d3b70a46b882979fabb82972921a6ad177c06b08
Added Closing Notes to history and about pages for groups. Fixes issue #2725.
- Legacy-Id: 16586
Note: SVN reference [16559] has been migrated to Git commit 93b4d6fcc4
Partially addresses issue #1926 still displaying markdown as text. Fixes#2704.
- Legacy-Id: 16576
Note: SVN reference [16557] has been migrated to Git commit f76c46bef0
Rework how SlideSuggestion objects name their files. Improve the UI when there are multiple pending suggestions for updating the same presentation.
- Legacy-Id: 16570
Note: SVN reference [16554] has been migrated to Git commit 1e8eb0ed6d227e32816c4bc352a7301691eaaaac
primary keys from character strings to integers, and makes corresponding code
changes.
This was prompted by database limitations discovered when trying to make
DocAlias use a m2m document field; with 255 long strings as primary keys for
Document and DocAlias this violated the MySQL database limitations.
Changing the primary keys to integers should also improve efficiency.
Due to the data migrations which create the new integer primary keys and adds
corresponding integer foreign keys matching the previous string foreign keys
in all tables having foreign keys to Document and DocAlias, some of these
migrations take a long time. The total set of migrations are expected to have
a runtime on the order of 2 hours.
- Legacy-Id: 16237
- Legacy-Id: 16163
Note: SVN reference [16124] has been migrated to Git commit e101d94065
Note: SVN reference [16154] has been migrated to Git commit 758757038a
Show minutes on the popup for the meeting materials button on the agenda page when those minutes are available. Fixes#2711.
- Legacy-Id: 16162
Note: SVN reference [16152] has been migrated to Git commit 88f49ed2b4
Update the out-of-date links in the footer of each datatracker page. Fixes#2710.
- Legacy-Id: 16156
Note: SVN reference [16145] has been migrated to Git commit d96e042bc9
Remove some clutter from I-D upload page. The information was mived to the Instructions tab, but a higligh to the Note Well and BCP 78 was added. Fixes#2057.
- Legacy-Id: 16155
Note: SVN reference [16144] has been migrated to Git commit 37851b9742
Remove some clutter from I-D upload page. The information was mived to the Instructions tab, but a higligh to the Note Well and BCP 78 was added. Fixes#2057.
- Legacy-Id: 16151
Note: SVN reference [16144] has been migrated to Git commit 37851b9742
Allow Secretariat to handle downrefs when they approve a document
- Legacy-Id: 16134
Note: SVN reference [16126] has been migrated to Git commit 8c7e75101d
Provides menubar offset for wg anchors on the /wg page. Fixes#1481.
- Legacy-Id: 16131
Note: SVN reference [16121] has been migrated to Git commit 1c04745c3e
Include the note itself in email sent when the RFC editor note changes after document approval. Also changed the flow to redirect back to the writeups pages after editing the RFC editor note. Fixes#2672.
- Legacy-Id: 16130
Note: SVN reference [16110] has been migrated to Git commit fbfd204eb9
Moved old nomcom announcements to database and removed references to legacy website. Fixes#2686.
- Legacy-Id: 16123
Note: SVN reference [16108] has been migrated to Git commit 26ebb022e7
Show the agenda note, if it exits, on a sessions SUMMARY line in the ical view of an agenda. Fixes#2676.
- Legacy-Id: 16122
Note: SVN reference [16107] has been migrated to Git commit 69acaccf14
Allow logged in users to propose slides for meeting sessions. Fixes#2547 and #2403.
- Legacy-Id: 16118
Note: SVN reference [16102] has been migrated to Git commit becad91b0b
Fixed bad calls to rfcdiff for -00 drafts and replaced drafts. Fixes issue #2697.
- Legacy-Id: 16117
Note: SVN reference [16095] has been migrated to Git commit cfdbae1f3c
Make it more obvious that a group has been replaced when looking at its pages. Fixes#2661.
- Legacy-Id: 15826
Note: SVN reference [15824] has been migrated to Git commit fdf0964c40
Whitespace only change to make the conditional structure followable.
- Legacy-Id: 15825
Note: SVN reference [15818] has been migrated to Git commit 487c35d0ae
Added an explicit ID-Exists state for the IESG state machine.
Reworked code so that the IESG state machine always has a state.
Added the ability to release a document from a working group,
research group, or the independent stream. Releasing a document
removes all stream state, and sets the document to have no stream.
- Legacy-Id: 15823
Note: SVN reference [15809] has been migrated to Git commit 6118975620
Note: SVN reference [15822] has been migrated to Git commit f6886f6105
Provide a correct link to jabber logs for plenaries in past agendas. Fixes#2641.
- Legacy-Id: 15819
Note: SVN reference [15816] has been migrated to Git commit 590e20c00f
Repaired another instance of a literal path with a reverse lookup. Related to #2657.
- Legacy-Id: 15814
Note: SVN reference [15807] has been migrated to Git commit 672b491ec3
Show counts on the active groups page and on the active wgs page. Fixes#2060.
- Legacy-Id: 15755
Note: SVN reference [15709] has been migrated to Git commit cb02df1681
Trivial fix for trivial issue #1907, warn user that added addresses will be confirmed.
- Legacy-Id: 15743
Note: SVN reference [15705] has been migrated to Git commit 4468eb523a
Notify the RFC Editor when an RFC Editor note is changed after a draft has been approved. Fixes#2440.
- Legacy-Id: 15729
Note: SVN reference [15698] has been migrated to Git commit 43374969f6
Changed wording since it is not an error for there to be two people with the same name. Fixes issue #2616.
- Legacy-Id: 15711
Note: SVN reference [15689] has been migrated to Git commit 6421ebc1de
Fixed bad variable in title of requests.html. Fixes issue #2608.
- Legacy-Id: 15707
Note: SVN reference [15688] has been migrated to Git commit 47e3ba8ba4
Verb tense used in Ballot Issued emails now matches whether the LC end date is in the past or future. Fixes issue #2482.
- Legacy-Id: 15685
Note: SVN reference [15679] has been migrated to Git commit 194d8c89d1
Added new custom API endpoints for export of person data, restricted
to secretariat use. Added a test for the new custom API.
- Legacy-Id: 15543
Note: SVN reference [15263] has been migrated to Git commit 8e7e0faf529db057ac4f7496d0bc84fb05f0625d
Note: SVN reference [15264] has been migrated to Git commit e6549635650d4d9f9a9de7c5b4711f5a4a25c42c
Note: SVN reference [15265] has been migrated to Git commit 7c0e97f824b874763550adf1647841129017bf5a
Note: SVN reference [15287] has been migrated to Git commit 7431bdfcd9f2213c812a9004162ca576ae230a94
Allow a nomcom to show nominees that have accepted nomination before feedback is open. Fixes#2598.
- Legacy-Id: 15487
Note: SVN reference [15486] has been migrated to Git commit 4d5de5dee6
