altf4arnold/datatracker
1
0
Fork 0
Code Issues Pull requests Actions 3 Packages Projects Releases Wiki Activity
12269 commits 1 branch 0 tags 2.6 GiB
Commit graph

279 commits

Author SHA1 Message Date
Henrik Levkowetz 8fcfd2073a Added a migration where Django 2.0 captures more model information than 1.11 did. 
- Legacy-Id: 17845
 2020-05-20 07:31:35 +00:00
Henrik Levkowetz bc05e7a8d0 Refactored many instances of msg.get_payload(decode=True).decode('utf-8') and similar to get_payload_text(msg), which uses msg.get_charset() to get the actual charset to do the decoding, in a consistent manner. Also removed some instances of force_str, but more remain. 
- Legacy-Id: 17807
 2020-05-16 20:20:05 +00:00
Henrik Levkowetz 2b68095b82 Merged in [17794] from mark@painless-security.com: 
Add the 'msg' variable for interpolation on reviewer availability change emails, and reformat the add-a-period email.  Fixes #2891.
 - Legacy-Id: 17799
Note: SVN reference [17794] has been migrated to Git commit 96bc71f51f150cec7043aca60d0156d35847019b
 2020-05-15 11:33:03 +00:00
Henrik Levkowetz 9aeda11a29 Removed some Py2 compatibility decorators. 
- Legacy-Id: 17673
 2020-04-21 13:54:31 +00:00
Henrik Levkowetz 02e0ccf441 Removed a renamed migration 
- Legacy-Id: 17620
 2020-04-14 19:29:09 +00:00
Henrik Levkowetz f10ddadc0e Merged in changes from trunk up to r17584. 
- Legacy-Id: 17593
 2020-04-07 16:02:52 +00:00
Henrik Levkowetz 87bf4e8d58 Make sure to strip possible mail header field values of whitespace before applying email.utils.unquite(). Resolution by kivinen@iki.fi, Fixes issue #2899. 
- Legacy-Id: 17485
 2020-03-21 17:34:37 +00:00
Henrik Levkowetz 89ec88dd7d - Legacy-Id: 17401 2020-03-07 12:46:53 +00:00
Henrik Levkowetz a69ffdc87a Added a migration 
- Legacy-Id: 17399
 2020-03-06 21:01:13 +00:00
Henrik Levkowetz 726fcbf27d Removed all __future__ imports. 
- Legacy-Id: 17391
 2020-03-05 23:53:42 +00:00
Henrik Levkowetz ab173cb2eb Removed further six usage: six.string_types, six.integer_types, six.moves.urllib instances. 
- Legacy-Id: 17390
 2020-03-05 20:46:58 +00:00
Henrik Levkowetz e9a37d8ac8 Removed six.text_type(), changed six.moves.urllib to plain urllib, and removed now unused six imports. 
- Legacy-Id: 17385
 2020-03-05 14:41:41 +00:00
Henrik Levkowetz af6ca37513 Admin model tweak, added a raw_id_field. 
- Legacy-Id: 17382
 2020-03-03 21:00:35 +00:00
Henrik Levkowetz 941a27bf72 Fixed a Py2/3 issue with review.mailarchive.construct_query_url(). 
- Legacy-Id: 17379
 2020-03-03 17:00:13 +00:00
Henrik Levkowetz 1017c21167 Renamed a migration to conform to migration naming conventions, using underscores instead of dashes in the name. 
- Legacy-Id: 17376
 2020-03-03 12:22:48 +00:00
Henrik Levkowetz 0487cfce3e Changed ReviewerSettings history change-reason field to TextField 
- Legacy-Id: 17184
 2020-01-06 18:50:36 +00:00
Henrik Levkowetz 49fc0d7a71 Change varchar(100) to text field for HistoricalReviewerSettings.history_change_reason, to accomodate longer change descriptions. 
- Legacy-Id: 17171
 2019-12-21 19:56:16 +00:00
Henrik Levkowetz d9c19449ce Fixed a migration overlap issue. 
- Legacy-Id: 17123
 2019-12-05 18:04:37 +00:00
Henrik Levkowetz fcb6806d17 Merged in work from sasha@dashcare.nl on Review Queue Managemnt: 
This abstracts queue management, making it possible to implement different
policies for each team. It provides two concrete policies:
RotateAlphabeticallyReviewerQueuePolicy, which rotates an alphabetically
ordered reviewer list with consideration for skip indications, and is the
default policy; and LeastRecentlyUsedReviewerQueuePolicy, a simple
least-recently-used policy.  Also see issues #2721 and #2656.
 - Legacy-Id: 17121
 2019-12-04 23:02:52 +00:00
Henrik Levkowetz fc0060079a Merged in [17085] from sasha@dashcare.nl: 
Fix #2278 - Notify secretary when a review request is closed.
The assigned reviewer was already notified, but secretaries were always
excluded.
 - Legacy-Id: 17108
Note: SVN reference [17085] has been migrated to Git commit 56003f66d8
 2019-11-27 22:19:58 +00:00
Henrik Levkowetz 7ec09554bb Merged in [17069] from sasha@dashcare.nl: 
Fix #2074, fix #2358 - Add history for assignments, requests and unavailability.
 - Legacy-Id: 17104
Note: SVN reference [17069] has been migrated to Git commit 65d84155b6
 2019-11-26 16:09:43 +00:00
Sasha Romijn 9e2dfbfe7f Fix review migration issue caused by merge 
- Legacy-Id: 17095
 2019-11-22 12:40:03 +00:00
Sasha Romijn 10a7bee637 Merge reviewer-queue-management on top of 6.111.1.dev0 
- Legacy-Id: 17094
 2019-11-22 12:35:28 +00:00
Sasha Romijn b64066b742 Fix LeastRecentlyUsed policy ordering. 
- Legacy-Id: 17092
 2019-11-22 11:00:58 +00:00
Sasha Romijn 384c0ac7af Improve LeastRecentlyUsed performance with select_related() fix 
- Legacy-Id: 17091
 2019-11-22 10:05:51 +00:00
Sasha Romijn 6bf7d15b70 Add a limit to the update_policy_state_for_assignment loop to prevent 
infinite loops, e.g. when a team has only a single reviewer.
 - Legacy-Id: 17087
 2019-11-21 12:37:02 +00:00
Sasha Romijn 084978e105 Fix issue where reviewers that left the team would be included in LeastRecentlyUsed 
- Legacy-Id: 17086
 2019-11-21 11:24:33 +00:00
Sasha Romijn 56003f66d8 Fix #2278 - Notify secretary when a review request is closed. 
The assigned reviewer was already notified, but secretaries were always
excluded.

Commit ready for merge.
 - Legacy-Id: 17085
 2019-11-21 11:03:21 +00:00
Henrik Levkowetz 424dcfb42d Some tweaks related to the changes related to #2830. 
- Legacy-Id: 17076
 2019-11-21 06:01:56 +00:00
Henrik Levkowetz f0adebbe70 Merged in [17062] from rjsparks@nostrum.com: 
Change the default template for assigned review emails to name the assigned reviewer. Fixes #2830.
 - Legacy-Id: 17073
Note: SVN reference [17062] has been migrated to Git commit 38e73b6f89
 2019-11-21 01:32:10 +00:00
Sasha Romijn 65d84155b6 Fix #2074, fix #2358 - Add history for assignments, requests and unavailability. 
Commit ready for merge.
 - Legacy-Id: 17069
 2019-11-20 11:29:14 +00:00
Robert Sparks 38e73b6f89 Change the default template for assigned review emails to name the assigned reviewer. Fixes #2830. Commit ready for merge. 
- Legacy-Id: 17062
 2019-11-19 21:27:23 +00:00
Sasha Romijn 3db8a0f39d Fix issue where queue might not advance correctly while managing 
unassigned reviews, when some reviewers have a skip count.
 - Legacy-Id: 17060
 2019-11-19 11:53:12 +00:00
Sasha Romijn b1eb2643f0 Cleanup. Branch ready for merge. (see email) 
- Legacy-Id: 17059
 2019-11-19 11:14:29 +00:00
Sasha Romijn 0c0980c641 Fix #2420 - Add reviewer back to top of the queue after rejected/withdrawn reviews. 
- Legacy-Id: 17058
 2019-11-19 10:57:56 +00:00
Sasha Romijn 8bb6955d47 Fix #2418 - Account for previous rejected reviews in recommended assignment order 
- Legacy-Id: 17053
 2019-11-18 19:50:33 +00:00
Sasha Romijn abedd2d970 Add support for setting reviewer queue policies per team. 
- Legacy-Id: 17052
 2019-11-18 17:29:25 +00:00
Sasha Romijn 57ec2b3ef8 Add LeastRecentlyUsed reviewer queue policy. 
- Legacy-Id: 17049
 2019-11-18 14:47:45 +00:00
Sasha Romijn 554a839864 Fix #2336 - Add "select me next for an assignment". 
Reviewers can set this flag in their reviewer settings, which triggers
a mail to be sent to the secretary. They are then kept on top of the
recommended assignment order. This flag is automatically reset when any
assignment is made to the reviewer.
 - Legacy-Id: 17048
 2019-11-18 12:30:11 +00:00
Sasha Romijn e188da5214 Remove development print statements and rename policy. 
This should now be a finished implementation of
https://trac.tools.ietf.org/tools/ietfdb/wiki/ReviewerQueuePolicy
except for missing LeastRecentlyUsed.
 - Legacy-Id: 17047
 2019-11-18 10:40:59 +00:00
Sasha Romijn c5ecfab29f Account for previous reviews of ancestor documents (see [16981]) 
- Legacy-Id: 17046
Note: SVN reference [16981] has been migrated to Git commit f740adcfc1
 2019-11-18 10:27:18 +00:00
Tero Kivinen b5d864499f Added two new configuration settings for the review team secretary, 
one to set how many days to include in the reviewers list, and
another one to limit the number of completed items in the list for
each person. This version replaces the one I did earlier, and includes
much more test cases to test different limits on the reviewers page.
Commit ready for merge.
 - Legacy-Id: 17034
 2019-11-16 09:41:55 +00:00
Sasha Romijn c36fcdc5a7 Update update_policy_state_for_assignment for new policies, fix tests, 
fix some other minor things.
 - Legacy-Id: 17023
 2019-11-13 14:39:42 +00:00
Sasha Romijn c8812c7193 Account for 'canfinish' unavailabilities. 
- Legacy-Id: 16999
 2019-11-12 12:11:52 +00:00
Sasha Romijn 1c84e3c363 Add additional tests for queue policies and fix unused import. 
- Legacy-Id: 16990
 2019-11-11 16:32:49 +00:00
Sasha Romijn 6b85d5aff1 - Remove consideration of unavailability from ranking for recommended 
assignment order, as it is obsolete
- Add test for recommended assignment order
 - Legacy-Id: 16989
 2019-11-11 16:05:11 +00:00
Sasha Romijn ce812a3a4f - Make skipping unavailable reviews the default, except for the 
reviewer_overview page.
- Make default_reviewer_rotation_list use a consistent return type
 - Legacy-Id: 16986
 2019-11-11 14:47:37 +00:00
Sasha Romijn 48f72f2501 Add tests for default reviewer rotation list. 
- Legacy-Id: 16984
 2019-11-11 13:48:06 +00:00
Sasha Romijn b5a31c3c6a Update some terminology and docstrings. 
- Legacy-Id: 16983
 2019-11-11 12:31:16 +00:00
Robert Sparks f740adcfc1 Look at the tree of replaces-relationships when determining if some reviewer has reviewed this (or perhaps an ancestor) of this document. Fixes #2821. Commit ready for merge. 
- Legacy-Id: 16981
 2019-11-07 23:02:19 +00:00