primary keys from character strings to integers, and makes corresponding code
changes.
This was prompted by database limitations discovered when trying to make
DocAlias use a m2m document field; with 255 long strings as primary keys for
Document and DocAlias this violated the MySQL database limitations.
Changing the primary keys to integers should also improve efficiency.
Due to the data migrations which create the new integer primary keys and adds
corresponding integer foreign keys matching the previous string foreign keys
in all tables having foreign keys to Document and DocAlias, some of these
migrations take a long time. The total set of migrations are expected to have
a runtime on the order of 2 hours.
- Legacy-Id: 16237
Remove some clutter from I-D upload page. The information was mived to the Instructions tab, but a higligh to the Note Well and BCP 78 was added. Fixes#2057.
- Legacy-Id: 16151
Note: SVN reference [16144] has been migrated to Git commit 37851b9742
Added a mail alias for all review team secretaries. Fixes#2139. Use
the alias if there is one for email about review request changes. Added
a test for the review team secretary alias functionality.
- Legacy-Id: 15747
Note: SVN reference [15708] has been migrated to Git commit 6067dcbfef
Note: SVN reference [15730] has been migrated to Git commit d525ade0b0
Added a mail alias for all review team secretaries. Fixes#2139. Use
the alias if there is one for email about review request changes. Added
a test for the review team secretary alias functionality.
- Legacy-Id: 15746
Note: SVN reference [15708] has been migrated to Git commit 6067dcbfef
Note: SVN reference [15730] has been migrated to Git commit d525ade0b0
Added easier to detect error message when search returns 0 results. This currently parses html result from the mailarchive system, but when we get proper API to mailarchive system it should be changed to do that instead. Fixes#2126.
- Legacy-Id: 15744
Note: SVN reference [15706] has been migrated to Git commit f9eeee0cc9
Changed format of the reviewer statistics in lists. Fixes#2131.
- Legacy-Id: 15735
Note: SVN reference [15701] has been migrated to Git commit 56acd00c6c
in a database table:
- Added a GroupFeatures model to the group models, and removed the old
features.py
- Added a agenda type for future use in showing different group types on
different agendas.
- Renamed the group feature has_materials to has_nonsession_materials.
- Added API resources and admin support for the new tables.
- Added a Directorate (with reviews) group type as complement to
Directorate, to distinguish between directorates with and without reviews.
- Adjusted tests as needed.
- Updated the fixtures, and fixed the generate_fixtures script to include
the new AgendaTypeName objects.
There still exists about 70 instances of code comparing the group type
with a list of types; most of these should probably be replaced with new
features, instead, to make it possible to add new group types through the
database table, rather than having to edit the code. That was the purpose
of this refactoring from the start, but the presence of this large number
of comparisons of group type against lists of types defeats the goal until
we add appropriate features and replace the group type list comparisons.
- Legacy-Id: 15316
Modified UserFactory to use a new locale for each new user, instead of the
same locale for a whole test run. This (almost) ensures the exercise of
code to deal with non-ascii names, something which would not happen if a
locale with ascii names was chosen at the start of a run.
Modified name.initials() to not use non-word characters as initials.
Modified unidecode_name() to do more normalization, to conform to the
conventions used in internet-drafts.
Added saving of the factory-boy random state in order to be able to re-run
a test suite with the same pseudo-random sequence as in a previous failed
run.
Fixed an issue with email formatting in test_api_submit_ok().
Modified the draft author extraction code to deal better with names with
embedded apostrophes.
- Legacy-Id: 14141
Reworked how review assigments are processed in order to ensure a team's queue rotates when it should. Fixes#2305.
- Legacy-Id: 13743
Note: SVN reference [13731] has been migrated to Git commit 7f5cef056ade1641f1d815b0a5f35962077d6d01
Add an expertise field to reviewer settings. Fixes#2308. ,
- Legacy-Id: 13539
Note: SVN reference [13532] has been migrated to Git commit d845fba8bec765f2f81ae1a4bbca52c9bceb6e02
Provide assigned dates on review team reviewers page. Fixes#2304. Related to #2305.
- Legacy-Id: 13518
Note: SVN reference [13500] has been migrated to Git commit e422717f91eb26a0691347beca9380889d8ee890
DocumentAuthor, rename author field to email and make it optional (for
modeling old email-less submissions), remove the authors many to many
referencing field from Document as it is not really pointing the right
place.
Update the Secretariat tools to show affiliation and country.
Add migration for getting rid of the fake email addresses that the
migration script created some years ago (just set the author email
field to null).
- Legacy-Id: 12739
Show other completed reviews of a document on page showing the status of a review request. Fixes#2083.
- Legacy-Id: 12605
Note: SVN reference [12596] has been migrated to Git commit 2bad0b0bcd
Send mail to team secretaries when a review is explicitly requested. Change the From and Subject for assignment emails to reviewers to make it clearer what the review is for and who assigned it. Fixes#2053 and #2114.
- Legacy-Id: 12602
Note: SVN reference [12593] has been migrated to Git commit 10f4892eae
Missed adding a migration to svn for r12521. Should only be applied after r12521.
- Legacy-Id: 12591
Note: SVN reference [12540] has been migrated to Git commit 68bdff6fd5
Removes classes obviated in r12520. Should be held for release after r12520 is released?
- Legacy-Id: 12590
Note: SVN reference [12521] has been migrated to Git commit 483d9db895
allow ads and secretaries to edit the review request comment. Fixes#2096. (Again).
- Legacy-Id: 12550
Note: SVN reference [12549] has been migrated to Git commit 32b431cf24
Allow a review request to include a comment to show to the review team secretary at assignment time and the reviewer at review time. Fixes#2096.
- Legacy-Id: 12548
Note: SVN reference [12545] has been migrated to Git commit 6fcd8b8a16
Slight refactor of the review models to capture review team settings. Allows configuring review teams to get automatic suggestions for reviews or not. Provides a better admin for creating/managing review teams. Fixes#2048 and #2072.
- Legacy-Id: 12544
Note: SVN reference [12520] has been migrated to Git commit b24bdb5bc3
Disallow requesting directorate reviews of RFCs (such things would better be done with reviews of status change documents). Fixes#2065.
- Legacy-Id: 12537
Note: SVN reference [12505] has been migrated to Git commit 1ea983a1c2
Add missing team constraint in the check for previous reviews by a
reviewer.
- Legacy-Id: 12481
Note: SVN reference [12479] has been migrated to Git commit 3f98a1a182
possible, also add an extra assignment fallback using deadline =
assignment time + 30 days for early reviews that never had a deadline
(a few left in secdir)
- Legacy-Id: 12381
and instead provide more information about each document to be
reviewed, to help the secretaries determine locally on that page what
action to take. The new layout should also make it easier to fit in
more info, in case it is still found lacking.
The public review request page still provides the previous information
in the summarized tabular form, so the overview can be found there.
- Legacy-Id: 12278
"Unknown" instead of auto-closing those where the IESG state is
further in the process on - this seems to leave more requests in
genart open, but hopefully the extra data for genart will fix this
problem shortly.
- Legacy-Id: 12247
review types so that teams will only have those review types
listed and suggested that they are configured to have.
Fix a couple of things in the importer after having tested it on all
the databases. Set unavailable end date >= 2020 to indefinite.
Fix a couple of bugs.
- Legacy-Id: 12095
the triggering event happened - this is probably only marginally
useful at the moment, but could perhaps be used for statistics later
on (e.g. comparing earliest possible request time vs. assignment time)
- Legacy-Id: 12085
requests for a given set of teams/reviewers (making it trivial to
compute statistics), revamp the related doc event code to support this
by referencing the review request directly, add a reviewer overview
page with recent performance for each reviewer as well as
settings/unavailable periods. Fix some bugs and shuffle some of the
review code a bit around.
Finish the importer from the previous Perl-based review tool,
importing log entries, figuring out whether a given review is
early/telechat/last call and fixing corner cases.
- Legacy-Id: 12080
relying on when they last reviewed. In-order assignments automatically
move the rotation forwards while out-of-order assignments increment
the skip next of the assigned reviewer. Include rotation in open
review assignments email. Fix a couple of issues in the importer.
- Legacy-Id: 12015