Commit graph

474 commits

Author SHA1 Message Date
Henrik Levkowetz a84ae9a10d Added a migration to capture changes to HistoricalRecords triggered by changes in django-simple-history
- Legacy-Id: 15836
2018-12-19 08:02:45 +00:00
Henrik Levkowetz c8e15fad50 Fixed a pyflakes issue
- Legacy-Id: 15830
2018-12-18 14:45:48 +00:00
Henrik Levkowetz 1bddfdffa5 Removed an assertion for iesg state for documents that can be in any stream.
- Legacy-Id: 15827
2018-12-17 14:03:55 +00:00
Henrik Levkowetz a1fc8722f2 Merged in [15824] from rjsparks@nostrum.com:
Make it more obvious that a group has been replaced when looking at its pages. Fixes #2661.
 - Legacy-Id: 15826
Note: SVN reference [15824] has been migrated to Git commit fdf0964c40
2018-12-16 20:43:12 +00:00
Robert Sparks fdf0964c40 Make it more obvious that a group has been replaced when looking at its pages. Fixes #2661. Commit ready for merge.
- Legacy-Id: 15824
2018-12-14 22:25:55 +00:00
Henrik Levkowetz e37303b441 Merged in [15822] and [15809] from rjsparks@nostrum.com:
Added an explicit ID-Exists state for the IESG state machine.
    Reworked code so that the IESG state machine always has a state.
    Added the ability to release a document from a working group,
    research group, or the independent stream. Releasing a document
    removes all stream state, and sets the document to have no stream.
 - Legacy-Id: 15823
Note: SVN reference [15809] has been migrated to Git commit 6118975620

Note: SVN reference [15822] has been migrated to Git commit f6886f6105
2018-12-14 22:17:58 +00:00
Henrik Levkowetz f65fcdd2c4 Merged in [15804] from rjsparks@nostrum.com:
Add history to ReviewerSettings. Fixes #2147.
 - Legacy-Id: 15811
Note: SVN reference [15804] has been migrated to Git commit cb707248e2
2018-12-13 14:29:58 +00:00
Robert Sparks 6118975620 Added an explicit ID-Exists state for the IESG state machine. Reworked code so that the IESG state machine always has a state. Added the ability to release a document from a working group, research group, or the independent stream. Releasing a document removes all stream state, and sets the document to have no stream.
- Legacy-Id: 15809
2018-12-11 22:38:05 +00:00
Robert Sparks cb707248e2 Add history to ReviewerSettings. Fixes #2147. Commit ready for merge.
- Legacy-Id: 15804
2018-12-03 22:23:01 +00:00
Henrik Levkowetz 44e28707cc Merged in [15709] from rjsparks@nostrum.com:
Show counts on the active groups page and on the active wgs page. Fixes #2060.
 - Legacy-Id: 15755
Note: SVN reference [15709] has been migrated to Git commit cb02df1681
2018-11-12 12:24:41 +00:00
Henrik Levkowetz 98015a64f2 Merged in [15683] and [15699] from housley@vigilsec.com:
Do not show reasons for review team member unavailability outside the team. Fixes #2614.
 - Legacy-Id: 15732
Note: SVN reference [15683] has been migrated to Git commit 6ff552640e

Note: SVN reference [15699] has been migrated to Git commit 895aa0cfbe
2018-11-06 14:43:58 +00:00
Robert Sparks cb02df1681 Show counts on the active groups page and on the active wgs page. Fixes #2060. Commit ready for merge.
- Legacy-Id: 15709
2018-11-04 01:33:34 +00:00
Russ Housley 895aa0cfbe Commit ready for merge.
- Legacy-Id: 15699
2018-11-03 08:41:23 +00:00
Russ Housley 6ff552640e Do not show reasons for review team member unavailability outside the team. Fixes #2614. Commit ready for merge.
- Legacy-Id: 15683
2018-11-03 04:24:32 +00:00
Robert Sparks 16ae849d68 Only do state-parent cross-validation on the group edit form when both fields are used on the form. (Many invocations of the form suppress all but one field.) Fixes #2597. Commit ready for merge.
- Legacy-Id: 15681
2018-11-03 03:55:53 +00:00
Henrik Levkowetz caa3ec98b4 Changed the menu listing of review dirs and their display on the Directorates page back to what it was before the 'reviews' group type was split out. Added a 'Reviews' column to the Directoratges page.
- Legacy-Id: 15420
2018-08-01 18:53:44 +00:00
Henrik Levkowetz 0c732d6538 Guard against comparing email origin with username of None.
- Legacy-Id: 15419
2018-07-31 14:27:31 +00:00
Henrik Levkowetz 6350f92ed1 Merged in [15370] from rjsparks@nostrum.com:
Use factories for ietf.group.tests_review.
 - Legacy-Id: 15404
Note: SVN reference [15370] has been migrated to Git commit 61932cbc9e
2018-07-24 06:14:47 +00:00
Henrik Levkowetz 2e83c529b1 Merged in [15355] from rjsparks@nostrum.com:
Used factories for ietf.group.tests_info.
 - Legacy-Id: 15398
Note: SVN reference [15355] has been migrated to Git commit 5a0b005939
2018-07-19 15:54:53 +00:00
Henrik Levkowetz ed208a5ebb Merged in [15342] from peter@akayla.com:
Added optional reviewer unavailability reason support.  Fixes issue #2146.
 - Legacy-Id: 15375
Note: SVN reference [15342] has been migrated to Git commit f4eba7d4df
2018-07-17 15:27:20 +00:00
Robert Sparks 61932cbc9e Use factories for ietf.group.tests_review. Commit ready for merge.
- Legacy-Id: 15370
2018-07-16 21:07:03 +00:00
Robert Sparks 5a0b005939 Used factories for ietf.group.tests_info. Commit ready for merge.
- Legacy-Id: 15355
2018-07-14 22:03:11 +00:00
Henrik Levkowetz 3807299eee Merged in [15321] from rjsparks@nostrum.com:
Converted ietf.group.tests to factories.
 - Legacy-Id: 15350
Note: SVN reference [15321] has been migrated to Git commit 5b1a68a922
2018-07-14 20:58:09 +00:00
Peter E. Yee f4eba7d4df Added optional reviewer unavailability reason support. Fixes issue #2146. Commit ready for merge.
- Legacy-Id: 15342
2018-07-14 18:04:31 +00:00
Henrik Levkowetz 991c7a5e54 Captured another GroupFeatures model tweak.
- Legacy-Id: 15330
2018-07-14 16:26:11 +00:00
Henrik Levkowetz 8783fb11ab Fixed a migration ordering issue
- Legacy-Id: 15322
2018-07-13 03:40:32 +00:00
Robert Sparks 5b1a68a922 Converted ietf.group.tests to factories. Commit ready for merge.
- Legacy-Id: 15321
2018-07-12 21:23:50 +00:00
Henrik Levkowetz 2daef52bea This commit replaces the code defined group features with features held
in a database table:

- Added a GroupFeatures model to the group models, and removed the old 
  features.py
- Added a agenda type for future use in showing different group types on
  different agendas.
- Renamed the group feature has_materials to has_nonsession_materials.
- Added API resources and admin support for the new tables.
- Added a Directorate (with reviews) group type as complement to
  Directorate, to distinguish between directorates with and without reviews.
- Adjusted tests as needed.
- Updated the fixtures, and fixed the generate_fixtures script to include
  the new AgendaTypeName objects.

There still exists about 70 instances of code comparing the group type
with a list of types; most of these should probably be replaced with new
features, instead, to make it possible to add new group types through the
database table, rather than having to edit the code.  That was the purpose
of this refactoring from the start, but the presence of this large number
of comparisons of group type against lists of types defeats the goal until
we add appropriate features and replace the group type list comparisons.
 - Legacy-Id: 15316
2018-07-12 10:51:48 +00:00
Henrik Levkowetz e87442f33a Merged in [15282] from housley@vigilsec.com:
Set reply-to for I-D Announcements that include a CC to a mail list.  Fixes #2530.
 - Legacy-Id: 15289
Note: SVN reference [15282] has been migrated to Git commit 733c304e3d
2018-07-10 17:16:47 +00:00
Henrik Levkowetz c9cc9ff214 Upped the permitted number of search results for the /stream/ise/ page (and friends) from 200 to 1000. Fixes issue #2527.
- Legacy-Id: 15281
2018-06-26 16:43:40 +00:00
Robert Sparks 13df62f8ba Tweaked the color palatte for the agenda editor. Commit ready for merge.
- Legacy-Id: 15247
2018-06-13 19:58:08 +00:00
Robert Sparks dcf9e6b40f Use factories for ietf.doc.tests_ballots. Fixed a long-hidden bug in test_edit_verify_permissions where non-existing usernames were used and passed the tests accidently. Added list_email to the GroupFactory. Commit ready for merge.
- Legacy-Id: 15219
2018-06-06 17:59:40 +00:00
Robert Sparks 84d3c92298 more factoryization of ietf.doc.tests. Commit ready for merge.
- Legacy-Id: 15205
2018-06-02 13:39:39 +00:00
Henrik Levkowetz 6c3ec5b18e Added Email origin to Email record creation throughout the codebase.
- Legacy-Id: 15149
2018-05-17 16:56:26 +00:00
Henrik Levkowetz 421621eb51 Another round of iesg page optimizations. Reduced additional instances of individual lookups to a single lookup followed by annotation of document objects. Reduced several instances of repeating the same work multiple times (queries for telechat documents, queries for telechat dates).
- Legacy-Id: 15010
2018-04-05 11:03:26 +00:00
Adam Roach 3c4c0f2584 Updated (deprecated, unregistered) 'text/json' with 'application/json' everwhere. Commit ready for merge.
- Legacy-Id: 14843
2018-03-17 15:14:57 +00:00
Henrik Levkowetz fac3053d48 Fixed an issue with the milestone edit changes.
- Legacy-Id: 14762
2018-03-09 21:27:58 +00:00
Henrik Levkowetz cb051a7f59 Changed the handling of the milestone edit form to defer deletion if deletion is indicated together with other changes to the same milestone. Instead emit a warning, and ask for deletion without simultaneous changes to the milestone.
- Legacy-Id: 14761
2018-03-09 20:05:09 +00:00
Henrik Levkowetz 2c0348cc7a Found that django's urlize() does not deal well with adjacent parantheses. Replaced it with a filter based on bleach.linkify, which does better.
- Legacy-Id: 14752
2018-03-09 15:07:04 +00:00
Henrik Levkowetz 1ed8e967e7 Merged in ^/personal/henrik/6.72.1-django-1.11@14676: Upgrade to Django 1.11
- Legacy-Id: 14695
2018-02-25 19:55:16 +00:00
Henrik Levkowetz 5192440c9e Rewrote the head-of-rotation review assignment loop to guarantee that it will terminate. This should fix the 'gateway timeout' issues we've seen lately, when review request volume in some review teams have been such that multiple assignments to the head of queue members have triggered the issue.
- Legacy-Id: 14684
2018-02-22 22:18:19 +00:00
Henrik Levkowetz 26bf387356 Replaced direct assignment to m2m fields with .clear() and .set()
- Legacy-Id: 14666
2018-02-21 23:58:25 +00:00
Henrik Levkowetz 36b5e2ef8e Changed name from .rel to .remote_field for remote accessors.
- Legacy-Id: 14665
2018-02-21 23:56:36 +00:00
Henrik Levkowetz 06362ec046 Got rid of old migrations and created new initial migrations.
- Legacy-Id: 14662
2018-02-21 23:46:22 +00:00
Henrik Levkowetz 5638cf3da3 Changed all usage of ForeignKey and OneToOneFiled in model.py files to the compatibility versions from ietf.utils.models.
- Legacy-Id: 14661
2018-02-20 15:36:05 +00:00
Henrik Levkowetz 1825406695 Added a presence check before removing a list element. Addresses a 500 in unassigned review form POST.
- Legacy-Id: 14642
2018-02-14 14:32:33 +00:00
Robert Sparks 7b89db153e Take a different approach to avoiding the crash when a team secretary uses the bulk assignment form to unassign a request. Reverts r14570. Fixes #2443. Commit ready for merge.
- Legacy-Id: 14623
2018-02-07 17:58:27 +00:00
Henrik Levkowetz bf7157341f Merged in [14572] from rjsparks@nostrum.com:
Corrected the filter for closed review requests. Fixes #2152.
 - Legacy-Id: 14573
Note: SVN reference [14572] has been migrated to Git commit 68725913b5
2018-01-26 20:02:23 +00:00
Henrik Levkowetz eb6341d826 Removed the possibility of choosing '(None)' as reviewer from the bulk review request edit form; this prevents a crash on line 1474 of ietf/group/views.py, in manage_review_request(). The view code needs further care in order make it possible to unassign an assignment here.
- Legacy-Id: 14570
2018-01-25 15:58:59 +00:00
Robert Sparks 15d23299d8 Add navigation to nomcom pages for nomcom members. Put the RFC Status change link in a saner place in the navigation. Fixes #1411 and #2433. Commit ready for merge.
- Legacy-Id: 14497
2018-01-09 22:10:10 +00:00