altf4arnold/datatracker
1
0
Fork 0
Code Issues Pull requests Actions 3 Packages Projects Releases Wiki Activity
3973 commits 1 branch 0 tags 2.6 GiB
Commit graph

3973 commits

This branch
This branch
All branches
Author SHA1 Message Date
Ole Laursen 650d8316eb Make the submit tool use the access token framework with a bit of backwards compatibility glue 
- Legacy-Id: 6717
 2013-11-15 16:09:05 +00:00
Ole Laursen 6174e72036 Rename unique key to random key as it is not really unique, add function for generating an access token from the key 
- Legacy-Id: 6716
 2013-11-15 16:07:10 +00:00
Ole Laursen e98abbf56d Change the port accepted for debug purposes to 2025 instead of 1025 to 
not conflict with the port on the live server
 - Legacy-Id: 6715
 2013-11-15 13:55:10 +00:00
Ole Laursen ecf68dbb05 Revamp and clean up submit models: 
- Rename IdSubmissionDetail to Submission
- Rename various submission fields to correspond to the conventions in
  the new schema
- Use a name model for the states instead of IdSubmissionStatus
- Drop the TempIdAuthor model which is based on splitting up author
  names
- Add a simple textual SubmissionEvent for tracking events in the
  lifetime of a submission
- Delete a bunch of obsolete fields
- Make sure all submission have an access key so we can depend on it
- Add state for when approval is needed from previous authors

A couple of migrations take care of transforming the
IdSubmissionDetail and moving data over/cleaning it up.

Also revamp the submit view code:

- Make form code do validation/cleaning only so there's a clear
  separation of concerns
- Reduce uses of inheritance that made the code hard to follow -
  forms now don't inherit from each other, views don't call each other
  but instead reuse common utilities, templates share CSS/utilities
  instead of relying on inheritance
- Move email rendering/sending to separate file
- Drop the in-grown terminology use (auto post vs. manual posts)
- Make the status page explain who is emailed for what purpose
- Add history table with recorded events
- Make the status page handle its post actions by itself instead of
  duplicating most of the setup logic in a number of simple views
- Fix a couple of minor bugs and handle some edge cases better
- Expand tests with a couple of more cases

Possibly the submit tool could still use more help text added to
explain the process, ideally what's explained in the tool instructions
page should be inlined or self-evident.
 - Legacy-Id: 6714
 2013-11-15 13:30:32 +00:00
Ole Laursen fd01ddd215 Make the mail code detect USING_DEBUG_EMAIL_SERVER which if set to 
true and EMAIL_HOST and EMAIL_PORT is set to localhost:1025 will turn
on debugging which essentially makes it send emails; also added
instructions for starting the debugging SMTP server bundled with
Python

  python -m smtpd -n -c DebuggingServer localhost:1025

in a comment near the code
 - Legacy-Id: 6713
 2013-11-15 12:57:31 +00:00
Ole Laursen 322e15e9a9 Add generate_unique_key utility for generating access tokens (like 
abda31fee90aabe...)
 - Legacy-Id: 6712
 2013-11-15 12:52:33 +00:00
Ole Laursen e0be9bcb95 Remove unused and bitrotten get_authors_email 
- Legacy-Id: 6711
 2013-11-15 12:50:24 +00:00
Ole Laursen 3a483461a2 Add simple split filter, as the opposite of the built-in join filter 
- Legacy-Id: 6710
 2013-11-15 12:49:37 +00:00
Ole Laursen e6b0ef4323 Fix spelling error in validation 
- Legacy-Id: 6709
 2013-11-15 11:04:12 +00:00
Ole Laursen 8020650566 Fix color of links in form errors 
- Legacy-Id: 6700
 2013-11-11 12:52:07 +00:00
Ole Laursen 422a20fe3d Add replaces field which is apparently in the database, but not in 
models.py which confuses South
 - Legacy-Id: 6658
 2013-11-06 15:24:22 +00:00
Ole Laursen 4635c1ce0f Move helpers for the admin on IdSubmissionDetail to admin.py 
- Legacy-Id: 6657
 2013-11-06 15:23:08 +00:00
Ole Laursen b46f0ba733 Get rid of submit/error_manager.py which is apparently unused 
- Legacy-Id: 6656
 2013-11-06 15:21:19 +00:00
Ole Laursen 2daff23f02 Remove shim layer from submit code 
- Legacy-Id: 6654
 2013-11-05 16:59:13 +00:00
Ole Laursen e1708da2fe Cosmetic fix, insert missing space 
- Legacy-Id: 6646
 2013-11-04 13:49:32 +00:00
Ole Laursen a7f515f4b2 Fix link pointing to /idtracker/ 
- Legacy-Id: 6645
 2013-11-04 11:11:50 +00:00
Ole Laursen 52583aa850 Add extra newline, forgot to commit that with previous commit 
- Legacy-Id: 6489
 2013-10-25 13:55:49 +00:00
Ole Laursen d202c65835 Add tests of document placement in the agenda 
- Legacy-Id: 6488
 2013-10-25 12:54:39 +00:00
Ole Laursen 9842eef405 For no good reason, agenda_data took request as first parameter, remove this as it makes testing harder 
- Legacy-Id: 6487
 2013-10-25 12:53:54 +00:00
Ole Laursen d915a31833 Add some styling from previous adaptation of Secretariat telechat tool that were missing from the commit 
- Legacy-Id: 6467
 2013-10-18 16:42:30 +00:00
Ole Laursen 10dceef26d Refactor IESG agenda pages, put the agenda structure in a helper function in agenda.py, build the agenda up around this structure, and reuse this everywhere instead of duplicating the structure in various templates and the JSON view - this also fixes a couple of minor bugs where the copy-pasted copies were not entirely in sync 
- Legacy-Id: 6454
 2013-10-16 13:07:09 +00:00
Ole Laursen de2ed527b4 Fix indentation problem with ballot writeup in Secretariat telechat tool and fix problem with unescaped << and >> 
- Legacy-Id: 6453
 2013-10-16 12:04:27 +00:00
Ole Laursen ec7e01481d Fix a potential bug with milestones_needing_review and ad-less groups 
- Legacy-Id: 6430
 2013-10-11 14:50:30 +00:00
Ole Laursen 87aaf4a47e Remove unused idtracker import from iesg/models.py 
- Legacy-Id: 6429
 2013-10-11 14:38:50 +00:00
Ole Laursen a17c07f282 Remove unused fixtures/sieve-charter.txt 
- Legacy-Id: 6428
 2013-10-11 14:37:11 +00:00
Ole Laursen 5f337e3c70 Remove obsolete testurl.list tests from IESG, the tests in 
iesg/tests.py together with the test crawler has better coverage
 - Legacy-Id: 6427
 2013-10-11 14:35:30 +00:00
Ole Laursen 5cf8d5af6a Area_Director -> Area Director in left_menu.html 
- Legacy-Id: 6426
 2013-10-11 14:33:46 +00:00
Ole Laursen b24a20d328 Add test for /iesg/discusses/ 
- Legacy-Id: 6425
 2013-10-11 14:31:50 +00:00
Ole Laursen 1c8c87f88a Remove search for "IESG has approved and state has been changed to" 
from state change doc event searches, these have been split up by a
migration and no longer exist
 - Legacy-Id: 6424
 2013-10-11 13:19:07 +00:00
Ole Laursen 75a2c9ba0d Remove idwrapper compatibility code from ballot_icon.py 
- Legacy-Id: 6423
 2013-10-11 13:17:32 +00:00
Ole Laursen b3ed153015 Get rid of old in_group template tag, it's been superseded by has_role 
- Legacy-Id: 6422
 2013-10-11 13:13:23 +00:00
Ole Laursen b63c622564 Streamline a couple of doc helpers to prevent unnecessary DB lookups, 
speeds up IESG discusses page up a fair bit
 - Legacy-Id: 6421
 2013-10-11 13:07:16 +00:00
Ole Laursen b6c4f725b9 Fix accidental debug slicing in IESG discusses - of note is that the 
discusses page now supports more than just I-Ds
 - Legacy-Id: 6420
 2013-10-11 13:06:38 +00:00
Ole Laursen dcfe368f74 Streamline a couple of doc helpers to prevent unnecessary DB lookups, 
speeds up IESG discusses page up a fair bit
 - Legacy-Id: 6419
 2013-10-11 13:05:33 +00:00
Ole Laursen 1975ff27d0 Port IESG discusses to new schema 
- Legacy-Id: 6418
 2013-10-11 13:03:40 +00:00
Ole Laursen d11f2331fe Remove invalid text-align: top from CSS 
- Legacy-Id: 6417
 2013-10-11 13:02:08 +00:00
Ole Laursen f6ff2a8082 Delete all old WGAction stuff, it's superceded by the WG charter 
support, clean up iesg/models.py a bit
 - Legacy-Id: 6411
 2013-10-10 16:12:34 +00:00
Ole Laursen 77aa4723bf Use the right path for other document types in 
/iesg/agenda/telechat-YYYY-MM-DD-docs.tgz which now as a side-effect
of the port can bundle more than just drafts
 - Legacy-Id: 6410
 2013-10-10 15:57:00 +00:00
Ole Laursen bfde86f52b Add support for status change in Document.get_file_path, ideally 
someone would clean up the directory structure and we would transition
to something simpler
 - Legacy-Id: 6409
 2013-10-10 15:54:32 +00:00
Ole Laursen 72cc997151 Add test for /iesg/agenda/telechat-YYYY-MM-DD-docs.tgz 
- Legacy-Id: 6408
 2013-10-10 15:53:24 +00:00
Ole Laursen 21b32e72a3 Port /iesg/agenda/telechat-YYYY-MM-DD-docs.tgz, use tarfile.addfile 
and StringIO to avoid the temporary file
 - Legacy-Id: 6407
 2013-10-10 11:12:13 +00:00
Ole Laursen a81af95500 Add simple test for /iesg/agenda/documents/ 
- Legacy-Id: 6406
 2013-10-10 10:38:59 +00:00
Ole Laursen 0860342e34 Port /iesg/agenda/documents/ to new schema, fix problem with rows 
being colored for ADs with their position even if a ballot icon is not
shown (issue #1128)
 - Legacy-Id: 6405
 2013-10-10 10:31:28 +00:00
Ole Laursen a728468711 Fix some problems highlighted by the tests, making the code a bit more 
robust in case of unexpected data
 - Legacy-Id: 6402
 2013-10-09 16:28:36 +00:00
Ole Laursen bb952fa281 Add test for agenda_documents_txt 
- Legacy-Id: 6401
 2013-10-09 16:27:36 +00:00
Ole Laursen 516a5fcc92 Port /iesg/agenda/documents.txt to new schema, compose the table in 
Python instead of using a template to make the code easier to read
 - Legacy-Id: 6400
 2013-10-09 15:55:45 +00:00
Ole Laursen 53c59e56e3 Remove vary_on_cookie on agenda view, it's not needed anymore, Django 
already adds the vary: cookie header automatically
 - Legacy-Id: 6399
 2013-10-09 12:55:28 +00:00
Ole Laursen be9fd53d55 Remove the ?private thing in /iesg/agenda/, the only use of it appears 
to be agenda_package.txt and that file already includes the links that
are enabled by the flag - perhaps it predates the user modeling that
allows ADs and Secretariat to see the links
 - Legacy-Id: 6398
 2013-10-09 12:53:13 +00:00
Ole Laursen b99cf963ae Move /iesg/milestones to /iesg/milestones/, apparently the URL (by accident) didn't include the ending slash 
- Legacy-Id: 6397
 2013-10-09 12:43:45 +00:00
Ole Laursen 55c7c69679 Remove unused secr/ copy of agenda outline template (from iesg/) 
- Legacy-Id: 6396
 2013-10-09 12:41:59 +00:00