Fix a potential bug with milestones_needing_review and ad-less groups

- Legacy-Id: 6430
This commit is contained in:
Ole Laursen 2013-10-11 14:50:30 +00:00
parent 87aaf4a47e
commit ec7e01481d

View file

@ -423,7 +423,7 @@ def discusses(request):
def milestones_needing_review(request):
# collect milestones, grouped on AD and group
ads = {}
for m in GroupMilestone.objects.filter(state="review").exclude(group__state="concluded", group__ad=None).distinct().select_related("group", "group__ad"):
for m in GroupMilestone.objects.filter(state="review").exclude(group__state="concluded").exclude(group__ad=None).distinct().select_related("group", "group__ad"):
groups = ads.setdefault(m.group.ad, {})
milestones = groups.setdefault(m.group, [])
milestones.append(m)