altf4arnold/datatracker
1
0
Fork 0
Code Issues Pull requests Actions 3 Packages Projects Releases Wiki Activity
7817 commits 1 branch 0 tags 2.6 GiB
Commit graph

6450 commits

Author SHA1 Message Date
Ole Laursen 58dd25ff79 Split up open review requests on the review team page in assigned and 
unassigned requests to make it easier to just work with the unassigned
ones. Use same split on the manage reviews page which is now two
pages.
 - Legacy-Id: 12266
 2016-11-04 17:19:33 +00:00
Ole Laursen 19a3f10f69 Fix bug in telechat code, a previous rewrite to fix a possible problem 
was misguided - we should always only look at the latest telechat
event
 - Legacy-Id: 12265
 2016-11-03 23:43:01 +00:00
Ole Laursen ac1b93a8a2 Base the assignment checks on persons rather than email addresses - 
otherwise people may use a new email address and not be caught in a
check
 - Legacy-Id: 12264
 2016-11-03 21:01:41 +00:00
Ole Laursen 7461409f7f Fix bug in suggestion algorithm, it was pruning suggestions with 
review requests from all teams, not just the team under consideration
 - Legacy-Id: 12257
 2016-11-03 20:31:44 +00:00
Ole Laursen 010c20801e When importing next reviewer, set it to the reviewer following the one 
that the old tool was pointing to, as it was pointing to the
last one having completed a review (despite being named next)
 - Legacy-Id: 12255
 2016-11-03 20:13:00 +00:00
Ole Laursen b16a829ec7 Modify review import to read result data for genart from an extra dataset 
- Legacy-Id: 12248
 2016-11-03 12:49:50 +00:00
Ole Laursen 54bc9ff596 Modify importer to close review requests for done documents as status 
"Unknown" instead of auto-closing those where the IESG state is
further in the process on - this seems to leave more requests in
genart open, but hopefully the extra data for genart will fix this
problem shortly.
 - Legacy-Id: 12247
 2016-11-02 16:58:03 +00:00
Ole Laursen 67e6423cb4 Modify importer to pick deadline from documents when there's an exact 
match, otherwise prefer what's stored with the review request (fixes
a bunch of cases with multiple reviews of the same draft)
 - Legacy-Id: 12246
 2016-11-02 12:37:47 +00:00
Ole Laursen b9d5352afd Display the reviewed revision in reviewer overview page 
- Legacy-Id: 12245
 2016-11-02 11:33:25 +00:00
Ole Laursen 70dfb760cb Don't import reviewer roles for completely unavailable reviewers who were marked as away until after 2020 
- Legacy-Id: 12244
 2016-11-01 20:57:34 +00:00
Ole Laursen 77d7d8b236 Add totals to review statistics tables and make it possible to select 
multiple teams in the graph and get accumulated counts shown
 - Legacy-Id: 12223
 2016-10-27 21:36:02 +00:00
Ole Laursen 3835532d71 Insert iconic link to review statistics from the team pages 
- Legacy-Id: 12215
 2016-10-26 13:35:32 +00:00
Ole Laursen 2548153894 Fix permission bug, secretaries should be able to request reviews 
- Legacy-Id: 12191
 2016-10-20 19:57:39 +00:00
Ole Laursen 31931ee0e8 Reviewed by -> Reviews 
- Legacy-Id: 12190
 2016-10-20 19:55:42 +00:00
Ole Laursen 76fd00c83e Don't put an anchor without an href around suggested review requests, 
it makes it look like a link despite the missing href
 - Legacy-Id: 12189
 2016-10-20 16:21:16 +00:00
Ole Laursen fb657c10b9 Don't put an anchor without an href around suggested review requests, 
it makes it look like a link despite the missing href
 - Legacy-Id: 12188
 2016-10-20 15:45:59 +00:00
Ole Laursen 31cc77db12 Add some help text to the team reviewers overview page 
- Legacy-Id: 12187
 2016-10-20 15:43:00 +00:00
Ole Laursen 1febf2465d Fix a bug in the logic that determines which roles are editable (the 
bug had the reviewer field showing up on non-dir pages)
 - Legacy-Id: 12186
 2016-10-20 15:30:35 +00:00
Ole Laursen 4b987436c0 Fix a missing HttpResponseForbidden in review statistics, make the 
review test code use a separate reviewer and reviewsecretary user to
avoid confounding things - also let these use Unicode in their names
to check for Unicode trouble.
 - Legacy-Id: 12175
 2016-10-19 11:58:49 +00:00
Ole Laursen 95bbabf384 Ignore duplicate review requests in importer - genart has had quite a 
few of these
 - Legacy-Id: 12171
 2016-10-18 13:50:10 +00:00
Ole Laursen d95be38ee7 Implement a reviewer blacklist in the importer and add "alice" in 
genart to it
 - Legacy-Id: 12170
 2016-10-18 11:51:33 +00:00
Ole Laursen 2ce2f8d067 Change default of ReviewerSettings.min_interval to null - if it's not 
specified for a reviewer, we don't take it into account
 - Legacy-Id: 12169
 2016-10-18 10:37:03 +00:00
Ole Laursen d0877a0aa9 Change default of ReviewerSettings.min_interval to null - if it's not 
specified for a reviewer, we don't take it into account
 - Legacy-Id: 12168
 2016-10-18 10:36:42 +00:00
Ole Laursen 78e4fa623e Tweak the sort order so that the minimum interval between reviews is 
considered of lower importance compared to previous reviews/wishes to
review the document
 - Legacy-Id: 12167
 2016-10-17 21:52:07 +00:00
Ole Laursen a216694c4c Add missing guard on the manage review button so it only shows up if 
the user can access the manage review page
 - Legacy-Id: 12166
 2016-10-17 21:43:35 +00:00
Ole Laursen 6b492ccf59 Only suggest I-Ds for review, not other types of documents 
- Legacy-Id: 12165
 2016-10-17 21:38:15 +00:00
Ole Laursen ed8f35e5a9 Scroll to top of textarea when clicking a message to use when 
completing a review.
 - Legacy-Id: 12164
 2016-10-17 21:30:34 +00:00
Ole Laursen e11a911d86 Include from in the list of messages when completing a review and 
searching for the review email, redo layout somewhat to accommodate
this and improve the presentation of the message date.
 - Legacy-Id: 12163
 2016-10-17 21:26:36 +00:00
Ole Laursen 4450ff192c Improve the looks of the previous commit by using an infinity sign in 
case of a missing start or end date
 - Legacy-Id: 12162
 2016-10-17 19:44:19 +00:00
Ole Laursen 399bb3bf4d Make UnavailablePeriod.start_date nullable and import the unavailable 
periods from the Perl tool with start date null as we don't know when
they started.
 - Legacy-Id: 12161
 2016-10-17 19:37:56 +00:00
Ole Laursen 38109e5f13 Add a couple more of the scripts that aren't supposed to be tested 
directly to TEST_CODE_COVERAGE_EXCLUDE
 - Legacy-Id: 12152
 2016-10-14 16:24:27 +00:00
Ole Laursen da032407f7 Exclude review tool importer from code coverage check 
- Legacy-Id: 12151
 2016-10-14 16:17:42 +00:00
Ole Laursen e1f69171b5 xslugify the last name part when constructing a name for the review document 
- Legacy-Id: 12147
 2016-10-14 09:42:34 +00:00
Ole Laursen 9a3996a286 Make sure that name_parts doesn't accidentally turn Unicode strings 
into plain strings
 - Legacy-Id: 12146
 2016-10-14 09:41:21 +00:00
Ole Laursen e864abdcdb Fix some pyquery compatibility issues 
- Legacy-Id: 12145
 2016-10-14 09:40:12 +00:00
Ole Laursen d59d0e8bdc Fix spelling mistake in class name 
- Legacy-Id: 12144
 2016-10-14 09:29:52 +00:00
Ole Laursen e3fbc070f9 Fix bug in reference in resources 
- Legacy-Id: 12143
 2016-10-14 08:43:21 +00:00
Ole Laursen 2b7fcf0b5f Remove unused import 
- Legacy-Id: 12142
 2016-10-14 08:40:24 +00:00
Ole Laursen e598b7209a Update name fixture with the alphabetical ordering. 
- Legacy-Id: 12137
 2016-10-13 19:37:30 +00:00
Ole Laursen 505b4fcea3 Fix redirection problem when group_type is not given. 
- Legacy-Id: 12136
 2016-10-13 19:34:39 +00:00
Ole Laursen 9de2d49823 Fixup some of the migrations a bit upon the merge with trunk. 
- Legacy-Id: 12135
 2016-10-13 19:20:26 +00:00
Ole Laursen 60ec861bd6 Shorten the verbose names a bit, they make Django complain 
- Legacy-Id: 12130
 2016-10-13 17:10:04 +00:00
Ole Laursen 958ba5ba95 Make new branch from trunk and merge in review-tracker-r11921 
- Legacy-Id: 12129
 2016-10-13 16:38:47 +00:00
Ole Laursen 8f497af6e6 Add admin.py for review models 
- Legacy-Id: 12128
 2016-10-13 16:16:34 +00:00
Ole Laursen 5a878981fe Guard against reviewer name not being filled in properly (still 
containing a @) on the complete review page
 - Legacy-Id: 12127
 2016-10-13 15:54:11 +00:00
Ole Laursen 336e2bbc5e In case the review data contains a proper name for a person we already 
know, use that - this prevents problems with email addresses being
embedded in review document names.
 - Legacy-Id: 12126
 2016-10-13 15:53:14 +00:00
Ole Laursen 6d7bfd7b37 Actually commit the statistics section. 
- Legacy-Id: 12125
 2016-10-13 15:36:14 +00:00
Ole Laursen bf55237112 Add statistics section with review statistics. Fix a couple of missing tests. 
- Legacy-Id: 12124
 2016-10-13 15:20:04 +00:00
Henrik Levkowetz 99b22efc96 Merged in [12104] from rjsparks@nostrum.com: 
Don't show the request publication button for ise,irtf, and iab drafts after publication has already been requested. Fixes #2019.
 - Legacy-Id: 12122
Note: SVN reference [12104] has been migrated to Git commit 933134f4cc
 2016-10-12 18:39:22 +00:00
Henrik Levkowetz 05c26ba4c9 The db api prefers resource URIs ending in slash -- make it so in json_agenda(). 
- Legacy-Id: 12121
 2016-10-12 18:09:18 +00:00