Commit graph

52 commits

Author SHA1 Message Date
Robert Sparks ba8b4d3a38 Allow those people who can make a review request to edit the request deadline. Send mail to other directorate secretaries when one secretary makes a change to a request. Fixes #2233. Commit ready for merge.
- Legacy-Id: 14549
2018-01-22 21:43:53 +00:00
Robert Sparks 0a9737a5d2 Include information about previous team reviews in assignement emails. Fixes #2392. Commit ready for merge.
- Legacy-Id: 14466
2017-12-26 22:13:13 +00:00
Henrik Levkowetz e79397d6ad Added cleaning of review_url from the review completion form, to make sure it's retrievable.
- Legacy-Id: 14227
2017-10-27 05:54:34 +00:00
Henrik Levkowetz 39dbf43da4 Merged in [13918] from kivinen@iki.fi:
Unified the review request views to use same template, so they all
show same data, in same format.
 - Legacy-Id: 13936
Note: SVN reference [13918] has been migrated to Git commit b6e036b63e
2017-07-18 12:57:56 +00:00
Henrik Levkowetz 023a32715d Merged in ^/branch/iola/author-stats-r13145 from olau@iola.com, with additional features from ^/personal/henrik/6.52.1-authorstats.
- Legacy-Id: 13550
2017-06-06 18:36:59 +00:00
Henrik Levkowetz 2e20d9df66 Changed all instances of deprecated self.failUnless() unittest method to self.assertTrue().
- Legacy-Id: 13515
2017-06-04 16:24:34 +00:00
Henrik Levkowetz 08f134bf52 Improved review linebreaking tests, based on [13495] from olau@iola.dk.
- Legacy-Id: 13511
Note: SVN reference [13495] has been migrated to Git commit 1a59cf60d3
2017-06-04 15:14:56 +00:00
Ole Laursen 1a59cf60d3 Introduce a word-wrapping filter that checks if there are lines (containing spaces to not
count URLs) longer than 100 characters, and only wraps the text if that's the case, to 
prevent messing up pre-wrapped text. Use this filter in the review email code.

Branch ready for merge.
 - Legacy-Id: 13495
2017-06-02 13:17:30 +00:00
Henrik Levkowetz 76628be3fd Merged in ^/branch/iola/author-stats-r13145 from olau@iola.dk, and fixed some tests in code which moved after the latest merge with trunk. The test suite passes, but the migrations are _not_ ready to run, because of numbering conflicts (again due to code changes on trunk since the latest sync).
- Legacy-Id: 13479
2017-05-31 20:59:26 +00:00
Ole Laursen 5b677dc6ba Merge author stats branch into new branch from trunk
- Legacy-Id: 13159
2017-03-28 14:36:40 +00:00
Henrik Levkowetz 14c748df98 Changed the creation of temporary test dirs to use names which include the test class name, in order to make it possible to run test cases in parallel. Disabled coverage testing when running in parallel (those classes cannot be pickled and distributed to the test runner threads, and also won't pass coverage data back). Tweaked the TestCase.tempdir() method.
- Legacy-Id: 13157
2017-03-27 21:41:18 +00:00
Lars Eggert 8a70e9773d Fix various "RemovedInDjango20Warning" warnings. Commit ready for merge.
- Legacy-Id: 13112
2017-03-25 19:16:45 +00:00
Henrik Levkowetz 4daf66d11c Added DocEvent rev= parameter througout the code.
- Legacy-Id: 12978
2017-03-06 15:08:21 +00:00
Henrik Levkowetz c006c44423 Added setting of document author for review document objects.
- Legacy-Id: 12957
2017-03-03 19:40:09 +00:00
Henrik Levkowetz 541085b1a8 Changed email notifications for reviews done to save the message as a Message instance before sending it. Added test code to check that a Message instance is created and matches what goes out.
- Legacy-Id: 12955
2017-03-03 15:45:29 +00:00
Robert Sparks 8577a5e84a Use the Role email associated with a reviewer as the From when emailing a review. Fixes #2201. Commit ready for merge.
- Legacy-Id: 12930
2017-02-28 18:40:09 +00:00
Henrik Levkowetz 27351c4349 Fixed url lookups for doc.views_doc.document_main() to only use dotted-path, and removed the doc_view explicit url name. Fixes a 500 error in /submit/status/NNNN/.
- Legacy-Id: 12897
2017-02-22 11:40:55 +00:00
Ole Laursen 9308948195 Add person, affiliation and country (through django-countries) to
DocumentAuthor, rename author field to email and make it optional (for
modeling old email-less submissions), remove the authors many to many
referencing field from Document as it is not really pointing the right
place.

Update the Secretariat tools to show affiliation and country.

Add migration for getting rid of the fake email addresses that the
migration script created some years ago (just set the author email
field to null).
 - Legacy-Id: 12739
2017-01-26 17:10:08 +00:00
Robert Sparks 4f2f691de6 Removed some unnecessary randomness in tests introduced in last commit. Commit ready for merge.
- Legacy-Id: 12675
2017-01-19 16:37:00 +00:00
Robert Sparks 8e007ce50b Make changing skip_next on a review assignment an explicit decision of the assigner. Commit ready for merge. Fixes #2148.
- Legacy-Id: 12670
2017-01-19 14:23:09 +00:00
Robert Sparks 10f4892eae Send mail to team secretaries when a review is explicitly requested. Change the From and Subject for assignment emails to reviewers to make it clearer what the review is for and who assigned it. Fixes #2053 and #2114. Commit ready for merge.
- Legacy-Id: 12593
2016-12-19 22:32:03 +00:00
Henrik Levkowetz ff3638e365 Merged in [12549] from rjsparks@nostrum.com:
allow ads and secretaries to edit the review request comment. Fixes #2096. (Again).
 - Legacy-Id: 12550
Note: SVN reference [12549] has been migrated to Git commit 32b431cf24
2016-12-15 23:10:28 +00:00
Henrik Levkowetz 8dcc1d20a2 Merged in [12545] from rjsparks@nostrum.com:
Allow a review request to include a comment to show to the review team secretary at assignment time and the reviewer at review time. Fixes #2096.
 - Legacy-Id: 12548
Note: SVN reference [12545] has been migrated to Git commit 6fcd8b8a16
2016-12-15 22:45:25 +00:00
Henrik Levkowetz b14e981e66 Merged in [12520] from rjsparks@nostrum.com:
Slight refactor of the review models to capture review team settings. Allows configuring review teams to get automatic suggestions for reviews or not. Provides a better admin for creating/managing review teams. Fixes #2048 and #2072.
 - Legacy-Id: 12544
Note: SVN reference [12520] has been migrated to Git commit b24bdb5bc3
2016-12-15 20:55:40 +00:00
Robert Sparks b24bdb5bc3 Slight refactor of the review models to capture review team settings. Allows configuring review teams to get automatic suggestions for reviews or not. Provides a better admin for creating/managing review teams. Fixes #2048 and #2072. Commit ready for merge.
- Legacy-Id: 12520
2016-12-14 23:26:32 +00:00
Robert Sparks 1ea983a1c2 Disallow requesting directorate reviews of RFCs (such things would better be done with reviews of status change documents). Fixes #2065. Commit ready for merge.
- Legacy-Id: 12505
2016-12-12 21:42:53 +00:00
Henrik Levkowetz 57eb5844e5 Merged in [12489] from rjsparks@nostrum.com:
Save a new reviewrequest for each team requested in the request form. Fixes #2094.
 - Legacy-Id: 12491
Note: SVN reference [12489] has been migrated to Git commit 4fff1ab101e4f7cd27dc8ded889e09905866076f
2016-12-09 12:01:48 +00:00
Ole Laursen e171aa657e Add support for revising a closed review, mostly to allow reviewers to
correct historic entries with missing data
 - Legacy-Id: 12314
2016-11-09 16:20:58 +00:00
Ole Laursen cde7cfacd5 Modify the reviewer overview page to display up to 10 historic reviews
per person from the past year instead of only 5.

Add basic reviewer stats to the assignment select box.
 - Legacy-Id: 12279
2016-11-07 22:32:53 +00:00
Ole Laursen 2548153894 Fix permission bug, secretaries should be able to request reviews
- Legacy-Id: 12191
2016-10-20 19:57:39 +00:00
Ole Laursen 4b987436c0 Fix a missing HttpResponseForbidden in review statistics, make the
review test code use a separate reviewer and reviewsecretary user to
avoid confounding things - also let these use Unicode in their names
to check for Unicode trouble.
 - Legacy-Id: 12175
2016-10-19 11:58:49 +00:00
Ole Laursen d0877a0aa9 Change default of ReviewerSettings.min_interval to null - if it's not
specified for a reviewer, we don't take it into account
 - Legacy-Id: 12168
2016-10-18 10:36:42 +00:00
Ole Laursen e11a911d86 Include from in the list of messages when completing a review and
searching for the review email, redo layout somewhat to accommodate
this and improve the presentation of the message date.
 - Legacy-Id: 12163
2016-10-17 21:26:36 +00:00
Ole Laursen 227fdd7953 Add reviews to search results and IESG agenda. Support restricting
review types so that teams will only have those review types
listed and suggested that they are configured to have.

Fix a couple of things in the importer after having tested it on all
the databases. Set unavailable end date >= 2020 to indefinite.

Fix a couple of bugs.
 - Legacy-Id: 12095
2016-10-06 14:47:41 +00:00
Ole Laursen 4c7b2847ba Add a utility function for extracting information about review
requests for a given set of teams/reviewers (making it trivial to
compute statistics), revamp the related doc event code to support this
by referencing the review request directly, add a reviewer overview
page with recent performance for each reviewer as well as
settings/unavailable periods. Fix some bugs and shuffle some of the
review code a bit around.

Finish the importer from the previous Perl-based review tool,
importing log entries, figuring out whether a given review is
early/telechat/last call and fixing corner cases.
 - Legacy-Id: 12080
2016-10-03 15:52:32 +00:00
Ole Laursen 99beb58291 Implement a round-robin rotation scheme for reviewers instead of
relying on when they last reviewed. In-order assignments automatically
move the rotation forwards while out-of-order assignments increment
the skip next of the assigned reviewer. Include rotation in open
review assignments email. Fix a couple of issues in the importer.
 - Legacy-Id: 12015
2016-09-21 16:52:50 +00:00
Ole Laursen 6da25e6bd9 Add personal review overview page for reviewers, add page for editing
reviewer availability settings, emailing the reviewer/secretary as
necessary, add tests for these pages. Fix a bunch of bugs.
 - Legacy-Id: 11998
2016-09-19 16:05:32 +00:00
Ole Laursen 74a02be9bf Create new branch from trunk@r11921, and merge review-tracker-r11360 into it
- Legacy-Id: 11923
2016-09-06 10:17:12 +00:00
Ole Laursen dd190b87fe Follow replacements when displaying reviews for a draft on the
document page, too. Add a test to check that recursive replacements
are handled correctly. Polish the display a bit.
 - Legacy-Id: 11847
2016-08-23 14:55:42 +00:00
Ole Laursen 0958bcba4a Fill in the list_email attribute on the test review team
- Legacy-Id: 11845
2016-08-23 14:05:45 +00:00
Ole Laursen 426542771a Turn ReviewRequest.deadline into a date field with no time
- Legacy-Id: 11801
2016-08-17 15:10:39 +00:00
Ole Laursen 308b854d66 Change the naming algorithm for review documents a bit
- Legacy-Id: 11635
2016-07-12 16:02:35 +00:00
Ole Laursen db4ea01e20 Take a bunch of factors into account when sorting reviewers for
assignment to a review request
 - Legacy-Id: 11626
2016-07-12 13:04:14 +00:00
Ole Laursen 19fff81a4f Rework closing a review request so the logic is reusable, add the more
specific close reasons to the database migration, add
ReviewRequest.requested_by so it's possible to notify the requester of
a review that it has been dropped.
 - Legacy-Id: 11520
2016-07-05 16:05:00 +00:00
Ole Laursen e2e66522c7 Add review request page for review teams and first draft of manage
review requests page.

Add importer for importing review data from the existing Perl tool
(WIP, gets most but not all of the interesting information out).

Fix various bugs.
 - Legacy-Id: 11508
2016-07-01 16:06:16 +00:00
Ole Laursen 7cbe36fb62 Implement completing a review with tests. One can currently
enter/upload content or retrieve it from an IETF mailarch archive
through integrated searching support. Support for partial completion.
 - Legacy-Id: 11360
2016-06-14 11:28:53 +00:00
Ole Laursen 604287e75d Support accepting a reviewer assignment
- Legacy-Id: 11237
2016-05-24 15:03:51 +00:00
Ole Laursen b9f4b7005e Add simple email notifications for assigning/rejecting review requests
- Legacy-Id: 11236
2016-05-24 14:02:59 +00:00
Ole Laursen 5dd079e2f8 Add support for assigning a reviewer to a review request, still some
corners missing. Fix a couple of other issues.
 - Legacy-Id: 11227
2016-05-23 16:42:49 +00:00
Ole Laursen b5ef179a6e Add support for rejecting a review assignment
- Legacy-Id: 11225
2016-05-23 13:57:01 +00:00