Commit graph

879 commits

Author SHA1 Message Date
Robert Sparks 3c63fdb800 Added an extra highlight to the ballot_icon box when the viewer holds a blocking position in that ballot. Fixes #2046. Commit ready for merge.
- Legacy-Id: 12385
2016-11-18 04:52:13 +00:00
Robert Sparks ab96f6c89c Fix an issue with the agenda linking to group type "other" slides. Will patch production. Commit ready for merge.
- Legacy-Id: 12338
2016-11-13 01:58:53 +00:00
Ole Laursen e171aa657e Add support for revising a closed review, mostly to allow reviewers to
correct historic entries with missing data
 - Legacy-Id: 12314
2016-11-09 16:20:58 +00:00
Ole Laursen cde7cfacd5 Modify the reviewer overview page to display up to 10 historic reviews
per person from the past year instead of only 5.

Add basic reviewer stats to the assignment select box.
 - Legacy-Id: 12279
2016-11-07 22:32:53 +00:00
Henrik Levkowetz 27abaae2e4 Tweaked and enhanced doc.admin.DocEventAdmin.
- Legacy-Id: 12276
2016-11-07 18:38:34 +00:00
Henrik Levkowetz 7f1c1e43f2 Replaced the use of plain DocEvent for submission doc events with a SubmissionDocEvent that carries rev and a FK to submission.
- Legacy-Id: 12275
2016-11-07 18:21:34 +00:00
Henrik Levkowetz 7c7e282797 When using select_related, field names are now valiadate. Fixed some invalid names.
- Legacy-Id: 12269
2016-11-04 19:03:58 +00:00
Henrik Levkowetz 87e1339924 Fixed all the warnings emitted by the check command; mostly use of null=True on ManyToManyFields, which doesn't make sense.
- Legacy-Id: 12256
2016-11-03 20:13:44 +00:00
Henrik Levkowetz cfe4d2f6aa Removed use of the fix_ampersands() function.
- Legacy-Id: 12254
2016-11-03 20:11:49 +00:00
Henrik Levkowetz ca570ae355 Reverted an inadvertent commit of all changes.
- Legacy-Id: 12253
2016-11-03 20:10:09 +00:00
Henrik Levkowetz 276c9c1030 Removed use of the fix_ampersands() function.
- Legacy-Id: 12252
2016-11-03 20:08:44 +00:00
Henrik Levkowetz 288d211ca1 Made doc.views_stat.make_title() more robust against inconsistent query arguments.
- Legacy-Id: 12242
2016-10-30 18:16:52 +00:00
Henrik Levkowetz aec77c2385 Rewrote Document.href() to not do database queries when possible, as that has a big performance impact. Fixed a number of tests which relied on href() not doing the right thing for simplified test data. Added caching of canonical_name(), which can be quite heavy. Additional refactoring in a number of places, to use better test data and avoid test failures for good code :-)
- Legacy-Id: 12226
2016-10-28 16:59:42 +00:00
Ole Laursen 3835532d71 Insert iconic link to review statistics from the team pages
- Legacy-Id: 12215
2016-10-26 13:35:32 +00:00
Henrik Levkowetz a2c8fa0178 Added a Document.pub_date() method which returns the RFC publication datetime or other documents' new-revision datetime. Changed the generated bibtex entries to use pub_date(). Added tests for bibtext entries. Added 'bibtexparser' to requirements.txt. Fixes issue #2032.
- Legacy-Id: 12212
2016-10-25 18:07:48 +00:00
Henrik Levkowetz cae4ab0024 Added caching of Document.href() values.
- Legacy-Id: 12210
2016-10-25 00:14:21 +00:00
Ole Laursen 2548153894 Fix permission bug, secretaries should be able to request reviews
- Legacy-Id: 12191
2016-10-20 19:57:39 +00:00
Ole Laursen 4b987436c0 Fix a missing HttpResponseForbidden in review statistics, make the
review test code use a separate reviewer and reviewsecretary user to
avoid confounding things - also let these use Unicode in their names
to check for Unicode trouble.
 - Legacy-Id: 12175
2016-10-19 11:58:49 +00:00
Ole Laursen d0877a0aa9 Change default of ReviewerSettings.min_interval to null - if it's not
specified for a reviewer, we don't take it into account
 - Legacy-Id: 12168
2016-10-18 10:36:42 +00:00
Ole Laursen e11a911d86 Include from in the list of messages when completing a review and
searching for the review email, redo layout somewhat to accommodate
this and improve the presentation of the message date.
 - Legacy-Id: 12163
2016-10-17 21:26:36 +00:00
Ole Laursen e1f69171b5 xslugify the last name part when constructing a name for the review document
- Legacy-Id: 12147
2016-10-14 09:42:34 +00:00
Ole Laursen e3fbc070f9 Fix bug in reference in resources
- Legacy-Id: 12143
2016-10-14 08:43:21 +00:00
Ole Laursen 9de2d49823 Fixup some of the migrations a bit upon the merge with trunk.
- Legacy-Id: 12135
2016-10-13 19:20:26 +00:00
Ole Laursen 958ba5ba95 Make new branch from trunk and merge in review-tracker-r11921
- Legacy-Id: 12129
2016-10-13 16:38:47 +00:00
Ole Laursen 5a878981fe Guard against reviewer name not being filled in properly (still
containing a @) on the complete review page
 - Legacy-Id: 12127
2016-10-13 15:54:11 +00:00
Henrik Levkowetz 99b22efc96 Merged in [12104] from rjsparks@nostrum.com:
Don't show the request publication button for ise,irtf, and iab drafts after publication has already been requested. Fixes #2019.
 - Legacy-Id: 12122
Note: SVN reference [12104] has been migrated to Git commit 933134f4cc
2016-10-12 18:39:22 +00:00
Robert Sparks 933134f4cc Don't show the request publication button for ise,irtf, and iab drafts after publication has already been requested. Fixes #2019. Commit ready for merge.
- Legacy-Id: 12104
2016-10-07 17:29:05 +00:00
Ole Laursen 227fdd7953 Add reviews to search results and IESG agenda. Support restricting
review types so that teams will only have those review types
listed and suggested that they are configured to have.

Fix a couple of things in the importer after having tested it on all
the databases. Set unavailable end date >= 2020 to indefinite.

Fix a couple of bugs.
 - Legacy-Id: 12095
2016-10-06 14:47:41 +00:00
Henrik Levkowetz 5f03d70bd7 Added admin support for the DocumentAuthor model.
- Legacy-Id: 12089
2016-10-05 15:16:46 +00:00
Ole Laursen 0aa8f8a7cc Don't automatically open a new review request if there's already
another open request in the team
 - Legacy-Id: 12086
2016-10-05 13:34:15 +00:00
Ole Laursen a177dc616b Fix a couple of bugs, add test for reviewer overview page
- Legacy-Id: 12081
2016-10-04 20:22:11 +00:00
Ole Laursen 4c7b2847ba Add a utility function for extracting information about review
requests for a given set of teams/reviewers (making it trivial to
compute statistics), revamp the related doc event code to support this
by referencing the review request directly, add a reviewer overview
page with recent performance for each reviewer as well as
settings/unavailable periods. Fix some bugs and shuffle some of the
review code a bit around.

Finish the importer from the previous Perl-based review tool,
importing log entries, figuring out whether a given review is
early/telechat/last call and fixing corner cases.
 - Legacy-Id: 12080
2016-10-03 15:52:32 +00:00
Henrik Levkowetz a9f879cd0e Tweaked admin models.
- Legacy-Id: 12071
2016-10-01 13:36:31 +00:00
Henrik Levkowetz e3a7d47fdc Moved some code and tweaked settings to ignore sql debug functions when calculating code coverage.
- Legacy-Id: 12069
2016-09-30 21:29:32 +00:00
Henrik Levkowetz 9e18351a0b Refined the sql debug info, making the table of queries sortable and adding duplication counts and accumulated query time.
- Legacy-Id: 12068
2016-09-30 20:38:18 +00:00
Robert Sparks c34356db94 Modified the rfc feed to better represent dois. Fixes #2014. Commit ready for merge.
- Legacy-Id: 12055
2016-09-28 17:52:39 +00:00
Henrik Levkowetz 7f772641d4 Change the cache key construction to deal with query arguments containing spaces. Fixes 500 errors which would otherwise occur.
- Legacy-Id: 12035
2016-09-25 13:53:22 +00:00
Henrik Levkowetz 8c34e9d78d Merged in ^/branch/proceedings/6.33.1.dev0 from rjsparks@nostrum.com and rcross@amsl.com. This provides new ietf meeting proceedings pages.
- Legacy-Id: 12028
2016-09-23 17:33:43 +00:00
Ole Laursen c586feb579 Fix an old bug in draft resurrection, it was using the long gone
doc.idinternal in an explanation
 - Legacy-Id: 12027
2016-09-23 15:29:27 +00:00
Ole Laursen 99beb58291 Implement a round-robin rotation scheme for reviewers instead of
relying on when they last reviewed. In-order assignments automatically
move the rotation forwards while out-of-order assignments increment
the skip next of the assigned reviewer. Include rotation in open
review assignments email. Fix a couple of issues in the importer.
 - Legacy-Id: 12015
2016-09-21 16:52:50 +00:00
Henrik Levkowetz 5089651e17 Don't use EmptyQuerySet directly; return Class.objects.none() instead.
- Legacy-Id: 12013
2016-09-21 11:23:57 +00:00
Henrik Levkowetz d0c3331f9f Clarified the differences between Document.href() and Document.get_absolute_url(). Updated PLAN.
- Legacy-Id: 12012
2016-09-20 21:05:14 +00:00
Henrik Levkowetz 9e66c16fa7 Made retrieve_search_results() always return a queryset, which lets us use .exists() on the returned value as needed.
- Legacy-Id: 12007
2016-09-20 18:32:20 +00:00
Henrik Levkowetz f8bca9bcf6 Reverted inadvertent commit
- Legacy-Id: 12006
2016-09-20 18:31:16 +00:00
Henrik Levkowetz e917c5a0df Added made group a json object in the json_agenda, and added session.group.type information.
- Legacy-Id: 12005
2016-09-20 18:24:08 +00:00
Ole Laursen 6da25e6bd9 Add personal review overview page for reviewers, add page for editing
reviewer availability settings, emailing the reviewer/secretary as
necessary, add tests for these pages. Fix a bunch of bugs.
 - Legacy-Id: 11998
2016-09-19 16:05:32 +00:00
Robert Sparks 02ee5dc5d7 (somewhat bumpy) merge forward from proceedings/6.31.1.dev0
- Legacy-Id: 11992
2016-09-14 22:09:30 +00:00
Robert Sparks 53f41a6327 Added an order field to SessionPresentation.
Set up removing the order field from Document.
Modified the meeting materials, proceedings, and session details views to use the order field on SessionPresentation.
Added bootstrapped views to upload session materials (agendas, slides, minutes, and bluesheets). 
Integrated upload into the session details view.
Commit ready for merge.
 - Legacy-Id: 11989
2016-09-14 19:11:31 +00:00
Henrik Levkowetz 9d053cae38 Removed an unwanted migration.
- Legacy-Id: 11968
2016-09-11 11:50:05 +00:00
Henrik Levkowetz ecd4491150 Corrected a migration to match the list of event types in doc/models.py
- Legacy-Id: 11963
2016-09-10 20:05:35 +00:00
Henrik Levkowetz 22b2953b18 Merged in ^/branch/scow/track-manual-id-posts-6.31.1.dev0, which provides secretariat support for managing draft submissions outside of the automated datatracker draft submission tool. In addition to making the secreatiat handling of draft submissions that come in by email or other paths easier, it also improves the datatracker submission and document history for these documents.
- Legacy-Id: 11959
2016-09-09 17:00:23 +00:00
Henrik Levkowetz 545140d939 Started moving app-specific settings into app settings.py files.
- Legacy-Id: 11949
2016-09-09 05:42:41 +00:00
Henrik Levkowetz e0e930fc0c Fixed a situation where the Change IETF WG State form gave an exception when the form was submitted empty, instead of informing the user.
- Legacy-Id: 11943
2016-09-08 17:23:15 +00:00
Henrik Levkowetz ec684e1b4e Added a pylint rc-file, and fixed or silenced a number of issues found by pylint using the settings .pylintrc (which enable only error checking).
- Legacy-Id: 11941
2016-09-08 14:48:59 +00:00
Henrik Levkowetz f726f5c785 Moved default column chart settings to settings.py. Split chart config and data into separate ajax urls to permit drawing base chart details before having data. Added a 'Loading...' notification while loading chart data. Added more test cases. Changed chart settings to eliminate empty data points from data transfer.
- Legacy-Id: 11930
2016-09-07 13:06:30 +00:00
Henrik Levkowetz 03d5b07e51 Added document information and submission timeline to profile pages. Refactored the chart data generation.
- Legacy-Id: 11928
2016-09-06 19:25:51 +00:00
Henrik Levkowetz 74f7c5782b Added some basic charting support, using highcharts, and charts showing new-revision timelines for document search results.
- Legacy-Id: 11927
2016-09-06 13:19:45 +00:00
Ole Laursen 74a02be9bf Create new branch from trunk@r11921, and merge review-tracker-r11360 into it
- Legacy-Id: 11923
2016-09-06 10:17:12 +00:00
Henrik Levkowetz b0906f04af Basic charting of new revision activity for document search results.
- Legacy-Id: 11922
2016-09-06 09:47:22 +00:00
Henrik Levkowetz 14607c977d Fixed a blowup which could happen if an rfc doesn't have its standard level set.
- Legacy-Id: 11916
2016-09-01 08:57:49 +00:00
Henrik Levkowetz e2fccfb094 Merged in ^/branch/scow/track-manual-id-posts-6.31.1.dev0@11899, which provides better support for manual ID posting.
- Legacy-Id: 11914
2016-08-31 22:30:31 +00:00
Henrik Levkowetz a939936a10 Fixed document methods .get_file_path() and .href() for historic meeting documents, to make urls like /doc/minutes-96-detnet/1/ work.
- Legacy-Id: 11912
2016-08-31 16:19:05 +00:00
Henrik Levkowetz fae136cfc3 Made migration doc:0013 more robust.
- Legacy-Id: 11903
2016-08-31 13:48:00 +00:00
Henrik Levkowetz f97204ceee Fixed a number of places where events were given the document time, but the document had not been given a new time yet, after the eventsave refactoring code changes of [11841]. Fixes issue #2004.
- Legacy-Id: 11901
Note: SVN reference [11841] has been migrated to Git commit d868371aff
2016-08-31 10:54:27 +00:00
Mike Douglass fa3a34389e Merge forward to 6.31.1.dev0
- Legacy-Id: 11899
2016-08-31 03:00:10 +00:00
Henrik Levkowetz 9fb2ec22c6 Added handling for an exception which could occur for charter documents which does not have a matching chartered group.
- Legacy-Id: 11886
2016-08-26 14:07:50 +00:00
Henrik Levkowetz 7d0fd4cb29 Merged in [11859] from rjsparks@nostrum.com:
Put WG summary information on the rechartering page. Fixes #2000.
 - Legacy-Id: 11881
Note: SVN reference [11859] has been migrated to Git commit b6978debb6
2016-08-26 10:31:03 +00:00
Henrik Levkowetz c8917f51aa Changed the migration progress indication to a tqdm progress bar.
- Legacy-Id: 11862
2016-08-25 05:48:04 +00:00
Henrik Levkowetz a90af1e9e3 Added a migration to capture an additional DocEvent type string.
- Legacy-Id: 11861
2016-08-25 05:22:59 +00:00
Robert Sparks b6978debb6 Put WG summary information on the rechartering page. Fixes #2000. Commit ready for merge.
- Legacy-Id: 11859
2016-08-24 18:43:15 +00:00
Henrik Levkowetz cf5ac68b09 Renumbered and updated the migrations merged in from the eventsaving work. Made the dochistory-adding migration idempotent, and added progress indication as this migration may take as much as an hour to run.
- Legacy-Id: 11854
2016-08-24 15:37:25 +00:00
Ole Laursen 24dd268a81 Show on document page if teams are not going to review that version
- Legacy-Id: 11851
2016-08-24 09:08:37 +00:00
Ole Laursen dd190b87fe Follow replacements when displaying reviews for a draft on the
document page, too. Add a test to check that recursive replacements
are handled correctly. Polish the display a bit.
 - Legacy-Id: 11847
2016-08-23 14:55:42 +00:00
Ole Laursen 0958bcba4a Fill in the list_email attribute on the test review team
- Legacy-Id: 11845
2016-08-23 14:05:45 +00:00
Henrik Levkowetz 4b0a9360f0 Merged in ^/branch/iola/event-saving-refactor-r10291, which refactors document saving to always use doc.save_with_history(events), and requires accompanying events. This branch also provides refactoring of recurring regexes in url patterns into a dictionary. As part of the merge, also refactored new code which didn't use the save_with_history() method.
- Legacy-Id: 11840
2016-08-23 10:52:08 +00:00
Ole Laursen 8b65c3ad65 Support adding CC's to the complete review email
- Legacy-Id: 11826
2016-08-19 16:37:46 +00:00
Henrik Levkowetz 6f05b23837 Merged in [11778] from rjsparks@nostrum.com:
Enabled and refined document_main view for bluesheets.
Improved migration for 95 and 96 bluesheets, adding DocAlias and DocEvent creation.
Added bluesheet upload to the session details view.
Moved a function out of secr/proceedings/views into its own util.py file to allow reusing it in other modules without introducing circular imports.
 - Legacy-Id: 11811
Note: SVN reference [11778] has been migrated to Git commit 0611444b36bc071e8db068a093cc1ad93bb69659
2016-08-17 18:28:02 +00:00
Ole Laursen 426542771a Turn ReviewRequest.deadline into a date field with no time
- Legacy-Id: 11801
2016-08-17 15:10:39 +00:00
Ole Laursen 3ecaf54d51 Pre-fill the review type when requesting a review
- Legacy-Id: 11798
2016-08-17 14:42:57 +00:00
Ole Laursen 0e808518bc Make it possible to request review for more than one team at the time,
auto-select the team for team secretaries/delegates
 - Legacy-Id: 11786
2016-08-15 16:05:56 +00:00
Ole Laursen 8a5d9d7a72 Make it more obvious that a review is not completed yet, include
ongoing reviews in the list on the review document page
 - Legacy-Id: 11785
2016-08-15 15:46:11 +00:00
Ole Laursen 9454c8bb9c Show other reviews of document on the review document page
- Legacy-Id: 11784
2016-08-15 14:41:12 +00:00
Ole Laursen 1ae302ca07 Add info about last call/scheduled telechat to the request review page, fix a bug
- Legacy-Id: 11782
2016-08-15 10:31:50 +00:00
Robert Sparks 44cd9e0920 Moved the materials start, cutoff, and revision dates into the Meeting object
- Legacy-Id: 11760
2016-08-05 20:44:05 +00:00
Ole Laursen 78062adc2f Use request.build_absolute_uri instead of grabbing the domain from the
current Site in the review code
 - Legacy-Id: 11753
2016-08-03 15:13:55 +00:00
Henrik Levkowetz b420ef220c Merged in [11721] from bartosz.balazinski@interdigital.com:
Annotated the document state selection list with indications of
whether the state is an IETF or IRTF state. Fixes #1968.
 - Legacy-Id: 11722
Note: SVN reference [11721] has been migrated to Git commit 0925e8e242
2016-07-20 09:14:27 +00:00
Bartosz Balazinski 0925e8e242 Annotated the document state selection list with indications of
whether the state is an IETF or IRTF state. Fixes #1968. 
Commit ready to merge.
 - Legacy-Id: 11721
2016-07-20 00:02:45 +00:00
Henrik Levkowetz f2150df76a Merged in [11687], [11710] from presnick@qti.qualcomm.com:
Generate a message to Secretary and IESG when AD changes a draft state
to 'Approved'.  Fixes issue #796.
 - Legacy-Id: 11714
Note: SVN reference [11687] has been migrated to Git commit ae87e84610

Note: SVN reference [11710] has been migrated to Git commit 65bb1f2738
2016-07-19 10:48:13 +00:00
Pete Resnick 65bb1f2738 Added a test for the document approved by AD action. Related to issue
#796.  Commit ready for merge
 - Legacy-Id: 11710
2016-07-18 20:12:12 +00:00
Pete Resnick ae87e84610 Generate message to Secretary and IESG when AD changes a draft state to "Approved".
Fixes issue #796. Commit ready for merge.
 - Legacy-Id: 11687
2016-07-16 17:09:21 +00:00
Henrik Levkowetz d5d9d10017 Merged in [11663] from housley@vigilsec.com:
Clarify that the consensus field is talking about whether the doument will include the consensus boilerplate when it is published as an RFC. Fixes #1955.
 - Legacy-Id: 11684
Note: SVN reference [11663] has been migrated to Git commit 9d5a94713e
2016-07-16 14:52:57 +00:00
Russ Housley 9d5a94713e Clarify that the consensus field is talking about whether the doument will include the consensus boilerplate when it is published as an RFC. Fixes #1955.
- Legacy-Id: 11663
2016-07-16 09:53:54 +00:00
Robert Sparks 030ea1c939 Enhanced factories to simplify test writing. Commit ready for merge.
- Legacy-Id: 11656
2016-07-15 12:30:08 +00:00
Robert Sparks 992aba1aec Call out downreferences in autogenerated last call text. Fixes #1982. Commit ready for merge.
- Legacy-Id: 11654
2016-07-14 18:09:22 +00:00
Ole Laursen 308b854d66 Change the naming algorithm for review documents a bit
- Legacy-Id: 11635
2016-07-12 16:02:35 +00:00
Ole Laursen e7ee08069e Swap the sort order on the displayed revisions when completing a review
- Legacy-Id: 11632
2016-07-12 15:06:49 +00:00
Ole Laursen db4ea01e20 Take a bunch of factors into account when sorting reviewers for
assignment to a review request
 - Legacy-Id: 11626
2016-07-12 13:04:14 +00:00
Henrik Levkowetz 45b19a585b Fixed various issues with the interim approval request email text when used for non-WG groups (RGs, for instance). Added supporting template filter functions. Related to issues #1979 and #1980.
- Legacy-Id: 11581
2016-07-09 20:02:28 +00:00
Henrik Levkowetz 8b6d8c9f44 Replaced the hardcoded 'Area Director' approval role with a group-dependent list of approval roles. Fixes issue #1980.
- Legacy-Id: 11575
2016-07-09 16:59:50 +00:00
Henrik Levkowetz 1ddd6e7a09 Merged in [11530] from rjsparks@nostrum.com:
Adds a publisher to the digital preservation feed.
 - Legacy-Id: 11570
Note: SVN reference [11530] has been migrated to Git commit aafd1dc1ed
2016-07-08 13:17:02 +00:00