Commit graph

15416 commits

Author SHA1 Message Date
Jennifer Richards 21997b1cdf
chore: Pin urllib3 to <2 (#6321) 2023-09-15 10:40:24 -05:00
Robert Sparks 20f427e013
chore: remove unused view (#6304)
* chore: remove unused view

* chore: deflake

* chore: deflake
2023-09-14 17:10:26 -05:00
Jennifer Richards bc5c411673
ci: specify/parameterize rabbitmq version (#6308)
* ci: Specify / parameterize rabbitmq version

* ci: Fix syntax in build-mq-broker.yml
2023-09-14 16:17:04 -04:00
Tero Kivinen a3fb6a49a3
fix: add review team setting allowing reviewers to reject assignments past the deadline (#5418)
* Added a new review team setting
allow_reviewer_to_reject_after_deadline that will allow rejecting
review requests, even after the deadline is past. Also modified that
the secretary, or whoever manages the reviews is always allowed to
reject the review regardless of the deadline as he/she could change
the deadline anyways.

* Fixed but in view_reviews (wrong variable name), added more test
cases to the test_reviews.py for different reject cases.

* test: More thoroughly exercise assignment rejection

* chore: Renumber migration

* test: Unrelated user cannot reject assignments

---------

Co-authored-by: Jennifer Richards <jennifer@staff.ietf.org>
2023-09-14 11:48:28 -05:00
Nicolas Giard 4d6a2cf635
ci: always update baseline coverage when building release 2023-09-13 17:57:42 -04:00
Robert Sparks 3400d129a2
ci: merge release to main 2023-09-13 16:06:41 -05:00
Lars Eggert d3d2f0d35f
fix: Enable js functionality on sortable tables (#6301)
Fixes #6263

Also fix the non-js "untrack_document" page while I'm here.
2023-09-13 15:31:01 -05:00
depfu[bot] 5d00e7226b
chore(deps): update all npm dependencies for dev/coverage-action (#6290)
Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
2023-09-13 15:30:49 -05:00
depfu[bot] 351c6980e3
chore(deps): update all npm dependencies for playwright (#6289)
Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
2023-09-13 15:30:40 -05:00
depfu[bot] bcc8587a45
chore(deps): update all npm dependencies for dev/del-old-packages (#6288)
Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
2023-09-13 15:30:29 -05:00
dependabot[bot] 9b8969ce0b
chore(deps): bump actions/checkout from 3 to 4 (#6275)
Bumps [actions/checkout](https://github.com/actions/checkout) from 3 to 4.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](https://github.com/actions/checkout/compare/v3...v4)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-09-13 15:30:19 -05:00
depfu[bot] d3794c5f4e
chore(deps): update all Yarn dependencies (#6291)
* chore(deps): update all Yarn dependencies

* chore: fix yarn cache

---------

Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
Co-authored-by: NGPixel <github@ngpixel.com>
2023-09-13 15:29:57 -05:00
Jennifer Richards 69fd3a059e
fix: Validate string before calling int() (#6268) 2023-09-13 15:29:16 -05:00
Jennifer Richards 8bc4507def
feat: Give AD the action in ad-f-up doc state (#6272)
* refactor: Add helper class to compare tag changes

* feat: Give AD the action in ad-f-up state

* refactor: Remove unnecessary check

* refactor: Reorganize update_action_holders()

* refactor: Remove unnecessary guard

* test: Update test for new AD handling

* test: Update another test

* test: Test ad-f-up effect on action holders

---------

Co-authored-by: Robert Sparks <rjsparks@nostrum.com>
2023-09-12 09:44:33 -05:00
Jennifer Richards 18a1af22f8
fix: Reject nul characters in ipr search parameters (#6292)
* fix: Reject nul characters in ipr search parameters

Really ought to rework this as a form, but in the meantime
this should prevent 500s. Could probably reduce the number
of places we check the value.

* fix: Guard against absent parameters

* fix: Remove stray junk

* fix: Use correct response code (400, not 405)

* test: Test handling of null chars in IPR search

* refactor: Simplify branch statements

This helps my code validator see that "start" is
always set.
2023-09-12 08:32:16 -05:00
Paul Selkirk febdeff85f
feat: Capture that IPR disclosures are removed under the Objectively False IPR Disclosure Policy (#6231)
* feat: Capture that IPR disclosures are removed under the Objectively False IPR Disclosure Policy (#6088)

* chore: Move PUBLISH_IPR_STATES from settings_local to settings

* fix: Add migration for removed_objfalse in IprEventTypeName

* fix: De-conflict migration

* fix: De-conflict migration

* style: Move PUBLISH_IPR_STATES ahead of not-production block
2023-09-11 13:14:46 -05:00
Robert Sparks 6b6c881353
fix: construct double-submit test correctly (#6168)
* fix: construct double-submit test correctly

* chore: remove unused import
2023-09-08 13:02:18 -05:00
Robert Sparks 7f074bf37f
fix: avoid redirects in mailarchive links (#6282) 2023-09-07 10:40:20 -05:00
Paul Selkirk cd56d43736
fix: Allow secretariat to change the state of a dead draft (#6253)
* fix: Allow secretariat to change the state of a dead draft (#6051)

* refactor: Move the secretariat-can-edit-dead-state enablement to the template to limit side-effects.

* style: Correct whitespace to fully revert file

---------

Co-authored-by: Robert Sparks <rjsparks@nostrum.com>
2023-09-05 12:58:56 -05:00
Lars Eggert fb4002dbbd
fix: Don't show deferred I-Ds in AD's missing ballot list (#6162)
* fix: Don't show deferred I-Ds in AD's missing ballot list

Fixes #6152

* Address code review comments
2023-09-05 12:16:33 -05:00
Robert Sparks 3c1fc3c0f9
chore: use factory-boy 3.3 (#6269) 2023-09-05 09:54:30 -05:00
Nicolas Giard f54f04460f
ci: fix tests workflow naming 2023-09-01 18:07:35 -04:00
Nicolas Giard 1bc0c1515e
ci: fix build workflow 2023-09-01 18:03:12 -04:00
Nicolas Giard e29f714794
ci: extract tests jobs into reusable workflow 2023-09-01 17:56:40 -04:00
Robert Sparks 87f0781ff3
chore: make some old things kept for documentation a little safer (#6260)
* chore: make some old things kept for documentation a little safer

* fix: sh syntax
2023-09-01 14:34:49 -05:00
Robert Sparks f2dc32a310
chore: remove unused scipts from ietf/bin (#6259) 2023-09-01 14:31:23 -05:00
Robert Sparks b5bf6789da
chore: remove one shot iab artifact importers (#6258) 2023-08-31 17:14:18 -05:00
Robert Sparks c8c1ebdf12
chore: remove unnecessary .gitignore files (#6262) 2023-08-31 17:12:01 -05:00
Robert Sparks 32bb4ef54f
ci: merge main to release 2023-08-31 08:12:37 -05:00
Robert Sparks 555ed4e8ff
ci: merge release to main 2023-08-31 08:11:15 -05:00
Nicolas Giard b3a535429b
test: fix missing migrations on legacy tests on PRs 2023-08-30 13:40:45 -04:00
Robert Sparks 852f9d90b9
feat: move IAB appeals into the datatracker (#6229)
* feat: basic models for appeals

* fix: modify appeal model to point to group

* fix: explicit date on Appeal objects

* feat: appeals importing management command

* feat: display appeals

* feat: admin for appeals

* fix: limit admin contentype choices

* feat: tastypie resources

* feat: factories and tests

* chore: update group migration

* fix: remove charset from pdf content type

* test: unittest download_name

* fix: admin for new name
2023-08-29 14:07:30 -05:00
depfu[bot] 79e7145363
chore(deps): update all Yarn dependencies (#6227)
* chore(deps): update all Yarn dependencies

* ci: fix yarn cache

---------

Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
Co-authored-by: NGPixel <github@ngpixel.com>
2023-08-29 13:54:13 -05:00
dependabot[bot] 13d527fce1
chore(deps): bump ncipollo/release-action from 1.12.0 to 1.13.0 (#6228)
Bumps [ncipollo/release-action](https://github.com/ncipollo/release-action) from 1.12.0 to 1.13.0.
- [Release notes](https://github.com/ncipollo/release-action/releases)
- [Commits](https://github.com/ncipollo/release-action/compare/v1.12.0...v1.13.0)

---
updated-dependencies:
- dependency-name: ncipollo/release-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-08-28 14:41:48 -05:00
Jennifer Richards 7f8cbaa211
feat: Distinguish failed from not-applied checkers (#6220)
* feat: Distinguish failed from not-applied checkers

* refactor: Only return applied checks from latest_checks()

* refactor: Use latest_checks() in submission_status view

* chore: Fix incorrectly phrased comment

* test: Test submission check summary
2023-08-28 11:06:35 -05:00
depfu[bot] 5d08378b5a
chore(deps): update all npm dependencies for dev/del-old-packages (#6223)
Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
2023-08-28 09:03:09 -05:00
depfu[bot] cf94947af7
chore(deps): update all npm dependencies for dev/diff (#6225)
Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
2023-08-28 09:02:49 -05:00
depfu[bot] 8477e29e40
chore(deps): update all npm dependencies for dev/coverage-action (#6226)
Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
2023-08-28 09:02:36 -05:00
depfu[bot] 23d9fa3768
chore(deps): update all npm dependencies for playwright (#6224)
Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
2023-08-28 09:02:17 -05:00
Jennifer Richards 85927c083d
chore: Move IDSUBMIT_REPOSITORY_PATH for dev (#6218) 2023-08-26 16:14:02 -05:00
Jennifer Richards 6adead355d
fix: Improve status page for canceled submissions (#6221)
* fix: Show quieter alert for metadata error in canceled submission

* fix: Suppress metadata errors and show warning for canceled submissions

* style: Fix indentation in HTML

* fix: Give better notice of a processing error
2023-08-26 15:58:40 -05:00
Jennifer Richards c65cd20f0c
fix: Move submission files using shutil.move() (#6217)
* fix: Use shutil.move in move_files_to_repository()

* refactor: Use shutil.move in rename_submission_files()
2023-08-25 11:47:28 -05:00
Lars Eggert b304e07008
fix: Change color of error reporting link in menu bar (#6213)
Fixes #6179
2023-08-25 09:21:07 -05:00
Lars Eggert 16c250fa33
fix: Add theme switcher to document view (#6202)
* fix: Add theme switcher to document view

And reduce duplication in the page structure while I'm here.

Fixes #6200

* Fix tests
2023-08-24 13:46:03 -05:00
Jennifer Richards 2bcb2c04f9
chore: Fix (mostly harmless) quoting error (#6209) 2023-08-24 13:45:17 -05:00
Robert Sparks bce70e74bc
feat: import iab agendas from iab website (#6197)
* feat: import iab agendas from wiki

* chore: adjust command help text
2023-08-24 11:53:10 -05:00
Robert Sparks 2d523989a4
ci: merge main to release 2023-08-24 09:02:33 -05:00
Robert Sparks 95050f343c
ci: merge release to main 2023-08-24 08:22:03 -05:00
Lars Eggert 06d87b4097
fix: Reword I-D announcement emails to make first sentence more useful (#6193)
Fixes #6092
2023-08-24 08:19:30 -05:00
Lars Eggert a8e904400d
fix: Color agenda table row based on AD position (#6192)
Fixes #6184
2023-08-23 09:43:03 -05:00